Changed status to 'unread'. I'm not chatting.

Changed status to 'unread'. I'm not chatting.

The following still harbors undefined behavior, but I did not want to touch it
due to fears of breaking the zeoizer:

cipher-gcm.c:1144:7: runtime error: store to misaligned address...
cipher-gcm.c:1145:7: runtime error: store to misaligned address...
cipher-gcm.c:1146:7: runtime error: store to misaligned address...

wipememory (c->u_mode.gcm.tagiv, GCRY_GCM_BLOCK_LEN);  // Line 1144
wipememory (c->u_mode.gcm.aadlen, sizeof (c->u_mode.gcm.aadlen)); // Line 1145
wipememory (c->u_mode.gcm.datalen, sizeof (c->u_mode.gcm.datalen)); //

Line 1146

cipher-ccm.c:280:7: runtime error: store to misaligned address...

wipememory (c->u_mode.ccm.macbuf, 16);  // Line 280

Attached is the script I am using to acceptance test the suite. It requires
Clang 3.5 (Clang 3.5 recipe was provided with Bug 1872).

Added updated gost28147.c that removes the undefined behavior.

Added updated buf.help.h that removes the undefined behavior.

Updated status to 'unread'. I'm not chatting.

Attached is the script I am using to acceptance test the suite. It requires
Clang 3.5 (Clang 3.5 recipe was provided with Bug 1872).

Closing. My test script overwrote the symbols/optimization flags with the Clang
sanitziers.

Attached is the script I am using to acceptance test the suite. It requires
Clang 3.5 (Clang 3.5 recipe was provided with Bug 1872).

Changed status to 'unread'. I am not chatting.

Attached is the script I am using to acceptance test the suite. It requires
Clang 3.5 (Clang 3.5 recipe was provided with Bug 1872)

Attached is the script I am using to acceptance test the suite. It requires
Clang 3.5 (Clang 3.5 recipe was provided with Bug 1872).

27503==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 24 byte(s) in 1 object(s) allocated from:

#0 0x49f53b in malloc

/home/gpg-user/Clang-3.5/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:40:3

#1 0x53a9ca in _gcry_private_malloc

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/mpitests+0x53a9ca)

#2 0x4f2e00 in do_malloc

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/mpitests+0x4f2e00)

#3 0x4f289a in _gcry_malloc

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/mpitests+0x4f289a)

#4 0x4f5349 in _gcry_xmalloc

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/mpitests+0x4f5349)

#5 0xc7ade0 in _gcry_mpi_alloc

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/mpitests+0xc7ade0)

#6 0xc8c6ac in _gcry_mpi_set_ui

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/mpitests+0xc8c6ac)

#7 0x4c9d2b in gcry_mpi_set_ui

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/mpitests+0x4c9d2b)

#8 0x4bd295 in test_const_and_immutable

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/mpitests+0x4bd295)

#9 0x4bd0fb in main

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/mpitests+0x4bd0fb)

#10 0x2abeb5528ec4 in __libc_start_main

/build/buildd/eglibc-2.19/csu/libc-start.c:287

Indirect leak of 8 byte(s) in 1 object(s) allocated from:

#0 0x49f53b in malloc

/home/gpg-user/Clang-3.5/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:40:3

#1 0x53a9ca in _gcry_private_malloc

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/mpitests+0x53a9ca)

#2 0x4f2e00 in do_malloc

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/mpitests+0x4f2e00)

#3 0x4f289a in _gcry_malloc

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/mpitests+0x4f289a)

#4 0x4f5349 in _gcry_xmalloc

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/mpitests+0x4f5349)

#5 0xc7b998 in _gcry_mpi_alloc_limb_space

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/mpitests+0xc7b998)

#6 0xc7aef4 in _gcry_mpi_alloc

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/mpitests+0xc7aef4)

#7 0xc8c6ac in _gcry_mpi_set_ui

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/mpitests+0xc8c6ac)

#8 0x4c9d2b in gcry_mpi_set_ui

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/mpitests+0x4c9d2b)

#9 0x4bd295 in test_const_and_immutable

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/mpitests+0x4bd295)

#10 0x4bd0fb in main

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/mpitests+0x4bd0fb)

#11 0x2abeb5528ec4 in __libc_start_main

/build/buildd/eglibc-2.19/csu/libc-start.c:287

SUMMARY: AddressSanitizer: 32 byte(s) leaked in 2 allocation(s).
FAIL: mpitests
./tsexp: /lib/x86_64-linux-gnu/libgpg-error.so.0: no version information
available (required by ./tsexp)

27510==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 558 byte(s) in 1 object(s) allocated from:

#0 0x49f53b in malloc

/home/gpg-user/Clang-3.5/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:40:3

#1 0x548dfa in _gcry_private_malloc

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/tsexp+0x548dfa)

#2 0x501230 in do_malloc

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/tsexp+0x501230)

#3 0x500cca in _gcry_malloc

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/tsexp+0x500cca)

#4 0x50fffa in _gcry_sexp_find_token

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/tsexp+0x50fffa)

#5 0x4d62cb in gcry_sexp_find_token

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/tsexp+0x4d62cb)

#6 0x4cc1ad in bug_1594

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/tsexp+0x4cc1ad)

#7 0x4bcf62 in main

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/tsexp+0x4bcf62)

#8 0x2ad398718ec4 in __libc_start_main

/build/buildd/eglibc-2.19/csu/libc-start.c:287

Direct leak of 523 byte(s) in 1 object(s) allocated from:

#0 0x49f53b in malloc

/home/gpg-user/Clang-3.5/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:40:3

#1 0x548dfa in _gcry_private_malloc

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/tsexp+0x548dfa)

#2 0x501230 in do_malloc

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/tsexp+0x501230)

#3 0x500cca in _gcry_malloc

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/tsexp+0x500cca)

#4 0x50fffa in _gcry_sexp_find_token

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/tsexp+0x50fffa)

#5 0x4d62cb in gcry_sexp_find_token

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/tsexp+0x4d62cb)

#6 0x4cc295 in bug_1594

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/tsexp+0x4cc295)

#7 0x4bcf62 in main

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/tsexp+0x4bcf62)

#8 0x2ad398718ec4 in __libc_start_main

/build/buildd/eglibc-2.19/csu/libc-start.c:287

SUMMARY: AddressSanitizer: 1081 byte(s) leaked in 2 allocation(s).
FAIL: tsexp

27657==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 144560 byte(s) in 278 object(s) allocated from:

#0 0x49f690 in calloc

/home/gpg-user/Clang-3.5/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:56:3

#1 0x4c3020 in do_slope_benchmark

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/bench-slope+0x4c3020)

#2 0x4d2030 in cipher_bench_one

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/bench-slope+0x4d2030)

#3 0x4c6565 in _cipher_bench

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/bench-slope+0x4c6565)

#4 0x4c5d96 in cipher_bench

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/bench-slope+0x4c5d96)

#5 0x4cb103 in main

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/bench-slope+0x4cb103)

#6 0x2b9df664dec4 in __libc_start_main

/build/buildd/eglibc-2.19/csu/libc-start.c:287

Direct leak of 15080 byte(s) in 29 object(s) allocated from:

#0 0x49f690 in calloc

/home/gpg-user/Clang-3.5/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:56:3

#1 0x4c3020 in do_slope_benchmark

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/bench-slope+0x4c3020)

#2 0x4cc4ea in mac_bench_one

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/bench-slope+0x4cc4ea)

#3 0x4c86db in _mac_bench

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/bench-slope+0x4c86db)

#4 0x4c819a in mac_bench

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/bench-slope+0x4c819a)

#5 0x4cb0ef in main

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/bench-slope+0x4cb0ef)

#6 0x2b9df664dec4 in __libc_start_main

/build/buildd/eglibc-2.19/csu/libc-start.c:287

Direct leak of 9360 byte(s) in 18 object(s) allocated from:

#0 0x49f690 in calloc

/home/gpg-user/Clang-3.5/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:56:3

#1 0x4c3020 in do_slope_benchmark

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/bench-slope+0x4c3020)

#2 0x4cfd7a in hash_bench_one

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/bench-slope+0x4cfd7a)

#3 0x4c773b in _hash_bench

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/bench-slope+0x4c773b)

#4 0x4c6e0a in hash_bench

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/bench-slope+0x4c6e0a)

#5 0x4cb0db in main

(/home/gpg-user/gcrypt-2.0-sanitize/libgcrypt-1.6.3/tests/bench-slope+0x4cb0db)

#6 0x2b9df664dec4 in __libc_start_main

/build/buildd/eglibc-2.19/csu/libc-start.c:287

SUMMARY: AddressSanitizer: 169000 byte(s) leaked in 325 allocation(s).
FAIL: bench-slope

The following still harbors undefined behavior, but I did not want to touch it
due to fears of breaking the zeoizer:

cipher-gcm.c:1144:7: runtime error: store to misaligned address...
cipher-gcm.c:1145:7: runtime error: store to misaligned address...
cipher-gcm.c:1146:7: runtime error: store to misaligned address...

      wipememory (c->u_mode.gcm.tagiv, GCRY_GCM_BLOCK_LEN);
      wipememory (c->u_mode.gcm.aadlen, sizeof (c->u_mode.gcm.aadlen));
      wipememory (c->u_mode.gcm.datalen, sizeof (c->u_mode.gcm.datalen));

cipher-ccm.c:280:7: runtime error: store to misaligned address...

wipememory (c->u_mode.ccm.macbuf, 16);

Updated bufhelp that corrects the undefined behavior.

Updated gost28147 that corrects the undefined behavior.

And:

$ addr2line -e libgcrypt-1.6.3/tests/version 0x51d8c6
hwf-x86.c:?

And:

$ gdb
(gdb) file libgcrypt-1.6.3/tests/version
Reading symbols from libgcrypt-1.6.3/tests/version...done.
(gdb) info symbol 0x51d8c6
get_xgetbv + 294 in section .text
(gdb) info *0x51d8c6
Undefined info command: "*0x51d8c6". Try "help info".
(gdb) info line *0x51d8c6
No line number information available for address 0x51d8c6 <get_xgetbv+294>

Related bug: "Test suite built without symbols",
T1873.

Attached is the recipe I am using to build Clang 3.5.

It appears --disable-static is the culprit.

You are right. Due to the first condition the second evaluates to (0==1). I
need to check whether thsi used inside libgcrypt.

What a pity that I released 1.6.3 without noticing this bug. ("typo" falsely
made be believe a doc problem). Sorry.

Thanks for testing

Yes it works fine, sorry I did not respond earlier. I'm using your patch since
you published it:
https://github.com/SynoCommunity/spksrc/blob/develop/cross/libgcrypt/patches/001-asm-allow-building-x86-and-amd64-using-old-compilers.patch

I'm running Ubuntu 14.10 on x84_64.

The toolchain is... whatever it is that Linuxbrew uses?

Here is a gist with significantly more detail (stacktraces, logs, configure
output, etc.): https://gist.github.com/anonymous/38a7178239568f946cd2

Please describe the problem and here and not just on some external tracker. Do
not forget to describe platform and toolchain used. Thanks.

Fixed for 1.7 with commit 8174723.

Path is in the repo so it will go into 1.7. Might have also been backported to 1.6.

This has been fixed for 1.7. It will not be fixed for 1.5.

The file has been completely rewritten for 1.6 and thus there is nothing to fix
for the current version. Thanks anyway for this report.

Sorry for the long delay. Fixed with commit 8c5eee5 for 1.7.

I won't backport it to 1.6 because the leak is only triggered by wrong usage of
the functions.

Not a problem with 1.6.2
thank you