Page MenuHome GnuPG
Feed Advanced Search

Jul 25 2017

gniibe closed T3262: Longer URL (possibly, login) should be supported as Resolved.

Fixed in rG69614d55018d: scd: Support longer data length for special DOs for v3 card..

Jul 25 2017, 6:46 AM · scd, gnupg (gpg21)
gniibe committed rGd40b4a41a8d6: dirmngr: Add annotation for fallthrough. (authored by gniibe).
dirmngr: Add annotation for fallthrough.
Jul 25 2017, 4:54 AM
gniibe created T3299: scd: support key algorithm attribute change UI.
Jul 25 2017, 1:26 AM · gnupg (gpg23)

Jul 24 2017

gniibe committed rGade4b2744c84: dirmngr: More minor fix. (authored by gniibe).
dirmngr: More minor fix.
Jul 24 2017, 9:11 AM
gniibe committed rG45e40487fb7b: scd: Use unsigned int for fields. (authored by gniibe).
scd: Use unsigned int for fields.
Jul 24 2017, 9:11 AM
gniibe committed rG789401e9557d: dirmngr: More minor fixes. (authored by gniibe).
dirmngr: More minor fixes.
Jul 24 2017, 8:36 AM
gniibe committed rG274602820cfb: dirmngr: Minor fix for Windows. (authored by gniibe).
dirmngr: Minor fix for Windows.
Jul 24 2017, 8:32 AM
gniibe committed rG328fca187253: agent: Minor fix for Windows. (authored by gniibe).
agent: Minor fix for Windows.
Jul 24 2017, 8:32 AM

Jul 21 2017

gniibe committed rGd8a55da715ce: scd: Fix SEGV in CCID driver. (authored by gniibe).
scd: Fix SEGV in CCID driver.
Jul 21 2017, 6:35 AM
gniibe committed rGa76b6cf9709c: g10: Don't limit at the frontend side for card capability. (authored by gniibe).
g10: Don't limit at the frontend side for card capability.
Jul 21 2017, 6:35 AM
gniibe committed rG892e86b0dc69: scd: Add debug message for v3 card. (authored by gniibe).
scd: Add debug message for v3 card.
Jul 21 2017, 6:35 AM

Jul 20 2017

gniibe committed rG69614d55018d: scd: Support longer data length for special DOs for v3 card. (authored by gniibe).
scd: Support longer data length for special DOs for v3 card.
Jul 20 2017, 10:33 AM
gniibe committed rG84146b3ec449: common: logstream fix. (authored by gniibe).
common: logstream fix.
Jul 20 2017, 9:39 AM
gniibe committed rGcc12cf386b62: dnsmngr: Fix use of CPP. (authored by gniibe).
dnsmngr: Fix use of CPP.
Jul 20 2017, 6:22 AM

Jul 19 2017

gniibe closed T3285: building libgcrypt 1.8.0 results in error: stray '\357' in program as Resolved.

Fixed in rC1d8e4c2c3a7d: Remove byte order mark.

Jul 19 2017, 7:31 AM · Bug Report
gniibe committed rC1d8e4c2c3a7d: Remove byte order mark. (authored by gniibe).
Remove byte order mark.
Jul 19 2017, 7:29 AM
gniibe added a comment to T3285: building libgcrypt 1.8.0 results in error: stray '\357' in program.

Thank you for the report. I think that there is a https://en.wikipedia.org/wiki/Byte_order_mark in those files.

Jul 19 2017, 7:22 AM · Bug Report
gniibe committed rG99791184ac4c: gpgconf: Make vars read-only explicitly. (authored by gniibe).
gpgconf: Make vars read-only explicitly.
Jul 19 2017, 6:46 AM
gniibe committed rGfa63db89f958: Fix usage of ARGPARSE_OPTS. (authored by gniibe).
Fix usage of ARGPARSE_OPTS.
Jul 19 2017, 6:46 AM
gniibe created T3286: card: Yubikey factory-reset failure .
Jul 19 2017, 12:59 AM · gnupg (gpg22), scd

Jul 14 2017

gniibe added a comment to T3269: (Constant-time) modular reduction.

https://patents.stackexchange.com/questions/5766/is-an-expired-patent-in-the-public-domain

Jul 14 2017, 8:40 AM · libgcrypt
gniibe added a comment to T3269: (Constant-time) modular reduction.

I found US patent which is expired due to fee: https://patents.google.com/patent/US7080109B2/en
The technique is described in : https://koclab.cs.ucsb.edu/docs/koc/j56.pdf
This is related paper: https://koclab.cs.ucsb.edu/docs/koc/j47.pdf

Jul 14 2017, 8:26 AM · libgcrypt
gniibe added a comment to T3269: (Constant-time) modular reduction.

Intel has patent application for folding technique for Montgomery reduction: US8392494
which is described in this paper: https://www.cse.buffalo.edu/srds2009/escs2009_submission_Gopal.pdf

Jul 14 2017, 4:44 AM · libgcrypt
gniibe renamed T3269: (Constant-time) modular reduction from (Constant-time) Barret modular reduction to (Constant-time) modular reduction.
Jul 14 2017, 4:42 AM · libgcrypt

Jul 13 2017

marcus awarded rPTH4fae99976c31: Fix busy_wait_for. a Manufacturing Defect? token.
Jul 13 2017, 1:41 AM

Jul 11 2017

gniibe added a comment to T3269: (Constant-time) modular reduction.

Intel has patent application for folding technique for Barret reduction: US20070297601
and it is granted as: US8229109

Jul 11 2017, 9:54 AM · libgcrypt
gniibe created T3269: (Constant-time) modular reduction.
Jul 11 2017, 8:56 AM · libgcrypt
gniibe claimed T3264: Possible RSA improvement.

The part of using Simultaneous Multiple Exponentiation (SME) for RSA is not patented, I think.
So, let me consider with SME.

Jul 11 2017, 3:47 AM · libgcrypt
gniibe created T3268: GnuPG 1.4.22 release.
Jul 11 2017, 1:43 AM · gnupg (gpg14)

Jul 10 2017

gniibe added a comment to T3264: Possible RSA improvement.

Another area would be faster (constant time) Barrett reduction.

Jul 10 2017, 5:16 AM · libgcrypt
gniibe added a comment to T3264: Possible RSA improvement.

In search of algorithm, I found this slide:
http://www1.spms.ntu.edu.sg/~ccrg/documents/chienning-multiexponentiation.pdf

Jul 10 2017, 2:29 AM · libgcrypt
gniibe created T3264: Possible RSA improvement.
Jul 10 2017, 2:27 AM · libgcrypt

Jul 7 2017

gniibe accepted D438: rsa: Add exponent blinding..
Jul 7 2017, 3:01 PM
gniibe added a comment to D438: rsa: Add exponent blinding..

Applied as rG8fd9f72e1b2e: rsa: Add exponent blinding..
Needed rG994d5b707559: rsa: Allow different build directory. for different build directory.
And added rG1b1f44846b5f: rsa: Reduce secmem pressure. to lower the secmem pressure.

Jul 7 2017, 3:00 PM
gniibe committed rG6b4abf1d491d: gpg: Fix memory leak. (authored by gniibe).
gpg: Fix memory leak.
Jul 7 2017, 2:57 PM
gniibe committed rG1b1f44846b5f: rsa: Reduce secmem pressure. (authored by gniibe).
rsa: Reduce secmem pressure.
Jul 7 2017, 2:57 PM
gniibe committed rG994d5b707559: rsa: Allow different build directory. (authored by gniibe).
rsa: Allow different build directory.
Jul 7 2017, 2:57 PM
gniibe committed rG8fd9f72e1b2e: rsa: Add exponent blinding. (authored by marcus).
rsa: Add exponent blinding.
Jul 7 2017, 2:57 PM
gniibe added a comment to D438: rsa: Add exponent blinding..

OK, I'm going to apply this patch to gpg1.4 and then, to modify a bit to lower the secmem pressure.

Jul 7 2017, 1:55 PM
gniibe added a comment to D438: rsa: Add exponent blinding..

(1) is done in rG12029f83fd0a: mpi: Same computation for square and multiply for mpi_pow..
(3) is partially done.

Jul 7 2017, 8:16 AM
gniibe committed rG12029f83fd0a: mpi: Same computation for square and multiply for mpi_pow. (authored by gniibe).
mpi: Same computation for square and multiply for mpi_pow.
Jul 7 2017, 8:13 AM
gniibe committed rG554ded485475: mpi: Minor fix for mpi_pow. (authored by gniibe).
mpi: Minor fix for mpi_pow.
Jul 7 2017, 8:13 AM
gniibe committed rGb38f4489f75e: mpi: Simplify mpi_powm. (authored by gniibe).
mpi: Simplify mpi_powm.
Jul 7 2017, 8:13 AM
gniibe committed rC61b0f52c1cc8: mpi: Minor fix of mpi_pow. (authored by gniibe).
mpi: Minor fix of mpi_pow.
Jul 7 2017, 7:57 AM
gniibe committed rC66ed4d537898: mpi: Fix mpi_pow alternative implementation. (authored by gniibe).
mpi: Fix mpi_pow alternative implementation.
Jul 7 2017, 5:02 AM
gniibe committed rC619ebae98478: Fix mpi_pow alternative implementation. (authored by gniibe).
Fix mpi_pow alternative implementation.
Jul 7 2017, 5:02 AM
gniibe added a comment to D438: rsa: Add exponent blinding..

For your reference, this is the BSI document URL: https://www.bsi.bund.de/SharedDocs/Downloads/DE/BSI/Zertifizierung/Interpretationen/AIS_46_BSI_guidelines_SCA_RSA_V1_0_e_pdf.html

Jul 7 2017, 1:59 AM
gniibe created T3262: Longer URL (possibly, login) should be supported.
Jul 7 2017, 1:43 AM · scd, gnupg (gpg21)
gniibe added a comment to D438: rsa: Add exponent blinding..

Comments (and complaints to academic paper :-) were at jabber, yesterday. My point is that their claims are for their community to be accepted as a good paper, I have my own view.

Jul 7 2017, 1:39 AM

Jul 5 2017

gniibe added a comment to T3247: SIGILL in prepare_macpads() at md.c:681.

I can replicate the issue on my system.
It is not the line 681, actually.

Jul 5 2017, 4:07 AM · clang, Ubuntu, libgcrypt, Bug Report

Jul 4 2017

gniibe claimed T3247: SIGILL in prepare_macpads() at md.c:681.

I think that the problem is in your usage with your tool. Please have a look at md_open function in cipher/md.c.
This bug is not the one in libgcrypt, but in the compiler.

Jul 4 2017, 6:27 AM · clang, Ubuntu, libgcrypt, Bug Report
gniibe closed T3246: md5.c:119:3: runtime error: unsigned integer overflow: 2612846078 + 3614090360 cannot be represented in type 'unsigned int' as Invalid.

Same argument can apply to MD5. See T3249: sha256.c:265:3: runtime error: unsigned integer overflow: 4084723048 + 1633837952 cannot be represented in type 'unsigned int' of SHA2.

Jul 4 2017, 5:10 AM · clang, Ubuntu, libgcrypt, Bug Report
gniibe closed T3250: random-csprng.c:1070:16: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'size_t' (aka 'unsigned long') as Invalid.

See T3245: cipher-gcm-intel-pclmul.c:418:17: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'size_t' (aka 'unsigned long').

Jul 4 2017, 5:08 AM · clang, Ubuntu, libgcrypt, Bug Report
gniibe closed T3245: cipher-gcm-intel-pclmul.c:418:17: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'size_t' (aka 'unsigned long') as Invalid.

See T3248: mpiutil.c:501:37: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'unsigned long' for unsigned integer overflow.

Jul 4 2017, 5:06 AM · clang, Ubuntu, libgcrypt, Bug Report
gniibe closed T3248: mpiutil.c:501:37: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'unsigned long' as Invalid.

It is intentionally used.
And in the C programming language, it is defined that unsigned integer never overflows (it is computed as modulo 2).

Jul 4 2017, 4:58 AM · clang, Ubuntu, libgcrypt, Bug Report
gniibe closed T3251: sha512.c:342:25: runtime error: unsigned integer overflow: 17296268247117069635 + 2271443192277056827 cannot be represented in type 'unsigned long' as Invalid.

See T3249: sha256.c:265:3: runtime error: unsigned integer overflow: 4084723048 + 1633837952 cannot be represented in type 'unsigned int'.

Jul 4 2017, 4:54 AM · clang, Ubuntu, libgcrypt, Bug Report
gniibe closed T3249: sha256.c:265:3: runtime error: unsigned integer overflow: 4084723048 + 1633837952 cannot be represented in type 'unsigned int' as Invalid.

In the SHA2 computation, it is defined that addition is calculated modulo 2^32.
And in the C programming language, "unsigned integer" operation never overflows (it is defined as modulo).

Jul 4 2017, 4:52 AM · Bug Report
gniibe closed T3239: selecting openpgp failed: Operation not supported by device as Resolved.

OK, closed.

Jul 4 2017, 4:31 AM · Bug Report
gniibe committed rC5feaf1cc8f22: mpi: Fix mpi_set_secure. (authored by gniibe).
mpi: Fix mpi_set_secure.
Jul 4 2017, 2:46 AM
gniibe committed rCa195d7346a80: mpi: Fix mpi_set_secure. (authored by gniibe).
mpi: Fix mpi_set_secure.
Jul 4 2017, 2:46 AM

Jul 1 2017

gniibe triaged T3239: selecting openpgp failed: Operation not supported by device as Normal priority.
Jul 1 2017, 2:40 AM · Bug Report
gniibe claimed T3239: selecting openpgp failed: Operation not supported by device.

"gpg: selecting openpgp failed: Operation not supported by device" means that gpg tried to access smartcard (expecting OpenPGP card), but it failed.

Jul 1 2017, 1:45 AM · Bug Report

Jun 29 2017

gniibe committed rC312101e1f266: rsa: More fix. (authored by gniibe).
rsa: More fix.
Jun 29 2017, 5:41 AM
gniibe committed rCaff5fd0f2650: rsa: Fix exponent blinding. (authored by gniibe).
rsa: Fix exponent blinding.
Jun 29 2017, 5:38 AM
gniibe committed rCa9f612def801: rsa: Add exponent blinding. (authored by gniibe).
rsa: Add exponent blinding.
Jun 29 2017, 4:50 AM
gniibe committed rC8725c99ffa41: rsa: Add exponent blinding. (authored by gniibe).
rsa: Add exponent blinding.
Jun 29 2017, 4:46 AM
gniibe committed rC0e6788517eac: Same computation for square and multiply. (authored by gniibe).
Same computation for square and multiply.
Jun 29 2017, 3:19 AM

Jun 28 2017

gniibe committed rC78130828e9a1: Same computation for square and multiply. (authored by gniibe).
Same computation for square and multiply.
Jun 28 2017, 12:02 PM

Jun 25 2017

gniibe committed rCfbd10abc0574: mpi: Simplify mpi_powm. (authored by gniibe).
mpi: Simplify mpi_powm.
Jun 25 2017, 7:17 AM

Jun 24 2017

gniibe committed rC4b6351356715: Same computation for square and multiply. (authored by gniibe).
Same computation for square and multiply.
Jun 24 2017, 1:53 PM

Jun 19 2017

gniibe committed rD54f8c6f024c7: campaign,ja: Update Japanese Translation. (authored by gniibe).
campaign,ja: Update Japanese Translation.
Jun 19 2017, 9:25 AM

Jun 9 2017

gniibe created T3201: KDF DO support enhancement.
Jun 9 2017, 6:26 AM · gnupg (gpg22), scd
gniibe removed a project from T3152: KDF DO support in OpenPGP card: g10code Sprint (KW 23).

Specification is finished.

Jun 9 2017, 6:24 AM · scd
gniibe added a comment to T3152: KDF DO support in OpenPGP card.

bit 0 (in smartcard context, we say b1 as it starts from 1) of Extended Capabilities specifies if KDF-DO is supported.

Jun 9 2017, 4:57 AM · scd
gniibe added a comment to T3152: KDF DO support in OpenPGP card.

Tag for KDF-DO is assigned as:

Jun 9 2017, 4:32 AM · scd

Jun 8 2017

gniibe abandoned D431: secmem fix.
Jun 8 2017, 6:39 AM · libgcrypt

Jun 5 2017

gniibe triaged T3192: gpg returns with non-zero exit status after successful run when using disable-scdaemon as Normal priority.
Jun 5 2017, 3:46 AM · gnupg (gpg21), Bug Report
gniibe added a project to T3192: gpg returns with non-zero exit status after successful run when using disable-scdaemon: gnupg (gpg21).
Jun 5 2017, 3:46 AM · gnupg (gpg21), Bug Report
gniibe added a comment to T3192: gpg returns with non-zero exit status after successful run when using disable-scdaemon.

This bug was introduced when I tried to handle T1983: gpg2 prefers missing secret key to available key on card. In master, this bug was fixed in: rGfbb2259d22e6: g10: Fix default-key selection for signing, possibly by card.

Jun 5 2017, 3:45 AM · gnupg (gpg21), Bug Report
gniibe added a subtask for T1983: gpg2 prefers missing secret key to available key on card: T3192: gpg returns with non-zero exit status after successful run when using disable-scdaemon.
Jun 5 2017, 3:44 AM · Bug Report, gnupg
gniibe added a parent task for T3192: gpg returns with non-zero exit status after successful run when using disable-scdaemon: T1983: gpg2 prefers missing secret key to available key on card.
Jun 5 2017, 3:44 AM · gnupg (gpg21), Bug Report
gniibe claimed T3192: gpg returns with non-zero exit status after successful run when using disable-scdaemon.
Jun 5 2017, 2:04 AM · gnupg (gpg21), Bug Report

Jun 2 2017

gniibe added a comment to D431: secmem fix.

Applied in rCe0958debe1a7: secmem: Fix SEGV and stat calculation..

Jun 2 2017, 3:40 AM · libgcrypt
gniibe committed rCe0958debe1a7: secmem: Fix SEGV and stat calculation. (authored by gniibe).
secmem: Fix SEGV and stat calculation.
Jun 2 2017, 3:39 AM
gniibe added a comment to D431: secmem fix.

Here is a test case:


It doesn't dump core on my x86 GNU/Linux, but we can see invalid stats.
Running under valgrind, it dumps core.

Jun 2 2017, 3:31 AM · libgcrypt
gniibe added a comment to T3027: gpg-agent crash on macOS Sierra triggerd by ssh.

libgcrypt secmem fix is not that in hurry, I think. nPTh bug for macOS sounds more severe.

Jun 2 2017, 12:37 AM · Bug Report, gpgagent, gnupg

Jun 1 2017

gniibe added a comment to T3027: gpg-agent crash on macOS Sierra triggerd by ssh.

I managed to replicate this issue by preparing artificial nPth on x86 GNU/Linux.

Jun 1 2017, 2:16 PM · Bug Report, gpgagent, gnupg
gniibe created D431: secmem fix.
Jun 1 2017, 2:13 PM · libgcrypt
gniibe added a project to T3190: Recursive call of pinentry: gnupg.
Jun 1 2017, 6:17 AM · gnupg (gpg22)
gniibe created T3190: Recursive call of pinentry.
Jun 1 2017, 6:16 AM · gnupg (gpg22)
gniibe added a comment to T3027: gpg-agent crash on macOS Sierra triggerd by ssh.

I fixed a bug in nPth: rPTH4fae99976c31: Fix busy_wait_for.
During this debug, I also found a bug and fixed in libassuan: rA62f3123d3877: Use gpgrt_free to release memory allocated by gpgrt_asprintf.
Also, I fixed two related bug in GnuPG:
rGc03e0eb01dc4: agent: Fix error from do_encryption.
rG996544626ea4: agent: Fix memory leaks.

Jun 1 2017, 5:02 AM · Bug Report, gpgagent, gnupg
gniibe committed rPTH4fae99976c31: Fix busy_wait_for. (authored by gniibe).
Fix busy_wait_for.
Jun 1 2017, 4:51 AM

May 31 2017

gniibe committed rA62f3123d3877: Use gpgrt_free to release memory allocated by gpgrt_asprintf. (authored by gniibe).
Use gpgrt_free to release memory allocated by gpgrt_asprintf.
May 31 2017, 1:22 PM
gniibe created T3189: secmem routines should be in libgpg-error as gpgrt_*.
May 31 2017, 1:10 PM · gpgrt, libgcrypt
gniibe committed rGc03e0eb01dc4: agent: Fix error from do_encryption. (authored by gniibe).
agent: Fix error from do_encryption.
May 31 2017, 11:46 AM
gniibe committed rG8defb21d3441: scd: Fix error code on failure at usb_init. (authored by gniibe).
scd: Fix error code on failure at usb_init.
May 31 2017, 3:06 AM
gniibe committed rG5c33649782bf: scd: Handle a failure of libusb_init. (authored by gniibe).
scd: Handle a failure of libusb_init.
May 31 2017, 2:51 AM

May 30 2017

gniibe closed Unknown Object (Maniphest Task), a subtask of T3075: Campaign 2017, as Resolved.
May 30 2017, 1:59 PM · g10code, Verein
gniibe committed rE1e7203515be0: Fix memory leak for estream. (authored by gniibe).
Fix memory leak for estream.
May 30 2017, 1:56 PM
gniibe committed rG996544626ea4: agent: Fix memory leaks. (authored by gniibe).
agent: Fix memory leaks.
May 30 2017, 7:19 AM