Page MenuHome GnuPG
Feed Advanced Search

Feb 28 2018

werner added a comment to T3774: Failure to decrypt AEAD-encrypted files in some rare cases.

I found another encoding error which renders the test data uploaded yesterday useless: Here is a bogus AEAD packet:

00000040  d4 84 01 07 01 00 6c 34  7c 37 83 24 2a 11 bc 1c  
00000050  bd 1a 76 da 93 8a
              [start chunk] 32 cd  80 a5 8e db 3a 7d 4a 40  
00000060  c5 0d 82 01 8d 64 7f 65  cd ca 58 d0 e7 db 3b 5e  
00000070  89 d9 1b c8 d9 93 1a 37  3c 0e a5 8f 4b 0d 9f db  
00000080  34 56 c8 f1 e9 b7 f5 0b  d2 53 4f 6c fd f8 e9 16  
00000090  cd a4 ae f6 7f 65
                      [tag] ef 5f  96 af 62 70 f4 30 27 37  
000000a0  68 61 95 0a fb 23
                [extra tag] a6 66  75 7a 47 bb 57 d3 da 5a  
000000b0  4d d1 c2 2f 43 39
                [final tag] cd 22  91 16 1d 92 17 1f f2 cf  
000000c0  0f c9 11 56 d0 a9
Feb 28 2018, 10:08 AM · gnupg, Bug Report
werner committed rGf2c09203b98b: gpg: Avoid writing a zero length last chunk in AEAD mode. (authored by werner).
gpg: Avoid writing a zero length last chunk in AEAD mode.
Feb 28 2018, 9:51 AM
werner committed rG047506a03d21: gpg: Merge two functions in cipher-aead.c (authored by werner).
gpg: Merge two functions in cipher-aead.c
Feb 28 2018, 9:51 AM
werner added a project to T3815: tests fail in 2021: qt.
Feb 28 2018, 8:34 AM · qt, Python, gpgme, Bug Report
werner added a comment to T3065: dirmngr: proxy issues with dnslookup causing failure.

The stripped down log is

Feb 28 2018, 8:30 AM · gnupg (gpg22), dns, dirmngr

Feb 27 2018

werner triaged T3816: please expose "change-usage" subcommand for --edit-key as High priority.
Feb 27 2018, 9:50 PM · gnupg (gpg22), Feature Request
werner added a comment to T3774: Failure to decrypt AEAD-encrypted files in some rare cases.


is a simple script to check that the encrypted files in the above tarball. How to use:

cd gnupg
mkdir test-aead
cd test-aead
tar xzf gnupg-aead-enc-files-20180227.tar.gz
sh checktestdata.sh gnupg-aead-enc-files-20180227/*
Feb 27 2018, 9:37 PM · gnupg, Bug Report
werner added a comment to T3774: Failure to decrypt AEAD-encrypted files in some rare cases.

(Some files are incorrect)

Feb 27 2018, 9:35 PM · gnupg, Bug Report
werner added a comment to T3774: Failure to decrypt AEAD-encrypted files in some rare cases.

password is "abc". I have some comments in the commit logs.

Feb 27 2018, 9:25 PM · gnupg, Bug Report
werner added projects to T3815: tests fail in 2021: gpgme, Python.

Can you please show the output of these failing tests? I assume you are running on a 64 bit platform.

Feb 27 2018, 9:23 PM · qt, Python, gpgme, Bug Report
werner committed rG618b86325f77: gpg: Simplify the AEAD decryption function. (authored by werner).
gpg: Simplify the AEAD decryption function.
Feb 27 2018, 9:18 PM
werner committed rGad989373f1a4: gpg: Factor common code out of the AEAD decryption function. (authored by werner).
gpg: Factor common code out of the AEAD decryption function.
Feb 27 2018, 9:18 PM
werner edited projects for T3065: dirmngr: proxy issues with dnslookup causing failure, added: dirmngr, dns; removed Info Needed.
Feb 27 2018, 3:45 PM · gnupg (gpg22), dns, dirmngr
werner added a comment to T3065: dirmngr: proxy issues with dnslookup causing failure.

@Ainahir thanks for the info. However, your problem might be different because you are on Windows and not on Linux.
Please use for dirmngr --debug=ipc,dns instead of --debug-level=guru

Feb 27 2018, 3:44 PM · gnupg (gpg22), dns, dirmngr
werner added a comment to T3774: Failure to decrypt AEAD-encrypted files in some rare cases.

Here is a file

created using the fixed gpg version. I have a lot more of these test files; I can tar them up and provide them here. They are too lareg to go into the repo or the tarball. The files are all uncompressed and consists of ~ characters.

Feb 27 2018, 2:51 PM · gnupg, Bug Report
werner committed rGb703ba725dad: gpg: Rename cipher.c to cipher-cfb.c (authored by werner).
gpg: Rename cipher.c to cipher-cfb.c
Feb 27 2018, 2:11 PM
werner committed rGebb0fcf6e0bd: gpg: Fix corner cases in AEAD encryption. (authored by werner).
gpg: Fix corner cases in AEAD encryption.
Feb 27 2018, 2:11 PM
werner added a comment to rM59fe3f26c1ca: core: Support non-thread-safe getenv..

The problem is still that other - non-gpgme threads - can still use getenv and friends without us noticing that. But I see no solution for this. In any case this code is the best we can do.

Feb 27 2018, 11:18 AM

Feb 26 2018

werner added a member for Verein: MuckiSG.
Feb 26 2018, 3:07 PM
werner created T3811: New website design.
Feb 26 2018, 12:14 PM · gpgweb, Verein
werner added members for Verein: gouttegd, guilhem, syscomet.
Feb 26 2018, 12:07 PM
werner added a member for Verein: bernhard.
Feb 26 2018, 12:05 PM
werner removed a member for Verein: marcus.
Feb 26 2018, 12:04 PM
werner added a member for Verein: gollo.
Feb 26 2018, 12:04 PM
werner closed T3075: Campaign 2017 as Wontfix.
Feb 26 2018, 12:04 PM · g10code, Verein
werner closed T3335: Find a new Treasurer for the Verein as Resolved.

Hello Andre.

Feb 26 2018, 12:03 PM · Verein
werner changed the edit policy for T3810: UI workshop.
Feb 26 2018, 12:02 PM · Documentation, gnupg, UI, Verein
werner set the color for UI to Orange.
Feb 26 2018, 11:57 AM
werner triaged T3808: Unable to safely delete IDs with shared secret keys as Normal priority.
Feb 26 2018, 9:48 AM · Feature Request
werner added a comment to T3808: Unable to safely delete IDs with shared secret keys.

GnuPG stores key in a protocol independent manner. This allows to use the same key material for ssh, X.509 and OpenPGP - if you want that. A side effect is that it is possible to use the same key material also for several subkeys. Note that, unless you use --yes, gpg-agent will issue an additional prompt to request confirmation of secret key deletion. It even will show a warning if gpg-agent knows that the key is used for ssh. The thing here is that gpg-agent is picky about accidentely deleting a secret key. In general this is better than the other way.

Feb 26 2018, 9:03 AM · Feature Request

Feb 25 2018

werner committed rD14956d3f716f: verein: Make the frontpage more serious and link the beitragsordnung. (authored by werner).
verein: Make the frontpage more serious and link the beitragsordnung.
Feb 25 2018, 8:32 PM

Feb 24 2018

werner triaged T3807: Mandatory OpenPGP Primary Key Binding Signature (sigclass 0x19) as Low priority.
Feb 24 2018, 12:16 PM · Documentation, gnupg

Feb 23 2018

werner added a comment to T3774: Failure to decrypt AEAD-encrypted files in some rare cases.

Can you help me and tell me the AD for the last and the final chunk?
My current values are:

Feb 23 2018, 5:13 PM · gnupg, Bug Report
werner added projects to T3806: error accessing ldaps key server (TLS vs. STARTTLS): dirmngr, LDAP.
Feb 23 2018, 11:06 AM · Too Old, LDAP, dirmngr, Bug Report
werner set the icon for LDAP to Tag.
Feb 23 2018, 11:05 AM
werner triaged T3805: Poor style: Redundant condition * 5 as Wishlist priority.

I will eventually look at this. However, sometimes the reason for such conditions can be documentation purposes. Thanks for pointing out.

Feb 23 2018, 11:03 AM · Bug Report
werner closed T3795: Failure to decrypt file, encrypted with multiple passwords as Wontfix.

With AEAD we can immediately check whether the correct passphrase is used. With CFB we can't do that and thus the checking is delayed until we can do the bulk encryption using the session key. At that point it is too late to check for other keys - well we could record that all and try again but that would make the code pretty complicate.

Feb 23 2018, 11:00 AM · Bug Report, gnupg
werner committed rGcbc7bacf2ff9: gpg: Try to mitigate the problem of wrong CFB symkey passphrases. (authored by werner).
gpg: Try to mitigate the problem of wrong CFB symkey passphrases.
Feb 23 2018, 10:56 AM
werner added a comment to rGcf006cbf7338: doc: Clarify -export-secret-key-p12.

It was fixed with commit 641aae78 _after_ 2.2.5. Will eventually be merged into master.

Feb 23 2018, 10:08 AM

Feb 22 2018

werner closed T3331: gpg: Address family not supported by protocol if kernel doesn't support ipv6 as Resolved.

Will go into 2.2.6

Feb 22 2018, 8:55 PM · gnupg (gpg22), dirmngr, Bug Report
werner committed rGecfc4db3a2f8: dirmngr: Handle failures related to missing IPv6 gracefully (authored by mgorny).
dirmngr: Handle failures related to missing IPv6 gracefully
Feb 22 2018, 8:54 PM
werner added a project to T3331: gpg: Address family not supported by protocol if kernel doesn't support ipv6: gnupg (gpg22).
Feb 22 2018, 8:42 PM · gnupg (gpg22), dirmngr, Bug Report
werner committed rD94c69b9eee9d: web: Release info for 2.2.5 and move old news entries (authored by werner).
web: Release info for 2.2.5 and move old news entries
Feb 22 2018, 7:16 PM
werner committed rG641aae783e46: doc: Fix recently introduced typo in gpgsm.texi. (authored by werner).
doc: Fix recently introduced typo in gpgsm.texi.
Feb 22 2018, 4:45 PM
werner committed rG7853190cfe29: build: Update swdb tags and include release info from 2.2.5 (authored by werner).
build: Update swdb tags and include release info from 2.2.5
Feb 22 2018, 4:43 PM
werner committed rG20539ea5cad1: Merge branch 'STABLE-BRANCH-2-2' (authored by werner).
Merge branch 'STABLE-BRANCH-2-2'
Feb 22 2018, 4:43 PM
werner committed rDd658ab86b59a: swdb: Release gnupg 2.2.5 (authored by werner).
swdb: Release gnupg 2.2.5
Feb 22 2018, 4:25 PM
werner committed rG59ee87aae874: Post release updates. (authored by werner).
Post release updates.
Feb 22 2018, 4:17 PM
werner committed rG9581a65ccc10: Release 2.2.5 (authored by werner).
Release 2.2.5
Feb 22 2018, 4:17 PM
werner committed rGb375d50ee4ce: gpg: Don't let gpg return failure on an invalid packet in a keyblock. (authored by werner).
gpg: Don't let gpg return failure on an invalid packet in a keyblock.
Feb 22 2018, 2:29 PM
werner claimed T3803: dirmngr issues malformed DNS queries.
Feb 22 2018, 2:11 PM · dns, dirmngr, Bug Report
werner closed T3065: dirmngr: proxy issues with dnslookup causing failure as Invalid.

No more info received - assuming this has been fixed after 1.2.20

Feb 22 2018, 11:01 AM · gnupg (gpg22), dns, dirmngr
werner closed T1967: GnuPG should select a key for signing without trying to use missing subkeys as Resolved.

Will go into 2.2.5

Feb 22 2018, 10:56 AM · gnupg (gpg22), Feature Request
werner committed rG88e766d3915c: g10: Select a secret key by checking availability under gpg-agent. (authored by gniibe).
g10: Select a secret key by checking availability under gpg-agent.
Feb 22 2018, 10:52 AM
werner claimed T1967: GnuPG should select a key for signing without trying to use missing subkeys.
Feb 22 2018, 10:51 AM · gnupg (gpg22), Feature Request
werner triaged T3622: --export-options export-minimal,export-clean includes unusable subkeys as Normal priority.
Feb 22 2018, 10:37 AM · Feature Request, gnupg (gpg22)
werner triaged T3773: private subkeys are never deleted on non-master instances as Low priority.
Feb 22 2018, 10:33 AM · Info Needed, OpenPGP, gnupg (gpg22), Bug Report
werner committed rGcf006cbf7338: doc: Clarify -export-secret-key-p12 (authored by werner).
doc: Clarify -export-secret-key-p12
Feb 22 2018, 10:31 AM
werner closed T3788: Document how to "exchange the private key" as Resolved.

I changed the wording to suggest the use of proper transport security.

Feb 22 2018, 10:31 AM · gnupg (gpg22), Documentation
werner committed rE70058cd9f944: build: Document how to use git send-email. (authored by werner).
build: Document how to use git send-email.
Feb 22 2018, 2:15 AM
werner committed rE887530733d04: doc: clarify patch submission workflow (authored by tbehrens).
doc: clarify patch submission workflow
Feb 22 2018, 2:15 AM
werner committed rEa8cf20c47ee0: doc: Typo fixes. (authored by werner).
doc: Typo fixes.
Feb 22 2018, 2:15 AM
werner committed rEdb7ed21adeaa: build: let autogen.sh set a git PATCH prefix (authored by werner).
build: let autogen.sh set a git PATCH prefix
Feb 22 2018, 2:15 AM

Feb 21 2018

werner committed rGa70502e93f06: build: Update autogen.sh (authored by werner).
build: Update autogen.sh
Feb 21 2018, 8:57 PM
werner committed rG914a2413228e: build: Update autogen.sh to set a git PATCH prefix. (authored by werner).
build: Update autogen.sh to set a git PATCH prefix.
Feb 21 2018, 8:57 PM
werner committed rGc4d8efb8942f: doc: Add extra hint on unattended use of gpg. (authored by werner).
doc: Add extra hint on unattended use of gpg.
Feb 21 2018, 11:16 AM

Feb 20 2018

werner claimed T3801: gpg --import cannot display user ID.

Thanks for tracking this down. I'll fix.

Feb 20 2018, 5:04 PM · gnupg (gpg23)
werner edited projects for T3801: gpg --import cannot display user ID, added: gnupg (gpg23); removed gnupg.
Feb 20 2018, 4:22 PM · gnupg (gpg23)
werner committed rG685a5e1558b2: wks: Add special mode to --install-key. (authored by werner).
wks: Add special mode to --install-key.
Feb 20 2018, 3:29 PM
werner committed rGee474856ec16: wks: Implement server command --install-key. (authored by werner).
wks: Implement server command --install-key.
Feb 20 2018, 11:52 AM
werner committed rDd63d03e12892: drafts,openpgp-webkey-service: Add alternative submission-address. (authored by werner).
drafts,openpgp-webkey-service: Add alternative submission-address.
Feb 20 2018, 9:37 AM
werner committed rG187760376191: wks: Support alternative submission address. (authored by werner).
wks: Support alternative submission address.
Feb 20 2018, 9:06 AM
werner committed rGfffefd3c98df: speedo: Use --enable-wks-tools for non-W32 builds. (authored by werner).
speedo: Use --enable-wks-tools for non-W32 builds.
Feb 20 2018, 9:06 AM

Feb 19 2018

werner added a comment to T3458: Add sha224sum.exe / sha384sum.exe / sha512sum.exe to Gpg4win installation.

Note that there is no standard for this. In particular the encoding of filenames with special characters are different in almost all implementations. I tried to find a common ground for our implementation.

Feb 19 2018, 5:05 PM · gpg4win, Feature Request
werner committed rG7b928c256426: speedo: Add new option STATIC=1 (authored by werner).
speedo: Add new option STATIC=1
Feb 19 2018, 11:19 AM
werner claimed T3774: Failure to decrypt AEAD-encrypted files in some rare cases.
Feb 19 2018, 9:48 AM · gnupg, Bug Report

Feb 16 2018

werner added a project to T3798: GpgOL: Memoryhole integration: gpgol.
Feb 16 2018, 5:54 PM · gpgol, Feature Request
werner added a comment to T3798: GpgOL: Memoryhole integration.

This is a MUA thing. Do you ask whether we plan to add it to GpgOL?

Feb 16 2018, 11:19 AM · gpgol, Feature Request
werner closed T3797: Allow Monero donations as Wontfix.

See T3796

Feb 16 2018, 8:55 AM · Feature Request
werner closed T3796: Allow Bitcoin Cash donations as Wontfix.

Sorry, we won't do this any time soon. We may even shut the Bitcoin thing down. I was too troublesome from a bookkeeping POV.

Feb 16 2018, 8:53 AM · Feature Request

Feb 15 2018

werner added a comment to T3056: gpgme-1.8.0: test failures on NetBSD.

(automake should flag non-portable Makefile features - after all it is there to avoid gmake features)

Feb 15 2018, 11:52 AM · gpgme (gpgme 1.23.x), gpgagent, gnupg (gpg23)
werner added a comment to T3770: heap buffer overflow in iobuf.c.

Does this patch help? My artificial test confirmed that this does the Right Thing.

Feb 15 2018, 11:49 AM · g10, Bug Report
werner committed rG5e3679ae395e: kbx: Fix detection of corrupted keyblocks on 32 bit systems. (authored by werner).
kbx: Fix detection of corrupted keyblocks on 32 bit systems.
Feb 15 2018, 11:48 AM
werner claimed T3770: heap buffer overflow in iobuf.c.
Feb 15 2018, 11:24 AM · g10, Bug Report

Feb 14 2018

werner triaged T3775: enable mixed hidden/non-hidden recipients during encryption as Normal priority.

I don't think that -R is a good way to implement BCC - it would be better to encrypt it separately. But people may have different ideas on this.

Feb 14 2018, 5:44 PM · gpgme, Feature Request
werner committed rGdf97fe248078: agent: Avoid appending a '\0' byte to the response of READKEY (authored by Katsuhiro Ueno <uenobk@gmail.com>).
agent: Avoid appending a '\0' byte to the response of READKEY
Feb 14 2018, 5:30 PM
werner triaged T3783: gpg-connect-agent: `HELP` lists `SIGKEY <hexstring_with_keygrip>` but only shows `SETKEY` as Wishlist priority.
/* Print all commands.  If a help string is available and that
   starts with the command name, print the first line of the
   help string.  */

For SETKEY this is not true. To change this we would need to have an "alias" flag to tell libassuan that setkey is an alias of sigkey. Not sure whether this really makes sense.

Feb 14 2018, 5:12 PM · gpgagent, Bug Report
werner added a comment to T3770: heap buffer overflow in iobuf.c.

Can't replicate this with gcc's address sanitizer. I found a bug in kbxutil, though.
Can you post a bit more info than just line 1275?

Feb 14 2018, 4:54 PM · g10, Bug Report
werner committed rG80719612b7e9: sm: Fix minor memory leak in --export-p12. (authored by werner).
sm: Fix minor memory leak in --export-p12.
Feb 14 2018, 3:01 PM
werner committed rG29aac7798085: sm: Fix a wrong key parameter in an exported private key file (authored by Katsuhiro Ueno <uenobk@gmail.com>).
sm: Fix a wrong key parameter in an exported private key file
Feb 14 2018, 3:01 PM
werner committed rG24ae5af102cb: Register DCO for Jussi. (authored by werner).
Register DCO for Jussi.
Feb 14 2018, 2:07 PM
werner committed rGf19ff78f0fbf: common: Use new function to print status strings. (authored by werner).
common: Use new function to print status strings.
Feb 14 2018, 12:27 PM
werner created P6 get_micalg (from mutt).
Feb 14 2018, 12:18 PM

Feb 13 2018

werner added a comment to T3790: gpgconf --list-dirs --dry-run should not create the socket directory.

That is just coincidence, ie. XDG_RUNTIME_DIR must be set to /run/user/$UID on you box.

Feb 13 2018, 4:53 PM · gnupg, Bug Report
werner claimed T3786: Unexpectedly slow decryption for AEAD (and CFB).

Thanks for this research. Two weeks ago I also did some testing and started to implement a fast track way for simple encryption(for example without signing and filters). But your path to improve iobuf is probably the more general solution.

Feb 13 2018, 12:29 PM · gnupg (gpg23), Bug Report
werner triaged T3788: Document how to "exchange the private key" as Normal priority.
Feb 13 2018, 12:20 PM · gnupg (gpg22), Documentation
werner triaged T3790: gpgconf --list-dirs --dry-run should not create the socket directory as Low priority.

The --create-socketdir is not not anymore needed because the socket directory is meanwhile always created. We would need to handle the --dry-run in a special way here.

Feb 13 2018, 12:19 PM · gnupg, Bug Report

Feb 6 2018

werner added projects to T3773: private subkeys are never deleted on non-master instances: gnupg (gpg22), OpenPGP.
Feb 6 2018, 6:30 PM · Info Needed, OpenPGP, gnupg (gpg22), Bug Report
werner added a comment to T3773: private subkeys are never deleted on non-master instances.

2.1.15 is a pretty old version. Please help us and try to replicate this with a 2.2 version and also give a log of the --delete-secret-and-public-key and --list-secret-key commands.

Feb 6 2018, 6:30 PM · Info Needed, OpenPGP, gnupg (gpg22), Bug Report
werner committed rG8305739fe857: gpg: Fix packet length checking in symkeyenc parser. (authored by werner).
gpg: Fix packet length checking in symkeyenc parser.
Feb 6 2018, 6:01 PM