Page MenuHome GnuPG
Feed Advanced Search

Oct 24 2019

gniibe committed rC05a7d2f262bc: ecc: Support an opaque MPI handling in mpi_from_keyparam. (authored by gniibe).
ecc: Support an opaque MPI handling in mpi_from_keyparam.
Oct 24 2019, 4:58 AM
gniibe committed rC35c1faaea2b0: ecc: String constant fix. (authored by gniibe).
ecc: String constant fix.
Oct 24 2019, 4:58 AM
gniibe committed rC006e51cd83a1: ecc: Fix wrong handling of shorten PK bytes. (authored by gniibe).
ecc: Fix wrong handling of shorten PK bytes.
Oct 24 2019, 2:59 AM

Oct 23 2019

gniibe committed rC8cc1ac270ff0: ecc: clean up. (authored by gniibe).
ecc: clean up.
Oct 23 2019, 11:28 AM
gniibe committed rCec7d3d9f780f: ecc: Make sure the size of bytes is same (2). (authored by gniibe).
ecc: Make sure the size of bytes is same (2).
Oct 23 2019, 11:00 AM
gniibe committed rCb280dbf75b99: ecc: Make sure the size of bytes is same. (authored by gniibe).
ecc: Make sure the size of bytes is same.
Oct 23 2019, 10:45 AM
gniibe closed T4723: Gmail by GoogleServer Error We're sorry, but Gmail is temporarily unavailable. We're currently working to fix the problem -- please try logging in to your account in a few minutes. as Spite.
Oct 23 2019, 7:48 AM · Bug Report, gpg4win
gniibe committed rC113fe03bedde: Merge branch 'master' into gniibe/x448 (authored by gniibe).
Merge branch 'master' into gniibe/x448
Oct 23 2019, 5:17 AM
gniibe committed rC27e848666b4a: ecc: ECDH clean up for use of ec->nbits. (authored by gniibe).
ecc: ECDH clean up for use of ec->nbits.
Oct 23 2019, 5:12 AM
gniibe committed rCc5a7191c1bd1: ecc: Use opaque MPI for _gcry_ecc_mul_point. (authored by gniibe).
ecc: Use opaque MPI for _gcry_ecc_mul_point.
Oct 23 2019, 5:12 AM
gniibe committed rCbbe15758c893: ecc: Fix _gcry_ecc_mont_decodepoint for data by old implementation. (authored by gniibe).
ecc: Fix _gcry_ecc_mont_decodepoint for data by old implementation.
Oct 23 2019, 5:12 AM

Oct 22 2019

gniibe committed rC13b9dcd65424: Merge branch 'master' into gniibe/x448 (authored by gniibe).
Merge branch 'master' into gniibe/x448
Oct 22 2019, 8:57 AM
gniibe committed rC82441bbb8290: ecc: Fix key generation for ECDH. (authored by gniibe).
ecc: Fix key generation for ECDH.
Oct 22 2019, 8:55 AM
gniibe committed rC89cc25994963: Merge branch 'master' into gniibe/x448 (authored by gniibe).
Merge branch 'master' into gniibe/x448
Oct 22 2019, 8:23 AM
gniibe committed rCc34e3e9257a2: Merge branch 'master' into gniibe/x448 (authored by gniibe).
Merge branch 'master' into gniibe/x448
Oct 22 2019, 8:23 AM
gniibe committed rC6d93812aa312: ecc: Fix debug output. (authored by gniibe).
ecc: Fix debug output.
Oct 22 2019, 8:23 AM
gniibe committed rC6a30a9a2cc48: ecc: Simplify using mpi_ec_t directly. (authored by gniibe).
ecc: Simplify using mpi_ec_t directly.
Oct 22 2019, 8:23 AM
gniibe committed rCe921ad5b3ad0: ecc: Add NAME member to struct mpi_ec_ctx_s. (authored by gniibe).
ecc: Add NAME member to struct mpi_ec_ctx_s.
Oct 22 2019, 8:23 AM
gniibe committed rC5415bc578080: ecc: Consolidate with _gcry_mpi_ec_internal_new. (authored by gniibe).
ecc: Consolidate with _gcry_mpi_ec_internal_new.
Oct 22 2019, 8:23 AM
gniibe committed rC975de3879691: ecc: Fix for NBITS support. (authored by gniibe).
ecc: Fix for NBITS support.
Oct 22 2019, 8:23 AM
gniibe committed rCc7b97ac9bdf9: ecc: Add new function _gcry_mpi_ec_internal_new. (authored by gniibe).
ecc: Add new function _gcry_mpi_ec_internal_new.
Oct 22 2019, 8:23 AM
gniibe committed rC488704be6e04: ecc: Add key generation support to mpi_ec_get_elliptic_curve. (authored by gniibe).
ecc: Add key generation support to mpi_ec_get_elliptic_curve.
Oct 22 2019, 8:23 AM
gniibe committed rCc2aa333dd88b: ecc: Support flags and debug print in _gcry_mpi_ec_internal_new. (authored by gniibe).
ecc: Support flags and debug print in _gcry_mpi_ec_internal_new.
Oct 22 2019, 8:23 AM
gniibe committed rC10b8cc280a53: ecc: Simplify ecc_encrypt_raw and ecc_decrypt_raw. (authored by gniibe).
ecc: Simplify ecc_encrypt_raw and ecc_decrypt_raw.
Oct 22 2019, 8:23 AM
gniibe committed rCa258ae728de6: ecc: Simply use unsigned int for cofactor, not MPI. (authored by gniibe).
ecc: Simply use unsigned int for cofactor, not MPI.
Oct 22 2019, 8:23 AM
gniibe committed rC61a051828253: ecc: More fixes for cofactor with PUBKEY_FLAG_PARAM. (authored by gniibe).
ecc: More fixes for cofactor with PUBKEY_FLAG_PARAM.
Oct 22 2019, 8:23 AM

Oct 18 2019

gniibe added a comment to T4713: Bug in get_best_pubkey_byname.

Or... it could be a feature, not bug, so that failure of -e -r someone can be examined by --locate-keys someone.

Oct 18 2019, 9:10 AM · Restricted Project, gnupg (gpg23)
gniibe committed rC579d5d6017d6: ecc: Simplify compute_keygrip. (authored by gniibe).
ecc: Simplify compute_keygrip.
Oct 18 2019, 4:25 AM
gniibe committed rC95cc9b8f4483: ecc: Clean up key generation code. (authored by gniibe).
ecc: Clean up key generation code.
Oct 18 2019, 2:56 AM
gniibe added a comment to T4713: Bug in get_best_pubkey_byname.

Let me clarify the point.

Oct 18 2019, 12:11 AM · Restricted Project, gnupg (gpg23)

Oct 17 2019

gniibe committed rGe2c2b0fb2d9b: gpg: More fix of get_best_pubkey_byname. (authored by gniibe).
gpg: More fix of get_best_pubkey_byname.
Oct 17 2019, 3:48 AM
gniibe added a comment to T4713: Bug in get_best_pubkey_byname.

I think that we should apply further change:

diff --git a/g10/getkey.c b/g10/getkey.c
index 077209415..1c337149c 100644
--- a/g10/getkey.c
+++ b/g10/getkey.c
@@ -1369,7 +1369,7 @@ get_best_pubkey_byname (ctrl_t ctrl, enum get_pubkey_modes mode,
     *retctx = NULL;
Oct 17 2019, 3:38 AM · Restricted Project, gnupg (gpg23)
gniibe added a comment to T4713: Bug in get_best_pubkey_byname.

I found more wrong cases of get_best_pubkey_byname.
For ranking results,
(1) It may return non-encryption primary key as the most relevant key, when its validity is higher.
(2) It may not select encryption primary key even if its creation time is newer.

Oct 17 2019, 2:32 AM · Restricted Project, gnupg (gpg23)
gniibe committed rG627a990f8e30: doc: Fix documentation about --locate-keys. (authored by gniibe).
doc: Fix documentation about --locate-keys.
Oct 17 2019, 2:32 AM
gniibe committed rG286d4c607574: gpg: Fix two other cases in get_best_pubkey_byname. (authored by gniibe).
gpg: Fix two other cases in get_best_pubkey_byname.
Oct 17 2019, 2:32 AM

Oct 16 2019

gniibe added a comment to T4713: Bug in get_best_pubkey_byname.

In my opinion, --locate-key should locate encryption key.

Oct 16 2019, 9:08 AM · Restricted Project, gnupg (gpg23)
gniibe committed rGf2734381ae14: gpg: Fix get_best_pubkey_byname to consider the first match. (authored by gniibe).
gpg: Fix get_best_pubkey_byname to consider the first match.
Oct 16 2019, 9:04 AM

Oct 15 2019

gniibe committed rG2906636b929f: Revert "gpg: The first key should be in candidates." (authored by gniibe).
Revert "gpg: The first key should be in candidates."
Oct 15 2019, 1:54 PM
gniibe added a reverting change for rG66eb953f4380: gpg: The first key should be in candidates.: rG2906636b929f: Revert "gpg: The first key should be in candidates.".
Oct 15 2019, 1:54 PM
gniibe committed rG44604209c1cf: gpg: Put the first key in candidates correctly. (authored by gniibe).
gpg: Put the first key in candidates correctly.
Oct 15 2019, 12:22 PM
gniibe committed rGfe02709ffd3c: po: Update Japanese translation. (authored by gniibe).
po: Update Japanese translation.
Oct 15 2019, 3:07 AM
gniibe committed rG66eb953f4380: gpg: The first key should be in candidates. (authored by gniibe).
gpg: The first key should be in candidates.
Oct 15 2019, 2:48 AM
gniibe committed rG2924ac374eb8: gpg: Fix a memory leak in get_best_pubkey_byname. (authored by gniibe).
gpg: Fix a memory leak in get_best_pubkey_byname.
Oct 15 2019, 2:48 AM
gniibe committed rGc933c15d587a: scd,ccid: Add 08e6:34c2 (GEMPC_EZIO). (authored by gniibe).
scd,ccid: Add 08e6:34c2 (GEMPC_EZIO).
Oct 15 2019, 2:46 AM
gniibe added projects to T4654: Gemalto Ezio Shield (CT710): CCID command failed: Parameter error at offset 7: Restricted Project, scd.

@pow, thanks for a reference. But problem here is that there are multiple products with same name.

Oct 15 2019, 2:44 AM · scd, Restricted Project, Bug Report

Oct 11 2019

gniibe committed rCff0f1782560e: ecc: Handle ephemeral key as opaque octets. (authored by gniibe).
ecc: Handle ephemeral key as opaque octets.
Oct 11 2019, 10:17 AM

Oct 10 2019

gniibe committed rCf6aac4771921: ecc: again. (authored by gniibe).
ecc: again.
Oct 10 2019, 10:13 AM
gniibe committed rC459944f1cd27: ecc: Fix X448 entry. (authored by gniibe).
ecc: Fix X448 entry.
Oct 10 2019, 10:12 AM
gniibe committed rC8053a23a091e: ecc: Use fixed-size little-endian bytes for ECC_DIALECT_SAFECURVE. (authored by gniibe).
ecc: Use fixed-size little-endian bytes for ECC_DIALECT_SAFECURVE.
Oct 10 2019, 10:09 AM
gniibe committed rCf44cdcd7e4fc: Merge branch 'master' into gniibe/x448 (authored by gniibe).
Merge branch 'master' into gniibe/x448
Oct 10 2019, 10:09 AM
gniibe committed rC80cf289905ac: ecc: Consolidate encoding a point for Montgomery curve. (authored by gniibe).
ecc: Consolidate encoding a point for Montgomery curve.
Oct 10 2019, 6:31 AM

Oct 9 2019

gniibe committed rCcca98375b556: ecc: Introduce ECC_DIALECT_SAFECURVE. (authored by gniibe).
ecc: Introduce ECC_DIALECT_SAFECURVE.
Oct 9 2019, 1:56 PM
gniibe committed rC82f092bebd9c: ecc: Use "X448" instead of "Curve448". (authored by gniibe).
ecc: Use "X448" instead of "Curve448".
Oct 9 2019, 1:56 PM
gniibe committed rC7fd4dcdbc0eb: ecc: Add Curve448. (authored by gniibe).
ecc: Add Curve448.
Oct 9 2019, 1:56 PM
gniibe committed rCba0b31f26366: ecc: More clean-up for Ed25519 and Curve25519. (authored by gniibe).
ecc: More clean-up for Ed25519 and Curve25519.
Oct 9 2019, 10:39 AM
gniibe added a project to T4158: UIF (User Interaction Flag) DO support: Restricted Project.
Oct 9 2019, 4:17 AM · Restricted Project, Feature Request, scd, gnupg
gniibe added a project to T4633: gpg argument "--passphrase=" yields 'missing argument for option "--passphrase="': Restricted Project.
Oct 9 2019, 4:16 AM · Restricted Project, gnupg (gpg22), Bug Report
gniibe added a project to T4713: Bug in get_best_pubkey_byname: Restricted Project.
Oct 9 2019, 4:15 AM · Restricted Project, gnupg (gpg23)
gniibe added a project to T4695: Remove SERIALNO as an identifier to select keys: Restricted Project.
Oct 9 2019, 4:15 AM · Restricted Project, Feature Request, gnupg
gniibe committed rG7535f1d47a35: gpg: The first key should be in candidates. (authored by gniibe).
gpg: The first key should be in candidates.
Oct 9 2019, 2:48 AM
gniibe changed the status of T4713: Bug in get_best_pubkey_byname from Open to Testing.

I believe that constraint of ret_keyblock != NULL is OK.
Pushing the fix.
Perhaps, backport to 2.2 should be done, too.

Oct 9 2019, 2:44 AM · Restricted Project, gnupg (gpg23)

Oct 8 2019

gniibe committed rC7bbc3adc8bc7: Merge branch 'gniibe/x448' of playfair.gnupg.org:/git/libgcrypt (authored by gniibe).
Merge branch 'gniibe/x448' of playfair.gnupg.org:/git/libgcrypt
Oct 8 2019, 9:27 AM
gniibe committed rC2ec2ea3d66ff: ecc: Add Curve448. (authored by gniibe).
ecc: Add Curve448.
Oct 8 2019, 9:27 AM
gniibe committed rCd66a4856eb0c: ecc: Fix hard-coded value for 25519 to allow other modern curves. (authored by gniibe).
ecc: Fix hard-coded value for 25519 to allow other modern curves.
Oct 8 2019, 9:13 AM
gniibe committed rC13038098e099: Merge branch 'gniibe/x448' of playfair.gnupg.org:/git/libgcrypt (authored by gniibe).
Merge branch 'gniibe/x448' of playfair.gnupg.org:/git/libgcrypt
Oct 8 2019, 8:34 AM
gniibe committed rC254c5279058f: ecc: Clean up for decoding point. (authored by gniibe).
ecc: Clean up for decoding point.
Oct 8 2019, 8:27 AM
gniibe committed rC6e57242c61bc: random: Clean up unused old internal API. (authored by gniibe).
random: Clean up unused old internal API.
Oct 8 2019, 5:36 AM

Oct 7 2019

gniibe added a comment to T4713: Bug in get_best_pubkey_byname.

If we can assume ret_keyblock != NULL (it is, in current implementation), it can be as simple as:

diff --git a/g10/getkey.c b/g10/getkey.c
index 6802026f6..27bbd354c 100644
--- a/g10/getkey.c
+++ b/g10/getkey.c
@@ -1354,6 +1354,8 @@ get_best_pubkey_byname (ctrl_t ctrl, enum get_pubkey_modes mode,
   int is_mbox = is_valid_mailbox (name);
   int wkd_tried = 0;
Oct 7 2019, 3:58 AM · Restricted Project, gnupg (gpg23)
gniibe committed rGe28572116fe4: gpg: Fix a memory leak in get_best_pubkey_byname. (authored by gniibe).
gpg: Fix a memory leak in get_best_pubkey_byname.
Oct 7 2019, 3:51 AM

Oct 4 2019

gniibe added a comment to T4713: Bug in get_best_pubkey_byname.
diff --git a/g10/getkey.c b/g10/getkey.c
index de5024198..051b21203 100644
--- a/g10/getkey.c
+++ b/g10/getkey.c
@@ -1272,6 +1272,48 @@ only_expired_enc_subkeys (kbnode_t keyblock)
   return any? 1 : 0;
 }
Oct 4 2019, 8:58 AM · Restricted Project, gnupg (gpg23)
gniibe added a comment to T4713: Bug in get_best_pubkey_byname.
Oct 4 2019, 8:56 AM · Restricted Project, gnupg (gpg23)

Oct 3 2019

gniibe committed rCf55b26a500d1: ecc: Add Curve448. (authored by gniibe).
ecc: Add Curve448.
Oct 3 2019, 7:01 AM

Oct 2 2019

gniibe added a project to T4712: Keygrip broken in master for cv25519: Restricted Project.

I modified _gcry_ecc_fill_in_curve so that g_y has new value in eid4730.

Oct 2 2019, 8:29 AM · Restricted Project, Bug Report, libgcrypt
gniibe committed rC1cfe2329b91c: ecc: Fix regression in keygrip computation for cv25519 (2). (authored by gniibe).
ecc: Fix regression in keygrip computation for cv25519 (2).
Oct 2 2019, 5:07 AM

Oct 1 2019

gniibe claimed T4712: Keygrip broken in master for cv25519.

That's my badness. I think that I haven't seen this problem, because I mainly use tokens (where keygrip difference doesn't matter, after --card-status).

Oct 1 2019, 7:17 AM · Restricted Project, Bug Report, libgcrypt

Sep 29 2019

gniibe created T4713: Bug in get_best_pubkey_byname.
Sep 29 2019, 10:44 AM · Restricted Project, gnupg (gpg23)

Sep 28 2019

gniibe added a project to T4620: no support for multiple (yubikey) smartcards plugged in at the same time: Restricted Project.
Sep 28 2019, 6:53 PM · Restricted Project, Bug Report
asv awarded T4620: no support for multiple (yubikey) smartcards plugged in at the same time a Like token.
Sep 28 2019, 4:36 PM · Restricted Project, Bug Report

Sep 27 2019

gniibe renamed T4563: gpg-agent fails to sign request of PKISSH from gpg-agent fails to sign request to gpg-agent fails to sign request of PKISSH.
Sep 27 2019, 1:45 PM · Feature Request, gpgagent
gniibe edited projects for T4563: gpg-agent fails to sign request of PKISSH, added: Feature Request; removed Info Needed, Bug Report.
Sep 27 2019, 10:17 AM · Feature Request, gpgagent
gniibe added a comment to T4563: gpg-agent fails to sign request of PKISSH.

OK, I identify the problem.

Sep 27 2019, 8:23 AM · Feature Request, gpgagent

Sep 25 2019

gniibe added a comment to T4710: Cannot use Secure PIN Entry for Reset Code.

For pinpadtest.py, you need to offer an option --add (adding dummy byte), when you are using Cherry ST-2xxx.

Sep 25 2019, 1:39 PM · Not A Bug, Documentation, OpenPGP, scd, Bug Report
gniibe claimed T4710: Cannot use Secure PIN Entry for Reset Code.

It is not supported, by CCID protocol itself. So, it is not supported by scdaemon, and by any of card readers (which I know of), either.

Sep 25 2019, 12:09 PM · Not A Bug, Documentation, OpenPGP, scd, Bug Report

Sep 24 2019

gniibe committed rEf73605e03949: Fix gpg-error.c for preprocessor use. (authored by gniibe).
Fix gpg-error.c for preprocessor use.
Sep 24 2019, 1:39 PM

Sep 20 2019

gniibe committed rGbb5ed9fe1abf: build: Build gpg-pair-tool only when there is newer libgcrypt. (authored by gniibe).
build: Build gpg-pair-tool only when there is newer libgcrypt.
Sep 20 2019, 7:21 AM

Sep 19 2019

gniibe committed rG7c81e5cb97c7: tools: Fix gpg-pair-tool to follow new API. (authored by gniibe).
tools: Fix gpg-pair-tool to follow new API.
Sep 19 2019, 11:37 AM
gniibe committed rGf22a00416149: tools: Use new API of libgcrypt for gpg-pair-tool. (authored by gniibe).
tools: Use new API of libgcrypt for gpg-pair-tool.
Sep 19 2019, 11:37 AM
gniibe committed rGb928de70e072: tools: Don't prepare G in gpg-pair-tool. (authored by gniibe).
tools: Don't prepare G in gpg-pair-tool.
Sep 19 2019, 11:37 AM
gniibe changed the status of T4620: no support for multiple (yubikey) smartcards plugged in at the same time from Open to Testing.

And it is merged into master.
Along with the support of multiple readers/token, the parts which assumes Windows 32-bit are fixed, too.

Sep 19 2019, 1:30 AM · Restricted Project, Bug Report

Sep 18 2019

gniibe added a comment to T4698: Results from clang analyzer.

For argparse.c, it can be only stopped with nonnull attribute for the API, I suppose.

Sep 18 2019, 10:50 AM · gpgrt, Bug Report
gniibe committed rE46bb7eb8c554: tests: Fix deallocation of buffer in t-b64.c. (authored by gniibe).
tests: Fix deallocation of buffer in t-b64.c.
Sep 18 2019, 10:48 AM
gniibe committed rE4b8e8ba9f60c: gpgrt_setenv: Define behavior when value=NULL. (authored by gniibe).
gpgrt_setenv: Define behavior when value=NULL.
Sep 18 2019, 10:48 AM
gniibe committed rEf41991480aaa: estream: Care about erroneous case for stream close. (authored by gniibe).
estream: Care about erroneous case for stream close.
Sep 18 2019, 10:48 AM
gniibe committed rE521aeecf1e41: logging: Fix the case of using socket_dir_cb which may return NULL. (authored by gniibe).
logging: Fix the case of using socket_dir_cb which may return NULL.
Sep 18 2019, 10:48 AM
gniibe claimed T4698: Results from clang analyzer.

I take this so that libgpg-error can be released soon.

Sep 18 2019, 9:21 AM · gpgrt, Bug Report

Sep 17 2019

gniibe committed rG49671b76eae2: scd,pcsc: Use HANDLE for context and card. (authored by gniibe).
scd,pcsc: Use HANDLE for context and card.
Sep 17 2019, 1:12 PM

Sep 12 2019

gniibe committed rGc569e49d1764: scd,pcsc: Remove the restriction of no-scanning in PC/SC. (authored by gniibe).
scd,pcsc: Remove the restriction of no-scanning in PC/SC.
Sep 12 2019, 2:38 AM
gniibe committed rG980d0234d316: scd: Remove old fallback logic from CCID to PC/SC. (authored by gniibe).
scd: Remove old fallback logic from CCID to PC/SC.
Sep 12 2019, 2:38 AM
gniibe committed rG6d750fe7fc42: scd,pcsc: Support "reader-port" option for PC/SC reader. (authored by gniibe).
scd,pcsc: Support "reader-port" option for PC/SC reader.
Sep 12 2019, 2:38 AM

Sep 11 2019

gniibe claimed T4620: no support for multiple (yubikey) smartcards plugged in at the same time.

I created a branch for this task: https://dev.gnupg.org/source/gnupg/repository/gniibe%252FT4620/

Sep 11 2019, 4:39 AM · Restricted Project, Bug Report