Page MenuHome GnuPG
Feed Advanced Search

Mar 8 2022

gniibe added a comment to T5793: gpgsm: Wrong length when parsing octetstring in constructed encoding + definite length.

I located the cause; Current implementation cannot parse the data like:

2611:d=5  hl=4 l=1632 cons:      cont [ 0 ]        
2615:d=6  hl=4 l= 500 prim:       OCTET STRING
3119:d=6  hl=4 l=1124 prim:       OCTET STRING
Mar 8 2022, 5:25 AM · Restricted Project, S/MIME, gnupg (gpg22)
gniibe updated the task description for T5793: gpgsm: Wrong length when parsing octetstring in constructed encoding + definite length.
Mar 8 2022, 1:52 AM · Restricted Project, S/MIME, gnupg (gpg22)

Mar 7 2022

gniibe claimed T5793: gpgsm: Wrong length when parsing octetstring in constructed encoding + definite length.
Mar 7 2022, 11:25 AM · Restricted Project, S/MIME, gnupg (gpg22)
gniibe claimed T5856: Forcing aead when creating sign & encrypted files creates inconsistent results.
Mar 7 2022, 11:23 AM · gnupg (gpg23), Bug Report
gniibe lowered the priority of T5704: Ed448/X448 defined in draft-ietf-openpgp-crypto-refresh-04 from High to Normal.
Mar 7 2022, 11:17 AM · gnupg24, OpenPGP, gnupg (gpg23)
gniibe triaged T5590: OpenPGP: Curve 448, modernize? as Normal priority.
Mar 7 2022, 11:15 AM · rationale, gnupg, OpenPGP
gniibe added a comment to T5860: Reducing memory copy overhead in iobuf and estream to increase OCB speed.

Ack from me for new 0005 and 0006.

Mar 7 2022, 9:13 AM · gnupg
gniibe added a comment to T5862: authentication with USB token.

More things to be considered:

  • How to connect scdaemon
  • How to invoke scdaemon
Mar 7 2022, 1:14 AM · gpgagent, Feature Request, scd

Mar 4 2022

gniibe added a comment to T5862: authentication with USB token.

BTW, there are various use cases for authentication(s), it is better to focus on the part of device and crypto (USB Token and scdaemon).

Mar 4 2022, 6:05 AM · gpgagent, Feature Request, scd
gniibe added a comment to T5862: authentication with USB token.

Here is an experimental shell script for testing:

Mar 4 2022, 5:46 AM · gpgagent, Feature Request, scd
gniibe committed rG14e13fb7123e: common: Fix confusion of get_pk_algo_from_key. (authored by gniibe).
common: Fix confusion of get_pk_algo_from_key.
Mar 4 2022, 3:09 AM
gniibe committed rG58e6990eaabb: scd: Fix PK_AUTH with --challenge-response option. (authored by gniibe).
scd: Fix PK_AUTH with --challenge-response option.
Mar 4 2022, 2:15 AM

Mar 3 2022

gniibe committed rG44621120a269: scd: Add --challenge-response option to PK_AUTH for OpenPGP card. (authored by gniibe).
scd: Add --challenge-response option to PK_AUTH for OpenPGP card.
Mar 3 2022, 9:51 AM
gniibe triaged T5870: libgcrypt: AEAD API for FIPS 140 (in future) as Unbreak Now! priority.
Mar 3 2022, 1:13 AM · Feature Request, FIPS, libgcrypt

Mar 2 2022

werner awarded rG8e650dbd48fa: scd: Let READKEY support --format=ssh option. a Cup of Joe token.
Mar 2 2022, 11:16 AM
gniibe committed rG8e650dbd48fa: scd: Let READKEY support --format=ssh option. (authored by gniibe).
scd: Let READKEY support --format=ssh option.
Mar 2 2022, 6:15 AM

Mar 1 2022

gniibe added projects to T5862: authentication with USB token: scd, Feature Request.

It may be simpler if we can enhance scdaemon to have an option for PKAUTH, say, --challenge-response, so that it generates a challenge and verify signature internally.

Mar 1 2022, 8:57 AM · gpgagent, Feature Request, scd
gniibe added a comment to T5862: authentication with USB token.

Possibly, it could be done with pam_exec http://linux-pam.org/Linux-PAM-html/sag-pam_exec.html
developing a simple executable (or even small shell script).

Mar 1 2022, 8:44 AM · gpgagent, Feature Request, scd
gniibe triaged T5862: authentication with USB token as Normal priority.
Mar 1 2022, 8:38 AM · gpgagent, Feature Request, scd
gniibe changed the status of T5853: Decrypting OCB encrypted file fails... from Open to Testing.
Mar 1 2022, 5:04 AM · gnupg (gpg23), Bug Report
gniibe added a comment to T5860: Reducing memory copy overhead in iobuf and estream to increase OCB speed.

Great. No problem for me.

Mar 1 2022, 4:14 AM · gnupg
gniibe added a comment to T5852: Use iobuf_copy where instead of manual iobuf_get/iobuf_put or iobuf_read/iobuf_write loops.

No problem. Both patches look good.

Mar 1 2022, 3:14 AM · gnupg (gpg23)

Feb 28 2022

gniibe added a comment to T5861: ntbtls: AEAD GCM nonce.

In TLS 1.2, it refers RFC5116. In RFC5116, it says:

Feb 28 2022, 11:34 AM · ntbtls
gniibe lowered the priority of T5861: ntbtls: AEAD GCM nonce from Unbreak Now! to Normal.
Feb 28 2022, 11:21 AM · ntbtls
gniibe added a comment to T5861: ntbtls: AEAD GCM nonce.

My reading was wrong; Indeed we use memcpy from out_ctr. But it increments in network byte order.
So, for AES-GCM, it works well.

Feb 28 2022, 11:21 AM · ntbtls
gniibe triaged T5861: ntbtls: AEAD GCM nonce as Unbreak Now! priority.
Feb 28 2022, 2:20 AM · ntbtls

Feb 25 2022

gniibe committed rG335805e1d482: gpg: Clarify a call of ask_for_detached_datafile. (authored by gniibe).
gpg: Clarify a call of ask_for_detached_datafile.
Feb 25 2022, 4:16 AM
gniibe added a comment to T5826: Improve detached signing and verification speed.

Patches look good for me.
Please go ahead.

Feb 25 2022, 1:53 AM · gnupg

Feb 23 2022

gniibe added a comment to T5853: Decrypting OCB encrypted file fails....

It was the bug of generating AEAD packet, which does:

Feb 23 2022, 1:33 AM · gnupg (gpg23), Bug Report
gniibe committed rGfb007d93de7b: Fix the previous commit. (authored by gniibe).
Fix the previous commit.
Feb 23 2022, 1:18 AM
gniibe triaged T5853: Decrypting OCB encrypted file fails... as High priority.

Sorry for pushing immature fix. I located the cause, but I didn't have enough concentration for fix.

Feb 23 2022, 1:17 AM · gnupg (gpg23), Bug Report
gniibe claimed T5853: Decrypting OCB encrypted file fails....
Feb 23 2022, 1:14 AM · gnupg (gpg23), Bug Report
gniibe added a member for FIPS: Jakuje.
Feb 23 2022, 12:40 AM
gniibe added a member for FIPS: gniibe.
Feb 23 2022, 12:40 AM
gniibe added a member for FIPS: neverpanic.
Feb 23 2022, 12:40 AM
gniibe moved T5835: libgcrypt: More robust/portable integrity check from Backlog to Next on the FIPS board.
Feb 23 2022, 12:38 AM · Bug Report, libgcrypt, FIPS

Feb 22 2022

gniibe committed rG903c5fe369bc: gpg: Fix generating AEAD packet. (authored by gniibe).
gpg: Fix generating AEAD packet.
Feb 22 2022, 1:18 PM

Feb 18 2022

gniibe added a comment to rG05fdaa173752: sm: Fix use of value NONE in gnupg_isotime_t type..

My direct problem is to silence warnings for newer GCC.

Feb 18 2022, 8:25 AM
gniibe committed rG05fdaa173752: sm: Fix use of value NONE in gnupg_isotime_t type. (authored by gniibe).
sm: Fix use of value NONE in gnupg_isotime_t type.
Feb 18 2022, 3:16 AM
gniibe triaged T5822: libgcrypt: Remove GCRYCTL_ENABLE_M_GUARD support (was: _gcry_private_malloc returns 4-byte alignment memory when use_m_guard==1) as Normal priority.
Feb 18 2022, 1:01 AM · Bug Report, libgcrypt

Feb 17 2022

gniibe committed rGf064d972e388: tests: Remove a test case with "quiet" option with gpgconf. (authored by gniibe).
tests: Remove a test case with "quiet" option with gpgconf.
Feb 17 2022, 6:19 AM
gniibe committed rG3c3765405de0: scd: Use lock_slot for apdu_send_direct. (authored by gniibe).
scd: Use lock_slot for apdu_send_direct.
Feb 17 2022, 6:08 AM
gniibe added a project to T5831: Backport (f808012a) scd: Use lock_slot for apdu_send_direct. to GnuPG 2.2: Restricted Project.

Thank you for your suggestion.

Feb 17 2022, 6:08 AM · gnupg (gpg22), Bug Report, scd
gniibe claimed T5831: Backport (f808012a) scd: Use lock_slot for apdu_send_direct. to GnuPG 2.2.
Feb 17 2022, 6:01 AM · gnupg (gpg22), Bug Report, scd
gniibe closed T5393: gnupg coverity static analysis reports as Resolved.
Feb 17 2022, 5:50 AM · gnupg (gpg23), Bug Report
gniibe closed T5730: During make, compile error under Ubuntu 21.10 as Resolved.
Feb 17 2022, 5:49 AM · gpgme, Bug Report
gniibe added a project to T5811: libgcrypt: Remove random-daemon (server side): Restricted Project.
Feb 17 2022, 5:48 AM · libgcrypt
gniibe closed T2385: support more than 1024 fds. as Resolved.
Feb 17 2022, 5:47 AM · gpgrt, Feature Request, gpgme
gniibe closed T5742: Apparent regressions between 2.2.32 and 2.2.33 of GnuPG as Resolved.
Feb 17 2022, 5:46 AM · Restricted Project, Bug Report, gnupg (gpg23)
gniibe added a comment to T5835: libgcrypt: More robust/portable integrity check.

I simplified the script not to use cmp: rC3c8b6c4a9cad: fips: Fix gen-note-integrity.sh script not to use cmp utility.
And I clarified the semantics of the integrity check.

Feb 17 2022, 3:48 AM · Bug Report, libgcrypt, FIPS
gniibe committed rC052c5ef4cea5: fips: Clarify what to be hashed for the integrity check. (authored by gniibe).
fips: Clarify what to be hashed for the integrity check.
Feb 17 2022, 3:29 AM
gniibe committed rE666d64d2bc65: gpg-error.m4: Fix use with older gpgrt-config (< 1.33). (authored by gniibe).
gpg-error.m4: Fix use with older gpgrt-config (< 1.33).
Feb 17 2022, 2:35 AM
gniibe committed rC3c8b6c4a9cad: fips: Fix gen-note-integrity.sh script not to use cmp utility. (authored by gniibe).
fips: Fix gen-note-integrity.sh script not to use cmp utility.
Feb 17 2022, 2:29 AM
gniibe committed rC5420cbbd3ec7: Silence compiler warnings for possible alignment problem. (authored by gniibe).
Silence compiler warnings for possible alignment problem.
Feb 17 2022, 1:44 AM
gniibe added a comment to T5835: libgcrypt: More robust/portable integrity check.

I located the cause:

../../src/gen-note-integrity.sh: line 78: cmp: command not found
Feb 17 2022, 1:36 AM · Bug Report, libgcrypt, FIPS

Feb 16 2022

gniibe added a comment to T5835: libgcrypt: More robust/portable integrity check.

I pushed the change: rCa340e9803882: fips: More portable integrity check.
It uses .note.fdo.integrity section, not loaded onto memory.
It simplifies the logic, and switches to dladdr (from dladdr1).

Feb 16 2022, 12:36 PM · Bug Report, libgcrypt, FIPS
gniibe committed rCa340e9803882: fips: More portable integrity check. (authored by gniibe).
fips: More portable integrity check.
Feb 16 2022, 12:33 PM
gniibe added a comment to T5835: libgcrypt: More robust/portable integrity check.

Pushed the change which fixes the build with ld.gold.
rC9dcf9305962b: fips: Integrity check improvement, with only loadable segments.

Feb 16 2022, 6:29 AM · Bug Report, libgcrypt, FIPS
gniibe committed rC9dcf9305962b: fips: Integrity check improvement, with only loadable segments. (authored by gniibe).
fips: Integrity check improvement, with only loadable segments.
Feb 16 2022, 6:16 AM
gniibe committed rCb2f110f99626: build: Clean up acinclude.m4. (authored by gniibe).
build: Clean up acinclude.m4.
Feb 16 2022, 3:15 AM
gniibe committed rCd98a78f0eb77: build: Remove checking Pth library. (authored by gniibe).
build: Remove checking Pth library.
Feb 16 2022, 3:15 AM
gniibe added a comment to T5835: libgcrypt: More robust/portable integrity check.

Thank you for your suggestions, @werner.
I agree that we should not put much effort to develop our own methodology here; Too much effort may introduce possibility of unmaintainable code, which should be avoided for the particular purpose of "integrity".

Feb 16 2022, 3:07 AM · Bug Report, libgcrypt, FIPS

Feb 15 2022

gniibe committed rCbeb5d6df5c57: fips: Use ELF header to find hmac file offset (authored by Clemens Lang via Gcrypt-devel <gcrypt-devel@lists.gnupg.org>).
fips: Use ELF header to find hmac file offset
Feb 15 2022, 2:24 PM
gniibe committed rC521500624b4b: fips: Fix previous commit. (authored by gniibe).
fips: Fix previous commit.
Feb 15 2022, 2:24 PM
gniibe committed rCbff9f1b02464: build: Fix m4/gpg-error.m4. (authored by gniibe).
build: Fix m4/gpg-error.m4.
Feb 15 2022, 9:26 AM
gniibe added a comment to T5835: libgcrypt: More robust/portable integrity check.

I am going to apply https://gitlab.com/redhat-crypto/libgcrypt/libgcrypt-mirror/-/commit/64ccc25c4b4a2c8c4e13e7e37ff1c8c60a3d8401
And consider adding the code to limit hashing content (from start of the file to end of data section).

Feb 15 2022, 7:40 AM · Bug Report, libgcrypt, FIPS
gniibe updated the task description for T5835: libgcrypt: More robust/portable integrity check.
Feb 15 2022, 3:39 AM · Bug Report, libgcrypt, FIPS
gniibe triaged T5835: libgcrypt: More robust/portable integrity check as High priority.
Feb 15 2022, 3:38 AM · Bug Report, libgcrypt, FIPS

Feb 14 2022

gniibe closed T5814: gpg-agent can't find existing 'pinentry', searches 'Pinentry' (uppercase'P') instead as Resolved.
Feb 14 2022, 10:46 AM · Not A Bug, Bug Report
gniibe added a comment to T5814: gpg-agent can't find existing 'pinentry', searches 'Pinentry' (uppercase'P') instead.

Good to hear the cause.

Feb 14 2022, 10:46 AM · Not A Bug, Bug Report
gniibe committed rC6994d874af86: hmac: Fix memory leak (authored by Clemens Lang via Gcrypt-devel <gcrypt-devel@lists.gnupg.org>).
hmac: Fix memory leak
Feb 14 2022, 7:31 AM
gniibe committed rC7fc5d33e7416: fips: Fix memory leaks in FIPS mode (authored by Clemens Lang via Gcrypt-devel <gcrypt-devel@lists.gnupg.org>).
fips: Fix memory leaks in FIPS mode
Feb 14 2022, 7:12 AM
gniibe committed rCb7dcb576bc1b: Register DCO for Clemens Lang. (authored by gniibe).
Register DCO for Clemens Lang.
Feb 14 2022, 6:43 AM

Feb 10 2022

gniibe committed rCf98ca6aa34cc: Remove the built-in memory guard support. (authored by gniibe).
Remove the built-in memory guard support.
Feb 10 2022, 1:56 AM
gniibe committed rC738723a1cd20: Clean up for removal of memory guard support. (authored by gniibe).
Clean up for removal of memory guard support.
Feb 10 2022, 1:56 AM
gniibe added a comment to T5822: libgcrypt: Remove GCRYCTL_ENABLE_M_GUARD support (was: _gcry_private_malloc returns 4-byte alignment memory when use_m_guard==1).

It was addressed in rC04f325d8917d: released 1.1.4 as "(obsolete)" feature, in Aug 2001.

Feb 10 2022, 1:32 AM · Bug Report, libgcrypt
gniibe renamed T5822: libgcrypt: Remove GCRYCTL_ENABLE_M_GUARD support (was: _gcry_private_malloc returns 4-byte alignment memory when use_m_guard==1) from libgcrypt: _gcry_private_malloc returns 4-byte alignment memory when use_m_guard==1 to libgcrypt: Remove GCRYCTL_ENABLE_M_GUARD support (was: _gcry_private_malloc returns 4-byte alignment memory when use_m_guard==1).
Feb 10 2022, 1:19 AM · Bug Report, libgcrypt

Feb 9 2022

gniibe added a comment to T5822: libgcrypt: Remove GCRYCTL_ENABLE_M_GUARD support (was: _gcry_private_malloc returns 4-byte alignment memory when use_m_guard==1).

Instead, let us remove the feature.

Feb 9 2022, 12:33 PM · Bug Report, libgcrypt
gniibe added inline comments to rC90f41a1898e4: Fix memory allocation when GCRYCTL_ENABLE_M_GUARD..
Feb 9 2022, 12:32 PM
gniibe added a comment to T5815: GPG-Agent randomly throwing "IPC connect call failed" .

FYI, if you can use backports, GnuPG 2.2 series is available
See : https://backports.debian.org/news/stretch-backports/

Feb 9 2022, 3:12 AM · Bug Report
gniibe added a project to T5817: libgcrypt: Add Balloon KDF: Restricted Project.
Feb 9 2022, 2:58 AM · libgcrypt, Feature Request
gniibe claimed T5822: libgcrypt: Remove GCRYCTL_ENABLE_M_GUARD support (was: _gcry_private_malloc returns 4-byte alignment memory when use_m_guard==1).
Feb 9 2022, 2:58 AM · Bug Report, libgcrypt
gniibe committed rC90f41a1898e4: Fix memory allocation when GCRYCTL_ENABLE_M_GUARD. (authored by gniibe).
Fix memory allocation when GCRYCTL_ENABLE_M_GUARD.
Feb 9 2022, 2:57 AM
gniibe committed rC6936f234220d: kdf: Prepare aligned memory in balloon_final. (authored by gniibe).
kdf: Prepare aligned memory in balloon_final.
Feb 9 2022, 2:30 AM
gniibe added a comment to rC59b2504df8f0: kdf: fix unaligned memory access in balloon_xor_block.

Sorry, I looked wrong place. It is balloon_final which assumes user provided RESULT is aligned, which is wrong.

Feb 9 2022, 2:11 AM
gniibe created T5822: libgcrypt: Remove GCRYCTL_ENABLE_M_GUARD support (was: _gcry_private_malloc returns 4-byte alignment memory when use_m_guard==1).
Feb 9 2022, 2:09 AM · Bug Report, libgcrypt
gniibe added a comment to rC59b2504df8f0: kdf: fix unaligned memory access in balloon_xor_block.

I think that this patch should not be needed, if our implementation of _gcry_private_malloc is not buggy (ensuring same alignment condition as system malloc does).
I just realized that it is buggy unfortunately, so, I'm opening a task for that.

Feb 9 2022, 1:44 AM

Feb 8 2022

gniibe added a comment to T5817: libgcrypt: Add Balloon KDF.

Tested on a big endian machine.

$ uname -a
Linux perotto 5.15.0-2-powerpc64 #1 SMP Debian 5.15.5-2 (2021-12-18) ppc64 GNU/Linux
Feb 8 2022, 4:00 AM · libgcrypt, Feature Request
gniibe committed rC26bfa41e2413: kdf: Extend original Balloon to other digest algos. (authored by gniibe).
kdf: Extend original Balloon to other digest algos.
Feb 8 2022, 2:45 AM
gniibe added a comment to T5814: gpg-agent can't find existing 'pinentry', searches 'Pinentry' (uppercase'P') instead.

FYI: When you have a problem with pinentry, possible workaround is using gpg with --pinentry-mode=loopback, which redirects pinentry queries to the caller (instead of invoking pinentry session).

Feb 8 2022, 1:37 AM · Not A Bug, Bug Report
gniibe added a comment to T5814: gpg-agent can't find existing 'pinentry', searches 'Pinentry' (uppercase'P') instead.

Thank you for the debug information.

Feb 8 2022, 1:21 AM · Not A Bug, Bug Report

Feb 7 2022

gniibe changed the status of T5721: gpg22: Update *.m4 to prefer use of gpgrt-config and *.pc to *-config, a subtask of T5034: dev: Deprecate libassuan-config, libgcrypt-config, ksba-config, ntbtls-config, npth-config, and gpg-error-config, from Open to Testing.
Feb 7 2022, 11:33 AM
gniibe changed the status of T5721: gpg22: Update *.m4 to prefer use of gpgrt-config and *.pc to *-config from Open to Testing.

Done by rGc8cd66ae7e60: m4: Update our library m4 files from master.

Feb 7 2022, 11:33 AM · gnupg (gpg22)
gniibe committed rG8021fe7670c7: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Feb 7 2022, 11:30 AM
gniibe added a comment to T5814: gpg-agent can't find existing 'pinentry', searches 'Pinentry' (uppercase'P') instead.

The change of pinentry-tty rP7f7fd8bcfd74: tty: Fix error return paths and its resource leaks. fixes SEGV, but the problem of your case is that access to the device file (/dev/pts/2 in the case of your log with pinentry-tty) failed.

Feb 7 2022, 10:57 AM · Not A Bug, Bug Report
gniibe committed rC08ab32228ad2: kdf: Add experimental Balloon KDF. (authored by gniibe).
kdf: Add experimental Balloon KDF.
Feb 7 2022, 6:17 AM
gniibe committed rCe257fe39b8ff: kdf: Use u64. (authored by gniibe).
kdf: Use u64.
Feb 7 2022, 6:17 AM
gniibe triaged T5817: libgcrypt: Add Balloon KDF as Normal priority.
Feb 7 2022, 6:15 AM · libgcrypt, Feature Request
gniibe added a comment to T5814: gpg-agent can't find existing 'pinentry', searches 'Pinentry' (uppercase'P') instead.

Thank you for your debugging.

Feb 7 2022, 3:06 AM · Not A Bug, Bug Report

Feb 4 2022

gniibe committed rCa484bd665f4a: jitterentropy: Include <fcntl.h> and <limits.h> (authored by heirecka).
jitterentropy: Include <fcntl.h> and <limits.h>
Feb 4 2022, 8:17 AM