Here's fix for mode specific setkey clearing error code:
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Apr 23 2023
Apr 23 2023
jukivili added a comment to T6451: libgcrypt | gcry_cipher_setkey: 3DES-CBC key returns GPG_ERR_WEAK even with GCRYCTL_SET_ALLOW_WEAK_KEY.
Apr 21 2023
Apr 21 2023
jukivili committed rC7146b69b4905: Revert "cipher: Fix edge case for SET_ALLOW_WEAK_KEY." (authored by jukivili).
Revert "cipher: Fix edge case for SET_ALLOW_WEAK_KEY."
jukivili committed rCf3ca9fa4f7e0: doc: add documentation for GCRYCTL_SET_ALLOW_WEAK_KEY (authored by jukivili).
doc: add documentation for GCRYCTL_SET_ALLOW_WEAK_KEY
Apr 20 2023
Apr 20 2023
jukivili added a comment to T6451: libgcrypt | gcry_cipher_setkey: 3DES-CBC key returns GPG_ERR_WEAK even with GCRYCTL_SET_ALLOW_WEAK_KEY.
About error code. You need to use gcry_err_code(error_code) to get the GPG_ERR_WEAK_KEY value.
Apr 17 2023
Apr 17 2023
jukivili added a comment to T6451: libgcrypt | gcry_cipher_setkey: 3DES-CBC key returns GPG_ERR_WEAK even with GCRYCTL_SET_ALLOW_WEAK_KEY.
I'll add documentation about GCRYCTL_SET_ALLOW_WEAK_KEY which was missing from be original commit.
jukivili added a comment to T6451: libgcrypt | gcry_cipher_setkey: 3DES-CBC key returns GPG_ERR_WEAK even with GCRYCTL_SET_ALLOW_WEAK_KEY.
tests/basic now actually fail because setkey not returning GPG_ERR_WEAK_KEY for weak keys with GCRYCTL_SET_ALLOW_WEAK_KEY.
jukivili added a comment to T6451: libgcrypt | gcry_cipher_setkey: 3DES-CBC key returns GPG_ERR_WEAK even with GCRYCTL_SET_ALLOW_WEAK_KEY.
That's right. With GCRYCTL_SET_ALLOW_WEAK_KEY, setkey still returns GPG_ERR_WEAK_KEY when weak key is detected. However, cipher handle can still be used as if setkey succeeded.
Apr 3 2023
Apr 3 2023
jukivili committed rC278ba98497e1: cipher-gcm-ppc: tweak loop structure a bit (authored by jukivili).
cipher-gcm-ppc: tweak loop structure a bit
Mar 30 2023
Mar 30 2023
Here's mirroring script that is in place currently:
#!/bin/bash -eMar 19 2023
Mar 19 2023
jukivili committed rC79a79d3dc626: camellia-simd128: use 8-bit right shift for rotate function (authored by jukivili).
camellia-simd128: use 8-bit right shift for rotate function
jukivili committed rC3c98ae9cb60a: camellia-gfni: use GFNI for uint8 right shift in FLS (authored by jukivili).
camellia-gfni: use GFNI for uint8 right shift in FLS
Mar 6 2023
Mar 6 2023
jukivili committed rC855f8c513d6d: rijndael-ppc: use vector registers for key schedule calculations (authored by jukivili).
rijndael-ppc: use vector registers for key schedule calculations
Add PowerPC vector implementation of SM4
jukivili committed rC6c05c808e4e8: camellia-simd128: faster sbox filtering with uint8 right shift (authored by jukivili).
camellia-simd128: faster sbox filtering with uint8 right shift
jukivili committed rC652598096325: chacha20-ppc: do not generate p9 code when target attr unavailable (authored by jukivili).
chacha20-ppc: do not generate p9 code when target attr unavailable
Mar 1 2023
Mar 1 2023
jukivili committed rC0a5f7e9543a8: Fix "'inline' is not at beginning of declaration" warnings (authored by jukivili).
Fix "'inline' is not at beginning of declaration" warnings
jukivili committed rC66bae697a853: Improve PPC target function attribute checks (authored by jukivili).
Improve PPC target function attribute checks
jukivili committed rC898c857206ad: camellia: add AArch64 crypto-extension implementation (authored by jukivili).
camellia: add AArch64 crypto-extension implementation
jukivili committed rC6fa11d8b7070: camellia: add POWER8/POWER9 vcrypto implementation (authored by jukivili).
camellia: add POWER8/POWER9 vcrypto implementation
Feb 28 2023
Feb 28 2023
jukivili committed rC0d42d9674458: aes-amd64-vaes: fix fast exit path in XTS function (authored by jukivili).
aes-amd64-vaes: fix fast exit path in XTS function
jukivili committed rCf3d1d4a8c9f0: chacha20-ppc: use target and optimize attributes for P8 and P9 (authored by jukivili).
chacha20-ppc: use target and optimize attributes for P8 and P9
jukivili committed rC937a76a34540: ppc: add support for clang target attribute (authored by jukivili).
ppc: add support for clang target attribute
jukivili committed rC100063cf4e1c: aes-ppc: use target and optimize attributes for P8 and P9 (authored by jukivili).
aes-ppc: use target and optimize attributes for P8 and P9
aes-ppc: add CTR32LE bulk acceleration
jukivili committed rCa7ebf9d52e67: aes-ppc: add ECB bulk acceleration for benchmarking purposes (authored by jukivili).
aes-ppc: add ECB bulk acceleration for benchmarking purposes
sha2-ppc: better optimization for POWER9
Feb 26 2023
Feb 26 2023
jukivili committed rCdd4cb5d75c8e: camellia-aesni-avx: speed up for round key broadcasting (authored by jukivili).
camellia-aesni-avx: speed up for round key broadcasting
jukivili committed rCa4c22331f57d: camellia-gfni-avx512: speed up for round key broadcasting (authored by jukivili).
camellia-gfni-avx512: speed up for round key broadcasting
jukivili committed rCb9a9755742c7: camellia-avx2: speed up for round key broadcasting (authored by jukivili).
camellia-avx2: speed up for round key broadcasting
jukivili committed rC5f25ad09fdb5: camellia-avx2: add fast path for full 32 block ECB input (authored by jukivili).
camellia-avx2: add fast path for full 32 block ECB input
jukivili committed rC87ae2a660d59: camellia: add CTR-mode byte addition for AVX/AVX2/AVX512 impl. (authored by jukivili).
camellia: add CTR-mode byte addition for AVX/AVX2/AVX512 impl.
jukivili committed rC926cc22058a3: camellia-aesni-avx: add acceleration for ECB/XTS/CTR32LE modes (authored by jukivili).
camellia-aesni-avx: add acceleration for ECB/XTS/CTR32LE modes
jukivili committed rC978b02fca682: sm4: add CTR-mode byte addition for AVX/AVX2/AVX512 implementations (authored by jukivili).
sm4: add CTR-mode byte addition for AVX/AVX2/AVX512 implementations
jukivili committed rC8f7f5a9fc639: aes-vaes-avx2: improve case when only CTR needs carry handling (authored by jukivili).
aes-vaes-avx2: improve case when only CTR needs carry handling
Feb 22 2023
Feb 22 2023
jukivili committed rCcaf402e9b41f: aria-avx2: add VAES accelerated implementation (authored by jukivili).
aria-avx2: add VAES accelerated implementation
jukivili committed rCf359a3ec7e84: aria-avx512: small optimization for aria_diff_m (authored by jukivili).
aria-avx512: small optimization for aria_diff_m
jukivili committed rC855f1551fd92: aria-avx: small optimization for aria_ark_8way (authored by jukivili).
aria-avx: small optimization for aria_ark_8way
jukivili committed rC45351e6474cb: aria: add x86_64 GFNI/AVX512 accelerated implementation (authored by jukivili).
aria: add x86_64 GFNI/AVX512 accelerated implementation
jukivili committed rCf4268a8f51a8: aria: add x86_64 AESNI/GFNI/AVX/AVX2 accelerated implementations (authored by jukivili).
aria: add x86_64 AESNI/GFNI/AVX/AVX2 accelerated implementations
Jan 21 2023
Jan 21 2023
jukivili committed rC833a904faf2b: asm-common-aarch64: fix read-only section for Windows target (authored by jukivili).
asm-common-aarch64: fix read-only section for Windows target
Jan 20 2023
Jan 20 2023
aarch64-asm: align functions to 16 bytes
jukivili committed rC65f52773d4bb: s390x-asm: move constant data to read-only section (authored by jukivili).
s390x-asm: move constant data to read-only section
jukivili committed rCb3d7d520a0aa: aarch64-asm: move constant data to read-only section (authored by jukivili).
aarch64-asm: move constant data to read-only section
jukivili committed rCd0a109148b79: powerpc-asm: move constant data to read-only section (authored by jukivili).
powerpc-asm: move constant data to read-only section
jukivili committed rC12ad3ea6b49b: mpi/amd64: align functions and inner loops to 16 bytes (authored by jukivili).
mpi/amd64: align functions and inner loops to 16 bytes
jukivili committed rC9d62c54de2b0: amd64-asm: align functions to 16 bytes for cipher algos (authored by jukivili).
amd64-asm: align functions to 16 bytes for cipher algos
jukivili committed rC14137d685cf8: amd64-asm: move constant data to read-only section for hash/mac algos (authored by jukivili).
amd64-asm: move constant data to read-only section for hash/mac algos
jukivili committed rC208b1f3a7bd8: amd64-asm: move constant data to read-only section for cipher algos (authored by jukivili).
amd64-asm: move constant data to read-only section for cipher algos
jukivili committed rCec57b50bc60a: tests/bench-slope: skip CPU warm-up in regression tests (authored by jukivili).
tests/bench-slope: skip CPU warm-up in regression tests
jukivili committed rC308a70ac9907: tests/basic: perform x86 vector cluttering only when __SSE2__ is set (authored by jukivili).
tests/basic: perform x86 vector cluttering only when __SSE2__ is set
jukivili committed rC1a758b08bba0: tests/basic: fix clutter vector register asm for amd64 and i386 (authored by jukivili).
tests/basic: fix clutter vector register asm for amd64 and i386
jukivili committed rC7de2fb66e065: avx512: tweak zmm16-zmm31 register clearing (authored by jukivili).
avx512: tweak zmm16-zmm31 register clearing
Jan 10 2023
Jan 10 2023
aria: add generic 2-way bulk processing
Add ARIA block cipher
Jan 6 2023
Jan 6 2023
jukivili committed rC86db4b02c6e5: bulkhelp: change bulk function definition to allow modifying context (authored by jukivili).
bulkhelp: change bulk function definition to allow modifying context
jukivili committed rC30c9a1d101b4: sm4: add missing OCB 16-way GFNI-AVX512 path (authored by jukivili).
sm4: add missing OCB 16-way GFNI-AVX512 path
jukivili committed rCf2153d797f43: Fix compiler warnings seen with clang-powerpc64le target (authored by jukivili).
Fix compiler warnings seen with clang-powerpc64le target
Add GMAC-SM4 and Poly1305-SM4
Dec 20 2022
Dec 20 2022
Dec 15 2022
Dec 15 2022
jukivili committed rC02d5d1d97b3f: Add clang support for ARM 32-bit assembly (authored by jukivili).
Add clang support for ARM 32-bit assembly
Dec 14 2022
Dec 14 2022
jukivili committed rC3d20308cc529: rijndael-ppc: fix wrong inline assembly constraint (authored by jukivili).
rijndael-ppc: fix wrong inline assembly constraint
jukivili committed rC31837163fbc3: Fix building AVX512 Intel-syntax assembly with x86-64 clang (authored by jukivili).
Fix building AVX512 Intel-syntax assembly with x86-64 clang
Dec 12 2022
Dec 12 2022
jukivili committed rC8b4e0e9e9a36: avx512: tweak AVX512 spec stop, use common macro in assembly (authored by jukivili).
avx512: tweak AVX512 spec stop, use common macro in assembly
jukivili committed rC996f81dd86ab: chacha20-avx512: add handling for any input block count and tweak 16 block code… (authored by jukivili).
chacha20-avx512: add handling for any input block count and tweak 16 block code…
Nov 26 2022
Nov 26 2022
Any comments on applying these to gnupg-2.2?
Oct 28 2022
Oct 28 2022
Yep. Closed now.
jukivili closed T4485: Add AEAD mode AES-GCM-SIV to libgcrypt (RFC 8452), a subtask of T4486: Add AEAD mode AES-SIV to libgcrypt (RFC 5297), as Resolved.
Oct 27 2022
Oct 27 2022
• gniibe awarded T6242: libgcrypt: optimize ECB? (as it may be used to estimate library crypto performance) a Yellow Medal token.
• werner awarded T6242: libgcrypt: optimize ECB? (as it may be used to estimate library crypto performance) a Cup of Joe token.
Oct 26 2022
Oct 26 2022
sha3-avx512: fix for "x32" target
twofish: accelerate XTS and ECB modes
jukivili committed rCb50b7ea5caba: serpent: fix compiler warning on 32-bit ARM (authored by jukivili).
serpent: fix compiler warning on 32-bit ARM
serpent: accelerate XTS and ECB modes
sm4: accelerate ECB (for benchmarking)
jukivili committed rC6475d0915ffe: camellia: accelerate ECB (for benchmarking) (authored by jukivili).
camellia: accelerate ECB (for benchmarking)
sm4: fix lookup-table prefetching
rijndael-vaes: align asm functions
jukivili committed rC84f3d41acb23: rijndael: add ECB acceleration (for benchmarking purposes) (authored by jukivili).
rijndael: add ECB acceleration (for benchmarking purposes)
jukivili committed rCbf5ec001dfcb: mpi/longlong: update powerpc macros from GCC (authored by jukivili).
mpi/longlong: update powerpc macros from GCC
jukivili committed rC4b1cb76e3587: hwf-x86: enable VPGATHER usage for AMD CPUs with AVX512 (authored by jukivili).
hwf-x86: enable VPGATHER usage for AMD CPUs with AVX512
jukivili committed rCc0f85e0c8657: sha512-avx512: enable only on Intel CPUs for now (authored by jukivili).
sha512-avx512: enable only on Intel CPUs for now
Oct 16 2022
Oct 16 2022
Oct 8 2022
Oct 8 2022
jukivili closed T6232: Documentation refers to wrong the RFC for GCM-SIV cipher mode (GCRY_CIPHER_MODE_GCM_SIV) as Resolved.
Thanks. Fix has been pushed to master.
doc: fix RFC reference for GCM-SIV
jukivili committed rCf01d4b7a601f: mpi/longlong.h: i386: use tzcnt instruction for trailing zeros (authored by jukivili).
mpi/longlong.h: i386: use tzcnt instruction for trailing zeros
jukivili committed rC38bd31bc46b9: mpi/longlong.h: x86-64: use tzcnt instruction for trailing zeros (authored by jukivili).
mpi/longlong.h: x86-64: use tzcnt instruction for trailing zeros
jukivili committed rCd67f453d1b9d: mpi/longlong: fix generic smul_ppmm ifdef (authored by jukivili).
mpi/longlong: fix generic smul_ppmm ifdef
jukivili committed rCaef0ddf4d37a: mpi/longlong: provide generic implementation using double word type (authored by jukivili).
mpi/longlong: provide generic implementation using double word type
Oct 2 2022
Oct 2 2022
tests: Avoid memory leak
jukivili committed rC0909186b9e66: t-rsa-testparm: fix 'function declaration isn’t a prototype' warning (authored by jukivili).
t-rsa-testparm: fix 'function declaration isn’t a prototype' warning
tests/benchmark: remove VLA usage
tests/bench-slope: remove VLA usage
cipher-ccm: remove VLA usage
mpi/ec: remove VLA usage
Patch applied to master, thanks.