Page MenuHome GnuPG
Feed Advanced Search

Sep 20 2023

ikloecker added a comment to T6725: Kleopatra: encryption via menu button does only encrypt files, not folders.

No. Windows has a file selection dialog where you can only select files and a folder selection dialog where you can only select folders. We cannot change Windows (and we will not use a non-native file dialog).

Sep 20 2023, 9:13 PM · kleopatra, Restricted Project
ikloecker committed rLIBKLEO079315385a26: Fix regression in outputFileExtension (authored by ikloecker).
Fix regression in outputFileExtension
Sep 20 2023, 12:46 PM
ikloecker claimed T6726: Kleopatra: Sign & Encrypt Folder suggests wrong output file name.
Sep 20 2023, 12:37 PM · Restricted Project, kleopatra, Bug Report
ikloecker triaged T6726: Kleopatra: Sign & Encrypt Folder suggests wrong output file name as High priority.

This is a serious regression.

Sep 20 2023, 11:34 AM · Restricted Project, kleopatra, Bug Report
ikloecker created T6726: Kleopatra: Sign & Encrypt Folder suggests wrong output file name.
Sep 20 2023, 11:33 AM · Restricted Project, kleopatra, Bug Report

Sep 19 2023

ikloecker created T6722: Kleopatra: Forbid adding non-encryption keys to groups.
Sep 19 2023, 12:15 PM · vsd33 (vsd-3.3.0), kleopatra, Restricted Project
ikloecker committed rMTP905dc2a15a72: Fix redefinition of TRANSLATION_DOMAIN (authored by ikloecker).
Fix redefinition of TRANSLATION_DOMAIN
Sep 19 2023, 10:00 AM
ikloecker committed rMTPa04ec32009e9: Fix redefinition of TRANSLATION_DOMAIN (authored by ikloecker).
Fix redefinition of TRANSLATION_DOMAIN
Sep 19 2023, 9:58 AM
ikloecker committed rMTP343d2d3345f5: Avoid "unused variable" warnings (authored by ikloecker).
Avoid "unused variable" warnings
Sep 19 2023, 9:47 AM
ikloecker committed rMTP1c0b1f97ea37: Avoid "unused variable" warnings (authored by ikloecker).
Avoid "unused variable" warnings
Sep 19 2023, 9:43 AM
ikloecker triaged T6721: QGpgME: Create archive as .part and rename on successful creation as Normal priority.
Sep 19 2023, 9:25 AM · vsd32 (vsd-3.2.0), Restricted Project, gpgme, kleopatra

Sep 18 2023

ikloecker added a comment to T5960: Kleopatra: Encoding problems with GnuPG output on Windows.

With the latest change the output read directly from gpg should now be displayed correctly.

Sep 18 2023, 12:27 PM · vsd33 (vsd-3.3.0), Restricted Project, kleopatra
ikloecker committed rLIBKLEO61b99b58aa7b: Always use UTF-8 for decoding GnuPG output on Windows (authored by ikloecker).
Always use UTF-8 for decoding GnuPG output on Windows
Sep 18 2023, 12:20 PM

Sep 15 2023

ikloecker committed rKLEOPATRA9463123a8e97: Make logic when command is finished more clear (authored by ikloecker).
Make logic when command is finished more clear
Sep 15 2023, 9:48 AM
ikloecker committed rKLEOPATRA29b7a708a65c: Replace own MessageViewerDialog with the one from MTP (authored by CarlSchwan).
Replace own MessageViewerDialog with the one from MTP
Sep 15 2023, 9:48 AM
ikloecker committed rKLEOPATRA915c929888bd: feat(messageviewerdialog): Support opening multiple messages simultaneously (authored by CarlSchwan).
feat(messageviewerdialog): Support opening multiple messages simultaneously
Sep 15 2023, 9:48 AM
ikloecker committed rKLEOPATRA51f3f7d35b2a: feat(decryptverifyfilescommand): Open mail viewer directly (authored by CarlSchwan).
feat(decryptverifyfilescommand): Open mail viewer directly
Sep 15 2023, 9:48 AM
ikloecker committed rKLEOPATRA7e29974ea415: Make logic when command is finished more clear (authored by ikloecker).
Make logic when command is finished more clear
Sep 15 2023, 9:48 AM

Sep 13 2023

ikloecker placed T5960: Kleopatra: Encoding problems with GnuPG output on Windows up for grabs.

As far as I can tell and see with my limited tests, everything works (for me). There's nothing else I can do and I don't have the slightest clue why it seems to fail sometimes. Somebody else needs to take over.

Sep 13 2023, 12:15 PM · vsd33 (vsd-3.3.0), Restricted Project, kleopatra
ikloecker added a comment to T5960: Kleopatra: Encoding problems with GnuPG output on Windows.

With regard to invalid characters in error messages as in T5960#172860:
We are using the identical function everywhere to convert the error codes to text. If an invalid character is displayed if copying a key to a smart card failed, then invalid characters should also be displayed for example if one tries to decrypt something in the notepad without having the necessary secret key. I get "Kein geheimer Schlüssel" in this case, i.e. no invalid character.

Sep 13 2023, 12:14 PM · vsd33 (vsd-3.3.0), Restricted Project, kleopatra
ikloecker added a comment to T5960: Kleopatra: Encoding problems with GnuPG output on Windows.

The remaining problem with output that's read directly from a GnuPG process seems to be that sometimes gpgconf --show-codepages prints 0 as ConsoleOutputCodePage or even as ACP (as in T5960#175580).

Sep 13 2023, 11:44 AM · vsd33 (vsd-3.3.0), Restricted Project, kleopatra
ikloecker added a comment to T5960: Kleopatra: Encoding problems with GnuPG output on Windows.

I tried to reproduce this with a locally built gpg4win-4.2.1-beta56. Using localhost as keyserver I got (after a looooooong timeout)

Sep 13 2023, 11:33 AM · vsd33 (vsd-3.3.0), Restricted Project, kleopatra

Sep 11 2023

ikloecker committed rKLEOPATRAf45c652e755b: Skip check if key is eligible for WKD refresh if WKD query is forced (authored by ikloecker).
Skip check if key is eligible for WKD refresh if WKD query is forced
Sep 11 2023, 4:19 PM
ikloecker committed rKLEOPATRAf01bd64babc0: Keep the line breaks in the output of gpg (authored by ikloecker).
Keep the line breaks in the output of gpg
Sep 11 2023, 12:13 PM
ikloecker reassigned T5903: Kleopatra: Add refresh button in certificatedetails from ikloecker to ebo.

Why do you think that no WKD lookup occurs for keys of unknown origin? gpg and therefore Kleopatra doesn't report any import results for certificates that are not published via WKD when doing --locate-external-keys --auto-key-locate clear,wkd.

Sep 11 2023, 9:48 AM · backport, kleopatra, Restricted Project

Sep 8 2023

ikloecker committed rLIBKLEO45a793052f1d: Avoid useless decoding of empty string (authored by ikloecker).
Avoid useless decoding of empty string
Sep 8 2023, 6:22 PM
ikloecker committed rLIBKLEOb3aa9a108a86: Ignore terminating null character when decoding output (authored by ikloecker).
Ignore terminating null character when decoding output
Sep 8 2023, 6:14 PM
ikloecker added a comment to T5960: Kleopatra: Encoding problems with GnuPG output on Windows.
In T5960#175407, @ebo wrote:

The result of your changes is a bit unexpected for me, maybe something is missing in the testversion Gpg4win-4.2.1-beta31?

[6064] org.kde.pim.libkleo: gpgConfGetConsoleOutputCodePage returns 65001
[6064] org.kde.pim.libkleo: stringFromGpgOutput trying to decode "" using codepage 65001
Sep 8 2023, 6:00 PM · vsd33 (vsd-3.3.0), Restricted Project, kleopatra
ikloecker committed rW49ee727581a8: Allow specifying a different build root for the AppImage (authored by ikloecker).
Allow specifying a different build root for the AppImage
Sep 8 2023, 4:52 PM
ikloecker committed rLIBKLEO2342c78d42c8: Bump library version (authored by ikloecker).
Bump library version
Sep 8 2023, 11:09 AM
ikloecker committed rLIBKLEOa71c2b2605e2: Make helpers for checking protocol of ranges of keys public (authored by ikloecker).
Make helpers for checking protocol of ranges of keys public
Sep 8 2023, 11:09 AM

Sep 7 2023

ikloecker committed rKLEOPATRA48209313616d: Minor refactoring to reduce code duplication (authored by ikloecker).
Minor refactoring to reduce code duplication
Sep 7 2023, 3:21 PM
ikloecker committed rKLEOPATRAf2025d095cc2: Remove update of certificate (authored by ikloecker).
Remove update of certificate
Sep 7 2023, 3:21 PM
ikloecker committed rKLEOPATRAa0883cbbcf7d: Ensure that tags of all keys are loaded (authored by ikloecker).
Ensure that tags of all keys are loaded
Sep 7 2023, 3:21 PM
ikloecker committed rKLEOPATRAe40a2a7a23c5: Skip disabled user IDs when looking for existing tags (authored by ikloecker).
Skip disabled user IDs when looking for existing tags
Sep 7 2023, 3:21 PM
ikloecker committed rKLEOPATRAb053ff4beda0: Factor out setup of widget after setting certificate(s) (authored by ikloecker).
Factor out setup of widget after setting certificate(s)
Sep 7 2023, 3:21 PM
ikloecker added a comment to rMTPd3fc19ccfa57: Add test for decrypting email.

I think using a static const char * is better than using a macro. In fact, using a static constexpr std::string may be even better because we avoid calculating the string length during runtime again and again. (I'm not sure the compiler is clever enough to precalculate the string length of a static const char *.)

Sep 7 2023, 3:15 PM

Sep 6 2023

ikloecker added a comment to T6556: gpgtar: Removes existing output file on error.

@iklocker: Which gpg bug to you mean?

Sep 6 2023, 3:44 PM · gnupg24 (gnupg-2.4.2), gnupg22 (gnupg-2.2.42), Restricted Project, gpgtar, Bug Report
ikloecker added a comment to T5960: Kleopatra: Encoding problems with GnuPG output on Windows.

Then gettext_use_utf8 doesn't seem to be working as intended.

Sep 6 2023, 3:41 PM · vsd33 (vsd-3.3.0), Restricted Project, kleopatra
ikloecker added a comment to T5960: Kleopatra: Encoding problems with GnuPG output on Windows.

Hopefully, we will soon have a Windows CI to catch such errors.

Sep 6 2023, 11:59 AM · vsd33 (vsd-3.3.0), Restricted Project, kleopatra
ikloecker committed rLIBKLEOd10be5034b8f: Fix Windows build (authored by ikloecker).
Fix Windows build
Sep 6 2023, 11:58 AM
ikloecker committed rLIBKLEOf649815ad726: Fix Windows build (authored by ikloecker).
Fix Windows build
Sep 6 2023, 11:57 AM

Sep 5 2023

ikloecker placed T5960: Kleopatra: Encoding problems with GnuPG output on Windows up for grabs.

Also, please retest T5960#172860 with the latest build.

Sep 5 2023, 3:32 PM · vsd33 (vsd-3.3.0), Restricted Project, kleopatra
ikloecker added a comment to T5960: Kleopatra: Encoding problems with GnuPG output on Windows.

The previous two changes will hopefully fix the error output of export to server. I'm not entirely sure about the missing line breaks.

Sep 5 2023, 3:22 PM · vsd33 (vsd-3.3.0), Restricted Project, kleopatra
ikloecker committed rLIBKLEO167c4ae6a5cd: Convert Windows line endings to POSIX line endings (authored by ikloecker).
Convert Windows line endings to POSIX line endings
Sep 5 2023, 3:18 PM
ikloecker committed rLIBKLEOf13da743e140: Convert Windows line endings to POSIX line endings (authored by ikloecker).
Convert Windows line endings to POSIX line endings
Sep 5 2023, 3:18 PM
ikloecker committed rLIBKLEO6c564028299d: Fall back to ANSI code page if console output code page is 0 (authored by ikloecker).
Fall back to ANSI code page if console output code page is 0
Sep 5 2023, 3:09 PM
ikloecker committed rLIBKLEO0b6d5c35534a: Fall back to ANSI code page if console output code page is 0 (authored by ikloecker).
Fall back to ANSI code page if console output code page is 0
Sep 5 2023, 3:08 PM
ikloecker added a comment to T5960: Kleopatra: Encoding problems with GnuPG output on Windows.

With regard to the ü-error in the error message on keytocard somebody else has to check what's going wrong because I'm convinced that we are doing everything right.

Sep 5 2023, 2:25 PM · vsd33 (vsd-3.3.0), Restricted Project, kleopatra
ikloecker added a comment to T5960: Kleopatra: Encoding problems with GnuPG output on Windows.

The debug output of libkleo is missing. Please add org.kde.pim.libkleo.debug=true to your qtlogging.ini.

Sep 5 2023, 2:15 PM · vsd33 (vsd-3.3.0), Restricted Project, kleopatra
ikloecker assigned T5960: Kleopatra: Encoding problems with GnuPG output on Windows to ebo.

Please provide the debug output, so that I can see which encoding was used to decode the error message.

Sep 5 2023, 1:30 PM · vsd33 (vsd-3.3.0), Restricted Project, kleopatra
ikloecker added a comment to T5960: Kleopatra: Encoding problems with GnuPG output on Windows.
In T5960#175302, @ebo wrote:

Found in GnuPG-VS-Desktop-3.2.0-beta178, broken ü and no linebreaks:

Setting this to high after consultation with @werner, these issues should be fixed in next release.

Sep 5 2023, 1:22 PM · vsd33 (vsd-3.3.0), Restricted Project, kleopatra

Sep 4 2023

ikloecker committed rLIBKLEO6b582c2647d8: Use qEnvironmentVariableIntValue() instead of slow qgetenv().toInt() (authored by ikloecker).
Use qEnvironmentVariableIntValue() instead of slow qgetenv().toInt()
Sep 4 2023, 11:18 PM
ikloecker committed rLIBKLEOb8b95d5b7b19: Use new-style connect (authored by ikloecker).
Use new-style connect
Sep 4 2023, 11:18 PM
ikloecker committed rLIBKLEOea1432d4acde: Use an empty QLatin1String instead of an empty QStringLiteral (authored by ikloecker).
Use an empty QLatin1String instead of an empty QStringLiteral
Sep 4 2023, 11:18 PM
ikloecker committed rLIBKLEOa7e631a82573: Make ninja keep going if jobs fail (authored by ikloecker).
Make ninja keep going if jobs fail
Sep 4 2023, 11:18 PM
ikloecker committed rLIBKLEO799211f978af: Start with clazy level0 checks and disable clang-tidy (authored by ikloecker).
Start with clazy level0 checks and disable clang-tidy
Sep 4 2023, 11:18 PM
ikloecker committed rLIBKLEO52c021b529c8: Add adapted version of okular's build_clazy_clang_tidy job (authored by ikloecker).
Add adapted version of okular's build_clazy_clang_tidy job
Sep 4 2023, 11:18 PM
ikloecker committed rLIBKLEO6a1638617877: Use correct package name (authored by ikloecker).
Use correct package name
Sep 4 2023, 11:18 PM
ikloecker committed rLIBKLEOd9b6cd5b3fbe: Use new-style connect (authored by ikloecker).
Use new-style connect
Sep 4 2023, 11:17 PM
ikloecker committed rLIBKLEOcdb77a65368c: Use qEnvironmentVariableIntValue() instead of slow qgetenv().toInt() (authored by ikloecker).
Use qEnvironmentVariableIntValue() instead of slow qgetenv().toInt()
Sep 4 2023, 11:17 PM
ikloecker committed rLIBKLEO544471f21be0: Use an empty QLatin1String instead of an empty QStringLiteral (authored by ikloecker).
Use an empty QLatin1String instead of an empty QStringLiteral
Sep 4 2023, 11:17 PM
ikloecker committed rLIBKLEO8a8d8ba62fff: Do not skip non-hex digits (authored by ikloecker).
Do not skip non-hex digits
Sep 4 2023, 11:02 PM
ikloecker committed rLIBKLEO7e4504754fef: Remove unused variable (authored by ikloecker).
Remove unused variable
Sep 4 2023, 11:02 PM
ikloecker committed rLIBKLEO543b79deb4e8: Make ninja keep going if jobs fail (authored by ikloecker).
Make ninja keep going if jobs fail
Sep 4 2023, 10:03 PM
ikloecker committed rLIBKLEOcd462e895799: Start with clazy level0 checks and disable clang-tidy (authored by ikloecker).
Start with clazy level0 checks and disable clang-tidy
Sep 4 2023, 9:54 PM
ikloecker committed rLIBKLEO20e77179fa83: Use correct package name (authored by ikloecker).
Use correct package name
Sep 4 2023, 9:48 PM
ikloecker committed rLIBKLEOf53ed2f66d50: Add adapted version of okular's build_clazy_clang_tidy job (authored by ikloecker).
Add adapted version of okular's build_clazy_clang_tidy job
Sep 4 2023, 9:45 PM
ikloecker committed rM8fde9cbe2288: tests: Re-add --with-secret option (authored by ikloecker).
tests: Re-add --with-secret option
Sep 4 2023, 5:33 PM
ikloecker closed T6704: Kleopatra: Wrong export of key groups as Resolved.

This is hopefully resolved. Setting to done because the fix cannot be verified with our builds of Kleopatra.

Sep 4 2023, 2:57 PM · Restricted Project, kleopatra, Bug Report
ikloecker added a comment to T6704: Kleopatra: Wrong export of key groups.

It also doesn't occur with the AppImage (Do we build a debug or unoptimized build for the AppImage?).

Sep 4 2023, 2:56 PM · Restricted Project, kleopatra, Bug Report
ikloecker committed rLIBKLEO19b514e46118: Don't use auto when concatenating QStrings to avoid QStringBuilder (authored by ikloecker).
Don't use auto when concatenating QStrings to avoid QStringBuilder
Sep 4 2023, 2:50 PM
ikloecker committed rLIBKLEO10be6bbdb881: Don't use auto when concatenating QStrings to avoid QStringBuilder (authored by ikloecker).
Don't use auto when concatenating QStrings to avoid QStringBuilder
Sep 4 2023, 2:49 PM
ikloecker committed rLIBKLEO65d29c4e9a97: Don't use auto when concatenating QStrings to avoid QStringBuilder (authored by ikloecker).
Don't use auto when concatenating QStrings to avoid QStringBuilder
Sep 4 2023, 2:49 PM
ikloecker claimed T6704: Kleopatra: Wrong export of key groups.
Sep 4 2023, 2:36 PM · Restricted Project, kleopatra, Bug Report
ikloecker added a comment to T6704: Kleopatra: Wrong export of key groups.

The problem doesn't occur with the development build. It also doesn't seem to occur with our Windows build.

Sep 4 2023, 2:36 PM · Restricted Project, kleopatra, Bug Report
ikloecker created T6704: Kleopatra: Wrong export of key groups.
Sep 4 2023, 2:35 PM · Restricted Project, kleopatra, Bug Report
ikloecker added a comment to T6696: qgpgme-qt6: Build failure for some distributions.

I found this in the change log of Qt 5.4.2:

- On x86 and x86-64 systems with ELF binaries (especially Linux), due to
  a new optimization in GCC 5.x in combination with a recent version of
  GNU binutils, compiling Qt applications with -fPIE is no longer
  enough with GCC 5.x. Applications now need to be compiled with
  the -fPIC option if Qt's option "reduce relocations" is active. For
  backward compatibility only, Qt accepts the use of -fPIE for GCC 4.x
  versions.
  Note that Clang is known to generate incompatible code even with -fPIC if
  the -flto option is active.
Sep 4 2023, 12:38 PM · Restricted Project, gpgme, Bug Report
ikloecker committed rKLEOPATRA9cc3dde882f8: Optionally, query WKDs for all user IDs when updating an OpenPGP key (authored by ikloecker).
Optionally, query WKDs for all user IDs when updating an OpenPGP key
Sep 4 2023, 12:01 PM

Sep 1 2023

ikloecker committed rKLEOPATRA8afe8de85606: Add bulk certification mode to certify widget (authored by ikloecker).
Add bulk certification mode to certify widget
Sep 1 2023, 9:02 PM
ikloecker committed rKLEOPATRA3056a8c29022: Add bulk certification mode to certify widget (authored by ikloecker).
Add bulk certification mode to certify widget
Sep 1 2023, 5:32 PM
ikloecker committed rKLEOPATRA0c5ba0786950: Add simple helper for changing visibility of multiple widgets at once (authored by ikloecker).
Add simple helper for changing visibility of multiple widgets at once
Sep 1 2023, 5:32 PM
ikloecker committed rKLEOPATRA70da7958f22f: Update size of content area just before showing it (authored by ikloecker).
Update size of content area just before showing it
Sep 1 2023, 5:32 PM
ikloecker committed rKLEOPATRAa5d5a8d536a7: Store a list of certificates to certify (authored by ikloecker).
Store a list of certificates to certify
Sep 1 2023, 5:32 PM
ikloecker triaged T6699: Kleopatra: Ask for confirmation when overwriting existing tags during certification as Normal priority.
Sep 1 2023, 5:18 PM · gpd5x, kleopatra
ikloecker changed the status of T6698: Kleopatra: Not all User IDs tagged with chosen tag selected when certifying a certificate from Open to Testing.

Fixed. I'll copy the ideas in comment T6698#175165 to a separate task.

Sep 1 2023, 5:13 PM · kleopatra, Restricted Project, Bug Report
ikloecker committed rKLEOPATRAd44cfb0f8039: Fix selection of all user IDs with tags matching Tags value (authored by ikloecker).
Fix selection of all user IDs with tags matching Tags value
Sep 1 2023, 5:11 PM
ikloecker claimed T6698: Kleopatra: Not all User IDs tagged with chosen tag selected when certifying a certificate.
Sep 1 2023, 4:01 PM · kleopatra, Restricted Project, Bug Report
ikloecker created T6698: Kleopatra: Not all User IDs tagged with chosen tag selected when certifying a certificate.
Sep 1 2023, 4:01 PM · kleopatra, Restricted Project, Bug Report
ikloecker changed the status of T6697: Kleopatra: Wrong User IDs selected when certifying specific User IDs and other User IDs have tags from Open to Testing.

Fixed. Backport? (Depends on first preparations for bulk certification and is probably not really relevant for VSD.)

Sep 1 2023, 3:51 PM · kleopatra, Restricted Project, Bug Report
ikloecker committed rKLEOPATRA1b0f7028d30e: Only offer the user IDs to certify for certification (authored by ikloecker).
Only offer the user IDs to certify for certification
Sep 1 2023, 3:46 PM
ikloecker committed rKLEOPATRA873132070ccb: Fix incorrect logging about different remarks (authored by ikloecker).
Fix incorrect logging about different remarks
Sep 1 2023, 3:46 PM
ikloecker committed rKLEOPATRA8ba98378f2a7: Remove special handling of Escape when tool tip was shown (authored by ikloecker).
Remove special handling of Escape when tool tip was shown
Sep 1 2023, 3:46 PM
ikloecker claimed T6697: Kleopatra: Wrong User IDs selected when certifying specific User IDs and other User IDs have tags.
Sep 1 2023, 2:38 PM · kleopatra, Restricted Project, Bug Report
ikloecker created T6697: Kleopatra: Wrong User IDs selected when certifying specific User IDs and other User IDs have tags.
Sep 1 2023, 2:37 PM · kleopatra, Restricted Project, Bug Report
ikloecker added a comment to T6696: qgpgme-qt6: Build failure for some distributions.

The official build for Arch Linux doesn't seem to run into this problem. The Qt6 build is configured with

./configure \
  --prefix=/usr \
  --disable-fd-passing \
  --disable-static \
  --disable-gpgsm-test \
  --enable-languages=cpp,qt6

See https://archlinux.org/packages/core/x86_64/gpgme/

Sep 1 2023, 10:58 AM · Restricted Project, gpgme, Bug Report
ikloecker created T6696: qgpgme-qt6: Build failure for some distributions.
Sep 1 2023, 10:45 AM · Restricted Project, gpgme, Bug Report

Aug 31 2023

ikloecker committed rKLEOPATRA368d5a0e36c3: Add bulk certification mode to certify widget (authored by ikloecker).
Add bulk certification mode to certify widget
Aug 31 2023, 6:04 PM
ikloecker committed rKLEOPATRA32ef98985898: Add simple helper for changing visibility of multiple widgets at once (authored by ikloecker).
Add simple helper for changing visibility of multiple widgets at once
Aug 31 2023, 6:04 PM
ikloecker committed rKLEOPATRAc1eac8ed079e: Store a list of certificates to certify (authored by ikloecker).
Store a list of certificates to certify
Aug 31 2023, 6:04 PM