Page MenuHome GnuPG
Feed Advanced Search

May 23 2018

gniibe added a comment to T3980: gpg-agent: error allocating thread attributes when starting as daemon.

Thanks for your testing, it's near. Here is updated patch:


I think that HP-UX is just like *BSD for pthread and POSIX semaphore.
It is also good to add a test case. I will.

May 23 2018, 4:09 AM · npth, Bug Report

May 22 2018

gniibe added a comment to T3980: gpg-agent: error allocating thread attributes when starting as daemon.

Thanks for config.log of GnuPG. I think that I located the problem; While gpg-agent should be linked to -lpthread, it was not. The configure variable NPTH_LIBS in config.log doesn't have -lpthread. Thus, pthread_* are linked to the ones of stub, and it resulted the error.

May 22 2018, 6:46 AM · npth, Bug Report

May 18 2018

gniibe claimed T3980: gpg-agent: error allocating thread attributes when starting as daemon.

Thanks for quick feedback.
Yes, it is a build problem, which should be handled by configure + make.
Could you please upload the build log here, so that I can check it to fix configure.ac+Makefile.am?

May 18 2018, 8:37 AM · npth, Bug Report

May 17 2018

gniibe added a comment to T3980: gpg-agent: error allocating thread attributes when starting as daemon.

ENOSYS means it's linked to stub.
http://nixdoc.net/man-pages/HP-UX/man5/pthread_stubs.5.html
Somehow the build process may be wrong for the gpg-agent executable.

May 17 2018, 8:22 PM · npth, Bug Report

May 14 2018

gniibe committed rG61b1508281cd: po: Fix Swedish and Turkish translations. (authored by gniibe).
po: Fix Swedish and Turkish translations.
May 14 2018, 3:40 PM
gniibe committed rG49bbbd9dc5e1: po: Fix Danish translation. (authored by gniibe).
po: Fix Danish translation.
May 14 2018, 3:22 PM

May 8 2018

gniibe lowered the priority of T3731: gcry_pk_genkey() segfaults for ecdsa 384 from High to Normal.

I changed the priority to 'Normal'. The problem now is not the libssh usage, but how we can assume use of secure memory by random generator(s).

May 8 2018, 2:07 AM · libgcrypt, Bug Report
gniibe added a comment to T3731: gcry_pk_genkey() segfaults for ecdsa 384.

By libssh upstream, the problem has been fixed: commit-72f6b34

May 8 2018, 2:01 AM · libgcrypt, Bug Report

May 7 2018

gniibe added a comment to T3731: gcry_pk_genkey() segfaults for ecdsa 384.

Here is the function:
https://git.libssh.org/projects/libssh.git/tree/src/dh.c#n227

May 7 2018, 9:18 AM · libgcrypt, Bug Report
gniibe added a comment to T3731: gcry_pk_genkey() segfaults for ecdsa 384.

It would be better not to require gcry_control(GCRYCTL_CLOSE_RANDOM_DEVICE). Automatic handling through gcry_control(GCRYCTL_TERM_SECMEM) would be better.

May 7 2018, 2:32 AM · libgcrypt, Bug Report
gniibe added a comment to T3731: gcry_pk_genkey() segfaults for ecdsa 384.

The patch D461 makes gcry_control(GCRYCTL_CLOSE_RANDOM_DEVICE) free the allocated secure memory.

May 7 2018, 1:53 AM · libgcrypt, Bug Report
gniibe added a comment to T3731: gcry_pk_genkey() segfaults for ecdsa 384.

It assumes a change of libssh like:

May 7 2018, 1:52 AM · libgcrypt, Bug Report
gniibe added a comment to T3731: gcry_pk_genkey() segfaults for ecdsa 384.

Here is my patch: D461: jent random requires finalizer to deallocate secure memory

May 7 2018, 1:51 AM · libgcrypt, Bug Report
gniibe created D461: jent random requires finalizer to deallocate secure memory.
May 7 2018, 1:51 AM

Apr 25 2018

Esai awarded T2291: Smartcard interaction improvement (was: Shadowed private key design (for smartcard)) a Love token.
Apr 25 2018, 1:11 PM · Restricted Project, gnupg, Feature Request
gniibe committed rG71903eee8949: g10: Fix printing the keygrip with --card-status. (authored by gniibe).
g10: Fix printing the keygrip with --card-status.
Apr 25 2018, 2:40 AM

Apr 20 2018

gniibe added a comment to T3781: ECC encryption key on-card generation broken.

@nitroalex Perhaps, creating new ticker is better for this topic.
In the current OpenPGP card specification, there is no way for an application (except having a list of card implementation information) to know wich algo and which curve is supported or not.
So, what an application does is try and error.
I don't like this situation, but I don't know how we can modify the specification.

Apr 20 2018, 10:10 AM · g10, scd, Bug Report

Apr 16 2018

gniibe claimed T3731: gcry_pk_genkey() segfaults for ecdsa 384.
Apr 16 2018, 10:24 AM · libgcrypt, Bug Report

Apr 13 2018

gniibe added a project to T3900: Memory leak in check_sig_and_print: gnupg (gpg22).
Apr 13 2018, 9:47 AM · gnupg (gpg22), Bug Report
gniibe changed the status of T3900: Memory leak in check_sig_and_print from Open to Testing.
Apr 13 2018, 9:46 AM · gnupg (gpg22), Bug Report
gniibe added a comment to T3900: Memory leak in check_sig_and_print.

Thanks again. Good catch.
In Japanese 39 sounds like "Thank You!", that's indeed appropriate to your report. :-)

Apr 13 2018, 9:46 AM · gnupg (gpg22), Bug Report
gniibe committed rGf747b8f07343: g10: Fix memory leak in check_sig_and_print. (authored by gniibe).
g10: Fix memory leak in check_sig_and_print.
Apr 13 2018, 9:45 AM
gniibe committed rE792877a08ca7: doc: Fix yat2m build for cross compilation. (authored by gniibe).
doc: Fix yat2m build for cross compilation.
Apr 13 2018, 8:48 AM
gniibe renamed T3101: GnuPG 2.2 cannot import secret keys from 1.4/2.0's secring.gpg directly (if it is expired by original expiration date) from GnuPG 2.1 cannot import secret keys from GnuPG secring.gpg directly (if it is expired by original expiration date) to GnuPG 2.2 cannot import secret keys from 1.4/2.0's secring.gpg directly (if it is expired by original expiration date).
Apr 13 2018, 6:58 AM · workaround, gnupg, Bug Report
gniibe added a comment to T3101: GnuPG 2.2 cannot import secret keys from 1.4/2.0's secring.gpg directly (if it is expired by original expiration date).

I changed the title to express the problem.

Apr 13 2018, 6:57 AM · workaround, gnupg, Bug Report
gniibe renamed T3101: GnuPG 2.2 cannot import secret keys from 1.4/2.0's secring.gpg directly (if it is expired by original expiration date) from GnuPG 2.1 cannot import secret keys with missing primary key to GnuPG 2.1 cannot import secret keys from GnuPG secring.gpg directly (if it is expired by original expiration date).
Apr 13 2018, 6:57 AM · workaround, gnupg, Bug Report
gniibe added a comment to T3101: GnuPG 2.2 cannot import secret keys from 1.4/2.0's secring.gpg directly (if it is expired by original expiration date).

Thanks for the script.
I confirmed that secring.gpg is not updated when importing key with updated expiration date, by GPG1.
So, for GPG2, it is expired key.

Apr 13 2018, 6:54 AM · workaround, gnupg, Bug Report
gniibe claimed T3779: pinentry-curses broken when launched from tig that's launched from mc.
Apr 13 2018, 4:51 AM · Documentation, pinentry, Bug Report
gniibe added a comment to T3779: pinentry-curses broken when launched from tig that's launched from mc.

When a command is invoked from Midnight Commander, pseudo tty is used.
You can confirm that by typing tty and see the output of the command after exiting from mc and again typing tty.

Apr 13 2018, 4:50 AM · Documentation, pinentry, Bug Report
gniibe added a comment to T3878: not all calloc performed in libgcrypt covered by gcry_set_allocation_handler.

I am currently considering improvement of finalizer of libgcrypt, so, this matters.
Looking code, it would be better not to allocate and free the constant,
but use compile time constant data in .text section; Something like: const unsigned char ctr_null[DBRG_CTR_NULL_LEN].

Apr 13 2018, 4:17 AM · libgcrypt, Bug Report
gniibe changed the status of T3898: Memory leak in g10 handle_compressed from Open to Testing.

Applied to STABLE-BRANCH-1-4, too.

Apr 13 2018, 3:24 AM · gnupg (gpg14), Bug Report
gniibe committed rG0f8fd95ab32a: g10: Push compress filter only if compressed. (authored by gniibe).
g10: Push compress filter only if compressed.
Apr 13 2018, 3:23 AM
gniibe committed rGc31abf84659d: g10: Push compress filter only if compressed. (authored by gniibe).
g10: Push compress filter only if compressed.
Apr 13 2018, 3:11 AM
gniibe claimed T3898: Memory leak in g10 handle_compressed.

Good catch. Thanks. Fixed in STABLE-BRANCH-2-2.

Apr 13 2018, 3:11 AM · gnupg (gpg14), Bug Report
gniibe triaged T3759: Compile test fails, Libassuan v2.5.1 - Ubuntu 14.04 - fdpassing[7693]: assuan_pipe_connect failed: End of file as Normal priority.

Apparently, your /lib/x86_64-linux-gnu/libgpg-error.so.0 is not the one you installed (I mean, libgpg-error version 1.27).
You need to install your new version of libgpg-error so that it is usable.
Please check your ldconfig or LD_LIBRARY_PATH, etc.

Apr 13 2018, 2:46 AM · Info Needed, libassuan, Bug Report

Apr 12 2018

gniibe committed rGbb2680a45ab2: po: Update Japanese translation. (authored by gniibe).
po: Update Japanese translation.
Apr 12 2018, 3:53 AM
gniibe changed the status of T3869: libgpg-error-1.28 on Solaris from Open to Testing.

Put the check in configure.

Apr 12 2018, 2:45 AM · Solaris, gpgrt, Bug Report
gniibe committed rEe35749023ca6: build: Check -lsocket -lnsl for Solaris. (authored by gniibe).
build: Check -lsocket -lnsl for Solaris.
Apr 12 2018, 2:45 AM

Apr 11 2018

gniibe added a comment to T3891: kdf-setup does not set admin and user PIN codes.

For the situation where PINs are not factory setting, given the specification, I don't know how to achieve "to align all PWs and the KDF-DO with correct values"; It might depend on card's implementation.

Apr 11 2018, 11:07 AM · Restricted Project, scd, Bug Report
gniibe added a project to T3843: Unable to generate RSA4096 keys on Yubikey 4 on OSX Sierra: Info Needed.
Apr 11 2018, 10:02 AM · Info Needed, MacOS, yubikey, scd, Bug Report
gniibe triaged T3843: Unable to generate RSA4096 keys on Yubikey 4 on OSX Sierra as Normal priority.
Apr 11 2018, 10:02 AM · Info Needed, MacOS, yubikey, scd, Bug Report
gniibe triaged T3880: gpg-agent's ssh-agent does not handle flags in signing requests properly as Normal priority.
Apr 11 2018, 10:01 AM · ssh, gpgagent, Bug Report
gniibe closed T3825: Scdaemon needs to restart after wake up from sleep mode for YubiKey to work on Windows as Resolved.

Workaround is implemented in 2.2.6.

Apr 11 2018, 1:59 AM · gpg4win, gpgagent, gnupg (gpg22), scd, Windows, Bug Report, yubikey
gniibe closed T3781: ECC encryption key on-card generation broken as Resolved.

Fixed in 2.2.6.

Apr 11 2018, 1:58 AM · g10, scd, Bug Report
gniibe changed the status of T3877: not all malloc performed in libgcrypt covered by gcry_set_allocation_handler from Open to Testing.
Apr 11 2018, 1:52 AM · libgcrypt, Bug Report
gniibe committed rC3e3b520fb32a: hmac: Use xtrymalloc. (authored by gniibe).
hmac: Use xtrymalloc.
Apr 11 2018, 1:52 AM
gniibe claimed T3877: not all malloc performed in libgcrypt covered by gcry_set_allocation_handler.
Apr 11 2018, 1:16 AM · libgcrypt, Bug Report
gniibe claimed T3891: kdf-setup does not set admin and user PIN codes.
Apr 11 2018, 1:13 AM · Restricted Project, scd, Bug Report

Apr 10 2018

gniibe added a comment to T3891: kdf-setup does not set admin and user PIN codes.

My interpretation of the specification is different.
By requiring the condition of setting KDF-DO (it is only valid to setup KDF-DO when PINs are factory setting), Gnuk works well with current "kdf-setup".
If the procedure of setting KDF-DO includes multiple steps with KDF-DO update and PIN update, there is a risk of power down which results unusable card.

Apr 10 2018, 11:38 PM · Restricted Project, scd, Bug Report
gniibe added a comment to T3877: not all malloc performed in libgcrypt covered by gcry_set_allocation_handler.

Note:
When we change the allocation, hmac256.c will not be standalone any more (as commented in the head of the file), and we will need to change the compile-command line to include libgpg-error.

Apr 10 2018, 7:09 AM · libgcrypt, Bug Report
gniibe committed rC0de2a22fcf66: random: Protect another use of jent_rng_collector. (authored by gniibe).
random: Protect another use of jent_rng_collector.
Apr 10 2018, 4:21 AM
gniibe added a comment to T3731: gcry_pk_genkey() segfaults for ecdsa 384.

I check this report again.
The test is single thread, IIUC.

Apr 10 2018, 3:08 AM · libgcrypt, Bug Report

Apr 9 2018

gniibe closed T3299: scd: support key algorithm attribute change UI as Resolved.
Apr 9 2018, 7:27 AM · gnupg (gpg23)
gniibe added a comment to T3299: scd: support key algorithm attribute change UI.

Fixed for forthcoming 2.2.6. Because of T3781: ECC encryption key on-card generation broken.
rG820380335a20: g10: Add "key-attr" command for --card-edit.

Apr 9 2018, 7:27 AM · gnupg (gpg23)
gniibe added a comment to T3844: Able to certify public keys without a certify key present when using smartcard..

I see. Got it.

Apr 9 2018, 1:20 AM · gnupg (gpg22), Bug Report

Apr 6 2018

gniibe added a comment to T3844: Able to certify public keys without a certify key present when using smartcard..

The patch has two parts; (1) detecting signature by incapable key and (2) limiting key with relevant capability.
I think that (1) is enough. I wonder with (2), (1) would not occur.

Apr 6 2018, 1:34 PM · gnupg (gpg22), Bug Report
gniibe added a comment to T3844: Able to certify public keys without a certify key present when using smartcard..

Sorry, the patch above is completely wrong, since pk->pubkey_usage is not the right key to check.

Apr 6 2018, 8:55 AM · gnupg (gpg22), Bug Report
gniibe created D460: Make sure the key for signature has capable for CERT.
Apr 6 2018, 8:53 AM
gniibe changed the status of T3880: gpg-agent's ssh-agent does not handle flags in signing requests properly from Open to Testing.
Apr 6 2018, 8:51 AM · ssh, gpgagent, Bug Report
gniibe committed rG80b775bdbb85: agent: Support SSH signature flags. (authored by gniibe).
agent: Support SSH signature flags.
Apr 6 2018, 8:08 AM
gniibe added a comment to T3844: Able to certify public keys without a certify key present when using smartcard..

If someone claims this is a kind of vulnerability, I think that what we need to fix is signature checking side:


Speaking about this, similar patch would be required to gpg1.4.

Apr 6 2018, 2:28 AM · gnupg (gpg22), Bug Report
gniibe added a comment to T3844: Able to certify public keys without a certify key present when using smartcard..

The bug is specific to 2.2, which may select available key on card. When such a selection, checking the PK->REQ_USAGE was missed.

Apr 6 2018, 1:09 AM · gnupg (gpg22), Bug Report

Apr 5 2018

gniibe abandoned D459: tests failures and stop-agent.

Pushed different version (with teardown-fn).

Apr 5 2018, 8:39 AM
gniibe committed rG870527df0dd7: g10: Let card-edit/key-attr show message when change. (authored by gniibe).
g10: Let card-edit/key-attr show message when change.
Apr 5 2018, 3:39 AM

Apr 4 2018

gniibe committed rG83529e1bd14a: tests: Fix no gpg-agent upon removal of GNUPGHOME. (authored by gniibe).
tests: Fix no gpg-agent upon removal of GNUPGHOME.
Apr 4 2018, 1:38 PM

Apr 3 2018

gniibe committed rGcb1731c23cdd: scd: Writing KDF resets auth state. (authored by gniibe).
scd: Writing KDF resets auth state.
Apr 3 2018, 1:32 PM
gniibe created D459: tests failures and stop-agent.
Apr 3 2018, 6:33 AM
gniibe added a comment to T3842: OpenPGP Smart card V2.1 returns truncated RSA signatures if leading bytes of signature are 0.

Yes, I meant the document. Please note that I am also one of users of the specification (for GnuPG, and for Gnuk Token). I am not defending, but try to explain the current situation.

Apr 3 2018, 1:30 AM · Not A Bug, scd
gniibe changed the status of T3844: Able to certify public keys without a certify key present when using smartcard. from Open to Testing.

I think that I located the bug and fixed. I wonder why Werner put gpg20 tag.

Apr 3 2018, 1:25 AM · gnupg (gpg22), Bug Report

Apr 2 2018

gniibe committed rGa17d2d1f690e: g10: Fix filtering by PK->REQ_USAGE. (authored by gniibe).
g10: Fix filtering by PK->REQ_USAGE.
Apr 2 2018, 10:49 AM
gniibe claimed T3844: Able to certify public keys without a certify key present when using smartcard..
Apr 2 2018, 10:43 AM · gnupg (gpg22), Bug Report
gniibe added a comment to T3842: OpenPGP Smart card V2.1 returns truncated RSA signatures if leading bytes of signature are 0.

You describe it as 'manual'. AFAIK, it's the specification for the functionality.
I have an experience implementing the functionality, following the specification.
And my own implementation does always return 512 bytes for RSA-4096. So, I could support your opinion.

Apr 2 2018, 7:16 AM · Not A Bug, scd

Mar 30 2018

gniibe committed rG6705ee42a4bd: po: Update Japanese translation. (authored by gniibe).
po: Update Japanese translation.
Mar 30 2018, 12:34 PM
gniibe committed rG130ad98240c0: g10: Fix card-edit/kdf-setup for single salt. (authored by gniibe).
g10: Fix card-edit/kdf-setup for single salt.
Mar 30 2018, 10:03 AM
gniibe committed rG0c097575a9cd: g10,scd: Support single salt for KDF data object. (authored by gniibe).
g10,scd: Support single salt for KDF data object.
Mar 30 2018, 5:52 AM
gniibe added a comment to T3152: KDF DO support in OpenPGP card.

I realized that KDF support may be incompatible to Gnuk's feature of "admin-less" mode.
I'm going to implement compatible KDF support to Gnuk; That is, KDF data which only has a single salt.
In this case, all KDF calculation (user, reset-code, and admin) is done with the single salt.
With single salt, admin-less mode can work with no problem.

Mar 30 2018, 4:59 AM · scd
gniibe changed the status of T3781: ECC encryption key on-card generation broken from Open to Testing.
Mar 30 2018, 4:52 AM · g10, scd, Bug Report
gniibe added a comment to T3781: ECC encryption key on-card generation broken.

Furthermore, I changed to have an explicit command: key-attr

Mar 30 2018, 4:52 AM · g10, scd, Bug Report
gniibe committed rG820380335a20: g10: Add "key-attr" command for --card-edit. (authored by gniibe).
g10: Add "key-attr" command for --card-edit.
Mar 30 2018, 4:04 AM
gniibe committed rG29692718768c: scd: Support changing key attribute back to RSA. (authored by gniibe).
scd: Support changing key attribute back to RSA.
Mar 30 2018, 4:04 AM

Mar 29 2018

gniibe triaged T3781: ECC encryption key on-card generation broken as Normal priority.

I changed the interaction so that user can specify RSA or ECC, then when it's for ECC, specifying curve.

Mar 29 2018, 6:10 AM · g10, scd, Bug Report
gniibe committed rGa1515b3bbc10: g10: Support key attribute change at --card-edit/generate. (authored by gniibe).
g10: Support key attribute change at --card-edit/generate.
Mar 29 2018, 5:06 AM
gniibe committed rG02d7bb819ff4: g10: check_pin_for_key_operation should be just before genkey. (authored by gniibe).
g10: check_pin_for_key_operation should be just before genkey.
Mar 29 2018, 5:06 AM
gniibe added a comment to T3843: Unable to generate RSA4096 keys on Yubikey 4 on OSX Sierra.

It looks like something wrong happened in scdaemon. Could you please try with following? .gnupg/scdaemon.conf

Mar 29 2018, 2:59 AM · Info Needed, MacOS, yubikey, scd, Bug Report
gniibe claimed T3843: Unable to generate RSA4096 keys on Yubikey 4 on OSX Sierra.

Since I don't have macOS environment and Yubikey 4 (I only have old Yubikey), I hesitated to claim this ticket. But it is me who should take this one.

Mar 29 2018, 1:07 AM · Info Needed, MacOS, yubikey, scd, Bug Report

Mar 28 2018

gniibe committed rGe610d51f0de1: g10: Change ask_curve so that it can be used outside. (authored by gniibe).
g10: Change ask_curve so that it can be used outside.
Mar 28 2018, 12:00 PM
gniibe claimed T3825: Scdaemon needs to restart after wake up from sleep mode for YubiKey to work on Windows.
Mar 28 2018, 1:29 AM · gpg4win, gpgagent, gnupg (gpg22), scd, Windows, Bug Report, yubikey

Mar 27 2018

gniibe committed rG96918346beec: agent,scd: Use pointer to represent HANDLE. (authored by gniibe).
agent,scd: Use pointer to represent HANDLE.
Mar 27 2018, 9:26 AM
gniibe committed rAb270f2ec21b6: tests: Exclude tests for Windows build. (authored by gniibe).
tests: Exclude tests for Windows build.
Mar 27 2018, 8:43 AM
gniibe committed rE99e976be723e: doc: Fix previous commit. (authored by gniibe).
doc: Fix previous commit.
Mar 27 2018, 5:17 AM
gniibe committed rEefc4769339d4: doc: Support cross compilation for yat2m. (authored by gniibe).
doc: Support cross compilation for yat2m.
Mar 27 2018, 3:22 AM

Mar 23 2018

gniibe committed rG5400a5bb77bd: build: Fix the manual source field. (authored by gniibe).
build: Fix the manual source field.
Mar 23 2018, 7:29 AM

Mar 22 2018

gniibe changed the status of T3823: gpg frontend support to setup KDF DO, a subtask of T3152: KDF DO support in OpenPGP card, from Open to Testing.
Mar 22 2018, 7:59 AM · scd
gniibe changed the status of T3823: gpg frontend support to setup KDF DO from Open to Testing.

2.2.6 will have this feature in --card-edit, as kdf-setup. Please test.

Mar 22 2018, 7:59 AM · scd
gniibe committed rG0152ba7c9874: scd: Support KDF DO setup. (authored by gniibe).
scd: Support KDF DO setup.
Mar 22 2018, 7:55 AM
gniibe committed rE4dc6d4d2067c: doc: Fix build and installation of yat2m. (authored by gniibe).
doc: Fix build and installation of yat2m.
Mar 22 2018, 3:20 AM

Mar 19 2018

gniibe committed rG11bbd99477ef: scd: signal mask should be set just after npth_init. (authored by gniibe).
scd: signal mask should be set just after npth_init.
Mar 19 2018, 8:47 AM

Mar 17 2018

gniibe abandoned D458: linux suspend/resume 1.
Mar 17 2018, 12:45 PM
gniibe created D458: linux suspend/resume 1.
Mar 17 2018, 12:43 PM

Mar 16 2018

gniibe added a comment to T3823: gpg frontend support to setup KDF DO.

For factory-reset, rG2c85e202bc30: scd: Better user interaction for factory-reset. fixed the issue.

Mar 16 2018, 3:40 AM · scd