Page MenuHome GnuPG
Feed All Stories

Aug 31 2020

slandden added a comment to T5040: Improve PPC code using code from CRYPTOGRAMs.

I think I am doing to try to do this on top of the work of Szabolcs Nagy[1] with the goal of making it portable, and also serving as a test cast to my carry-less multiplication intrinsic RFC[2]. Hopefully I can also remove the manual register allocation that makes it still a derivitive work of Andy, however this algorithm takes advantage of the communicative properties of carry-less multiplication, which is mult(H) on page 5 of the gcm spec[3], this communicative property works differently than with addition and multiplication in a way I do not entirely understand.

Aug 31 2020, 2:11 PM · legal, libgcrypt
ikloecker committed rKLEOPATRA559bcddaf1be: Use the new getCard() to get the card (authored by ikloecker).
Use the new getCard() to get the card
Aug 31 2020, 2:03 PM
ikloecker committed rKLEOPATRA2bca8779ccef: Fix selection of slot if multiple slots are suitable for key (authored by ikloecker).
Fix selection of slot if multiple slots are suitable for key
Aug 31 2020, 2:03 PM
glr added a comment to T3362: Prevent Smartcard from caching PIN when cache-ttl is set accordingly.

@werner , I understand your poiont.

So, the best approach would be:
(1) Define some DO (Data-Object) or attribute/flag per key to control timeout or "force" by the card itself.
(2) Modify scdaemon so that it always ask authentication state to the card before doing crypto operation.
(3) Modify gpg frontend so that it shows those attribute/flag and setup.

Then, it is the card itself to control timeout or "force".

Aug 31 2020, 1:00 PM · Feature Request
werner added a project to T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status: gnupg (gpg22).
Aug 31 2020, 12:54 PM · Restricted Project, gnupg (gpg22), Bug Report
mgorny added a comment to T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status.

Yes, I do have a signing key (that is distinct from the primary key, primary key I don't store on the smartcard).

Aug 31 2020, 10:37 AM · Restricted Project, gnupg (gpg22), Bug Report
werner added a comment to T5030: Release GnuPG 2.2.22 .

As a workaround please run

Aug 31 2020, 10:36 AM · gnupg (gpg22), Release Info
gniibe added a comment to T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status.

Ah, I see the situation of the regression.
When the token is not yet accessed at all, scdaemon misunderstood as no signing key.

Aug 31 2020, 10:20 AM · Restricted Project, gnupg (gpg22), Bug Report
gniibe added a comment to T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status.

Do you have a signing key in your card or not?

Aug 31 2020, 10:18 AM · Restricted Project, gnupg (gpg22), Bug Report
gniibe claimed T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status.
Aug 31 2020, 10:17 AM · Restricted Project, gnupg (gpg22), Bug Report
werner added a comment to D501: VPMSUMD accelleration for GCM mode on PPC.

Let's continue discussion at T5040

Aug 31 2020, 9:31 AM
werner created T5040: Improve PPC code using code from CRYPTOGRAMs.
Aug 31 2020, 9:31 AM · legal, libgcrypt
werner added a comment to T5030: Release GnuPG 2.2.22 .

There seems to be a problem with Gnuk and thus Nitrokey tokens with 2.2.22. We are investigating this. See T5039.

Aug 31 2020, 9:22 AM · gnupg (gpg22), Release Info
mgorny updated subscribers of T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status.
Aug 31 2020, 8:26 AM · Restricted Project, gnupg (gpg22), Bug Report
mgorny created T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status.
Aug 31 2020, 8:26 AM · Restricted Project, gnupg (gpg22), Bug Report

Aug 30 2020

slandden added a comment to D501: VPMSUMD accelleration for GCM mode on PPC.

and Andy is the sole author, and he even told me personally by e-mail this
a long time ago when I was interested in the libcrypt library of glibc is .
He also licensed cryptogams for the Linux kernel (because of WireGuard)
however that did not make it into the version the version that was merged
(some of his code is already there, and IIRC includes the ghash at issue
here).

Aug 30 2020, 9:14 PM
werner committed rGPAee215574aa10: Adding key size 4096 for key generation. (authored by DebXWoody <stefan@debxwoody.de>).
Adding key size 4096 for key generation.
Aug 30 2020, 7:14 PM
werner added a comment to D501: VPMSUMD accelleration for GCM mode on PPC.

If we can use the code please first commit the original code to the repo and only then apply code style fixes.

Aug 30 2020, 11:01 AM
werner added a comment to D501: VPMSUMD accelleration for GCM mode on PPC.

We need to clarify two things:

Aug 30 2020, 10:59 AM

Aug 29 2020

jukivili updated subscribers of D501: VPMSUMD accelleration for GCM mode on PPC.

So, things I see are needed to be done for inclusion of this patch are:

  1. GNU C coding style fixes.
  2. Adding comment about that this implementation is based on GHASH implementation by Andy Polyakov with original license. This needs to be checked with @werner , but I think following would be sufficient:
Aug 29 2020, 6:30 PM
werner triaged T5038: UTF-8 handling in the command line as Normal priority.
Aug 29 2020, 5:19 PM · gnupg
werner edited projects for T5033: dirmngr does not seem to use the default .gnupg directory if GNUPGHOME is not set, added: Not A Bug, gnupg; removed Info Needed, Bug Report.
Aug 29 2020, 5:18 PM · gnupg, Not A Bug
werner added a comment to T5037: dn.cpp:181: suspicious loop.

FWIW, here an example of warnings we use. Yes it starts with -Wall but there are a couple of more specific warnings and at a few places we even use pragmas to disable warnings. And it depends on the compiler version used.

Aug 29 2020, 5:16 PM · gnupg, gpgme, Bug Report

Aug 28 2020

dcb added a comment to T5037: dn.cpp:181: suspicious loop.

-Wall is not a good idea in general because it is too unspecific. This is why we have a list of useful warning and >warnings we ignore with gcc.

Aug 28 2020, 7:53 PM · gnupg, gpgme, Bug Report
CodingCellist closed T5033: dirmngr does not seem to use the default .gnupg directory if GNUPGHOME is not set as Invalid.
Aug 28 2020, 1:52 PM · gnupg, Not A Bug
CodingCellist added a comment to T5033: dirmngr does not seem to use the default .gnupg directory if GNUPGHOME is not set.

Hmm. Now, even with a fresh session, dirmngr, GNUPGHOME not set, etc. it seems to work. It correctly uses the config file and the keyserver, and the logs show the Home and Config variables are set and communicated correctly.

Aug 28 2020, 1:51 PM · gnupg, Not A Bug
werner added a comment to T5037: dn.cpp:181: suspicious loop.

-Wall is not a good idea in general because it is too unspecific. This is why we have a list of useful warning and warnings we ignore with gcc.

Aug 28 2020, 12:43 PM · gnupg, gpgme, Bug Report
werner committed rGbcae9cd4e3c3: po: Minor update to the Hungarian translation. (authored by Nagy Ferenc László <nfl@nfllab.com>).
po: Minor update to the Hungarian translation.
Aug 28 2020, 12:37 PM
dcb added a comment to T5037: dn.cpp:181: suspicious loop.

I found the bug by compiling the package with C/C++ compiler clang and flag -Wall.

Aug 28 2020, 9:32 AM · gnupg, gpgme, Bug Report
werner committed rMb088d81cefe4: qt: Fix an rfc2253 parser flaw (authored by werner).
qt: Fix an rfc2253 parser flaw
Aug 28 2020, 9:20 AM
werner closed T5037: dn.cpp:181: suspicious loop as Resolved.

Fixed in gnupg and gpgme. it is not serious because that is just a failsafe check; libksba creates these strings and it does it correctly.

Aug 28 2020, 9:15 AM · gnupg, gpgme, Bug Report
werner committed rGd2fe2ffd7537: sm: Fix a bug in the rfc2253 parser (authored by werner).
sm: Fix a bug in the rfc2253 parser
Aug 28 2020, 9:10 AM
werner committed rG16c1d8a14e98: sm: Fix a bug in the rfc2253 parser (authored by werner).
sm: Fix a bug in the rfc2253 parser
Aug 28 2020, 9:09 AM
werner committed rGd45e92cf8855: doc: Fix typos (authored by glr).
doc: Fix typos
Aug 28 2020, 9:09 AM
werner added a project to T5037: dn.cpp:181: suspicious loop: gnupg.

We have the same flaw in gnupg.

Aug 28 2020, 9:00 AM · gnupg, gpgme, Bug Report
werner claimed T5037: dn.cpp:181: suspicious loop.
Aug 28 2020, 8:54 AM · gnupg, gpgme, Bug Report
gniibe committed rG393dcdd61c3b: common: Fix fallback handling to utf-8. (authored by gniibe).
common: Fix fallback handling to utf-8.
Aug 28 2020, 8:21 AM
werner added a comment to T4838: add configure check for zlib to ntbtls.

I think we should make zlib a mandatory dependency.

Aug 28 2020, 7:54 AM · ntbtls, Bug Report
gniibe added a comment to T5038: UTF-8 handling in the command line.

I mean:

diff --git a/common/utf8conv.c b/common/utf8conv.c
index 7804dbfcd..bdab225a9 100644
--- a/common/utf8conv.c
+++ b/common/utf8conv.c
@@ -138,7 +138,7 @@ handle_iconv_error (const char *to, const char *from, int use_fallback)
          native encoding.  Nowadays this seems to be the best bet in
          case of errors from iconv or nl_langinfo.  */
       active_charset_name = "utf-8";
-      no_translation = 0;
+      no_translation = 1;
       use_iconv = 0;
     }
 }
Aug 28 2020, 7:39 AM · gnupg
gniibe added a subtask for T1514: charset weirdness with non-ascii User IDs under non-UTF-8 locales: T5038: UTF-8 handling in the command line.
Aug 28 2020, 7:37 AM · Bug Report, gnupg
gniibe added a parent task for T5038: UTF-8 handling in the command line: T1514: charset weirdness with non-ascii User IDs under non-UTF-8 locales.
Aug 28 2020, 7:37 AM · gnupg
gniibe updated the task description for T5038: UTF-8 handling in the command line.
Aug 28 2020, 7:25 AM · gnupg
gniibe created T5038: UTF-8 handling in the command line.
Aug 28 2020, 7:22 AM · gnupg
gniibe added projects to T4710: Cannot use Secure PIN Entry for Reset Code: Documentation, Not A Bug.
Aug 28 2020, 6:48 AM · Not A Bug, Documentation, OpenPGP, scd, Bug Report
gniibe added a comment to T4817: dirmgr keys.openpgp.org:443 Address family not supported by protocol.

In T4977: dirmngr not working with linux kernel parameter ipv6.disable=1, EAFNOSUPPORT fix was applied in 2.2.22.
I think that original problem in this report is fixed.
Please test with 2.2.22.

Aug 28 2020, 6:46 AM · Bug Report
gniibe added a comment to T4838: add configure check for zlib to ntbtls.

Actually, configure already has the check.
If it's really needed to build without zlib, you can use this patch:

From 76920ac034490e4860ad6abe9891e3b1c0813363 Mon Sep 17 00:00:00 2001
From: NIIBE Yutaka <gniibe@fsij.org>
Date: Fri, 28 Aug 2020 11:02:13 +0900
Subject: [PATCH] Until compression is implemented, build with no ZLIB can be
 done.
Aug 28 2020, 4:08 AM · ntbtls, Bug Report
gniibe added a project to T5037: dn.cpp:181: suspicious loop: gpgme.
Aug 28 2020, 3:06 AM · gnupg, gpgme, Bug Report
gniibe closed T3207: FASTWIPE_T undefined as Resolved.
Aug 28 2020, 3:01 AM · Restricted Project, ntbtls, Bug Report
gniibe closed T4934: Returning automatic variable buffer from a function as Resolved.
Aug 28 2020, 2:58 AM · dirmngr, Restricted Project, Bug Report

Aug 27 2020

dcb created T5037: dn.cpp:181: suspicious loop.
Aug 27 2020, 5:41 PM · gnupg, gpgme, Bug Report
ikloecker committed rKLEOPATRA42f5173f335b: Allow users to change the administration key of a PIV card (authored by ikloecker).
Allow users to change the administration key of a PIV card
Aug 27 2020, 4:04 PM
ikloecker committed rKLEOPATRA662d68fa9a07: Ask for PIV Card Application Administration Key if necessary (authored by ikloecker).
Ask for PIV Card Application Administration Key if necessary
Aug 27 2020, 4:04 PM
werner committed rDbc245f461505: swdb: Release GnuPG 2.2.22 (authored by werner).
swdb: Release GnuPG 2.2.22
Aug 27 2020, 3:31 PM
werner closed T5030: Release GnuPG 2.2.22 as Resolved.
Aug 27 2020, 3:21 PM · gnupg (gpg22), Release Info
werner closed T4843: REGEXP support for all systems as Resolved.
Aug 27 2020, 3:04 PM · Restricted Project, gnupg
werner closed T4083: gpgtar, Kleopatra: Unicode filenames that are not native 8 bit on Windows don't work as Resolved.
Aug 27 2020, 3:04 PM · Bug Report, gpg4win, kleopatra, gpgtar
werner closed T4977: dirmngr not working with linux kernel parameter ipv6.disable=1 as Resolved.
Aug 27 2020, 3:03 PM · Restricted Project, gnupg (gpg22), dirmngr, Bug Report
werner set External Link to https://lists.gnupg.org/pipermail/gnupg-announce/2020q3/000447.html on T5030: Release GnuPG 2.2.22 .
Aug 27 2020, 3:03 PM · gnupg (gpg22), Release Info
werner committed rGf799b3ddbb4a: Post release updates (authored by werner).
Post release updates
Aug 27 2020, 2:56 PM
werner committed rGf9c120a29986: Release 2.2.22 (authored by werner).
Release 2.2.22
Aug 27 2020, 2:56 PM
werner committed rG27652e0ca75f: doc: Fix typos (authored by glr).
doc: Fix typos
Aug 27 2020, 2:56 PM
werner closed T5027: gpgtar's "--files-from" should also handle a LF terminated list of file names. as Resolved.
Aug 27 2020, 2:24 PM · gnupg (gpg22), Feature Request, gpgtar
werner added a project to T5018: Export keys to secure card failure: gpg: KEYTOCARD failed: Unusable secret key: Info Needed.
Aug 27 2020, 12:55 PM · Info Needed, Bug Report
werner closed T5035: Doc fix: simple typos as Resolved.

Thanks. Applied to 2.2 and master.

Aug 27 2020, 12:54 PM · Bug Report
werner committed rGb5de213efe77: doc: Add a remark about keyservers. (authored by werner).
doc: Add a remark about keyservers.
Aug 27 2020, 12:51 PM
werner committed rGcde92d3e2341: doc: Add a remark about keyservers. (authored by werner).
doc: Add a remark about keyservers.
Aug 27 2020, 12:51 PM
werner committed rGa0a4744bd064: scd: New option to APDU command to return the ATR as data. (authored by werner).
scd: New option to APDU command to return the ATR as data.
Aug 27 2020, 11:56 AM
werner committed rG95b5a852e269: scd: Fix reading of the ATR for card type detection. (authored by werner).
scd: Fix reading of the ATR for card type detection.
Aug 27 2020, 11:54 AM
werner triaged T5029: server socket/pipe handling in GnuPG as Normal priority.

I still don't think that it is correct. We would also need to turn fd from an int to a gnupg_fd_t (ie. a HANDLE under Windows) which requires other changes and should be done in the other parts of the code as well. assuan_sock_close also delegates to the system specific function and on Windows removes the fd also from the cygwin table. This may trigger other bugs so I'd like to keep it as it is to go with the code which has been in active use for a long time - at least for 2.2

Aug 27 2020, 11:01 AM · Windows, scd, gnupg (gpg23)
werner added a project to T5033: dirmngr does not seem to use the default .gnupg directory if GNUPGHOME is not set: Info Needed.
Aug 27 2020, 10:47 AM · gnupg, Not A Bug
werner closed T4597: Support GCM modes for ntbtls. as Resolved.

0.2.0 was just released with support for GCM. Tested against openpgpkeys.pm.me

Aug 27 2020, 9:34 AM · Restricted Project, Feature Request, ntbtls
werner committed rD91b230451226: swdb: Take signing key from ~/.gnupg-autogen.rc (authored by werner).
swdb: Take signing key from ~/.gnupg-autogen.rc
Aug 27 2020, 9:30 AM
werner committed rDa6c7b484c7a0: swdb: Release ntbtls 0.2.0 (authored by werner).
swdb: Release ntbtls 0.2.0
Aug 27 2020, 9:22 AM
werner committed rT6a4ffcc68cb0: Release 0.2.0 (authored by werner).
Release 0.2.0
Aug 27 2020, 9:18 AM
werner committed rT56061b8dd685: Post release updates (authored by werner).
Post release updates
Aug 27 2020, 9:18 AM
werner committed rT8b3a059e8a81: Fix printf error in debug output. (authored by werner).
Fix printf error in debug output.
Aug 27 2020, 9:18 AM
werner committed rTf10e83874e86: Add public function ntbtls_get_last_alert. (authored by werner).
Add public function ntbtls_get_last_alert.
Aug 27 2020, 9:18 AM
werner committed rG45499b2ca3e8: dirmngr: Print the last alert message returned by NTBTLS. (authored by werner).
dirmngr: Print the last alert message returned by NTBTLS.
Aug 27 2020, 9:05 AM
werner committed rG05358d738411: dirmngr: Print the last alert message returned by NTBTLS. (authored by werner).
dirmngr: Print the last alert message returned by NTBTLS.
Aug 27 2020, 9:03 AM
Laurent Montel <montel@kde.org> committed rLIBKLEO5e7df547ab8f: GIT_SILENT: prepare 5.15.1 (authored by Laurent Montel <montel@kde.org>).
GIT_SILENT: prepare 5.15.1
Aug 27 2020, 8:02 AM
Laurent Montel <montel@kde.org> committed rKLEOPATRAc55f8854b39d: GIT_SILENT: prepare 5.15.1 (authored by Laurent Montel <montel@kde.org>).
GIT_SILENT: prepare 5.15.1
Aug 27 2020, 7:37 AM
gniibe committed rG9f148360a2bf: scd: Add heuristics to identify cardtype. (authored by gniibe).
scd: Add heuristics to identify cardtype.
Aug 27 2020, 7:34 AM
gniibe committed rGd2f1a0a791db: scd: Add condition for VERIFY with 0x82. (authored by gniibe).
scd: Add condition for VERIFY with 0x82.
Aug 27 2020, 3:55 AM
gniibe committed rGaf189be481df: scd: Add condition for VERIFY with 0x82. (authored by gniibe).
scd: Add condition for VERIFY with 0x82.
Aug 27 2020, 3:45 AM

Aug 26 2020

werner committed rT408d5b469a2a: Silence some compiler warnings (authored by werner).
Silence some compiler warnings
Aug 26 2020, 9:33 PM
werner committed rT1003f94975ec: Improve debug messages for alerts. (authored by werner).
Improve debug messages for alerts.
Aug 26 2020, 9:33 PM
doronbehar added a comment to T5036: pinentry won't launch when gpg is invoked by Firefox when Firefox runs with native wayland support in a wayland DE.

I am always glad to fix such bugs before a release (I am about to prepare 2.2.22).

Aug 26 2020, 4:12 PM · Wayland, pinentry
werner added a comment to T5036: pinentry won't launch when gpg is invoked by Firefox when Firefox runs with native wayland support in a wayland DE.

I am always glad to fix such bugs before a release (I am about to prepare 2.2.22).

Aug 26 2020, 3:48 PM · Wayland, pinentry
doronbehar added a comment to T5036: pinentry won't launch when gpg is invoked by Firefox when Firefox runs with native wayland support in a wayland DE.

It worked! You were right!

Aug 26 2020, 3:31 PM · Wayland, pinentry
doronbehar added a comment to T5036: pinentry won't launch when gpg is invoked by Firefox when Firefox runs with native wayland support in a wayland DE.

Thank you for your prompt help. It's much appreciated.

Aug 26 2020, 3:20 PM · Wayland, pinentry
werner merged T5036: pinentry won't launch when gpg is invoked by Firefox when Firefox runs with native wayland support in a wayland DE into T4137: IPC syntax error when `gpg` starts `gpg-agent` without `$TERM` variable.
Aug 26 2020, 3:19 PM · gnupg, Bug Report
werner merged task T5036: pinentry won't launch when gpg is invoked by Firefox when Firefox runs with native wayland support in a wayland DE into T4137: IPC syntax error when `gpg` starts `gpg-agent` without `$TERM` variable.
Aug 26 2020, 3:19 PM · Wayland, pinentry
werner added a comment to T5036: pinentry won't launch when gpg is invoked by Firefox when Firefox runs with native wayland support in a wayland DE.

rG4c8d5eb0bdd3: agent: Allow TERM="".

Aug 26 2020, 3:19 PM · Wayland, pinentry
doronbehar added a comment to T5036: pinentry won't launch when gpg is invoked by Firefox when Firefox runs with native wayland support in a wayland DE.

I see. Thank you @werner . For clarity could you please link the patch that was not backported to 2.2.?

Aug 26 2020, 3:17 PM · Wayland, pinentry
werner added a comment to T5036: pinentry won't launch when gpg is invoked by Firefox when Firefox runs with native wayland support in a wayland DE.

Mails crossed ;-)

Aug 26 2020, 3:16 PM · Wayland, pinentry
werner committed rG90a87d96eaf5: build: Silence gcc warning -Wformat-zero-length (authored by werner).
build: Silence gcc warning -Wformat-zero-length
Aug 26 2020, 3:15 PM
werner committed rG4699911f047c: speedo: Allow customizing the release process (authored by werner).
speedo: Allow customizing the release process
Aug 26 2020, 3:15 PM
werner committed rG4c8d5eb0bdd3: agent: Allow TERM="". (authored by gniibe).
agent: Allow TERM="".
Aug 26 2020, 3:14 PM
werner committed rG0be5decc0972: build: Silence gcc warning -Wformat-zero-length (authored by werner).
build: Silence gcc warning -Wformat-zero-length
Aug 26 2020, 3:14 PM
doronbehar added a comment to T5036: pinentry won't launch when gpg is invoked by Firefox when Firefox runs with native wayland support in a wayland DE.

But @werner what's the value $TERM *supposed* to have? When gpg is invoked straight by Gnome? I can run the command sh -c 'env | grep TERM > ~/gnome-term.env' in Gnome's "Run Command: interface and then the file ~/gnome-term.env says TERM is set to nothing (It is set, but the contents is a "" string).

Aug 26 2020, 3:13 PM · Wayland, pinentry