Page MenuHome GnuPG
Feed Advanced Search

May 25 2022

gniibe committed rA2a5550b7a13c: client: Handle inquiry from server with CONFIDENTIAL. (authored by gniibe).
client: Handle inquiry from server with CONFIDENTIAL.
May 25 2022, 10:49 AM
gniibe committed rAfd1ac5cdf804: client: Wipe the inbound buffer when CONFIDENTIAL. (authored by gniibe).
client: Wipe the inbound buffer when CONFIDENTIAL.
May 25 2022, 10:49 AM
gniibe committed rA89e8f265e377: server,client: Wipe the outbound buffer when CONFIDENTIAL. (authored by gniibe).
server,client: Wipe the outbound buffer when CONFIDENTIAL.
May 25 2022, 10:49 AM
gniibe committed rAd812e28af637: server: Wipe out the memory used by assuan_inquire if CONFIDENTIAL. (authored by gniibe).
server: Wipe out the memory used by assuan_inquire if CONFIDENTIAL.
May 25 2022, 10:49 AM
gniibe added a comment to T5977: Smartcard PIN stays in clear in memory.

Pushed the solution which doesn't require new flag for libassuan.

May 25 2022, 9:42 AM · backport, libassuan, pinentry, scd, gnupg (gpg22), Bug Report
gniibe added a project to T5977: Smartcard PIN stays in clear in memory: Restricted Project.
May 25 2022, 9:39 AM · backport, libassuan, pinentry, scd, gnupg (gpg22), Bug Report
gniibe committed rPc405add93a77: Mark with ASSUAN_CONFIDENTIAL flag. (authored by gniibe).
Mark with ASSUAN_CONFIDENTIAL flag.
May 25 2022, 9:06 AM
gniibe added a project to T5977: Smartcard PIN stays in clear in memory: backport.
May 25 2022, 7:59 AM · backport, libassuan, pinentry, scd, gnupg (gpg22), Bug Report
gniibe committed rG052f58422dca: agent,scd: Make sure to set CONFIDENTIAL flag in Assuan. (authored by gniibe).
agent,scd: Make sure to set CONFIDENTIAL flag in Assuan.
May 25 2022, 7:58 AM
gniibe committed rG8e859331eafc: agent: Add missing assuan_end_confidential call. (authored by gniibe).
agent: Add missing assuan_end_confidential call.
May 25 2022, 6:51 AM
gniibe added a comment to T5977: Smartcard PIN stays in clear in memory.

^-- I withdraw the solution (with error value) above.

May 25 2022, 4:57 AM · backport, libassuan, pinentry, scd, gnupg (gpg22), Bug Report
gniibe added a project to T5702: Display prompt to user when YubiKey is waiting for touch confirmation: patch.
May 25 2022, 4:13 AM · patch, Feature Request
gniibe added a comment to T5702: Display prompt to user when YubiKey is waiting for touch confirmation.

Besides, if lower layer solution is preferred, Yubikey can support having the special BWT value 0xff when bmCommandStatus = 2 (Time extension) is returned to host. The CCID driver recognizes this special value to prompt a user the dialog window.

May 25 2022, 4:12 AM · patch, Feature Request

May 24 2022

gniibe added a project to T6003: card: READCERT with KEYGRIP: Restricted Project.
May 24 2022, 2:04 PM · scd, Feature Request
gniibe added a project to T5120: Incompatible Ed25519 secret key (no-encryption): Restricted Project.
May 24 2022, 2:02 PM · gnupg (gpg22), Bug Report
gniibe added a project to T5953: batch signature fails with imported ed25519 signing key as of 2.2.34: Restricted Project.
May 24 2022, 2:01 PM · gnupg (gpg22), Bug Report
gniibe added a project to T5922: libgpg-error: gpgrt_log_get_fd always returns -1 even if it's not tcp/socket.: Restricted Project.
May 24 2022, 1:22 PM · Bug Report, gpgrt
gniibe added a comment to T5977: Smartcard PIN stays in clear in memory.

Or, it would be good for client side (in this case, gpg-agent) to specify the flag in the inquiry callback, that is, it's a kind of transient flag for a single transaction.

May 24 2022, 10:45 AM · backport, libassuan, pinentry, scd, gnupg (gpg22), Bug Report
gniibe added a comment to T5977: Smartcard PIN stays in clear in memory.

Revised version with new flag ASSUAN_CLEAR_INQUIRY_DATA.

May 24 2022, 10:33 AM · backport, libassuan, pinentry, scd, gnupg (gpg22), Bug Report
gniibe added a project to T5925: libassuan: Add assuan_sock_accept function to the API: Restricted Project.
May 24 2022, 9:44 AM · Feature Request, libassuan
gniibe added a project to T5914: libassuan: Introduce use of gpgrt_get_syscall_clamp, no use of system_hooks for nPTH: Restricted Project.
May 24 2022, 9:43 AM · Feature Request, libassuan
gniibe committed rGea97683d5820: scd: Support automatic card selection for READCERT with keygrip. (authored by gniibe).
scd: Support automatic card selection for READCERT with keygrip.
May 24 2022, 9:32 AM
gniibe added a comment to T6003: card: READCERT with KEYGRIP.

Pushed rGea97683d5820: scd: Support automatic card selection for READCERT with keygrip..
I think that it works for PIV card.

May 24 2022, 9:21 AM · scd, Feature Request
gniibe updated the task description for T6003: card: READCERT with KEYGRIP.
May 24 2022, 9:13 AM · scd, Feature Request
gniibe triaged T6003: card: READCERT with KEYGRIP as Normal priority.
May 24 2022, 7:22 AM · scd, Feature Request
gniibe committed rS6574f16cc88a: Allow up to four cards. (authored by gniibe).
Allow up to four cards.
May 24 2022, 5:58 AM
gniibe added a comment to T6002: scute w/ gpg23: Support multiple cards/tokens, major update with KEYGRIP.

For testing, I can use these sites for client certificate authentication:
https://stackoverflow.com/questions/38095559/https-test-server-that-checks-client-certificates

May 24 2022, 5:40 AM · Feature Request, scute
gniibe triaged T6002: scute w/ gpg23: Support multiple cards/tokens, major update with KEYGRIP as Normal priority.
May 24 2022, 4:36 AM · Feature Request, scute

May 23 2022

gniibe added a comment to T5862: authentication with USB token.

I did some research about scree lockers (xtrlock, slock, swaylock, etc.).

May 23 2022, 9:11 AM · gpgagent, Feature Request, scd
gniibe renamed T5984: gpg-agent interaction improvement (smartcard improvement #3) from gpg-agent interaction improvement ( (smartcard improvement #3) to gpg-agent interaction improvement (smartcard improvement #3).
May 23 2022, 6:41 AM · ssh, gpgagent, scd
gniibe added a comment to T5984: gpg-agent interaction improvement (smartcard improvement #3).

The order to solve:

May 23 2022, 3:39 AM · ssh, gpgagent, scd
gniibe triaged T5996: ssh,card: "Use-for-ssh:" (was: OpenPGP.3) keys should be on the list even when card is not available as Normal priority.
May 23 2022, 3:35 AM · ssh, gpgagent, scd
gniibe edited projects for T5988: agent: Add new command to update private key fields, added: Feature Request; removed scd.
May 23 2022, 3:27 AM · Feature Request, ssh, gpgagent
gniibe edited projects for T5985: private-key: Support "Use-for-ssh" flag, added: Feature Request; removed scd.
May 23 2022, 3:26 AM · Feature Request, ssh, gpgagent
gniibe lowered the priority of T5985: private-key: Support "Use-for-ssh" flag from Normal to Low.
May 23 2022, 3:24 AM · Feature Request, ssh, gpgagent
gniibe triaged T5995: Better prompt with SETKEYDESC as Normal priority.
May 23 2022, 3:15 AM · gnupg24, ssh, gpgagent, scd
gniibe added a comment to T5985: private-key: Support "Use-for-ssh" flag.

This is an experimental patch to support "Use-for-ssh":

May 23 2022, 2:55 AM · Feature Request, ssh, gpgagent
gniibe committed rG1b0c4c277824: agent: Fix a bug accessing after release when opt.verbose. (authored by gniibe).
agent: Fix a bug accessing after release when opt.verbose.
May 23 2022, 2:50 AM
gniibe committed rGef3e5fd40377: agent: Factor out handling scanning over ssh keys. (authored by gniibe).
agent: Factor out handling scanning over ssh keys.
May 23 2022, 2:50 AM

May 20 2022

gniibe added a comment to T5985: private-key: Support "Use-for-ssh" flag.

cmd_keyinfo should be also updated to access the field correctly.

May 20 2022, 7:59 AM · Feature Request, ssh, gpgagent
gniibe added a project to T5986: card: Show "Label:" when prompting the insertion of a card: Restricted Project.
May 20 2022, 7:41 AM · ssh, gpgagent, scd
gniibe committed rG598631086652: agent: Show "Label:" field of private key when prompt the insertion. (authored by gniibe).
agent: Show "Label:" field of private key when prompt the insertion.
May 20 2022, 7:41 AM
gniibe committed rG6a37240cf279: agent: Move confirmation handling into findkey.c. (authored by gniibe).
agent: Move confirmation handling into findkey.c.
May 20 2022, 7:41 AM
gniibe added a parent task for T5702: Display prompt to user when YubiKey is waiting for touch confirmation: T5984: gpg-agent interaction improvement (smartcard improvement #3).
May 20 2022, 6:53 AM · patch, Feature Request
gniibe added a parent task for T5099: Confirmation dialog for remote access (restricted extra socket): T5984: gpg-agent interaction improvement (smartcard improvement #3).
May 20 2022, 6:53 AM · Feature Request, gnupg
gniibe added subtasks for T5984: gpg-agent interaction improvement (smartcard improvement #3): T5099: Confirmation dialog for remote access (restricted extra socket), T5702: Display prompt to user when YubiKey is waiting for touch confirmation.
May 20 2022, 6:53 AM · ssh, gpgagent, scd
gniibe renamed T5984: gpg-agent interaction improvement (smartcard improvement #3) from smartcard interaction improvement #3 to gpg-agent interaction improvement ( (smartcard improvement #3).
May 20 2022, 6:39 AM · ssh, gpgagent, scd
gniibe triaged T5988: agent: Add new command to update private key fields as Normal priority.
May 20 2022, 6:38 AM · Feature Request, ssh, gpgagent
gniibe triaged T5987: card: New field to specify refusing operations when card/token is not available as Normal priority.
May 20 2022, 6:33 AM · ssh, gpgagent, scd
gniibe added a comment to T5986: card: Show "Label:" when prompting the insertion of a card.

Also, it is better for a user, not to be asked confirmation (even if "Confirm:" is specified), that is, skipping the confirmation, when it is going to prompt the insertion of a card.

May 20 2022, 6:29 AM · ssh, gpgagent, scd
gniibe triaged T5986: card: Show "Label:" when prompting the insertion of a card as Normal priority.
May 20 2022, 6:27 AM · ssh, gpgagent, scd
gniibe triaged T5985: private-key: Support "Use-for-ssh" flag as Normal priority.
May 20 2022, 6:23 AM · Feature Request, ssh, gpgagent
gniibe triaged T5984: gpg-agent interaction improvement (smartcard improvement #3) as Normal priority.
May 20 2022, 6:21 AM · ssh, gpgagent, scd

May 19 2022

gniibe added a comment to T5702: Display prompt to user when YubiKey is waiting for touch confirmation.

I put another change for T5099. This feature can be used for any keys, no matter if it's on Yubikey or not, no matter if token supports touch confirmation or not.

May 19 2022, 7:45 AM · patch, Feature Request
gniibe added projects to T5099: Confirmation dialog for remote access (restricted extra socket): Restricted Project, Feature Request.
May 19 2022, 7:40 AM · Feature Request, gnupg
gniibe added a comment to T5099: Confirmation dialog for remote access (restricted extra socket).

Part 2 patch is pushed, with a bit of change.
A user needs to specify "Confirm" flag in the key file.

May 19 2022, 7:40 AM · Feature Request, gnupg
gniibe committed rG598b3fdfaa09: agent: Pop up dialog window for confirmation, when specified so. (authored by gniibe).
agent: Pop up dialog window for confirmation, when specified so.
May 19 2022, 7:39 AM
gniibe committed rG09357d7eae3e: agent: Supply GRIP=NULL for agent_key_from_file, for real use. (authored by gniibe).
agent: Supply GRIP=NULL for agent_key_from_file, for real use.
May 19 2022, 7:12 AM
gniibe added a comment to T5099: Confirmation dialog for remote access (restricted extra socket).

Part 1 patch is pushed.

May 19 2022, 7:08 AM · Feature Request, gnupg
gniibe added a comment to T5977: Smartcard PIN stays in clear in memory.

For this particular issue of assuan_inquire, if it's needed, the point we should fix is:

May 19 2022, 6:29 AM · backport, libassuan, pinentry, scd, gnupg (gpg22), Bug Report
gniibe claimed T5975: Allow signature verification using specific RSA keys <2k in FIPS mode.

Pushed the change (master and 1.10).

May 19 2022, 3:50 AM · backport, patch, libgcrypt, FIPS, Feature Request
gniibe committed rCca2afc9fb64d: cipher: Allow verification of small RSA signatures in FIPS mode (authored by Jakuje).
cipher: Allow verification of small RSA signatures in FIPS mode
May 19 2022, 3:48 AM
gniibe added a comment to T5964: gnupg should use the KDFs implemented in libgcrypt.

At first, we need to add/enhance new API for KDF in libgcrypt. Currently, the term "KDF" in libgcrypt is used with narrower focus, that is, only for password->key KDF.

May 19 2022, 3:43 AM · gnupg26, FIPS, Feature Request

May 18 2022

gniibe added a comment to T5862: authentication with USB token.

A concrete example use case in my mind is:

  • (Usual display manager (authentication by password or no-password))
  • session starts with "locked" state of screen
    • In the beginning, user needs to "unlock" the screen, by scdaemon authentication
  • (optionally, if needed) our-own-screen-locker should detect device removal, then, automatically locks the screen
  • our-own-screen-locker should detect idling user session, then, disabling the card, automatically locks the screen
  • our-own-screen-locker does authentication by scdaemon when it unlocks the screen
May 18 2022, 9:34 AM · gpgagent, Feature Request, scd
gniibe added a comment to T5862: authentication with USB token.

Note that this doesn't work if pinentry is pinentry-gnome3. pinentry-qt works well, too, because it supports curses fallback.

May 18 2022, 9:06 AM · gpgagent, Feature Request, scd
gniibe added a comment to T5862: authentication with USB token.

I added the last line, to recover tty state:

May 18 2022, 8:56 AM · gpgagent, Feature Request, scd
gniibe added a comment to T5862: authentication with USB token.

With cmatrix command and pinentry-gtk2, I now do experiment with this script:

May 18 2022, 5:09 AM · gpgagent, Feature Request, scd
gniibe added a comment to T5971: Yubikey: Removal of device is not detected by PC/SC.

No, no apologize needed. You did your best for the bug report, and it helped us a lot to identify the issue, and it certainly helped resulting the fixes. Moreover, your report kicked another fix of T5979 (thanks to the valgrind output).
Thank you.

May 18 2022, 1:37 AM · Info Needed, yubikey, scd, Bug Report

May 17 2022

werner awarded F3647377: gpg-auth2.sh a Cup of Joe token.
May 17 2022, 1:28 PM
gniibe added a comment to T5862: authentication with USB token.

This is updated version of gpg-auth, which clears the authentication state before trying PKAUTH.
Access is controlled by ~/.ssh/authorized_keys.

May 17 2022, 11:18 AM · gpgagent, Feature Request, scd
gniibe added a comment to T5862: authentication with USB token.

This is the one for login authentication (which invokes scdaemon to authenticate, instead of connecting by socket).

May 17 2022, 10:59 AM · gpgagent, Feature Request, scd
gniibe added a comment to T5980: compilation error libgcrypt 1.10.1.

For the second, I wonder if newer xlclang++ compiler works with 1.9.

May 17 2022, 4:58 AM · backport, ppc, AIX, libgcrypt, Bug Report
gniibe triaged T5980: compilation error libgcrypt 1.10.1 as Normal priority.

Thank you for the bug report.

May 17 2022, 4:31 AM · backport, ppc, AIX, libgcrypt, Bug Report
gniibe committed rC4019f1a66b15: Fix internal declaration of _gcry_kdf_compute. (authored by gniibe).
Fix internal declaration of _gcry_kdf_compute.
May 17 2022, 4:14 AM
gniibe committed rG1b1684cf6192: scd: Fix use of SCardListReaders for PC/SC. (authored by gniibe).
scd: Fix use of SCardListReaders for PC/SC.
May 17 2022, 3:57 AM
gniibe committed rG7bc794c31134: scd: Fix use of SCardListReaders for PC/SC. (authored by gniibe).
scd: Fix use of SCardListReaders for PC/SC.
May 17 2022, 3:57 AM
gniibe committed rGa5217c90003c: scd: Add workaround for ECC attribute on Yubikey. (authored by gniibe).
scd: Add workaround for ECC attribute on Yubikey.
May 17 2022, 3:57 AM
gniibe committed rCc0692324fe8b: mpi: Allow building with --disable-asm for HPPA. (authored by gniibe).
mpi: Allow building with --disable-asm for HPPA.
May 17 2022, 3:50 AM
gniibe added a project to T5976: libgcrypt build failure on HPPA 1.1 (./.libs/libgcrypt.so: undefined reference to `__udiv_qrnnd'): Restricted Project.

Pushed the change.

May 17 2022, 3:47 AM · backport, hppa, libgcrypt, Gentoo, Bug Report
gniibe added a project to T5979: SCardListReaders: Conditional jump or move depends on uninitialised value(s): Restricted Project.

To detect these kinds of bugs, possibly, we can use new GCC option: -ftrivial-auto-var-init=0xFEFEFEFE.
https://gcc.gnu.org/gcc-12/changes.html#uninitialized

May 17 2022, 3:34 AM · backport, gnupg, scd, patch
gniibe claimed T5979: SCardListReaders: Conditional jump or move depends on uninitialised value(s).

The bug was there when it was initially written. It was in 2003, which introduced PC/SC in rG1bcf8ef9dea1: Cleanups, fixes and PC/SC support

May 17 2022, 3:29 AM · backport, gnupg, scd, patch
gniibe added a comment to T5971: Yubikey: Removal of device is not detected by PC/SC.

When compiling the package, I can see that all 4 are applied.

May 17 2022, 2:41 AM · Info Needed, yubikey, scd, Bug Report

May 16 2022

gniibe removed a project from T5616: asn1-parse.y:861:20: error: 'yytoknum' undeclared: Restricted Project.
May 16 2022, 8:23 AM · toolchain, libksba, Bug Report
gniibe added a comment to T5976: libgcrypt build failure on HPPA 1.1 (./.libs/libgcrypt.so: undefined reference to `__udiv_qrnnd').

Thanks for your confirmation.

May 16 2022, 4:05 AM · backport, hppa, libgcrypt, Gentoo, Bug Report
gniibe added a comment to T5971: Yubikey: Removal of device is not detected by PC/SC.

Thanks again for your update.

May 16 2022, 3:08 AM · Info Needed, yubikey, scd, Bug Report

May 13 2022

gniibe added a comment to T5976: libgcrypt build failure on HPPA 1.1 (./.libs/libgcrypt.so: undefined reference to `__udiv_qrnnd').

Could you please give us the build log with no --disable-asm?

May 13 2022, 4:33 AM · backport, hppa, libgcrypt, Gentoo, Bug Report
gniibe added a comment to T5971: Yubikey: Removal of device is not detected by PC/SC.

I put more fix for error handling of key algorithm attribute.
The change: rG53eddf9b9ea0: scd: Fail when no good algorithm attribute.

May 13 2022, 3:21 AM · Info Needed, yubikey, scd, Bug Report
gniibe added a comment to T5971: Yubikey: Removal of device is not detected by PC/SC.

Thanks a lot for your cooperation.

May 13 2022, 3:15 AM · Info Needed, yubikey, scd, Bug Report

May 12 2022

gniibe added a comment to T5971: Yubikey: Removal of device is not detected by PC/SC.

Please do experiment again and give us the whole log of scdaemon.log for:

  • insert Yubikey initially
  • run gpg --card-status (success is expected)
  • remove Yubikey
  • insert Yubikey second time
  • run gpg --card-status (failure is expected)
May 12 2022, 5:19 PM · Info Needed, yubikey, scd, Bug Report
gniibe added a comment to T5971: Yubikey: Removal of device is not detected by PC/SC.

Umm... The problem is the last bogus octet from Yubikey. In the log, we see:

May 12 2022, 1:43 AM · Info Needed, yubikey, scd, Bug Report

May 11 2022

gniibe added a comment to T5963: Yubikey: scdaemon causes libc segfault and clashes with ECC keys.

The change improve error handling for possible other errors by device: rG53eddf9b9ea0: scd: Fail when no good algorithm attribute.

May 11 2022, 4:31 AM · backport, yubikey, scd, segv, Bug Report
gniibe committed rG53eddf9b9ea0: scd: Fail when no good algorithm attribute. (authored by gniibe).
scd: Fail when no good algorithm attribute.
May 11 2022, 4:23 AM
gniibe added a comment to T5971: Yubikey: Removal of device is not detected by PC/SC.

Thank you for the logs. It seems that scdaemon didn't detect the removal correctly.

May 11 2022, 1:50 AM · Info Needed, yubikey, scd, Bug Report

May 10 2022

gniibe added a project to T5970: gcry_mpi_invm producing wrong result: Restricted Project.

Pushed the change. Also, it's backported to 1.10 branch.

May 10 2022, 8:59 AM · backport, libgcrypt, Bug Report
gniibe committed rCa611e3a25d61: mpi: Fix for 64-bit for _gcry_mpih_cmp_ui. (authored by gniibe).
mpi: Fix for 64-bit for _gcry_mpih_cmp_ui.
May 10 2022, 8:48 AM
gniibe claimed T5970: gcry_mpi_invm producing wrong result.

Thanks for creating this ticket. I'll reply.

May 10 2022, 8:44 AM · backport, libgcrypt, Bug Report
gniibe added a comment to T5899: Fix compilation of dirmngr with mingw.org's MinGW.

Pushed the changes for http.c.

May 10 2022, 7:58 AM · patch, Feature Request, Windows, toolchain
gniibe committed rG14068dfc74ff: dirmngr: Fix for Windows. (authored by gniibe).
dirmngr: Fix for Windows.
May 10 2022, 7:57 AM
gniibe closed T5731: libgcrypt,w32: Possible API change for include file(s) as Resolved.

libgcrypt 1.10 is out with the API change for Windows, and we don't see any report (yet).

May 10 2022, 7:34 AM · libgcrypt
gniibe added a project to T5889: Declaration of 'struct timespec' in npth-1.6 conflicts with some versions of MinGW: Restricted Project.
May 10 2022, 7:31 AM · npth, Bug Report