Page MenuHome GnuPG
Feed Advanced Search

Thu, Apr 11

aheinecke added a comment to T6813: GpgOL: Key generation window does not close.
In T6813#184976, @ebo wrote:

Works on Gpg4win 4.3.1, too.

But noticed an inconsistency for the key creation via GpgOL: Contrary to the behavior for key creation in Kleopatra in Gpg4win, you are asked for a password for the new key.

Thu, Apr 11, 3:11 PM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project
ebo closed T6813: GpgOL: Key generation window does not close as Resolved.
Thu, Apr 11, 2:39 PM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project
ebo moved T6813: GpgOL: Key generation window does not close from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Thu, Apr 11, 2:39 PM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project
ebo added a comment to T6813: GpgOL: Key generation window does not close.

Works on Gpg4win 4.3.1, too.

Thu, Apr 11, 2:33 PM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project

Feb 8 2024

aheinecke added a comment to T6840: Libkleo: KeySelectionCombo has wrong sizeHint.

In E1020 @TobiasFella wrote about this: Sizehint is correct, but only at a later point in time; also, apparently some cache invalidation problem? Since the current version works fine with a fixed size, might not be worth the effort to fix.

Feb 8 2024, 10:10 AM · vsd33, libkleo, Restricted Project

Jan 2 2024

aheinecke added a parent task for T6911: Libkleo / Kleopatra: Group configuration from keyresolver?: T6914: Kleopatra: Make group feature more visible.
Jan 2 2024, 11:33 AM · libkleo, kleopatra, Restricted Project

Dec 28 2023

aheinecke updated the task description for T6911: Libkleo / Kleopatra: Group configuration from keyresolver?.
Dec 28 2023, 12:09 PM · libkleo, kleopatra, Restricted Project
aheinecke triaged T6911: Libkleo / Kleopatra: Group configuration from keyresolver? as Normal priority.
Dec 28 2023, 12:07 PM · libkleo, kleopatra, Restricted Project

Dec 15 2023

ikloecker added a comment to T6840: Libkleo: KeySelectionCombo has wrong sizeHint.

I suggest to replace size.width() with qMax(size.width(), minWidth) where minWidth is the width of a reasonably sized text (to account for different text sizes) instead of trying to fight with the combo box. Combo boxes are not a good UI element for long entries.

Dec 15 2023, 8:22 AM · vsd33, libkleo, Restricted Project
aheinecke added a comment to T6840: Libkleo: KeySelectionCombo has wrong sizeHint.

Shouldn't that be the difference between SizeAdjustPolicy AdjustToContentsOnFirstShow and AdjustToContents?

Dec 15 2023, 7:01 AM · vsd33, libkleo, Restricted Project

Dec 14 2023

TobiasFella added a comment to T6840: Libkleo: KeySelectionCombo has wrong sizeHint.

As far as I can tell, the sizeHint is "correct", for the items that are currently in the combobox. At the point in time of creating the dialog, the combobox only contains two items ("new key" and "no key"), which both have shorter strings than an average key description. The actual keys are only added to the combobox at a later point. I tried to make the dialog's size update when that happens, but have not managed to get it working yet, i think that some cache is not being invalidated correctly.

Dec 14 2023, 2:36 PM · vsd33, libkleo, Restricted Project

Dec 12 2023

aheinecke reassigned T6840: Libkleo: KeySelectionCombo has wrong sizeHint from ikloecker to TobiasFella.

Tobias could you create an MR for this?

Dec 12 2023, 7:37 AM · vsd33, libkleo, Restricted Project

Dec 11 2023

aheinecke closed T6837: GpgOL: Keyresolver size default too small as Resolved.
Dec 11 2023, 12:15 PM · vsd32 (vsd-3.2.0), Restricted Project, gpgol, libkleo

Nov 29 2023

aheinecke triaged T6854: Kleopatra / libkleo: Improve tooltips for unusable keys in keyresolver as Low priority.
Nov 29 2023, 7:15 PM · Restricted Project, libkleo, gpgol

Nov 27 2023

ebo moved T6837: GpgOL: Keyresolver size default too small from QA to vsd-3.2.0 on the vsd32 board.
Nov 27 2023, 4:00 PM · vsd32 (vsd-3.2.0), Restricted Project, gpgol, libkleo
ebo added a comment to T6837: GpgOL: Keyresolver size default too small.

I can confirm this

Nov 27 2023, 4:00 PM · vsd32 (vsd-3.2.0), Restricted Project, gpgol, libkleo
ebo edited projects for T6839: GpgOL: Keyresolver forbids to encrypt to (partially?) untrusted keys, added: Not A Bug; removed vsd32, Restricted Project.
Nov 27 2023, 10:28 AM · Not A Bug, libkleo
ikloecker added a comment to T6839: GpgOL: Keyresolver forbids to encrypt to (partially?) untrusted keys.

Wait,.. I misunderstood this issue B81CE112B26A8EA8BE7B95D2E375339BF4C51840 has no encryption subkey o.O

Nov 27 2023, 9:43 AM · Not A Bug, libkleo

Nov 25 2023

aheinecke added a comment to T6837: GpgOL: Keyresolver size default too small.

Works nicely for me in beta300

Nov 25 2023, 10:18 PM · vsd32 (vsd-3.2.0), Restricted Project, gpgol, libkleo
aheinecke moved T6837: GpgOL: Keyresolver size default too small from Backlog to QA on the vsd32 board.
Nov 25 2023, 10:17 PM · vsd32 (vsd-3.2.0), Restricted Project, gpgol, libkleo
aheinecke changed the status of T6837: GpgOL: Keyresolver size default too small from Open to Testing.

Looks good now

Nov 25 2023, 5:12 PM · vsd32 (vsd-3.2.0), Restricted Project, gpgol, libkleo
aheinecke closed T6839: GpgOL: Keyresolver forbids to encrypt to (partially?) untrusted keys as Invalid.
Nov 25 2023, 5:49 AM · Not A Bug, libkleo
aheinecke triaged T6840: Libkleo: KeySelectionCombo has wrong sizeHint as Normal priority.
Nov 25 2023, 5:16 AM · vsd33, libkleo, Restricted Project
aheinecke added a comment to T6839: GpgOL: Keyresolver forbids to encrypt to (partially?) untrusted keys.

Wait,.. I misunderstood this issue B81CE112B26A8EA8BE7B95D2E375339BF4C51840 has no encryption subkey o.O

Nov 25 2023, 5:04 AM · Not A Bug, libkleo
aheinecke triaged T6839: GpgOL: Keyresolver forbids to encrypt to (partially?) untrusted keys as High priority.
Nov 25 2023, 4:37 AM · Not A Bug, libkleo
aheinecke added a comment to T6837: GpgOL: Keyresolver size default too small.

New MR: https://invent.kde.org/pim/libkleo/-/merge_requests/61

Nov 25 2023, 4:11 AM · vsd32 (vsd-3.2.0), Restricted Project, gpgol, libkleo

Nov 24 2023

aheinecke added a project to T6837: GpgOL: Keyresolver size default too small: vsd32.

MR for this: https://invent.kde.org/pim/libkleo/-/merge_requests/60/

Nov 24 2023, 6:41 PM · vsd32 (vsd-3.2.0), Restricted Project, gpgol, libkleo
aheinecke added a project to T6837: GpgOL: Keyresolver size default too small: Restricted Project.

I am temped to put the VSD-3.2 flag on it and raise prio to high because of strategic reasons... So if someone has a cheap fix for this. Please go for it.

Nov 24 2023, 4:31 PM · vsd32 (vsd-3.2.0), Restricted Project, gpgol, libkleo
aheinecke triaged T6837: GpgOL: Keyresolver size default too small as Normal priority.
Nov 24 2023, 4:29 PM · vsd32 (vsd-3.2.0), Restricted Project, gpgol, libkleo
ebo moved T6823: GpgOL: Security Approval reports "Operation Failed" error if key generation was canceled from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 24 2023, 11:44 AM · vsd32 (vsd-3.2.0), libkleo, gpgol, Restricted Project

Nov 23 2023

ebo moved T6823: GpgOL: Security Approval reports "Operation Failed" error if key generation was canceled from QA to vsd-3.2.0 on the vsd32 board.
Nov 23 2023, 5:26 PM · vsd32 (vsd-3.2.0), libkleo, gpgol, Restricted Project
ebo added a comment to T6823: GpgOL: Security Approval reports "Operation Failed" error if key generation was canceled.

Works on windows, too. VS-Desktop-3.1.90.295-Beta

Nov 23 2023, 5:25 PM · vsd32 (vsd-3.2.0), libkleo, gpgol, Restricted Project
ebo moved T6813: GpgOL: Key generation window does not close from QA to vsd-3.2.0 on the vsd32 board.
Nov 23 2023, 5:08 PM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project
ebo added a comment to T6813: GpgOL: Key generation window does not close.

works, VS-Desktop-3.1.90.295-Beta

Nov 23 2023, 5:07 PM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project
aheinecke moved T6823: GpgOL: Security Approval reports "Operation Failed" error if key generation was canceled from Backlog to QA on the vsd32 board.
Nov 23 2023, 2:18 PM · vsd32 (vsd-3.2.0), libkleo, gpgol, Restricted Project
aheinecke moved T6813: GpgOL: Key generation window does not close from WiP to QA on the vsd32 board.
Nov 23 2023, 2:16 PM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project

Nov 21 2023

ikloecker changed the status of T6813: GpgOL: Key generation window does not close from Open to Testing.

I have added a workaround and tested it on Windows. Works now for me, including T6566.

Nov 21 2023, 1:58 PM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project
aheinecke added a comment to T6813: GpgOL: Key generation window does not close.

@ikloecker I suggest giving up on this, I know that it is frustrating but it does not make much sense, it is probably related to some compiler settings / Qt cross compile issue and might be a bug in qt. Just do an old style connect and leave a comment that we will revisit this with Qt6. When VSD 3.2 is our last major release based on Qt5 we should not spend too much time investigating this which might be completely different (or not) with Qt6.

Nov 21 2023, 7:34 AM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project

Nov 20 2023

ikloecker moved T6813: GpgOL: Key generation window does not close from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 20 2023, 8:22 PM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project
ikloecker claimed T6813: GpgOL: Key generation window does not close.
Nov 20 2023, 8:22 PM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project
ikloecker added a comment to T6813: GpgOL: Key generation window does not close.

And it's the signals that are not found. I don't see any indication that this has anything to do with the slots/lambdas.

Nov 20 2023, 2:17 PM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project
ikloecker added a comment to T6813: GpgOL: Key generation window does not close.

Well, the failed new style connects are logged for me with "QObject::connect: signal not found in QGpgME::QGpgMEQuickJob". I haven't dug into how the check works for those connects. It turns out that none of the three connects to the signals of QuickJob work (two of those connects are done in ProgressDialog). Even the connect to the argument-less done() signal. So this has nothing to do with default arguments. This is very disturbing because this means that any other connect might also be broken.

Nov 20 2023, 2:15 PM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project
aheinecke added a comment to T6813: GpgOL: Key generation window does not close.

Ah no I see the difference here. Instead of connecting to a lambda with no args 96da231f97eff9485f62ab925d81252f5f97fc31 connected to the functions which were used in the old signal / slot syntax. I think the fix might be to explicitly list the args of the quickjob result or to use afunction to handle the keygenresult.

Nov 20 2023, 1:56 PM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project
aheinecke added a comment to T6813: GpgOL: Key generation window does not close.

It does not log failed connections but new style connections are never logged when they fail. Since they can't fail ;-)

Nov 20 2023, 1:43 PM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project
aheinecke moved T6813: GpgOL: Key generation window does not close from Backlog to WiP on the vsd32 board.
Nov 20 2023, 1:40 PM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project
aheinecke added a project to T6813: GpgOL: Key generation window does not close: vsd32.
Nov 20 2023, 1:40 PM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project
aheinecke raised the priority of T6813: GpgOL: Key generation window does not close from Normal to High.

Let me put this on the 3.2 workboard since we already have the "reports error when canceled" on that workboard and T6566 too depens on this, in fact I am currently working on this even though it was not on the workbaord.

Nov 20 2023, 1:40 PM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project
ikloecker added a comment to T6813: GpgOL: Key generation window does not close.

Does Qt log failed connections?

Nov 20 2023, 8:25 AM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project

Nov 16 2023

aheinecke added a project to T6823: GpgOL: Security Approval reports "Operation Failed" error if key generation was canceled: vsd32.

I cherry picked it anyway. See my notes in T6813 I think I will at least workaround that one tomorrow.

Nov 16 2023, 9:42 PM · vsd32 (vsd-3.2.0), libkleo, gpgol, Restricted Project
aheinecke added a comment to T6813: GpgOL: Key generation window does not close.

Mh, I found some commits related to that 0796e04aa43c4500fb0f2c378b9a6cadf53a0a94 a43080fb0472afb46726cc555efffa102de9c7cc 810ed7b374f38eb7e038a83a557c8b6b91a65da3 if I remember correctly I even discussed this with Thiago and or David Faure back then and we figured it was a problem with default arguments. And there might have been a difference in KDE Compile settings and the compile settings with which QGpgME are compiled. It is pretty weird though even after some searching I can't find an initial commit from me that might be more verbose about the topic then just "Again new style connects won't work".

Nov 16 2023, 8:45 PM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project
ikloecker added a comment to T6813: GpgOL: Key generation window does not close.

Eva said this worked with older installers. Otherwise, she wouldn't have reported T6566 as-is. What changed is that we now use QuickJob/QGpgMEQuickJob instead of DefaultKeyGenerationJob (the one defined in QGpgME).

Nov 16 2023, 1:41 PM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project
ikloecker changed the status of T6823: GpgOL: Security Approval reports "Operation Failed" error if key generation was canceled from Open to Testing.

This may not be reproducible on Windows for the same reasons as T6813.

Nov 16 2023, 12:00 PM · vsd32 (vsd-3.2.0), libkleo, gpgol, Restricted Project
aheinecke claimed T6813: GpgOL: Key generation window does not close.

Me neither. But I take this since I can better debug this on Windows directly since this seems to be a windows only issue and it might be a build issue.

Nov 16 2023, 11:57 AM · vsd32 (vsd-3.2.0), gpgol, libkleo, Restricted Project
aheinecke added a project to T6823: GpgOL: Security Approval reports "Operation Failed" error if key generation was canceled: libkleo.

Not important for VSD 3.2 but yes I would like to see that fixed. Especially since we want the resolver also in KMail.

Nov 16 2023, 11:51 AM · vsd32 (vsd-3.2.0), libkleo, gpgol, Restricted Project

Aug 13 2021

werner changed the edit policy for libkleo.
Aug 13 2021, 11:08 PM

Jul 25 2019

aheinecke set the color for libkleo to Violet.
Jul 25 2019, 11:39 AM