Page MenuHome GnuPG
Feed Advanced Search

Apr 15 2020

werner committed rG4148976841d1: scd:p15: Emit MANUFACTURER, $ENCRKEYID, $SIGNKEYID. (authored by werner).
scd:p15: Emit MANUFACTURER, $ENCRKEYID, $SIGNKEYID.
Apr 15 2020, 3:48 PM
werner committed rGb0cb2c2ab8c7: scd:p15: Rename some variables and functions for clarity. (authored by werner).
scd:p15: Rename some variables and functions for clarity.
Apr 15 2020, 3:48 PM
werner committed rG133b6ff8cd0c: scd:p15: Cache the PIN. (authored by werner).
scd:p15: Cache the PIN.
Apr 15 2020, 3:48 PM
werner committed rGc0d5c673542b: sm,dirmngr: Restrict allowed parameters used with rsaPSS. (authored by werner).
sm,dirmngr: Restrict allowed parameters used with rsaPSS.
Apr 15 2020, 11:11 AM

Apr 14 2020

werner assigned T4915: Cannot compile on macOS Mojave (utf8.c) to gniibe.

Thanks for reporting; the code is really new and not yet fully tested.

Apr 14 2020, 6:33 PM · Restricted Project, gnupg (gpg23), Bug Report
werner committed rKe6e9858970ed: Support rsaPSS also for CRLs. (authored by werner).
Support rsaPSS also for CRLs.
Apr 14 2020, 4:53 PM
werner committed rK17a09f41fc4b: Allow for Null hash algo parameters on rsaPSS and add pss flag. (authored by werner).
Allow for Null hash algo parameters on rsaPSS and add pss flag.
Apr 14 2020, 4:53 PM
werner committed rK5c08d7ea8e0f: Refactor PSS parameter parsing. (authored by werner).
Refactor PSS parameter parsing.
Apr 14 2020, 4:53 PM
werner committed rK641fc8b6deac: Merge copies of stringbuf functions into one new header. (authored by werner).
Merge copies of stringbuf functions into one new header.
Apr 14 2020, 4:53 PM
werner closed T4538: Support PSS signed CRLs as Resolved.

Data (ie.e CMS) signatures do now also work.

Apr 14 2020, 4:26 PM · dirmngr, S/MIME, libksba
werner committed rG6c28d9343ea6: sm: Support rsaPSS verification also for CMS signatures. (authored by werner).
sm: Support rsaPSS verification also for CMS signatures.
Apr 14 2020, 3:51 PM
werner committed rC32b08e38628b: sexp: Extend gcry_sexp_extract_param with a multi-string extractor. (authored by werner).
sexp: Extend gcry_sexp_extract_param with a multi-string extractor.
Apr 14 2020, 2:28 PM

Apr 10 2020

werner added a comment to T4913: ntbtls: TLS handshake error.

I think I fixed a memory leak on error but no other changes for old code except that the array to old the args now takes void* and not gcry_mpi_t - which does not make a difference.

Apr 10 2020, 12:23 PM · ntbtls

Apr 9 2020

werner committed rC60c179b59e53: sexp: Extend gcry_sexp_extract_param with new format specifiers. (authored by werner).
sexp: Extend gcry_sexp_extract_param with new format specifiers.
Apr 9 2020, 8:23 PM
werner added a comment to T4908: ECDH with AES-128 decryption failure when fully padded.

There are no betas; either you apply the patch mentioned above ( rG2f08a4f25df7) to a stock 2.2.20 or you build from the Git repo (STABLE-BRANCH-2-2, see https://gnupg.org/download/git.html).

Apr 9 2020, 6:44 PM · Restricted Project, gnupg (gpg22), Bug Report
werner added a comment to T4538: Support PSS signed CRLs.

Okay certificate and CRL checking does now work with rsaPSS. Need to work on data signatures and check the compliance modes.

Apr 9 2020, 1:09 PM · dirmngr, S/MIME, libksba
werner committed rGba34f1415366: dirmngr: Support rsaPSS also in the general validate module. (authored by werner).
dirmngr: Support rsaPSS also in the general validate module.
Apr 9 2020, 1:07 PM
werner committed rGb45ab0ca08f8: sm,dirmngr: Support rsaPSS signature verification. (authored by werner).
sm,dirmngr: Support rsaPSS signature verification.
Apr 9 2020, 12:24 PM
werner committed rG5d5b70ae0f51: common: New function to map hash algo names. (authored by werner).
common: New function to map hash algo names.
Apr 9 2020, 12:24 PM
werner committed rGbfedc760efdc: scd:p15: Return a display S/N via Assuan. (authored by werner).
scd:p15: Return a display S/N via Assuan.
Apr 9 2020, 12:24 PM
werner edited projects for T4912: Miscellaneous feedback for gpg4win-compendium-de.pdf , added: Documentation; removed Bug Report.
Apr 9 2020, 9:02 AM · Documentation, gpg4win

Apr 8 2020

werner committed rKf5695be600ab: Add read-only support for rsaPSS. (authored by werner).
Add read-only support for rsaPSS.
Apr 8 2020, 8:52 PM
werner committed rK152d04749cce: Remove duplicated code and make parse wrappers internally available. (authored by werner).
Remove duplicated code and make parse wrappers internally available.
Apr 8 2020, 8:52 PM
werner claimed T4538: Support PSS signed CRLs.

I started to work on it so that I can actually use the certificates on my new D-Trust card. This will be a verify-only implementation.

Apr 8 2020, 8:37 PM · dirmngr, S/MIME, libksba
werner added a comment to T4908: ECDH with AES-128 decryption failure when fully padded.

FWIW, the code was written by the author of the specs and he note in his original patch (rGe0972d3d96) :

Apr 8 2020, 4:07 PM · Restricted Project, gnupg (gpg22), Bug Report

Apr 7 2020

werner closed T4909: gpg2: "decryption failed: No secret key" DBG: search.keyring.c.1109, parse.keyring.c.415 as Resolved.

That smells very much like an old and insecure version 3 key. We don't allow them anymore - use gpg 1 to decrypt old material but never use that key to sign stuff or give it to others to encrypt to you. It is just too weak.

Apr 7 2020, 8:59 PM · FAQ
werner committed rG9ec8d984be46: scd:p15: Show a pretty PIN prompt. (authored by werner).
scd:p15: Show a pretty PIN prompt.
Apr 7 2020, 8:40 PM
werner committed rGf28795b615c3: scd: Return GPG_ERR_BAD_PIN on 0x63Cn status word. (authored by werner).
scd: Return GPG_ERR_BAD_PIN on 0x63Cn status word.
Apr 7 2020, 8:40 PM
werner committed rG60d018f6a91c: scd: Factor common PIN status check out. (authored by werner).
scd: Factor common PIN status check out.
Apr 7 2020, 8:40 PM
werner committed rG42ddcc87f4bc: scd:p15: Fix decrypt followed by sign problem for D-Trust cards. (authored by werner).
scd:p15: Fix decrypt followed by sign problem for D-Trust cards.
Apr 7 2020, 4:05 PM
werner committed rG5ec1f667930b: doc: Typo fix in code comment. (authored by werner).
doc: Typo fix in code comment.
Apr 7 2020, 4:05 PM
werner added a comment to T4909: gpg2: "decryption failed: No secret key" DBG: search.keyring.c.1109, parse.keyring.c.415.

Please explain what your problems is. Setting arbitrary debug flags is not helpful for your or us.

Apr 7 2020, 8:48 AM · FAQ
werner created T4910: Allow to add a no-mail notation to user-ids.
Apr 7 2020, 8:38 AM · gnupg24, gnupg (gpg23), Feature Request

Apr 6 2020

werner added a comment to T4908: ECDH with AES-128 decryption failure when fully padded.

EdDSA is sign only - how do you want to encrypt to such a key? Did you mean cv25519 and ECDH?

Apr 6 2020, 12:21 PM · Restricted Project, gnupg (gpg22), Bug Report
werner added a project to T3763: ECDH - encryption with obfuscated size of the symmetric key: OpenPGP.

I also don't think that key size obfuscation is useful, after all the preferences of the key demand a certain key size.

Apr 6 2020, 12:19 PM · OpenPGP, gnupg (gpg23)
werner added a comment to T4774: Cross compilation friendly libgpg-error.

Clever idea.

Apr 6 2020, 9:49 AM · Restricted Project, gpgrt

Apr 3 2020

werner committed rE98d11eff669c: core: Improve the echo and info meta commands of the arg parser (authored by werner).
core: Improve the echo and info meta commands of the arg parser
Apr 3 2020, 10:51 PM
werner committed rEef07aedc7099: core: Implement meta command [user] also for Windows (authored by werner).
core: Implement meta command [user] also for Windows
Apr 3 2020, 10:51 PM
werner committed rEd843d260f550: core: Implement meta command [user] for the arg parser. (authored by werner).
core: Implement meta command [user] for the arg parser.
Apr 3 2020, 10:42 PM
werner committed rK1119068b2e9f: Very minor patch cleanup (authored by werner).
Very minor patch cleanup
Apr 3 2020, 5:18 PM
werner committed rGaa60645b997d: scd:p15: Emit MANUFACTURER, $ENCRKEYID, $SIGNKEYID. (authored by werner).
scd:p15: Emit MANUFACTURER, $ENCRKEYID, $SIGNKEYID.
Apr 3 2020, 11:22 AM
werner committed rG541a6a903e79: scd:openpgp: New attribute "MANUFACTURER". (authored by werner).
scd:openpgp: New attribute "MANUFACTURER".
Apr 3 2020, 11:22 AM
werner committed rG15352b0eac33: gpg,card: Use the new MANUFACTURER attribute. (authored by werner).
gpg,card: Use the new MANUFACTURER attribute.
Apr 3 2020, 11:22 AM

Apr 2 2020

werner committed rG61c5b0767fac: scd:p15: Implement do_with_keygrip and capabilities. (authored by werner).
scd:p15: Implement do_with_keygrip and capabilities.
Apr 2 2020, 2:23 PM
werner committed rG8149742ddfea: scd:p15: Rename some variables and functions for clarity. (authored by werner).
scd:p15: Rename some variables and functions for clarity.
Apr 2 2020, 2:23 PM
werner closed T4907: Spurious warning: ignoring return value of ‘write’ ... as Spite.

Please stop this and use the mailing list for such ramblings. Usually only one developer reads a bug report and thus you can't participate from the experience of others - use mailing lists - please.

Apr 2 2020, 12:05 PM · gnupg
werner committed rG5b7b42e2b2b7: scd: Use Gcrypt usage constants for the do_with_keygrip capabilities. (authored by werner).
scd: Use Gcrypt usage constants for the do_with_keygrip capabilities.
Apr 2 2020, 11:54 AM
werner awarded T4864: New scdaemon command to watch device removal a Cup of Joe token.
Apr 2 2020, 10:19 AM · Restricted Project, Feature Request, scd, Bug Report

Apr 1 2020

werner triaged T4900: OS X 10.12 and dyld: Library not loaded: /usr/local/lib/libgcrypt.20.dylib as Normal priority.
Apr 1 2020, 8:53 PM · MacOS, libgcrypt, Bug Report
werner closed T4905: t-secmem: line 176: gcry_control ((GCRYCTL_INIT_SECMEM, pool_size, 0)) failed: General error as Invalid.
Apr 1 2020, 8:52 PM · libgcrypt, Bug Report
werner closed T4904: argparse.c:286:22: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' as Spite.

See my comments on the other bugs you posted today.

Apr 1 2020, 8:51 PM · gpgrt, Bug Report
werner closed T4902: libgpg-error and yat2m: can't open include file './version.texi': No such file or directory as Spite.

Please see my other comments; we need proper bug reports and not just arbitrary snippets.

Apr 1 2020, 8:50 PM · gpgrt, Bug Report
werner closed T4901: Libgcrypt-error 1.38 is missing from https://gnupg.org/ftp/gcrypt/libgpg-error as Invalid.

That are all development versions and they may require the latest changes from the repo of other libraries.

Apr 1 2020, 8:49 PM · gnupg, Bug Report
werner added a comment to T4905: t-secmem: line 176: gcry_control ((GCRYCTL_INIT_SECMEM, pool_size, 0)) failed: General error.

Please write proper bug reports and do not just post snippets from some arbitrary build process. In addition master is non-released software and thus it is in general better to ask at gcrypt-devel@gnupg.org for help.

Apr 1 2020, 8:48 PM · libgcrypt, Bug Report
werner closed T4903: Github sources are difficult to test as Invalid.

Sorry, if you use your own copy of GnuPG on GitHub, it is all up to you. We do not use Github.

Apr 1 2020, 8:45 PM · gnupg, Bug Report
werner committed rG29f8f52bf816: scd:p15: Cache the PIN. (authored by werner).
scd:p15: Cache the PIN.
Apr 1 2020, 8:32 PM
werner committed rG132d82c15820: scd:p15: Run a keygrip_from_prkdf before verify_pin (authored by werner).
scd:p15: Run a keygrip_from_prkdf before verify_pin
Apr 1 2020, 8:32 PM
werner committed rGb95a0bfbba75: scd:p15: Add missing keygrip retrieval for decryption. (authored by werner).
scd:p15: Add missing keygrip retrieval for decryption.
Apr 1 2020, 5:43 PM
werner committed rGe730444e7b75: scd:p15: Support signing with CardOS 5 cards. (authored by werner).
scd:p15: Support signing with CardOS 5 cards.
Apr 1 2020, 4:19 PM
werner committed rG4af38ea5e450: scd:p15: Support decryption with CardOS 5 cards. (authored by werner).
scd:p15: Support decryption with CardOS 5 cards.
Apr 1 2020, 4:19 PM
werner committed rGce9406ca370b: scd:p15: Factor PIN verification out to a new function. (authored by werner).
scd:p15: Factor PIN verification out to a new function.
Apr 1 2020, 4:19 PM
werner committed rG64142caafe5c: scd: Add function for binary read in extended mode. (authored by werner).
scd: Add function for binary read in extended mode.
Apr 1 2020, 4:19 PM
werner committed rG368f006a2840: scd:p15: Read certificates in extended mode. (authored by werner).
scd:p15: Read certificates in extended mode.
Apr 1 2020, 4:19 PM
werner committed rG135af6652558: scd:p15: Improve diagnostics (authored by werner).
scd:p15: Improve diagnostics
Apr 1 2020, 4:19 PM
werner committed rG60b0aa7e57e7: scd:p15: Detect CardOS 5 cards and print some basic infos. (authored by werner).
scd:p15: Detect CardOS 5 cards and print some basic infos.
Apr 1 2020, 4:19 PM
werner committed rGca4391399c69: scd:p15: Support decryption with CardOS 5 cards. (authored by werner).
scd:p15: Support decryption with CardOS 5 cards.
Apr 1 2020, 2:08 PM
werner committed rG375b1454875f: scd:p15: Factor PIN verification out to a new function. (authored by werner).
scd:p15: Factor PIN verification out to a new function.
Apr 1 2020, 2:08 PM
werner closed T4495: UBsan finding "certdump.c:695:3: runtime error: null pointer passed as argument 2" as Resolved.

Applied the fix also to master with a comment to ebentually replace it with es_fopenmem.

Apr 1 2020, 10:00 AM · gnupg
werner closed T4899: Undefined behavior in sm/certdump.c as Resolved.
Apr 1 2020, 9:59 AM · gnupg, Bug Report
werner committed rGc7ff8c59b925: sm: Fix a warning in an es_fopencooie function. (authored by werner).
sm: Fix a warning in an es_fopencooie function.
Apr 1 2020, 9:59 AM

Mar 31 2020

werner committed rG103c1576b73e: scd:p15: Support signing with CardOS 5 cards. (authored by werner).
scd:p15: Support signing with CardOS 5 cards.
Mar 31 2020, 7:57 PM
werner committed rG2bdd4fc7b6cf: scd:p15: Read certificates in extended mode. (authored by werner).
scd:p15: Read certificates in extended mode.
Mar 31 2020, 12:05 PM
werner committed rGc9ad81070a2b: scd: Add function for binary read in extended mode. (authored by werner).
scd: Add function for binary read in extended mode.
Mar 31 2020, 12:05 PM
werner committed rGc29603fa9a1a: scd:p15: Improve diagnostics (authored by werner).
scd:p15: Improve diagnostics
Mar 31 2020, 12:05 PM
werner triaged T4898: auto import CA certs with authInfo.caIssuers as Normal priority.
Mar 31 2020, 12:04 PM · dirmngr, S/MIME, gnupg (gpg23)
werner created T4898: auto import CA certs with authInfo.caIssuers.
Mar 31 2020, 12:04 PM · dirmngr, S/MIME, gnupg (gpg23)

Mar 30 2020

werner committed rG8a68d497f1dd: scd:p15: Detect CardOS 5 cards and print some basic infos. (authored by werner).
scd:p15: Detect CardOS 5 cards and print some basic infos.
Mar 30 2020, 9:20 PM
werner closed T4886: gpg-wks-server fails on openbsd, because sendmail is in /usr/sbin, not /usr/lib as Resolved.

Done; will go into 2.2.21 (T4897).

Mar 30 2020, 5:42 PM · wkd, gnupg (gpg22), Bug Report
werner committed rG76d2a02dfe8f: wks: Take name of sendmail from configure. (authored by werner).
wks: Take name of sendmail from configure.
Mar 30 2020, 5:41 PM
werner renamed T4897: Release GnuPG 2.2.21 from Release GnUPG 2.2.21 to Release GnuPG 2.2.21.
Mar 30 2020, 5:40 PM · gnupg (gpg22), Release Info
werner created T4897: Release GnuPG 2.2.21.
Mar 30 2020, 5:40 PM · gnupg (gpg22), Release Info
werner closed T4895: segfaults in certreqen.c from logging NULL return from get_parameter as Resolved.

Thanks.

Mar 30 2020, 5:35 PM · gnupg (gpg22), S/MIME, Bug Report
werner committed rG9c5c7c6f602c: sm: Fix possible NULL deref in error messages of --gen-key. (authored by werner).
sm: Fix possible NULL deref in error messages of --gen-key.
Mar 30 2020, 5:35 PM
werner committed rGc5c21a064671: agent: Print an error if gpg-protect reads the extended key format. (authored by werner).
agent: Print an error if gpg-protect reads the extended key format.
Mar 30 2020, 5:35 PM
werner committed rG011a2f5fb77c: agent: Print an error if gpg-protect reads the extended key format. (authored by werner).
agent: Print an error if gpg-protect reads the extended key format.
Mar 30 2020, 5:35 PM
werner committed rG2b4b0b1223aa: sm: Fix possible NULL deref in error messages of --gen-key. (authored by werner).
sm: Fix possible NULL deref in error messages of --gen-key.
Mar 30 2020, 5:35 PM
werner committed rK1e903fe558bd: Allow optional elements in keyinfo objects. (authored by werner).
Allow optional elements in keyinfo objects.
Mar 30 2020, 5:32 PM
werner added a comment to T4892: gpgsm --gen-key with existing key from "ssh-add" fails.

The problem was the comment field which was not expected in an rsa key. However ist makes sense to allow additional fields and thus I pushed a change to Libksba.

Mar 30 2020, 5:00 PM · gnupg24, Bug Report, S/MIME

Mar 29 2020

werner added a comment to T4393: GnuPG should always accept key updates even if the update does not contain UIDs.

No, we always stated that the user id is a mandatory part of OpenPGP keyblocks and that non-compliant keyblocks are rejected. The only exception we made are for revocation signatures where we allow a standalone packet. That exception is done to allow typing in a printed out revocation signature.

Mar 29 2020, 6:30 PM · gnupg (gpg23), Feature Request
werner closed T4393: GnuPG should always accept key updates even if the update does not contain UIDs as Wontfix.

With OpenPGP we made user ids mandatory to avoid problems we had with PGP2. I see no reason to revert this.

Mar 29 2020, 11:25 AM · gnupg (gpg23), Feature Request

Mar 27 2020

werner committed rG1424c12e4c71: sm: Consider certificates w/o CRL DP as valid. (authored by werner).
sm: Consider certificates w/o CRL DP as valid.
Mar 27 2020, 9:24 PM
werner committed rG0b583a555e75: sm: Consider certificates w/o CRL DP as valid. (authored by werner).
sm: Consider certificates w/o CRL DP as valid.
Mar 27 2020, 9:16 PM
werner committed rG4c4999b8185a: scd:openpgp: Allow PKSIGN with keygrip also for OPENPGP.3. (authored by werner).
scd:openpgp: Allow PKSIGN with keygrip also for OPENPGP.3.
Mar 27 2020, 7:38 PM
werner triaged T4894: FIPS: RSA/DSA/ECDSA are missing hashing operation as Normal priority.

I recall that I talked with Stephan about it but things got lost.

Mar 27 2020, 7:12 PM · FIPS, libgcrypt, Feature Request
werner set the icon for FIPS to Tag.
Mar 27 2020, 7:12 PM
werner awarded T4888: GpgSM: Support ECC key generation by gpgsm_genkey a Cup of Joe token.
Mar 27 2020, 4:18 PM · Restricted Project, Feature Request, S/MIME

Mar 26 2020

werner closed T4893: "Note: signatures using the MD5 algorithm are rejected" is emitted despite --quiet as Wontfix.

This is an important information to know because it can help to avoid bug reports.

Mar 26 2020, 7:32 PM · gnupg (gpg22), Bug Report
werner closed T4892: gpgsm --gen-key with existing key from "ssh-add" fails as Wontfix.

Please use the mailing list for help on generating keys. I would also suggest to use GnuPG master for such experiments.

Mar 26 2020, 10:27 AM · gnupg24, Bug Report, S/MIME

Mar 25 2020

werner added a comment to T4890: print preview tries to use wrong key for decryption.

FWIW, a log of the decryption process will always show the sender's key because a message is usually also encrypted to that one (--encrypt-to).

Mar 25 2020, 1:00 PM · gpgol, Bug Report
werner created T4891: Support CBOR content in gpgsm.
Mar 25 2020, 12:54 PM · Feature Request, gnupg, S/MIME