I'd sad we keep it as it is now (unless we see a regression). The real and only correct solution is the use of a daemon to serialize access.

Still, there is a fundamental problem with keydb locking.

• It only assures no-data-corruption.
• When a process doing write access, another process reading the resource may encounter a problem (inconsistent data read), since data could be changed while accessing.
  • Currently, write access may occur with keybox compress, this means that users are not safe to invoke multiple gpg/gpgsm simultaneously (to be sure).
    • It would be: only keybox compress when users explicitly ask.
  • We could introduce a lock to read access... BUT naively adding a lock (both for read and write or read-multiple-write-one) results possible deadlock in gpgsm
    • in gpgsm, gpgsm_walk_cert_chain and gpgsm_validate_chain access the resource of keydb in a way of:
      • While it has a handle kh, by find_up routine, it may call keydb_store_cert by callback routine; The callback does write access to the resource opening another handle.
      • Currently, it works because of no lock for read access and keydb_store_cert appends data at the end.

All changes in gniibe/t7855 are pushed into master.

Backported for VSD 3.4 since this is clearly a regression introduced with T7350 and the fix is zero risk.

Fixed. The check box has been removed from the "S/MIME Validation" tab.

Fixed and backported for VSD 3.4

Fixed in master: rGae431b04370f: w32:common: Take care of possible race on startup under Windows.

I merged Tobias's MR

We need to check what the current status here is. This has been in the 5.0 Betas for a while, so testing with 5.0-Beta369 will work

Fixed and backported for VSD 3.4

With a GNUPG-Home on another Partition (on the VMs shared folder with the host) the auto refresh after deletion additionally doesn't work for public keys or S/MIME certificates.

Lastly, pushed a change into gniibe/t7855 branch.
rGf861b2a33f96: gpg,gpgsm: Fix thinko for FP closing under no lock.

Fixed and backported for VSD 3.4

Backported for VSD 3.4

Backported for VSD 3.4

Backported for VSD 3.4

Fixed. When one of the lists/tables gets focus then NVDA should speak something like "<name of list> list" or "<name of table> tree view".

I pushed further changes into gniibe/t7855 branch.
rG2fe62809014e: gpg,gpgsm: Serialize write access to keybox/keyring to protect.

Note: QGpgMEWKDLookupJob uses an Assuan transaction with dirmngr.

We had considered and rejected adding below the above configuration a marked section (like e.g. with a frame) showing the options in the order they appear in the sign/encrypt window:

• Sign as
• Encrypt for me
• Encrypt for others
• Encrypt with password
• Encrypt / Sign each file separately

For remaining changes in 2.2, I pushed changes into gniibe/t7855 branch.
rGbd65b06b74c2: gpg,gpgsm: Don't lock recursively when KEEP_LOCK is enabled.
rG423fd047da87: kbx,gpg,gpgsm: Add FP-close method for keydb to close before unlock.
rG966258ac5f99: gpgsm: Fix delete and store certificate locking glitches.

I pushed changes into gniibe/t7855 for compressing the keybox.
rG8cc2a0e0ffee: gpg: Minor clean up for keydb_lock API.
rGe4d3c3aa2220: kbx,gpg,gpgsm: Introduce keybox_compress_when_no_other_users.
rG3e441d5b299f: kbx,gpg,gpgsm: More changes for compressing the keybox.

Then, we need to integrate following commits of 2.2 into gniibe/t7855 branch:
rG43fe9073aa81: gpg,gpgsm: Tweak the locking of the pubring.kbx
rG8491aca73cff: gpg: Revert the always locking introduced with 43fe9073aa
rGad4a5117ab1c: gpgsm: Properly release the lock when compressing a pubring.
rG7962eca3a023: gpgsm: Change delete and store certificate locking glitches.
rG22f9c4a3b3c1: gpg: Release lock after close also in the compress code path.

I created gniibe/t7855 branch for this issue.
To start with, I forward-port/cherry-pick 2.2 commits to the branch:
rG39430d9f78dc: build,common,g13,sm,tools: Require GpgRT 1.56.
rGe71aca2a628d: common: New function gnupg_remove_ext.
rGe38c5f7d5873: w32:common: Take care of possible race on startup under Windows.
rG7bfd37e305c0: common,w32: Always use share mode readwrite for the keybox.

with VS-Desktop-3.3.90.19-Beta, and settings disableAutoPreview and ReadAsPlain

with VS-Desktop-3.3.90.19-Beta, and settings disableAutoPreview and ReadAsPlain

This does not occur any more in Gpg4win-5.0.0-beta369

I understand that this is for 2.6.

Except for the release/unlock thing after keybox_compress I already have the other fixes in my 2.2 commits. I noticed that the gpgsm keydb lock/release stuff differes from the one for gpg: For gpg we use the keybox_lock function but that is bot used at all by gpgsm. In theory this should be unified but I fear a regression risk and thus for 2.2 we better don't touch it.

The latter is also the case for deleted softkeys.

Might be related to T7836?

Shall we merge this with T2196 ? BTW, I have some unpushed commit and a test installer.

related to T7843: GpgOL: Empty OpenPGP mails with "Read as plain" activated

Here are places where I found problems.

The regression that the Welcome screen didn't go away after generating the very first key has been fixed. The fix has been backported for VSD 3.4 and VSD 3.3.