Page MenuHome GnuPG
Feed Advanced Search

Oct 25 2018

werner added a comment to T4226: Change "Public Key" to "OpenPGP Certificate".

The correct technical term is OpenPGP Public Keyblock but I better shut up on the certificate vs. Public key(block) question.

Oct 25 2018, 3:25 PM · nGPH
werner created P7 X25519 the ugly way.
Oct 25 2018, 1:15 PM
werner committed rC3b271079d529: cipher: Add comments about future OIDs. (authored by werner).
cipher: Add comments about future OIDs.
Oct 25 2018, 1:05 PM

Oct 24 2018

werner added a comment to rGef540d1af064: doc: fix spelling mistakes.

Thanks

Oct 24 2018, 8:46 PM
werner added a member for nGPH: olf.
Oct 24 2018, 8:43 PM
werner closed T4223: Uninitialized use of ctx variable in simple-pwquery.c as Resolved.

Thanks.

Oct 24 2018, 8:34 PM · gnupg
werner closed T4222: Uninitialized use of value variable in command.c cmd_genkey as Resolved.

Thanks.

Oct 24 2018, 8:33 PM · gnupg
werner removed a project from T4221: Suspicious read error handling in command-ssh.c ssh_handler_add_identity: backport.
Oct 24 2018, 8:33 PM · gnupg
werner closed T4221: Suspicious read error handling in command-ssh.c ssh_handler_add_identity as Resolved.

Thanks.

Oct 24 2018, 8:33 PM · gnupg
werner closed T4220: Leak of FILE memory in gpg-connect-agent.c:do_open as Resolved.

Thanks.

Oct 24 2018, 8:33 PM · gnupg
werner closed T4219: Copy & paste error in gpgsm.c as Resolved.

Thanks

Oct 24 2018, 8:32 PM · gnupg
werner committed rGe53253485cd7: agent: Fix possible uninitalized use of CTX in simple_pwquery. (authored by werner).
agent: Fix possible uninitalized use of CTX in simple_pwquery.
Oct 24 2018, 8:32 PM
werner committed rG62c75271173f: agent: Fix possible release of unitialize var in a genkey error case. (authored by werner).
agent: Fix possible release of unitialize var in a genkey error case.
Oct 24 2018, 8:32 PM
werner committed rG147e59b7815d: ssh: Fix possible infinite loop in case of an read error. (authored by werner).
ssh: Fix possible infinite loop in case of an read error.
Oct 24 2018, 8:32 PM
werner committed rGf1561e5196e5: tools: Fix FILE memory leak in gpg-connect-agent. (authored by werner).
tools: Fix FILE memory leak in gpg-connect-agent.
Oct 24 2018, 8:32 PM
werner committed rG1b9b0fc54b9b: sm: Use the correct string in an error message. (authored by werner).
sm: Use the correct string in an error message.
Oct 24 2018, 8:32 PM
werner added a project to T4223: Uninitialized use of ctx variable in simple-pwquery.c: backport.

Thanks.

Oct 24 2018, 8:22 PM · gnupg
werner committed rG2bdc4b6ed977: agent: Fix possible release of unitialize var in a genkey error case. (authored by werner).
agent: Fix possible release of unitialize var in a genkey error case.
Oct 24 2018, 8:22 PM
werner committed rGbafcf7095159: agent: Fix possible uninitalized use of CTX in simple_pwquery. (authored by werner).
agent: Fix possible uninitalized use of CTX in simple_pwquery.
Oct 24 2018, 8:22 PM
werner committed rG7385e1babf6e: ssh: Fix possible infinite loop in case of an read error. (authored by werner).
ssh: Fix possible infinite loop in case of an read error.
Oct 24 2018, 8:22 PM
werner committed rG378719f25fe0: tools: Fix FILE memory leak in gpg-connect-agent. (authored by werner).
tools: Fix FILE memory leak in gpg-connect-agent.
Oct 24 2018, 8:22 PM
werner committed rG793fd8d87677: sm: Use the correct string in an error message. (authored by werner).
sm: Use the correct string in an error message.
Oct 24 2018, 8:22 PM
werner added a project to T4222: Uninitialized use of value variable in command.c cmd_genkey: backport.

Thanks. May also happen if the first print_assuan_status fails.

Oct 24 2018, 8:15 PM · gnupg
werner added a project to T4221: Suspicious read error handling in command-ssh.c ssh_handler_add_identity: backport.
Oct 24 2018, 8:11 PM · gnupg
werner committed rG64a1e86fc06d: gpg: Unfinished support for v5 signatures. (authored by werner).
gpg: Unfinished support for v5 signatures.
Oct 24 2018, 4:18 PM
werner committed rG3b88bceb4dc3: indent: Modernize g10/sign.c (authored by werner).
indent: Modernize g10/sign.c
Oct 24 2018, 4:18 PM
werner committed rG256a280c51f9: dirmngr: Prepare for updated WKD specs with ?l= param (authored by werner).
dirmngr: Prepare for updated WKD specs with ?l= param
Oct 24 2018, 4:18 PM
werner closed T4208: Copy & paste error in libgcrypt ecc-curves.c as Resolved.

Fixed in 1.8

Oct 24 2018, 12:34 PM · Bug Report, libgcrypt
werner closed T4212: Uninitialized use of l1 variable in _gcry_sexp_vextract_param as Resolved.

Fixed in 1.8

Oct 24 2018, 12:33 PM · Bug Report, libgcrypt
werner closed T4102: libgcrypt: yat2m does not respect SOURCE_DATE_EPOCH, patch included as Resolved.

yat2m updated. Thanks.

Oct 24 2018, 12:32 PM · gpgrt, libgcrypt, Bug Report
werner committed rC99a5babfd1e7: build: Add release make target (authored by werner).
build: Add release make target
Oct 24 2018, 12:32 PM
werner committed rC4e044b80b296: doc: Update yat2m.c from upstream (libgpg-error) (authored by werner).
doc: Update yat2m.c from upstream (libgpg-error)
Oct 24 2018, 12:32 PM
werner committed rCabd267bf2393: Fix memory leak in secmem in out of core conditions. (authored by werner).
Fix memory leak in secmem in out of core conditions.
Oct 24 2018, 12:32 PM
werner committed rC60224352f4de: ecc: Fix memory leak in the error case of ecc_encrypt_raw (authored by werner).
ecc: Fix memory leak in the error case of ecc_encrypt_raw
Oct 24 2018, 12:32 PM
werner committed rC7f4de8bab991: doc: Fix example for gcry_sexp_extract_param (authored by werner).
doc: Fix example for gcry_sexp_extract_param
Oct 24 2018, 12:32 PM
werner committed rC347987d4cf29: ecc: Fix possible memory leakage in parameter check of eddsa. (authored by werner).
ecc: Fix possible memory leakage in parameter check of eddsa.
Oct 24 2018, 12:32 PM
werner committed rC8cc7cac82ec2: sexp: Fix uninitialized use of a var in the error case. (authored by werner).
sexp: Fix uninitialized use of a var in the error case.
Oct 24 2018, 12:32 PM
werner committed rCbe68b3ee4fd1: ecc: Fix potential unintended freeing of an internal param. (authored by werner).
ecc: Fix potential unintended freeing of an internal param.
Oct 24 2018, 12:32 PM
werner committed rCb0ad66e48c46: build: Make distcheck work again. (authored by werner).
build: Make distcheck work again.
Oct 24 2018, 12:30 PM
werner committed rC03bb25ee7ed6: build: Add release make target (authored by werner).
build: Add release make target
Oct 24 2018, 12:30 PM
werner committed rC0cfd41c66279: doc: Update yat2m.c from upstream (libgpg-error) (authored by werner).
doc: Update yat2m.c from upstream (libgpg-error)
Oct 24 2018, 12:06 PM
werner closed T4210: Potential memory leak in ecc_encrypt_raw as Resolved.
Oct 24 2018, 11:56 AM · libgcrypt
werner closed T4211: Potential memory leak in _gcry_secmem_malloc_internal as Resolved.

Thanks.

Oct 24 2018, 11:55 AM · libgcrypt
werner committed rCf74687fd43f5: Fix memory leak in secmem in out of core conditions. (authored by werner).
Fix memory leak in secmem in out of core conditions.
Oct 24 2018, 11:55 AM
werner committed rCe57e75ea517f: ecc: Fix memory leak in the error case of ecc_encrypt_raw (authored by werner).
ecc: Fix memory leak in the error case of ecc_encrypt_raw
Oct 24 2018, 11:55 AM
werner added a comment to T4210: Potential memory leak in ecc_encrypt_raw.

Thanks again.

Oct 24 2018, 11:51 AM · libgcrypt
werner closed T4209: Potential memory leak in _gcry_ecc_eddsa_verify as Resolved.

Thanks. Not a real world problem now but needs to be fixed.

Oct 24 2018, 10:03 AM · libgcrypt
werner committed rC149ceb3cae03: ecc: Fix possible memory leakage in parameter check of eddsa. (authored by werner).
ecc: Fix possible memory leakage in parameter check of eddsa.
Oct 24 2018, 10:03 AM
werner closed T4216: Newline at end of tooltip string just making tooltip unnecessarily bigger as Resolved.

Thanks. There is an easier solution for this, though: I now trim trailing LFs.

Oct 24 2018, 9:42 AM · gpa, Bug Report
werner committed rGPA70858dcd6062: Trim tooltips before displaying. (authored by werner).
Trim tooltips before displaying.
Oct 24 2018, 9:40 AM
werner triaged T4215: Typo bees/been as Low priority.
Oct 24 2018, 9:27 AM · gpa
werner added a comment to T4217: {libksba,libgcrypt,ntbtls,libassuan,npth}.m4, {libksba,libgcrypt,ntbtls,libassuan}-config script and gpg-error-config.

May I suggest to use a (new) gpgrt-config instead of the current name libgpg-error-config. The long term plan is to change the name of the library.

Oct 24 2018, 9:06 AM · npth, libassuan, ntbtls, libgcrypt, libksba
werner committed rKa1ce3c17ee0d: Fix error detection in the CMS parser which may led to a NULL-deref. (authored by werner).
Fix error detection in the CMS parser which may led to a NULL-deref.
Oct 24 2018, 2:13 AM
werner committed rKd56bddc68db8: Use only one .PHONY target in a Makefile. (authored by werner).
Use only one .PHONY target in a Makefile.
Oct 24 2018, 2:13 AM
werner committed rKa0bbba1c4928: Fix test for existence of the signing_time (authored by werner).
Fix test for existence of the signing_time
Oct 24 2018, 2:13 AM

Oct 23 2018

werner committed rCe2da4e8dee4b: ecc: Fix potential unintended freeing of an internal param. (authored by werner).
ecc: Fix potential unintended freeing of an internal param.
Oct 23 2018, 11:38 PM
werner committed rC9f2c7ec4d8b0: sexp: Fix uninitialized use of a var in the error case. (authored by werner).
sexp: Fix uninitialized use of a var in the error case.
Oct 23 2018, 11:38 PM
werner committed rC282f238f7788: doc: Fix example for gcry_sexp_extract_param (authored by werner).
doc: Fix example for gcry_sexp_extract_param
Oct 23 2018, 11:38 PM
werner triaged T4208: Copy & paste error in libgcrypt ecc-curves.c as High priority.

Thanks. Fixed in master. Needs backport.

Oct 23 2018, 10:59 PM · Bug Report, libgcrypt
werner triaged T4199: Disable scaling for cardkey icon in keylist as Normal priority.
Oct 23 2018, 10:54 PM · gpa, Bug Report
werner triaged T4212: Uninitialized use of l1 variable in _gcry_sexp_vextract_param as High priority.

Thanks. Fixed in master.

Oct 23 2018, 10:53 PM · Bug Report, libgcrypt
werner closed T4207: Copy & paste error in libksba cms.c as Resolved.

Thanks.

Oct 23 2018, 10:44 PM · libksba
werner closed T4213: Invalid test for certlist->signing_time in build_signed_data_attributes in cms.c as Resolved.

Thanks. That code is from 2001 and whne I changed to another time representaion in 2003 (due certs with 40 years expiration time) I missed to changed that condition.

Oct 23 2018, 10:39 PM · libksba
werner committed rGPA493b02e52377: po: Added missing files and sorted POTFILES (authored by werner).
po: Added missing files and sorted POTFILES
Oct 23 2018, 10:01 PM
werner closed T4214: Missing files in POTFILES.in as Resolved.

Thanks. I added these files.

Oct 23 2018, 9:55 PM · gpa

Oct 22 2018

werner committed rGa2bd4a64e5b0: dirmngr: Prepare for updated WKD specs with ?l= param (authored by werner).
dirmngr: Prepare for updated WKD specs with ?l= param
Oct 22 2018, 8:14 PM
werner closed T4014: when verifying signatures, gpg and gpgv should ensure signing capabilities as Resolved.
Oct 22 2018, 7:32 PM · gpgv, gnupg, Bug Report
werner committed rGb0d6e26bf3c8: gpg: Fix extra check for sign usage of a data signature. (authored by werner).
gpg: Fix extra check for sign usage of a data signature.
Oct 22 2018, 7:29 PM
werner added a comment to T4182: Dirmngr: Keeps files in homedir open on Windows.

iirrc, that are memory mapped files.

Oct 22 2018, 5:35 PM · dirmngr
werner committed rG68b8096b6617: agent: Fix build regression for Windows. (authored by werner).
agent: Fix build regression for Windows.
Oct 22 2018, 5:28 PM
werner committed rG0a7f446c1892: dirmngr: In verbose mode print the OCSP responder id. (authored by werner).
dirmngr: In verbose mode print the OCSP responder id.
Oct 22 2018, 2:52 PM
werner committed rGf03928b16c4f: tools: Replace duplicated code in mime-maker. (authored by werner).
tools: Replace duplicated code in mime-maker.
Oct 22 2018, 2:52 PM
werner added a comment to rE12b834ba59ae: yat2m: Avoid compiler warnings..

Can you please be so kind and show the compiler warning? I can't see any fault in the code unless the OS is broken.
Instead of that change I would suggest to change the sprintf to

snprintf (buffer,  sizeof buffer, "%04d-%02d-%02d",
          1900+tp->tm_year, tp->tm_mon+1, tp->tm_mday )
Oct 22 2018, 12:51 PM
werner created T4205: Release libgpg-error 1.33.
Oct 22 2018, 12:01 PM · gpgrt, Release Info
werner closed T4201: gpg: keyserver send failed: Server indicated a failure as Resolved.

I am sorry about this but the hkps pool has load problems because only a few servers are left. You might have a better chance getting your key uploaded by configuring another pool. See https://sks-keyservers.net . The admins are aware of the problem but there won't be any short time solution.

Oct 22 2018, 10:02 AM · Bug Report

Oct 21 2018

werner triaged T4175: HTTP 5xx should fail over to the next server as High priority.
Oct 21 2018, 2:48 PM · dirmngr, Feature Request
werner created T4200: Evaluate sub-addresses in gpg and wkd.
Oct 21 2018, 2:46 PM · gnupg, Feature Request

Oct 19 2018

werner added a comment to T4198: Pinentry doesn't capture input correctly, crashes terminal instead.

Thanks for the reporting templates; would mind to fill in some bug details?

Oct 19 2018, 8:00 PM · pinentry, Bug Report

Oct 18 2018

werner lowered the priority of T3443: Install gpg 1.4 as gpg1 from Unbreak Now! to Normal.
Oct 18 2018, 8:35 PM · Feature Request
werner added a comment to T4191: gpgme python bindings test t-callbacks.py fails on 32-bit platforms.

That is up to @BenM

Oct 18 2018, 7:56 PM · Python, gpgme, Bug Report
werner closed T4196: gpgme-json is confused about malformed input as Invalid.

The default mode of the tool is to use the Native Messaging protocol which prefixes requests and responses with a 32 bit native endian length header. It is the default due to the way browsers call native messaging programs. If you want to use it in a different way, use the option --single or --interactive.

Oct 18 2018, 7:54 PM · gpgme
werner added a comment to T4195: Fix time API in gpgme.

That it will not be a problem on that or near that date but already now because some use expiration times of 20 years.

Oct 18 2018, 7:49 PM · gnupg, kleopatra, Restricted Project, gpgme, Feature Request
werner added a comment to T4191: gpgme python bindings test t-callbacks.py fails on 32-bit platforms.

See T4195 for the general problem

Oct 18 2018, 6:10 PM · Python, gpgme, Bug Report
werner created T4195: Fix time API in gpgme.
Oct 18 2018, 6:09 PM · gnupg, kleopatra, Restricted Project, gpgme, Feature Request
werner assigned T4191: gpgme python bindings test t-callbacks.py fails on 32-bit platforms to BenM.

I have not looked at the new error but the year 2099 is clearly a y2k38 problem. gpg has some precautions but I have not checked the key generation code. The gpgme interface uses a signed long for the expiration time, although that it parses the dates received from gpg as an unsigned long. Right now, I am not sure why we did this because an unsigned long would just work. Maybe we can change or enhance the interface. But in any case this is a general problem and not specific to this bug.

Oct 18 2018, 5:54 PM · Python, gpgme, Bug Report
werner changed the status of T4192: python gpg segfaults when first parameter to gpg.Context().op_genkey() is None or otherwise malformed from Open to Testing.
Oct 18 2018, 5:41 PM · Python, gpgme
werner committed rMfbac11b19d97: core: Fix segv in genkey when no endtag is provided. (authored by werner).
core: Fix segv in genkey when no endtag is provided.
Oct 18 2018, 5:41 PM
werner added a comment to T4192: python gpg segfaults when first parameter to gpg.Context().op_genkey() is None or otherwise malformed.

@BenM thinks that swig is still the best option. Actually this case helped to find a bug in gpgme. See my next commit.

Oct 18 2018, 5:40 PM · Python, gpgme
werner committed rM174af15725d4: core: Return an error if NULL is provided for genkey's parms. (authored by werner).
core: Return an error if NULL is provided for genkey's parms.
Oct 18 2018, 5:00 PM
werner added a comment to T4192: python gpg segfaults when first parameter to gpg.Context().op_genkey() is None or otherwise malformed.

That swig based interface is not really robust and it can't be because it does not known about API requirements. I bet there are other places where mandatory parameters are not checked.

Oct 18 2018, 4:13 PM · Python, gpgme
werner changed the status of T3354: gpgme only builds against two versions of python at once from Open to Testing.
Oct 18 2018, 11:48 AM · Python, gpgme, Bug Report
werner triaged T4191: gpgme python bindings test t-callbacks.py fails on 32-bit platforms as High priority.
Oct 18 2018, 11:46 AM · Python, gpgme, Bug Report
werner added a comment to rM2f12427e416a: doc: use https:// for www.gnu.org.

FWIW, you should better not change the build-aux/ files becuase they are supposed to be updated from libgpg-error.

Oct 18 2018, 11:42 AM
werner triaged T4190: https://git.gnupg.org/ is out of date as Normal priority.
Oct 18 2018, 11:40 AM · gpgweb, Bug Report
werner assigned T4192: python gpg segfaults when first parameter to gpg.Context().op_genkey() is None or otherwise malformed to BenM.
Oct 18 2018, 11:39 AM · Python, gpgme
werner added a comment to T4192: python gpg segfaults when first parameter to gpg.Context().op_genkey() is None or otherwise malformed.

Is this new in gpgme 1.12 or might it also be in older versions?

Oct 18 2018, 11:38 AM · Python, gpgme
werner committed rGPAd7f0e50b7a45: Replace use of the GPGME_KEYLIST_MODE_LOCATE alias (authored by werner).
Replace use of the GPGME_KEYLIST_MODE_LOCATE alias
Oct 18 2018, 11:29 AM
werner committed rGPA9ac18119fb3c: Allow searchin in the key listing also for mail addresses. (authored by werner).
Allow searchin in the key listing also for mail addresses.
Oct 18 2018, 11:17 AM

Oct 17 2018

werner closed T4187: Error in decrypt_file function as Invalid.

That is a different python binding than what we provide with gpgme. Our gpgme based binding is called "gpg" and was formerly known as "pyme". I strongly suggest to install gpgme and not to use pip because the "gpg" module over there has not been updated for quite some time.

Oct 17 2018, 9:59 PM · Bug Report
werner added a comment to T4187: Error in decrypt_file function.

From where did you go that "python package gnupg==2.3.1" ?
Sorry, I can see what kind of Python code this is. It is not part of GnuPG, though.

Oct 17 2018, 5:43 PM · Bug Report