Page MenuHome GnuPG
Feed Advanced Search

Sep 1 2020

gniibe updated the task description for T5001: Card specification enhancement.
Sep 1 2020, 7:23 AM · Feature Request, scd
gniibe triaged T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status as High priority.
Sep 1 2020, 7:11 AM · Restricted Project, gnupg (gpg22), Bug Report
gniibe added a comment to T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status.

I think that following patch can solve the issue:

Sep 1 2020, 7:10 AM · Restricted Project, gnupg (gpg22), Bug Report

Aug 31 2020

gniibe added a comment to T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status.

Ah, I see the situation of the regression.
When the token is not yet accessed at all, scdaemon misunderstood as no signing key.

Aug 31 2020, 10:20 AM · Restricted Project, gnupg (gpg22), Bug Report
gniibe added a comment to T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status.

Do you have a signing key in your card or not?

Aug 31 2020, 10:18 AM · Restricted Project, gnupg (gpg22), Bug Report
gniibe claimed T5039: 2.2.22 regression: Nitrokey Pro 2 is no longer recognized automatically, requires --card-status.
Aug 31 2020, 10:17 AM · Restricted Project, gnupg (gpg22), Bug Report

Aug 28 2020

gniibe committed rG393dcdd61c3b: common: Fix fallback handling to utf-8. (authored by gniibe).
common: Fix fallback handling to utf-8.
Aug 28 2020, 8:21 AM
gniibe added a comment to T5038: UTF-8 handling in the command line.

I mean:

diff --git a/common/utf8conv.c b/common/utf8conv.c
index 7804dbfcd..bdab225a9 100644
--- a/common/utf8conv.c
+++ b/common/utf8conv.c
@@ -138,7 +138,7 @@ handle_iconv_error (const char *to, const char *from, int use_fallback)
          native encoding.  Nowadays this seems to be the best bet in
          case of errors from iconv or nl_langinfo.  */
       active_charset_name = "utf-8";
-      no_translation = 0;
+      no_translation = 1;
       use_iconv = 0;
     }
 }
Aug 28 2020, 7:39 AM · gnupg
gniibe added a subtask for T1514: charset weirdness with non-ascii User IDs under non-UTF-8 locales: T5038: UTF-8 handling in the command line.
Aug 28 2020, 7:37 AM · Bug Report, gnupg
gniibe added a parent task for T5038: UTF-8 handling in the command line: T1514: charset weirdness with non-ascii User IDs under non-UTF-8 locales.
Aug 28 2020, 7:37 AM · gnupg
gniibe updated the task description for T5038: UTF-8 handling in the command line.
Aug 28 2020, 7:25 AM · gnupg
gniibe created T5038: UTF-8 handling in the command line.
Aug 28 2020, 7:22 AM · gnupg
gniibe added projects to T4710: Cannot use Secure PIN Entry for Reset Code: Documentation, Not A Bug.
Aug 28 2020, 6:48 AM · Not A Bug, Documentation, OpenPGP, scd, Bug Report
gniibe added a comment to T4817: dirmgr keys.openpgp.org:443 Address family not supported by protocol.

In T4977: dirmngr not working with linux kernel parameter ipv6.disable=1, EAFNOSUPPORT fix was applied in 2.2.22.
I think that original problem in this report is fixed.
Please test with 2.2.22.

Aug 28 2020, 6:46 AM · Bug Report
gniibe added a comment to T4838: add configure check for zlib to ntbtls.

Actually, configure already has the check.
If it's really needed to build without zlib, you can use this patch:

From 76920ac034490e4860ad6abe9891e3b1c0813363 Mon Sep 17 00:00:00 2001
From: NIIBE Yutaka <gniibe@fsij.org>
Date: Fri, 28 Aug 2020 11:02:13 +0900
Subject: [PATCH] Until compression is implemented, build with no ZLIB can be
 done.
Aug 28 2020, 4:08 AM · ntbtls, Bug Report
gniibe added a project to T5037: dn.cpp:181: suspicious loop: gpgme.
Aug 28 2020, 3:06 AM · gnupg, gpgme, Bug Report
gniibe closed T3207: FASTWIPE_T undefined as Resolved.
Aug 28 2020, 3:01 AM · Restricted Project, ntbtls, Bug Report
gniibe closed T4934: Returning automatic variable buffer from a function as Resolved.
Aug 28 2020, 2:58 AM · dirmngr, Restricted Project, Bug Report

Aug 27 2020

gniibe committed rG9f148360a2bf: scd: Add heuristics to identify cardtype. (authored by gniibe).
scd: Add heuristics to identify cardtype.
Aug 27 2020, 7:34 AM
gniibe committed rGd2f1a0a791db: scd: Add condition for VERIFY with 0x82. (authored by gniibe).
scd: Add condition for VERIFY with 0x82.
Aug 27 2020, 3:55 AM
gniibe committed rGaf189be481df: scd: Add condition for VERIFY with 0x82. (authored by gniibe).
scd: Add condition for VERIFY with 0x82.
Aug 27 2020, 3:45 AM

Aug 25 2020

gniibe committed rE13c28a300e02: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Aug 25 2020, 7:36 AM
gniibe added a comment to T5029: server socket/pipe handling in GnuPG.

It's pretty minor bug, it only matters for some strange scenario on Windows like:
(1) a user runs gpg --card-edit or gpg-card and keeps the user interaction for some reason (say, forgetting the terminal interaction), which keeps the pipe connection from gpg-agent to scdaemon
(2) While the pipe connection is used by the user interaction above, from another terminal, the user invokes gpg (say, gpg --decrypt) which uses socket connection from gpg-agent to scdaemon

Aug 25 2020, 3:13 AM · Windows, scd, gnupg (gpg23)
gniibe added a comment to T5029: server socket/pipe handling in GnuPG.

I mean these uses of close:

diff --git a/scd/scdaemon.c b/scd/scdaemon.c
index b7bbc0361..a6925eaf9 100644
--- a/scd/scdaemon.c
+++ b/scd/scdaemon.c
@@ -797,8 +797,8 @@ main (int argc, char **argv )
       /* We run handle_connection to wait for the shutdown signal and
          to run the ticker stuff.  */
       handle_connections (fd);
-      if (fd != -1)
-        close (fd);
+      if (fd != GNUPG_INVALID_FD)
+        assuan_sock_close (fd);
     }
   else if (!is_daemon)
     {
@@ -932,7 +932,7 @@ main (int argc, char **argv )
Aug 25 2020, 3:02 AM · Windows, scd, gnupg (gpg23)
gniibe renamed T5034: dev: Deprecate libassuan-config, libgcrypt-config, ksba-config, ntbtls-config, npth-config, and gpg-error-config from dev: Deprecate libassuan-config, libgcrypt-config, ksba-config, ntbtls-config, and npth-config to dev: Deprecate libassuan-config, libgcrypt-config, ksba-config, ntbtls-config, npth-config, ang gpg-error-config.
Aug 25 2020, 2:55 AM
gniibe created T5034: dev: Deprecate libassuan-config, libgcrypt-config, ksba-config, ntbtls-config, npth-config, and gpg-error-config.
Aug 25 2020, 2:54 AM
gniibe closed T5010: gpgrt-config: Bug for handling Requires as Resolved.
Aug 25 2020, 2:24 AM · gpgrt

Aug 24 2020

gniibe committed rPTH02ce6b2d27f9: Conditionally enable busy_wait_for. (authored by gniibe).
Conditionally enable busy_wait_for.
Aug 24 2020, 9:26 AM

Aug 21 2020

gniibe committed rC65a2cd139e21: ecc: Fix an error path. (authored by gniibe).
ecc: Fix an error path.
Aug 21 2020, 5:51 AM
gniibe committed rCfd51bc523d09: tests: Fix basic.c. (authored by gniibe).
tests: Fix basic.c.
Aug 21 2020, 5:51 AM
gniibe committed rE87a6b28c0f3b: argparse: Handle a corner case of wrong ARGC. (authored by gniibe).
argparse: Handle a corner case of wrong ARGC.
Aug 21 2020, 4:02 AM

Aug 19 2020

gniibe added a project to T5029: server socket/pipe handling in GnuPG: gnupg.
Aug 19 2020, 10:10 AM · Windows, scd, gnupg (gpg23)
gniibe created T5029: server socket/pipe handling in GnuPG.
Aug 19 2020, 10:10 AM · Windows, scd, gnupg (gpg23)
gniibe committed rG1d66b518ca83: gpg: Fix condition of string_to_aead_algo. (authored by gniibe).
gpg: Fix condition of string_to_aead_algo.
Aug 19 2020, 8:20 AM
gniibe committed rGf58d441bee7e: common: Fix iobuf.c. (authored by gniibe).
common: Fix iobuf.c.
Aug 19 2020, 8:20 AM
gniibe committed rGcc0d53905ce9: dns: Fix memory use-after-free. (authored by gniibe).
dns: Fix memory use-after-free.
Aug 19 2020, 8:20 AM
gniibe committed rGf3e424d4e727: Silence compiler warnings. (authored by gniibe).
Silence compiler warnings.
Aug 19 2020, 6:24 AM
gniibe committed rG4fa0a65676a2: scd: Fix possible uninitialized variables. (authored by gniibe).
scd: Fix possible uninitialized variables.
Aug 19 2020, 4:45 AM
gniibe closed T4915: Cannot compile on macOS Mojave (utf8.c) as Resolved.
Aug 19 2020, 3:42 AM · Restricted Project, gnupg (gpg23), Bug Report
gniibe closed T3843: Unable to generate RSA4096 keys on Yubikey 4 on OSX Sierra as Resolved.

No more information, can't proceed, thus, closed.

Aug 19 2020, 3:41 AM · Info Needed, MacOS, yubikey, scd, Bug Report
gniibe closed T4774: Cross compilation friendly libgpg-error as Resolved.

For GNU/Linux, it's done.

Aug 19 2020, 3:39 AM · Restricted Project, gpgrt

Aug 14 2020

gniibe added a comment to T5008: Fedora 32 and FAIL: gpg-error-config-test.sh.

Thanks for your patch. I understand your point, but your fix is not relevant (for supporting all platforms). You can use that way in your build script, but we can't take that approach; The correct fix is fixing libtool.

Aug 14 2020, 8:01 AM · gpgrt, Bug Report
gniibe added a comment to T5024: libtool problem for some platforms for 'make check' (program built with -no-install won't work without installation).

libtool works like this:

  • For program without -no-install, it uses wrapper script specifying the runtime path to the library by LD_LIBRARY_PATH (or equivalent), so that the program can work without installation
  • For program with no-install, it uses a feature (e.g., -rpath in ELF environment) to specify the runtime path to the library *in* the executable. The executable cannot be installed because the path of build directly is embedded in the executable.
Aug 14 2020, 7:43 AM · toolchain
gniibe merged T5009: OS X 10.12 and FAIL: random into T5024: libtool problem for some platforms for 'make check' (program built with -no-install won't work without installation).
Aug 14 2020, 7:08 AM · toolchain
gniibe merged task T5009: OS X 10.12 and FAIL: random into T5024: libtool problem for some platforms for 'make check' (program built with -no-install won't work without installation).
Aug 14 2020, 7:08 AM · libgcrypt, Bug Report
gniibe added a comment to T5008: Fedora 32 and FAIL: gpg-error-config-test.sh.

@JW, I'm feeling difficulty to talk to you.

Aug 14 2020, 6:59 AM · gpgrt, Bug Report
gniibe closed T5008: Fedora 32 and FAIL: gpg-error-config-test.sh as Wontfix.

For the original problem of no-support of slash at the end of path and duplicated slash, we won't fix.

Aug 14 2020, 5:52 AM · gpgrt, Bug Report
gniibe added a comment to T5008: Fedora 32 and FAIL: gpg-error-config-test.sh.

@JW, I'm afraid you are not able to read what I write here. This is not chat system at all. For chat system, please use XMPP on
gnupg-devel@chat.gnupg.org as written at https://gnupg.org/documentation/mailing-lists.html (if possible).

Aug 14 2020, 5:50 AM · gpgrt, Bug Report
gniibe created T5024: libtool problem for some platforms for 'make check' (program built with -no-install won't work without installation).
Aug 14 2020, 5:49 AM · toolchain
gniibe added a comment to T5008: Fedora 32 and FAIL: gpg-error-config-test.sh.

I wrote that "FAIL: gpg-error-config-test.sh" is because of your typo, and I asked to fix your typo and test again.

Aug 14 2020, 5:33 AM · gpgrt, Bug Report
gniibe added a comment to T5008: Fedora 32 and FAIL: gpg-error-config-test.sh.

@JW, you are now describing another problem, instead of the problem you reported.
I'm closing this one.

Aug 14 2020, 5:26 AM · gpgrt, Bug Report

Aug 10 2020

gniibe added a comment to T5008: Fedora 32 and FAIL: gpg-error-config-test.sh.

I meant:

Aug 10 2020, 9:28 AM · gpgrt, Bug Report
gniibe changed the status of T5010: gpgrt-config: Bug for handling Requires from Open to Testing.
Aug 10 2020, 6:31 AM · gpgrt
gniibe added a comment to T5008: Fedora 32 and FAIL: gpg-error-config-test.sh.

If there is no other problem (than the issues of additional slash and double slash), I'll close this bug report.

Aug 10 2020, 6:30 AM · gpgrt, Bug Report

Aug 7 2020

gniibe changed the status of T5000: trustdb,keybox: Adding support of v5key from Open to Testing.
Aug 7 2020, 6:11 AM · Restricted Project, gnupg (gpg23)
gniibe committed rG373c975859a5: gpg: Fix trustdb for v5key. (authored by gniibe).
gpg: Fix trustdb for v5key.
Aug 7 2020, 6:11 AM
gniibe committed rG20982bbd7539: gpg: Fix short key ID for v5key. (authored by gniibe).
gpg: Fix short key ID for v5key.
Aug 7 2020, 6:11 AM
gniibe added a comment to T5000: trustdb,keybox: Adding support of v5key.

Applied and pushed.

Aug 7 2020, 6:10 AM · Restricted Project, gnupg (gpg23)
gniibe added a comment to T5000: trustdb,keybox: Adding support of v5key.

No, it didn't work, but we need more change:

diff --git a/g10/tdbio.c b/g10/tdbio.c
index bfeede991..9f01667b4 100644
--- a/g10/tdbio.c
+++ b/g10/tdbio.c
@@ -1909,12 +1909,9 @@ tdbio_search_trust_byfpr (ctrl_t ctrl, const byte *fingerprint, TRUSTREC *rec)
 gpg_error_t
 tdbio_search_trust_bypk (ctrl_t ctrl, PKT_public_key *pk, TRUSTREC *rec)
 {
-  byte fingerprint[MAX_FINGERPRINT_LEN];
-  size_t fingerlen;
+  byte fingerprint[20];
Aug 7 2020, 4:53 AM · Restricted Project, gnupg (gpg23)

Aug 6 2020

cepxuo awarded D505: Ed448 support for GnuPG a Like token.
Aug 6 2020, 12:36 PM
gniibe added a comment to T5000: trustdb,keybox: Adding support of v5key.

I revise the change, using different approach, so that we can keep better existing implementation compatibility.

Aug 6 2020, 12:31 PM · Restricted Project, gnupg (gpg23)
gniibe committed rGdf531848a961: kbx: Support v5key for short kid and long kid. (authored by gniibe).
kbx: Support v5key for short kid and long kid.
Aug 6 2020, 12:26 PM
gniibe added a comment to T5009: OS X 10.12 and FAIL: random.

I'm afraid that the dynamic linker doesn't allow hardcoding library path in an executable on macOS.
(It is only supported on some limited platforms.)

Aug 6 2020, 9:41 AM · libgcrypt, Bug Report
gniibe added a comment to T5013: OS X 10.11 and error: use of undeclared identifier 'getenv'.

Thanks for your report.

Aug 6 2020, 5:59 AM · gpgme, Bug Report

Aug 5 2020

gniibe merged T3763: ECDH - encryption with obfuscated size of the symmetric key into T4908: ECDH with AES-128 decryption failure when fully padded.
Aug 5 2020, 7:23 AM · Restricted Project, gnupg (gpg22), Bug Report
gniibe merged task T3763: ECDH - encryption with obfuscated size of the symmetric key into T4908: ECDH with AES-128 decryption failure when fully padded.
Aug 5 2020, 7:22 AM · OpenPGP, gnupg (gpg23)
gniibe added a comment to T3763: ECDH - encryption with obfuscated size of the symmetric key.

Since it was handled in T4908, this task is merged into that.

Aug 5 2020, 7:22 AM · OpenPGP, gnupg (gpg23)
gniibe added a comment to T5008: Fedora 32 and FAIL: gpg-error-config-test.sh.

BTW, I learned that Fedora now uses pkgconfig (instead of pkg-config).
https://github.com/pkgconf/pkgconf

Aug 5 2020, 3:51 AM · gpgrt, Bug Report
gniibe added a comment to T4951: Support point compression in Libgcrypt.

For the reference of full mod_sqrt, see https://eli.thegreenplace.net/2009/03/07/computing-modular-square-roots-in-python/

Aug 5 2020, 3:33 AM · Feature Request, libgcrypt
gniibe claimed T5008: Fedora 32 and FAIL: gpg-error-config-test.sh.
Aug 5 2020, 3:21 AM · gpgrt, Bug Report
gniibe added a comment to T5008: Fedora 32 and FAIL: gpg-error-config-test.sh.

Try with --prefix=/home/jwalton/tmp/pk2delete (with no slash at the end) and --libdir=/home/jwalton/tmp/pk2delete/lib64 (with no double slash between pk2delete and lib64, but a single slash).

Aug 5 2020, 3:20 AM · gpgrt, Bug Report

Aug 4 2020

gniibe committed rTe9bf89a6f611: build: Update for newer autotools. (authored by gniibe).
build: Update for newer autotools.
Aug 4 2020, 4:31 AM

Aug 3 2020

gniibe committed rE4192cbc3c585: gpgrt-config: Fix handling 'Requires' field. (authored by gniibe).
gpgrt-config: Fix handling 'Requires' field.
Aug 3 2020, 9:13 AM
gniibe created T5010: gpgrt-config: Bug for handling Requires.
Aug 3 2020, 8:25 AM · gpgrt
gniibe committed rG8e04cf969e95: w32: Fix cast from intptr_t of _get_osfhandle. (authored by gniibe).
w32: Fix cast from intptr_t of _get_osfhandle.
Aug 3 2020, 6:43 AM

Jul 31 2020

gniibe committed rGda3a4c54a8ce: agent: Fix coercion for pinentry_pid handling. (authored by gniibe).
agent: Fix coercion for pinentry_pid handling.
Jul 31 2020, 10:24 AM
gniibe committed rG2a34a2afea5f: scd: Silence compiler warning. (authored by gniibe).
scd: Silence compiler warning.
Jul 31 2020, 10:05 AM
gniibe added a comment to T4246: GnuPG master does not allow decryption with bad usage flags (regression).

I realized that it fails with GPG_ERR_INV_ID (with gpg master) when it's on smartcard.
It can't be decrypted if it's on smartcard, that's true, but more relevant error would be good for this case.

Jul 31 2020, 8:13 AM · Restricted Project, Bug Report, gnupg (gpg23)

Jul 30 2020

gniibe changed the status of T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem from Open to Testing.

Pushed modified patch to master and 2.2.

Jul 30 2020, 8:27 AM · Restricted Project, gnupg, Windows
gniibe committed rG8d9ce32c30db: w32: More adding NETLIBS. (authored by gniibe).
w32: More adding NETLIBS.
Jul 30 2020, 8:17 AM
gniibe committed rGf95d923090e1: w32: Add link to $(NETLIB) for -lws2_32. (authored by gniibe).
w32: Add link to $(NETLIB) for -lws2_32.
Jul 30 2020, 8:17 AM
gniibe committed rGc1f81eb9fc25: w32: Add NETLIBS for sm/t-minip12. (authored by gniibe).
w32: Add NETLIBS for sm/t-minip12.
Jul 30 2020, 8:09 AM
gniibe committed rG5fa4427419c8: w32: More adding NETLIBS. (authored by gniibe).
w32: More adding NETLIBS.
Jul 30 2020, 8:09 AM
gniibe committed rGd69f5570ee5e: w32: Add link to $(NETLIB) for -lws2_32. (authored by gniibe).
w32: Add link to $(NETLIB) for -lws2_32.
Jul 30 2020, 4:41 AM

Jul 29 2020

gniibe added a comment to T4994: Windows: assuan_sock_init or WSAStartup by main/_init_common_subsystem.

Linking $(NETLIB) is required when the executable uses WSAStartup.

Jul 29 2020, 10:28 AM · Restricted Project, gnupg, Windows
gniibe triaged T5005: Unified single header file if it offers same API as Wishlist priority.
Jul 29 2020, 2:22 AM · libassuan, gpgrt
gniibe created T5005: Unified single header file if it offers same API.
Jul 29 2020, 2:22 AM · libassuan, gpgrt

Jul 28 2020

gniibe committed rGd17b838921b3: Revert patches applied wrongly. (authored by gniibe).
Revert patches applied wrongly.
Jul 28 2020, 10:04 AM

Jul 27 2020

gniibe committed rGfa4a2bd7a1ba: kbx: Fix short KID and long KID handling for FPR32. (authored by gniibe).
kbx: Fix short KID and long KID handling for FPR32.
Jul 27 2020, 2:37 PM
gniibe added a comment to T5001: Card specification enhancement.

@wener But it uses undefined data structure of "certificate" DO, IIUC. My point is defining DOs for OpenPGP, so that host side can construct OpenPGP object from those DOs.

Jul 27 2020, 3:48 AM · Feature Request, scd

Jul 21 2020

gniibe updated the task description for T5001: Card specification enhancement.
Jul 21 2020, 7:05 AM · Feature Request, scd
gniibe updated the task description for T5001: Card specification enhancement.
Jul 21 2020, 7:02 AM · Feature Request, scd
gniibe updated the task description for T5001: Card specification enhancement.
Jul 21 2020, 7:02 AM · Feature Request, scd
gniibe created T5001: Card specification enhancement.
Jul 21 2020, 6:45 AM · Feature Request, scd

Jul 20 2020

gniibe renamed T5000: trustdb,keybox: Adding support of v5key from trustdb: Adding support of v5key to trustdb,keybox: Adding support of v5key.
Jul 20 2020, 7:30 AM · Restricted Project, gnupg (gpg23)
gniibe added a comment to T5000: trustdb,keybox: Adding support of v5key.

Here is the patch for trustdb and keybox. Not introduced new record structure, but RECTYPE_TRUST_SHA2 saving only 20-byte.

Jul 20 2020, 7:21 AM · Restricted Project, gnupg (gpg23)
gniibe renamed T5000: trustdb,keybox: Adding support of v5key from trustdb: Adding support of v5 keys to trustdb: Adding support of v5key.
Jul 20 2020, 7:18 AM · Restricted Project, gnupg (gpg23)
gniibe updated the task description for T5000: trustdb,keybox: Adding support of v5key.
Jul 20 2020, 4:25 AM · Restricted Project, gnupg (gpg23)
gniibe added a comment to T5000: trustdb,keybox: Adding support of v5key.

Something like:

  • 1-byte: TYPE
  • 1-byte: Reserved
  • 32-byte: fingerprint
  • 1-byte; ownertrust / min_ownertrust
  • 1-byte: depth
  • 4-byte: validlist recnum
Jul 20 2020, 4:25 AM · Restricted Project, gnupg (gpg23)
gniibe created T5000: trustdb,keybox: Adding support of v5key.
Jul 20 2020, 4:22 AM · Restricted Project, gnupg (gpg23)