In T5834#154975, @ikloecker wrote:I assumed that changes to internal classes wouldn't break the ABI, but apparently the symbols were still exported. I'll keep this in mind for the next release.
FWIW, the internal class in question was completely rewritten. Since the damage has been done already, I'll close this report. We won't readd symbols to dead code. Sorry, for the inconvenience.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Feb 15 2022
Feb 15 2022
• ikloecker committed rKLEOPATRA5a884b791663: Improve initial focus in Advanced Settings dialog (authored by • ikloecker).
Improve initial focus in Advanced Settings dialog
• ikloecker committed rKLEOPATRAe3634a32f5ea: Ensure correct tab order of UI elements on Details page (authored by • ikloecker).
Ensure correct tab order of UI elements on Details page
• ikloecker committed rKLEOPATRA4e979d5b54cc: Disable all key strength combo boxes by default (authored by • ikloecker).
Disable all key strength combo boxes by default
• ikloecker committed rKLEOPATRA8c74a572cc02: Fix hiding of "Protect key with passphrase" check box for X.509 (authored by • ikloecker).
Fix hiding of "Protect key with passphrase" check box for X.509
• ikloecker committed rKLEOPATRAf7a94db9da7c: Fix tab order in Advanced Settings dialog (authored by • ikloecker).
Fix tab order in Advanced Settings dialog
• gniibe committed rCbeb5d6df5c57: fips: Use ELF header to find hmac file offset (authored by Clemens Lang via Gcrypt-devel <gcrypt-devel@lists.gnupg.org>).
fips: Use ELF header to find hmac file offset
fips: Fix previous commit.
Folks, you are opening a can of worms. The only secure why to sign a file is to have a detached signature. That is often non-practical and thus putting the signature/MAC at one certain position and exempt just this one position from hashing is the next best alternative. Any more complicated rules will inevitably introduce security flaws. If a binary is stripped, it is a different binary than a non-stripped one, if it is linked with another linker, it is a different one. And that binary will even be able to figure this out and change behavior. Please keep it simple.
Thanks! Maybe it would be simpler to use dl_iterate_phdr(3) for this. I wasn't aware of the function, but a colleague just implemented a proof-of-concept of what you're proposing in https://gitlab.com/dueno/integrity-notes.
build: Fix m4/gpg-error.m4.
I assumed that changes to internal classes wouldn't break the ABI, but apparently the symbols were still exported. I'll keep this in mind for the next release.
Laurent Montel <montel@kde.org> committed rLIBKLEO1771f9eee6ff: GIT_SILENT: use ecm_set_disabled_deprecation_versions (authored by Laurent Montel <montel@kde.org>).
GIT_SILENT: use ecm_set_disabled_deprecation_versions
Laurent Montel <montel@kde.org> committed rLIBKLEOe2cfa25a3e56: GIT_SILENT: time to increase version (authored by Laurent Montel <montel@kde.org>).
GIT_SILENT: time to increase version
Laurent Montel <montel@kde.org> committed rKLEOPATRA99e70c5b9141: GIT_SILENT: time to increase version (authored by Laurent Montel <montel@kde.org>).
GIT_SILENT: time to increase version
Laurent Montel <montel@kde.org> committed rKLEOPATRAd134b7e9b333: GIT_SILENT: use ecm_set_disabled_deprecation_versions (authored by Laurent Montel <montel@kde.org>).
GIT_SILENT: use ecm_set_disabled_deprecation_versions
I am going to apply https://gitlab.com/redhat-crypto/libgcrypt/libgcrypt-mirror/-/commit/64ccc25c4b4a2c8c4e13e7e37ff1c8c60a3d8401
And consider adding the code to limit hashing content (from start of the file to end of data section).
Guess why GnuPG has its own Tor aware resolver ;-) To debug this kind of stuff you need to debug dirmngr, by adding for example
Feb 14 2022
Feb 14 2022
thesamesam set External Link to https://bugs.kde.org/show_bug.cgi?id=449891 on T5834: C++ ABI breakage in gpgme-1.17.0?.
web: Add signature-key.pdf
• ikloecker moved T5832: Kleopatra: Make OpenPGP certificate generation (with default settings) accessible from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ikloecker committed rKLEOPATRA3296827c92c5: Use application display name in Really Quit? confirmation dialog (authored by • ikloecker).
Use application display name in Really Quit? confirmation dialog
• ikloecker committed rKLEOPATRAf495f7bdc064: Add user interface markers to other system tray menu entries (authored by • ikloecker).
Add user interface markers to other system tray menu entries
• ikloecker committed rKLEOPATRA1a326e18c555: Set application data before initializing KleopatraApplication (authored by • ikloecker).
Set application data before initializing KleopatraApplication
• ikloecker committed rKLEOPATRAcbe887480e12: Use display name of application for the system tray menu entries (authored by • ikloecker).
Use display name of application for the system tray menu entries
• ikloecker moved T5833: Kleopatra: Shows lower case "kleopatra" in system tray menu and Really Quit? confirmation dialog from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Found it: I did not initialize gpgme_op_interact's last parameter out with gpgme_data_new. The error is now gone.
• ikloecker triaged T5832: Kleopatra: Make OpenPGP certificate generation (with default settings) accessible as Normal priority.
• werner triaged T5825: [gpgme] [python] possible dangling reference to passphrase as High priority.
• werner lowered the priority of T5812: GpgOL: Draft encryption after modification no longer works from Unbreak Now! to High.
As well as GnuPG VS-Desktop. 3.1.21. We should also do a new gpg4win release.
• ikloecker changed the status of T5776: Kleopatra: Add possibility to copy fingerprints without spaces from Open to Testing.
Instead of extending the context menu I have simply added a button next to the fingerprint which always copies the fingerprint without whitespace to the clipboard. Should also be better for accessibility.
• ikloecker committed rKLEOPATRA20dce6e8a3f4: Remove LinksAccessibleByMouse flag from labels not showing links (authored by • ikloecker).
Remove LinksAccessibleByMouse flag from labels not showing links
• ikloecker committed rKLEOPATRAa6500b0b4065: Make button for changing expiration look like copy to clipboard button (authored by • ikloecker).
Make button for changing expiration look like copy to clipboard button
• ikloecker committed rKLEOPATRAd3035a7ccde4: Add button to copy the fingerprint to the clipboard (authored by • ikloecker).
Add button to copy the fingerprint to the clipboard
• gniibe added a comment to T5814: gpg-agent can't find existing 'pinentry', searches 'Pinentry' (uppercase'P') instead.
Good to hear the cause.
I have added tooltips to the + ECDH and the + Elgamal checkboxes. Hope this helps.
• ikloecker committed rKLEOPATRA68e1519e55e3: Add tooltip to subkeys that are required for encryption (authored by • ikloecker).
Add tooltip to subkeys that are required for encryption
If the user unselects + ECDH, then the checkmark before Encryption under Certificate Usage is removed. I'm not sure whether adding a tooltip would help if they don't notice this.
• ikloecker committed rKLEOPATRA120bfb4dd76b: Add missing changes to fix last commit (authored by • ikloecker).
Add missing changes to fix last commit
• ikloecker changed the status of T5775: Kleopatra: Add action to restart background processes from Open to Testing.
Remove unnecessary include
• ikloecker committed rKLEOPATRA60a035d48e22: Request start of GnuPG agent if connecting to it fails (authored by • ikloecker).
Request start of GnuPG agent if connecting to it fails
• ikloecker committed rKLEOPATRA521ee4cbf670: Require current version of libkleo (authored by • ikloecker).
Require current version of libkleo
Since you are using C++, I suggest that you have a look at GpgSetOwnerTrustEditInteractor in the C++ bindings of gpgme. Have a look at QGpgMEChangeOwnerTrustJob in the Qt bindings of gpgme to see how it's used even if you do not want to use Qt.
• aheinecke changed the status of T5829: "read error: ec=8", missing .dll's and gnupg folder after mkportable.exe from Open to Testing.
Hi,
(Exec format error), read 0 bytes
• aheinecke committed rW36f727ff13cc: mkportable: Update libintl dll version (authored by • aheinecke).
mkportable: Update libintl dll version
• gniibe committed rC6994d874af86: hmac: Fix memory leak (authored by Clemens Lang via Gcrypt-devel <gcrypt-devel@lists.gnupg.org>).
hmac: Fix memory leak
• gniibe committed rC7fc5d33e7416: fips: Fix memory leaks in FIPS mode (authored by Clemens Lang via Gcrypt-devel <gcrypt-devel@lists.gnupg.org>).
fips: Fix memory leaks in FIPS mode
Register DCO for Clemens Lang.
Feb 13 2022
Feb 13 2022
Commented out the problematic code and added notes.
Feb 12 2022
Feb 12 2022
NfuRipHA updated the task description for T5829: "read error: ec=8", missing .dll's and gnupg folder after mkportable.exe.
NfuRipHA updated the task description for T5829: "read error: ec=8", missing .dll's and gnupg folder after mkportable.exe.
Feb 11 2022
Feb 11 2022
• werner committed rW2a24be4b3349: msi: Don't let die die with a stack trace. (authored by • werner).
msi: Don't let die die with a stack trace.
Fix source upload name.
jukivili added a comment to T5828: Improvements for gnupg data operation performance (enc/dec/sign/verify/enarmor/dearmor/etc).
0001-g10-cipher-aead-add-fast-path-for-avoid-memcpy-when-.patch4 KBDownload
Group action data by menu
• ikloecker committed rKLEOPATRA6a1b1e1cc9b6: Clean up left-over references to configure_backend action (authored by • ikloecker).
Clean up left-over references to configure_backend action
• ikloecker committed rKLEOPATRA8cda5a03a97c: Add action for restarting the GnuPG daemons (authored by • ikloecker).
Add action for restarting the GnuPG daemons
Bump library version
• ikloecker committed rLIBKLEOb8517cb0a019: Throttle launching of the GnuPG agent (authored by • ikloecker).
Throttle launching of the GnuPG agent
• ikloecker committed rLIBKLEOe0864b3a88bf: Add helper for shutting down the GnuPG daemons (authored by • ikloecker).
Add helper for shutting down the GnuPG daemons
• ikloecker committed rLIBKLEO216cb848f962: Deduplicate code for running gpgconf (authored by • ikloecker).
Deduplicate code for running gpgconf
Post release version bump
Update NEWS for todays release
• aheinecke committed rWe9361b49d061: Remove NEWS entry about larger gpgtar fnames (authored by • aheinecke).
Remove NEWS entry about larger gpgtar fnames
msi: Add guids for dvipdf icon
• ikloecker committed rLIBKLEO2a87d1d356da: Unify retrying to connect to the GnuPG agent (authored by • ikloecker).
Unify retrying to connect to the GnuPG agent
• ikloecker committed rLIBKLEO04a4478605b9: Add helper for launching the GnuPG agent (authored by • ikloecker).
Add helper for launching the GnuPG agent
• ikloecker committed rLIBKLEO8df2fe9a13b9: Add helper to check if gpg-agent is running and accepts connections (authored by • ikloecker).
Add helper to check if gpg-agent is running and accepts connections
• ikloecker committed rLIBKLEO74375c89d154: GIT_SILENT: Remove trailing '/' from include path (authored by • ikloecker).
GIT_SILENT: Remove trailing '/' from include path
• ikloecker committed rKLEOPATRA2f504289f748: Reset the Assuan context if we detect a broken pipe (authored by • ikloecker).
Reset the Assuan context if we detect a broken pipe
• ikloecker committed rKLEOPATRAe7d903e3bd7e: Unify retrying to connect to the GnuPG agent (authored by • ikloecker).
Unify retrying to connect to the GnuPG agent
• ikloecker committed rKLEOPATRA183e3f72ec26: Wait a bit before restarting the connection (authored by • ikloecker).
Wait a bit before restarting the connection
• aheinecke committed rW2e060b14b622: msi: Fix multi targets with beta versioning change (authored by • aheinecke).
msi: Fix multi targets with beta versioning change
Feb 10 2022
Feb 10 2022
JaminCollins added a comment to T2818: expected behavior unclear when using gpg from ssh on a machine with a running X11 session.
While searching for a solution to this, I found multiple reports of people that appear to be impacted by this 5 year old issue.
jukivili committed rGab177eed514f: g10/mainproc: avoid extra hash contexts when decrypting MDC input (authored by jukivili).
g10/mainproc: avoid extra hash contexts when decrypting MDC input
Did you make another request for locating keys via WKD after adding the debug flags? I'm asking because when I do this I get the following log:
2022-02-10 17:49:59 dirmngr[6780] listening on socket '/run/user/1000/gnupg/d.f3hdqcrmjwf98p87yqjmuctx/S.dirmngr' 2022-02-10 17:49:59 dirmngr[6781.0] permanently loaded certificates: 130 2022-02-10 17:49:59 dirmngr[6781.0] runtime cached certificates: 0 2022-02-10 17:49:59 dirmngr[6781.0] trusted certificates: 130 (130,0,0,0) 2022-02-10 17:49:59 dirmngr[6781.0] failed to open cache dir file '/tmp/tmp.8P2EakNghu/crls.d/DIR.txt': No such file or directory 2022-02-10 17:49:59 dirmngr[6781.0] creating directory '/tmp/tmp.8P2EakNghu/crls.d' 2022-02-10 17:49:59 dirmngr[6781.0] new cache dir file '/tmp/tmp.8P2EakNghu/crls.d/DIR.txt' created 2022-02-10 17:49:59 dirmngr[6781.6] handler for fd 6 started 2022-02-10 17:49:59 dirmngr[6781.6] DBG: chan_6 -> # Home: /tmp/tmp.8P2EakNghu 2022-02-10 17:49:59 dirmngr[6781.6] DBG: chan_6 -> # Config: /tmp/tmp.8P2EakNghu/dirmngr.conf 2022-02-10 17:49:59 dirmngr[6781.6] DBG: chan_6 -> OK Dirmngr 2.3.5-beta17 at your service 2022-02-10 17:49:59 dirmngr[6781.6] connection from process 6779 (1000:100) 2022-02-10 17:49:59 dirmngr[6781.6] DBG: chan_6 <- GETINFO version 2022-02-10 17:49:59 dirmngr[6781.6] DBG: chan_6 -> D 2.3.5-beta17 2022-02-10 17:49:59 dirmngr[6781.6] DBG: chan_6 -> OK 2022-02-10 17:49:59 dirmngr[6781.6] DBG: chan_6 <- WKD_GET -- werner.koch@gnupg.com 2022-02-10 17:49:59 dirmngr[6781.6] DBG: dns: libdns initialized 2022-02-10 17:49:59 dirmngr[6781.6] DBG: dns: resolve_dns_name(openpgpkey.gnupg.com): No name 2022-02-10 17:49:59 dirmngr[6781.6] DBG: dns: getsrv(_openpgpkey._tcp.gnupg.com) -> 0 records 2022-02-10 17:49:59 dirmngr[6781.6] DBG: chan_6 -> S SOURCE https://gnupg.com 2022-02-10 17:49:59 dirmngr[6781.6] number of system provided CAs: 390 2022-02-10 17:49:59 dirmngr[6781.6] DBG: Using TLS library: GNUTLS 3.7.3 2022-02-10 17:49:59 dirmngr[6781.6] DBG: http.c:connect_server: trying name='gnupg.com' port=443 2022-02-10 17:49:59 dirmngr[6781.6] DBG: dns: resolve_dns_name(gnupg.com): Success 2022-02-10 17:49:59 dirmngr[6781.6] DBG: http.c:1917:socket_new: object 0x00007f524c290e20 for fd 7 created 2022-02-10 17:50:00 dirmngr[6781.6] DBG: http.c:request: 2022-02-10 17:50:00 dirmngr[6781.6] DBG: >> GET /.well-known/openpgpkey/hu/waoubdep9643akkesx4xm3ynstfffiok?l=werner.koch HTTP/1.0\r\n 2022-02-10 17:50:00 dirmngr[6781.6] DBG: >> Host: gnupg.com\r\n 2022-02-10 17:50:00 dirmngr[6781.6] DBG: http.c:request-header: 2022-02-10 17:50:00 dirmngr[6781.6] DBG: >> \r\n 2022-02-10 17:50:00 dirmngr[6781.6] DBG: http.c:response: 2022-02-10 17:50:00 dirmngr[6781.6] DBG: >> HTTP/1.0 200 OK\r\n 2022-02-10 17:50:00 dirmngr[6781.6] http.c:RESP: 'Date: Thu, 10 Feb 2022 16:49:59 GMT' 2022-02-10 17:50:00 dirmngr[6781.6] http.c:RESP: 'Server: Boa/0.94.14rc21' 2022-02-10 17:50:00 dirmngr[6781.6] http.c:RESP: 'Accept-Ranges: bytes' 2022-02-10 17:50:00 dirmngr[6781.6] http.c:RESP: 'Connection: close' 2022-02-10 17:50:00 dirmngr[6781.6] http.c:RESP: 'Content-Length: 957' 2022-02-10 17:50:00 dirmngr[6781.6] http.c:RESP: 'Last-Modified: Mon, 28 Jun 2021 17:47:11 GMT' 2022-02-10 17:50:00 dirmngr[6781.6] http.c:RESP: 'Content-Type: text/plain' 2022-02-10 17:50:00 dirmngr[6781.6] http.c:RESP: '' 2022-02-10 17:50:00 dirmngr[6781.6] DBG: (957 bytes sent via D lines not shown) 2022-02-10 17:50:00 dirmngr[6781.6] DBG: chan_6 -> OK 2022-02-10 17:50:00 dirmngr[6781.6] DBG: chan_6 <- BYE 2022-02-10 17:50:00 dirmngr[6781.6] DBG: chan_6 -> OK closing connection 2022-02-10 17:50:00 dirmngr[6781.6] handler for fd 6 terminated
2022-02-10 17:07:35 [12256] dauerhaft geladene Zertifikate: 74 2022-02-10 17:07:35 [12256] zwischengespeicherte Zertifikate: 0 2022-02-10 17:07:35 [12256] vertrauenswürdige Zertifikate: 74 (74,0,0,0) 2022-02-10 17:07:35 [12256] DBG: chan_0x0000026c -> # Home: C:\Users\User\AppData\Roaming\gnupg 2022-02-10 17:07:35 [12256] DBG: chan_0x0000026c -> # Config: .\dirmngr.conf 2022-02-10 17:07:35 [12256] DBG: chan_0x0000026c -> OK Dirmngr 2.3.4 at your service
From the external test and review of the test results I list the priority below. Some of the issues need to be reproduced for full understanding. We should open subtasks where appropiate. To have a better orientation I think we should keep the general prioritization in mind and work use case by use case.
• aheinecke committed rP7d5c123f802a: qt: Embed icons to avoid theme searches (authored by • aheinecke).
qt: Embed icons to avoid theme searches