Page MenuHome GnuPG
Feed All Stories

Jun 1 2022

gniibe claimed T5973: libgcrypt: Minor test issues reported by coverity.
Jun 1 2022, 5:09 AM · backport, patch, libgcrypt, Bug Report
gniibe claimed T5976: libgcrypt build failure on HPPA 1.1 (./.libs/libgcrypt.so: undefined reference to `__udiv_qrnnd').
Jun 1 2022, 5:08 AM · backport, hppa, libgcrypt, Gentoo, Bug Report
gniibe claimed T5980: compilation error libgcrypt 1.10.1.
Jun 1 2022, 5:08 AM · backport, ppc, AIX, libgcrypt, Bug Report
gniibe claimed T5977: Smartcard PIN stays in clear in memory.
Jun 1 2022, 5:05 AM · backport, libassuan, pinentry, scd, gnupg (gpg22), Bug Report
gniibe committed rP523a4f2d5d1c: Remove old code which makes sure NUL-termination of strings. (authored by gniibe).
Remove old code which makes sure NUL-termination of strings.
Jun 1 2022, 4:54 AM
gniibe committed rP0d3be7b81eb1: Remove USE_CAPABILITIES. (authored by gniibe).
Remove USE_CAPABILITIES.
Jun 1 2022, 4:54 AM
gniibe committed rP88cad4621be3: secmem: Remove use of cap_set_proc. (authored by gniibe).
secmem: Remove use of cap_set_proc.
Jun 1 2022, 4:54 AM
gniibe committed rP96771ae57e86: pinentry: Remove dead code (authored by Jakuje).
pinentry: Remove dead code
Jun 1 2022, 4:54 AM
gniibe committed rPcd753c8560cd: pinentry: Terminate the buffer in the right place (authored by Jakuje).
pinentry: Terminate the buffer in the right place
Jun 1 2022, 4:54 AM
gniibe committed rPc2e7cc560bdb: secmem: Do not pass negative values to strerr (authored by Jakuje).
secmem: Do not pass negative values to strerr
Jun 1 2022, 4:54 AM
gniibe triaged T6007: coverity issues in pinentry as Normal priority.
Jun 1 2022, 4:35 AM · pinentry, Bug Report
gniibe added a project to T6007: coverity issues in pinentry: Restricted Project.
Jun 1 2022, 4:35 AM · pinentry, Bug Report
gniibe committed rCd7c900a97b62: secmem: Clean up ERRNO handling. (authored by gniibe).
secmem: Clean up ERRNO handling.
Jun 1 2022, 4:14 AM
gniibe committed rCfd9aa21983a1: secmem: Remove RISC OS support. (authored by gniibe).
secmem: Remove RISC OS support.
Jun 1 2022, 4:14 AM
gniibe committed rC43f51d0ec6b5: secmem: Remove getting cap_ipc_lock by capabilities support. (authored by gniibe).
secmem: Remove getting cap_ipc_lock by capabilities support.
Jun 1 2022, 4:14 AM
gniibe claimed T6007: coverity issues in pinentry.

I take this ticket. The way to go is removing all such cases.

Jun 1 2022, 2:06 AM · pinentry, Bug Report

May 31 2022

ikloecker committed rKLEOPATRA1aac58bc89f7: Avoid deprecation warning (authored by ikloecker).
Avoid deprecation warning
May 31 2022, 10:15 PM
ikloecker committed rKLEOPATRAdc76bc77418e: Require C++20 (authored by ikloecker).
Require C++20
May 31 2022, 10:15 PM
ikloecker committed rKLEOPATRA0d07a36de5ea: Avoid deprecation warning (authored by ikloecker).
Avoid deprecation warning
May 31 2022, 10:15 PM
ikloecker committed rKLEOPATRA884d82be26f8: Make lambdas used in std::accumulate compatible with C++20 (authored by ikloecker).
Make lambdas used in std::accumulate compatible with C++20
May 31 2022, 10:15 PM
ikloecker committed rKLEOPATRA0481d53638ab: Fix raw string literal and add missing include (authored by ikloecker).
Fix raw string literal and add missing include
May 31 2022, 10:05 PM
ikloecker committed rKLEOPATRA3b2cd0ae8857: Replace some static QMaps with std::array (authored by Ahmad Samir <a.samirh78@gmail.com>).
Replace some static QMaps with std::array
May 31 2022, 7:30 PM
Ahmad Samir <a.samirh78@gmail.com> committed rKLEOPATRAe2e5d2e39c5a: Replace some static QMaps with std::array (authored by Ahmad Samir <a.samirh78@gmail.com>).
Replace some static QMaps with std::array
May 31 2022, 4:40 PM
Ahmad Samir <a.samirh78@gmail.com> committed rKLEOPATRA3aedb7aeea40: Replace some static QMaps with std::array (authored by Ahmad Samir <a.samirh78@gmail.com>).
Replace some static QMaps with std::array
May 31 2022, 4:39 PM
gniibe added a comment to T6007: coverity issues in pinentry.

Reference to a CVE for old MinGW-W64: https://nvd.nist.gov/vuln/detail/CVE-2018-1000101
https://sourceforge.net/p/mingw-w64/bugs/709/

May 31 2022, 3:40 PM · pinentry, Bug Report
ikloecker committed rKLEOPATRA2399cb2a3386: Add autotest for KeyParameters (authored by ikloecker).
Add autotest for KeyParameters
May 31 2022, 1:15 PM
ikloecker committed rKLEOPATRAdf4ce1717a5f: Add class wrapping the key usage flags (authored by ikloecker).
Add class wrapping the key usage flags
May 31 2022, 1:15 PM
ikloecker committed rKLEOPATRA01e7fda1a944: Use ecm_add_test to set up autotests (authored by ikloecker).
Use ecm_add_test to set up autotests
May 31 2022, 1:15 PM
ikloecker committed rKLEOPATRAadf23c42850a: Store the rest of the key parameters with their native types (authored by ikloecker).
Store the rest of the key parameters with their native types
May 31 2022, 1:15 PM
ikloecker committed rKLEOPATRA3de0362420eb: Set and store the usage flags of key and subkey using new KeyUsage (authored by ikloecker).
Set and store the usage flags of key and subkey using new KeyUsage
May 31 2022, 1:15 PM
ikloecker committed rKLEOPATRA8a35d159cc20: Remove unused page ID (authored by ikloecker).
Remove unused page ID
May 31 2022, 1:15 PM
ikloecker committed rKLEOPATRAbe31bd7a6bdd: Store type of key and subkey with native type (authored by ikloecker).
Store type of key and subkey with native type
May 31 2022, 1:15 PM
ikloecker committed rKLEOPATRA60f5ac4ff7e1: Make KeyParameters copyable and movable (authored by ikloecker).
Make KeyParameters copyable and movable
May 31 2022, 1:15 PM
werner added a comment to T6007: coverity issues in pinentry.

At least old Windows versions did not add a nul in the truncation case. Thus I used to make that sure. I don't think we need it anymore.

May 31 2022, 11:26 AM · pinentry, Bug Report
ikloecker committed rLIBKLEOd8148b7104c5: Bump library version (authored by ikloecker).
Bump library version
May 31 2022, 11:19 AM
ikloecker committed rLIBKLEO2baa8512a10e: Remove usage of std::unary_function and std::binary_function (authored by ikloecker).
Remove usage of std::unary_function and std::binary_function
May 31 2022, 11:19 AM
ikloecker committed rLIBKLEOa91f796f7312: Move enum KeyUsage to KeyCache (authored by ikloecker).
Move enum KeyUsage to KeyCache
May 31 2022, 11:19 AM
gniibe moved T5975: Allow signature verification using specific RSA keys <2k in FIPS mode from Next to Ready for release on the FIPS board.
May 31 2022, 11:16 AM · backport, patch, libgcrypt, FIPS, Feature Request
gniibe added a comment to T5973: libgcrypt: Minor test issues reported by coverity.

Also applied to 1.10.

May 31 2022, 8:27 AM · backport, patch, libgcrypt, Bug Report
gniibe committed rCa15cb31bf733: tests: Fix copy paste error (authored by Jakuje).
tests: Fix copy paste error
May 31 2022, 8:25 AM
gniibe committed rCef2e1523c33c: Fix memory leaks in tests (authored by Jakuje).
Fix memory leaks in tests
May 31 2022, 8:25 AM
gniibe added a project to T5973: libgcrypt: Minor test issues reported by coverity: Restricted Project.
May 31 2022, 8:25 AM · backport, patch, libgcrypt, Bug Report
gniibe added a comment to T5973: libgcrypt: Minor test issues reported by coverity.

Applied and pushed.

May 31 2022, 8:24 AM · backport, patch, libgcrypt, Bug Report
gniibe added a comment to T5964: gnupg should use the KDFs implemented in libgcrypt.

I learned that it's now called "OneStep KDF" in SP 800-56Cr2.
It's "SSKDF" in OpenSSL (Single Step KDF, perhaps).

May 31 2022, 8:17 AM · gnupg26, FIPS, libgcrypt, Feature Request

May 30 2022

Jakuje added a comment to T6007: coverity issues in pinentry.

AFAIK the above case has a lot of wiggle room to fit one PID and the surrounded string into 400 bytes and even if it would need to truncate, it would write terminating character, at least on Linux:

May 30 2022, 9:20 PM · pinentry, Bug Report
ikloecker added a comment to T6007: coverity issues in pinentry.
--- a/pinentry/pinentry.c
+++ b/pinentry/pinentry.c
@@ -351,7 +351,6 @@ get_pid_name_for_uid (unsigned long pid, int uid)
   char *uidstr;
May 30 2022, 9:11 PM · pinentry, Bug Report
Jakuje created T6007: coverity issues in pinentry.
May 30 2022, 3:28 PM · pinentry, Bug Report
ikloecker reassigned T5962: Kleopatra: Crash when quitting Application on Windows from ikloecker to aheinecke.

@aheinecke I think this task can be closed.

May 30 2022, 9:25 AM · Restricted Project, kleopatra

May 29 2022

ikloecker committed rKLEOPATRA00bfc24c3013: Required new version of libkleo (authored by ikloecker).
Required new version of libkleo
May 29 2022, 6:14 PM
ikloecker committed rLIBKLEO323acdc47023: Namespace the functions (authored by ikloecker).
Namespace the functions
May 29 2022, 6:14 PM
ikloecker committed rLIBKLEOdd6b3057f709: Bump library version (authored by ikloecker).
Bump library version
May 29 2022, 6:14 PM
ikloecker committed rLIBKLEO350a33446fb7: Add function for mapping OID to attribute name (authored by ikloecker).
Add function for mapping OID to attribute name
May 29 2022, 6:14 PM
ikloecker committed rLIBKLEO91719c2b0e5b: Make oidmap a std::vector (authored by ikloecker).
Make oidmap a std::vector
May 29 2022, 6:14 PM
ikloecker committed rKLEOPATRAb51b3b502cfa: Fix wrong connections (authored by ikloecker).
Fix wrong connections
May 29 2022, 6:09 PM
ikloecker committed rKLEOPATRA23e01d2c7035: Optimize containers' usage (authored by Ahmad Samir <a.samirh78@gmail.com>).
Optimize containers' usage
May 29 2022, 4:14 PM
ikloecker committed rKLEOPATRA9461babcfeca: Apply 1 suggestion(s) to 1 file(s) (authored by ikloecker).
Apply 1 suggestion(s) to 1 file(s)
May 29 2022, 4:10 PM
ikloecker committed rKLEOPATRA18dd62047d77: Use a vector instead of QSet (authored by Ahmad Samir <a.samirh78@gmail.com>).
Use a vector instead of QSet
May 29 2022, 4:09 PM
werner committed rG07eaf006c276: scd:nks: Support the Telesec ESIGN application. (authored by werner).
scd:nks: Support the Telesec ESIGN application.
May 29 2022, 3:57 PM
werner added a project to T4938: Support Signature Card V2.0 (NKS15): eIDAS.
May 29 2022, 3:55 PM · eIDAS, scd, Feature Request, S/MIME
werner added a project to T5219: scd: Generating CSR for SigG NetKey card key fails: eIDAS.
May 29 2022, 3:54 PM · gnupg24, eIDAS, gnupg (gpg23), scd
werner created eIDAS.
May 29 2022, 3:53 PM
werner raised the priority of T5219: scd: Generating CSR for SigG NetKey card key fails from Low to Normal.

Related problem exists with the modern ESIGN application. I think I fixed that but the whole Telesec eIDAS QES case needs more work.

May 29 2022, 3:51 PM · gnupg24, eIDAS, gnupg (gpg23), scd
Ahmad Samir <a.samirh78@gmail.com> committed rKLEOPATRA4cbe9e64ecca: Use a vector instead of QSet (authored by Ahmad Samir <a.samirh78@gmail.com>).
Use a vector instead of QSet
May 29 2022, 11:18 AM

May 28 2022

Ahmad Samir <a.samirh78@gmail.com> committed rKLEOPATRA034153b5e65b: src/uiserver/*command: port to PMF signal/slot syntax (authored by Ahmad Samir <a.samirh78@gmail.com>).
src/uiserver/*command: port to PMF signal/slot syntax
May 28 2022, 9:28 PM
jukivili added a comment to T6006: Optimize Chacha20 and Poly1305 for PPC P10 LE.

Problem is that new assembly is using VSX registers vs14-vs31 which overlap with floating-point registers f14-f31. f14-f31 are ABI callee saved, so those need to be stored and restored.

May 28 2022, 9:04 PM · patch, ppc, Feature Request, libgcrypt
jukivili added a comment to T6006: Optimize Chacha20 and Poly1305 for PPC P10 LE.

Tested patch with small change so that HWF_PPC_ARCH_3_00 is used instead of HWF_PPC_ARCH_3_10. Building bench-slope with "-O3 -flto" makes bug in new implementation visible. Without new implementations bench-slope is ok (testing with QEMU):

$ tests/bench-slope --disable-hwf ppc-arch_3_00 cipher chacha20
Cipher:
 CHACHA20       |  nanosecs/byte   mebibytes/sec   cycles/byte
     STREAM enc |      2.35 ns/B     405.0 MiB/s         - c/B
     STREAM dec |      2.32 ns/B     410.7 MiB/s         - c/B
   POLY1305 enc |      2.46 ns/B     388.0 MiB/s         - c/B
   POLY1305 dec |      2.34 ns/B     408.1 MiB/s         - c/B
  POLY1305 auth |     0.238 ns/B      4003 MiB/s         - c/B
May 28 2022, 6:49 PM · patch, ppc, Feature Request, libgcrypt
werner committed rG7aabd94b8103: gpg: Setup the 'usage' filter property for export. (authored by werner).
gpg: Setup the 'usage' filter property for export.
May 28 2022, 5:40 PM
Ahmad Samir <a.samirh78@gmail.com> committed rKLEOPATRA61040bebea5e: Optimize containers' usage (authored by Ahmad Samir <a.samirh78@gmail.com>).
Optimize containers' usage
May 28 2022, 5:34 PM
Ahmad Samir <a.samirh78@gmail.com> committed rKLEOPATRA127c28362f61: Replace some staic QMaps with std::array (authored by Ahmad Samir <a.samirh78@gmail.com>).
Replace some staic QMaps with std::array
May 28 2022, 5:28 PM
Ahmad Samir <a.samirh78@gmail.com> committed rKLEOPATRAdd7f96978c0b: src/uiserver/*command: port to PMF signal/slot syntax (authored by Ahmad Samir <a.samirh78@gmail.com>).
src/uiserver/*command: port to PMF signal/slot syntax
May 28 2022, 1:22 PM
l10n daemon script <scripty@kde.org> committed rLIBKLEOb401d87b88c1: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
May 28 2022, 5:57 AM
l10n daemon script <scripty@kde.org> committed rKLEOPATRA535dda2df4e1: GIT_SILENT made messages (after extraction) (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT made messages (after extraction)
May 28 2022, 5:08 AM
l10n daemon script <scripty@kde.org> committed rLIBKLEObac2ee523c6b: SVN_SILENT made messages (.desktop file) - always resolve ours (authored by l10n daemon script <scripty@kde.org>).
SVN_SILENT made messages (.desktop file) - always resolve ours
May 28 2022, 4:20 AM
l10n daemon script <scripty@kde.org> committed rKLEOPATRAe40e8f84dcc1: GIT_SILENT made messages (after extraction) (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT made messages (after extraction)
May 28 2022, 3:00 AM

May 27 2022

sergi added a watcher for scd: sergi.
May 27 2022, 10:10 PM
sergi added a watcher for Python: sergi.
May 27 2022, 10:10 PM
sergi added a watcher for pinentry: sergi.
May 27 2022, 10:09 PM
sergi added a watcher for OpenPGP: sergi.
May 27 2022, 10:09 PM
sergi added a watcher for npth: sergi.
May 27 2022, 10:09 PM
sergi added a watcher for libksba: sergi.
May 27 2022, 10:09 PM
sergi added a watcher for libassuan: sergi.
May 27 2022, 10:09 PM
sergi added a watcher for libgcrypt: sergi.
May 27 2022, 10:09 PM
sergi added a watcher for Keyserver: sergi.
May 27 2022, 10:08 PM
sergi added a watcher for gpgagent: sergi.
May 27 2022, 10:08 PM
sergi added a watcher for gnupg: sergi.
May 27 2022, 10:08 PM
sergi added a watcher for FIPS: sergi.
May 27 2022, 10:08 PM
sergi added a watcher for dev.gnupg.org: sergi.
May 27 2022, 10:07 PM
srgblnchtrn removed a watcher for gnupg: srgblnchtrn.
May 27 2022, 10:06 PM
srgblnchtrn removed a watcher for gpgagent: srgblnchtrn.
May 27 2022, 10:06 PM
srgblnchtrn removed a watcher for libgcrypt: srgblnchtrn.
May 27 2022, 10:05 PM
srgblnchtrn removed a watcher for OpenPGP: srgblnchtrn.
May 27 2022, 10:05 PM
srgblnchtrn removed a watcher for Python: srgblnchtrn.
May 27 2022, 10:05 PM
srgblnchtrn removed a watcher for ssh: srgblnchtrn.
May 27 2022, 10:05 PM
sergi added a watcher for Debian: sergi.
May 27 2022, 10:04 PM
srgblnchtrn removed a watcher for Debian: srgblnchtrn.
May 27 2022, 10:04 PM
sergi added a watcher for Contributor: sergi.
May 27 2022, 9:57 PM
sergi added a watcher for CI: sergi.
May 27 2022, 9:57 PM
ikloecker closed D552: gpg: Support specifiying user ID to revoke as UID hash for --quick-revoke-uid.

The changes have been applied with Werner's suggested improvement with revision rG35b17550706c: gpg: Look up user ID to revoke by UID hash

May 27 2022, 9:23 PM · gnupg (gpg23)
jukivili added a comment to T6006: Optimize Chacha20 and Poly1305 for PPC P10 LE.

-O2 problem with bench-slope seems strange. Does problem appear after this patch is applied?

May 27 2022, 7:15 PM · patch, ppc, Feature Request, libgcrypt
ikloecker committed rKLEOPATRA25e4425bba43: Use simple struct with two Keys instead of a QMap (authored by ikloecker).
Use simple struct with two Keys instead of a QMap
May 27 2022, 4:37 PM