Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRA79d0e641896d: Port signal/slot that use action_data struct to PMF/Functor syntax (authored by Ahmad Samir <a.samirh78@gmail.com>).
Port signal/slot that use action_data struct to PMF/Functor syntax
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRAbcb1c92ee223: action_data: use enums instead of bool members to improve reability (authored by Ahmad Samir <a.samirh78@gmail.com>).
action_data: use enums instead of bool members to improve reability
SMimeValidationConfigurationWidget: clean up constructor initializer list
SMimeValidationConfigurationWidget: move connect() calls to Private's…
SMimeValidationConfigurationWidget: port to PMF singal/slot syntax
SMimeValidationConfigurationWidget: clean up constructor initializer list
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRA601be1e8479f: SMimeValidationConfigurationWidget: move connect() calls to Private's… (authored by Ahmad Samir <a.samirh78@gmail.com>).
SMimeValidationConfigurationWidget: move connect() calls to Private's…
action_data: use enums instead of bool members to improve reability
Port signal/slot that use action_data struct to PMF/Functor syntax
Fix name clash between wizard page classes and page enum values
Port signal/slot that use action_data struct to PMF/Functor syntax
action_data: use enums instead of bool members to improve reability
GIT_SILENT Remove superfluous casts of signal pointers
GIT_SILENT Remove unused files
should be also updated to access the field correctly.
agent: Show "Label:" field of private key when prompt the insertion.
agent: Move confirmation handling into findkey.c.
• gniibe renamed
T5984: gpg-agent interaction improvement (smartcard improvement #3) from
smartcard interaction improvement #3 to
gpg-agent interaction improvement ( (smartcard improvement #3).
Also, it is better for a user, not to be asked confirmation (even if "Confirm:" is specified), that is, skipping the confirmation, when it is going to prompt the insertion of a card.
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRA826d43da1ce0: std::unary/binary_function have been deprecated and removed in C++17 (authored by Ahmad Samir <a.samirh78@gmail.com>).
std::unary/binary_function have been deprecated and removed in C++17
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRA6cb4179b4a2b: Fix a couple compiler warnings (authored by Ahmad Samir <a.samirh78@gmail.com>).
Fix a couple compiler warnings
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRAbd72100e94cf: ReaderStatus: use a std::function in Transaction struct (authored by Ahmad Samir <a.samirh78@gmail.com>).
ReaderStatus: use a std::function in Transaction struct
Manage lifetime of validator with shared pointer
Manage lifetime of validators with shared pointers
GIT_SILENT Remove unused functions
It seems that editing a pre-created revocation certificate on Windows with Notepad doesn't let Kleopatra detect this correctly as OpenPGP file and thus refuses to import. Works on the command line but needs more testing.
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRA2c90e6b48513: Minor refactor (authored by Ahmad Samir <a.samirh78@gmail.com>).
Minor refactor
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRAb9a64fb725e1: Port Q_FOREACH to range-for (authored by Ahmad Samir <a.samirh78@gmail.com>).
Port Q_FOREACH to range-for
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRA3bafe1c106a0: Use std::find_if instead of Q_FOREACH (authored by Ahmad Samir <a.samirh78@gmail.com>).
Use std::find_if instead of Q_FOREACH
ikloecker moved
T5832: Kleopatra: Make OpenPGP certificate generation (with default settings) accessible from
Restricted Project Column to
Restricted Project Column on the
Restricted Project board.
The KDE crowd think that this is likely a bug mingw. duckducking "mingw thread_local crash" give many hits, e.g. .
I put another change for T5099. This feature can be used for any keys, no matter if it's on Yubikey or not, no matter if token supports touch confirmation or not.
Part 2 patch is pushed, with a bit of change.
A user needs to specify "Confirm" flag in the key file.
agent: Pop up dialog window for confirmation, when specified so.
agent: Supply GRIP=NULL for agent_key_from_file, for real use.
For this particular issue of , if it's needed, the point we should fix is:
Pushed the change (master and 1.10).
cipher: Allow verification of small RSA signatures in FIPS mode
At first, we need to add/enhance new API for KDF in libgcrypt. Currently, the term "KDF" in libgcrypt is used with narrower focus, that is, only for password->key KDF.
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRA729995097cb0: ChecksumsUtils: split the implementation to .cpp file (authored by Ahmad Samir <a.samirh78@gmail.com>).
ChecksumsUtils: split the implementation to .cpp file
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRA98aa73452d22: CreateChecksumsController: move static util methods to a private header (authored by Ahmad Samir <a.samirh78@gmail.com>).
CreateChecksumsController: move static util methods to a private header
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRAaff083f42f99: VerifyChecksumsController: use static methods from checksumsutils_p.h (authored by Ahmad Samir <a.samirh78@gmail.com>).
VerifyChecksumsController: use static methods from checksumsutils_p.h
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRAea9276f35797: Checksum Controller: port to QRegularExpression (authored by Ahmad Samir <a.samirh78@gmail.com>).
Checksum Controller: port to QRegularExpression
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRAd337737e5706: Minor refactor (authored by Ahmad Samir <a.samirh78@gmail.com>).
Minor refactor
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRA2dedd369e35b: ChecksumsUtils: split the implementation to .cpp file (authored by Ahmad Samir <a.samirh78@gmail.com>).
ChecksumsUtils: split the implementation to .cpp file
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRAe3a153269fa4: Checksum Controller: port to QRegularExpression (authored by Ahmad Samir <a.samirh78@gmail.com>).
Checksum Controller: port to QRegularExpression
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRAc4489a4e5413: Minor refactor (authored by Ahmad Samir <a.samirh78@gmail.com>).
Minor refactor
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRAe610b20cdd2d: VerifyChecksumsController: use static methods from checksumsutils_p.h (authored by Ahmad Samir <a.samirh78@gmail.com>).
VerifyChecksumsController: use static methods from checksumsutils_p.h
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRA115561eef4bb: CreateChecksumsController: move static util methods to a private header (authored by Ahmad Samir <a.samirh78@gmail.com>).
CreateChecksumsController: move static util methods to a private header
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRA205a1b4923c2: ChecksumsUtils: split the implementation to .cpp file (authored by Ahmad Samir <a.samirh78@gmail.com>).
ChecksumsUtils: split the implementation to .cpp file
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRA0e046b207b17: Minor refactor (authored by Ahmad Samir <a.samirh78@gmail.com>).
Minor refactor
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRAff4c06056893: ChecksumsUtils: split the implementation to .cpp file (authored by Ahmad Samir <a.samirh78@gmail.com>).
ChecksumsUtils: split the implementation to .cpp file
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRA0c12f2b13e97: CreateChecksumsController: move static util methods to a private header (authored by Ahmad Samir <a.samirh78@gmail.com>).
CreateChecksumsController: move static util methods to a private header
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRAc38773ae930c: VerifyChecksumsController: use static methods from checksumsutils_p.h (authored by Ahmad Samir <a.samirh78@gmail.com>).
VerifyChecksumsController: use static methods from checksumsutils_p.h
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRAfcefb9df5534: Checksum Controller: port to QRegularExpression (authored by Ahmad Samir <a.samirh78@gmail.com>).
Checksum Controller: port to QRegularExpression
Certificate generation should now be possible with 400 % magnification. I haven't checked the different actions under "Next Steps".
Keep the old contents margins
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRAf07c4072108b: ChecksumsUtils: split the implementation to .cpp file (authored by Ahmad Samir <a.samirh78@gmail.com>).
ChecksumsUtils: split the implementation to .cpp file
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRA59e544571a9b: VerifyChecksumsController: use static methods from checksumsutils_p.h (authored by Ahmad Samir <a.samirh78@gmail.com>).
VerifyChecksumsController: use static methods from checksumsutils_p.h
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRA2721c995f0b7: CreateChecksumsController: move static util methods to a private header (authored by Ahmad Samir <a.samirh78@gmail.com>).
CreateChecksumsController: move static util methods to a private header
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRA06fa98e12992: Checksum Controller: port to QRegularExpression (authored by Ahmad Samir <a.samirh78@gmail.com>).
Checksum Controller: port to QRegularExpression
Ahmad Samir <a.samirh78@gmail.com> committed
rKLEOPATRA5c6c596785e2: Minor refactor (authored by Ahmad Samir <a.samirh78@gmail.com>).
Minor refactor
GIT_SILENT Update copyright notice
Allow scrolling the tabs of the Advanced Settings dialog vertically
Create UI of Advanced Settings dialog in code
Never shrink the window when adjusting its size
Create UI of Key Creation page in code
A concrete example use case in my mind is:
AFAICS, we need to implement a new Assuan flag and wipe the data passed to the callback after the callback returned.
Note that this doesn't work if pinentry is pinentry-gnome3. pinentry-qt works well, too, because it supports curses fallback.
That is expected. The export re-encrypts the secret parts to comply with the OpenPGP specs and this includes a salt andf IV and thus the output must be different.
I added the last line, to recover tty state:
With command and pinentry-gtk2, I now do experiment with this script:
Glad to hear. I've also now had time to manually apply the patches and have not seen any issues so far! Thank you! If anything does turn up later down the road I'll let you know.