pinentryProject
ActivePublic

Members

  • This project does not have any members.

Watchers

  • This project does not have any watchers.

Recent Activity

Tue, Oct 29

sunknudsen added a comment to T4733: pinentry-curses reveals pin.

Thanks for the follow-up Werner.

Tue, Oct 29, 11:54 AM · MacOS, pinentry, Bug Report
werner triaged T4733: pinentry-curses reveals pin as Normal priority.

Then better do not use a curses pinentry. It can't guarantee that another process changes the tty properties. For security reasons it is better to run the pinentry in a different window (ie. a GUI based pinentry).

Tue, Oct 29, 10:26 AM · MacOS, pinentry, Bug Report

Sep 21 2019

werner added a comment to T4123: Pinentry-qt does not always become active foreground window (especially when requesting pin for authentication).

It is not just about being annoying but for security reasons. It would be too easy for other applications *think webbrowser or Acrobat) to take a screenshot and pop up a modified version of that screenshot with data entries to act as a MitM.

Sep 21 2019, 11:00 AM · pinentry, Bug Report, gpg4win

Sep 15 2019

gouttegd added a comment to T3428: pinentry-curses should be able to avoid showing *s when user enters passphrase.

The feature has been implemented for the -qt, -tqt, -gtk, and -curses pinentries.

Sep 15 2019, 3:26 PM · pinentry, Feature Request

Aug 20 2019

dkg reopened T2013: pinentry-curses / pinentry-tty should emit a bell when showing a dialog as "Open".

reviewing this, i think the situation is:

Aug 20 2019, 2:36 AM · pinentry, Feature Request

Jul 29 2019

aheinecke added a comment to T4123: Pinentry-qt does not always become active foreground window (especially when requesting pin for authentication).

I think the problem is the following:

Jul 29 2019, 9:23 AM · pinentry, Bug Report, gpg4win

Jul 28 2019

bb added a comment to T4123: Pinentry-qt does not always become active foreground window (especially when requesting pin for authentication).

False alarm. Turns out pinentry-gtk-2.exe is also not working all the time.

Jul 28 2019, 9:22 PM · pinentry, Bug Report, gpg4win
a_p3rson added a comment to T4123: Pinentry-qt does not always become active foreground window (especially when requesting pin for authentication).

@bb - I've tried this, this doesn't appear to work. It looks like the Gtk2 pinentry doesn't grab focus when doing authentication, either. Interestingly enough, it also doesn't show in the taskbar.

Jul 28 2019, 12:50 AM · pinentry, Bug Report, gpg4win

Jul 27 2019

bb added a comment to T4123: Pinentry-qt does not always become active foreground window (especially when requesting pin for authentication).

Note:
I added:

pinentry-program "C:\Program Files (x86)\Gpg4win\bin\pinentry-gtk-2.exe"

as a workaround to my gpg-agent.conf. This pinentry is able to grab the focus.

Jul 27 2019, 3:58 PM · pinentry, Bug Report, gpg4win
bb added a comment to T4123: Pinentry-qt does not always become active foreground window (especially when requesting pin for authentication).

Does anyone has an update on this issue?

Jul 27 2019, 11:59 AM · pinentry, Bug Report, gpg4win
dkg added a comment to T4658: Fix a dangling pointer in pinentry's qt/main.cpp.

I've just uploaded pinentry 1.1.0-3 to debian unstable with this fix in it.

Jul 27 2019, 6:07 AM · pinentry, Bug Report
dkg added a comment to T4658: Fix a dangling pointer in pinentry's qt/main.cpp.

@aheinecke thanks for the heads-up. i'll pull this in.

Jul 27 2019, 1:16 AM · pinentry, Bug Report

Jul 25 2019

aheinecke updated subscribers of T4658: Fix a dangling pointer in pinentry's qt/main.cpp.

@dkg This patch ( rP0e2e53) might also be something for debian as it can cause crashes depending on the qt theme, which is not under our control.

Jul 25 2019, 4:19 PM · pinentry, Bug Report
aheinecke closed T4658: Fix a dangling pointer in pinentry's qt/main.cpp as Resolved.

Thanks!

Jul 25 2019, 4:14 PM · pinentry, Bug Report
aheinecke added a subtask for T4658: Fix a dangling pointer in pinentry's qt/main.cpp: T4659: Release Pinentry-1.0.1.
Jul 25 2019, 4:14 PM · pinentry, Bug Report
aheinecke added a parent task for T4659: Release Pinentry-1.0.1: T4658: Fix a dangling pointer in pinentry's qt/main.cpp.
Jul 25 2019, 4:14 PM · pinentry, Release Info
aheinecke created T4659: Release Pinentry-1.0.1.
Jul 25 2019, 4:13 PM · pinentry, Release Info
pmgdeb added a comment to T4658: Fix a dangling pointer in pinentry's qt/main.cpp.

I can confirm that the patch from the referenced commit fixes the issue. Thanks for the quick action!

Jul 25 2019, 3:37 PM · pinentry, Bug Report
aheinecke added a commit to T4658: Fix a dangling pointer in pinentry's qt/main.cpp: rP0e2e53c8987d: qt: Fix use of dangling pointer in QApplication.
Jul 25 2019, 3:27 PM · pinentry, Bug Report
aheinecke changed the status of T4658: Fix a dangling pointer in pinentry's qt/main.cpp from Open to Testing.

thanks for the report. I've commited a different fix 0e2e53c8987d6f236aaef515eb005e8e86397fbc which also should solve the problem.

Jul 25 2019, 2:31 PM · pinentry, Bug Report
pmgdeb added a comment to T4658: Fix a dangling pointer in pinentry's qt/main.cpp.

Adding the patch here.

Jul 25 2019, 1:21 PM · pinentry, Bug Report
pmgdeb created T4658: Fix a dangling pointer in pinentry's qt/main.cpp.
Jul 25 2019, 1:19 PM · pinentry, Bug Report

Jul 13 2019

chyen added a comment to T4598: curses: dialog broken with wide characters.

Thanks for all the fixes! I can confirm commit dad35d65f05eb1c15589a7e4755dcae6aed2d6cf works just fine on all my machines (Linux & macOS).

Jul 13 2019, 11:30 AM · pinentry

Jul 11 2019

gniibe claimed T4587: pinentry-gnome3 grabs input (is system modal) despite`--no-global-grab` or `OPTION no-grab`.

gpg-agent side is fixed to relax the error handling.

Jul 11 2019, 7:57 AM · gpgagent, pinentry
gniibe added a commit to T4587: pinentry-gnome3 grabs input (is system modal) despite`--no-global-grab` or `OPTION no-grab`: rG02d8b383833b: agent: Relax the handling of pinentry error for keyboard grab..
Jul 11 2019, 7:56 AM · gpgagent, pinentry
gniibe closed T4598: curses: dialog broken with wide characters as Resolved.
Jul 11 2019, 3:53 AM · pinentry

Jul 10 2019

gniibe added a commit to T4598: curses: dialog broken with wide characters: rPdad35d65f05e: curses: Fix more..
Jul 10 2019, 2:16 AM · pinentry
gniibe added a comment to T4598: curses: dialog broken with wide characters.

I pushed the fix. Thanks for your cooperation.

Jul 10 2019, 2:15 AM · pinentry
gniibe added a comment to T4598: curses: dialog broken with wide characters.

Thanks for further testing.
I realized that it's not the left border drawing problem in fact, but the newline should be between the description and passphrase line.
I'm going to fix this.

Jul 10 2019, 2:07 AM · pinentry

Jul 9 2019

chyen added a comment to T4598: curses: dialog broken with wide characters.

Thanks for the further fix! With that only a minor hiccup remains:

Jul 9 2019, 6:19 PM · pinentry
gniibe added a commit to T4598: curses: dialog broken with wide characters: rPa03f39207148: curses: Fix handling of newline in description..
Jul 9 2019, 9:30 AM · pinentry
chyen added a comment to T4598: curses: dialog broken with wide characters.

Thanks for the update! With git-master, the toy example above works fine. However, pinentry-curses seems to hang with real commands from gpg. Here is an example:

$ ./curses/pinentry-curses 
OK Pleased to meet you
SETDESC 請輸入密語來解鎖 OpenPGP 私鑰:%0A%22Chih-Hsuan Yen <yan12125@gmail.com>%22%0A3072 位元長的 DSA 金鑰, ID F98EF2A7B0A098AE,%0A建立於 2018-04-25 (主要金鑰 ID 3FDDD575826C5C30).%0A
OK
SETPROMPT 密語:
OK
GETPIN

(CPU usage of ./curses/pinentry-curses goes > 90%)

Jul 9 2019, 9:06 AM · pinentry
gniibe added a commit to T4598: curses: dialog broken with wide characters: rP9298cca67742: curses: Fix calculation of columns for CJK text..
Jul 9 2019, 7:41 AM · pinentry
gniibe added a comment to T4598: curses: dialog broken with wide characters.

I pushed the change to master.
Please test.

Jul 9 2019, 7:23 AM · pinentry
gniibe claimed T4598: curses: dialog broken with wide characters.
Jul 9 2019, 7:20 AM · pinentry

Jul 1 2019

werner triaged T4598: curses: dialog broken with wide characters as Normal priority.
Jul 1 2019, 9:59 PM · pinentry
chyen added a comment to T4598: curses: dialog broken with wide characters.

Well in my browser (Firefox) the dialogs are not rendered correctly. Here are the two dialogs in the terminal:

Jul 1 2019, 3:30 PM · pinentry
chyen created T4598: curses: dialog broken with wide characters in the S1 Public space.
Jul 1 2019, 3:23 PM · pinentry

Jun 27 2019

dkg added a comment to T4587: pinentry-gnome3 grabs input (is system modal) despite`--no-global-grab` or `OPTION no-grab`.

Thanks for the feedback, @werner. I think I understand the reasons that we've gotten to this place -- but that doesn't mean i think it's ok to stay here. In this bug report, i'm pointing out that the documentation and the feedback/error reporting is misleading, which leads to difficulty in debugging. We need to do something about it.

Jun 27 2019, 6:20 PM · gpgagent, pinentry
werner removed a project from T4587: pinentry-gnome3 grabs input (is system modal) despite`--no-global-grab` or `OPTION no-grab`: Bug Report.

pinentry-gnome has no grab support. However, it needs to accept that option so that gpg-agent does not error out. We want to have the same global options for all pinentries. Whether they work depends on the pinentry and other parameters. For example when falling back to curses grab won't work in any pinentry.

Jun 27 2019, 3:08 PM · gpgagent, pinentry

Jun 26 2019

dkg added a comment to T4587: pinentry-gnome3 grabs input (is system modal) despite`--no-global-grab` or `OPTION no-grab`.

I note that this is likely happening because we are using gcr's system-modal prompter. I haven't looked into whether it's even possible to use gcr in a non-system-modal way, but i'd welcome pointers.

Jun 26 2019, 8:00 PM · gpgagent, pinentry
dkg created T4587: pinentry-gnome3 grabs input (is system modal) despite`--no-global-grab` or `OPTION no-grab`.
Jun 26 2019, 7:58 PM · gpgagent, pinentry

Jun 4 2019

maiden_taiwan closed T4542: gpg-agent loses characters when prompting for a GPG passphrase over SSH in Emacs as Resolved.

No worries -- you led me in the direction of a solution when you mentioned loopback mode. I appreciate your time and your help!

Jun 4 2019, 2:34 AM · Emacs, Documentation, pinentry, Bug Report
gniibe added projects to T4542: gpg-agent loses characters when prompting for a GPG passphrase over SSH in Emacs: Documentation, Emacs.

Sorry, I responded in a mode of "tracking a bug to fix soonish". I should have changed my mode into showing HOWTO.
Thanks for sharing useful link.

Jun 4 2019, 2:07 AM · Emacs, Documentation, pinentry, Bug Report

Jun 3 2019

maiden_taiwan added a comment to T4542: gpg-agent loses characters when prompting for a GPG passphrase over SSH in Emacs.

I found these instructions for pinentry loopback in Emacs, and they worked!

Jun 3 2019, 5:43 PM · Emacs, Documentation, pinentry, Bug Report
maiden_taiwan added a comment to T4542: gpg-agent loses characters when prompting for a GPG passphrase over SSH in Emacs.

When you can configure it properly, there is a way to workaround it.

Jun 3 2019, 5:28 PM · Emacs, Documentation, pinentry, Bug Report
gniibe added a comment to T4542: gpg-agent loses characters when prompting for a GPG passphrase over SSH in Emacs.

For (1): it is broken out-of-the-box, that would be true. When you can configure it properly, there is a way to workaround it. Well, I admit, it's not yet perfect.

Jun 3 2019, 2:59 AM · Emacs, Documentation, pinentry, Bug Report
maiden_taiwan added a comment to T4542: gpg-agent loses characters when prompting for a GPG passphrase over SSH in Emacs.

Thank you for that analysis. I don't understand some of the parts (because I don't know anything about pinentry), but I do have some questions.

Jun 3 2019, 2:40 AM · Emacs, Documentation, pinentry, Bug Report
gniibe claimed T4542: gpg-agent loses characters when prompting for a GPG passphrase over SSH in Emacs.

Thanks for your report. The symptom you have could be only solved by using pinentry loopback mode, or using some special pinentry for CLI, I suppose. pinentry-tty is not sufficient for this usage.

Jun 3 2019, 1:55 AM · Emacs, Documentation, pinentry, Bug Report

May 31 2019

maiden_taiwan added a comment to T4542: gpg-agent loses characters when prompting for a GPG passphrase over SSH in Emacs.

Please let me know if I can run any other tests to help debug this issue. I'm happy to help.

May 31 2019, 8:05 PM · Emacs, Documentation, pinentry, Bug Report