Page MenuHome GnuPG

pinentryProject
ActivePublic

Members

  • This project does not have any members.
  • View All

Watchers

  • This project does not have any watchers.
  • View All

Recent Activity

Wed, Apr 28

bagnaram closed T5410: pinentry-gnome3 no longer functions in Wayland as Resolved.
Wed, Apr 28, 4:38 AM · pinentry
bagnaram added a comment to T5410: pinentry-gnome3 no longer functions in Wayland.

Thank you all for the help. I thought this was a bug with pinentry itself but appears to be dbus related based on the above command.

Wed, Apr 28, 4:38 AM · pinentry
gniibe added a comment to T5410: pinentry-gnome3 no longer functions in Wayland.

To set DISPLAY, dbus-update-activation-environment is your friend.

Wed, Apr 28, 3:43 AM · pinentry
gniibe added a comment to T5410: pinentry-gnome3 no longer functions in Wayland.

FYI, for me, on a machine with Debian GNU/Linux, I use Sway, it works fine with pinentry-gnome3.

Wed, Apr 28, 3:34 AM · pinentry
bagnaram added a comment to T5410: pinentry-gnome3 no longer functions in Wayland.

I have installed the Gnome keyring prompter and there seems to be a problem using the Wayland display

Apr 27 17:33:09 mbagnara-pc org.gnome.keyring.SystemPrompter[1952]: Unable to init server: Could not connect: Connection refused
Apr 27 17:33:09 mbagnara-pc gcr-prompter[1952]: cannot open display:
Wed, Apr 28, 12:46 AM · pinentry

Mon, Apr 26

werner triaged T5410: pinentry-gnome3 no longer functions in Wayland as Normal priority.

Please install the Gnome Key Ring prompter tool or use the plain GTK pinentry.

Mon, Apr 26, 2:17 PM · pinentry

Sat, Apr 24

bagnaram created T5410: pinentry-gnome3 no longer functions in Wayland.
Sat, Apr 24, 1:10 AM · pinentry

Tue, Apr 20

gniibe closed T5384: pinentry coverity static analysis reports as Resolved.
Tue, Apr 20, 2:28 AM · pinentry, Bug Report

Fri, Apr 16

gniibe added a comment to T5384: pinentry coverity static analysis reports.

Fixed in rP7f7fd8bcfd74: tty: Fix error return paths and its resource leaks.

Fri, Apr 16, 5:59 AM · pinentry, Bug Report
gniibe added a comment to T5384: pinentry coverity static analysis reports.

Actually, calling do_tuch_file when some error(s) are not good.
Let me fix all the things.

Fri, Apr 16, 5:02 AM · pinentry, Bug Report

Thu, Apr 15

Jakuje added a comment to T5384: pinentry coverity static analysis reports.

I hope last amendment is the following, which can happen if the tty can be opened only for reading but not for writing:

--- a/tty/pinentry-tty.c
+++ b/tty/pinentry-tty.c
@@ -583,7 +583,8 @@ tty_cmd_handler (pinentry_t pinentry)
   if (pinentry->ttyname)
     {
       fclose (ttyfi);
-      fclose (ttyfo);
+      if (ttyfo)
+        fclose (ttyfo);
     }
Thu, Apr 15, 11:43 AM · pinentry, Bug Report
gniibe changed the status of T4848: Usage of git in configure.ac for pinentry/gpa finds incorrect repositories from Open to Testing.

Done for gpa.
Please test.

Thu, Apr 15, 7:08 AM · pinentry, gpa, toolchain, Bug Report
gniibe added a comment to T4848: Usage of git in configure.ac for pinentry/gpa finds incorrect repositories.

Done for pinentry.

Thu, Apr 15, 6:36 AM · pinentry, gpa, toolchain, Bug Report

Wed, Apr 14

Jakuje reopened T5384: pinentry coverity static analysis reports as "Open".

Thank you for applying the provided changes!

Wed, Apr 14, 5:44 PM · pinentry, Bug Report
gniibe closed T5384: pinentry coverity static analysis reports as Resolved.

Applied and pushed.

Wed, Apr 14, 8:58 AM · pinentry, Bug Report

Apr 13 2021

gniibe claimed T5384: pinentry coverity static analysis reports.

Thank you. I'll take care of this.

Apr 13 2021, 3:01 AM · pinentry, Bug Report

Apr 7 2021

Jakuje created T5384: pinentry coverity static analysis reports.
Apr 7 2021, 3:00 PM · pinentry, Bug Report

Apr 6 2021

werner triaged T5377: pinentry-qt dialog cannot be raised under Linux/Wayland as Normal priority.
Apr 6 2021, 9:56 AM · pinentry, Bug Report

Apr 1 2021

werner added a comment to T5377: pinentry-qt dialog cannot be raised under Linux/Wayland.

Seems that it is not a coincidence that Wayland starts with a W like Windows. ;-)

Apr 1 2021, 12:28 PM · pinentry, Bug Report
holi0317 created T5377: pinentry-qt dialog cannot be raised under Linux/Wayland.
Apr 1 2021, 12:11 PM · pinentry, Bug Report

Mar 25 2021

aheinecke added a comment to T4974: timeout for pinentry too short for key-generation, losing previous entries.

pinentry-timeout is indeed used when it is not set to 0.

Mar 25 2021, 12:15 PM · pinentry
aheinecke added a comment to T4974: timeout for pinentry too short for key-generation, losing previous entries.

In my opinion this is also a problem. Especially if you think about it for a while. The one minute timeout is too short and pinentry-timeout which I would expect here to be the config value to adjust this is not used.

Mar 25 2021, 11:53 AM · pinentry

Feb 24 2021

Aster89 added a comment to T5322: gpg erroring when the terminal is too small to show the ncurses pinentry dialog.

As suggested in the linked question on stackexchange, I think that even if the error comes from the pinentry program, GnuPG could echo a more informative error than gpg: decryption failed: No secret key, such as terminal to little to show the pinetnry program, or something similar.

Feb 24 2021, 2:37 PM · gnupg (gpg22), gpgagent, pinentry, Bug Report

Feb 23 2021

werner triaged T5322: gpg erroring when the terminal is too small to show the ncurses pinentry dialog as Normal priority.

Thanks for the report. Frankly the curses pinentries are not that widely tested.

Feb 23 2021, 5:02 PM · gnupg (gpg22), gpgagent, pinentry, Bug Report

Feb 21 2021

wltjr added a comment to T5308: pkg-config misuse in efl sections of pinentry autoconf tooling.
Feb 21 2021, 5:06 AM · pinentry, Bug Report

Feb 19 2021

ikloecker added a comment to T5308: pkg-config misuse in efl sections of pinentry autoconf tooling.

Well, it's a (hard) requirement unless you explicitly disable efl, i.e. ./configure (without --disable-efl) fails with an error if elementary or ecore-x is not found.

Feb 19 2021, 2:54 PM · pinentry, Bug Report
dkg added a comment to T5308: pkg-config misuse in efl sections of pinentry autoconf tooling.

I don't think the patch made elementary and ecore-x dev headers an absolute hard requirement; in particular, ./configure --disable-efl works fine to build pinentry without having these headers installed.

Feb 19 2021, 2:22 PM · pinentry, Bug Report
ikloecker added a comment to T5308: pkg-config misuse in efl sections of pinentry autoconf tooling.

The following patch makes the efl requirements optional unless pinentry-efl is explicitly enabled:

diff --git a/configure.ac b/configure.ac
index bc67c14..ce170c9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -423,7 +423,24 @@ AC_ARG_ENABLE(pinentry-efl,
             pinentry_efl=$enableval, pinentry_efl=maybe)
Feb 19 2021, 12:42 PM · pinentry, Bug Report
ikloecker added a comment to T5308: pkg-config misuse in efl sections of pinentry autoconf tooling.

rP19a18ba5fee0 makes elementary and ecore-x hard requirements for pinentry. I don't think that's intended.

Feb 19 2021, 12:05 PM · pinentry, Bug Report

Feb 18 2021

dkg closed T5308: pkg-config misuse in efl sections of pinentry autoconf tooling as Resolved.

Thanks for the verification, @wltjr. I've pushed 19a18ba5fee049aac87b5114763095aaeb42430f to the master branch for future releases.

Feb 18 2021, 3:30 PM · pinentry, Bug Report
werner triaged T5307: pinentry-qt unilaterally enables rpath, even when configured with `--disable-rpath` as Low priority.
Feb 18 2021, 8:49 AM · qt, pinentry, Bug Report
werner triaged T5308: pkg-config misuse in efl sections of pinentry autoconf tooling as Normal priority.
Feb 18 2021, 8:49 AM · pinentry, Bug Report
wltjr added a comment to T5308: pkg-config misuse in efl sections of pinentry autoconf tooling.

Btw, ecore-x was also needed, so that should remain. Just to be clear, the final version should be

PKG_CHECK_MODULES(EFL,[elementary >= 1.18,ecore-x])

Give or take the >= vs >.

Feb 18 2021, 4:46 AM · pinentry, Bug Report
wltjr added a comment to T5308: pkg-config misuse in efl sections of pinentry autoconf tooling.

@dkg it was the 2nd one, the EFL vs efl. That worked fine after uppercasing it! The >= may not be necessary, but might as well. I am on a much newer EFL, 1.25.1, so not really able to test that part of it. I should be running one of the latest autotools,

[ebuild   R    ] sys-devel/automake-1.16.3-r1:1.16::gentoo  USE="-test" 0 KiB
[ebuild   R    ] sys-devel/autoconf-2.69-r5:2.69::gentoo  USE="-emacs" 1,438 KiB
[ebuild   R    ] sys-devel/libtool-2.4.6-r6:2::gentoo  USE="-vanilla" 951 KiB
Feb 18 2021, 4:42 AM · pinentry, Bug Report
dkg added a comment to T5308: pkg-config misuse in efl sections of pinentry autoconf tooling.

hm, actually, maybe the efl should be EFL in order to produce and substitute the EFL_CFLAGS and EFL_LIBS variables.

Feb 18 2021, 2:22 AM · pinentry, Bug Report
dkg added a comment to T5308: pkg-config misuse in efl sections of pinentry autoconf tooling.

@wltjr maybe it needs ecore-x as well as elementary > 1.18 in the PKG_CHECK_MODULES line? oh, and looks like i screwed up and used > where i should have used >= sorry! fixing those would make the PKG_CHECK_MODULES line be:

Feb 18 2021, 2:18 AM · pinentry, Bug Report
wltjr added a comment to T5308: pkg-config misuse in efl sections of pinentry autoconf tooling.

Looks like its missing an include

x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I..  -pthread -I/usr/include/libsecret-1 -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/lib64/libffi/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include    -I/usr/include/ncursesw -I../secmem -I../pinentry -Wall  -O2 -pipe -march=amdfam10 -mcx16 -msahf -mabm -mlzcnt -Wall -Wno-pointer-sign -Wpointer-arith -c -o pinentry-efl.o pinentry-efl.c
pinentry-efl.c:32:10: fatal error: Elementary.h: No such file or directory
   32 | #include <Elementary.h>
      |          ^~~~~~~~~~~~~~
compilation terminated.

Feb 18 2021, 1:00 AM · pinentry, Bug Report
wltjr added a comment to T5308: pkg-config misuse in efl sections of pinentry autoconf tooling.

@dkg for sure, I will test out the patch ASAP. Thanks for the ping.

Feb 18 2021, 12:54 AM · pinentry, Bug Report

Feb 17 2021

dkg added a comment to T5308: pkg-config misuse in efl sections of pinentry autoconf tooling.

fwiw, i think a patch like this ought to work with reasonably-modern versions of autotools:

Feb 17 2021, 9:22 PM · pinentry, Bug Report
dkg updated subscribers of T5308: pkg-config misuse in efl sections of pinentry autoconf tooling.

@wltjr maybe you could take a look at this?

Feb 17 2021, 8:52 PM · pinentry, Bug Report
dkg renamed T5308: pkg-config misuse in efl sections of pinentry autoconf tooling from po to pkg-config misuse in efl sections of pinentry autoconf tooling.
Feb 17 2021, 8:44 PM · pinentry, Bug Report
dkg created T5308: pkg-config misuse in efl sections of pinentry autoconf tooling.
Feb 17 2021, 8:43 PM · pinentry, Bug Report
dkg created T5307: pinentry-qt unilaterally enables rpath, even when configured with `--disable-rpath`.
Feb 17 2021, 8:22 PM · qt, pinentry, Bug Report

Jan 30 2021

werner triaged T5281: gpg-agent / pinentry: allow to pause/mute passphrase requests for a while as Normal priority.
Jan 30 2021, 12:10 PM · gpgagent, pinentry, Feature Request

Jan 27 2021

gouttegd closed T5262: pinentry qt4 fails to compile in pinentry 1.1.1 as Resolved.

Thanks @aheinecke for fixing my fix with 2859edd! Closing here.

Jan 27 2021, 12:37 AM · pinentry, Bug Report

Jan 26 2021

aheinecke abandoned D521: qt: Fix build against Qt4..

Modified and commited with: rev. 2859eddfb0c935d3f9eb9ccc1b42c121621123e9 I'm not sure if phabricator automatically does it when I mention the differential as GnuPG-Bug-Id

Jan 26 2021, 11:34 AM · pinentry
aheinecke commandeered D521: qt: Fix build against Qt4..

Thanks for noticing, I did not have Qt4 on my radar when writing this. The delayed raise with the timer might be only necessary on windows, on linux we don't have reports that just doing an activateWindow and raise does not work. So this is mostly for windows and there the Qt4 pinentry is not relevant.

Jan 26 2021, 11:11 AM · pinentry

Jan 25 2021

werner added a comment to T4659: Release Pinentry-1.1.1.
  • Please see T5262 if you want to build with Qt4.
Jan 25 2021, 10:43 AM · pinentry, Release Info

Jan 24 2021

gouttegd updated subscribers of T5262: pinentry qt4 fails to compile in pinentry 1.1.1.

There’s a patch to restore support for Qt4: D521.

Jan 24 2021, 12:49 AM · pinentry, Bug Report
gouttegd created D521: qt: Fix build against Qt4..
Jan 24 2021, 12:43 AM · pinentry