Today
Then, we need to integrate following commits of 2.2 into gniibe/t7855 branch:
rG43fe9073aa81: gpg,gpgsm: Tweak the locking of the pubring.kbx
rG8491aca73cff: gpg: Revert the always locking introduced with 43fe9073aa
rGad4a5117ab1c: gpgsm: Properly release the lock when compressing a pubring.
rG7962eca3a023: gpgsm: Change delete and store certificate locking glitches.
rG22f9c4a3b3c1: gpg: Release lock after close also in the compress code path.
I created gniibe/t7855 branch for this issue.
To start with, I forward-port/cherry-pick 2.2 commits to the branch:
rG39430d9f78dc: build,common,g13,sm,tools: Require GpgRT 1.56.
rGe71aca2a628d: common: New function gnupg_remove_ext.
rGe38c5f7d5873: w32:common: Take care of possible race on startup under Windows.
rG7bfd37e305c0: common,w32: Always use share mode readwrite for the keybox.
@timegrid Thank you for your confirmation.
Sorry for my late review. I should have reviewed earlier.
Yesterday
I can't reproduce this in vsd-3.3.90.19 @ win10 anymore.
Probably the fixes in https://dev.gnupg.org/T7827 or https://dev.gnupg.org/T7855 solved this, too.
Sun, Oct 12
Sat, Oct 11
Fri, Oct 10
This does not occur any more in Gpg4win-5.0.0-beta369
The problem here is that iobuf_readbyte returns -1 on error and on EOF. parse_packet is not able to distinguish that because for histroic reasons we do not return a gpg-error code (GPG_ERR_EOF). To fix this we need to change all callers of parse_packet to not act upon -1 but only on an error code.
I understand that this is for 2.6.
Thu, Oct 9
Except for the release/unlock thing after keybox_compress I already have the other fixes in my 2.2 commits. I noticed that the gpgsm keydb lock/release stuff differes from the one for gpg: For gpg we use the keybox_lock function but that is bot used at all by gpgsm. In theory this should be unified but I fear a regression risk and thus for 2.2 we better don't touch it.
The latter is also the case for deleted softkeys.
Might be related to T7836?
Might this be related to T4953?
Shall we merge this with T2196 ? BTW, I have some unpushed commit and a test installer.
Here are places where I found problems.
The regression that the Welcome screen didn't go away after generating the very first key has been fixed. The fix has been backported for VSD 3.4 and VSD 3.3.
I was asked to test this again with a newer version. With Gpg4win-5.0.0-beta369 not much has changed, you still can choose "Certify" on the only secret key and the certify window only allows "Cancel". Difference is only that now the "Certify with" line is empty:
Panel Used By
Dashboard | Mitzie209's Dashboard |