I wonder how useful this is. When entering your password, you can't see it.
Thus, if you make a mistake are you really able to recover by deleting the last
word? I don't think I could. If werner still thinks it is a good idea, I'll
implement it, but I think it is a waste of time.

The patch seems reasonable. Applied.

On a debian system, i did:

   apt install --no-install-recommends scim scim-gtk-immodule

Here is a transcript of pinentry being invoked: there is additional scim-related
output:

0 dkg@alice:~$ GTK_IM_MODULE=scim pinentry-gtk-2
OK Your orders please
GETPIN
Loading simple Config module ...
Creating backend ...
Loading socket FrontEnd module ...
Starting SCIM as daemon ...
Loading socket Config module ...
Creating backend ...
Loading x11 FrontEnd module ...
GTK Panel of SCIM 1.4.15

Starting SCIM as daemon ...

at this point, no keyboard entry works in the module at all.

This is https://bugs.debian.org/750521

pinentry GTK-2 is still failing to accept any keyboard input when invoked with
GTK_IM_MODULE=scim

D303: 609_559936.patch

the reporter noted the same problem in 0.9.0, not just 0.7.6.

still, a re-test with 0.9.2 would be useful

sorry, that should be https://bugs.debian.org/581617 instead.

Unfortunately, yes. Still happening with 0.9.2.

From looking at the error (I don't have gcc 5 at hand) this looks to me like a
problem in the stdc++ library.

It appears that the basic_string implementation wants to put the templates class
(QChar) into a Union and it fails because it has a non-trivial constructor and
this is not allowed.

As this currently works, either the stdc++ library does this differently or gcc
does not check that rule.

Depending on the GCC Version during build configuration I guess we could add
-std=gnu++11 as the error message suggests if the GCC mayor version is > 5

Afaik this is not a pinentry-qt issue as the style looks ok under Unity (ubuntu)
and Windows.

I want to investigate why that is the case and figure out what the problem is
exactly (other KDE password entries in the same style environment look slightly
better) so I left this open to remind me.

I've clarified the title.

fixed by using

1. pragma GCC diagnostic push
2. pragma GCC diagnostic ignored "-Wstrict-prototypes"

...

Andre: Can we fix that without the need to require a newer gcc version?

Okay. The secentry needs some work anyway to allow for a hide/show button. This
will probably go in the 0.9.3 release because it is too late for 0.9.2

We had 7 more releases after 0.7.6 Can you please test with 0.9.2 which will
be released today.

Does this still happen with 0.9.1 or 0.9.2 which will be released later the day.

Fixed with 0.9.1 which has a new option parser.

Ludwig: Is that still an issue with a decent pinentry (0.9.1)?

Fixed with commit 726c005 for 0.9.2.

You will now get an gpg-error codes like ENOENT, ENOTTY and GPG_ERR_TOO_SHORT
and not always GPG_ERR_CANCELED. I was not able to replicate a crash but that
might have been fixed in an earlier version.

Fixed with commit d7f2081 for 0.9.2.

The report is quite old.
Let's assume that has been fixed by newer gtk versions.

Is that still a problem with the latest Pinentry (0.9.1 or 0.9.2)?

dkg and Neal fixed a couple of things recently. @neal: I think supporting C-W
in curses would a good idea.

That would require to send this string to all pinentries.

Fixed in:

commit 189ab07e94dc2d4103c1edf00e15e0156df89297
Author: Neal H. Walfield <neal@gnu.org>
Date: Fri May 1 20:35:59 2015 +0200

When reading the pin, correctly handle backspace.

* tty/pinentry-tty.c (read_password): Handle backspace.

--

I think this needs to be a bit clearer:

In pinentry-tty.c:confirm, only the "ok" button's text is shown and it is
suffixed by a fixed string: "[y/N]", which should be internationalized.

Well, it is only a warning and we should not remove the -Wstrict-prototypes
because it is in general very helpful. I suggest to use something similar to

#if JNLIB_GCC_HAVE_PUSH_PRAGMA

1. pragma GCC push_options
2. pragma GCC optimize ("no-strict-overflow")

#endif
....
pragma pop... but with the diagnostics pragmas.

Just pushed commit 9d2d8b6 which is the patch with some modification to avoid
gcc warnings. Will go into 0.9.2

Thanks.

This is still an issue with pinentry 0.9.1

Fixed with pinentry 0.9.1.

How much time would it take to migrate to QT5?

Should be fixed now.

The next version will no longer include the generated moc files.
It's not really a patch to backport (as you requested this in your mailing list).

In quilt you can just do something like:
quilt new remove-broken-moc-files.patch
quilt add qt4/*.moc
rm qt4/*.moc
quilt refresh

I also ran into this problem with our (intevation's) debian packaging.

Just removing the .moc files worked as they were correctly generated
automatically (as they should be).

I'll commit a fix not to include them in the dist package anymore.

Thanks!

Applied:
http://git.gnupg.org/cgi-bin/gitweb.cgi?p=pinentry.git;a=commit;h=484465338ea6f5f12eb1341ca0ef84aa79224ed4

D274: 536_0001-pinentry-qt4-make-the-accessibility-part-optional.patch

Werner: I think the source tarball you distribute should be changed not to
include the .moc files as they depend on the qt version used when you generate
the tarballs.

MOC should be detected during configure (and otherwise pinentry-qt should be
disabled) and MOC should be used to generate the moc files. If this does not
work as expected this might have been caused by my limited Make and autotools
skills ;-)

On 12/02/2014 10:14 PM, Daniel Kahn Gillmor via BTS wrote:

Daniel Kahn Gillmor <dkg@fifthhorseman.net> added the comment:

Any word on this? It would be nice to see something like this merged.

Any word on this? It would be nice to see something like this merged.

Thanks werner -- I've filed an upstream issue to bring awareness of the change
to the software I use that was affected (duply/duplicity), I'm sure this is
going to pop up for others as 2.1 becomes more widely adopted. Maybe add
something to the release notes or docs for '--passphrase-fd 0' so folks know a
config change is needed in their apps and gpg-agent? Regardless, I appreciate
your help.

(marking as resolved)