Thank you for your publishing your key of CB6BE1D0D7D1594A.
I applied and pushed your changes.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Apr 12 2021
Apr 12 2021
Apr 11 2021
Apr 11 2021
still actual problem (Gpg4win-3.1.15, Windows 10)
Apr 9 2021
Apr 9 2021
Thanks. Note, that the same code is in gnupg2 in common/exechelp-posix.c:736
Apr 8 2021
Apr 8 2021
In T5381#144927, @gniibe wrote:For gpgrt_wait_processes, I modified it to skip invalid PID.
The change is: rE956c40f106ea: core: Fix gpgrt_wait_processes, by skipping invalid PID.
Thank you.
Applied both to STABLE-BRANCH-2-2 and master (changing new function name).
• gniibe added a comment to T5380: Tools needed during a build lack of CFLAGS was passed durring configure time.
CC_FOR_BUILD is used for building executables for the build machine.
CC_FOR_BUILD may be different to CC (for target).
For gpgrt_wait_processes, I modified it to skip invalid PID.
The change is: rE956c40f106ea: core: Fix gpgrt_wait_processes, by skipping invalid PID.
Apr 7 2021
Apr 7 2021
Yes, will be fixed but it has no severity because the fault is actually by the caller.
xandox added a comment to T5380: Tools needed during a build lack of CFLAGS was passed durring configure time.
Referencing external patches is not sufficient
xandox added a comment to T5380: Tools needed during a build lack of CFLAGS was passed durring configure time.
What is vcpkg?
• werner added a project to T5380: Tools needed during a build lack of CFLAGS was passed durring configure time: MacOS.
Sorry, I can't parse your message. Please describe the problem or feature requests. Referencing external patches is not sufficient. What is vcpkg?
Thanks. I understand that this is no big issue in the test code, but half of the code paths have proper cleaning already so fixing it once should save anyone in the future going through the same issues over and over again during our releases or anyone else who would run your code through static analyzer.
Thank you.
For get_attr_l, I pushed a fix as rE89a353f418f5: build: Fix gpgrt-config for handling 'Requires' field.
Apr 6 2021
Apr 6 2021
Actually I don't care about releasing resources for regression test failures.
The other missing free is for code which is commented out (#if 0) but should eventually be fixed.
Note that rndjent.c is already build with -O0 as can be seen in example above. That warning could be silenced by surrounding pragma with #ifdef __OPTIMIZE__ (with should be supported by GCC and Clang).
FYI, I sent DCO to gnupg-devel@gnupg.org some moments ago, so I hope it arrived correctly.
xandox changed External Link from https://github.com/microsoft/vcpkg/pull/15605 https://github.com/microsoft/vcpkg/pull/17020 https://github.com/microsoft/vcpkg/pull/17023 https://github.com/microsoft/vcpkg/pull/17021 to https://github.com/microsoft/vcpkg/pull/15605 on T5380: Tools needed during a build lack of CFLAGS was passed durring configure time.
Apr 4 2021
Apr 4 2021
This feature does not use Outlook per se.. It's a problem with Exchange really. An Exchange Add-in would be needed to solve it, an Outlook add-in such as Gpgol can't do anything about it..
Apr 1 2021
Apr 1 2021
Seems that it is not a coincidence that Wayland starts with a W like Windows. ;-)
Fixed in 1.42.
Mar 30 2021
Mar 30 2021
• werner triaged T5376: gpg --fetch-keys no longer returns non 0 exit status on failure as Normal priority.
You are coming pretty late to the party ;-). Since 2.1.0 we don't use the ancient keyserver helpers anymore but reworked the entire network access. I even doubt that I can still test with a 2.0 version.
We have two or three other open issue which I would like to address before a release. FWIW, release ticket is T5305.
Do what ever you want with _gcry prefixed functions - this is never considered an API or ABI break. There are some exceptions for internal functions used by macros but those are clearly marked.
Good to hear that it works now.
I already backported the above for Fedora so I am not in hurry now. But I believe others might hit the same issue.
@werner Can you comment about bugfix release?
These functions are internal to library and, for example, on linux/windows builds are not externally available.
Admin here. I'm sorry your replies did not make it to this site but somewhere got stuck. So copying them for completeness:
• aheinecke added a comment to T5374: GpgOL: Can't move a signed mail in Outlook from In-Mail folder to any other folder.
Very strange. Both logs show no error.
EnricoH added a comment to T5374: GpgOL: Can't move a signed mail in Outlook from In-Mail folder to any other folder.
Sorry, first log was without API.
This log includes API calls.
gpgol3.txt20 KBDownload
EnricoH added a comment to T5374: GpgOL: Can't move a signed mail in Outlook from In-Mail folder to any other folder.
Here we go. ;-)
• aheinecke added a comment to T5374: GpgOL: Can't move a signed mail in Outlook from In-Mail folder to any other folder.
Just drag and drop it into the input field. There is also a little cloud icon that makes this explicit.
EnricoH added a comment to T5374: GpgOL: Can't move a signed mail in Outlook from In-Mail folder to any other folder.
Thanks for this very quick reply.
• aheinecke triaged T5374: GpgOL: Can't move a signed mail in Outlook from In-Mail folder to any other folder as Normal priority.
Mmh, all these issues should be fixed with the most recent versions.
The optimization introduced for curve 25519 and curve 448 en-bugged for usage of direct MPI.
Mar 29 2021
Mar 29 2021
• werner added projects to T5373: Using GCRY_THREAD_OPTION_PTHREAD_IMPL in a file compiled with Clang generates deprecation warning: libgcrypt, clang.
Yet another identify theft scam committed by clang.
This patch should work if configure properly detects need for extra underscore on C symbols:
This patch should work if configure properly detects need for extra underscore on C symbols:
0001-mpi-aarch64-use-C_SYMBOL_NAME-for-assembly-function-.patch4 KBDownload
• werner updated the task description for T5372: assertion failure mulm_25519: different sizes in Libgrypt 1.9.
• werner updated the task description for T5372: assertion failure mulm_25519: different sizes in Libgrypt 1.9.
Please look at the code:
Sorry to dig up an old report...
Sorry to dig up an old thread...
Here's the patch I am using for the Apple M1: libgcrypt-darwin.patch. The patch is public domain so anyone is free to use it.
This is kind of a hack, but this patch:
Mar 28 2021
Mar 28 2021
Mar 26 2021
Mar 26 2021
Looks good to me, it no longer returns immediately with the error when there are no readers and the command itself seems to work. Thanks.
I noticed that my windows user folder contains Chinese character, and I rename that into English and seems like kleopatra works fine. GnuPG in cli cannot show Chinese folder name properly, thus I guess that's the reason why kleopatra exits without showing a gui.
Ah, I see that when there is no card reader, it returns "Service is not running" with PC/SC.
Let's fix that.
Mar 25 2021
Mar 25 2021
Thanks! Tested the above patches and now all the tests pass on the machine where I saw the failures.
Thanks for the report.
• ikloecker moved T5361: Kleopatra: No icon for Smartcard Management from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ikloecker added a project to T5361: Kleopatra: No icon for Smartcard Management: Restricted Project.
When testing under Windows "scd devinfo --watch" returns immediately with ERR 100663614 Service is not running <SCD>
Probably also if you would use PC/SC on Linux but I have not tested this.
I suppose that you installed the latest version of gpg4win. Please state the exact version you installed.
Mar 24 2021
Mar 24 2021
I have a minimal reproducer:
diff --git a/tests/basic.c b/tests/basic.c index 9a7e33cc..73ae01db 100644 --- a/tests/basic.c +++ b/tests/basic.c @@ -6346,11 +6346,152 @@ do_check_ocb_cipher (int inplace) "033ac4d13c3decc4c62d7de718ace802" "140452dc850989f6762e3578bbb04be3" "1a237c599c4649f4e586b2de" + }, + { GCRY_CIPHER_AES, 12, "0F0E0D0C0B0A09080706050403020100", + "BBAA9988776655443322110D", + "000102030405060708090A0B0C0D0E0F1011121314151617" + "18191A1B1C1D1E1F2021222324252627", + /* test vector for checksumming */ + "01000000000000000000000000000000" + "02000000000000000000000000000000" + "04000000000000000000000000000000" + "08000000000000000000000000000000" + "10000000000000000000000000000000" + "20000000000000000000000000000000" + "40000000000000000000000000000000" + "80000000000000000000000000000000" + "00010000000000000000000000000000" + "00020000000000000000000000000000" + "00040000000000000000000000000000" + "00080000000000000000000000000000" + "00100000000000000000000000000000" + "00200000000000000000000000000000" + "00400000000000000000000000000000" + "00800000000000000000000000000000" + "00000100000000000000000000000000" + "00000200000000000000000000000000" + "00000400000000000000000000000000" + "00000800000000000000000000000000" + "00001000000000000000000000000000" + "00002000000000000000000000000000" + "00004000000000000000000000000000" + "00008000000000000000000000000000" + "00000001000000000000000000000000" + "00000002000000000000000000000000" + "00000004000000000000000000000000" + "00000008000000000000000000000000" + "00000010000000000000000000000000" + "00000020000000000000000000000000" + "00000040000000000000000000000000" + "00000080000000000000000000000000" + "00000000010000000000000000000000" + "00000000020000000000000000000000" + "00000000040000000000000000000000" + "00000000080000000000000000000000" + "00000000100000000000000000000000" + "00000000200000000000000000000000" + "00000000400000000000000000000000" + "00000000800000000000000000000000" + "00000000000100000000000000000000" + "00000000000200000000000000000000" + "00000000000400000000000000000000" + "00000000000800000000000000000000" + "00000000001000000000000000000000" + "00000000002000000000000000000000" + "00000000004000000000000000000000" + "00000000008000000000000000000000" + "02000000000000000000000000000000" + "04000000000000000000000000000000" + "08000000000000000000000000000000" + "10000000000000000000000000000000" + "20000000000000000000000000000000" + "40000000000000000000000000000000" + "80000000000000000000000000000000" + "00010000000000000000000000000000" + "00020000000000000000000000000000" + "00040000000000000000000000000000" + "00080000000000000000000000000000" + "00100000000000000000000000000000" + "00200000000000000000000000000000" + "00400000000000000000000000000000" + "00800000000000000000000000000000" + "00000100000000000000000000000000" + "00000200000000000000000000000000" + "00000400000000000000000000000000" + "00000800000000000000000000000000", + "01105c6e36f6ac480f022c51e31ed702" + "90fda4b7b783194d4b4be8e4e1e2dff4" + "6a0804d1c5f9f808ea7933e31c063233" + "2bf65a22b20bb13cde3b80b3682ba965" + "b1207c58916f7856fa9968b410e50dee" + "98b35c071163d1b352b9bbccd09fde29" + "b850f40e71a8ae7d2e2d577f5ee39c46" + "7fa28130b50a123c29958e4665dda9a5" + "e0793997f8f19633a96392141d6e0e88" + "77850ed4364065d1d2f8746e2f1d5fd1" + "996cdde03215306503a30e41f58ef3c4" + "400365cfea4fa6381157c12a46598edf" + "18604854462ec66e3d3cf26d4723cb6a" + "9d801095048086a606fdb9192760889b" + "a8ce2e70e1b55a469137a9e2e6734565" + "283cb1e2c74f37e0854d03e33f8ba499" + "ef5d9af4edfce077c6280338f0a64286" + "2e6bc27ebd5a4c91b3778e22631251c8" + "c5bb75a10945597a9d6c274fc82d3338" + "b403a0a549d1375f26e71ef22bce0941" + "93ea87e2ed72fce0546148c351eec3be" + "867bb1b96070c377fff3c98e21562beb" + "475cfe28abcaaedf49981f6599b15140" + "ea6130d24407079f18ba9d4a8960b082" + "b39c57320e2e064f02fde88c23112146" + "1cac3655868aef584714826ee4f361fb" + "e6d692e1589cbb9dd3c74fa628df2a1f" + "3b0029b1d62b7e9978013ed3c793c1dd" + "1f184c8f7022a853cac40b74ac749aa3" + "f33f0d14732dfda0f2c3c20591bf1f5a" + "710ec0d0bca342baa5146068a78ff58c" + "66316312b7a98af35a0f4e92799b4047" + "f047ae61f25c28d232ce5c168cc745d6" + "6da13cb0f9e38a696635dba7a21571cf" + "cd64ec8cc33db7879f59a90d9edd00f6" + "a899e39ab36b9269a3ac04ebad9326bf" + "53cd9b400168a61714cd628a4056d236" + "bd8622c76daa54cb65f5db2fe03bafbe" + "0b23549ae31136f607293e8093a21934" + "74fd5e9c2451b4c8e0499e6ad34fafc8" + "ab77722a282f7f84b14ddebf7e696300" + "c1ef92d4a0263c6cca104530f996e272" + "f58992ff68d642b071a5848dc4acf2ae" + "28fb1f27ae0f297d5136a7a0a4a03e89" + "b588755b8217a1c62773790e69261269" + "19f45daf7b3ccf18e3fc590a9a0e172f" + "033ac4d13c3decc4c62d7de718ace802" + "140452dc850989f6762e3578bbb04be3" + "a8ae66427697167e85725b37b304baf0" + "56dbcef79fbb97cdfe1590e5f3d0bd1b" + "ce518f2f141960a1c80a4fe787b90b63" + "e7b0e0a0d8d522619130c544bb1abad0" + "b267c650e8916b5d7ececfeea7f0ad15" + "206a92581319946b138764f209109a20" + "0146b4cfb2ce8bd0db5c2cd5b495c56f" + "8f8a7934fe1f9add0674d4549080bf0d" + "01149ed18dbdccc5e54a3e7039546970" + "401ecc885902ee3dcfad504a68066f92" + "c779f1e1c48d37ba0e177ac652c1827b" + "f1f6723d533f0cdf36331e3ad1e1b1af" + "bc89a29c87fe3603353130d0dfbe1f29" + "13ad144e7c6515fb92005b6ece218b4f" + "baedc42d484fffee39df88041b49342a" + "6134cc7ca46d40d274c1ffafa98956e6" + "a492486989c4e328761c01798abcb09b" + "a42eb115334619daaeae9175f365fe9f" + "e5c3b254379d546005016784015f729f" + "4715ff6db16c5d16333e03fd" } }; gpg_error_t err = 0; gcry_cipher_hd_t hde, hdd; - unsigned char out[1024]; + unsigned char out[2048]; unsigned char tag[16]; int tidx;
Sorry, this is not a help line. Please use one of the the mailing lists or the gpg4win fori for ask for help.
Mar 23 2021
Mar 23 2021
I did a bit digging and it looks like the code path using accelerator is not hit because the test vecors have max ~48 blocks, but accelerator is involved only with 64 blocks and more if I read the code right. So we need 1) larger test vector to invoke this code path in libgcrypt 2) figure out what goes wrong there.