Patch lets it build on xenial for me, thank you.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jan 29 2021
Jan 28 2021
Patch for this bug is available here, "attachment-0001.bin": https://lists.gnupg.org/pipermail/gcrypt-devel/2021-January/005079.html
I committed the partial result docker container, so I can restart it for investigation. So:
I tested xenial with gcc-5.3 (xenial distro repo) and gcc-5.4 (xenial-updates distro repo) and libgcrypt 1.9.0 from git repo and from tarball. I did not get any errors.
Jan 27 2021
https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man2/posix_spawn.2.html dated August 9, 2007.
So, I guess that posix_spawn became available in MacOS X Leopard (10.5).
Also support older MacOS X, which has no posix_spawn.
Thanks @aheinecke for fixing my fix with 2859edd! Closing here.
Jan 26 2021
In T5264#142204, @jukivili wrote:I also needed this patch:
0001-global-fix-compile-error-at-pragma-GCC-diagnostic.patch2 KBDownloadI am going to check whether I need it on Tiger!
In T5264#142204, @jukivili wrote:I tested building on Ubuntu 8.04 (gcc-4.2) and got same error about cipher_bulk_ops_t. Applying patch fixed that problem.
I see now my mistake: I also have to re-write line #132 which I did not see yet!
With your other patch I still get:
libtool: compile: /opt/local/bin/gcc-apple-4.2 -DHAVE_CONFIG_H -I. -I.. -I../src -I../src -I../mpi -I../mpi -I/opt/local/include -I/opt/local/include -pipe -Os -std=gnu89 -arch ppc -fno-delete-null-pointer-checks -Wall -MT cipher.lo -MD -MP -MF .deps/cipher.Tpo -c cipher.c -fno-common -DPIC -o .libs/cipher.o In file included from cipher.c:31: ./cipher-internal.h:145: error: redefinition of typedef 'cipher_bulk_ops_t' ../src/cipher-proto.h:132: error: previous declaration of 'cipher_bulk_ops_t' was here
In T5264#142203, @jukivili wrote:Thanks for testing. However, I do not believe patch has been correctly applied.
The "Portfile" that conducts the build process has the patch contained, I sent you the list of files being patched, and here is the end of my translated patch set:
I tested building on Ubuntu 8.04 (gcc-4.2) and got same error about cipher_bulk_ops_t. Applying patch fixed that problem.
Thanks for testing. However, I do not believe patch has been correctly applied.
In T5264#142094, @jukivili wrote:Here's patch to try out:
0001-cipher-proto-remove-forward-typedef-of-cipher_bulk_o.patch6 KBDownload
T4702 is our release info task for 2.3.0
You should have received mail with additional log levels now
In T5264#142064, @jukivili wrote:In "src/cipher-proto.h", try removing typedef and leaving just forward declaration of structure.
Performing only this change leads consistently to the well-known error of:
In T5264#142059, @werner wrote:Do not use -fno-common
The translated bulk patch fails. Compilation still runs into this error:
In T5264#142094, @jukivili wrote:Here's patch to try out:
0001-cipher-proto-remove-forward-typedef-of-cipher_bulk_o.patch6 KBDownload
@gniibe Hi! Can you estimate, when this feature will be released?
I have not found this patch in the latest GnuPG release tags (in the Git repository) either by the name or the commit hash.
Thanks for the report. Some time ago I wrote the code in a way that when setting the HTML body failed it would fallback to the plain body, regardless of the preferences:
So even though there is an error that error is handled. https://dev.gnupg.org/source/gpgol/browse/master/src/mail.cpp;4d57033a095aecf8529606428efef6af466f1196$1488
Alright!
@ballapete when you have time, could you also test https://dev.gnupg.org/T5268#142155 on Tiger?
Jan 25 2021
Right now I am compiling with my old PowerBook in Tiger. In case a compilation fails I'll try this patch – on Tiger (Mac OS X 10.4.11)! It's a bit more primitive than Leopard.
Here's patch to try out:
BTW, we should better get back to the classic/GNU-coding-style pattern:
In "src/cipher-proto.h", try removing typedef and leaving just forward declaration of structure.
Do not use -fno-common
Jan 24 2021
Does attached patch help?
There’s a patch to restore support for Qt4: D521.
Jan 23 2021
My bad, prior to the release I tested only against Qt5.
I tried it - that doesn't help. Same error message.
Thanks for the report. As you noticed, issue had been reported already.
That might be helpful. But, on the other hand, if I had just googled the problem I was seeing I would have gotten answer quite fast.
Problem is in GET_DATA_POINTER macro. MacOS assembler expects data references in some different format than Linux. Could you try following edit and see if libgcrypt then compiles? In cipher/asm-common-aarch64.h, there is definition of GET_DATA_POINTER macro:
#ifdef _WIN32 #define GET_DATA_POINTER(reg, name) \ adrp reg, name ; \ add reg, reg, #:lo12:name ; #else #define GET_DATA_POINTER(reg, name) \ adrp reg, :got:name ; \ ldr reg, [reg, #:got_lo12:name] ; #endif
I have now tried to build libgcrypt 1.9.0 for arm64 using clang. I get the following error:
Jan 22 2021
It seems that this issue has already been reported with a better fix: https://lists.gnupg.org/pipermail/gcrypt-devel/2021-January/005060.html
Feel free to close this issue.