Page MenuHome GnuPG
Feed Advanced Search

Apr 15 2021

gniibe closed T5390: Italian translation GnuPG 2.3 as Resolved.

Thank you. Merged and pushed.

Apr 15 2021, 3:15 AM · i18n, gnupg (gpg23)

Apr 14 2021

gniibe committed rPa87d9e8f89f9: core,emacs,tty,curses: Fix memory leaks, invalid accese, and mistake. (authored by Jakuje).
core,emacs,tty,curses: Fix memory leaks, invalid accese, and mistake.
Apr 14 2021, 12:37 PM
gniibe closed T5384: pinentry coverity static analysis reports as Resolved.

Applied and pushed.

Apr 14 2021, 8:58 AM · pinentry, Bug Report
gniibe added a comment to T5393: gnupg coverity static analysis reports.

@werner No problem. Just go ahead.

Apr 14 2021, 1:45 AM · gnupg (gpg23), Bug Report

Apr 13 2021

gniibe closed T3416: gpg should select available signing key on card (even with -u option) as Resolved.

Done in 2.3.0.

Apr 13 2021, 8:07 AM · Restricted Project, Feature Request, gnupg
gniibe closed T3416: gpg should select available signing key on card (even with -u option), a subtask of T2291: Smartcard interaction improvement (was: Shadowed private key design (for smartcard)), as Resolved.
Apr 13 2021, 8:07 AM · Restricted Project, gnupg, Feature Request
gniibe closed T4695: Remove SERIALNO as an identifier to select keys, a subtask of T2291: Smartcard interaction improvement (was: Shadowed private key design (for smartcard)), as Resolved.
Apr 13 2021, 8:06 AM · Restricted Project, gnupg, Feature Request
gniibe closed T4695: Remove SERIALNO as an identifier to select keys as Resolved.

Done in 2.3.0.

Apr 13 2021, 8:06 AM · Restricted Project, Feature Request, gnupg
gniibe closed T2291: Smartcard interaction improvement (was: Shadowed private key design (for smartcard)) as Resolved.

Done in 2.3.

Apr 13 2021, 8:05 AM · Restricted Project, gnupg, Feature Request
gniibe committed rGa16f726f9404: common: Fix memory leaks. (authored by Jakuje).
common: Fix memory leaks.
Apr 13 2021, 8:02 AM
gniibe committed rG7cbe29c4fb4f: scd: Fix memory leaks. (authored by Jakuje).
scd: Fix memory leaks.
Apr 13 2021, 8:02 AM
gniibe committed rG51bbd99a3c9b: kbx: Fix memory leak. (authored by Jakuje).
kbx: Fix memory leak.
Apr 13 2021, 8:02 AM
gniibe committed rG4c8be54cc430: tools: Fix memory leaks. (authored by Jakuje).
tools: Fix memory leaks.
Apr 13 2021, 8:02 AM
gniibe added a comment to T5393: gnupg coverity static analysis reports.

Thank you.

Apr 13 2021, 8:02 AM · gnupg (gpg23), Bug Report
gniibe claimed T5393: gnupg coverity static analysis reports.
Apr 13 2021, 7:12 AM · gnupg (gpg23), Bug Report
gniibe closed T5389: gnupg 2.3 missing libassuan include directory in CFLAGS for several targets as Resolved.

Thank you. Applied and pushed.

Apr 13 2021, 6:59 AM · gnupg (gpg23), Bug Report
gniibe committed rGcd66b2eb0d34: agent,kbx: Add LIBASSUAN_CLFAGS. (authored by Jakuje).
agent,kbx: Add LIBASSUAN_CLFAGS.
Apr 13 2021, 6:58 AM
gniibe committed rC9c42db0b379c: api: Avoid use of C99 feature. (authored by gniibe).
api: Avoid use of C99 feature.
Apr 13 2021, 4:00 AM
gniibe changed the status of T5372: assertion failure mulm_25519: different sizes in Libgrypt 1.9 from Open to Testing.
Apr 13 2021, 3:16 AM · !assert, Bug Report, libgcrypt
gniibe changed the status of T5375: getentropy usage is forbidden by Apple, but is now being forced by libgcrypt from Open to Testing.
Apr 13 2021, 3:16 AM · MacOS, libgcrypt
gniibe committed rC0007f889bda8: random: Fix for iOS. (authored by gniibe).
random: Fix for iOS.
Apr 13 2021, 3:15 AM
gniibe committed rCe8b7f10be275: cipher: Hardening ElGamal by introducing exponent blinding too. (authored by gniibe).
cipher: Hardening ElGamal by introducing exponent blinding too.
Apr 13 2021, 3:15 AM
gniibe claimed T5384: pinentry coverity static analysis reports.

Thank you. I'll take care of this.

Apr 13 2021, 3:01 AM · pinentry, Bug Report

Apr 12 2021

gniibe closed T4888: GpgSM: Support ECC key generation by gpgsm_genkey, a subtask of T4098: GpgSM: Add ECC support, as Resolved.
Apr 12 2021, 12:21 PM · gnupg (gpg23), Feature Request, S/MIME
gniibe closed T4888: GpgSM: Support ECC key generation by gpgsm_genkey as Resolved.
Apr 12 2021, 12:21 PM · Restricted Project, Feature Request, S/MIME
gniibe added a comment to T5328: On the (in)security of Elgamal in OpenPGP.

Do we have CVE number assigned?

Apr 12 2021, 7:52 AM · side-channel, CVE, libgcrypt
gniibe claimed T5380: Tools needed during a build lack of CFLAGS was passed durring configure time.
Apr 12 2021, 7:51 AM · MacOS, Bug Report
gniibe claimed T5389: gnupg 2.3 missing libassuan include directory in CFLAGS for several targets.
Apr 12 2021, 7:05 AM · gnupg (gpg23), Bug Report
gniibe changed the status of T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection from Open to Testing.
Apr 12 2021, 6:13 AM · MacOS, gpgrt, Cross-Compiler, libgcrypt
gniibe closed T5381: libgpg-error coverity static analysis reports as Resolved.

Thank you for your publishing your key of CB6BE1D0D7D1594A.
I applied and pushed your changes.

Apr 12 2021, 6:08 AM · gpgrt, Bug Report
gniibe committed rEad062b0a5b7d: build,tests: Fix leaks of memory or file pointer. (authored by Jakuje).
build,tests: Fix leaks of memory or file pointer.
Apr 12 2021, 6:08 AM
gniibe committed rG304c2e0202dd: doc: Register DCO for Jakub Jelen. (authored by gniibe).
doc: Register DCO for Jakub Jelen.
Apr 12 2021, 5:57 AM

Apr 9 2021

gniibe added a comment to T5381: libgpg-error coverity static analysis reports.

Thanks. Note, that the same code is in gnupg2 in common/exechelp-posix.c:736

Apr 9 2021, 1:45 AM · gpgrt, Bug Report

Apr 8 2021

gniibe committed rG36355394d865: gpg: Ed448 and X448 are only for v5. (authored by gniibe).
gpg: Ed448 and X448 are only for v5.
Apr 8 2021, 9:52 AM
gniibe committed rGb0a7132856ef: po: Update Simplified Chinese Translation. (authored by bobwxc).
po: Update Simplified Chinese Translation.
Apr 8 2021, 6:58 AM
gniibe committed rGf8ae51977ce4: scd: Fix CCID driver for SCM SPR332/SPR532. (authored by gniibe).
scd: Fix CCID driver for SCM SPR332/SPR532.
Apr 8 2021, 6:50 AM
gniibe claimed T5297: SCM SPR332 smartcard reader support broken.

Thank you.
Applied both to STABLE-BRANCH-2-2 and master (changing new function name).

Apr 8 2021, 6:50 AM · gnupg (gpg22), scd, Bug Report
gniibe committed rGab66c4357595: scd: Fix CCID driver for SCM SPR332/SPR532. (authored by gniibe).
scd: Fix CCID driver for SCM SPR332/SPR532.
Apr 8 2021, 6:44 AM
gniibe added a comment to T5328: On the (in)security of Elgamal in OpenPGP.

So, in my opinion, applying the patch for ElGamal exponent blinding is enough (for now).

Apr 8 2021, 6:22 AM · side-channel, CVE, libgcrypt
gniibe added a comment to T5328: On the (in)security of Elgamal in OpenPGP.

For DSA, I had assumed similar attack could be effective.

Apr 8 2021, 6:22 AM · side-channel, CVE, libgcrypt
gniibe added a comment to T5380: Tools needed during a build lack of CFLAGS was passed durring configure time.

CC_FOR_BUILD is used for building executables for the build machine.
CC_FOR_BUILD may be different to CC (for target).

Apr 8 2021, 6:09 AM · MacOS, Bug Report
gniibe committed rGd82dae5d2229: common: Fix gnupg_wait_processes, by skipping invalid PID. (authored by gniibe).
common: Fix gnupg_wait_processes, by skipping invalid PID.
Apr 8 2021, 4:29 AM
gniibe added a comment to T5381: libgpg-error coverity static analysis reports.

For gpgrt_wait_processes, I modified it to skip invalid PID.
The change is: rE956c40f106ea: core: Fix gpgrt_wait_processes, by skipping invalid PID.

Apr 8 2021, 4:26 AM · gpgrt, Bug Report
gniibe committed rE956c40f106ea: core: Fix gpgrt_wait_processes, by skipping invalid PID. (authored by gniibe).
core: Fix gpgrt_wait_processes, by skipping invalid PID.
Apr 8 2021, 4:15 AM
gniibe committed rGac1e159397a7: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Apr 8 2021, 3:24 AM

Apr 7 2021

gniibe committed rE89a353f418f5: build: Fix gpgrt-config for handling 'Requires' field. (authored by gniibe).
build: Fix gpgrt-config for handling 'Requires' field.
Apr 7 2021, 10:26 AM
gniibe added a comment to T5381: libgpg-error coverity static analysis reports.

Thank you.
For get_attr_l, I pushed a fix as rE89a353f418f5: build: Fix gpgrt-config for handling 'Requires' field.

Apr 7 2021, 10:25 AM · gpgrt, Bug Report

Apr 2 2021

gniibe committed rC840713de1a68: cipher: Return GPG_ERR_INV_KEYLEN when wrong key length. (authored by gniibe).
cipher: Return GPG_ERR_INV_KEYLEN when wrong key length.
Apr 2 2021, 3:15 AM

Apr 1 2021

gniibe triaged T5375: getentropy usage is forbidden by Apple, but is now being forced by libgcrypt as Normal priority.
Apr 1 2021, 6:39 AM · MacOS, libgcrypt
gniibe added a comment to T5375: getentropy usage is forbidden by Apple, but is now being forced by libgcrypt.

IIUC... Could you please try this patch?

diff --git a/random/rndlinux.c b/random/rndlinux.c
index a7a78906..c20c5d4c 100644
--- a/random/rndlinux.c
+++ b/random/rndlinux.c
@@ -35,10 +35,13 @@
 #if defined(__APPLE__) && defined(__MACH__)
 #include <Availability.h>
 #ifdef __MAC_10_11
+#include <TargetConditionals.h>
+#if !defined(TARGET_OS_IPHONE) || TARGET_OS_IPHONE == 0
 extern int getentropy (void *buf, size_t buflen) __attribute__ ((weak_import));
 #define HAVE_GETENTROPY
 #endif
 #endif
+#endif
 #if defined(__linux__) || !defined(HAVE_GETENTROPY)
 #ifdef HAVE_SYSCALL
 # include <sys/syscall.h>
Apr 1 2021, 6:36 AM · MacOS, libgcrypt
gniibe claimed T5375: getentropy usage is forbidden by Apple, but is now being forced by libgcrypt.
Apr 1 2021, 5:58 AM · MacOS, libgcrypt
gniibe closed T5289: gen-lock-obj.sh uses echo -n from /bin/sh, which echos "-n" as Resolved.

Fixed in 1.42.

Apr 1 2021, 5:58 AM · MacOS, gpgrt, Bug Report

Mar 31 2021

gniibe added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

I was wrong in my last comment. Escaping by another \ is needed.

Mar 31 2021, 4:09 AM · MacOS, gpgrt, Cross-Compiler, libgcrypt
gniibe committed rG8d6152a4cfd8: build: Update gpg-error.m4. (authored by gniibe).
build: Update gpg-error.m4.
Mar 31 2021, 3:38 AM
gniibe committed rCd2b3d046fc66: build: Update gpg-error.m4. (authored by gniibe).
build: Update gpg-error.m4.
Mar 31 2021, 3:35 AM
gniibe committed rE8536f82194ec: m4: Fix previous commit. (authored by gniibe).
m4: Fix previous commit.
Mar 31 2021, 3:33 AM
gniibe committed rE9b9c5dfa1020: m4: Support cross-compiling better. (authored by gniibe).
m4: Support cross-compiling better.
Mar 31 2021, 3:23 AM

Mar 30 2021

gniibe added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

Or, if we keep the code of newline (so that it will eventually support path with a space in future):

Mar 30 2021, 9:55 AM · MacOS, gpgrt, Cross-Compiler, libgcrypt
gniibe added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

Thank you. Sorry for the use of GNU sed extension. It could be just a whitespace, if it's OK not to support path having a space.
sed -n -e "/^libraries/{s/libraries: =//;s/:/ /gp}") should work.

Mar 30 2021, 9:42 AM · MacOS, gpgrt, Cross-Compiler, libgcrypt
gniibe added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

I wonder if this works in your use case:

diff --git a/m4/gpg-error.m4 b/m4/gpg-error.m4
index d910754e..aeedaf10 100644
--- a/m4/gpg-error.m4
+++ b/m4/gpg-error.m4
@@ -65,7 +65,7 @@ AC_DEFUN([AM_PATH_GPG_ERROR],
   min_gpg_error_version=ifelse([$1], ,1.33,$1)
   ok=no
Mar 30 2021, 7:36 AM · MacOS, gpgrt, Cross-Compiler, libgcrypt
gniibe added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

If it is new, it may be the change of this commit rC8e3cd4c4677c: build: Update gpg-error.m4.

Mar 30 2021, 7:22 AM · MacOS, gpgrt, Cross-Compiler, libgcrypt
gniibe claimed T5372: assertion failure mulm_25519: different sizes in Libgrypt 1.9.
Mar 30 2021, 5:56 AM · !assert, Bug Report, libgcrypt
gniibe committed rGd1bac0a3be70: build: Fix for make distcheck, no EPS support. (authored by gniibe).
build: Fix for make distcheck, no EPS support.
Mar 30 2021, 5:41 AM
gniibe committed rC35917373d645: build: Fix for make distcheck, no EPS support. (authored by gniibe).
build: Fix for make distcheck, no EPS support.
Mar 30 2021, 5:07 AM
gniibe triaged T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection as Normal priority.

We are in transition from old gpg-error-config to new gpgrt-config. <-- This is the cause, while I tried to cover most use cases.

Mar 30 2021, 4:19 AM · MacOS, gpgrt, Cross-Compiler, libgcrypt
gniibe committed rC45e88b8ec6df: ecc: Fix the regression of gcry_mpi_ec_add. (authored by gniibe).
ecc: Fix the regression of gcry_mpi_ec_add.
Mar 30 2021, 3:53 AM
gniibe added a comment to T5372: assertion failure mulm_25519: different sizes in Libgrypt 1.9.

The optimization introduced for curve 25519 and curve 448 en-bugged for usage of direct MPI.

Mar 30 2021, 3:37 AM · !assert, Bug Report, libgcrypt

Mar 26 2021

gniibe committed rS7da084640636: build: Fix for make distcheck. (authored by gniibe).
build: Fix for make distcheck.
Mar 26 2021, 9:38 AM
gniibe added a comment to T5358: scute: Errors when building 1.7.

It's OK not supporting generation in PostScript format.
Thus, we can remove image_eps support.
Then, convert is not required any more.

Mar 26 2021, 8:25 AM · scute
gniibe committed rE33593864cd54: build: Fix generation of lock-obj-pub.native.h for cross build. (authored by David Michael <fedora.dm0@gmail.com>).
build: Fix generation of lock-obj-pub.native.h for cross build.
Mar 26 2021, 8:23 AM
gniibe committed rS9a5f29da90dc: build: Don't require ImageMagick anymore for building document. (authored by gniibe).
build: Don't require ImageMagick anymore for building document.
Mar 26 2021, 8:23 AM
gniibe committed rGd4e5979c630c: scd: Fix PC/SC error handling at apdu_dev_list_start. (authored by gniibe).
scd: Fix PC/SC error handling at apdu_dev_list_start.
Mar 26 2021, 3:28 AM
gniibe added a comment to T4864: New scdaemon command to watch device removal.

Ah, I see that when there is no card reader, it returns "Service is not running" with PC/SC.
Let's fix that.

Mar 26 2021, 2:34 AM · Restricted Project, Feature Request, scd, Bug Report

Mar 25 2021

gniibe committed rCcf88dca06991: build: Revert the previous commit. (authored by gniibe).
build: Revert the previous commit.
Mar 25 2021, 9:09 AM
gniibe committed rC52f6e9515988: build: Remove intermediate PDF files from EXTRA_DIST. (authored by gniibe).
build: Remove intermediate PDF files from EXTRA_DIST.
Mar 25 2021, 8:53 AM

Mar 24 2021

gniibe committed rG14ef703ad658: gpg: Fix v5 signature for clearsign. (authored by gniibe).
gpg: Fix v5 signature for clearsign.
Mar 24 2021, 7:51 AM
gniibe committed rG90a5b4e648b3: gpg: Support ECDH with v5 key. (authored by gniibe).
gpg: Support ECDH with v5 key.
Mar 24 2021, 6:54 AM

Mar 23 2021

gniibe committed rT64f895dba734: Support X25519 and X448. (authored by gniibe).
Support X25519 and X448.
Mar 23 2021, 9:34 AM

Mar 22 2021

gniibe committed rG1524a942b645: gpg: Support exporting Ed448 SSH key. (authored by gniibe).
gpg: Support exporting Ed448 SSH key.
Mar 22 2021, 9:04 AM
gniibe committed rG0b45c5a99410: gpg: Fix exporting SSH key. (authored by gniibe).
gpg: Fix exporting SSH key.
Mar 22 2021, 9:04 AM

Mar 15 2021

gniibe committed rGb743942a9719: scd: Add handling of Ed448 key. (authored by gniibe).
scd: Add handling of Ed448 key.
Mar 15 2021, 9:12 AM
gniibe committed rGf482e4bd121f: scd: Fix count_sos_bits handling. (authored by gniibe).
scd: Fix count_sos_bits handling.
Mar 15 2021, 9:12 AM
gniibe committed rG373b52e69a6c: common: Fix the NBITS of Ed448in OIDTABLE. (authored by gniibe).
common: Fix the NBITS of Ed448in OIDTABLE.
Mar 15 2021, 8:55 AM

Mar 12 2021

gniibe committed rG95156ef9bfb6: scd: Fix computing fingerprint for ECC with SOS. (authored by gniibe).
scd: Fix computing fingerprint for ECC with SOS.
Mar 12 2021, 8:23 AM
gniibe committed rGcfc1497efa8c: gpg: Fix compute_fingerprint for ECC with SOS. (authored by gniibe).
gpg: Fix compute_fingerprint for ECC with SOS.
Mar 12 2021, 8:16 AM

Mar 8 2021

gniibe committed rGfc99f77b14b6: scd: Fix for X448. (authored by gniibe).
scd: Fix for X448.
Mar 8 2021, 8:27 AM

Mar 3 2021

gniibe renamed T5331: Possibly incompatible Ed25519 signature between other implementations and 2.3-bata from Incompatible Ed25519 signature between GnuPG 2.2 and 2.3-bata to Possibly incompatible Ed25519 signature between other implementations and 2.3-bata.
Mar 3 2021, 8:50 AM · gnupg (gpg23), Bug Report
gniibe added a comment to T5331: Possibly incompatible Ed25519 signature between other implementations and 2.3-bata.
========= 0110.asc ==========
# off=0 ctb=88 tag=2 hlen=2 plen=117
:signature packet: algo 22, keyid E267B052364F028D
	version 4, created 1614755507, md5len 0, sigclass 0x01
	digest algo 10, begin of digest 4f 78
	hashed subpkt 33 len 21 (issuer fpr v4 249CB3771750745D5CDD323CE267B052364F028D)
	hashed subpkt 2 len 4 (sig created 2021-03-03)
	subpkt 16 len 8 (issuer key ID E267B052364F028D)
	data: ADEE890B755C3B52D46FB0105097F23B5905B472C626222ACB4E441D8EB40001
	data: 007119FF80C34DA152BDB07E1EF5D968CB9F2773002A0CF57911670BE248CF06
========= 0354.asc ==========
# off=0 ctb=88 tag=2 hlen=2 plen=117
:signature packet: algo 22, keyid E267B052364F028D
	version 4, created 1614755520, md5len 0, sigclass 0x01
	digest algo 10, begin of digest 28 19
	hashed subpkt 33 len 21 (issuer fpr v4 249CB3771750745D5CDD323CE267B052364F028D)
	hashed subpkt 2 len 4 (sig created 2021-03-03)
	subpkt 16 len 8 (issuer key ID E267B052364F028D)
	data: 001DB3839E3FD8D4CB81357EE5E42F4AF652C252A03A0FB21768621B1025C08C
	data: AF5A0910EF1D4D6BDD07EA0AA6D69049CB7BA7ED42427E14B8B72CF2C2231704
Mar 3 2021, 8:25 AM · gnupg (gpg23), Bug Report
gniibe added a comment to T5331: Possibly incompatible Ed25519 signature between other implementations and 2.3-bata.

Here are example files produced by GnuPG 2.3-beta:
S part has preceding zero:


R part has preceding zero:

Mar 3 2021, 8:22 AM · gnupg (gpg23), Bug Report

Mar 1 2021

gniibe added a comment to T5331: Possibly incompatible Ed25519 signature between other implementations and 2.3-bata.

We could add compatibility mode for Ed25519 signature to conform well-formed MPI (expecting recovery).

Mar 1 2021, 9:30 AM · gnupg (gpg23), Bug Report
gniibe created T5331: Possibly incompatible Ed25519 signature between other implementations and 2.3-bata.
Mar 1 2021, 9:15 AM · gnupg (gpg23), Bug Report

Feb 26 2021

gniibe accepted D528: po: Update Simplified Chinese Translation..

Thank you. Applied and pushed.

Feb 26 2021, 4:02 AM
gniibe committed rGf5897b3d2448: po: Update Simplified Chinese Translation. (authored by bobwxc).
po: Update Simplified Chinese Translation.
Feb 26 2021, 4:01 AM

Feb 25 2021

gniibe added inline comments to D528: po: Update Simplified Chinese Translation..
Feb 25 2021, 12:49 AM

Feb 19 2021

gniibe committed rG8d5a9c858d97: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Feb 19 2021, 3:40 AM
gniibe added a comment to T4363: Availability of FST-01SZ in Europe.

For the pogo-pin test clip to flash, it is available in China.

Feb 19 2021, 1:21 AM · Verein

Feb 18 2021

gniibe committed rE1fb90a7da186: build: Support --disable-threads by gen-lock-obj.sh. (authored by gniibe).
build: Support --disable-threads by gen-lock-obj.sh.
Feb 18 2021, 2:26 AM
gniibe changed the status of T5296: libgpg-error: build failure without threads from Open to Testing.

Pushed the change. Please test.

Feb 18 2021, 2:24 AM · gpgrt, Bug Report
gniibe added a comment to T5296: libgpg-error: build failure without threads.

See the comment in rE13918d05a333: Allow building with --disable-threads. for ABI incompatibility.

Feb 18 2021, 2:24 AM · gpgrt, Bug Report
gniibe added a comment to T1756: gpg-agent doesn't accept ssh certificates.

I'm sorry, if my wording sounded harsh.

Feb 18 2021, 1:50 AM · gnupg, Feature Request