Page MenuHome GnuPG
Feed Advanced Search

Sep 22 2021

ikloecker added a comment to T5613: GpgEX does not use CSIDL_LOCAL_APPDATA.

Alternative patch for Kleopatra:

diff --git a/src/uiserver/uiserver.cpp b/src/uiserver/uiserver.cpp
index d9746f0b..ab4d2ca7 100644
--- a/src/uiserver/uiserver.cpp
+++ b/src/uiserver/uiserver.cpp
@@ -23,6 +23,8 @@
 #include "kleopatra_debug.h"
 #include <KLocalizedString>
Sep 22 2021, 4:45 PM · Windows, kleopatra, gpgex
ikloecker added a comment to T5613: GpgEX does not use CSIDL_LOCAL_APPDATA.

Not from understanding. libkleo adds high-level functionality that's useful for KDE applications, but out-of-scope for gpgme and its C++/Qt wrappers gpgme++ and qgpgme. I would use GpgME::dirInfo() directly in Kleopatra. It would make sense to add an overload of GpgME::dirInfo() that takes an enum, so that one does not have to use the low-level string names in Kleopatra. The downside is that a string-based interface can be extended easily. OTOH, deprecating values of a string-based interface is hard and after removing it the compiler won't complain.

Sep 22 2021, 4:24 PM · Windows, kleopatra, gpgex
ikloecker added a comment to T5613: GpgEX does not use CSIDL_LOCAL_APPDATA.

gpgme_get_dirinfo does already have support for "uiserver-socket" since about 7 years. I don't think a separate "socketdir" which requires a brand new gpgme makes much sense.

Sep 22 2021, 4:02 PM · Windows, kleopatra, gpgex

Sep 20 2021

ikloecker added a comment to T5607: Fingerprint signing fails with 'gpg: signing failed: No secret key'.

When you sign data, then the signing subkey is used

ssb>  rsa4096/0xEB0B4DFC657EF670 2016-04-01 [S]
Sep 20 2021, 6:15 PM · Support, Info Needed, gnupg (gpg22)
ikloecker committed rGe2069d563283: build: Fix several "include file not found" problems (authored by ikloecker).
build: Fix several "include file not found" problems
Sep 20 2021, 12:40 PM
ikloecker closed T5473: Libkleo build for Windows broken as Resolved.
Sep 20 2021, 10:36 AM · kleopatra, Restricted Project
ikloecker added a comment to rKLEOPATRA107abfdb1a41: Hide create openpgp key from card command for <2.3.

I thought that I had tested this with some 2.2.x version of gpg. But if it doesn't work with 2.2.31, then I probably didn't and just relied on the release notes.

Sep 20 2021, 9:58 AM
ikloecker added a comment to rKLEOPATRA533c11c5247f: Align the recipient selection at the top.

Hmm, I had removed a stretch there because I thought that a stretch in the middle of the dialog looks bad. Usually, vertical stretches are added just before the button row.

Sep 20 2021, 9:54 AM

Sep 15 2021

ikloecker created T5599: Make gpg use the helpers baked into its AppImage.
Sep 15 2021, 1:29 PM · gnupg, Restricted Project, Feature Request
ikloecker added a comment to T5598: AppImage of gpg.

One challenge of the AppImage is how to make gpg and its helpers use the helpers baked into the AppImage. Currently, everything is built with prefix /build/AppDir/usr. This causes

gpg: failed to start agent '/build/AppDir/usr/bin/gpg-agent': No such file or directory

unless gpg finds an already running agent.

Sep 15 2021, 1:25 PM · AppImage, gnupg, Restricted Project, Feature Request
ikloecker triaged T5598: AppImage of gpg as High priority.
Sep 15 2021, 9:29 AM · AppImage, gnupg, Restricted Project, Feature Request

Sep 14 2021

ikloecker committed rPc68d80e23a86: qt: Support building with Qt 5.9 (authored by ikloecker).
qt: Support building with Qt 5.9
Sep 14 2021, 8:06 PM
ikloecker committed rMab9bca09eb86: qt: Fix build against Qt 5.9 (authored by ikloecker).
qt: Fix build against Qt 5.9
Sep 14 2021, 6:34 PM

Sep 13 2021

ikloecker added a comment to T5574: Doubled characters in Windows console output.

Symmetric decryption is broken in 2.3.2. See T5577: Null ptr dereference in gpg-agent (gnupg 2.3.2). Try 2.3.1.

Sep 13 2021, 12:34 PM · gnupg, Windows, Bug Report

Sep 10 2021

ikloecker added a comment to T5595: gpgrt-config doesn't work well with PKG_CONFIG_LIBDIR="" and setting PKG_CONFIG_PATH.

The fix works for me (using bash on openSUSE Tumbleweed).

Sep 10 2021, 12:26 PM · gpgrt
ikloecker committed rKLEOPATRAba72eadef0a8: Use correct name for third number of RELEASE_SERVICE_VERSION (authored by ikloecker).
Use correct name for third number of RELEASE_SERVICE_VERSION
Sep 10 2021, 9:53 AM
ikloecker committed rKLEOPATRAcbd5aefd99cc: Fix duplicate release versions (authored by Nicolas Fella <nicolas.fella@gmx.de>).
Fix duplicate release versions
Sep 10 2021, 9:31 AM
ikloecker committed rKLEOPATRA0f4efe1124d5: Fix version number (authored by ikloecker).
Fix version number
Sep 10 2021, 9:31 AM
ikloecker committed rKLEOPATRAb0565ac2a3c4: Use correct name for third number of RELEASE_SERVICE_VERSION (authored by ikloecker).
Use correct name for third number of RELEASE_SERVICE_VERSION
Sep 10 2021, 9:31 AM

Sep 8 2021

ikloecker committed rG08f227052fa3: build: Fix "ksba.h not found" problem (authored by ikloecker).
build: Fix "ksba.h not found" problem
Sep 8 2021, 3:21 PM
ikloecker changed the status of T5535: Kleopatra: Check that accessibility is also supported for VS-NfD from Open to Testing.

Finishing development for now.

Sep 8 2021, 10:52 AM · Restricted Project, kleopatra
ikloecker claimed T5592: AppImage of Kleopatra.
Sep 8 2021, 10:49 AM · Restricted Project, kleopatra, Feature Request
ikloecker created T5592: AppImage of Kleopatra.
Sep 8 2021, 10:48 AM · Restricted Project, kleopatra, Feature Request
ikloecker closed T5591: How to build Gpgmepp in Windows 10 as Invalid.

Please talk to the KDE folks who develop Craft. We do not support building anything with Craft. Check out gpg4win (https://dev.gnupg.org/source/gpg4win/) to see how we build our products on Windows.

Sep 8 2021, 10:39 AM · Cross-Compiler, gpgme
ikloecker added a comment to T5589: add context menu for normal operation after installation.

Which product do you refer to? Kleopatra? gpg4win? Something else?
Which operating system are you using? Windows? Linux? Something else?

Sep 8 2021, 10:29 AM · Installer, FAQ, gpg4win

Sep 7 2021

ikloecker committed rKLEOPATRA69f69c15715c: Revert "Add widget parent" (authored by ikloecker).
Revert "Add widget parent"
Sep 7 2021, 9:44 AM
ikloecker added a reverting change for rKLEOPATRAa4a84b9a3b48: Add widget parent: rKLEOPATRA69f69c15715c: Revert "Add widget parent".
Sep 7 2021, 9:44 AM
ikloecker accepted rKLEOPATRA966b5db50d72: Avoid use of private Qt API by dropping workaround in accessibleWidgetFactory.

I have approved the commit in KDE's GitLab. For details see https://invent.kde.org/pim/kleopatra/-/merge_requests/8

Sep 7 2021, 9:19 AM

Sep 6 2021

ikloecker committed rKLEOPATRA69aa9861643c: Improve accessibility of decryption result overview and details (authored by ikloecker).
Improve accessibility of decryption result overview and details
Sep 6 2021, 6:56 PM
ikloecker committed rKLEOPATRAa40973a644d5: Minor cleanup (authored by ikloecker).
Minor cleanup
Sep 6 2021, 6:56 PM
ikloecker added a comment to rGb89b1f35c29c: agent: Ignore passphrase constraints for a generated passphrase..

This commit breaks decryption of symmetrically encrypted data. gpg-agent segfaults after one has entered the passphrase in pinentry.

Sep 6 2021, 5:29 PM
ikloecker committed rKLEOPATRAf59e713f708e: Avoid use of private Qt API by dropping workaround in accessibleWidgetFactory (authored by fvogt).
Avoid use of private Qt API by dropping workaround in accessibleWidgetFactory
Sep 6 2021, 10:08 AM

Sep 3 2021

ikloecker committed rKLEOPATRAfb35f8a7d4b0: Ensure that the link is readable even on the blue "success" background (authored by ikloecker).
Ensure that the link is readable even on the blue "success" background
Sep 3 2021, 4:39 PM
ikloecker committed rKLEOPATRA2ac361b46f13: Allow setting the color of the rendered link (authored by ikloecker).
Allow setting the color of the rendered link
Sep 3 2021, 4:39 PM
ikloecker committed rKLEOPATRA3464ec148c3e: Ensure correct focus order of the result item widgets (authored by ikloecker).
Ensure correct focus order of the result item widgets
Sep 3 2021, 4:39 PM
ikloecker committed rKLEOPATRAcbbcbbfb6861: Show information about recipients also if decryption didn't succeed (authored by ikloecker).
Show information about recipients also if decryption didn't succeed
Sep 3 2021, 4:39 PM
ikloecker committed rKLEOPATRA49cd0070652f: Create scroll area together with the other child widgets (authored by ikloecker).
Create scroll area together with the other child widgets
Sep 3 2021, 4:39 PM
ikloecker committed rKLEOPATRAd031959ef156: Move "No MDC" hint before information on recipients (authored by ikloecker).
Move "No MDC" hint before information on recipients
Sep 3 2021, 4:39 PM
ikloecker committed rKLEOPATRAd0d25f717d5c: Exit early if decryption failed or was canceled (authored by ikloecker).
Exit early if decryption failed or was canceled
Sep 3 2021, 4:39 PM
ikloecker committed rKLEOPATRAcefdbaaeee23: Improve accessibility if no or multiple certificates match (authored by ikloecker).
Improve accessibility if no or multiple certificates match
Sep 3 2021, 4:39 PM
ikloecker committed rKLEOPATRA6c3c904a9b40: Show more decryption details if decryption was successful (authored by ikloecker).
Show more decryption details if decryption was successful
Sep 3 2021, 4:39 PM
ikloecker added a comment to T5585: Passphrase File Carriage Return New Line \r\n Issue in Windows.

The OP wants to do symmetric encryption. This isn't about the passphrase that protects a key.

Sep 3 2021, 9:57 AM · Documentation, gnupg, Bug Report

Sep 2 2021

ikloecker added a comment to T5584: gpg --list-packets lists wrong packets.

The actual problem is not that --list-packets produces weird output, but that --decrypt fails with

gpg: [don't know]: invalid packet (ctb=4f)
[GNUPG:] NODATA 3

causing confusing errors in Kleopatra.

Sep 2 2021, 11:46 AM · gnupg (gpg22), Bug Report
ikloecker added a comment to T5584: gpg --list-packets lists wrong packets.

Sep 2 2021, 11:42 AM · gnupg (gpg22), Bug Report
ikloecker created T5584: gpg --list-packets lists wrong packets.
Sep 2 2021, 11:42 AM · gnupg (gpg22), Bug Report
ikloecker committed rKLEOPATRAeaae2c4754fd: Improve accessibility of Diagnostics/Show Audit Log label (authored by ikloecker).
Improve accessibility of Diagnostics/Show Audit Log label
Sep 2 2021, 12:10 AM

Sep 1 2021

aheinecke awarded T5582: Kleopatra: Error when unchecking encrypt for others in file encryption dialog a Like token.
Sep 1 2021, 12:13 PM · kleopatra, Restricted Project
ikloecker closed T5582: Kleopatra: Error when unchecking encrypt for others in file encryption dialog as Resolved.
Sep 1 2021, 11:57 AM · kleopatra, Restricted Project
ikloecker committed rKLEOPATRA04170a835f8d: Fix validation of recipient keys (authored by ikloecker).
Fix validation of recipient keys
Sep 1 2021, 11:56 AM
ikloecker renamed T5582: Kleopatra: Error when unchecking encrypt for others in file encryption dialog from Kleopatra: Error when unchecking decrypt for others in file encryption dialog to Kleopatra: Error when unchecking encrypt for others in file encryption dialog.
Sep 1 2021, 11:52 AM · kleopatra, Restricted Project

Aug 26 2021

ikloecker committed rLIBKLEO1792abbe0ce4: Make the Close button the default button of the dialog (authored by ikloecker).
Make the Close button the default button of the dialog
Aug 26 2021, 4:49 PM
ikloecker committed rLIBKLEOe8fb46f9a46e: Add workaround for broken tab order of dialog buttons (authored by ikloecker).
Add workaround for broken tab order of dialog buttons
Aug 26 2021, 4:49 PM
ikloecker added a comment to T5569: pinentry qt4 fails to compile in pinentry 1.2.0.

Qt4 is no longer supported. Please use the previous released version plus commit rP2859eddfb0c9: qt: Fix build against Qt4 to build pinentry for Qt4. For everything else use 1.2.0.

Aug 26 2021, 3:13 PM · Bug Report, pinentry

Aug 25 2021

ikloecker committed rKLEOPATRA785049dc0827: Disable the hidden Close button to prevent problem with screen reader (authored by ikloecker).
Disable the hidden Close button to prevent problem with screen reader
Aug 25 2021, 12:27 PM

Aug 23 2021

ikloecker committed rKLEOPATRAd6582a49c422: Do not show "opaque signature" warning if just one file is to be signed (authored by ikloecker).
Do not show "opaque signature" warning if just one file is to be signed
Aug 23 2021, 5:08 PM
ikloecker committed rKLEOPATRAb2e7699ac08c: Update the commit button only if the corresponding wizard page is shown (authored by ikloecker).
Update the commit button only if the corresponding wizard page is shown
Aug 23 2021, 5:08 PM
ikloecker committed rKLEOPATRAe54ed5081272: Modernize code (authored by ikloecker).
Modernize code
Aug 23 2021, 5:08 PM
ikloecker committed rKLEOPATRAc7755bcbdafc: Ensure correct tab order in VS-NfD compliant mode (authored by ikloecker).
Ensure correct tab order in VS-NfD compliant mode
Aug 23 2021, 5:08 PM
ikloecker committed rKLEOPATRA4aacd973a86c: Set VS-NfD compliance hint also as tooltip of the commit button (authored by ikloecker).
Set VS-NfD compliance hint also as tooltip of the commit button
Aug 23 2021, 5:08 PM
ikloecker committed rKLEOPATRA2c00747e99e4: Disable sign option and encrypt options if needed keys are not available (authored by ikloecker).
Disable sign option and encrypt options if needed keys are not available
Aug 23 2021, 11:24 AM

Aug 19 2021

ikloecker committed rKLEOPATRA4479581deb12: Do not crash if there are no keys in the keyring (authored by ikloecker).
Do not crash if there are no keys in the keyring
Aug 19 2021, 5:38 PM
ikloecker moved T5544: Kleopatra: Ensure that file encryption dialogs has shortcuts on all actions from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Aug 19 2021, 4:05 PM · kleopatra, Restricted Project
ikloecker changed the status of T5544: Kleopatra: Ensure that file encryption dialogs has shortcuts on all actions from Open to Testing.
Aug 19 2021, 4:05 PM · kleopatra, Restricted Project
ikloecker changed the status of T5544: Kleopatra: Ensure that file encryption dialogs has shortcuts on all actions, a subtask of T5535: Kleopatra: Check that accessibility is also supported for VS-NfD, from Open to Testing.
Aug 19 2021, 4:05 PM · Restricted Project, kleopatra
ikloecker added a comment to T5544: Kleopatra: Ensure that file encryption dialogs has shortcuts on all actions.

I have added shortcuts to the checkboxes and the (first) visible filename requester. I have not added shortcuts to the two buttons because the first one is anyway the default button, i.e. it reacts on Return, and the Cancel button reacts on Esc.

Aug 19 2021, 4:05 PM · kleopatra, Restricted Project
ikloecker committed rKLEOPATRAa89f74471d70: Move output files/folders before "Encrypt/Sign ... separately" option (authored by ikloecker).
Move output files/folders before "Encrypt/Sign ... separately" option
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRAf45b63d331b7: Simplify code checking for OpenPGP and/or S/MIME encryption (authored by ikloecker).
Simplify code checking for OpenPGP and/or S/MIME encryption
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRA9f0ec8e0b3bc: Add wrapper widget for a FileNameRequester with icon (authored by ikloecker).
Add wrapper widget for a FileNameRequester with icon
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRA93d3c3789f1a: Sort the enum values in the desired GUI order (authored by ikloecker).
Sort the enum values in the desired GUI order
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRAb9a9ae106b6c: Do not add recipient field unconditionally when editing another started (authored by ikloecker).
Do not add recipient field unconditionally when editing another started
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRA1d1c4df33d62: Ensure correct tab order of the recipient widgets (authored by ikloecker).
Ensure correct tab order of the recipient widgets
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRA300719d3ec9a: Move focus to next (or previous) recipient field when removing one (authored by ikloecker).
Move focus to next (or previous) recipient field when removing one
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRAa8bedd58865c: Add/improve/fix context of a few translated strings (authored by ikloecker).
Add/improve/fix context of a few translated strings
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRA06b03e9b0524: Take the scroll area out of the tab order (authored by ikloecker).
Take the scroll area out of the tab order
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRAb2817adf528c: Ensure correct setup of UI for default protocol (authored by ikloecker).
Ensure correct setup of UI for default protocol
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRAa85ea08abb5f: Simplify layout handling of recipient widgets (authored by ikloecker).
Simplify layout handling of recipient widgets
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRA1ee45a58d278: Minor cleanup (authored by ikloecker).
Minor cleanup
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRAae821301ccf1: Make the filename requesters accessible with a shortcut (authored by ikloecker).
Make the filename requesters accessible with a shortcut
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRA4b2dcc8549be: Manually specify shortcuts for all checkboxes (authored by ikloecker).
Manually specify shortcuts for all checkboxes
Aug 19 2021, 1:04 PM
ikloecker committed rLIBKLEO0fb836a692ce: Make it possible to use FileNameRequester as buddy of a label (authored by ikloecker).
Make it possible to use FileNameRequester as buddy of a label
Aug 19 2021, 1:03 PM
ikloecker committed rLIBKLEO8ab5857cc518: Set tooltip of push button and line edit (authored by ikloecker).
Set tooltip of push button and line edit
Aug 19 2021, 1:03 PM
ikloecker added inline comments to rG661c2ae96699: agent: Use the sysconfdir for a pattern file..
Aug 19 2021, 9:23 AM

Aug 18 2021

ikloecker moved T5535: Kleopatra: Check that accessibility is also supported for VS-NfD from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Aug 18 2021, 4:52 PM · Restricted Project, kleopatra
ikloecker committed rP082abf916e06: doc: Change group size for passphrase formatting to five (authored by ikloecker).
doc: Change group size for passphrase formatting to five
Aug 18 2021, 10:14 AM
ikloecker committed rP5a6d70cf7d7b: qt: Change group size for passphrase formatting to 5 (authored by ikloecker).
qt: Change group size for passphrase formatting to 5
Aug 18 2021, 10:10 AM

Aug 16 2021

ikloecker moved T5544: Kleopatra: Ensure that file encryption dialogs has shortcuts on all actions from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Aug 16 2021, 3:53 PM · kleopatra, Restricted Project
ikloecker committed rKLEOPATRAd87504e0cc72: Fix wrong button text when opening wizard (authored by ikloecker).
Fix wrong button text when opening wizard
Aug 16 2021, 3:53 PM
ikloecker committed rKLEOPATRAaa59b873a51b: Simplify code displaying compliance label next to buttons (authored by ikloecker).
Simplify code displaying compliance label next to buttons
Aug 16 2021, 3:53 PM
ikloecker committed rKLEOPATRA3c8a08ce2f2c: Remove superfluous call of setEncryptionPreset() (authored by ikloecker).
Remove superfluous call of setEncryptionPreset()
Aug 16 2021, 3:53 PM
ikloecker committed rKLEOPATRA76543bec5dc7: Enable "Encrypt with password" if keyring is empty (authored by ikloecker).
Enable "Encrypt with password" if keyring is empty
Aug 16 2021, 3:53 PM
ikloecker changed the status of T5545: Kleopatra: Select symmetric encryption by default if keyring is empty, a subtask of T5535: Kleopatra: Check that accessibility is also supported for VS-NfD, from Open to Testing.
Aug 16 2021, 3:52 PM · Restricted Project, kleopatra
ikloecker changed the status of T5545: Kleopatra: Select symmetric encryption by default if keyring is empty from Open to Testing.
Aug 16 2021, 3:52 PM · kleopatra, Restricted Project
ikloecker moved T5545: Kleopatra: Select symmetric encryption by default if keyring is empty from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Aug 16 2021, 3:52 PM · kleopatra, Restricted Project
ikloecker committed rPd285c2cb1f61: qt: Make sure the message box is centered on top of the pinentry (authored by ikloecker).
qt: Make sure the message box is centered on top of the pinentry
Aug 16 2021, 11:00 AM
ikloecker moved T5545: Kleopatra: Select symmetric encryption by default if keyring is empty from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Aug 16 2021, 10:59 AM · kleopatra, Restricted Project
ikloecker changed the status of T5543: pinentry-qt: Accessibility switch to repeat on enter from Open to Testing.
Aug 16 2021, 10:58 AM · pinentry, Restricted Project
ikloecker changed the status of T5543: pinentry-qt: Accessibility switch to repeat on enter, a subtask of T5535: Kleopatra: Check that accessibility is also supported for VS-NfD, from Open to Testing.
Aug 16 2021, 10:58 AM · Restricted Project, kleopatra
ikloecker moved T5543: pinentry-qt: Accessibility switch to repeat on enter from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Aug 16 2021, 10:57 AM · pinentry, Restricted Project
ikloecker added a comment to T5552: Key information loading is sometimes very slow. Suspected that the problem originated from gnupg..

keyserver hkps://hkps.pool.sks-keyservers.net:80 is problematic.

Aug 16 2021, 10:40 AM · FAQ, Keyserver, gnupg

Aug 12 2021

ikloecker committed rP141b5776a906: qt: Make pinentry compile again with QT_NO_ACCESSIBILITY (authored by ikloecker).
qt: Make pinentry compile again with QT_NO_ACCESSIBILITY
Aug 12 2021, 6:48 PM