Page MenuHome GnuPG
Feed Advanced Search

Apr 19 2019

gniibe claimed T4456: gpgme repeatedly segfaults claws-mail after update to 1.13.0.
Apr 19 2019, 8:02 AM · gpgme (gpgme 1.23.x), Bug Report
gniibe changed the status of T4456: gpgme repeatedly segfaults claws-mail after update to 1.13.0 from Open to Testing.

I think I identified the bug. A fix is pushed.

Apr 19 2019, 8:02 AM · gpgme (gpgme 1.23.x), Bug Report
gniibe added a comment to T4456: gpgme repeatedly segfaults claws-mail after update to 1.13.0.

Before the SEGV, calling a handler in _gpgme_io_close is strange:

GPGME 2019-04-11 12:24:58 <0x660e>        _gpgme_io_close: check: fd=0x22 invoking close handler 0x7f341d8b8960/0x7f33f0003930

Because the file descriptor 0x21 and 0x22 is allocated by _gpgme_io_pipe, and there should be no handler(s) for those fds.
Either, the notify_table is screwed up, or there is a leak of fds.
I'd like to see the logs of all calls of _gpgme_io_set_close_notify and _gpgme_io_close.

Apr 19 2019, 7:23 AM · gpgme (gpgme 1.23.x), Bug Report
gniibe added a comment to T4456: gpgme repeatedly segfaults claws-mail after update to 1.13.0.

Sorry, I overlooked. I think it is inside _gpgme_io_close calling the handler, and the handler segfaults.

Apr 19 2019, 6:05 AM · gpgme (gpgme 1.23.x), Bug Report

Apr 18 2019

gniibe added a comment to T4456: gpgme repeatedly segfaults claws-mail after update to 1.13.0.

Apparently, it SEGV-ted itself by assert at line 468 in gpgme/src/engine.c.
For GpgSM, info->file_name is not assigned (while it is done by gpg and gpgconf).
The code hasn't been changed for a while, I don't know the exact reason why it becomes occur.

Apr 18 2019, 5:14 AM · gpgme (gpgme 1.23.x), Bug Report

Apr 17 2019

gniibe changed the status of T4461: Memory leak in read_block from Open to Testing.
Apr 17 2019, 3:02 AM · Bug Report
gniibe committed rGa861f9343d6e: g10: Fix a memory leak. (authored by gniibe).
g10: Fix a memory leak.
Apr 17 2019, 3:02 AM
gniibe added a comment to T4461: Memory leak in read_block.

I think that the bug has been there. The commits of import.c revealed the problem with your particular input.

Apr 17 2019, 3:01 AM · Bug Report
gniibe claimed T4461: Memory leak in read_block.

Thanks for your report. It was good you add "enter no passphrase for Alfa Test Key". Then, I saw the leak. (I misunderstood as if I needed the test environment.)
Anyway, I'm going to fix it now.

Apr 17 2019, 2:46 AM · Bug Report

Apr 16 2019

SHAGO79 awarded rE7933692f2e60: build: Build with LD_LIBRARY_PATH, use of DT_RPATH (1/2). a Love token.
Apr 16 2019, 10:54 AM
gniibe changed the status of T4459: libgpg-error build issue with gawk 5.0.0 from Open to Testing.

Added a fix to GnuPG, too (master and stable 2.2).

Apr 16 2019, 8:29 AM · Gentoo, gpgrt, MacOS, Bug Report
gniibe committed rGee766b2b5d64: common: Fix AWK portability. (authored by gniibe).
common: Fix AWK portability.
Apr 16 2019, 6:29 AM
gniibe committed rGb6f0b0efa19e: common: Fix AWK portability. (authored by gniibe).
common: Fix AWK portability.
Apr 16 2019, 6:28 AM
gniibe added a comment to T4459: libgpg-error build issue with gawk 5.0.0.

I keep this ticket open, since it is also problem for other packages.

Apr 16 2019, 6:21 AM · Gentoo, gpgrt, MacOS, Bug Report

Apr 15 2019

gniibe committed rE7865041c77f4: awk: Prepare for Gawk 5.0. (authored by gniibe).
awk: Prepare for Gawk 5.0.
Apr 15 2019, 8:55 AM
gniibe claimed T4459: libgpg-error build issue with gawk 5.0.0.
Apr 15 2019, 6:40 AM · Gentoo, gpgrt, MacOS, Bug Report

Apr 8 2019

gniibe closed T4415: Does not build using gcc 9 as Invalid.

For what I use, please refer: https://tracker.debian.org/pkg/gcc-9

Apr 8 2019, 11:57 PM · Info Needed, toolchain, Bug Report

Apr 6 2019

gniibe added a project to T4415: Does not build using gcc 9: Info Needed.
Apr 6 2019, 3:58 AM · Info Needed, toolchain, Bug Report
gniibe added a comment to T4415: Does not build using gcc 9.

@kloczek , it is not reproducible for us, so, we consider it may be a problem other than GnuPG itself, possibly, some specific build configuration parameter(s) for GCC, or something by unreleased code.
Please file a report with how to reproduce your problem.

Apr 6 2019, 3:57 AM · Info Needed, toolchain, Bug Report

Apr 4 2019

gniibe committed rGf1cf799a37f3: scd: Better handling of timeout and time extension. (authored by gniibe).
scd: Better handling of timeout and time extension.
Apr 4 2019, 9:02 AM

Mar 27 2019

gniibe committed rG2f455d18ab99: gpg: Don't use EdDSA algo ID for ECDSA curves. (authored by Trevor Bentley <trevor@yubico.com>).
gpg: Don't use EdDSA algo ID for ECDSA curves.
Mar 27 2019, 3:11 AM
gniibe committed rG4324560b2c0b: gpg: Don't use EdDSA algo ID for ECDSA curves. (authored by Trevor Bentley <trevor@yubico.com>).
gpg: Don't use EdDSA algo ID for ECDSA curves.
Mar 27 2019, 3:08 AM

Mar 25 2019

gniibe committed rG8d1b5982138c: libdns: Don't use _[A-Z] which are reserved names. (authored by gniibe).
libdns: Don't use _[A-Z] which are reserved names.
Mar 25 2019, 11:43 AM
gniibe claimed T4420: gnupg-2.2.14: Compilation failure on OpenIndiana.
Mar 25 2019, 11:16 AM · Solaris, gnupg (gpg22), Bug Report

Mar 22 2019

gniibe added a comment to T4415: Does not build using gcc 9.

With gcc-9 in Debian experimental, everything goes well.
Yes, the use of pragma is questionable, but let's see.

Mar 22 2019, 10:39 AM · Info Needed, toolchain, Bug Report

Mar 14 2019

gniibe committed rGf199b627ce51: Fix the previous commit. (authored by gniibe).
Fix the previous commit.
Mar 14 2019, 12:33 AM

Mar 13 2019

gniibe committed rGaf3efd149f55: g10: Fix symmetric cipher algo constant for ECDH. (authored by gniibe).
g10: Fix symmetric cipher algo constant for ECDH.
Mar 13 2019, 1:17 AM

Mar 6 2019

gniibe committed rK09a4cfae1439: Update libgcrypt.m4. (authored by gniibe).
Update libgcrypt.m4.
Mar 6 2019, 7:11 AM
gniibe committed rS5509f2dbcb89: Update libassuan.m4. (authored by gniibe).
Update libassuan.m4.
Mar 6 2019, 6:36 AM
gniibe changed the status of T4377: gpg-agent does not anymore restart a killed scdaemon from Open to Testing.
Mar 6 2019, 3:05 AM · gnupg (gpg23), gpgagent, scd
gniibe added a comment to T4377: gpg-agent does not anymore restart a killed scdaemon.

That's my badness. In wait_child_thread, assuan_release may cause thread context switch to agent_reset_scd which accesses scd_local_list; This access should be serialized.
And... in start_scd, calling unlock_scd should be after unlocking start_scd_lock.

Mar 6 2019, 3:05 AM · gnupg (gpg23), gpgagent, scd
gniibe committed rG2abad7585a00: agent: Fix detection of exit of scdaemon. (authored by gniibe).
agent: Fix detection of exit of scdaemon.
Mar 6 2019, 3:00 AM

Mar 4 2019

gniibe committed rP6ddcc92cf6e9: Update gpg-error.m4 and libassuan.m4 from corresponding repos. (authored by gniibe).
Update gpg-error.m4 and libassuan.m4 from corresponding repos.
Mar 4 2019, 9:46 AM

Feb 28 2019

gniibe added inline comments to rG0173b249cfb7: agent: PKSIGN should return signature in same format for card..
Feb 28 2019, 12:59 AM

Feb 27 2019

gniibe committed rKf37361f86d22: Revert wrong fix for ECDSA. (authored by gniibe).
Revert wrong fix for ECDSA.
Feb 27 2019, 6:53 AM
gniibe committed rK9fea74575085: Don't remove leading zero byte. (authored by gniibe).
Don't remove leading zero byte.
Feb 27 2019, 3:18 AM
gniibe claimed T4104: gpgsm/ksba removes leading zeros from signature byte array.

We also need to fix for encryption and signature in CSR.

Feb 27 2019, 3:17 AM · Restricted Project, libksba, S/MIME, Bug Report
gniibe committed rG0173b249cfb7: agent: PKSIGN should return signature in same format for card. (authored by gniibe).
agent: PKSIGN should return signature in same format for card.
Feb 27 2019, 2:49 AM

Feb 26 2019

gniibe committed rK5d9278f3d130: Fixing ECDSA, support EdDSA signatures in CSRs. (authored by gniibe).
Fixing ECDSA, support EdDSA signatures in CSRs.
Feb 26 2019, 7:29 AM
gniibe claimed T4367: gnupg fails to build with gcc9.

Fixed in master, by removing use of compound literals. Compound literals are not portable feature (even for C99 code), so, it's good to avoid when we can.
Still dns.c uses C99 features of struct initializer with name.

Feb 26 2019, 4:36 AM · gnupg (gpg22), Bug Report
gniibe committed rG371ae25f8f6f: libdns: Avoid using compound literals (8). (authored by gniibe).
libdns: Avoid using compound literals (8).
Feb 26 2019, 4:33 AM
gniibe committed rGd661acd48323: libdns: Avoid using compound literals (7). (authored by gniibe).
libdns: Avoid using compound literals (7).
Feb 26 2019, 4:33 AM
gniibe committed rGa1ccfe2b3784: libdns: Avoid using compound literals (5). (authored by gniibe).
libdns: Avoid using compound literals (5).
Feb 26 2019, 4:33 AM
gniibe committed rG6501e59d3685: libdns: Avoid using compound literals (6). (authored by gniibe).
libdns: Avoid using compound literals (6).
Feb 26 2019, 4:33 AM
gniibe committed rG7313a112f9c7: libdns: Avoid using compound literals (4). (authored by gniibe).
libdns: Avoid using compound literals (4).
Feb 26 2019, 4:33 AM
gniibe committed rG72efb7840258: libdns: Avoid using compound literals (3). (authored by gniibe).
libdns: Avoid using compound literals (3).
Feb 26 2019, 4:33 AM
gniibe committed rG455ef62d29a1: libdns: Avoid using compound literals (2). (authored by gniibe).
libdns: Avoid using compound literals (2).
Feb 26 2019, 4:33 AM
gniibe committed rG1c405499388f: libdns: Avoid using compound literals. (authored by gniibe).
libdns: Avoid using compound literals.
Feb 26 2019, 4:33 AM

Feb 25 2019

gniibe added projects to T3381: dirmngr won't start on Windows 10 with admin level account: Restricted Project, libassuan.
Feb 25 2019, 3:37 AM · libassuan, Restricted Project, gpg4win, dirmngr, Windows, Bug Report
gniibe committed rGe140c6d4f581: gpgscm: Build well even if NDEBUG defined. (authored by gniibe).
gpgscm: Build well even if NDEBUG defined.
Feb 25 2019, 2:51 AM
gniibe committed rG8161afb9ddda: gpgscm: Build well even if NDEBUG defined. (authored by gniibe).
gpgscm: Build well even if NDEBUG defined.
Feb 25 2019, 2:51 AM
gniibe closed T3959: Syntax errors in scheme.c as Resolved.

Thanks, applied to GnuPG 2.2, master, and libgpg-error.

Feb 25 2019, 2:49 AM · Bug Report
gniibe committed rCad133fc79757: fips: Only test check_binary_integrity when fips_mode is enabled. (authored by gniibe).
fips: Only test check_binary_integrity when fips_mode is enabled.
Feb 25 2019, 1:43 AM
gniibe triaged T4274: Fail selftests when checksum file is missing in FIPS mode only as Normal priority.

Fixed in master.

Feb 25 2019, 1:10 AM · Restricted Project, libgcrypt, Bug Report
gniibe claimed T4274: Fail selftests when checksum file is missing in FIPS mode only.

Thanks for your report.
I think that your patch is too generous to run HMAC even if fips_mode is not enabled; Simply, we can stop calling integrity check when fips_mode is not active.

Feb 25 2019, 1:09 AM · Restricted Project, libgcrypt, Bug Report

Feb 22 2019

gniibe committed rG611faf1579a5: scd: internal driver: Submit SET_INTERFACE control transfer. (authored by gniibe).
scd: internal driver: Submit SET_INTERFACE control transfer.
Feb 22 2019, 12:14 PM

Feb 21 2019

gniibe committed rG2013cb5ee667: scd: Clear CHV status on timeout error. (authored by gniibe).
scd: Clear CHV status on timeout error.
Feb 21 2019, 7:53 AM
gniibe committed rGbd15aa34ab8a: scd: Handle ack button timeout as GPG_ERR_TIMEOUT. (authored by gniibe).
scd: Handle ack button timeout as GPG_ERR_TIMEOUT.
Feb 21 2019, 7:18 AM
gniibe committed rG64b7c6fd1945: tests: Add "disable-scdaemon" in gpg-agent.conf. (authored by gniibe).
tests: Add "disable-scdaemon" in gpg-agent.conf.
Feb 21 2019, 4:35 AM
gniibe added a comment to T4363: Availability of FST-01SZ in Europe.

I use BBG-SWD (my own tool to flash MCU) for transparency of the process. It's up to you to choice a tool for initial flashing.
Just in case, here are resources to be reproducible.

Feb 21 2019, 3:08 AM · Verein

Feb 19 2019

gniibe changed the status of T2011: gnupg should notify cancellation of its operation to gpg-agent to kill pinentry from Open to Testing.
Feb 19 2019, 8:17 AM · Bug Report, gpgagent
gniibe added a comment to T4198: Pinentry doesn't capture input correctly, crashes terminal instead.

Original issue (of pinentry-curses, which should be killed by CTRL-C) is related to T2011: gnupg should notify cancellation of its operation to gpg-agent to kill pinentry, I suppose. It is fixed in master and testing.
I don't know about the second one with pinentry-tty.

Feb 19 2019, 8:14 AM · pinentry, Bug Report
gniibe committed rG14e5435afb50: gpg: Fix comparison. (authored by Neal H. Walfield <neal@g10code.com>).
gpg: Fix comparison.
Feb 19 2019, 7:56 AM
gniibe committed rG005e951714ff: agent: Fix cancellation handling for scdaemon. (authored by gniibe).
agent: Fix cancellation handling for scdaemon.
Feb 19 2019, 7:56 AM
gniibe committed rG90e5f49b6a2e: scd: Distinguish cancel by user and protocol error. (authored by gniibe).
scd: Distinguish cancel by user and protocol error.
Feb 19 2019, 7:56 AM
gniibe committed rG6e422b5135c7: common: Fix gnupg_wait_processes. (authored by gniibe).
common: Fix gnupg_wait_processes.
Feb 19 2019, 7:56 AM
gniibe added a comment to T2011: gnupg should notify cancellation of its operation to gpg-agent to kill pinentry.

Fixed in master.

Feb 19 2019, 6:42 AM · Bug Report, gpgagent
gniibe committed rGc395f8315362: agent: Terminate pinentry process gracefully, by watching socket. (authored by gniibe).
agent: Terminate pinentry process gracefully, by watching socket.
Feb 19 2019, 6:41 AM
gniibe committed rG99aa54323f97: agent: Minor change for pinentry status handling. (authored by gniibe).
agent: Minor change for pinentry status handling.
Feb 19 2019, 6:41 AM
gniibe committed rGada797f477f9: agent: Factor out the getpin interaction. (authored by gniibe).
agent: Factor out the getpin interaction.
Feb 19 2019, 3:58 AM
gniibe claimed T2011: gnupg should notify cancellation of its operation to gpg-agent to kill pinentry.
Feb 19 2019, 3:55 AM · Bug Report, gpgagent
gniibe closed T3600: Support ACKNOWLEDGE button for OpenPGP card and/or Token as Resolved.

Gnuk implements the feature, and newer GnuPG shows a dialog to request pushing the ack button.

Feb 19 2019, 2:50 AM · scd
gniibe closed T4217: {libksba,libgcrypt,ntbtls,libassuan,npth}.m4, {libksba,libgcrypt,ntbtls,libassuan}-config script and gpg-error-config as Resolved.
Feb 19 2019, 2:48 AM · npth, libassuan, ntbtls, libgcrypt, libksba
gniibe closed T4245: 2019: Use of gpg-error-config scrypt (symbolic link) for {libassuan,libksba,npth,libgcrypt,ntbtls,gpgme}-config as Resolved.
Feb 19 2019, 2:46 AM
gniibe closed T4340: gpg-agent should support clearing passphrase cache for SSH as Resolved.
Feb 19 2019, 2:45 AM · gpgagent
gniibe closed T4348: When pinentry cache is used, gpg-agent should clear the cache if it failed at unprotect, a subtask of T4340: gpg-agent should support clearing passphrase cache for SSH, as Resolved.
Feb 19 2019, 2:45 AM · gpgagent
gniibe closed T4348: When pinentry cache is used, gpg-agent should clear the cache if it failed at unprotect as Resolved.
Feb 19 2019, 2:45 AM · gpgagent
gniibe lowered the priority of T4319: New 2017 MAC permission isues on gpg-agent from High to Low.

Your problem is apparently not an issue of upstream development of GnuPG; It is your setup script (agent.sh?) which specifies /dev/shm/SOMETHING.
Standard GnuPG never does that. We have no idea about use of /dev/shm/SOMETHING.

Feb 19 2019, 2:37 AM · MacOS, gpgagent, gnupg (gpg22)

Feb 18 2019

gniibe added a comment to T4363: Availability of FST-01SZ in Europe.

Some of my terminology: I call "case", "shell", and "board".

Feb 18 2019, 9:27 AM · Verein
gniibe committed rG3cbdf896e691: sm: Support generation of card-based ed25519 CSR. (authored by Damien Goutte-Gattat via Gnupg-devel <gnupg-devel@gnupg.org>).
sm: Support generation of card-based ed25519 CSR.
Feb 18 2019, 3:37 AM

Feb 15 2019

gniibe committed rG74e9b579ca27: sm: Support generation of card-based ECDSA CSR. (authored by Damien Goutte-Gattat via Gnupg-devel <gnupg-devel@gnupg.org>).
sm: Support generation of card-based ECDSA CSR.
Feb 15 2019, 3:02 AM

Feb 14 2019

gniibe committed rK98882064f457: Support multi-valued signatures in CSRs. (authored by Damien Goutte-Gattat via Gnupg-devel <gnupg-devel@gnupg.org>).
Support multi-valued signatures in CSRs.
Feb 14 2019, 2:32 AM

Feb 13 2019

gniibe accepted D451: agent: Fix S2K calibration..

Final fix was rG380bce13d94f: agent: Use clock or clock_gettime for calibration., with clock.
Closing this patch.

Feb 13 2019, 10:52 AM

Feb 12 2019

gniibe added a comment to T4363: Availability of FST-01SZ in Europe.

The metal case, I bought from here (it's expensive CNY3.00, for individuals): https://item.taobao.com/item.htm?id=550180089286

Feb 12 2019, 7:56 AM · Verein
gniibe added a comment to T4363: Availability of FST-01SZ in Europe.

For prototype, I used:

Feb 12 2019, 7:55 AM · Verein
gniibe triaged T4363: Availability of FST-01SZ in Europe as Wishlist priority.
Feb 12 2019, 7:51 AM · Verein
gniibe added a comment to T4363: Availability of FST-01SZ in Europe.
Feb 12 2019, 7:50 AM · Verein
gniibe created T4363: Availability of FST-01SZ in Europe.
Feb 12 2019, 7:29 AM · Verein

Feb 6 2019

gniibe committed rGc16685b2f502: po: Update Japanese translation. (authored by gniibe).
po: Update Japanese translation.
Feb 6 2019, 9:31 AM
gniibe committed rG9109bb9919f8: agent: Clear bogus pinentry cache, when it causes an error. (authored by gniibe).
agent: Clear bogus pinentry cache, when it causes an error.
Feb 6 2019, 9:31 AM
gniibe committed rG7f4c3eb0a039: dirmngr: Fix initialization of assuan's nPth hook. (authored by gniibe).
dirmngr: Fix initialization of assuan's nPth hook.
Feb 6 2019, 9:31 AM

Jan 28 2019

gniibe committed rG02a2633a7f0b: agent: Clear bogus pinentry cache, when it causes an error. (authored by gniibe).
agent: Clear bogus pinentry cache, when it causes an error.
Jan 28 2019, 5:04 AM
gniibe added a comment to T4348: When pinentry cache is used, gpg-agent should clear the cache if it failed at unprotect.

When bogus entry is "", the error is GPG_ERR_NO_PASSPHRASE, and user cannot input the passphrase.

Jan 28 2019, 4:55 AM · gpgagent
gniibe added a comment to T4348: When pinentry cache is used, gpg-agent should clear the cache if it failed at unprotect.

Confirmed that manually created entry in gnome-keyring-daemon causes trouble.

Jan 28 2019, 4:52 AM · gpgagent

Jan 26 2019

gniibe created T4348: When pinentry cache is used, gpg-agent should clear the cache if it failed at unprotect.
Jan 26 2019, 2:46 PM · gpgagent

Jan 25 2019

werner awarded rA5e48116051a4: socks5: Implement timeout to detect bogus service. a Cup of Joe token.
Jan 25 2019, 7:36 AM
gniibe committed rA5e48116051a4: socks5: Implement timeout to detect bogus service. (authored by gniibe).
socks5: Implement timeout to detect bogus service.
Jan 25 2019, 4:23 AM
gniibe changed the status of T4340: gpg-agent should support clearing passphrase cache for SSH from Open to Testing.
Jan 25 2019, 4:10 AM · gpgagent
gniibe added a comment to T4340: gpg-agent should support clearing passphrase cache for SSH.

Since there is --mode=normal option, it should be --mode=ssh.

Jan 25 2019, 4:10 AM · gpgagent
gniibe committed rGae966bbe9b16: agent: Support --mode=ssh option for CLEAR_PASSPHRASE. (authored by gniibe).
agent: Support --mode=ssh option for CLEAR_PASSPHRASE.
Jan 25 2019, 4:09 AM