Page MenuHome GnuPG
Feed All Stories

Aug 23 2021

gniibe committed rC581e04386d87: cipher: Use offsetof for allocation of gcry_md_context. (authored by gniibe).
cipher: Use offsetof for allocation of gcry_md_context.
Aug 23 2021, 4:52 AM
gniibe added projects to T5556: Use of offsetof is better for allocation of flexible array: libgcrypt, gpgme, gnupg (gpg23).
Aug 23 2021, 4:47 AM · gnupg24, gpgme, libgcrypt

Aug 22 2021

werner committed rD622f695de394: swdb: Libgcrypt 1.9.4 (authored by werner).
swdb: Libgcrypt 1.9.4
Aug 22 2021, 6:59 PM
werner closed T5328: On the (in)security of Elgamal in OpenPGP as Resolved.
Aug 22 2021, 6:13 PM · side-channel, CVE, libgcrypt
werner closed T5402: Release Libgcrypt 1.9.4 as Resolved.
Aug 22 2021, 6:12 PM · Release Info, libgcrypt
werner updated the task description for T5402: Release Libgcrypt 1.9.4.
Aug 22 2021, 6:12 PM · Release Info, libgcrypt
werner committed rC05422ca24a03: Release 1.9.4 (authored by werner).
Release 1.9.4
Aug 22 2021, 6:08 PM
werner committed rC06567be79d15: Post release updates (authored by werner).
Post release updates
Aug 22 2021, 6:08 PM
werner triaged T5563: Release Libgcrypt 1.9.5 as Low priority.
Aug 22 2021, 6:07 PM · Release Info, libgcrypt
werner updated subscribers of T5561: posix-io.c: In function '_gpgme_io_spawn': posix-io.c:577:23: error: void value not ignored as it ought to be .

Fallout from the fact that the @cbiedl left us and had an internal non-tagged ticket left open (T5456)

Aug 22 2021, 5:43 PM · Bug Report
werner closed T5490: gcry_pk_get_param aborts program with error on "Curve25519" as Resolved.
Aug 22 2021, 4:52 PM · libgcrypt, Bug Report
shoober420 closed T5561: posix-io.c: In function '_gpgme_io_spawn': posix-io.c:577:23: error: void value not ignored as it ought to be as Resolved.
Aug 22 2021, 4:49 PM · Bug Report
shoober420 added a comment to T5561: posix-io.c: In function '_gpgme_io_spawn': posix-io.c:577:23: error: void value not ignored as it ought to be .

I see whats going on. The GitHub gpgme mirror (https://github.com/gpg/gpgme) is no longer updated. The last commit is from June 22, 2021. Changing the source link to the official (https://dev.gnupg.org/source/gpgme) URL gets the latest updates, and now builds successfully.

Aug 22 2021, 4:46 PM · Bug Report
werner committed rC8bf723e91522: doc: Fix a typo. (authored by gniibe).
doc: Fix a typo.
Aug 22 2021, 3:23 PM
werner committed rCf91f02e8bba5: mpi/longlong.h: fix missing macro parameter parentheses (authored by jukivili).
mpi/longlong.h: fix missing macro parameter parentheses
Aug 22 2021, 3:23 PM
werner committed rC8ce522cfaba1: tests/t-mpi-point: add NIST curve multiplication test vectors (authored by jukivili).
tests/t-mpi-point: add NIST curve multiplication test vectors
Aug 22 2021, 3:23 PM
werner committed rC64e4a6a2a436: ecc: Fix bug in gcry_pk_get_param for Curve25519. (authored by werner).
ecc: Fix bug in gcry_pk_get_param for Curve25519.
Aug 22 2021, 3:23 PM
werner committed rC84ad6ac02c45: build: Fix broken mlock detection (authored by Johannes Schindelin via Gcrypt-devel <gcrypt-devel@gnupg.org>).
build: Fix broken mlock detection
Aug 22 2021, 3:23 PM
werner committed rCf1ee80baba7a: random: Silence a warning for building rndjent by Clang. (authored by gniibe).
random: Silence a warning for building rndjent by Clang.
Aug 22 2021, 3:23 PM
werner committed rC6e1412d6bdca: Minor tweak to gcry_free. (authored by werner).
Minor tweak to gcry_free.
Aug 22 2021, 3:23 PM
werner committed rCa83fb13a3bff: cipher: Extend convenience OID mapping table for AES. (authored by werner).
cipher: Extend convenience OID mapping table for AES.
Aug 22 2021, 3:23 PM
werner committed rC41dffbdd5180: cipher: Fix memory leaks for EdDSA. (authored by Tianjia Zhang <tianjia.zhang@linux.alibaba.com>).
cipher: Fix memory leaks for EdDSA.
Aug 22 2021, 3:23 PM
werner committed rC5632fa359a8c: ecc: Check the input length for the point. (authored by gniibe).
ecc: Check the input length for the point.
Aug 22 2021, 3:23 PM
werner committed rC7529b8e455e3: hwf-x86: fix use of wrong operand type (authored by jukivili).
hwf-x86: fix use of wrong operand type
Aug 22 2021, 3:23 PM
werner committed rCdd14da42caed: doc: Clarify gcry_md_setkey for keyed BLAKE hashes. (authored by werner).
doc: Clarify gcry_md_setkey for keyed BLAKE hashes.
Aug 22 2021, 3:23 PM

Aug 21 2021

werner added a comment to T5561: posix-io.c: In function '_gpgme_io_spawn': posix-io.c:577:23: error: void value not ignored as it ought to be .

This has already been fixed with rM4b64774b6d13ffa4f59dddf947a97d61bcfa2f2e

Aug 21 2021, 1:01 PM · Bug Report
werner triaged T5560: gpg.exe interrupt batch execution in WindowsXp as Normal priority.

Frankly, I don fully understand your report. Can you please clarify?
Note that with 2.2.8 we introduced full Unicode support on the command line. If you see scrambled output you may want to "chcp 65001" to get the output correctly rendered.

Aug 21 2021, 12:53 PM · Windows, gnupg (gpg22), Bug Report
werner triaged T5562: GnuPG behaves inconsistently across versions when a secret key is not found during decryption as High priority.
Aug 21 2021, 12:47 PM · Bug Report, gnupg (gpg23)

Aug 20 2021

vsajip created T5562: GnuPG behaves inconsistently across versions when a secret key is not found during decryption.
Aug 20 2021, 11:05 PM · Bug Report, gnupg (gpg23)
Saturneric added a comment to T5552: Key information loading is sometimes very slow. Suspected that the problem originated from gnupg..

I have recently been busy with the new features and mechanisms of the GpgFrontend project.

Aug 20 2021, 4:44 PM · FAQ, Keyserver, gnupg
werner committed rG2b65f4e95380: wkd: Properly unescape the user-id from a key listing. (authored by werner).
wkd: Properly unescape the user-id from a key listing.
Aug 20 2021, 4:41 PM
werner committed rGdb5dc7a91af3: agent: Ignore passphrase constraints for a generated passphrase. (authored by werner).
agent: Ignore passphrase constraints for a generated passphrase.
Aug 20 2021, 4:41 PM
werner committed rG5ed8e598faaf: agent: Use the sysconfdir for a pattern file. (authored by werner).
agent: Use the sysconfdir for a pattern file.
Aug 20 2021, 4:41 PM
werner committed rG17e2ec488f66: common: New function decode_c_string. (authored by werner).
common: New function decode_c_string.
Aug 20 2021, 4:41 PM
werner committed rG576e429d41a1: wkd: Fix client issue with leading or trailing spaces in user-ids. (authored by werner).
wkd: Fix client issue with leading or trailing spaces in user-ids.
Aug 20 2021, 4:41 PM
werner committed rG6685696adafb: gpg: Return SUCCESS/FAILURE status also for --card-edit/name. (authored by werner).
gpg: Return SUCCESS/FAILURE status also for --card-edit/name.
Aug 20 2021, 4:41 PM
werner committed rG87d238de3d9d: wkd: Properly unescape the user-id from a key listing. (authored by werner).
wkd: Properly unescape the user-id from a key listing.
Aug 20 2021, 4:17 PM
shoober420 created T5561: posix-io.c: In function '_gpgme_io_spawn': posix-io.c:577:23: error: void value not ignored as it ought to be .
Aug 20 2021, 3:52 PM · Bug Report
luweitest created T5560: gpg.exe interrupt batch execution in WindowsXp.
Aug 20 2021, 10:01 AM · Windows, gnupg (gpg22), Bug Report
werner committed rGb4345f7521cb: wkd: Fix client issue with leading or trailing spaces in user-ids. (authored by werner).
wkd: Fix client issue with leading or trailing spaces in user-ids.
Aug 20 2021, 9:51 AM
werner added a comment to T5550: Fix check_binary_integrity.

iirc Uli Drepper added a hack to dladdr which we made use of. Seems to be integrated into dladdr1 now.

Aug 20 2021, 8:26 AM · FIPS, libgcrypt
gniibe committed rG1565baa93ae3: scd: Don't release the context until list_finish for PC/SC. (authored by gniibe).
scd: Don't release the context until list_finish for PC/SC.
Aug 20 2021, 8:25 AM
shtrom added a comment to T5436: gpg-agent 2.3.1: PIN caching not working for decrypt operations.

I added "disable-application piv" to ~/.gnupg/scdaemon.conf and the behavior went back to pin caching working as before. Since I don't use PIV, this is an acceptable workaround for me.

Aug 20 2021, 5:46 AM · gnupg24, yubikey, Bug Report
gniibe added a comment to T5550: Fix check_binary_integrity.

While I don't know if runtime integrity check is required or not by FIPS 140,
I checked OpenSSL, and it has such a check in openssl/providers/fips. The FIPS module configuration file which has the module checksum by HMAC is generated by openssl fipsinstall command.

Aug 20 2021, 3:23 AM · FIPS, libgcrypt
gniibe added a comment to T5550: Fix check_binary_integrity.

Ah... I realized that HMAC integrity check with dladdr (using address of constant string) might work (at some point) to determine the filename of libgcrypt.so, when/if glibc implementation allows searching with address of constant string. So, my claim "never worked" was wrong.

Aug 20 2021, 2:46 AM · FIPS, libgcrypt

Aug 19 2021

ikloecker committed rKLEOPATRA4479581deb12: Do not crash if there are no keys in the keyring (authored by ikloecker).
Do not crash if there are no keys in the keyring
Aug 19 2021, 5:38 PM
ikloecker moved T5544: Kleopatra: Ensure that file encryption dialogs has shortcuts on all actions from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Aug 19 2021, 4:05 PM · kleopatra, Restricted Project
ikloecker changed the status of T5544: Kleopatra: Ensure that file encryption dialogs has shortcuts on all actions from Open to Testing.
Aug 19 2021, 4:05 PM · kleopatra, Restricted Project
ikloecker changed the status of T5544: Kleopatra: Ensure that file encryption dialogs has shortcuts on all actions, a subtask of T5535: Kleopatra: Check that accessibility is also supported for VS-NfD, from Open to Testing.
Aug 19 2021, 4:05 PM · Restricted Project, kleopatra
ikloecker added a comment to T5544: Kleopatra: Ensure that file encryption dialogs has shortcuts on all actions.

I have added shortcuts to the checkboxes and the (first) visible filename requester. I have not added shortcuts to the two buttons because the first one is anyway the default button, i.e. it reacts on Return, and the Cancel button reacts on Esc.

Aug 19 2021, 4:05 PM · kleopatra, Restricted Project
werner committed rGc1a23c366475: gpg: Return SUCCESS/FAILURE status also for --card-edit/name. (authored by werner).
gpg: Return SUCCESS/FAILURE status also for --card-edit/name.
Aug 19 2021, 2:13 PM
ikloecker committed rKLEOPATRAa89f74471d70: Move output files/folders before "Encrypt/Sign ... separately" option (authored by ikloecker).
Move output files/folders before "Encrypt/Sign ... separately" option
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRAf45b63d331b7: Simplify code checking for OpenPGP and/or S/MIME encryption (authored by ikloecker).
Simplify code checking for OpenPGP and/or S/MIME encryption
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRA9f0ec8e0b3bc: Add wrapper widget for a FileNameRequester with icon (authored by ikloecker).
Add wrapper widget for a FileNameRequester with icon
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRA93d3c3789f1a: Sort the enum values in the desired GUI order (authored by ikloecker).
Sort the enum values in the desired GUI order
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRAb9a9ae106b6c: Do not add recipient field unconditionally when editing another started (authored by ikloecker).
Do not add recipient field unconditionally when editing another started
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRA1d1c4df33d62: Ensure correct tab order of the recipient widgets (authored by ikloecker).
Ensure correct tab order of the recipient widgets
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRA300719d3ec9a: Move focus to next (or previous) recipient field when removing one (authored by ikloecker).
Move focus to next (or previous) recipient field when removing one
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRAa8bedd58865c: Add/improve/fix context of a few translated strings (authored by ikloecker).
Add/improve/fix context of a few translated strings
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRA06b03e9b0524: Take the scroll area out of the tab order (authored by ikloecker).
Take the scroll area out of the tab order
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRAb2817adf528c: Ensure correct setup of UI for default protocol (authored by ikloecker).
Ensure correct setup of UI for default protocol
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRAa85ea08abb5f: Simplify layout handling of recipient widgets (authored by ikloecker).
Simplify layout handling of recipient widgets
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRA1ee45a58d278: Minor cleanup (authored by ikloecker).
Minor cleanup
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRAae821301ccf1: Make the filename requesters accessible with a shortcut (authored by ikloecker).
Make the filename requesters accessible with a shortcut
Aug 19 2021, 1:04 PM
ikloecker committed rKLEOPATRA4b2dcc8549be: Manually specify shortcuts for all checkboxes (authored by ikloecker).
Manually specify shortcuts for all checkboxes
Aug 19 2021, 1:04 PM
ikloecker committed rLIBKLEO0fb836a692ce: Make it possible to use FileNameRequester as buddy of a label (authored by ikloecker).
Make it possible to use FileNameRequester as buddy of a label
Aug 19 2021, 1:03 PM
ikloecker committed rLIBKLEO8ab5857cc518: Set tooltip of push button and line edit (authored by ikloecker).
Set tooltip of push button and line edit
Aug 19 2021, 1:03 PM
Jakuje added a comment to T5550: Fix check_binary_integrity.

We have the same patch (including the hmac key and we use the switch. The reasoning on our side was to be compatible with fipscheck, but it is no longer used since last year and we use just the hmac256 tool:

Aug 19 2021, 12:52 PM · FIPS, libgcrypt
werner added a comment to T5550: Fix check_binary_integrity.

Just for the records, the whole HMAC thing including the special dlopen trick used to work fine when we did the original FIPS support.

Aug 19 2021, 12:35 PM · FIPS, libgcrypt
gniibe committed rCc9acca865ba4: hmac: Don't have the second implementation of hmac256. (authored by gniibe).
hmac: Don't have the second implementation of hmac256.
Aug 19 2021, 10:33 AM
gniibe committed rCc11788e5641b: fips: Don't use gcry_check_version for integrity check any more. (authored by gniibe).
fips: Don't use gcry_check_version for integrity check any more.
Aug 19 2021, 10:23 AM
gniibe committed rCf02dc5235e47: fips: Use a .rodata1 section integrity check with hmac256. (authored by gniibe).
fips: Use a .rodata1 section integrity check with hmac256.
Aug 19 2021, 10:17 AM
ikloecker added inline comments to rG661c2ae96699: agent: Use the sysconfdir for a pattern file..
Aug 19 2021, 9:23 AM
gniibe committed rC24aaded244a2: build: Generate hash for integrity check with hmac256 (2). (authored by gniibe).
build: Generate hash for integrity check with hmac256 (2).
Aug 19 2021, 3:54 AM

Aug 18 2021

Jakuje added a comment to T5244: libgcrypt: Restrict MD5 use.

Right. The clarification is that SHA1 itself (for non-security and non-signature use) is still allowed in FIPS mode. But it is not allowed to be used as part of signature schemes of the new API in FIPS mode. The old API, which allows raw signatures without digests, should just fail in FIPS mode too. And the FIPS-compatible gnupg should use the new API too (it would be good to think about this when putting it together).

Aug 18 2021, 7:46 PM · Bug Report, FIPS, libgcrypt
Jakuje added a comment to T5523: jitter entropy RNG update.

For Linux and FIPS, we should be actually fine with using /dev/random or getrandom().

Aug 18 2021, 7:24 PM · FIPS, libgcrypt
werner committed rGb89b1f35c29c: agent: Ignore passphrase constraints for a generated passphrase. (authored by werner).
agent: Ignore passphrase constraints for a generated passphrase.
Aug 18 2021, 7:22 PM
werner committed rG661c2ae96699: agent: Use the sysconfdir for a pattern file. (authored by werner).
agent: Use the sysconfdir for a pattern file.
Aug 18 2021, 7:22 PM
werner closed T5559: libksba: possible NULL pointer dereference as Resolved.
Aug 18 2021, 6:22 PM · libksba, Bug Report
ikloecker moved T5535: Kleopatra: Check that accessibility is also supported for VS-NfD from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Aug 18 2021, 4:52 PM · Restricted Project, kleopatra
werner committed rKc242f31b6d52: Avoid warnings about NULL ptr deref in ASN.1 helpers. (authored by werner).
Avoid warnings about NULL ptr deref in ASN.1 helpers.
Aug 18 2021, 4:21 PM
werner triaged T5559: libksba: possible NULL pointer dereference as Low priority.

I added some asserts. However I doubt that it can be hit by LibKSBA. I also fixed a real bug related to VALTYPE_BOOL - but that is also not used in Libksba.

Aug 18 2021, 3:07 PM · libksba, Bug Report
Jakuje added a comment to T5540: Update fipsdrv and cavs_driver.pl.

The CAVS driver can be safely removed. The certification goes through the ACVP these days so it does not make sense to keep this.

Aug 18 2021, 12:46 PM · FIPS, libgcrypt
werner committed rG2e69ce878f89: agent: Improve the GENPIN callback. (authored by werner).
agent: Improve the GENPIN callback.
Aug 18 2021, 11:35 AM
Jakuje created T5559: libksba: possible NULL pointer dereference.
Aug 18 2021, 11:35 AM · libksba, Bug Report
werner committed rG9fb646660258: agent: Fix for zero length help string in pinentry hints. (authored by werner).
agent: Fix for zero length help string in pinentry hints.
Aug 18 2021, 11:31 AM
werner committed rG8ed79103474c: agent: Improve the GENPIN callback. (authored by werner).
agent: Improve the GENPIN callback.
Aug 18 2021, 11:31 AM
werner committed rG629f4a5cffb7: common,w32: Replace log_debug by log_info for InProcessJobs (authored by werner).
common,w32: Replace log_debug by log_info for InProcessJobs
Aug 18 2021, 11:30 AM
werner committed rGc622cf59fd5a: doc: Add sample texts for Pinentry hints (authored by werner).
doc: Add sample texts for Pinentry hints
Aug 18 2021, 11:30 AM
werner committed rP008fb9337a52: Accept percent escaped formatted-passphrase-hint option. (authored by werner).
Accept percent escaped formatted-passphrase-hint option.
Aug 18 2021, 11:30 AM
werner committed rG4855888c0a56: agent: Fix for zero length help string in pinentry hints. (authored by werner).
agent: Fix for zero length help string in pinentry hints.
Aug 18 2021, 10:22 AM
werner committed rGec2f1b38980a: common,w32: Replace log_debug by log_info for InProcessJobs (authored by werner).
common,w32: Replace log_debug by log_info for InProcessJobs
Aug 18 2021, 10:22 AM
ikloecker committed rP082abf916e06: doc: Change group size for passphrase formatting to five (authored by ikloecker).
doc: Change group size for passphrase formatting to five
Aug 18 2021, 10:14 AM
ikloecker committed rP5a6d70cf7d7b: qt: Change group size for passphrase formatting to 5 (authored by ikloecker).
qt: Change group size for passphrase formatting to 5
Aug 18 2021, 10:10 AM
gniibe committed rC3c89aad4a0d7: build: Generate hash for integrity check with hmac256. (authored by gniibe).
build: Generate hash for integrity check with hmac256.
Aug 18 2021, 5:51 AM
gniibe committed rCcbbdc015bf52: cipher: Fix the order of fields of gcry_md_context. (authored by gniibe).
cipher: Fix the order of fields of gcry_md_context.
Aug 18 2021, 5:51 AM
gniibe committed rC07c21dd7d134: hmac: Fix hmac256 command option handling. (authored by gniibe).
hmac: Fix hmac256 command option handling.
Aug 18 2021, 5:51 AM
gniibe committed rC709a41ef540e: hmac: Use xfree. (authored by gniibe).
hmac: Use xfree.
Aug 18 2021, 2:43 AM
gniibe added a comment to T5244: libgcrypt: Restrict MD5 use.

For use of SHA-1:

Aug 18 2021, 1:59 AM · Bug Report, FIPS, libgcrypt

Aug 17 2021

werner closed T5537: Use CSIDL_LOCAL_APPDATA for the socketdir as Resolved.

I have done tests with 2.2 and no problems showed up.

Aug 17 2021, 5:18 PM · Windows, Restricted Project, gnupg (gpg22)