- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jul 1 2021
Very cool, I like it especially that you avoided a popup and used that action mechanism.
Jun 30 2021
When selecting a certification key without ultimate trust the message "Is this your own key?" is shown.
Thanks a lot.
Jun 29 2021
curve=23 secp256r1 point=040000ffffffff0000000000000000000000000000000000000000000000000000cfe26d107a5134d6feb38ce3577075bdc7aa70ff7523d3b203c8a973f2d3dc8e bignum=0000000000ff0000000400000000000000000000005d00003277002000010000 mbedtls: 0 04fd351b304ad50f36153d8193c4bbf7d4c3bee26e5af52a9c70133edfa62c273e05da8312615436e9c81b5b0624e68667233ace6307afc8056eae85049ca63226 gcrypt: 0 04d6915640b8ba3918f129c108f52f571ec28c1c89ad710b43928c3bd942eb29d8bf181e997b502abf12cf3606eb46379c59fd396bda7b45cdc75d429b2b37b15f
curve=24 secp384r1 point=0400000000000000000000000000000000000000000000000000000000000000000000000000fffffffffffffffffffffc1b0d6f8fb7f2de5b8875645b64042ae20f119f3e1cfefc0215857eeae5f4a8fca737057d69a42c44d958e7cfcc77ce6b bignum=ffffffffffffffffffffffffffffffffffffffffffffffffc7634d81f4372ddf581a0db248b0a77aecec196accc52972 mbedtls: 0 0400000000000000000000000000000000000000000000000000000000000000000000000000fffffffffffffffffffffce4f29070480d21a4778a9ba49bfbd51df0ee60c1e30103fdea7a81151a0b570258c8fa81965bd3bb26a7183133883194 gcrypt: 0 04fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffeffffffff0100000000000000fffffffbe4f29070480d21a4778a9ba49bfbd51df0ee60c1e30103fdea7a81151a0b570258c8fa81965bd3bb26a7183133883194
The original idea with the DNS code was just to source copy it but it turned out that we need to maintain it in GnuPG. Thus adding support for SHA256 makes sense to keep the code current in case we ever need to use it.
Do I correctly understand that issue will be resolved on GnuPG side by tweaking key bits before private-key import/and/or/operations?
Jun 28 2021
P192, P224, P256 and P384 are affected.
Is secp192r1 only curve that is giving wrong results?
Attached patch should fix the issue:
Fixed as discussed.
Thanks for reporting. There is two commits in that commit range, including https://dev.gnupg.org/rC9d909cb67e70fd792926ac1e2ab305b2cc96bc27 which adds fast reduction for NIST curves. So obviously something is wrong there. Is secp192r1 only curve that is giving wrong results?
I have received a convincing report that Kleopatra crashes when encrypting or decrypting Folder structures > 30GB. So I need to at least test this, too.
test-stubs.c:374:1: note: 'show_photos' was previously declared here keyserver-internal.h:35:24: warning: type of 'parse_keyserver_uri' does not match original declaration [-Wlto-type-mismatch] 35 | struct keyserver_spec *parse_keyserver_uri (const char *string, | ^ test-stubs.c:356:1: note: type mismatch in parameter 3 356 | parse_keyserver_uri (const char *uri, int require_scheme, | ^ test-stubs.c:356:1: note: 'parse_keyserver_uri' was previously declared here keyserver-internal.h:60:5: warning: type of 'keyserver_import_ldap' does not match original declaration [-Wlto-type-mismatch] 60 | int keyserver_import_ldap (ctrl_t ctrl, const char *name, | ^ test-stubs.c:243:1: note: type mismatch in parameter 2 243 | keyserver_import_ldap (const char *name) | ^ test-stubs.c:243:1: note: 'keyserver_import_ldap' was previously declared here keyserver-internal.h:57:5: warning: type of 'keyserver_import_name' does not match original declaration [-Wlto-type-mismatch] 57 | int keyserver_import_name (ctrl_t ctrl, | ^ test-stubs.c:224:1: note: type mismatch in parameter 3 224 | keyserver_import_name (const char *name,struct keyserver_spec *spec) | ^ test-stubs.c:224:1: note: 'keyserver_import_name' was previously declared here keyserver-internal.h:50:5: warning: type of 'keyserver_import_cert' does not match original declaration [-Wlto-type-mismatch] 50 | int keyserver_import_cert (ctrl_t ctrl, const char *name, int dane_mode, | ^ test-stubs.c:205:1: note: type mismatch in parameter 2 205 | keyserver_import_cert (const char *name) | ^ test-stubs.c:205:1: note: 'keyserver_import_cert' was previously declared here keyserver-internal.h:44:5: warning: type of 'keyserver_import_keyid' does not match original declaration [-Wlto-type-mismatch] 44 | int keyserver_import_keyid (ctrl_t ctrl, u32 *keyid, | ^ test-stubs.c:184:1: note: type mismatch in parameter 3 184 | keyserver_import_keyid (u32 *keyid, void *dummy, unsigned int flags) | ^ test-stubs.c:184:1: note: 'keyserver_import_keyid' was previously declared here photoid.h:31:6: warning: type of 'show_photos' does not match original declaration [-Wlto-type-mismatch] 31 | void show_photos (ctrl_t ctrl, const struct user_attribute *attrs, int count, | ^ test-stubs.c:374:1: note: type mismatch in parameter 2 374 | show_photos (const struct user_attribute *attrs, int count, PKT_public_key *pk) | ^ test-stubs.c:374:1: note: 'show_photos' was previously declared here keyserver-internal.h:35:24: warning: type of 'parse_keyserver_uri' does not match original declaration [-Wlto-type-mismatch] 35 | struct keyserver_spec *parse_keyserver_uri (const char *string, | ^ test-stubs.c:356:1: note: type mismatch in parameter 3 356 | parse_keyserver_uri (const char *uri, int require_scheme, | ^ test-stubs.c:356:1: note: 'parse_keyserver_uri' was previously declared here keyserver-internal.h:60:5: warning: type of 'keyserver_import_ldap' does not match original declaration [-Wlto-type-mismatch] 60 | int keyserver_import_ldap (ctrl_t ctrl, const char *name, | ^ test-stubs.c:243:1: note: type mismatch in parameter 2 243 | keyserver_import_ldap (const char *name) | ^ test-stubs.c:243:1: note: 'keyserver_import_ldap' was previously declared here keyserver-internal.h:57:5: warning: type of 'keyserver_import_name' does not match original declaration [-Wlto-type-mismatch] 57 | int keyserver_import_name (ctrl_t ctrl, | ^ test-stubs.c:224:1: note: type mismatch in parameter 3 224 | keyserver_import_name (const char *name,struct keyserver_spec *spec) | ^ test-stubs.c:224:1: note: 'keyserver_import_name' was previously declared here keyserver-internal.h:50:5: warning: type of 'keyserver_import_cert' does not match original declaration [-Wlto-type-mismatch] 50 | int keyserver_import_cert (ctrl_t ctrl, const char *name, int dane_mode, | ^ test-stubs.c:205:1: note: type mismatch in parameter 2 205 | keyserver_import_cert (const char *name) | ^ test-stubs.c:205:1: note: 'keyserver_import_cert' was previously declared here keyserver-internal.h:44:5: warning: type of 'keyserver_import_keyid' does not match original declaration [-Wlto-type-mismatch] 44 | int keyserver_import_keyid (ctrl_t ctrl, u32 *keyid, | ^ test-stubs.c:184:1: note: type mismatch in parameter 3 184 | keyserver_import_keyid (u32 *keyid, void *dummy, unsigned int flags) | ^ test-stubs.c:184:1: note: 'keyserver_import_keyid' was previously declared here photoid.h:31:6: warning: type of 'show_photos' does not match original declaration [-Wlto-type-mismatch] 31 | void show_photos (ctrl_t ctrl, const struct user_attribute *attrs, int count, | ^ test-stubs.c:374:1: note: type mismatch in parameter 2 374 | show_photos (const struct user_attribute *attrs, int count, PKT_public_key *pk) | ^ test-stubs.c:374:1: note: 'show_photos' was previously declared here keyserver-internal.h:35:24: warning: type of 'parse_keyserver_uri' does not match original declaration [-Wlto-type-mismatch] 35 | struct keyserver_spec *parse_keyserver_uri (const char *string, | ^ test-stubs.c:356:1: note: type mismatch in parameter 3 356 | parse_keyserver_uri (const char *uri, int require_scheme, | ^ test-stubs.c:356:1: note: 'parse_keyserver_uri' was previously declared here keyserver-internal.h:60:5: warning: type of 'keyserver_import_ldap' does not match original declaration [-Wlto-type-mismatch] 60 | int keyserver_import_ldap (ctrl_t ctrl, const char *name, | ^ test-stubs.c:243:1: note: type mismatch in parameter 2 243 | keyserver_import_ldap (const char *name) | ^ test-stubs.c:243:1: note: 'keyserver_import_ldap' was previously declared here keyserver-internal.h:57:5: warning: type of 'keyserver_import_name' does not match original declaration [-Wlto-type-mismatch] 57 | int keyserver_import_name (ctrl_t ctrl, | ^ test-stubs.c:224:1: note: type mismatch in parameter 3 224 | keyserver_import_name (const char *name,struct keyserver_spec *spec) | ^ test-stubs.c:224:1: note: 'keyserver_import_name' was previously declared here keyserver-internal.h:50:5: warning: type of 'keyserver_import_cert' does not match original declaration [-Wlto-type-mismatch] 50 | int keyserver_import_cert (ctrl_t ctrl, const char *name, int dane_mode, | ^ test-stubs.c:205:1: note: type mismatch in parameter 2 205 | keyserver_import_cert (const char *name) | ^ test-stubs.c:205:1: note: 'keyserver_import_cert' was previously declared here keyserver-internal.h:44:5: warning: type of 'keyserver_import_keyid' does not match original declaration [-Wlto-type-mismatch] 44 | int keyserver_import_keyid (ctrl_t ctrl, u32 *keyid, | ^ test-stubs.c:184:1: note: type mismatch in parameter 3 184 | keyserver_import_keyid (u32 *keyid, void *dummy, unsigned int flags) | ^ test-stubs.c:184:1: note: 'keyserver_import_keyid' was previously declared here photoid.h:31:6: warning: type of 'show_photos' does not match original declaration [-Wlto-type-mismatch] 31 | void show_photos (ctrl_t ctrl, const struct user_attribute *attrs, int count, | ^ gpgv.c:617:1: note: type mismatch in parameter 2 617 | show_photos (const struct user_attribute *attrs, int count, PKT_public_key *pk) | ^ gpgv.c:617:1: note: 'show_photos' was previously declared here keyserver-internal.h:35:24: warning: type of 'parse_keyserver_uri' does not match original declaration [-Wlto-type-mismatch] 35 | struct keyserver_spec *parse_keyserver_uri (const char *string, | ^ gpgv.c:599:1: note: type mismatch in parameter 3 599 | parse_keyserver_uri (const char *uri, int require_scheme, | ^ gpgv.c:599:1: note: 'parse_keyserver_uri' was previously declared here keyserver-internal.h:60:5: warning: type of 'keyserver_import_ldap' does not match original declaration [-Wlto-type-mismatch] 60 | int keyserver_import_ldap (ctrl_t ctrl, const char *name, | ^ gpgv.c:485:1: note: type mismatch in parameter 2 485 | keyserver_import_ldap (const char *name) | ^ gpgv.c:485:1: note: 'keyserver_import_ldap' was previously declared here keyserver-internal.h:57:5: warning: type of 'keyserver_import_name' does not match original declaration [-Wlto-type-mismatch] 57 | int keyserver_import_name (ctrl_t ctrl, | ^ gpgv.c:466:1: note: type mismatch in parameter 3 466 | keyserver_import_name (const char *name,struct keyserver_spec *spec) | ^ gpgv.c:466:1: note: 'keyserver_import_name' was previously declared here keyserver-internal.h:50:5: warning: type of 'keyserver_import_cert' does not match original declaration [-Wlto-type-mismatch] 50 | int keyserver_import_cert (ctrl_t ctrl, const char *name, int dane_mode, | ^ gpgv.c:447:1: note: type mismatch in parameter 2 447 | keyserver_import_cert (const char *name) | ^ gpgv.c:447:1: note: 'keyserver_import_cert' was previously declared here keyserver-internal.h:44:5: warning: type of 'keyserver_import_keyid' does not match original declaration [-Wlto-type-mismatch] 44 | int keyserver_import_keyid (ctrl_t ctrl, u32 *keyid, | ^ gpgv.c:426:1: note: type mismatch in parameter 3 426 | keyserver_import_keyid (u32 *keyid, void *dummy, unsigned int flags) | ^ gpgv.c:426:1: note: 'keyserver_import_keyid' was previously declared here certchain.c:2123:1: note: in a call to function 'gpgsm_validate_chain' 2123 | gpgsm_validate_chain (ctrl_t ctrl, ksba_cert_t cert, ksba_isotime_t checktime, | ^ cvt-openpgp.h:27:13: warning: type of 'convert_from_openpgp_native' does not match original declaration [-Wlto-type-mismatch] 27 | gpg_error_t convert_from_openpgp_native (ctrl_t ctrl, | ^ t-protect.c:344:1: note: type mismatch in parameter 4 344 | convert_from_openpgp_native (gcry_sexp_t s_pgp, const char *passphrase, | ^ t-protect.c:344:1: note: 'convert_from_openpgp_native' was previously declared here
In this case it is not about don't consult the return code or casting sometning byt messy declaration in header files and .c files.
Please have look closer one more time on [-Wlto-type-mismatch] warnings.
Jun 27 2021
g10/getkey.c
Jun 26 2021
Thanks for the report. Fixed.
wk at gnupg dot org but better avoid any HTML parts etc.
Jun 25 2021
Thanks for the report.