Page MenuHome GnuPG
Feed All Stories

Nov 15 2021

ikloecker committed rLIBKLEO75e0d5096e5d: Add helpers for reading/writing key groups from/to a file (authored by ikloecker).
Add helpers for reading/writing key groups from/to a file
Nov 15 2021, 3:26 PM
werner added a comment to T5690: Kleopatra: Custom placeholder text in newcertificatewizard.

Can you given a example on how this would look like. In particulr are placeholders some kind of forced template or just a grey background text?

Nov 15 2021, 3:23 PM · kleopatra, Restricted Project
aheinecke triaged T5690: Kleopatra: Custom placeholder text in newcertificatewizard as Normal priority.
Nov 15 2021, 2:05 PM · kleopatra, Restricted Project
aheinecke updated the task description for T5689: Kleopatra: Make config pages hideable again.
Nov 15 2021, 2:01 PM · kleopatra, Restricted Project
aheinecke triaged T5689: Kleopatra: Make config pages hideable again as Normal priority.
Nov 15 2021, 2:00 PM · kleopatra, Restricted Project
aheinecke triaged T5688: Kleopatra: Configure to hide CSR creation as Normal priority.
Nov 15 2021, 1:57 PM · kleopatra, Restricted Project
werner committed rWc0b369015aac: appimage: Fix new --devel option (authored by werner).
appimage: Fix new --devel option
Nov 15 2021, 12:06 PM
wrobelda added a comment to T5687: "/mkheader.exe: cannot execute binary file: Exec format error" when cross compiling on Windows.

Please also refer to https://github.com/microsoft/vcpkg/discussions/20755 where we discuss on how to approach GnuPG libraries for a native Windows compilation.

Nov 15 2021, 11:30 AM · Bug Report
wrobelda added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

Also, and I should maybe have opened with it, the issues vcpkg has with your build system are currently tracked here, while my effort to build gpg-error natively (i.e. without relying on ShiftMediaProject fork) on all platforms is here.

Nov 15 2021, 11:27 AM · MacOS, gpgrt, Cross-Compiler, libgcrypt
wrobelda added a comment to T5687: "/mkheader.exe: cannot execute binary file: Exec format error" when cross compiling on Windows.

FWIW, the gnupg installer comes with dll, header and import files. You may use them.

Nov 15 2021, 11:23 AM · Bug Report
wrobelda added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

Let me clarify the use case of gpg-error.m4.

gpg-error.m4 is for GnuPG and its friends, where we cannot assume availability of pkg-config. Its capability is limited, and we don't pursue 100% compatibility of pkg-config.

Nov 15 2021, 11:16 AM · MacOS, gpgrt, Cross-Compiler, libgcrypt
ikloecker committed rW35b689e3543a: appimage: Fix typo (authored by ikloecker).
appimage: Fix typo
Nov 15 2021, 10:19 AM
werner triaged T5668: gpgme: gpgme_op_query_swdb() does not report error from gpgconf as Normal priority.
Nov 15 2021, 7:46 AM · Restricted Project, gpgme, Bug Report
werner closed T5670: gpgconf --query-swdb incorrectly handles pre-release version numbers as Wontfix.
Nov 15 2021, 7:45 AM · gpg4win, Bug Report
werner closed T5667: gpg(v) prints the human-readable form of notations to the status-fd as Resolved.
Nov 15 2021, 7:43 AM · Bug Report
werner triaged T5686: GitHub mirror out of date as Normal priority.
Nov 15 2021, 7:43 AM · Feature Request, dev.gnupg.org
werner added a comment to T5686: GitHub mirror out of date.

No, our admin left us and took all scripts and docs with him. We need to set it up again. You better use this system anyway, patches etc on GitHib are not used.

Nov 15 2021, 7:42 AM · Feature Request, dev.gnupg.org
werner changed the status of T5687: "/mkheader.exe: cannot execute binary file: Exec format error" when cross compiling on Windows from Resolved to Wontfix.
Nov 15 2021, 7:40 AM · Bug Report
werner closed T5687: "/mkheader.exe: cannot execute binary file: Exec format error" when cross compiling on Windows as Resolved.

GnuPG requires a Unix system to build. We do not support building natively on Windows. Sorry.

Nov 15 2021, 7:40 AM · Bug Report
gniibe committed rCec671cfa2398: random: Include getentropy random module. (authored by gniibe).
random: Include getentropy random module.
Nov 15 2021, 7:13 AM
gniibe committed rCcebe5c78a949: random:getentropy: Limit the size of buffer in exact size. (authored by gniibe).
random:getentropy: Limit the size of buffer in exact size.
Nov 15 2021, 7:13 AM
gniibe committed rCe562e34c824d: build: Support rndgetentropy random module. (authored by gniibe).
build: Support rndgetentropy random module.
Nov 15 2021, 7:13 AM
gniibe committed rC6de43f11c625: random:getentropy: Simplify more. (authored by gniibe).
random:getentropy: Simplify more.
Nov 15 2021, 7:13 AM
gniibe committed rCa8395fd7a40f: random: Simplify rndgetentropy. (authored by gniibe).
random: Simplify rndgetentropy.
Nov 15 2021, 7:13 AM
gniibe committed rCf36bfe7ec1b2: random: Start rnd-getentropy.c. (authored by gniibe).
random: Start rnd-getentropy.c.
Nov 15 2021, 7:13 AM
gniibe added a project to T5682: ed25519 internal authenticate with openpgpcard may send long data over short apdu: Restricted Project.
Nov 15 2021, 3:53 AM · Restricted Project, scd, ssh, Bug Report
gniibe added a comment to T5682: ed25519 internal authenticate with openpgpcard may send long data over short apdu.

Adding the check on host side, I pushed the change: rGa575b0aba542: scd:openpgp: Support longer data for INTERNAL_AUTHENTICATE.

Nov 15 2021, 3:53 AM · Restricted Project, scd, ssh, Bug Report
gniibe committed rGa575b0aba542: scd:openpgp: Support longer data for INTERNAL_AUTHENTICATE. (authored by gniibe).
scd:openpgp: Support longer data for INTERNAL_AUTHENTICATE.
Nov 15 2021, 3:53 AM
gniibe added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

Let me clarify the use case of gpg-error.m4.

Nov 15 2021, 2:30 AM · MacOS, gpgrt, Cross-Compiler, libgcrypt
gniibe added a comment to T5393: gnupg coverity static analysis reports.

Or, we can use memcmp to avoid arguing semantics of strncmp, and make it a bit cleaner to avoid calling strlen multple times by put_membuf_str.

diff --git a/g10/export.c b/g10/export.c
index 98c4623cf..c7cfcfaa4 100644
--- a/g10/export.c
+++ b/g10/export.c
@@ -2133,14 +2133,15 @@ key_to_sshblob (membuf_t *mb, const char *identifier, ...)
   size_t buflen;
   gcry_mpi_t a;
Nov 15 2021, 2:08 AM · gnupg (gpg23), Bug Report
wrobelda added a comment to T5365: --with-libgpg-error-prefix doesn't affect gpgrt-config path detection.

If it is new, it may be the change of this commit rC8e3cd4c4677c: build: Update gpg-error.m4.

Nov 15 2021, 1:22 AM · MacOS, gpgrt, Cross-Compiler, libgcrypt
gniibe added a comment to T5393: gnupg coverity static analysis reports.

We know that problematic strncmp implementation: T5443
So, I don't blame Coverity. But I think that it's better to fix strncmp implementation.

Nov 15 2021, 1:13 AM · gnupg (gpg23), Bug Report
gniibe added a comment to rGb124bca592e1: gpg: Don't use malloc for kek_params..

The old code using sizeof(kek_params) (which is used for log_printhex) is incorrect; the value is the size of pointer to byte. It may works for 32-bit architectures, though.
On the machine which has 8 for a pointer, it will cause accessing wrong area, when DPG_CRYPTO is enabled.

Nov 15 2021, 1:00 AM
wrobelda added a comment to T5687: "/mkheader.exe: cannot execute binary file: Exec format error" when cross compiling on Windows.

I tried following the README instructions, but getting:

Nov 15 2021, 12:17 AM · Bug Report
wrobelda added a comment to T5687: "/mkheader.exe: cannot execute binary file: Exec format error" when cross compiling on Windows.

I just read https://github.com/gpg/libgpg-error/blob/master/README#L119 and realize this is by design...

Nov 15 2021, 12:12 AM · Bug Report
wrobelda updated the task description for T5687: "/mkheader.exe: cannot execute binary file: Exec format error" when cross compiling on Windows.
Nov 15 2021, 12:00 AM · Bug Report
wrobelda updated the task description for T5687: "/mkheader.exe: cannot execute binary file: Exec format error" when cross compiling on Windows.
Nov 15 2021, 12:00 AM · Bug Report
wrobelda updated the task description for T5687: "/mkheader.exe: cannot execute binary file: Exec format error" when cross compiling on Windows.
Nov 15 2021, 12:00 AM · Bug Report

Nov 14 2021

wrobelda updated the task description for T5687: "/mkheader.exe: cannot execute binary file: Exec format error" when cross compiling on Windows.
Nov 14 2021, 11:59 PM · Bug Report
wrobelda updated the task description for T5687: "/mkheader.exe: cannot execute binary file: Exec format error" when cross compiling on Windows.
Nov 14 2021, 11:59 PM · Bug Report
wrobelda created T5687: "/mkheader.exe: cannot execute binary file: Exec format error" when cross compiling on Windows.
Nov 14 2021, 11:58 PM · Bug Report
wrobelda created T5686: GitHub mirror out of date.
Nov 14 2021, 9:57 PM · Feature Request, dev.gnupg.org
werner committed rW578ea4764731: appimage: Add a --devel option to the docker build script. (authored by werner).
appimage: Add a --devel option to the docker build script.
Nov 14 2021, 6:41 PM
werner committed rGa43efc9294d1: agent: Print the non-option warning earlier. (authored by werner).
agent: Print the non-option warning earlier.
Nov 14 2021, 6:32 PM
werner committed rG027e34235bc5: build: Fix several "include file not found" problems (authored by ikloecker).
build: Fix several "include file not found" problems
Nov 14 2021, 6:32 PM
werner committed rW1f99eba52eb2: appimage: Fix the version extraction. (authored by werner).
appimage: Fix the version extraction.
Nov 14 2021, 6:32 PM
werner committed rGbd5c775878fd: agent: Print the non-option warning earlier. (authored by werner).
agent: Print the non-option warning earlier.
Nov 14 2021, 6:07 PM
werner committed rW7fd576a75698: packages: Update libgpg-error to 1.43 (authored by werner).
packages: Update libgpg-error to 1.43
Nov 14 2021, 5:16 PM
werner committed rW30922599b6be: appimage: Allow building a VSD version and rename AppImage name (authored by werner).
appimage: Allow building a VSD version and rename AppImage name
Nov 14 2021, 4:33 PM
werner committed rW392d05d69e70: appimage: Extend the AppRun (authored by werner).
appimage: Extend the AppRun
Nov 14 2021, 1:44 PM
Laurent Montel <montel@kde.org> committed rLIBKLEO8938bf0a4b53: GIT_SILENT: time to increase version (authored by Laurent Montel <montel@kde.org>).
GIT_SILENT: time to increase version
Nov 14 2021, 1:35 PM
Laurent Montel <montel@kde.org> committed rKLEOPATRA32a61afe6da5: GIT_SILENT: time to increase version (authored by Laurent Montel <montel@kde.org>).
GIT_SILENT: time to increase version
Nov 14 2021, 1:33 PM
werner committed rDac919c7c52b7: ids: draft-koch-openpgp-webkey-service-13.txt (authored by werner).
ids: draft-koch-openpgp-webkey-service-13.txt
Nov 14 2021, 11:59 AM

Nov 13 2021

werner closed T5685: Clear stale --trusted-key records from the trustdb, a subtask of T5058: Review --trusted-key, as Resolved.
Nov 13 2021, 9:03 PM · gnupg24, gnupg (gpg23)
werner closed T5685: Clear stale --trusted-key records from the trustdb as Resolved.
Nov 13 2021, 9:03 PM · gnupg
werner committed rGa9bc8e169567: Update release signing keys (authored by werner).
Update release signing keys
Nov 13 2021, 9:03 PM
werner committed rGd2b2dc4549f2: Update release signing keys (authored by werner).
Update release signing keys
Nov 13 2021, 9:02 PM
werner committed rGbc6d56282ec9: gpg: Remove stale ultimately trusted keys from the trustdb. (authored by werner).
gpg: Remove stale ultimately trusted keys from the trustdb.
Nov 13 2021, 9:02 PM
werner committed rG8fe3f5764347: gpgconf: New command --show-configs. (authored by werner).
gpgconf: New command --show-configs.
Nov 13 2021, 9:02 PM
werner committed rG99ef78aa0ca7: gpg: Remove stale ultimately trusted keys from the trustdb. (authored by werner).
gpg: Remove stale ultimately trusted keys from the trustdb.
Nov 13 2021, 8:44 PM
werner triaged T5685: Clear stale --trusted-key records from the trustdb as Normal priority.
Nov 13 2021, 8:13 PM · gnupg
werner committed rG6507c6ab101e: agent,dirmngr: New option --steal-socket (authored by werner).
agent,dirmngr: New option --steal-socket
Nov 13 2021, 3:09 PM
werner committed rGb0079ab39d31: keyboxd: New option --steal-socket. (authored by werner).
keyboxd: New option --steal-socket.
Nov 13 2021, 3:05 PM
werner committed rGdd708f60d5cf: agent,dirmngr: New option --steal-socket (authored by werner).
agent,dirmngr: New option --steal-socket
Nov 13 2021, 3:05 PM
werner committed rG6d52cb966e0e: doc: Clarify the "ntds" AKL mechanism. (authored by werner).
doc: Clarify the "ntds" AKL mechanism.
Nov 13 2021, 3:05 PM
werner closed T5301: Decrypting a message that has multiple SKESK packets sometimes fails as Wontfix.
Nov 13 2021, 2:43 PM · gnupg (gpg22), Bug Report
werner closed T5607: Fingerprint signing fails with 'gpg: signing failed: No secret key' as Resolved.
Nov 13 2021, 2:42 PM · Support, Info Needed, gnupg (gpg22)
werner edited projects for T5331: Possibly incompatible Ed25519 signature between other implementations and 2.3-bata, added: gnupg (gpg23); removed gnupg (gpg22).
Nov 13 2021, 2:38 PM · gnupg (gpg23), Bug Report
werner set Due Date to Apr 30 2022, 12:00 AM on T5684: Allow to categorize X.509 PKIs.
Nov 13 2021, 12:37 PM · Restricted Project, S/MIME, kleopatra, gpgagent
werner triaged T5684: Allow to categorize X.509 PKIs as Normal priority.
Nov 13 2021, 12:35 PM · Restricted Project, S/MIME, kleopatra, gpgagent

Nov 12 2021

werner committed rG751b978ee1dc: doc: Clarify the "ntds" AKL mechanism. (authored by werner).
doc: Clarify the "ntds" AKL mechanism.
Nov 12 2021, 4:16 PM
werner triaged T5682: ed25519 internal authenticate with openpgpcard may send long data over short apdu as High priority.
Nov 12 2021, 12:53 PM · Restricted Project, scd, ssh, Bug Report
werner added a comment to T5682: ed25519 internal authenticate with openpgpcard may send long data over short apdu.

Okay, I revisited the code:

Nov 12 2021, 12:52 PM · Restricted Project, scd, ssh, Bug Report
werner added a comment to T1621: Support multiple cards (not just readers).

Do not user Reiner SCT those readers are all buggy and work only on Windows - if at all. Stay away from them and get a real reader and not the incompatible broken stuff from that company. I spent way too much time trying to get those readers working. That time is better invested in support for hardware which is standard compatible or are helpful to get stuff running.

Nov 12 2021, 12:36 PM · gnupg, Feature Request
werner added a comment to T5682: ed25519 internal authenticate with openpgpcard may send long data over short apdu.

The internal hashing of ed25519 is not used by OpenPGP but instead we pass the hash of the message to the ed25519 function and thus to the card. Pushing a message through a card is a no-go - way too slow for any normal sized message.

Nov 12 2021, 12:32 PM · Restricted Project, scd, ssh, Bug Report
kwinz added a comment to T1621: Support multiple cards (not just readers).

Some more info: OpenVPN does not care about the second reader only gnupg agent is sensitive to what is present when it is started. So a workaround that I just found is to disable the Virtual Smartcard reader first so that only the ReinerSCT smartcard reader with an OpenPGP V3.4 card is present. Make sure to open an SSH connection. Then reconnect the second reader. And reconnect to VPN. After the PIN for the OpenPGP V3.4 card is already cached and a connection to the card established I can also open more SSH connections with the second reader attached and disconnect and reconnect the VPN as I want.
Even removing the smartcard from the ReinerSCT reader and plugging it back in works and I can still authenticate with new SSH tunnels and both readers present. So it seems it is actually only important which readers are present when the agent connects for the first time.
So this is a practical woraround. Although disabling the TPM backed reader temporarily needs Admin rights and is really janky.

Nov 12 2021, 10:41 AM · gnupg, Feature Request
kwinz added a comment to T1621: Support multiple cards (not just readers).

I am on Windows 10 21H1 and I using gnupg-w32-2.3.3_20211012 from here [1]
Together with win-gpg-agent, which extends gnupg to play nicely with Windows sockets. [2]

Nov 12 2021, 10:23 AM · gnupg, Feature Request
klali added a comment to T5682: ed25519 internal authenticate with openpgpcard may send long data over short apdu.

Since hashing happens on-card for ed25519 I'm not sure what limits gpg wants to impose, currently the data is passed straight through and scdaemon will happily try to send more than 255 bytes of data as a short apdu here. My patch is probably not correct, I assume it needs to care about cardcap.ext_lc_le and chunking as well.

Nov 12 2021, 9:21 AM · Restricted Project, scd, ssh, Bug Report
werner added a comment to T5682: ed25519 internal authenticate with openpgpcard may send long data over short apdu.

That does not seem to be right. You don't need 255 bytes for an ECC key. It would be best to get scdaemon logs simialr to the gpg-agent logs. Set "debug ipc,cardio" into scdaemon.conf.

Nov 12 2021, 8:59 AM · Restricted Project, scd, ssh, Bug Report
werner added a comment to rGb124bca592e1: gpg: Don't use malloc for kek_params..

What is the rational for this change?

Nov 12 2021, 8:53 AM
vajinadaraltma updated vajinadaraltma.
Nov 12 2021, 8:50 AM
gniibe added a comment to T5393: gnupg coverity static analysis reports.

Under C11, it seems OK (strncmp).
https://stackoverflow.com/questions/38878195/does-this-usage-of-strncmp-contain-an-out-of-bounds-read

Nov 12 2021, 7:45 AM · gnupg (gpg23), Bug Report
gniibe committed rGfae1d2e2ccde: kbx: Avoid use of uninitialized value. (authored by Jakuje).
kbx: Avoid use of uninitialized value.
Nov 12 2021, 7:41 AM
gniibe committed rGb124bca592e1: gpg: Don't use malloc for kek_params. (authored by gniibe).
gpg: Don't use malloc for kek_params.
Nov 12 2021, 7:41 AM
gniibe committed rGd24c5df52b55: gpg: Avoid uninitialized revkey.fprlen. (authored by Jakuje).
gpg: Avoid uninitialized revkey.fprlen.
Nov 12 2021, 7:41 AM
gniibe committed rGae3d0bb8e77c: agent: Avoid uninitialized buffer. (authored by Jakuje).
agent: Avoid uninitialized buffer.
Nov 12 2021, 7:41 AM
gniibe committed rG50f32eb0664d: agent: Correctly free memory on error path. (authored by Jakuje).
agent: Correctly free memory on error path.
Nov 12 2021, 7:41 AM
gniibe committed rG50e6d63f12e7: tools: Avoid memory leak from gpgspilt. (authored by Jakuje).
tools: Avoid memory leak from gpgspilt.
Nov 12 2021, 7:41 AM
gniibe committed rGc0b99e6dbb26: gpg-pair-tool: Fix typos in protocol description. (authored by Jakuje).
gpg-pair-tool: Fix typos in protocol description.
Nov 12 2021, 7:41 AM
gniibe committed rGc0b1bcc5c6b5: scd: Avoid memory leak. (authored by Jakuje).
scd: Avoid memory leak.
Nov 12 2021, 7:41 AM
gniibe added a comment to T5393: gnupg coverity static analysis reports.

I applied most of gnupg-coverity.patch.

  • Part 1 is not applied; It should be handled later.
  • Part 2: applied
  • Part 3: applied
  • Part 4: applied, but spell fixes not require ChangeLog entry
  • Part 5
  • Part 6: applied
  • Part 7: applied, but empty initializer is GNU extension (or the way of C++), so first 0
  • Part 8: applied
  • Part 9: applied, but one more fix
Nov 12 2021, 7:28 AM · gnupg (gpg23), Bug Report
gniibe added a project to T5644: Heuristic for default reader detection: Restricted Project.
Nov 12 2021, 5:50 AM · Restricted Project, Feature Request, gnupg (gpg22)
gniibe triaged T5683: Deprecation of gpg-error-config as Wishlist priority.
Nov 12 2021, 5:49 AM · gpgrt
gniibe claimed T5682: ed25519 internal authenticate with openpgpcard may send long data over short apdu.
Nov 12 2021, 5:42 AM · Restricted Project, scd, ssh, Bug Report
gniibe committed rEfd83c3e29744: build: Fix for configure generated files. (authored by gniibe).
build: Fix for configure generated files.
Nov 12 2021, 4:11 AM
gniibe committed rE1e5b17f4284e: configure: Escape includedir/libdir to defer interpretation of vars. (authored by gniibe).
configure: Escape includedir/libdir to defer interpretation of vars.
Nov 12 2021, 3:45 AM
gniibe committed rM4583ab77e5af: gpgme.pc: Fix library dependency and use of includedir, libdir. (authored by gniibe).
gpgme.pc: Fix library dependency and use of includedir, libdir.
Nov 12 2021, 3:14 AM
gniibe committed rM1cedac2bba24: tests: Build using GPG_ERROR_MT_LIBS for thread use. (authored by gniibe).
tests: Build using GPG_ERROR_MT_LIBS for thread use.
Nov 12 2021, 3:14 AM
gniibe committed rTc612c4f16494: ntbtls.pc: Fix library dependency. (authored by gniibe).
ntbtls.pc: Fix library dependency.
Nov 12 2021, 2:07 AM
gniibe committed rT612351adc7ca: build: Fix library dependency for ntbtls-cli test program. (authored by gniibe).
build: Fix library dependency for ntbtls-cli test program.
Nov 12 2021, 2:07 AM