In T5939#157259, @werner wrote:You should not use log messages because they are subject to change and they are translated. Let us return an ERROR status instead.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Apr 25 2022
Apr 25 2022
• ikloecker triaged T5943: gpg: Report details about failed symmetric decrypt with ERROR status as Normal priority.
• ikloecker changed the status of T5939: Kleopatra: Better error for wrong password in symmetric decryption from Testing to Open.
• werner added a comment to T5935: scd: SSH emulation of gpg-agent doesn't work well with sntrup761x25519-sha512@openssh.com.
We are using rsa-4096 on smartcard for quite some time; so I wonder what's the problem here. Is that that we don't use our Assuan hack for large key material with OpenPGP.3?
• gniibe added a comment to T5935: scd: SSH emulation of gpg-agent doesn't work well with sntrup761x25519-sha512@openssh.com.
There is another case: RSA-4096 key. scdaemon rejects data by Invalid value. Unfortunately, there is no fix for this, as it's really too large. Even if scdaemon allows larger data, the card implementation rejects, when it conforms to PKCS #1 standard (data should not be larger than 40% of the modulus).
• gniibe committed rG2848fe4c84e5: scd: Fix hard-coded constant for RSA auth. (authored by • gniibe).
scd: Fix hard-coded constant for RSA auth.
Thank you for the bug report.
• gniibe renamed T5941: gnupg 2.3.5 hangs on key import from gnupg 1.3.5 hangs on key import to gnupg 2.3.5 hangs on key import.
Apr 24 2022
Apr 24 2022
Carlo Vanini <silhusk@gmail.com> committed rKLEOPATRA19be93f095a4: File name extension can be longer than 3 character (authored by Carlo Vanini <silhusk@gmail.com>).
File name extension can be longer than 3 character
• werner added a comment to T5939: Kleopatra: Better error for wrong password in symmetric decryption.
You should not use log messages because they are subject to change and they are translated. Let us return an ERROR status instead.
Laurent Montel <montel@kde.org> committed rLIBKLEO7447a1b7ce68: GIT_SILENT: prepare 5.20.1 (authored by Laurent Montel <montel@kde.org>).
GIT_SILENT: prepare 5.20.1
Laurent Montel <montel@kde.org> committed rKLEOPATRAb3161638fbfc: GIT_SILENT: prepare 5.20.1 (authored by Laurent Montel <montel@kde.org>).
GIT_SILENT: prepare 5.20.1
Apr 23 2022
Apr 23 2022
Apr 22 2022
Apr 22 2022
Laurent Montel <montel@kde.org> committed rLIBKLEOb33b73518168: GIT_SILENT: prepare 5.20.1 (authored by Laurent Montel <montel@kde.org>).
GIT_SILENT: prepare 5.20.1
• werner triaged T5936: gpg: Support specifiying user ID to revoke as UID hash for --quick-revoke-uid as High priority.
Should also go into 2.2
• werner accepted D552: gpg: Support specifiying user ID to revoke as UID hash for --quick-revoke-uid.
The rest of the code looks fine.
• ikloecker committed rMd8e5871dca94: qt: Report better error if decryption failed because of bad passphrase (authored by • ikloecker).
qt: Report better error if decryption failed because of bad passphrase
• ikloecker committed rM321c8a0254f4: cpp: Allow changing the error of a result (authored by • ikloecker).
cpp: Allow changing the error of a result
• ikloecker changed the status of T5939: Kleopatra: Better error for wrong password in symmetric decryption from Open to Testing.
I have added the check for a possibly wrong symmetric password to QGpgMEDecryptVerifyJob because it relies on logging messages emitted by gpg which are not part of gpg's status API.
• ikloecker moved T5939: Kleopatra: Better error for wrong password in symmetric decryption from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ikloecker added a comment to T5939: Kleopatra: Better error for wrong password in symmetric decryption.
The error
gpg: decryption failed: Bad session key
is only logged if the sanity check "algo given in decrypted session key is a valid OpenPGP algo" passes even though a wrong password was given (which happens with a chance of 11:256). If the sanity check detects a bad algo then gpg logs
gpg: decryption of the symmetrically encrypted session key failed: Checksum error
If AEAD is used, then other logging will happen.
• aheinecke triaged T5939: Kleopatra: Better error for wrong password in symmetric decryption as Normal priority.
Minor fix in gpg4win.mk.in
doc: Update READMEs
Allow authenticode signing using a card.
• ikloecker committed rKLEOPATRA670728a271d2: Share generally useful helpers (authored by • ikloecker).
Share generally useful helpers
Update NEWS for todays release
Bump 4.x Version to 4.0.1
Update kde-l10n and kleopatra
• aheinecke committed rW8655444076b6: Grammar and spelling fixes for NEWS (authored by • aheinecke).
Grammar and spelling fixes for NEWS
Add GpgEX NEWS entry
Update to GnuPG 2.3.5
I tend to avoid such changes to keep the translations valid. But for master this is okay.
gpg: Fix line end in error message
Bump version to 3.1.22
• aheinecke committed rKLEOPATRA81879ec97eb9: Fix display of non compliance after decrypt (authored by • aheinecke).
Fix display of non compliance after decrypt
The links for the Windows installer as given in the mail was wrong. The corrected links are
• gniibe added a project to T5935: scd: SSH emulation of gpg-agent doesn't work well with sntrup761x25519-sha512@openssh.com: Restricted Project.
• gniibe closed T5538: gpg-agent's keytocard cmd should use a better default creation time. as Resolved.
• gniibe closed T5758: scd: loop forever with reader_port, when open_pcsc_reader failed as Resolved.
• gniibe closed T5884: dotlock is not perfect (errornously remove .lock as stale lockfile) as Resolved.
• gniibe closed T5884: dotlock is not perfect (errornously remove .lock as stale lockfile), a subtask of T5109: Initial socket connection to server, as Resolved.
• gniibe added projects to T5917: gpg-agent: Not writing password into file: Restricted Project, gpgagent, Bug Report.
agent: Not writing password into file.
• gniibe committed rGe8fb8e2b3e66: scd: Don't inhibit SSH authentication for larger data if it can. (authored by • gniibe).
scd: Don't inhibit SSH authentication for larger data if it can.
• gniibe added a comment to T5935: scd: SSH emulation of gpg-agent doesn't work well with sntrup761x25519-sha512@openssh.com.
I confirmed that the patch above works with newer Gnuk (>= 1.2.16).
Apr 21 2022
Apr 21 2022
swdb: GnuPG 2.3.5
• werner set External Link to https://lists.gnupg.org/pipermail/gnupg-announce/2022q2/000472.html on T5743: Release GnuPG 2.3.5.
Release 2.3.5
Post release updates
• ikloecker committed rKLEOPATRA5df72613f43b: Ensure that the key details are loaded when keys were reloaded (authored by • ikloecker).
Ensure that the key details are loaded when keys were reloaded
• ikloecker committed rKLEOPATRAb035e01d57e1: Unify updating of key after key was changed (authored by • ikloecker).
Unify updating of key after key was changed
• ikloecker committed rKLEOPATRA0b6290a47528: Connect the signal only once (authored by • ikloecker).
Connect the signal only once
• ikloecker committed rKLEOPATRA3ac9f23e07bc: Ask for confirmation before revoking a user ID (authored by • ikloecker).
Ask for confirmation before revoking a user ID
• ikloecker committed rKLEOPATRA6df84274eb17: Disable "Revoke User ID" action for last "valid" user ID (authored by • ikloecker).
Disable "Revoke User ID" action for last "valid" user ID
• ikloecker committed rKLEOPATRAc5e2514e3fb3: Add the possibility to revoke a user ID (authored by • ikloecker).
Add the possibility to revoke a user ID
speedo: Fix authenticode signing
po: Auto update
dirmngr: Fix Makefile
• aheinecke committed rW1bae03cb824d: Update kde-l10n with latest german translation (authored by • aheinecke).
Update kde-l10n with latest german translation
Post release version bump
Update NEWS for todays relase
• aheinecke committed rX548de964824d: Add registry config for default command (authored by • aheinecke).
Add registry config for default command
Update GpgOL to 2.5.3
Update gpgex to 1.0.9
swdb: Release gpgex 1.0.9
For the record the Task for the fingerprint copy was T5776
I tend to disagree. The fingerprint is a very long and cryptic looking thing. Most users of Kleopatra will never share their fingerprint as they tend to work on a TOFU model, just accepting a given key and using it. For another bunch of users the long keyid, which we show, is more then enough security. And for the VS-NfD case with very high security where users compare a full fingerprint it is accessibile enough.
• werner triaged T5935: scd: SSH emulation of gpg-agent doesn't work well with sntrup761x25519-sha512@openssh.com as Normal priority.
• gniibe added a comment to T5935: scd: SSH emulation of gpg-agent doesn't work well with sntrup761x25519-sha512@openssh.com.
With newer Gnuk Token, following patch should work:
diff --git a/scd/app-openpgp.c b/scd/app-openpgp.c index 05e1f3977..439052f8c 100644 --- a/scd/app-openpgp.c +++ b/scd/app-openpgp.c @@ -5490,6 +5490,11 @@ do_auth (app_t app, ctrl_t ctrl, const char *keyidstr, exmode = 1; /* Use extended length. */ le_value = app->app_local->keyattr[2].rsa.n_bits / 8; } + else if (app->app_local->cardcap.cmd_chaining && indatalen > 254) + { + exmode = -254; /* Command chaining with max. 254 bytes. */ + le_value = 0; + } else if (indatalen > 255) { if (!app->app_local->cardcap.ext_lc_le)
• gniibe set External Link to https://bugs.debian.org/1008573 on T5935: scd: SSH emulation of gpg-agent doesn't work well with sntrup761x25519-sha512@openssh.com.
• gniibe committed rG3560cd0d9d79: po: Update Simplified Chinese Translation. (authored by • gniibe).
po: Update Simplified Chinese Translation.
• gniibe committed rC299e2f934159: tests: Replace custom bit with more generic flags (authored by Jakuje).
tests: Replace custom bit with more generic flags
• gniibe committed rCf736f3c70182: tests: Expect the RSA PKCS #1.5 encryption to fail in FIPS mode (authored by Jakuje).
tests: Expect the RSA PKCS #1.5 encryption to fail in FIPS mode
• gniibe committed rCc7709f7b2384: Do not allow PKCS #1.5 padding for encryption in FIPS (authored by Jakuje).
Do not allow PKCS #1.5 padding for encryption in FIPS
• gniibe committed rCf436bf4451cb: random: Not use secure memory for DRBG instance. (authored by • gniibe).
random: Not use secure memory for DRBG instance.
Apr 20 2022
Apr 20 2022
• ikloecker committed rLIBKLEO3bb2b74b57c2: Add clang-format git pre-commit hook (authored by • ikloecker).
Add clang-format git pre-commit hook
• ikloecker committed rLIBKLEO8c0c18f09ff7: GIT_SILENT Clear list of words to ignore by codespell (authored by • ikloecker).
GIT_SILENT Clear list of words to ignore by codespell
Run clang-format