Using SLOT doesn't work anymore. The "slot" needs to be a std::function<void(bool)> (e.g. a lambda) now. Moreover, the trailing false, true is not required anymore (because of suitable enum value defaults for those action_data members).

Jul 20 2022, 4:39 PM · kleopatra, Restricted Project

• ikloecker changed the status of T6096: Kleopatra: Add "include-default" when creating a new trustlist.txt from Open to Testing.

I have used the same header blurb as gpg-agent (https://dev.gnupg.org/source/gnupg/browse/master/agent/trustlist.c$60-73) with an additional comment about the include-default statement.

Jul 20 2022, 4:28 PM · kleopatra, Restricted Project

• ikloecker committed rKLEOPATRA2f357f08ff9b: Avoid duplicating the last empty line when writing back lines (authored by • ikloecker).

Avoid duplicating the last empty line when writing back lines

Jul 20 2022, 4:23 PM

• ikloecker committed rKLEOPATRAb569a1b22e4b: Write comment lines with DN attributes to trust list file (authored by • ikloecker).

Write comment lines with DN attributes to trust list file

Jul 20 2022, 4:23 PM

• ikloecker committed rKLEOPATRA58c7ecceb32c: Append optional relax flag to (un)trusted root certificates (authored by • ikloecker).

Append optional relax flag to (un)trusted root certificates

Jul 20 2022, 4:23 PM

• ikloecker committed rKLEOPATRA8e05bd711386: Write header blurb to start of newly created trustlist.txt (authored by • ikloecker).

Write header blurb to start of newly created trustlist.txt

Jul 20 2022, 4:23 PM

• aheinecke added a comment to T5989: Kleopatra: Customization Window Title and custom Logo from VERSION file.

To add an icon:

Jul 20 2022, 2:39 PM · kleopatra, Restricted Project

• ikloecker committed rKLEOPATRAdd4e553d241a: Prevent scroll area embedding config page from receiving focus (authored by • ikloecker).

Prevent scroll area embedding config page from receiving focus

Jul 20 2022, 12:47 PM

• ikloecker committed rKLEOPATRA6121172d17c0: Ensure correct tab order (authored by • ikloecker).

Ensure correct tab order

Jul 20 2022, 12:47 PM

• aheinecke triaged T6096: Kleopatra: Add "include-default" when creating a new trustlist.txt as High priority.

Jul 20 2022, 12:07 PM · kleopatra, Restricted Project

• ikloecker moved T6095: Kleopatra: Fix accessibility of group configuration from Restricted Project Column to Restricted Project Column on the Restricted Project board.

Jul 20 2022, 12:05 PM · kleopatra, Restricted Project

• ikloecker triaged T6095: Kleopatra: Fix accessibility of group configuration as Normal priority.

Jul 20 2022, 12:05 PM · kleopatra, Restricted Project

• ikloecker closed T6088: Kleopatra: Improve accessibility of icon-only buttons, a subtask of T5824: Kleopatra: Full accessibility support, as Resolved.

Jul 20 2022, 11:56 AM · a11y, kleopatra

• ikloecker closed T6088: Kleopatra: Improve accessibility of icon-only buttons as Resolved.

I have added accessible names to all icon-only buttons created in libkleo and kleopatra. There may be buttons created by Qt or KDE Frameworks which lack an accessible name.

Jul 20 2022, 11:56 AM · kleopatra, Restricted Project

• ikloecker committed rKLEOPATRA509c6d0d1432: Set accessible names for a few icon-only buttons (authored by • ikloecker).

Set accessible names for a few icon-only buttons

Jul 20 2022, 11:49 AM

• ikloecker committed rLIBKLEO06e61fad64a6: Add accessible names for a few icon-only buttons (authored by • ikloecker).

Add accessible names for a few icon-only buttons

Jul 20 2022, 11:48 AM

• ikloecker committed rLIBKLEO7ec7eed4411d: GIT_SILENT Keep line breaks in initializer lists (authored by • ikloecker).

GIT_SILENT Keep line breaks in initializer lists

Jul 20 2022, 11:48 AM

• ikloecker committed rLIBKLEO1be06ea6b526: Improve some accessible names of icon-only buttons (authored by • ikloecker).

Improve some accessible names of icon-only buttons

Jul 20 2022, 11:48 AM

• aheinecke triaged T6094: Kleopatra: Make prefilled name and email address for new certificates configurable as Wishlist priority.

Jul 20 2022, 11:47 AM · vsd, gpd5x, kleopatra

Jul 19 2022

• ikloecker moved T6088: Kleopatra: Improve accessibility of icon-only buttons from Restricted Project Column to Restricted Project Column on the Restricted Project board.

Jul 19 2022, 3:39 PM · kleopatra, Restricted Project

• ikloecker closed T6089: Kleopatra: Make DN attribute order configuration accessible as Resolved.

I think the accessibility is okay now. It could be further improved with useful shortcuts for the different buttons, but the DN attribute order configuration is a rather unimportant UI of Kleopatra.

Jul 19 2022, 3:38 PM · kleopatra, Restricted Project

• ikloecker closed T6089: Kleopatra: Make DN attribute order configuration accessible, a subtask of T5824: Kleopatra: Full accessibility support, as Resolved.

Jul 19 2022, 3:38 PM · a11y, kleopatra

• ikloecker triaged T6091: Kleopatra: "Cancel" in the password dialog of "Print secret key" has no effect as Low priority.

The command needs to be ported away from running gpg --export-secret-key via QProcess to using QGpgME::ExportJob. I'll give this a low priority.

Jul 19 2022, 3:12 PM · vsd33 (vsd-3.3.0), kleopatra, Restricted Project

• ikloecker committed rLIBKLEO2b699430fbce: Explicitly include QStringBuilder for operator% (authored by • ikloecker).

Explicitly include QStringBuilder for operator%

Jul 19 2022, 2:47 PM

• gniibe committed rPTH70fb608c3bf7: build: Update config.guess and config.sub. (authored by • gniibe).

build: Update config.guess and config.sub.

Jul 19 2022, 2:15 PM

• ikloecker added a comment to T6092: Minor typo in documentation.

But then again: The three other apostrophes that occur in the text are represented by single quote characters. Maybe sticking to ASCII characters is the better fix after all.

Jul 19 2022, 12:41 PM · patch, Documentation, Bug Report

• ikloecker added a comment to T6092: Minor typo in documentation.

Typographically the apostrophe character ’ is a different character than the single quote character '. So, the correct fix would be to fix the probably wrong encoded apostrophe instead of replacing it by a single quote character.

Jul 19 2022, 12:38 PM · patch, Documentation, Bug Report

• ikloecker changed the status of T6090: Kleopatra: "Cancel" in the password dialog of "backup secret keys" has no effect from Open to Testing.

Kleopatra now silently ends the "backup secret key" operation if the password dialog was canceled.

Jul 19 2022, 12:29 PM · kleopatra, Restricted Project

tiagoepi added a project to T6092: Minor typo in documentation: patch.

Jul 19 2022, 12:24 PM · patch, Documentation, Bug Report

tiagoepi added a comment to T6092: Minor typo in documentation.

patch783 BDownload

Jul 19 2022, 12:24 PM · patch, Documentation, Bug Report

• ikloecker triaged T6093: gpg: Continues export of secret key if first passphrase dialog was canceled as Normal priority.

Jul 19 2022, 12:18 PM · gnupg22 (gnupg-2.2.42), gnupg24 (gnupg-2.4.1), Bug Report, Restricted Project

tiagoepi created T6092: Minor typo in documentation.

Jul 19 2022, 12:07 PM · patch, Documentation, Bug Report

• ikloecker triaged T6090: Kleopatra: "Cancel" in the password dialog of "backup secret keys" has no effect as Normal priority.

Jul 19 2022, 12:01 PM · kleopatra, Restricted Project

• ikloecker committed rKLEOPATRA4a3dcec0428a: Do not export anything if the user canceled the operation (authored by • ikloecker).

Do not export anything if the user canceled the operation

Jul 19 2022, 12:00 PM

• gniibe committed rE64bcee3c467d: build: Fix configure script. (authored by • gniibe).

build: Fix configure script.

Jul 19 2022, 11:44 AM

• gniibe committed rEb1b808f30f83: build: Update config.guess, config.sub, and config.rpath. (authored by • gniibe).

build: Update config.guess, config.sub, and config.rpath.

Jul 19 2022, 11:44 AM

• gniibe committed rA6da6a3df3c98: build: Update config.guess, config.sub, and config.rpath. (authored by • gniibe).

build: Update config.guess, config.sub, and config.rpath.

Jul 19 2022, 11:31 AM

• gniibe committed rK466837db84fb: build: Update config.guess and config.sub. (authored by • gniibe).

build: Update config.guess and config.sub.

Jul 19 2022, 11:21 AM

• gniibe committed rKca9a04569020: build: Support cross compile. (authored by • gniibe).

build: Support cross compile.

Jul 19 2022, 11:21 AM

• gniibe committed rC9a134fb7f286: cipher: Add buildhelp.h to source to be distributed. (authored by • gniibe).

cipher: Add buildhelp.h to source to be distributed.

Jul 19 2022, 10:23 AM

• ikloecker added a comment to T6090: Kleopatra: "Cancel" in the password dialog of "backup secret keys" has no effect.

It turns out that gpg does report an error via status-fd, ~~but it doesn't report via status-fd that the operation was canceled~~ (Update: The error code 83886179 in the status message corresponds to GPG_ERR_CANCELED, i.e. gpg reports that the user canceled the operation.)

$ gpg --status-fd 1 --export-secret-keys --armor -- 3A8536D46F57779C49F0CF542C0444CB59852D29
[GNUPG:] KEY_CONSIDERED 3A8536D46F57779C49F0CF542C0444CB59852D29 0
[GNUPG:] PINENTRY_LAUNCHED 6899 qt 1.2.1-beta1 /dev/pts/47 xterm-256color :0 20600/1000/5 1000/100 0
gpg: key 79BF2044FA53B3A492B361882353B5828F9B391C: error receiving key from agent: Operation cancelled - skipped
[GNUPG:] ERROR export_keys.secret 83886179
[GNUPG:] PINENTRY_LAUNCHED 6907 qt 1.2.1-beta1 /dev/pts/47 xterm-256color :0 20600/1000/5 1000/100 0
-----BEGIN PGP PRIVATE KEY BLOCK-----

Jul 19 2022, 10:16 AM · kleopatra, Restricted Project

• gniibe committed rC2efb90104591: build: Fix configure script. (authored by • gniibe).

build: Fix configure script.

Jul 19 2022, 10:12 AM

• gniibe committed rCe633cc3315aa: build: Update config.guess, config.sub, and config.rpath. (authored by • gniibe).

build: Update config.guess, config.sub, and config.rpath.

Jul 19 2022, 10:12 AM

• ebo created T6091: Kleopatra: "Cancel" in the password dialog of "Print secret key" has no effect.

Jul 19 2022, 10:01 AM · vsd33 (vsd-3.3.0), kleopatra, Restricted Project

• ikloecker added a comment to T6090: Kleopatra: "Cancel" in the password dialog of "backup secret keys" has no effect.

The second pinentry window comes up to ask for the passphrase that protects your subkey. Usually, gpg will try to use the passphrase entered for the primary key also for the subkey, but since you canceled the first pinentry there's no passphrase to re-use.

Jul 19 2022, 9:51 AM · kleopatra, Restricted Project

• ebo added a comment to T6090: Kleopatra: "Cancel" in the password dialog of "backup secret keys" has no effect.