I can reproduce the problem that this dll does not load.

Weird the same version compiled directly works for me. I'll investigate what
happens on the build system / with the buildscript.

Thanks. I found it. WHat's the difference between gpgol in
beta folder and that one in mime-send?
After replacing the dll I tried to enable gpgol but I had bno success so far.
There is a run time error reported when loading the addin. I also ran
ProcessMonitor and there is probably a missing file "C:\Program Files
(x86)\GNU\GnuPG\pub\api-ms-win-appmodel-runtime-l1-1-0.dll".
There are screeen shots in file uploaded.

Kind regards
KJ

Yes there is a new version available from the usual place. beta 103 is currently
the latest. I'll probably publish a beta installer containing that version later
today.

Hi,

thanks for your reply. No, there was no crash since disabling gpgol. I even
exported my contacts every day without any problem.

Is there a testversion available?

Kind regards,
KJ

Hi,

The "crash on disable" from T1837 (kjathome on Nov 03 2015, 06:44 PM / Roundup) was indeed a bug in gpgol. I've fixed it
with rev. 4f8c746e (included in beta100 and later). It only happened under
circumstances that did not occur in my development environment.

Have you seen crashes while gpgol was disabled?

Regards,
Andre

I've fixed this in the KDE translations.

Updated translations need to be put in gpg4win.

GpgOl was just deactived in my testing setup because the startup was too slow.

This makes this issue more urgent.

According to Werner, this is probably not a bug. Closing since the user never
followed up.

This should not happen anymore with the new MIME code in GpgOL for Outlook 2010
and later.
With the "Decrypt Body" function we had in Outlook 2010 and later you could
store the plaintext if you decrypted a mail and then confirmed the "Do you want
to save" dialog.

But for messages which are now automatically decrypted / verified the plain text
should never be stored persistently. T2138 might have caused this but this
was because GpgOL was deactivated before it prevented Outlook from storing the
plaintext.

I clicked on an e-mail today and it got decrypted (although others didn't).

That means that it was a valid PGP/Mime or PGP/Inline mail and you encountered
the new handler code which works similar to the old mail handling we had for
Outlook 2007 and earlier in that it decrypts / verifies automatically and then
shows the plaintext in the mail body.

This e-mails have been left decrypted (see T1106). So I wanted to
disable gpgol

It should not have been left decrypted. GpgOL now prevents that. If Addin
deactivation was involved you might have run into T2138 which I only fixed
on Monday and the fix for this was not in your version.

Pic2.png shows the message we inject in the Mail Body when we encounter Outlooks
"Write event" to avoid just such a leak.

The latest Version (Currently beta-85) also has a fix for the confusing "The
properties of the Mail have changed do you want to save dialog" (Where clicking
yes also brings up the message of Pic2.png)

http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgol.git;a=commit;h=452477949fe2f1d8ca36ebbad31c6f3c6607e30e

and when I tried to do so Outlook crashed again.
Because I deinstalled PDF Architect there is no such addin!
Unfortunately there must be another reason.
I'll append gpgol.txt, an excerpt of windows eventlog and screenshots of > the
addins still activated in archiv.tar.gpg.

The debug output / event log match here. It crashes on Release in the destructor
of the Addin object. There might be a bug there if we Release / delete an
invalid object. I'll investigate and test this some more. Thanks.

Because I had serveral crashes the last 2 days I decided to disable gpgol
add-in. I'll see what it's going to happen the next days.

Ok. Please let us know how it works out and if you still see random crashes. And
thanks again for your feedback / testing.

Because I had serveral crashes the last 2 days I decided to disable gpgol add-in.
I'll see what it's going to happen the next days.

I have no idea what a trusted extension is and I can happily read / modify the
body through OOM.

I'm marking this as resolved as I don't see anything to do here.

I clicked on an e-mail today and it got decrypted (although others didn't). This
e-mails have been left decrypted (see T1106). So I wanted to disable gpgol
and when I tried to do so Outlook crashed again.
Because I deinstalled PDF Architect there is no such addin!
Unfortunately there must be another reason.
I'll append gpgol.txt, an excerpt of windows eventlog and screenshots of the
addins still activated in archiv.tar.gpg.

Fixed with: b942f73

If GpgOL is deactivated it cleans up after itself and wipes the plaintext from
mails / session encrypts attachments.
If that fails it shows a warning message.

So it seems as if the cause has been found. I uninstalled PDF Architect and
hopefully there will be no more crashes.
Thanks
KJ

just installed the free version of PDF Architect 3 in a test VM and after
clicking around a bit I got a crash in Outlook.

Then restarted and got an "Runtimeerror" in the GetCustomUI callback of PDF
Architect 3. (These errors are normally not shown if you don't enable them under
"Erweitert -> Entwickler -> Add-In-Benutzeroberflächenfehler anzeigen")

This addin looks fishy.

The only third party addin besides gpgol (and those of Microsoft) I've installed
is PDF Architect 3 which I disabled. During the step of disabling another
crashed occured. Now I'm going to see waht happens.

Just turned off all addins but gpgol and export of contacts worked. Enabled
again all addins and export of contacts worked without problems. There must be
some other influences.

I've come up with a theory to explain what we are seeing here:

You have another addin that does some things asynchronously (in a different
thread) this addin then makes a callback into the Outlook Object model. This is
not supported and you should not do this according to documentation. But it
might just work.

Assuming (because you don't see random crashes where gpgol is not involved) that
this works in the majority of cases but when outlook is busy executing third
party code (like gpgol) this causes the crash.

In that case Outlook would think that it crashed in gpgol as the main thread of
Outlook was executing gpgol code at the time of the crash although gpgol did
nothing wrong.

This theory could be validated if you leave GpgOL active but start to disable
other addins and check that the crashes disappear.

I've added werner to the nosy list. Maybe he has another idea.

Both those Event log entries are bogous.

If you take a look at the application events callback:
http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgol.git;a=blob;f=src/application-events.cpp#l58

In case it is called with NewMailEx (0x0000FAB5) or OptionsPagesAdd (0x0000F005)
as the event log entries suggest.

The only lines executed are:

USE_INVOKE_ARGS (which is a helper macro to reduce compiler warnings. Does nothing)

log_oom_extra ("%s:%s: Unhandled Event: %lx \n", SRCNAME, func, dispid);

and
return S_OK;

There is simply no way that this can crash.

The previous crash you've reported in ApplicationEvents was for the ItemLoad
event. This does some more stuff so I accepted that there might be a crash in there.

But there is no way that the Event handler could crash in the other two events
from T1837 (kjathome on Oct 30 2015, 04:56 PM / Roundup) and T1837 (kjathome on Oct 30 2015, 04:46 PM / Roundup)

Now Outlook crashed while trying to modify addins.

Fehler bei der Ausführung des Add-Ins. Outlook ist während des Rückrufs
'OptionsPagesAdd' der Schnittstelle 'ApplicationEvents' beim Aufrufen des
Add-Ins 'GpgOL - The GnuPG Outlook Plugin' abgestürzt.

Name der fehlerhaften Anwendung: OUTLOOK.EXE, Version: 15.0.4763.1000,
Zeitstempel: 0x55f7f203
Name des fehlerhaften Moduls: OUTLOOK.EXE, Version: 15.0.4763.1000, Zeitstempel:
0x55f7f203
Ausnahmecode: 0xc0000005
Fehleroffset: 0x0016ed2c
ID des fehlerhaften Prozesses: 0x2dd0
Startzeit der fehlerhaften Anwendung: 0x01d11321b1369144
Pfad der fehlerhaften Anwendung: C:\Program Files (x86)\Microsoft
Office\Office15\OUTLOOK.EXE
Pfad des fehlerhaften Moduls: C:\Program Files (x86)\Microsoft
Office\Office15\OUTLOOK.EXE
Berichtskennung: 3d154856-7f1e-11e5-920b-2c4138a83b6e

The eventlog messages as of today are:

Fehler bei der Ausführung des Add-Ins. Outlook ist während des Rückrufs
'0x0000FAB5' der Schnittstelle 'ApplicationEvents' beim Aufrufen des Add-Ins
'GpgOL - The GnuPG Outlook Plugin' abgestürzt.

followed by

Name der fehlerhaften Anwendung: OUTLOOK.EXE, Version: 15.0.4763.1000,
Zeitstempel: 0x55f7f203
Name des fehlerhaften Moduls: OUTLOOK.EXE, Version: 15.0.4763.1000, Zeitstempel:
0x55f7f203
Ausnahmecode: 0xc0000005
Fehleroffset: 0x0016ed2c
ID des fehlerhaften Prozesses: 0x1704
Startzeit der fehlerhaften Anwendung: 0x01d112f3b4588f4c
Pfad der fehlerhaften Anwendung: C:\Program Files (x86)\Microsoft
Office\Office15\OUTLOOK.EXE
Pfad des fehlerhaften Moduls: C:\Program Files (x86)\Microsoft
Office\Office15\OUTLOOK.EXE
Berichtskennung: 700aef2d-7f14-11e5-920b-2c4138a83b6e

I'm to check exporting contaxts by disabling addins as you suggested.

looking at the data from 20152029.tar.gpg:

At the point where the Eventlog reports the crash GpgOL was not doing anything
according to the debug output. I'm not sure what the Windows event log wants to
tell me with "gpgol.dll_unloaded" in the error message.

And with exporting contacts. There is absolutely no code in GpgOL that does
anything with contacts. :-/

I've talked with Werner (who handled gpgol development before me) about this bug
and that I am clueless how a static function like GetCustonUI could sometimes
crash and sometimes not. And he thinks that the EventLog information may just be
wrong.

E.g. It just prints the last function called in gpgol. While the actual problem
might be caused by a different addin.

I should probably ask on the gpg4win-users mailing list if others are seeing
those random crashes too. But with the frequencies you are seeing I would expect
that we had more reports about this.

If you can reproduce this with exporting contacts, maybe you can disable the
other addins you are using in Outlook and check if it still crashes?

Or disable GpgOL and check if the crash dissapears?

Now it's definitely exporting contacts. Today I didn't even switch to inbox.

I've never seen this but there is code for it in case op_assuan_sign is called
without a sender.

Should not happen except in bug cases. So it would probably be better just to
show an error in that case rather then a weird "GpgOL is annoyed with Kleopatra"
email address.

Had another crash today. The last steps were: exported contacts to a local file
and when done I switched to inbox folder. Then Outlook crashed and restarted itself.
Please see windows evenlog entry and gpgol log file.
Best regards kj

Fixed with 694a6e4 was indeed the same problem I had with my buttons. (local8
bit encoding passed to put_oom_string which expects utf8)

I'm directly resolving this as I tested myself.

Tested with GpgOL 1.3.0-beta71 in Outlook 2003:
Still the same problem: "ü" is missing in German Tooltips

I just installed the version and as soon as there are new results I'll come back
to you.
Thanks

I've just uploaded a new binary:

http://files.gpg4win.org/Beta/gpgol/1.3.0-beta71/

It is an IMAP issue in Outlook 2003/2007 that deleted email are marked as
deleted (stroked) but were not deleted permanently. This can be done via Edit
menu (in German: "Gelöschte Nachrichten permanent löschen"), see [1].
So not a GpgOL bug. => Resolved.

https://support.office.com/de-de/article/Permanentes-L%C3%B6schen-von-zum-L%C3%B6schen-markierten-IMAP-Elementen-ac1c51da-31c1-435c-a357-96eb78ad684a?ui=de-DE&rs=de-DE&ad=DE

Debug output looks ok.

Please check that the old version (as included in gpg4win 2.2.6) does not show
the same behavior in your setup.

If It's not a regression I'm inclined to mark this as a wontfix.

Thanks for the answer. Is there another (beta) dll for download or should I wait
for the next release?
TIA KJ

debug output attached.

Ok. Thats what I thought.

The problem is that
" 90695/8872/mailitem-events.cpp:Invoke: Unloaded. " Is unrelated to the
function the event log says caused the crash (application-events.cpp:Invoke).
And is the usual last line of a "normal" mail item unload..

In Application Events the first log entry would have been "Installing event sink
on mailitem: ..." [1]

But as we did not see that before the crash I've added a check if parms is NULL
in that call (Which according to msdn it should never be and that function is
called by outlook and not by us). And added debug output before the first
function call in that function (But that function call is just an Error wrapper
around a QueryInterface call which should also never ever crash ;-) )

Weird.

1:
http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgol.git;a=blob;f=src/application-events.cpp;hb=560cea7e5bbf7f0404e4f1977b42710245f26b1f

Outlook reported the problem and a message box appeared stating "searching for
the cause of the problem". Outlook then restarted itself. After terminating
Outlook I assembled the log files.

The most interesting lines should be around line # 3152 which is presumably the
very last line before/during the crash.

So I'll wait for the new version :-)

Thanks!

Did you obtain the log right after the crash or have you started / shut down
outlook once after the crash? (From the debug output it looks that way).

Or did the crash happen when closing Outlook?

I've just commited a change to the logging format so that the current UTC Date
Time is included in the log and it can be better correlated with EventLog entries
and I don't have to ask such questions in the future ;-)

I've also added a guard against an invalid parmeter in the function now reported
to crash (The Application ItemLoad event handler) and even more debug output in
that function (because I doubt that the invalid parameter caused the crash).

I'll give you a ping here when I've uploaded a new version.

I just had another crash using your latest provided gpgol.dll.
See gpgol logfile and corresponging windows eventlog entry in the file included.

With the informsec code we had "decent" support for encrypted / decrypted
attachments.

With 1.3.0 we have very nice read support for MIME Attachments (including
Outlook's internal preview). And send support is on the roadmap.

But this is event based code. I'd say we can close this issue.

Emanuel can you check if this is still the case with the current version? I
think it should still be the case as I have tried to leave this all intact.

But the problem is likely the same as for
http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgol.git;a=commit;h=1bab2eba47249b258759ad7d897ef96e76bb9557

And easy to fix.

Duplicate of T1826

Please try the latest 1.3.0 beta version which is available from:

https://wiki.gnupg.org/GpgOL/Development/Testversions

This version has experimental read support for PGP/MIME mails.

I'm closing this issue as a duplicate of T1826 which already tracks PGP-MIME
support in gpgol.

I have to check if this is possible (Depending on the parameters in the forward
reply events this could even be trivial)

You may want to try out the latest 1.3.0 Beta version which supports reading
PGP/MIME mails. See:

https://wiki.gnupg.org/GpgOL/Development/Testversions

I've just uploaded a Test Version of a new GpgOL and documented it under:
https://wiki.gnupg.org/GpgOL/Development/Testversions

While the main focus for that Testversion is MIME support I've also added a lot
of debug output in the functions you see crashing:

http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgol.git;a=commitdiff;h=7016fec9aef7be53f164829f7c76e28c6a83e228

If you are willing it would be a great help if you would install that version
and provide me with the gpgol debug log after you encounter the next crash.

They just might also be gone because of the changes mentioned in T1837 (aheinecke on Oct 13 2015, 12:06 PM / Roundup) but I
doubt it.

Thanks for your quick reponse.

Thanks for the info (and again apologies for your trouble)

btnDecryptLarge and btnDecrypt are also functions that only fetch resource data
like GetCustomUI. I don't understand why they would crash only some time and not
always.

From looking at the code the only possible problem I see is that an invalid
result pointer is passed to that function. There is not check for that. I'm
adding one.

With regards to getcustomui:

In the current mime-addin development branch I'm currently working on I have
modified the ribbon ui function to use a dynamically allocated string. But this
should not the problem because the locale strings should not change.

Another theory that I need to check is that the pointers to the localized string
I use there are not guaranteed to be valid when they are used in the sprintf
call. They should be, but maybe there is a problem with our gettext
implementation. So I'll reduce the lifetime of the pointers to the function call.

Just to give an update:

since June I had 24 messages of type without any encryption/decryption

Fehler bei der Ausführung des Add-Ins. Outlook ist während des Rückrufs
'GetCustomUI' der Schnittstelle 'IRibbonExtensibility' beim Aufrufen des Add-Ins
'GpgOL - The GnuPG Outlook Plugin' abgestürzt.

and one of the folling two

Fehler bei der Ausführung des Add-Ins. Outlook ist während des Rückrufs
'btnDecryptLarge' der Schnittstelle 'IRibbonControl' beim Aufrufen des Add-Ins
'GpgOL - The GnuPG Outlook Plugin' abgestürzt.

Fehler bei der Ausführung des Add-Ins. Outlook ist während des Rückrufs
'btnDecrypt' der Schnittstelle 'IRibbonControl' beim Aufrufen des Add-Ins 'GpgOL

• The GnuPG Outlook Plugin' abgestürzt.

No reply thus we assume everything is alright.

Hi, any plans for the next release?
Best regards
KJ

I can't reproduce this problem.

GpgOL tries to talk to Kleopatra through a file in %APPDATA%\gnupg

please make sure the permissions on this folder are correct. If you started
things with Administrator privileges before there might be files in there that
are only accessible for administrators and not with normal user rights.

So I'm going to wait for a new release with more tracing capabilites.
Thanks so far.
KJ

The Mail you show is a so called PGP/MIME mail.

We are well aware that GpgOL for Outlook 2010 and later versions only provides a
very basic OpenPGP support and no PGP/MIME Support. It is mentioned on the
website and in the documentation.

We are hoping to develop this but this is a huge Feature and very problematic to
implement given Outlook's extension API.

Wildly clicking around and changing components in GpgOL for quite some time I
was able to trigger this crash once (right before I was about to give up)

So there definitely is something here. Probably a threading / timing thing as it
is so hard to reproduce. Should not be though as all the extension code runs in
Outlooks main thread.

I've tried to reproduce it a second time but failed. Even with a script changing
components and opening encrypted mails in Outlook I was unable to reproduce it a
second time.

If I don't find more I'll add some more trace code in the debug output for a new
release. That should help us to at least tell us where it crashes in that function.

Hi,

since April there are 14 crashes recorded in windows event log, one occurred in
function btnDecryptLarge all others in function GetCustomUI.

It happens occasionally when changing between views. So it's not easy to
reproduce the behaviour. Even the log is not very useful because there are no
timestamps in the log entries to check it against windows event log.

There are other 6 active plugins installed.

If you need more info’s, please let me know.

KJ