Page MenuHome GnuPG
Feed All Stories

Oct 24 2018

werner committed rCabd267bf2393: Fix memory leak in secmem in out of core conditions. (authored by werner).
Fix memory leak in secmem in out of core conditions.
Oct 24 2018, 12:32 PM
werner committed rC60224352f4de: ecc: Fix memory leak in the error case of ecc_encrypt_raw (authored by werner).
ecc: Fix memory leak in the error case of ecc_encrypt_raw
Oct 24 2018, 12:32 PM
werner committed rC7f4de8bab991: doc: Fix example for gcry_sexp_extract_param (authored by werner).
doc: Fix example for gcry_sexp_extract_param
Oct 24 2018, 12:32 PM
werner committed rC347987d4cf29: ecc: Fix possible memory leakage in parameter check of eddsa. (authored by werner).
ecc: Fix possible memory leakage in parameter check of eddsa.
Oct 24 2018, 12:32 PM
werner committed rC8cc7cac82ec2: sexp: Fix uninitialized use of a var in the error case. (authored by werner).
sexp: Fix uninitialized use of a var in the error case.
Oct 24 2018, 12:32 PM
werner committed rCbe68b3ee4fd1: ecc: Fix potential unintended freeing of an internal param. (authored by werner).
ecc: Fix potential unintended freeing of an internal param.
Oct 24 2018, 12:32 PM
werner committed rCb0ad66e48c46: build: Make distcheck work again. (authored by werner).
build: Make distcheck work again.
Oct 24 2018, 12:30 PM
werner committed rC03bb25ee7ed6: build: Add release make target (authored by werner).
build: Add release make target
Oct 24 2018, 12:30 PM
werner committed rC0cfd41c66279: doc: Update yat2m.c from upstream (libgpg-error) (authored by werner).
doc: Update yat2m.c from upstream (libgpg-error)
Oct 24 2018, 12:06 PM
werner closed T4210: Potential memory leak in ecc_encrypt_raw as Resolved.
Oct 24 2018, 11:56 AM · libgcrypt
werner closed T4211: Potential memory leak in _gcry_secmem_malloc_internal as Resolved.

Thanks.

Oct 24 2018, 11:55 AM · libgcrypt
werner committed rCf74687fd43f5: Fix memory leak in secmem in out of core conditions. (authored by werner).
Fix memory leak in secmem in out of core conditions.
Oct 24 2018, 11:55 AM
werner committed rCe57e75ea517f: ecc: Fix memory leak in the error case of ecc_encrypt_raw (authored by werner).
ecc: Fix memory leak in the error case of ecc_encrypt_raw
Oct 24 2018, 11:55 AM
werner added a comment to T4210: Potential memory leak in ecc_encrypt_raw.

Thanks again.

Oct 24 2018, 11:51 AM · libgcrypt
aheinecke created T4218: GpgOL: Populate key cache on startup.
Oct 24 2018, 11:38 AM · gpg4win, gpgol
aheinecke created D469: dirmngr: Add FLUSHCRLs command.
Oct 24 2018, 10:45 AM
aheinecke added a revision to T3967: dirmngr: "flush" does not flush in memory CRL's: D469: dirmngr: Add FLUSHCRLs command.
Oct 24 2018, 10:45 AM · kleopatra, S/MIME, gnupg
aheinecke updated the diff for D468: dirmngr: Read CRLs into memory on Windows.

Added a missing free in case of read error.

Oct 24 2018, 10:29 AM
aheinecke added a comment to T4182: Dirmngr: Keeps files in homedir open on Windows.

If I understand the code correctly the mapping is done to let the system optimize the memory management so that the full contents of the file are not kept in memory, or is there a different reason?

Oct 24 2018, 10:28 AM · dirmngr
aheinecke created D468: dirmngr: Read CRLs into memory on Windows.
Oct 24 2018, 10:26 AM
aheinecke added a revision to T4182: Dirmngr: Keeps files in homedir open on Windows: D468: dirmngr: Read CRLs into memory on Windows.
Oct 24 2018, 10:26 AM · dirmngr
gniibe committed rTace1fa90ec40: build: Fix ntbtls.pc.in. (authored by gniibe).
build: Fix ntbtls.pc.in.
Oct 24 2018, 10:13 AM
werner closed T4209: Potential memory leak in _gcry_ecc_eddsa_verify as Resolved.

Thanks. Not a real world problem now but needs to be fixed.

Oct 24 2018, 10:03 AM · libgcrypt
werner committed rC149ceb3cae03: ecc: Fix possible memory leakage in parameter check of eddsa. (authored by werner).
ecc: Fix possible memory leakage in parameter check of eddsa.
Oct 24 2018, 10:03 AM
gniibe committed rTea6edafcf839: build: Compatibility to pkg-config. (authored by gniibe).
build: Compatibility to pkg-config.
Oct 24 2018, 10:01 AM
gniibe committed rT39d0b3a02afe: build: Fix ntbtls.m4. (authored by gniibe).
build: Fix ntbtls.m4.
Oct 24 2018, 10:01 AM
gniibe committed rTf4e5435e1d4c: build: Update m4 scripts. (authored by gniibe).
build: Update m4 scripts.
Oct 24 2018, 10:01 AM
gniibe committed rT548b70b9db46: build: Provide ntbtls.pc, generated by configure. (authored by gniibe).
build: Provide ntbtls.pc, generated by configure.
Oct 24 2018, 10:01 AM
gniibe committed rT06e6d62dcaf6: build: Make ntbtls.m4 use gpg-error-config. (authored by gniibe).
build: Make ntbtls.m4 use gpg-error-config.
Oct 24 2018, 10:01 AM
werner closed T4216: Newline at end of tooltip string just making tooltip unnecessarily bigger as Resolved.

Thanks. There is an easier solution for this, though: I now trim trailing LFs.

Oct 24 2018, 9:42 AM · gpa, Bug Report
werner committed rGPA70858dcd6062: Trim tooltips before displaying. (authored by werner).
Trim tooltips before displaying.
Oct 24 2018, 9:40 AM
werner triaged T4215: Typo bees/been as Low priority.
Oct 24 2018, 9:27 AM · gpa
aheinecke committed rG01baee2b0ef4: dirmngr: Only print info for no ldapserver file (authored by aheinecke).
dirmngr: Only print info for no ldapserver file
Oct 24 2018, 9:20 AM
aheinecke added a comment to T4182: Dirmngr: Keeps files in homedir open on Windows.

Maybe related, flush also does not work on Windows:

Oct 24 2018, 9:09 AM · dirmngr
werner added a comment to T4217: {libksba,libgcrypt,ntbtls,libassuan,npth}.m4, {libksba,libgcrypt,ntbtls,libassuan}-config script and gpg-error-config.

May I suggest to use a (new) gpgrt-config instead of the current name libgpg-error-config. The long term plan is to change the name of the library.

Oct 24 2018, 9:06 AM · npth, libassuan, ntbtls, libgcrypt, libksba
gniibe committed rA25797256e158: build: Fix libassuan.pc. (authored by gniibe).
build: Fix libassuan.pc.
Oct 24 2018, 8:43 AM
gniibe committed rC0e071372fc0e: build: Fix libgcrypt.pc. (authored by gniibe).
build: Fix libgcrypt.pc.
Oct 24 2018, 8:35 AM
gniibe committed rK4754816d10a3: build: Fix ksba.pc. (authored by gniibe).
build: Fix ksba.pc.
Oct 24 2018, 8:35 AM
aheinecke added a comment to T4193: Debug log has full content of a regular mail even when checkmarked not to have decrypted mail content.

For what it's worth I found some more places where data leaked out even in log level 1. It will probably be a bit of a process to get this clean to a 100% as there is no automated way to decide what needs to be filtered and what not.

Oct 24 2018, 8:28 AM · Bug Report, gpg4win
gniibe committed rCc60eabb11435: build: Compatibility to pkg-config. (authored by gniibe).
build: Compatibility to pkg-config.
Oct 24 2018, 8:26 AM
gniibe committed rC7da887d69d72: build: Make libgcrypt.m4 use gpg-error-config. (authored by gniibe).
build: Make libgcrypt.m4 use gpg-error-config.
Oct 24 2018, 8:26 AM
gniibe committed rC97194b422bc8: build: Provide libgcrypt.pc, generated by configure. (authored by gniibe).
build: Provide libgcrypt.pc, generated by configure.
Oct 24 2018, 8:26 AM
gniibe committed rC5b1febb5e40d: build: Update gpg-error.m4 from libgpg-error. (authored by gniibe).
build: Update gpg-error.m4 from libgpg-error.
Oct 24 2018, 8:26 AM
gniibe committed rC0f4545b441b6: build: Don't default to underscore=yes for cross-build. (authored by gniibe).
build: Don't default to underscore=yes for cross-build.
Oct 24 2018, 8:26 AM
aheinecke committed rOa9f1c04e2933: Only log raw crypto data if DBG_DATA is enabled (authored by aheinecke).
Only log raw crypto data if DBG_DATA is enabled
Oct 24 2018, 8:24 AM
gniibe committed rK5a21f7465ca2: build: Fix previous commit. (authored by gniibe).
build: Fix previous commit.
Oct 24 2018, 7:19 AM
gniibe committed rAb9fb02a823f7: build: Fix previous commit. (authored by gniibe).
build: Fix previous commit.
Oct 24 2018, 7:18 AM
gniibe committed rE184c22bea37d: gpg-error-config: Fix previous commit. (authored by gniibe).
gpg-error-config: Fix previous commit.
Oct 24 2018, 7:15 AM
gniibe committed rKd0016a76942e: build: Provide libassuan.pc, generated by configure. (authored by gniibe).
build: Provide libassuan.pc, generated by configure.
Oct 24 2018, 5:45 AM
gniibe committed rKce5247c0f3fc: build: Make ksba.m4 use gpg-error-config. (authored by gniibe).
build: Make ksba.m4 use gpg-error-config.
Oct 24 2018, 5:45 AM
gniibe committed rKdfc3ad5c6e97: build: Compatibility to pkg-config. (authored by gniibe).
build: Compatibility to pkg-config.
Oct 24 2018, 5:45 AM
gniibe committed rKec4e838ca918: build: Update gpg-error.m4 from libgpg-error. (authored by gniibe).
build: Update gpg-error.m4 from libgpg-error.
Oct 24 2018, 5:45 AM
gniibe committed rA9b1666522f7b: build: Compatibility to pkg-config. (authored by gniibe).
build: Compatibility to pkg-config.
Oct 24 2018, 5:33 AM
gniibe committed rA9c74661d6f80: build: Provide libassuan.pc, generated by configure. (authored by gniibe).
build: Provide libassuan.pc, generated by configure.
Oct 24 2018, 5:33 AM
gniibe committed rAf69f4c893f29: build: Make libassuan.m4 use gpg-error-config. (authored by gniibe).
build: Make libassuan.m4 use gpg-error-config.
Oct 24 2018, 5:33 AM
gniibe committed rA34fd79ae2af2: build: Update gpg-error.m4 from libgpg-error. (authored by gniibe).
build: Update gpg-error.m4 from libgpg-error.
Oct 24 2018, 5:33 AM
gniibe committed rE6d8b1e958ca9: gpg-error-config: Old gpg-error-config support --modversion. (authored by gniibe).
gpg-error-config: Old gpg-error-config support --modversion.
Oct 24 2018, 4:51 AM
gniibe committed rE7b81ec272b0c: gpg-error-config: Get var/attr from the first package. (authored by gniibe).
gpg-error-config: Get var/attr from the first package.
Oct 24 2018, 3:40 AM
gniibe updated the task description for T4217: {libksba,libgcrypt,ntbtls,libassuan,npth}.m4, {libksba,libgcrypt,ntbtls,libassuan}-config script and gpg-error-config.
Oct 24 2018, 2:37 AM · npth, libassuan, ntbtls, libgcrypt, libksba
gniibe updated the task description for T4217: {libksba,libgcrypt,ntbtls,libassuan,npth}.m4, {libksba,libgcrypt,ntbtls,libassuan}-config script and gpg-error-config.
Oct 24 2018, 2:33 AM · npth, libassuan, ntbtls, libgcrypt, libksba
gniibe added a comment to T4217: {libksba,libgcrypt,ntbtls,libassuan,npth}.m4, {libksba,libgcrypt,ntbtls,libassuan}-config script and gpg-error-config.

This is the dependency graph:

Oct 24 2018, 2:32 AM · npth, libassuan, ntbtls, libgcrypt, libksba
gniibe created T4217: {libksba,libgcrypt,ntbtls,libassuan,npth}.m4, {libksba,libgcrypt,ntbtls,libassuan}-config script and gpg-error-config.
Oct 24 2018, 2:15 AM · npth, libassuan, ntbtls, libgcrypt, libksba
werner committed rKa1ce3c17ee0d: Fix error detection in the CMS parser which may led to a NULL-deref. (authored by werner).
Fix error detection in the CMS parser which may led to a NULL-deref.
Oct 24 2018, 2:13 AM
werner committed rKd56bddc68db8: Use only one .PHONY target in a Makefile. (authored by werner).
Use only one .PHONY target in a Makefile.
Oct 24 2018, 2:13 AM
werner committed rKa0bbba1c4928: Fix test for existence of the signing_time (authored by werner).
Fix test for existence of the signing_time
Oct 24 2018, 2:13 AM
gusnan created T4216: Newline at end of tooltip string just making tooltip unnecessarily bigger.
Oct 24 2018, 1:50 AM · gpa, Bug Report
gusnan created T4215: Typo bees/been in the S1 Public space.
Oct 24 2018, 12:08 AM · gpa

Oct 23 2018

werner committed rCe2da4e8dee4b: ecc: Fix potential unintended freeing of an internal param. (authored by werner).
ecc: Fix potential unintended freeing of an internal param.
Oct 23 2018, 11:38 PM
werner committed rC9f2c7ec4d8b0: sexp: Fix uninitialized use of a var in the error case. (authored by werner).
sexp: Fix uninitialized use of a var in the error case.
Oct 23 2018, 11:38 PM
werner committed rC282f238f7788: doc: Fix example for gcry_sexp_extract_param (authored by werner).
doc: Fix example for gcry_sexp_extract_param
Oct 23 2018, 11:38 PM
werner triaged T4208: Copy & paste error in libgcrypt ecc-curves.c as High priority.

Thanks. Fixed in master. Needs backport.

Oct 23 2018, 10:59 PM · Bug Report, libgcrypt
werner triaged T4199: Disable scaling for cardkey icon in keylist as Normal priority.
Oct 23 2018, 10:54 PM · gpa, Bug Report
werner triaged T4212: Uninitialized use of l1 variable in _gcry_sexp_vextract_param as High priority.

Thanks. Fixed in master.

Oct 23 2018, 10:53 PM · Bug Report, libgcrypt
werner closed T4207: Copy & paste error in libksba cms.c as Resolved.

Thanks.

Oct 23 2018, 10:44 PM · libksba
werner closed T4213: Invalid test for certlist->signing_time in build_signed_data_attributes in cms.c as Resolved.

Thanks. That code is from 2001 and whne I changed to another time representaion in 2003 (due certs with 40 years expiration time) I missed to changed that condition.

Oct 23 2018, 10:39 PM · libksba
werner committed rGPA493b02e52377: po: Added missing files and sorted POTFILES (authored by werner).
po: Added missing files and sorted POTFILES
Oct 23 2018, 10:01 PM
werner closed T4214: Missing files in POTFILES.in as Resolved.

Thanks. I added these files.

Oct 23 2018, 9:55 PM · gpa
gusnan created T4214: Missing files in POTFILES.in in the S1 Public space.
Oct 23 2018, 6:25 PM · gpa
t8m created T4213: Invalid test for certlist->signing_time in build_signed_data_attributes in cms.c in the S1 Public space.
Oct 23 2018, 4:53 PM · libksba
gusnan added a comment to T3881: Window sizing issue.

In addition to what I said above - the patch comes with two small side-effects - The size of the content in the tab is constant over the tabs, so that even a page with not very many settings will show a scrollbar, even if it only makes it possible to scroll in empty space from below.

Oct 23 2018, 4:42 PM · gpa, Bug Report
aheinecke committed rG6b36c16f7772: sm: Fix dirmngr loadcrl for intermediate certs (authored by aheinecke).
sm: Fix dirmngr loadcrl for intermediate certs
Oct 23 2018, 4:01 PM
gusnan added a comment to T3881: Window sizing issue.

I have made a patch for this, that add scrollbars to scroll up and down in the settings. This adds the need to set a default window size, which I have set to 700 x 500, which seems fine. Tested on a relatively low-resolution machine (1366 x 768), where it seems to work fine for me.

Oct 23 2018, 3:32 PM · gpa, Bug Report
t8m created T4212: Uninitialized use of l1 variable in _gcry_sexp_vextract_param in the S1 Public space.
Oct 23 2018, 3:20 PM · Bug Report, libgcrypt
t8m created T4211: Potential memory leak in _gcry_secmem_malloc_internal in the S1 Public space.
Oct 23 2018, 3:13 PM · libgcrypt
t8m added a project to T4210: Potential memory leak in ecc_encrypt_raw: libgcrypt.
Oct 23 2018, 3:11 PM · libgcrypt
BenM committed rM04791c896712: docs: python howto (authored by BenM).
docs: python howto
Oct 23 2018, 2:41 PM
t8m created T4210: Potential memory leak in ecc_encrypt_raw in the S1 Public space.
Oct 23 2018, 2:31 PM · libgcrypt
t8m added a project to T4209: Potential memory leak in _gcry_ecc_eddsa_verify: libgcrypt.
Oct 23 2018, 2:27 PM · libgcrypt
t8m created T4209: Potential memory leak in _gcry_ecc_eddsa_verify in the S1 Public space.
Oct 23 2018, 2:14 PM · libgcrypt
t8m created T4208: Copy & paste error in libgcrypt ecc-curves.c in the S1 Public space.
Oct 23 2018, 1:52 PM · Bug Report, libgcrypt
t8m created T4207: Copy & paste error in libksba cms.c in the S1 Public space.
Oct 23 2018, 1:20 PM · libksba
gniibe committed rE25ea85066cf1: build: Fix permission. (authored by gniibe).
build: Fix permission.
Oct 23 2018, 12:01 PM
aheinecke committed rW3495295da4d6: doc: Update HOWTO-SMIME (authored by aheinecke).
doc: Update HOWTO-SMIME
Oct 23 2018, 10:10 AM
aheinecke committed rWc52f7588f3c9: Fix typo in news (authored by aheinecke).
Fix typo in news
Oct 23 2018, 10:10 AM
aheinecke committed rW46e289dd54e9: Remove ast l10n also from portable (authored by aheinecke).
Remove ast l10n also from portable
Oct 23 2018, 10:10 AM
gniibe committed rE00e955558c66: build: Fix detecting build on multiarch environment. (authored by gniibe).
build: Fix detecting build on multiarch environment.
Oct 23 2018, 8:38 AM
gniibe committed rEf575b2fd3f73: build: Supply CC to invoke gpg-error-config. (authored by gniibe).
build: Supply CC to invoke gpg-error-config.
Oct 23 2018, 7:01 AM
gniibe committed rE40e22c774afe: gpg-error-config: Fix cross build support. (authored by gniibe).
gpg-error-config: Fix cross build support.
Oct 23 2018, 5:48 AM
gniibe added a comment to rE12b834ba59ae: yat2m: Avoid compiler warnings..

While we have no way to express possible range of values in structure member, we can do something like this (which is not needed actually, if the gmtime function returns correct value).

Oct 23 2018, 4:50 AM
gniibe added a comment to rE12b834ba59ae: yat2m: Avoid compiler warnings..

Here is the warning:

../../libgpg-error/doc/yat2m.c: In function 'isodatestring':
../../libgpg-error/doc/yat2m.c:373:29: warning: '%02d' directive writing between 2 and 11 bytes into a region of size between 4 and 11 [-Wformat-overflow=]
       sprintf (buffer,"%04d-%02d-%02d",
                             ^~~~
../../libgpg-error/doc/yat2m.c:373:23: note: directive argument in the range [-2147483647, 2147483647]
       sprintf (buffer,"%04d-%02d-%02d",
                       ^~~~~~~~~~~~~~~~
../../libgpg-error/doc/yat2m.c:373:7: note: 'sprintf' output between 11 and 36 bytes into a destination of size 16
       sprintf (buffer,"%04d-%02d-%02d",
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                1900+tp->tm_year, tp->tm_mon+1, tp->tm_mday );
                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Oct 23 2018, 1:13 AM