- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Oct 24 2018
Thanks.
Thanks again.
Added a missing free in case of read error.
If I understand the code correctly the mapping is done to let the system optimize the memory management so that the full contents of the file are not kept in memory, or is there a different reason?
Thanks. Not a real world problem now but needs to be fixed.
Thanks. There is an easier solution for this, though: I now trim trailing LFs.
Maybe related, flush also does not work on Windows:
May I suggest to use a (new) gpgrt-config instead of the current name libgpg-error-config. The long term plan is to change the name of the library.
For what it's worth I found some more places where data leaked out even in log level 1. It will probably be a bit of a process to get this clean to a 100% as there is no automated way to decide what needs to be filtered and what not.
Oct 23 2018
Thanks. Fixed in master. Needs backport.
Thanks. Fixed in master.
Thanks.
Thanks. That code is from 2001 and whne I changed to another time representaion in 2003 (due certs with 40 years expiration time) I missed to changed that condition.
Thanks. I added these files.
In addition to what I said above - the patch comes with two small side-effects - The size of the content in the tab is constant over the tabs, so that even a page with not very many settings will show a scrollbar, even if it only makes it possible to scroll in empty space from below.
I have made a patch for this, that add scrollbars to scroll up and down in the settings. This adds the need to set a default window size, which I have set to 700 x 500, which seems fine. Tested on a relatively low-resolution machine (1366 x 768), where it seems to work fine for me.
While we have no way to express possible range of values in structure member, we can do something like this (which is not needed actually, if the gmtime function returns correct value).
Here is the warning:
../../libgpg-error/doc/yat2m.c: In function 'isodatestring': ../../libgpg-error/doc/yat2m.c:373:29: warning: '%02d' directive writing between 2 and 11 bytes into a region of size between 4 and 11 [-Wformat-overflow=] sprintf (buffer,"%04d-%02d-%02d", ^~~~ ../../libgpg-error/doc/yat2m.c:373:23: note: directive argument in the range [-2147483647, 2147483647] sprintf (buffer,"%04d-%02d-%02d", ^~~~~~~~~~~~~~~~ ../../libgpg-error/doc/yat2m.c:373:7: note: 'sprintf' output between 11 and 36 bytes into a destination of size 16 sprintf (buffer,"%04d-%02d-%02d", ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1900+tp->tm_year, tp->tm_mon+1, tp->tm_mday ); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~