Page MenuHome GnuPG
Feed Advanced Search

Jan 19 2021

gniibe closed T4585: pinentry-tty mishandles ctrl-C as Resolved.

For a bug which requires more tests (like this one with GnuPG and pinentry), I had a practice to put "Testing" tag.

Jan 19 2021, 3:01 AM · Restricted Project, Bug Report
gniibe closed T4585: pinentry-tty mishandles ctrl-C, a subtask of T4771: pinentry-tty/pinentry-curses interact a user as background process, as Resolved.
Jan 19 2021, 3:01 AM · pinentry

Jan 18 2021

gniibe added a project to T5182: libgcrypt self tests for FIPS 140: Restricted Project.
Jan 18 2021, 6:50 AM · Restricted Project, libgcrypt

Jan 15 2021

gniibe added a comment to T5244: libgcrypt: Restrict MD5 use.

Note that even after rCce1cbe16992a: Disable non-allowed algorithms in FIPS mode, gcry_md_open won't return an error with disabled algo.

Jan 15 2021, 8:56 AM · Bug Report, FIPS, libgcrypt
gniibe added a comment to T5244: libgcrypt: Restrict MD5 use.

The changelog in https://src.fedoraproject.org/rpms/libgcrypt/c/402a3b5f2eed746bea996c5743c99bec9bbc3487?branch=master

Jan 15 2021, 8:44 AM · Bug Report, FIPS, libgcrypt
gniibe updated the task description for T5244: libgcrypt: Restrict MD5 use.
Jan 15 2021, 8:33 AM · Bug Report, FIPS, libgcrypt
gniibe added a subtask for T5244: libgcrypt: Restrict MD5 use: T4294: Release Libgcrypt 1.9.0.
Jan 15 2021, 8:08 AM · Bug Report, FIPS, libgcrypt
gniibe added a parent task for T4294: Release Libgcrypt 1.9.0: T5244: libgcrypt: Restrict MD5 use.
Jan 15 2021, 8:08 AM · Release Info, libgcrypt
gniibe created T5244: libgcrypt: Restrict MD5 use.
Jan 15 2021, 8:08 AM · Bug Report, FIPS, libgcrypt
gniibe added a parent task for T4294: Release Libgcrypt 1.9.0: T5243: libgcrypt "check if fips_is_operational and error return if not" patch for FIPS 140.
Jan 15 2021, 7:50 AM · Release Info, libgcrypt
gniibe added a subtask for T5243: libgcrypt "check if fips_is_operational and error return if not" patch for FIPS 140: T4294: Release Libgcrypt 1.9.0.
Jan 15 2021, 7:50 AM · libgcrypt
gniibe removed a subtask for T4294: Release Libgcrypt 1.9.0: T5243: libgcrypt "check if fips_is_operational and error return if not" patch for FIPS 140.
Jan 15 2021, 7:50 AM · Release Info, libgcrypt
gniibe removed a parent task for T5243: libgcrypt "check if fips_is_operational and error return if not" patch for FIPS 140: T4294: Release Libgcrypt 1.9.0.
Jan 15 2021, 7:50 AM · libgcrypt
gniibe added a subtask for T5182: libgcrypt self tests for FIPS 140: T4294: Release Libgcrypt 1.9.0.
Jan 15 2021, 7:50 AM · Restricted Project, libgcrypt
gniibe added a parent task for T4294: Release Libgcrypt 1.9.0: T5182: libgcrypt self tests for FIPS 140.
Jan 15 2021, 7:50 AM · Release Info, libgcrypt
gniibe removed a parent task for T5182: libgcrypt self tests for FIPS 140: T4294: Release Libgcrypt 1.9.0.
Jan 15 2021, 7:49 AM · Restricted Project, libgcrypt
gniibe removed a subtask for T4294: Release Libgcrypt 1.9.0: T5182: libgcrypt self tests for FIPS 140.
Jan 15 2021, 7:49 AM · Release Info, libgcrypt
gniibe claimed T5182: libgcrypt self tests for FIPS 140.
Jan 15 2021, 7:47 AM · Restricted Project, libgcrypt
gniibe renamed T5243: libgcrypt "check if fips_is_operational and error return if not" patch for FIPS 140 from libgcrypt "check if fips_is_operational and error return if not fix" for FIPS 140 to libgcrypt "check if fips_is_operational and error return if not" patch for FIPS 140.
Jan 15 2021, 7:46 AM · libgcrypt
gniibe created T5243: libgcrypt "check if fips_is_operational and error return if not" patch for FIPS 140.
Jan 15 2021, 7:14 AM · libgcrypt
gniibe committed rC7a0da2492536: kdf: Add selftest. (authored by gniibe).
kdf: Add selftest.
Jan 15 2021, 6:32 AM

Jan 13 2021

gniibe committed rC00d7c1c63201: sexp: Raise an error when an integer is negative with USG. (authored by gniibe).
sexp: Raise an error when an integer is negative with USG.
Jan 13 2021, 3:18 AM
gniibe committed rC385a89e35b0b: cmac: Add selftest. (authored by gniibe).
cmac: Add selftest.
Jan 13 2021, 3:18 AM

Jan 12 2021

gniibe committed rCca16fd3ded7c: Change the use of check_one (same name as hmac). (authored by gniibe).
Change the use of check_one (same name as hmac).
Jan 12 2021, 6:23 AM
gniibe committed rC30ca05e8257c: Fix copyright notice and one error message. (authored by gniibe).
Fix copyright notice and one error message.
Jan 12 2021, 6:18 AM
gniibe committed rGc31ba1fcbd22: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Jan 12 2021, 5:52 AM
gniibe committed rGecaabc2d8f87: po: Update Simplified Chinese Translation. (authored by bobwxc).
po: Update Simplified Chinese Translation.
Jan 12 2021, 2:09 AM

Jan 8 2021

gniibe added a comment to T4964: ecc: Discrepancy of handling MPI for the interpretation of signed and unsigned.

For printing SEXP, it would be good to have this change:

Jan 8 2021, 6:58 AM · libgcrypt
gniibe added a comment to T4956: agent: Discrepancy of handling MPI for the interpretation of signed and unsigned.

rG47c1c329ed82: agent,ecc: Use of opaque MPI for ECC, fixup 'd'. does the fixup when reading keys.

Jan 8 2021, 4:18 AM · gpgagent, gnupg
gniibe committed rC4768baf74be0: ecc: Add backward compatibility support for Ed25519 key in SEXP. (authored by gniibe).
ecc: Add backward compatibility support for Ed25519 key in SEXP.
Jan 8 2021, 3:57 AM
gniibe committed rC3fe7036d05f2: ecc: Minor implementation change for _gcry_ecc_get_curve. (authored by gniibe).
ecc: Minor implementation change for _gcry_ecc_get_curve.
Jan 8 2021, 3:57 AM
gniibe added a comment to T4964: ecc: Discrepancy of handling MPI for the interpretation of signed and unsigned.

I describe about rC6f8b1d4cb798: ecc: Consistently handle parameters as unsigned value..

Jan 8 2021, 3:13 AM · libgcrypt
gniibe updated the task description for T4964: ecc: Discrepancy of handling MPI for the interpretation of signed and unsigned.
Jan 8 2021, 2:16 AM · libgcrypt
gniibe added a comment to T4951: Support point compression in Libgcrypt.

Reading compressed point (in keys) is supported (except for NIST P-224). When curve point is represented in compressed format, it is correctly interpreted now. So, for example, I think that with 1.9.0, gpgsm can handle certificate which uses compressed format in its curve point representation.

Jan 8 2021, 2:09 AM · Feature Request, libgcrypt

Jan 7 2021

gniibe committed rC9d9cebb61240: Add CMAC selftest. (authored by gniibe).
Add CMAC selftest.
Jan 7 2021, 9:26 AM
gniibe added a comment to T5189: update Chinese translation.

D520 is accepted by me.
If you will have another fixes, please go ahead.
Or else, I'll commit the change to master of GnuPG.

Jan 7 2021, 8:21 AM · gnupg
gniibe accepted D520: gnupg po: Fix Simplified Chinese Translation.
Jan 7 2021, 8:19 AM

Jan 6 2021

gniibe added inline comments to D520: gnupg po: Fix Simplified Chinese Translation.
Jan 6 2021, 2:40 AM

Jan 5 2021

gniibe added a comment to T5189: update Chinese translation.

rG6850f21d08b2: po: Fix Simplified Chinese Translation. is a fix for adjusting columns; The number means the number of columns.
rGf4a8be0950ea: po: Fix Simplified Chinese Translation. is a fix for:

  • SETERROR is a command name of pinentry which should not be translated.
  • The message is expected to be displayed in four lines.
Jan 5 2021, 2:59 AM · gnupg
gniibe committed rGf4a8be0950ea: po: Fix Simplified Chinese Translation. (authored by gniibe).
po: Fix Simplified Chinese Translation.
Jan 5 2021, 2:54 AM
gniibe committed rG6850f21d08b2: po: Fix Simplified Chinese Translation. (authored by gniibe).
po: Fix Simplified Chinese Translation.
Jan 5 2021, 2:44 AM
gniibe added a comment to T5189: update Chinese translation.

Please check following translations:

"do not detach from the console"
"do not use the internal CCID driver"
"do not use a reader's pinpad"

Those are explanation for the options to instruct gpg-agent or scdaemon, not do something.
It's not a text to users.

Jan 5 2021, 2:31 AM · gnupg
gniibe committed rGbfb073c73279: po: Update Simplified Chinese Translation. (authored by bobwxc).
po: Update Simplified Chinese Translation.
Jan 5 2021, 2:14 AM
gniibe added a comment to T5189: update Chinese translation.

Sorry, I didn't read your message above, and it's applied and pushed to master, due to exactly same reason (it's so big).
It's easier (at least for me), when it's in git repo.

Jan 5 2021, 2:12 AM · gnupg
gniibe accepted D518: po: Update Simplified Chinese translation po/zh_CN.po.
Jan 5 2021, 2:07 AM · gnupg

Dec 28 2020

gniibe committed rG22f7dddc3444: Update Traditional Chinese doc/help.zh_TW.txt (authored by medicalwei).
Update Traditional Chinese doc/help.zh_TW.txt
Dec 28 2020, 9:32 AM
gniibe committed rE621446d3c859: po: Update Traditional Chinese Translation. (authored by bobwxc).
po: Update Traditional Chinese Translation.
Dec 28 2020, 2:17 AM
gniibe added a comment to T5189: update Chinese translation.

For D515, I think that there is similar issue, and I received another patch from Debian.

Dec 28 2020, 2:13 AM · gnupg
gniibe updated subscribers of T5189: update Chinese translation.

Reviewed D517 and pushed it as rE621446d3c859: po: Update Traditional Chinese Translation..

Dec 28 2020, 2:12 AM · gnupg
gniibe accepted D517: po: Update traditional Chinese translation po/zh_TW.po.

I did editorial change for meta data.
Also, I fixed the translation of "out of core", even if it's unused (it's comment).

Dec 28 2020, 2:02 AM

Dec 25 2020

gniibe closed T5163: Cannot import NIST-P521 key to OpenPGP v3.3 smart card as Resolved.
Dec 25 2020, 8:24 AM · Restricted Project, gnupg, scd, Bug Report

Dec 24 2020

gniibe committed rE9b288ec583c0: po: Update Simplified Chinese Translation. (authored by bobwxc).
po: Update Simplified Chinese Translation.
Dec 24 2020, 8:19 AM
gniibe added a comment to T5189: update Chinese translation.

Pushed the change for libgpg-error zh_CN.po.

Dec 24 2020, 8:14 AM · gnupg
gniibe accepted D516: po: Update simplified Chinese translation po/zh_CN.po.
Dec 24 2020, 8:13 AM
gniibe added a comment to D516: po: Update simplified Chinese translation po/zh_CN.po.

I think that you don't use PO editor. I'm going to remove mark like ", fuzzy", which should be removed when entering good entry.

Dec 24 2020, 3:08 AM
gniibe added a comment to T5189: update Chinese translation.

Thank you for your effort. I'll review.

Dec 24 2020, 1:04 AM · gnupg

Dec 23 2020

gniibe added a comment to T5189: update Chinese translation.

Please note that many error messages are defined in: https://dev.gnupg.org/source/libgpg-error/browse/master/po/zh_CN.po
and https://dev.gnupg.org/source/gnupg/browse/master/po/zh_CN.po

Dec 23 2020, 4:09 AM · gnupg
gniibe accepted D514: update gnupg doc/help.zh_CN.txt.
Dec 23 2020, 4:04 AM
gniibe added a comment to T5189: update Chinese translation.

For D515, I will also apply it to master.

Dec 23 2020, 4:03 AM · gnupg
gniibe added a comment to T5189: update Chinese translation.

Applied D514 to master, with an editorial change (removing extra space before newline).

Dec 23 2020, 3:52 AM · gnupg
gniibe committed rGea3fb3dc9462: doc: Update Simplified Chinese doc/help.zh_CN.txt. (authored by bobwxc).
doc: Update Simplified Chinese doc/help.zh_CN.txt.
Dec 23 2020, 3:39 AM
gniibe committed rGeeea4f0fabf7: doc: Update Japanese doc/help.ja.txt. (authored by gniibe).
doc: Update Japanese doc/help.ja.txt.
Dec 23 2020, 3:28 AM
gniibe added a comment to T5167: GnuPG 2.25 still have problems related to Yubikey NEO..

Please change your passphrase for your card, BTW.

Dec 23 2020, 1:31 AM · gnupg (gpg22), yubikey, ssh, scd, Bug Report
gniibe changed the status of T5167: GnuPG 2.25 still have problems related to Yubikey NEO. from Open to Testing.
Dec 23 2020, 1:30 AM · gnupg (gpg22), yubikey, ssh, scd, Bug Report
gniibe added a comment to T5167: GnuPG 2.25 still have problems related to Yubikey NEO..

Good. The error recovery worked well.

Dec 23 2020, 1:30 AM · gnupg (gpg22), yubikey, ssh, scd, Bug Report

Dec 22 2020

gniibe added a comment to D514: update gnupg doc/help.zh_CN.txt.

Translation of "key" is difficult in our context of public key cryptography.
In many case "key" just refers public key, but for key generation, it means key pair.

Dec 22 2020, 8:27 AM

Dec 21 2020

gniibe added a comment to T5189: update Chinese translation.

Please not that you can use this interface: https://dev.gnupg.org/differential/
I think that it is better when you update your patch. You can just refer a patch from this task by:

Dec 21 2020, 8:27 AM · gnupg
gniibe added a comment to T5189: update Chinese translation.

If translated, 'keygrip' should be different word to 'fingerprint', because 'fingerprint' is used as a technical term of OpenPGP.

Dec 21 2020, 7:36 AM · gnupg
gniibe added a comment to T5189: update Chinese translation.

Do you call gpg-agent as 'Gpg 代理'? IIUC, it is better keep it as is (gpg-agent), because it is the name of the program.

Dec 21 2020, 7:26 AM · gnupg
gniibe added a comment to T5186: SCD: Stable branch "Invalid ID" when attempting to sign with bp384 yubikey.

I think that ... For some reason, your private key file under .gnupg/private-keys-v1.d has wrong serial number.

Dec 21 2020, 6:50 AM · gnupg, scd
gniibe committed rPde1829f81f31: gtk+-2: Avoid use of deprecated API. (authored by gniibe).
gtk+-2: Avoid use of deprecated API.
Dec 21 2020, 6:44 AM
gniibe added a comment to T5167: GnuPG 2.25 still have problems related to Yubikey NEO..

Thank you for your testing.
May I ask more test, please?

Dec 21 2020, 1:31 AM · gnupg (gpg22), yubikey, ssh, scd, Bug Report
gniibe committed rC2ab14b23afc0: Merge hmac-tests.c into mac-hmac.c. (authored by gniibe).
Merge hmac-tests.c into mac-hmac.c.
Dec 21 2020, 1:16 AM

Dec 18 2020

gniibe added a comment to T5184: scd: Generating CSR for NetKey card key fails.

IIUC, for completeness, it would be good to add the lines like:

Dec 18 2020, 7:54 AM · scd
gniibe committed rCc90fb0d8fb7a: Reorganize self-tests for HMAC. (authored by gniibe).
Reorganize self-tests for HMAC.
Dec 18 2020, 7:22 AM

Dec 16 2020

gniibe added a comment to T5182: libgcrypt self tests for FIPS 140.

I cannot find good test vectors for PBKDF2 with HMAC-SHA-2.

Dec 16 2020, 6:53 AM · Restricted Project, libgcrypt
gniibe added a comment to T5167: GnuPG 2.25 still have problems related to Yubikey NEO..

Nice, I gonna apply the patch and see if resolves for me!

Dec 16 2020, 3:55 AM · gnupg (gpg22), yubikey, ssh, scd, Bug Report
gniibe committed rG3c55e15cee4b: scd:ccid: Call libusb_clear_halt in ccid_vendor_specific_setup. (authored by gniibe).
scd:ccid: Call libusb_clear_halt in ccid_vendor_specific_setup.
Dec 16 2020, 2:18 AM
gniibe committed rG585cfca0a60b: scd:ccid: Revert the addition of libusb_clear_halt for EP_INTR. (authored by gniibe).
scd:ccid: Revert the addition of libusb_clear_halt for EP_INTR.
Dec 16 2020, 2:18 AM
gniibe reopened T4563: gpg-agent fails to sign request of PKISSH as "Open".
Dec 16 2020, 1:43 AM · Feature Request, gpgagent
gniibe closed T4563: gpg-agent fails to sign request of PKISSH as Wontfix.
Dec 16 2020, 1:42 AM · Feature Request, gpgagent
gniibe added a comment to T4563: gpg-agent fails to sign request of PKISSH.

If your problem is the incompatibility between standard OpenSSH (server) and PKIXSSH (client) for use of ssh-agent emulation of gpg-agent with ECDSA key, I'd suggest to apply following patch to your PKIXSSH:

diff --git a/compat.c b/compat.c
index fe71951..0c9b1ef 100644
--- a/compat.c
+++ b/compat.c
@@ -245,7 +245,6 @@ xkey_compatibility(const char *remote_version) {
 {	static sshx_compatibility info[] = {
 		{ 0, "OpenSSH*PKIX[??.*" /* 10.+ first correct */ },
 		{ 0, "OpenSSH*PKIX[X.*" /* developlement */ },
-		{ 1, "OpenSSH*" /* PKIX pre 10.0 */ },
 		{ 1, "SecureNetTerm-3.1" /* same as PKIX pre 10.0 */},
 		{ 0, NULL } };
 	p = xkey_compatibility_find(remote_version, info);
Dec 16 2020, 12:58 AM · Feature Request, gpgagent

Dec 15 2020

gniibe renamed T5182: libgcrypt self tests for FIPS 140 from libgcrypt tests for FIPS 140 to libgcrypt self tests for FIPS 140.
Dec 15 2020, 6:50 AM · Restricted Project, libgcrypt
gniibe added a comment to T5182: libgcrypt self tests for FIPS 140.

Our tests are now in tests/basic.c.

Dec 15 2020, 6:36 AM · Restricted Project, libgcrypt
gniibe added a comment to T5182: libgcrypt self tests for FIPS 140.

For CMAC tests, we would need to use newer test vectors.

Dec 15 2020, 6:35 AM · Restricted Project, libgcrypt
gniibe created T5182: libgcrypt self tests for FIPS 140.
Dec 15 2020, 6:30 AM · Restricted Project, libgcrypt

Dec 14 2020

gniibe added a comment to T4563: gpg-agent fails to sign request of PKISSH.

Unfortunately and confusingly, PKISSH returns "OpenSSH" when asked by "ssh -V".
Please install real OpenSSH, if this is the case for you.

Dec 14 2020, 10:52 AM · Feature Request, gpgagent
gniibe added a comment to T4563: gpg-agent fails to sign request of PKISSH.

I added "Feature Request", because this is a request to support:

  • A feature of bug compatibility, which is implemented wrongly in PKISSH
  • for a specific algo of key, which is not considered so useful (== ECDSA)
  • PKISSH, which is variant of OpenSSH
Dec 14 2020, 10:23 AM · Feature Request, gpgagent
gniibe added a comment to T4563: gpg-agent fails to sign request of PKISSH.
In T4563#140184, @idl0r wrote:

I was and I am using OpenSSH on both sides, client and server.

Dec 14 2020, 10:20 AM · Feature Request, gpgagent
gniibe changed the status of T5170: card: Allow use cases with no corresponding *.key file under private-keys-v1.d from Open to Testing.
Dec 14 2020, 6:58 AM · Restricted Project, gnupg (gpg23)
gniibe lowered the priority of T4563: gpg-agent fails to sign request of PKISSH from Normal to Low.

In theory, I don't think the patch gnupg.patch works. It just ignore the flag.

Dec 14 2020, 3:19 AM · Feature Request, gpgagent
gniibe added a comment to T2291: Smartcard interaction improvement (was: Shadowed private key design (for smartcard)).

Thank you for testing.
For the issue #1, I think it is the probelm of rG1cd615afe301: gpg,card: Allow no version information of Yubikey., which is fixed already. This was introduced by the support of PIV feature of Yubikey.

Dec 14 2020, 1:05 AM · Restricted Project, gnupg, Feature Request

Dec 11 2020

gniibe committed rG3b3926308813: scd:nks: Support READKEY with keygrip and for "NKS-IDLM" keyref. (authored by gniibe).
scd:nks: Support READKEY with keygrip and for "NKS-IDLM" keyref.
Dec 11 2020, 6:12 AM
gniibe committed rGb7c087375d84: scd:nks: Factor out pubkey retrieval from keygrip handling. (authored by gniibe).
scd:nks: Factor out pubkey retrieval from keygrip handling.
Dec 11 2020, 6:12 AM
gniibe added a comment to T5150: scd: For NetKey cards READKEY with keygrip fails.

Reading the code again, I think that some configuration of NKS card doesn't work well, when it has no certificates but keys (e.g. IDLM config).
I'm going to fix do_readkey as well (the approach #1).

Dec 11 2020, 1:13 AM · backport, gnupg (gpg23), scd

Dec 10 2020

gniibe added a comment to T5167: GnuPG 2.25 still have problems related to Yubikey NEO..

With my Yubikey NEO, when I use OTP (touching the button to generate OTP output as key input), I observed "card eject" event:

2020-12-10 11:23:05 scdaemon[7254] DBG: ccid-driver: CCID: interrupt callback 0 (2)
2020-12-10 11:23:05 scdaemon[7254] DBG: ccid-driver: CCID: NotifySlotChange: 02
2020-12-10 11:23:05 scdaemon[7254] DBG: ccid-driver: CCID: card removed
2020-12-10 11:23:05 scdaemon[7254] DBG: enter: apdu_get_status: slot=0 hang=0
2020-12-10 11:23:05 scdaemon[7254] DBG: leave: apdu_get_status => sw=0x1000c status=0
2020-12-10 11:23:05 scdaemon[7254] DBG: Removal of a card: 0
Dec 10 2020, 3:46 AM · gnupg (gpg22), yubikey, ssh, scd, Bug Report
gniibe committed rG4020cd9d6562: scd:nks: Add support of KEYGRIP for do_readcert. (authored by gniibe).
scd:nks: Add support of KEYGRIP for do_readcert.
Dec 10 2020, 2:41 AM
gniibe committed rG6c4365847666: scd:nks: Factor out iteration over filelist. (authored by gniibe).
scd:nks: Factor out iteration over filelist.
Dec 10 2020, 2:41 AM
gniibe added a comment to T5150: scd: For NetKey cards READKEY with keygrip fails.

Thanks a lot for your time to locate the problem. I took the approach of #2.

Dec 10 2020, 2:37 AM · backport, gnupg (gpg23), scd

Dec 9 2020

gniibe committed rCdb2c0895eacc: Apply libgcrypt-1.8.5-fips-module.patch (authored by gniibe).
Apply libgcrypt-1.8.5-fips-module.patch
Dec 9 2020, 9:17 AM