Nov 26 2023
Nov 25 2023
Works nicely for me in beta300
I'm quite happy with that now. The only thing left to do would be to benchmark this, but to keep this as a an open task for that seems wrong.
Außerdem kann man das ja konfigurieren 😅
Yeah,.. keep the defaults and don't show them? :) With this screenshot you can send even the most friendly user running away. Monospace won't help there. And using different fonts in the same table is also ugly and monospace for the complete table is a no go for me since users should not look at fingerprints or keyids in this table view.
So this is done now to my liking. I took the pkg-copyright from GNUPG as a baseline at the top and then went through all other packages. It is mostly about licenses though and not about copyright holders, even the license information for some packages was weird to figure out. Let alone the individual copyright holders. So I don't think we can or should say "The list of other copyright holders". I changed that now "For a complete list of licenses see: "
Looks good now
This now works to my liking.
I read the documentation (and stackoverflow) as owner we have to close our handle before deleting the file. With FILE_SHARE_DELETE we only ensure that others must live with the fact that we can always delete the file, but since we hold an exclusive READ right (which we gracefully share with others) our handle needs to be closed. So the trick was just to CloseHandle first and then the file could be deleted.
My very simple patch for this would be:
Wait,.. I misunderstood this issue B81CE112B26A8EA8BE7B95D2E375339BF4C51840 has no encryption subkey o.O
The Keyresolver did not allow me to encrypt to an S/MIME cert where the root CA was not in my trustlist.txt that was part of this feature to allow users to encrypt "non vs-nfd compliant" to such untrusted keys, like they would be able to also encrypt to untrusted openpgp keys.
Nov 24 2023
Or you use a Cleaner like the one I added to QGpgME: https://dev.gnupg.org/rM278f92b189ece58dee2036450ac029e3599fdb1f
I am temped to put the VSD-3.2 flag on it and raise prio to high because of strategic reasons... So if someone has a cheap fix for this. Please go for it.
It might also depends on the file type as I wouldn't be surprised if for example the photo viewer opens the file differently than the text editor.
Similarly if you decrypt with a PKI BW card and the mimeviewer there are also no longer problems which again might be related that the internal states where somewhat disturbed by the loop in Kleopatra.
I retested this with the current beta and It works without problems. I somehow suspect that the permanent access loop from Kleopatra caused other Smartcard operations to be canceled. Since the test setup is not really good to reproduce to for Ebo I resolved this myself.
I tested it and for me the files are not deleted:
Since I have such a test card, I just tested it and the issue is indeed gone.
should this go into the upcomming VSD release?
Nov 23 2023
Oh sorry, no that did slightly not make it in when I created the tarball for the current beta.
Now the Learn Certificates button is shown if at least one card key is unknown. And the list of certificates is shown if at least one certificate of a card key is known.
No change in VS-Desktop-3.1.90.295-Beta
Works on windows, too. VS-Desktop-3.1.90.295-Beta
works, VS-Desktop-3.1.90.295-Beta
works, VS-Desktop-3.1.90.295-Beta
VS-Desktop-3.1.90.295-Beta: now there is no button any more... So still no learn key possible.
It is now: https://invent.kde.org/pim/kleopatra/-/merge_requests/75
I realized that for Qt6 the include qtextcodec and setIniCodec must be removed. I should probably ifdef them to make merging more painless.
Should work now.