Page MenuHome GnuPG
Feed All Stories

Oct 24 2018

werner committed rG147e59b7815d: ssh: Fix possible infinite loop in case of an read error. (authored by werner).
ssh: Fix possible infinite loop in case of an read error.
Oct 24 2018, 8:32 PM
werner committed rGf1561e5196e5: tools: Fix FILE memory leak in gpg-connect-agent. (authored by werner).
tools: Fix FILE memory leak in gpg-connect-agent.
Oct 24 2018, 8:32 PM
werner committed rG1b9b0fc54b9b: sm: Use the correct string in an error message. (authored by werner).
sm: Use the correct string in an error message.
Oct 24 2018, 8:32 PM
werner added a project to T4223: Uninitialized use of ctx variable in simple-pwquery.c: backport.

Thanks.

Oct 24 2018, 8:22 PM · gnupg
werner committed rG2bdc4b6ed977: agent: Fix possible release of unitialize var in a genkey error case. (authored by werner).
agent: Fix possible release of unitialize var in a genkey error case.
Oct 24 2018, 8:22 PM
werner committed rGbafcf7095159: agent: Fix possible uninitalized use of CTX in simple_pwquery. (authored by werner).
agent: Fix possible uninitalized use of CTX in simple_pwquery.
Oct 24 2018, 8:22 PM
werner committed rG7385e1babf6e: ssh: Fix possible infinite loop in case of an read error. (authored by werner).
ssh: Fix possible infinite loop in case of an read error.
Oct 24 2018, 8:22 PM
werner committed rG378719f25fe0: tools: Fix FILE memory leak in gpg-connect-agent. (authored by werner).
tools: Fix FILE memory leak in gpg-connect-agent.
Oct 24 2018, 8:22 PM
werner committed rG793fd8d87677: sm: Use the correct string in an error message. (authored by werner).
sm: Use the correct string in an error message.
Oct 24 2018, 8:22 PM
werner added a project to T4222: Uninitialized use of value variable in command.c cmd_genkey: backport.

Thanks. May also happen if the first print_assuan_status fails.

Oct 24 2018, 8:15 PM · gnupg
werner added a project to T4221: Suspicious read error handling in command-ssh.c ssh_handler_add_identity: backport.
Oct 24 2018, 8:11 PM · gnupg
jman added a comment to T4225: Gpg4win - Yubikey failure after generating an OTP.

Can you give me the exact steps what you are doing?
"Generation of an OTP" is strange to me. I have an FST-1 hardware token that runs the same software as a yubikey (GNUK) but I'm not so well versed in all the windows use cases. But I am interested to fix them.

Oct 24 2018, 7:09 PM · Documentation, Bug Report
aheinecke renamed T4225: Gpg4win - Yubikey failure after generating an OTP from (GPG4WIN) to Gpg4win - Yubikey failure after generating an OTP.
Oct 24 2018, 7:04 PM · Documentation, Bug Report
aheinecke added a comment to T4224: PIN entry window not in focus (GPG4WIN).

I've closed this as a dup because the pinentry-qt is the default one on Windows and T4123 describes your problem.

Oct 24 2018, 7:02 PM · Bug Report
aheinecke merged task T4224: PIN entry window not in focus (GPG4WIN) into T4123: Pinentry-qt does not always become active foreground window (especially when requesting pin for authentication).
Oct 24 2018, 7:02 PM · Bug Report
aheinecke merged T4224: PIN entry window not in focus (GPG4WIN) into T4123: Pinentry-qt does not always become active foreground window (especially when requesting pin for authentication).
Oct 24 2018, 7:02 PM · pinentry, Bug Report, gpg4win
aheinecke added a comment to T4224: PIN entry window not in focus (GPG4WIN).

Is it possible that you have used a different pinentry in the past? Like the GTK one?

Oct 24 2018, 7:02 PM · Bug Report
aheinecke updated subscribers of T4225: Gpg4win - Yubikey failure after generating an OTP.

Can you give me the exact steps what you are doing?
"Generation of an OTP" is strange to me. I have an FST-1 hardware token that runs the same software as a yubikey (GNUK) but I'm not so well versed in all the windows use cases. But I am interested to fix them.

Oct 24 2018, 6:59 PM · Documentation, Bug Report
jman created T4225: Gpg4win - Yubikey failure after generating an OTP.
Oct 24 2018, 6:50 PM · Documentation, Bug Report
jman renamed T4224: PIN entry window not in focus (GPG4WIN) from PIN entry window not in focus to PIN entry window not in focus (GPG4WIN).
Oct 24 2018, 6:44 PM · Bug Report
jman created T4224: PIN entry window not in focus (GPG4WIN).
Oct 24 2018, 6:42 PM · Bug Report
t8m created T4223: Uninitialized use of ctx variable in simple-pwquery.c in the S1 Public space.
Oct 24 2018, 5:41 PM · gnupg
t8m created T4222: Uninitialized use of value variable in command.c cmd_genkey in the S1 Public space.
Oct 24 2018, 5:13 PM · gnupg
t8m created T4221: Suspicious read error handling in command-ssh.c ssh_handler_add_identity in the S1 Public space.
Oct 24 2018, 5:08 PM · gnupg
t8m created T4220: Leak of FILE memory in gpg-connect-agent.c:do_open in the S1 Public space.
Oct 24 2018, 4:57 PM · gnupg
t8m created T4219: Copy & paste error in gpgsm.c in the S1 Public space.
Oct 24 2018, 4:47 PM · gnupg
werner committed rG64a1e86fc06d: gpg: Unfinished support for v5 signatures. (authored by werner).
gpg: Unfinished support for v5 signatures.
Oct 24 2018, 4:18 PM
werner committed rG3b88bceb4dc3: indent: Modernize g10/sign.c (authored by werner).
indent: Modernize g10/sign.c
Oct 24 2018, 4:18 PM
werner committed rG256a280c51f9: dirmngr: Prepare for updated WKD specs with ?l= param (authored by werner).
dirmngr: Prepare for updated WKD specs with ?l= param
Oct 24 2018, 4:18 PM
aheinecke closed T4185: I can not import my secret private key -> always failure as Resolved.
Oct 24 2018, 3:23 PM · Bug Report, gpg4win
aheinecke committed rO2fbb76c2d318: Pass --w64 parameter to gpgolconfig (authored by aheinecke).
Pass --w64 parameter to gpgolconfig
Oct 24 2018, 2:46 PM
aheinecke committed rOba8e0516d784: Revert "Addionally add outputdebugstring debugs" (authored by aheinecke).
Revert "Addionally add outputdebugstring debugs"
Oct 24 2018, 2:46 PM
aheinecke committed rOc321d3c3394b: Revert "Add temporary logging to readRegStr" (authored by aheinecke).
Revert "Add temporary logging to readRegStr"
Oct 24 2018, 2:46 PM
aheinecke added a reverting change for rO0ab051af6406: Add temporary logging to readRegStr: rOc321d3c3394b: Revert "Add temporary logging to readRegStr".
Oct 24 2018, 2:46 PM
aheinecke added a reverting change for rO56ea58e405b5: Addionally add outputdebugstring debugs: rOba8e0516d784: Revert "Addionally add outputdebugstring debugs".
Oct 24 2018, 2:46 PM
aheinecke committed rO56ea58e405b5: Addionally add outputdebugstring debugs (authored by aheinecke).
Addionally add outputdebugstring debugs
Oct 24 2018, 1:05 PM
gniibe committed rPTH5fb67e0e5975: build: Compatibility to pkg-config. (authored by gniibe).
build: Compatibility to pkg-config.
Oct 24 2018, 1:00 PM
gniibe committed rPTHf3cbbc86cb49: build: Provide npth.pc, generated by configure. (authored by gniibe).
build: Provide npth.pc, generated by configure.
Oct 24 2018, 1:00 PM
gniibe committed rPTHa48b6aec3659: build: Make npth.m4 use gpg-error-config. (authored by gniibe).
build: Make npth.m4 use gpg-error-config.
Oct 24 2018, 1:00 PM
aheinecke committed rO0ab051af6406: Add temporary logging to readRegStr (authored by aheinecke).
Add temporary logging to readRegStr
Oct 24 2018, 12:59 PM
aheinecke committed rOffeeda76a797: Pseudonym some more without DBG_DATA (authored by aheinecke).
Pseudonym some more without DBG_DATA
Oct 24 2018, 12:59 PM
werner closed T4208: Copy & paste error in libgcrypt ecc-curves.c as Resolved.

Fixed in 1.8

Oct 24 2018, 12:34 PM · Bug Report, libgcrypt
werner closed T4212: Uninitialized use of l1 variable in _gcry_sexp_vextract_param as Resolved.

Fixed in 1.8

Oct 24 2018, 12:33 PM · Bug Report, libgcrypt
werner closed T4102: libgcrypt: yat2m does not respect SOURCE_DATE_EPOCH, patch included as Resolved.

yat2m updated. Thanks.

Oct 24 2018, 12:32 PM · gpgrt, libgcrypt, Bug Report
werner committed rC99a5babfd1e7: build: Add release make target (authored by werner).
build: Add release make target
Oct 24 2018, 12:32 PM
werner committed rC4e044b80b296: doc: Update yat2m.c from upstream (libgpg-error) (authored by werner).
doc: Update yat2m.c from upstream (libgpg-error)
Oct 24 2018, 12:32 PM
werner committed rCabd267bf2393: Fix memory leak in secmem in out of core conditions. (authored by werner).
Fix memory leak in secmem in out of core conditions.
Oct 24 2018, 12:32 PM
werner committed rC60224352f4de: ecc: Fix memory leak in the error case of ecc_encrypt_raw (authored by werner).
ecc: Fix memory leak in the error case of ecc_encrypt_raw
Oct 24 2018, 12:32 PM
werner committed rC7f4de8bab991: doc: Fix example for gcry_sexp_extract_param (authored by werner).
doc: Fix example for gcry_sexp_extract_param
Oct 24 2018, 12:32 PM
werner committed rC347987d4cf29: ecc: Fix possible memory leakage in parameter check of eddsa. (authored by werner).
ecc: Fix possible memory leakage in parameter check of eddsa.
Oct 24 2018, 12:32 PM
werner committed rC8cc7cac82ec2: sexp: Fix uninitialized use of a var in the error case. (authored by werner).
sexp: Fix uninitialized use of a var in the error case.
Oct 24 2018, 12:32 PM
werner committed rCbe68b3ee4fd1: ecc: Fix potential unintended freeing of an internal param. (authored by werner).
ecc: Fix potential unintended freeing of an internal param.
Oct 24 2018, 12:32 PM
werner committed rCb0ad66e48c46: build: Make distcheck work again. (authored by werner).
build: Make distcheck work again.
Oct 24 2018, 12:30 PM
werner committed rC03bb25ee7ed6: build: Add release make target (authored by werner).
build: Add release make target
Oct 24 2018, 12:30 PM
werner committed rC0cfd41c66279: doc: Update yat2m.c from upstream (libgpg-error) (authored by werner).
doc: Update yat2m.c from upstream (libgpg-error)
Oct 24 2018, 12:06 PM
werner closed T4210: Potential memory leak in ecc_encrypt_raw as Resolved.
Oct 24 2018, 11:56 AM · libgcrypt
werner closed T4211: Potential memory leak in _gcry_secmem_malloc_internal as Resolved.

Thanks.

Oct 24 2018, 11:55 AM · libgcrypt
werner committed rCf74687fd43f5: Fix memory leak in secmem in out of core conditions. (authored by werner).
Fix memory leak in secmem in out of core conditions.
Oct 24 2018, 11:55 AM
werner committed rCe57e75ea517f: ecc: Fix memory leak in the error case of ecc_encrypt_raw (authored by werner).
ecc: Fix memory leak in the error case of ecc_encrypt_raw
Oct 24 2018, 11:55 AM
werner added a comment to T4210: Potential memory leak in ecc_encrypt_raw.

Thanks again.

Oct 24 2018, 11:51 AM · libgcrypt
aheinecke created T4218: GpgOL: Populate key cache on startup.
Oct 24 2018, 11:38 AM · gpg4win, gpgol
aheinecke created D469: dirmngr: Add FLUSHCRLs command.
Oct 24 2018, 10:45 AM
aheinecke added a revision to T3967: dirmngr: "flush" does not flush in memory CRL's: D469: dirmngr: Add FLUSHCRLs command.
Oct 24 2018, 10:45 AM · kleopatra, S/MIME, gnupg
aheinecke updated the diff for D468: dirmngr: Read CRLs into memory on Windows.

Added a missing free in case of read error.

Oct 24 2018, 10:29 AM
aheinecke added a comment to T4182: Dirmngr: Keeps files in homedir open on Windows.

If I understand the code correctly the mapping is done to let the system optimize the memory management so that the full contents of the file are not kept in memory, or is there a different reason?

Oct 24 2018, 10:28 AM · dirmngr
aheinecke created D468: dirmngr: Read CRLs into memory on Windows.
Oct 24 2018, 10:26 AM
aheinecke added a revision to T4182: Dirmngr: Keeps files in homedir open on Windows: D468: dirmngr: Read CRLs into memory on Windows.
Oct 24 2018, 10:26 AM · dirmngr
gniibe committed rTace1fa90ec40: build: Fix ntbtls.pc.in. (authored by gniibe).
build: Fix ntbtls.pc.in.
Oct 24 2018, 10:13 AM
werner closed T4209: Potential memory leak in _gcry_ecc_eddsa_verify as Resolved.

Thanks. Not a real world problem now but needs to be fixed.

Oct 24 2018, 10:03 AM · libgcrypt
werner committed rC149ceb3cae03: ecc: Fix possible memory leakage in parameter check of eddsa. (authored by werner).
ecc: Fix possible memory leakage in parameter check of eddsa.
Oct 24 2018, 10:03 AM
gniibe committed rTea6edafcf839: build: Compatibility to pkg-config. (authored by gniibe).
build: Compatibility to pkg-config.
Oct 24 2018, 10:01 AM
gniibe committed rT39d0b3a02afe: build: Fix ntbtls.m4. (authored by gniibe).
build: Fix ntbtls.m4.
Oct 24 2018, 10:01 AM
gniibe committed rTf4e5435e1d4c: build: Update m4 scripts. (authored by gniibe).
build: Update m4 scripts.
Oct 24 2018, 10:01 AM
gniibe committed rT548b70b9db46: build: Provide ntbtls.pc, generated by configure. (authored by gniibe).
build: Provide ntbtls.pc, generated by configure.
Oct 24 2018, 10:01 AM
gniibe committed rT06e6d62dcaf6: build: Make ntbtls.m4 use gpg-error-config. (authored by gniibe).
build: Make ntbtls.m4 use gpg-error-config.
Oct 24 2018, 10:01 AM
werner closed T4216: Newline at end of tooltip string just making tooltip unnecessarily bigger as Resolved.

Thanks. There is an easier solution for this, though: I now trim trailing LFs.

Oct 24 2018, 9:42 AM · gpa, Bug Report
werner committed rGPA70858dcd6062: Trim tooltips before displaying. (authored by werner).
Trim tooltips before displaying.
Oct 24 2018, 9:40 AM
werner triaged T4215: Typo bees/been as Low priority.
Oct 24 2018, 9:27 AM · gpa
aheinecke committed rG01baee2b0ef4: dirmngr: Only print info for no ldapserver file (authored by aheinecke).
dirmngr: Only print info for no ldapserver file
Oct 24 2018, 9:20 AM
aheinecke added a comment to T4182: Dirmngr: Keeps files in homedir open on Windows.

Maybe related, flush also does not work on Windows:

Oct 24 2018, 9:09 AM · dirmngr
werner added a comment to T4217: {libksba,libgcrypt,ntbtls,libassuan,npth}.m4, {libksba,libgcrypt,ntbtls,libassuan}-config script and gpg-error-config.

May I suggest to use a (new) gpgrt-config instead of the current name libgpg-error-config. The long term plan is to change the name of the library.

Oct 24 2018, 9:06 AM · npth, libassuan, ntbtls, libgcrypt, libksba
gniibe committed rA25797256e158: build: Fix libassuan.pc. (authored by gniibe).
build: Fix libassuan.pc.
Oct 24 2018, 8:43 AM
gniibe committed rC0e071372fc0e: build: Fix libgcrypt.pc. (authored by gniibe).
build: Fix libgcrypt.pc.
Oct 24 2018, 8:35 AM
gniibe committed rK4754816d10a3: build: Fix ksba.pc. (authored by gniibe).
build: Fix ksba.pc.
Oct 24 2018, 8:35 AM
aheinecke added a comment to T4193: Debug log has full content of a regular mail even when checkmarked not to have decrypted mail content.

For what it's worth I found some more places where data leaked out even in log level 1. It will probably be a bit of a process to get this clean to a 100% as there is no automated way to decide what needs to be filtered and what not.

Oct 24 2018, 8:28 AM · Bug Report, gpg4win
gniibe committed rCc60eabb11435: build: Compatibility to pkg-config. (authored by gniibe).
build: Compatibility to pkg-config.
Oct 24 2018, 8:26 AM
gniibe committed rC7da887d69d72: build: Make libgcrypt.m4 use gpg-error-config. (authored by gniibe).
build: Make libgcrypt.m4 use gpg-error-config.
Oct 24 2018, 8:26 AM
gniibe committed rC97194b422bc8: build: Provide libgcrypt.pc, generated by configure. (authored by gniibe).
build: Provide libgcrypt.pc, generated by configure.
Oct 24 2018, 8:26 AM
gniibe committed rC5b1febb5e40d: build: Update gpg-error.m4 from libgpg-error. (authored by gniibe).
build: Update gpg-error.m4 from libgpg-error.
Oct 24 2018, 8:26 AM
gniibe committed rC0f4545b441b6: build: Don't default to underscore=yes for cross-build. (authored by gniibe).
build: Don't default to underscore=yes for cross-build.
Oct 24 2018, 8:26 AM
aheinecke committed rOa9f1c04e2933: Only log raw crypto data if DBG_DATA is enabled (authored by aheinecke).
Only log raw crypto data if DBG_DATA is enabled
Oct 24 2018, 8:24 AM
gniibe committed rK5a21f7465ca2: build: Fix previous commit. (authored by gniibe).
build: Fix previous commit.
Oct 24 2018, 7:19 AM
gniibe committed rAb9fb02a823f7: build: Fix previous commit. (authored by gniibe).
build: Fix previous commit.
Oct 24 2018, 7:18 AM
gniibe committed rE184c22bea37d: gpg-error-config: Fix previous commit. (authored by gniibe).
gpg-error-config: Fix previous commit.
Oct 24 2018, 7:15 AM
gniibe committed rKd0016a76942e: build: Provide libassuan.pc, generated by configure. (authored by gniibe).
build: Provide libassuan.pc, generated by configure.
Oct 24 2018, 5:45 AM
gniibe committed rKce5247c0f3fc: build: Make ksba.m4 use gpg-error-config. (authored by gniibe).
build: Make ksba.m4 use gpg-error-config.
Oct 24 2018, 5:45 AM
gniibe committed rKdfc3ad5c6e97: build: Compatibility to pkg-config. (authored by gniibe).
build: Compatibility to pkg-config.
Oct 24 2018, 5:45 AM
gniibe committed rKec4e838ca918: build: Update gpg-error.m4 from libgpg-error. (authored by gniibe).
build: Update gpg-error.m4 from libgpg-error.
Oct 24 2018, 5:45 AM
gniibe committed rA9b1666522f7b: build: Compatibility to pkg-config. (authored by gniibe).
build: Compatibility to pkg-config.
Oct 24 2018, 5:33 AM
gniibe committed rA9c74661d6f80: build: Provide libassuan.pc, generated by configure. (authored by gniibe).
build: Provide libassuan.pc, generated by configure.
Oct 24 2018, 5:33 AM