Tue, Dec 10
I think then we could also include this idea: https://dev.gnupg.org/T5006#195230
If we're looking at changing this workflow, we could also consider how those dialogs (especially the "Certificate Import Result") dialog relate to the "Imported Certificates" tab - maybe we can find a way of showing both the relevant contents of the tab and the dialog in a unified view and then no longer need the dialog
All changes proposed here have been implemented. I do plan more changes, but will put them in separate tickets
Yes, automatic scanning of the clipboard is not good. I withdraw the idea.
I don't really understand the problem. After all gpg-agent seems to be started using gpgconf --launch gpg-agent which should handle the locking properly.
VS-Desktop-3.2.94.474-Beta:
This is, what it looks like after generating the first key in a fresh installation:
Maybe we could join the two dialogs, i.e. add the additional text and the Certify button to the import result window.
On the other hand might 2 pop up windows after an import be annoying…
Although the second window has a "do not show again" option.
Any suggestions?
just a nit in the test name
The title says "notepad". The description says "clipboard". What do you want?
Mon, Dec 9
Additionally permanently watching the clipboard for changes can cause some password managers to detect an "attack". As it is discoverable which application accesses the clipboard on windows we had the case where a password manager would not work when Kleopatras clipboard watcher was running. T6642
We'll do this with QGpgME 3. And it's easy to add new functions by using the NVI pattern and, if needed, virtual functions in the attached private classes. I've been using this technique for quite some time now.
Ah, ok I understood it as "we will change the soname for other reasons e.g. so that both versions are co installable but we will not break ABI". And I would prefer the break for qgpgme at least because of the mentioned problem not because I don't care about ABI stability but because I do and this is a big problem which only exists, because I didn't do it with the last repo move. There is no technical reason anymore for the abstract base classes.
Werner wrote:
We will bump the gpgme core version to 2.0 to indicate this split despite that there will be non-ABI/API incompatibility.
If the major version for QGpgME is bumped, shouldn't we at least remove the virtual base classes. Eg: delete FooJob and rename QGpgMEFooJob to FooJob. I did regret not doing this when i moved them out of libkleo since this architecture no longer makes sense in the standalone libnrary and technically the virtual bases make it nearly impossible to maintain ABI stability when adding functions. The reason for those was only because libkleo had that idea of different backends namely gpgme and chiasmus. But a Library called QGpgME should never provide another backend then GPGME IMO.
So no behavioural change at all, just something to make future ABI compat easier.
I think we have to use multiple different texts instead of assuming that we can use something general as "Detailed import results from %1" which fits all cases in all languages.
ok, then we leave it in the certifications tab like it is.
What about the Uid tab? Keep it like it is, which is: Name, Email, Trust Level, Origin, [Tags] ?
While I do not think that the origin need to be shown by default, I don't think it's really a problem, as this is the last column
Pushed the change for adding hash tests in rC7faf542f1573: fips,tests: Add t-digest.
Sun, Dec 8
Sat, Dec 7
Fri, Dec 6
My comment referred exclusively to Tobias's "In the future [...]" comment.
"Tags" are stored with certifications. Therefore, I think it's useful and makes sense to show the Tags column in the Certifications view.
This is what Tobias means:
Isn't the name of the tab showing the imported certificates "Imported Certficates" or something like that? The filter "All" shows all imported certificates. And when you select the filter OpenPGP you see the subset of imported OpenPGP certificates. Therefore, I don't think it makes sense to add a custom filter.
Gpg4win 4.4: