mpi/longlong.h: fix missing macro parameter parentheses
tests/t-mpi-point: add NIST curve multiplication test vectors
ecc: Fix bug in gcry_pk_get_param for Curve25519.
• werner committed
rC84ad6ac02c45: build: Fix broken mlock detection (authored by Johannes Schindelin via Gcrypt-devel <gcrypt-devel@gnupg.org>).
build: Fix broken mlock detection
random: Silence a warning for building rndjent by Clang.
Minor tweak to gcry_free.
cipher: Extend convenience OID mapping table for AES.
• werner committed
rC41dffbdd5180: cipher: Fix memory leaks for EdDSA. (authored by Tianjia Zhang <tianjia.zhang@linux.alibaba.com>).
cipher: Fix memory leaks for EdDSA.
ecc: Check the input length for the point.
hwf-x86: fix use of wrong operand type
doc: Clarify gcry_md_setkey for keyed BLAKE hashes.
Frankly, I don fully understand your report. Can you please clarify?
Note that with 2.2.8 we introduced full Unicode support on the command line. If you see scrambled output you may want to "chcp 65001" to get the output correctly rendered.
I have recently been busy with the new features and mechanisms of the GpgFrontend project.
wkd: Properly unescape the user-id from a key listing.
agent: Ignore passphrase constraints for a generated passphrase.
agent: Use the sysconfdir for a pattern file.
common: New function decode_c_string.
wkd: Fix client issue with leading or trailing spaces in user-ids.
gpg: Return SUCCESS/FAILURE status also for --card-edit/name.
wkd: Properly unescape the user-id from a key listing.
wkd: Fix client issue with leading or trailing spaces in user-ids.
iirc Uli Drepper added a hack to dladdr which we made use of. Seems to be integrated into dladdr1 now.
scd: Don't release the context until list_finish for PC/SC.
While I don't know if runtime integrity check is required or not by FIPS 140,
I checked OpenSSL, and it has such a check in . The FIPS module configuration file which has the module checksum by HMAC is generated by command.
Ah... I realized that HMAC integrity check with (using address of constant string) might work (at some point) to determine the filename of libgcrypt.so, when/if glibc implementation allows searching with address of constant string. So, my claim "never worked" was wrong.
Do not crash if there are no keys in the keyring
• ikloecker moved
T5544: Kleopatra: Ensure that file encryption dialogs has shortcuts on all actions from
Restricted Project Column to
Restricted Project Column on the
Restricted Project board.
I have added shortcuts to the checkboxes and the (first) visible filename requester. I have not added shortcuts to the two buttons because the first one is anyway the default button, i.e. it reacts on Return, and the Cancel button reacts on Esc.
gpg: Return SUCCESS/FAILURE status also for --card-edit/name.
Move output files/folders before "Encrypt/Sign ... separately" option
Simplify code checking for OpenPGP and/or S/MIME encryption
Add wrapper widget for a FileNameRequester with icon
Sort the enum values in the desired GUI order
Do not add recipient field unconditionally when editing another started
Ensure correct tab order of the recipient widgets
Move focus to next (or previous) recipient field when removing one
Add/improve/fix context of a few translated strings
Take the scroll area out of the tab order
Ensure correct setup of UI for default protocol
Simplify layout handling of recipient widgets
Make the filename requesters accessible with a shortcut
Manually specify shortcuts for all checkboxes
Make it possible to use FileNameRequester as buddy of a label
Set tooltip of push button and line edit
We have the same patch (including the hmac key and we use the switch. The reasoning on our side was to be compatible with fipscheck, but it is no longer used since last year and we use just the hmac256 tool:
Just for the records, the whole HMAC thing including the special dlopen trick used to work fine when we did the original FIPS support.
hmac: Don't have the second implementation of hmac256.
fips: Don't use gcry_check_version for integrity check any more.
fips: Use a .rodata1 section integrity check with hmac256.
build: Generate hash for integrity check with hmac256 (2).
Right. The clarification is that SHA1 itself (for non-security and non-signature use) is still allowed in FIPS mode. But it is not allowed to be used as part of signature schemes of the new API in FIPS mode. The old API, which allows raw signatures without digests, should just fail in FIPS mode too. And the FIPS-compatible gnupg should use the new API too (it would be good to think about this when putting it together).
For Linux and FIPS, we should be actually fine with using /dev/random or getrandom().
agent: Ignore passphrase constraints for a generated passphrase.
agent: Use the sysconfdir for a pattern file.
• ikloecker moved
T5535: Kleopatra: Check that accessibility is also supported for VS-NfD from
Restricted Project Column to
Restricted Project Column on the
Restricted Project board.
Avoid warnings about NULL ptr deref in ASN.1 helpers.
I added some asserts. However I doubt that it can be hit by LibKSBA. I also fixed a real bug related to VALTYPE_BOOL - but that is also not used in Libksba.
The CAVS driver can be safely removed. The certification goes through the ACVP these days so it does not make sense to keep this.
agent: Improve the GENPIN callback.
agent: Fix for zero length help string in pinentry hints.
agent: Improve the GENPIN callback.
common,w32: Replace log_debug by log_info for InProcessJobs
doc: Add sample texts for Pinentry hints
Accept percent escaped formatted-passphrase-hint option.
agent: Fix for zero length help string in pinentry hints.
common,w32: Replace log_debug by log_info for InProcessJobs
doc: Change group size for passphrase formatting to five
qt: Change group size for passphrase formatting to 5
build: Generate hash for integrity check with hmac256.
cipher: Fix the order of fields of gcry_md_context.
hmac: Fix hmac256 command option handling.
I have done tests with 2.2 and no problems showed up.
w32: Move socketdir to LOCAL_APPDATA
agent: Make QT_QPA_PLATFORMTHEME=qt5ct work for the pient
agent: New option --check-sym-passphrase-pattern.
gpgconf,w32: Print more registry diagnostics with --list-dirs.
agent: Add checkpin inquiry for pinentry
common: Pass XDG_SESSION_TYPE and QT_QPA_PLATFORM envvars to pinentry
agent: New option --pinentry-formatted-passphrase
tools: Extend gpg-check-pattern.
(can't access that bug with my account)
For tests with FIPS mode enabled, I manually create the file under src/.libs.
• gniibe added a project to
T5520: Fix tests in FIPS mode:
Restricted Project.
I pushed my further change.
Also, applied and pushed your changes.