Page MenuHome GnuPG
Feed Advanced Search

Oct 24 2018

werner added a comment to T4210: Potential memory leak in ecc_encrypt_raw.

Thanks again.

Oct 24 2018, 11:51 AM · libgcrypt
werner closed T4209: Potential memory leak in _gcry_ecc_eddsa_verify as Resolved.

Thanks. Not a real world problem now but needs to be fixed.

Oct 24 2018, 10:03 AM · libgcrypt
werner committed rC149ceb3cae03: ecc: Fix possible memory leakage in parameter check of eddsa. (authored by werner).
ecc: Fix possible memory leakage in parameter check of eddsa.
Oct 24 2018, 10:03 AM
werner closed T4216: Newline at end of tooltip string just making tooltip unnecessarily bigger as Resolved.

Thanks. There is an easier solution for this, though: I now trim trailing LFs.

Oct 24 2018, 9:42 AM · gpa, Bug Report
werner committed rGPA70858dcd6062: Trim tooltips before displaying. (authored by werner).
Trim tooltips before displaying.
Oct 24 2018, 9:40 AM
werner triaged T4215: Typo bees/been as Low priority.
Oct 24 2018, 9:27 AM · gpa
werner added a comment to T4217: {libksba,libgcrypt,ntbtls,libassuan,npth}.m4, {libksba,libgcrypt,ntbtls,libassuan}-config script and gpg-error-config.

May I suggest to use a (new) gpgrt-config instead of the current name libgpg-error-config. The long term plan is to change the name of the library.

Oct 24 2018, 9:06 AM · npth, libassuan, ntbtls, libgcrypt, libksba
werner committed rKa1ce3c17ee0d: Fix error detection in the CMS parser which may led to a NULL-deref. (authored by werner).
Fix error detection in the CMS parser which may led to a NULL-deref.
Oct 24 2018, 2:13 AM
werner committed rKd56bddc68db8: Use only one .PHONY target in a Makefile. (authored by werner).
Use only one .PHONY target in a Makefile.
Oct 24 2018, 2:13 AM
werner committed rKa0bbba1c4928: Fix test for existence of the signing_time (authored by werner).
Fix test for existence of the signing_time
Oct 24 2018, 2:13 AM

Oct 23 2018

werner committed rCe2da4e8dee4b: ecc: Fix potential unintended freeing of an internal param. (authored by werner).
ecc: Fix potential unintended freeing of an internal param.
Oct 23 2018, 11:38 PM
werner committed rC9f2c7ec4d8b0: sexp: Fix uninitialized use of a var in the error case. (authored by werner).
sexp: Fix uninitialized use of a var in the error case.
Oct 23 2018, 11:38 PM
werner committed rC282f238f7788: doc: Fix example for gcry_sexp_extract_param (authored by werner).
doc: Fix example for gcry_sexp_extract_param
Oct 23 2018, 11:38 PM
werner triaged T4208: Copy & paste error in libgcrypt ecc-curves.c as High priority.

Thanks. Fixed in master. Needs backport.

Oct 23 2018, 10:59 PM · Bug Report, libgcrypt
werner triaged T4199: Disable scaling for cardkey icon in keylist as Normal priority.
Oct 23 2018, 10:54 PM · gpa, Bug Report
werner triaged T4212: Uninitialized use of l1 variable in _gcry_sexp_vextract_param as High priority.

Thanks. Fixed in master.

Oct 23 2018, 10:53 PM · Bug Report, libgcrypt
werner closed T4207: Copy & paste error in libksba cms.c as Resolved.

Thanks.

Oct 23 2018, 10:44 PM · libksba
werner closed T4213: Invalid test for certlist->signing_time in build_signed_data_attributes in cms.c as Resolved.

Thanks. That code is from 2001 and whne I changed to another time representaion in 2003 (due certs with 40 years expiration time) I missed to changed that condition.

Oct 23 2018, 10:39 PM · libksba
werner committed rGPA493b02e52377: po: Added missing files and sorted POTFILES (authored by werner).
po: Added missing files and sorted POTFILES
Oct 23 2018, 10:01 PM
werner closed T4214: Missing files in POTFILES.in as Resolved.

Thanks. I added these files.

Oct 23 2018, 9:55 PM · gpa

Oct 22 2018

werner committed rGa2bd4a64e5b0: dirmngr: Prepare for updated WKD specs with ?l= param (authored by werner).
dirmngr: Prepare for updated WKD specs with ?l= param
Oct 22 2018, 8:14 PM
werner closed T4014: when verifying signatures, gpg and gpgv should ensure signing capabilities as Resolved.
Oct 22 2018, 7:32 PM · gpgv, gnupg, Bug Report
werner committed rGb0d6e26bf3c8: gpg: Fix extra check for sign usage of a data signature. (authored by werner).
gpg: Fix extra check for sign usage of a data signature.
Oct 22 2018, 7:29 PM
werner added a comment to T4182: Dirmngr: Keeps files in homedir open on Windows.

iirrc, that are memory mapped files.

Oct 22 2018, 5:35 PM · dirmngr
werner committed rG68b8096b6617: agent: Fix build regression for Windows. (authored by werner).
agent: Fix build regression for Windows.
Oct 22 2018, 5:28 PM
werner committed rG0a7f446c1892: dirmngr: In verbose mode print the OCSP responder id. (authored by werner).
dirmngr: In verbose mode print the OCSP responder id.
Oct 22 2018, 2:52 PM
werner committed rGf03928b16c4f: tools: Replace duplicated code in mime-maker. (authored by werner).
tools: Replace duplicated code in mime-maker.
Oct 22 2018, 2:52 PM
werner added a comment to rE12b834ba59ae: yat2m: Avoid compiler warnings..

Can you please be so kind and show the compiler warning? I can't see any fault in the code unless the OS is broken.
Instead of that change I would suggest to change the sprintf to

snprintf (buffer,  sizeof buffer, "%04d-%02d-%02d",
          1900+tp->tm_year, tp->tm_mon+1, tp->tm_mday )
Oct 22 2018, 12:51 PM
werner created T4205: Release libgpg-error 1.33.
Oct 22 2018, 12:01 PM · gpgrt, Release Info
werner closed T4201: gpg: keyserver send failed: Server indicated a failure as Resolved.

I am sorry about this but the hkps pool has load problems because only a few servers are left. You might have a better chance getting your key uploaded by configuring another pool. See https://sks-keyservers.net . The admins are aware of the problem but there won't be any short time solution.

Oct 22 2018, 10:02 AM · Bug Report

Oct 21 2018

werner triaged T4175: HTTP 5xx should fail over to the next server as High priority.
Oct 21 2018, 2:48 PM · dirmngr, Feature Request
werner created T4200: Evaluate sub-addresses in gpg and wkd.
Oct 21 2018, 2:46 PM · gnupg, Feature Request

Oct 19 2018

werner added a comment to T4198: Pinentry doesn't capture input correctly, crashes terminal instead.

Thanks for the reporting templates; would mind to fill in some bug details?

Oct 19 2018, 8:00 PM · pinentry, Bug Report

Oct 18 2018

werner lowered the priority of T3443: Install gpg 1.4 as gpg1 from Unbreak Now! to Normal.
Oct 18 2018, 8:35 PM · Feature Request
werner added a comment to T4191: gpgme python bindings test t-callbacks.py fails on 32-bit platforms.

That is up to @BenM

Oct 18 2018, 7:56 PM · Python, gpgme, Bug Report
werner closed T4196: gpgme-json is confused about malformed input as Invalid.

The default mode of the tool is to use the Native Messaging protocol which prefixes requests and responses with a 32 bit native endian length header. It is the default due to the way browsers call native messaging programs. If you want to use it in a different way, use the option --single or --interactive.

Oct 18 2018, 7:54 PM · gpgme
werner added a comment to T4195: Fix time API in gpgme.

That it will not be a problem on that or near that date but already now because some use expiration times of 20 years.

Oct 18 2018, 7:49 PM · gnupg, kleopatra, gpgme, Feature Request
werner added a comment to T4191: gpgme python bindings test t-callbacks.py fails on 32-bit platforms.

See T4195 for the general problem

Oct 18 2018, 6:10 PM · Python, gpgme, Bug Report
werner created T4195: Fix time API in gpgme.
Oct 18 2018, 6:09 PM · gnupg, kleopatra, gpgme, Feature Request
werner assigned T4191: gpgme python bindings test t-callbacks.py fails on 32-bit platforms to BenM.

I have not looked at the new error but the year 2099 is clearly a y2k38 problem. gpg has some precautions but I have not checked the key generation code. The gpgme interface uses a signed long for the expiration time, although that it parses the dates received from gpg as an unsigned long. Right now, I am not sure why we did this because an unsigned long would just work. Maybe we can change or enhance the interface. But in any case this is a general problem and not specific to this bug.

Oct 18 2018, 5:54 PM · Python, gpgme, Bug Report
werner changed the status of T4192: python gpg segfaults when first parameter to gpg.Context().op_genkey() is None or otherwise malformed from Open to Testing.
Oct 18 2018, 5:41 PM · Python, gpgme
werner committed rMfbac11b19d97: core: Fix segv in genkey when no endtag is provided. (authored by werner).
core: Fix segv in genkey when no endtag is provided.
Oct 18 2018, 5:41 PM
werner added a comment to T4192: python gpg segfaults when first parameter to gpg.Context().op_genkey() is None or otherwise malformed.

@BenM thinks that swig is still the best option. Actually this case helped to find a bug in gpgme. See my next commit.

Oct 18 2018, 5:40 PM · Python, gpgme
werner committed rM174af15725d4: core: Return an error if NULL is provided for genkey's parms. (authored by werner).
core: Return an error if NULL is provided for genkey's parms.
Oct 18 2018, 5:00 PM
werner added a comment to T4192: python gpg segfaults when first parameter to gpg.Context().op_genkey() is None or otherwise malformed.

That swig based interface is not really robust and it can't be because it does not known about API requirements. I bet there are other places where mandatory parameters are not checked.

Oct 18 2018, 4:13 PM · Python, gpgme
werner changed the status of T3354: gpgme only builds against two versions of python at once from Open to Testing.
Oct 18 2018, 11:48 AM · Python, gpgme, Bug Report
werner triaged T4191: gpgme python bindings test t-callbacks.py fails on 32-bit platforms as High priority.
Oct 18 2018, 11:46 AM · Python, gpgme, Bug Report
werner added a comment to rM2f12427e416a: doc: use https:// for www.gnu.org.

FWIW, you should better not change the build-aux/ files becuase they are supposed to be updated from libgpg-error.

Oct 18 2018, 11:42 AM
werner triaged T4190: https://git.gnupg.org/ is out of date as Normal priority.
Oct 18 2018, 11:40 AM · gpgweb, Bug Report
werner assigned T4192: python gpg segfaults when first parameter to gpg.Context().op_genkey() is None or otherwise malformed to BenM.
Oct 18 2018, 11:39 AM · Python, gpgme
werner added a comment to T4192: python gpg segfaults when first parameter to gpg.Context().op_genkey() is None or otherwise malformed.

Is this new in gpgme 1.12 or might it also be in older versions?

Oct 18 2018, 11:38 AM · Python, gpgme
werner committed rGPAd7f0e50b7a45: Replace use of the GPGME_KEYLIST_MODE_LOCATE alias (authored by werner).
Replace use of the GPGME_KEYLIST_MODE_LOCATE alias
Oct 18 2018, 11:29 AM
werner committed rGPA9ac18119fb3c: Allow searchin in the key listing also for mail addresses. (authored by werner).
Allow searchin in the key listing also for mail addresses.
Oct 18 2018, 11:17 AM

Oct 17 2018

werner closed T4187: Error in decrypt_file function as Invalid.

That is a different python binding than what we provide with gpgme. Our gpgme based binding is called "gpg" and was formerly known as "pyme". I strongly suggest to install gpgme and not to use pip because the "gpg" module over there has not been updated for quite some time.

Oct 17 2018, 9:59 PM · Bug Report
werner added a comment to T4187: Error in decrypt_file function.

From where did you go that "python package gnupg==2.3.1" ?
Sorry, I can see what kind of Python code this is. It is not part of GnuPG, though.

Oct 17 2018, 5:43 PM · Bug Report
werner added a comment to T4085: Add support for pkg-config.

Frankly, I still do not understand the problems with cross-compiling. Since 2014 we support SYSROOT and the respective foo-config script is installed as $SYSROOT/bin/foo-config. This guarantees that a matching config script is used and because it is a script it works on all platforms from which we are cross-building. It is also fine to install that very script in the bin dir of the (target) host; it will work there as long as host is a Unix system. So it does not matter whether it is a plain text file (a la pgk-config) or a POSIX script. The only important thing is to really install the foo-config at SYSROOOT/bin - make install does it.

Oct 17 2018, 10:45 AM
werner committed rMff6ff616aea6: python: Auto-check for all installed python versions. (authored by werner).
python: Auto-check for all installed python versions.
Oct 17 2018, 10:07 AM

Oct 16 2018

werner assigned T4173: gpgme 1.12.0 make check fails to aheinecke.

It seems to be a cpp problem. Andre, would you mind to take this bug?

Oct 16 2018, 11:55 PM · gpgme, Bug Report
werner closed T4186: GPA 0.10.0 release as Resolved.

Release today.

Oct 16 2018, 11:52 PM · gpa, Release Info
werner committed rD9d646eba1474: swdb: Release gpa 0.10.0 (authored by werner).
swdb: Release gpa 0.10.0
Oct 16 2018, 11:52 PM
werner committed rGPAb68e47f38536: Post release updates (authored by werner).
Post release updates
Oct 16 2018, 11:48 PM
werner committed rGPA43f95b7de615: po: Auto update (authored by werner).
po: Auto update
Oct 16 2018, 11:48 PM
werner committed rGPAbb097c7b8bb0: Release 0.10.0 (authored by werner).
Release 0.10.0
Oct 16 2018, 11:48 PM
werner committed rGPA40e0c2e6d438: Require more modern versions of libraries. (authored by werner).
Require more modern versions of libraries.
Oct 16 2018, 11:48 PM
werner created T4186: GPA 0.10.0 release.
Oct 16 2018, 11:26 PM · gpa, Release Info
werner committed rGPA82ec950925c9: po: Update Russian translation (authored by Ineiev <ineiev@gnu.org>).
po: Update Russian translation
Oct 16 2018, 10:00 PM
werner committed rGPAdd43dd901499: Make sure valid utf-8 is passed to GtkTextView. (authored by werner).
Make sure valid utf-8 is passed to GtkTextView.
Oct 16 2018, 7:33 PM
werner committed rMd63d6d8b8030: core: Really remove CR from version output. (authored by werner).
core: Really remove CR from version output.
Oct 16 2018, 5:30 PM
werner added inline comments to rM6bde05635579: 2006-07-16 Marcus Brinkmann <marcus@g10code.de>.
Oct 16 2018, 4:52 PM
werner committed rGPA728f09629698: po: Update German translation (authored by werner).
po: Update German translation
Oct 16 2018, 1:32 PM
werner committed rGPA83227b81ae3f: In --locate-key mode ley Retrieve_Key not search in Local. (authored by werner).
In --locate-key mode ley Retrieve_Key not search in Local.
Oct 16 2018, 1:04 PM
werner committed rGPA210c7c375df1: Make diagnostic dialog scrollable. (authored by werner).
Make diagnostic dialog scrollable.
Oct 16 2018, 1:04 PM
werner committed rGPA1ca0eb42967a: Add more details buttons to error dialogs. (authored by werner).
Add more details buttons to error dialogs.
Oct 16 2018, 1:04 PM

Oct 15 2018

werner closed T3377: GPA updated Swedish translation as Resolved.

Just commited. Thanks.

Oct 15 2018, 9:24 PM · gpa, i18n, patch, Bug Report
werner committed rGPA38bdae22d127: po: Update Swedish translation (authored by werner).
po: Update Swedish translation
Oct 15 2018, 9:24 PM
werner closed T2373: GPA should explain problems with expired subkeys. as Wontfix.

The next version will have a details button to show the actual gpg output. This will often be helpful.

Oct 15 2018, 9:21 PM · Feature Request, gpa
werner closed T2949: GPGME library returned unexpected error at keytable.c150 - Debian as Invalid.

The current version is 0.9.10 and the reported 0.9.5 is 4 years old. We also received no more info.

Oct 15 2018, 9:20 PM · Too Old, gpa, Bug Report
werner closed T4049: BUG in gpa - MUST everytime save private key to harddisk to export it as Resolved.

The "Copy" menu item already copies public keys to the clipboard.
I now added a private key key copy option to the context menu.

Oct 15 2018, 9:15 PM · Feature Request, gpa
werner committed rGPAf8d64d13a15a: Add context menu to copy a private key to the clipboard. (authored by werner).
Add context menu to copy a private key to the clipboard.
Oct 15 2018, 9:14 PM
werner committed rGPAf160e92d908e: Let Server->Retrieve_Key use --locate-key for a mail address. (authored by werner).
Let Server->Retrieve_Key use --locate-key for a mail address.
Oct 15 2018, 7:24 PM
werner committed rGPA9e119866c02c: Add diagnostic button to some error report dialogs. (authored by werner).
Add diagnostic button to some error report dialogs.
Oct 15 2018, 7:24 PM
werner committed rGPAfea939b6fe08: Add context menu to copy the fingerprint(s). (authored by werner).
Add context menu to copy the fingerprint(s).
Oct 15 2018, 4:52 PM
werner committed rGPAf5361478e121: Show GPGME version in the about dialog. (authored by werner).
Show GPGME version in the about dialog.
Oct 15 2018, 4:52 PM

Oct 12 2018

werner added a project to T4173: gpgme 1.12.0 make check fails: gpgme.

Thanks for the report. I would also like to see what

Oct 12 2018, 5:31 PM · gpgme, Bug Report
werner committed rM233d2f3d351c: cl: Add missing file (authored by werner).
cl: Add missing file
Oct 12 2018, 9:05 AM
werner committed rM85d7af8ff2f6: cl: Several fixes (authored by Guillaume LE VAILLANT <glv@posteo.net>).
cl: Several fixes
Oct 12 2018, 9:05 AM
werner committed rMaafadb859497: Register DCO for Guillaume LE VAILLANT (authored by werner).
Register DCO for Guillaume LE VAILLANT
Oct 12 2018, 9:05 AM

Oct 11 2018

werner committed rD89c22291b1bb: verein: Add contact info (authored by werner).
verein: Add contact info
Oct 11 2018, 3:07 PM

Oct 10 2018

werner added a member for g10code: MuckiSG.
Oct 10 2018, 7:19 PM
werner committed rDb0a7e26f7684: web: Add BSI PR for EasyGPG (authored by werner).
web: Add BSI PR for EasyGPG
Oct 10 2018, 7:18 PM
werner closed T4176: Remove my account as Resolved.

I will disable your account but destroying the account and all data is not possible because this has public interlinked content. The intro page at dev.gnupg.org clearly explains this as welll as the privacy policy linked from the side menu; excerpt

Oct 10 2018, 5:55 PM · dev.gnupg.org
werner added a comment to T3811: New website design.

The pages of the Verein shall use a different layout than the general gnupg.org pages.

Oct 10 2018, 5:34 PM · gpgweb, Verein
werner changed the status of T4146: GPG Agent fails in parallel: "gpg: decryption failed: No secret key" from Open to Testing.
Oct 10 2018, 12:10 PM · gnupg (gpg22), MacOS, Bug Report
werner added a comment to T4146: GPG Agent fails in parallel: "gpg: decryption failed: No secret key".

Please put

Oct 10 2018, 12:09 PM · gnupg (gpg22), MacOS, Bug Report
werner committed rG150a33df4194: gpg: Don't take the a TOFU trust model from the trustdb, (authored by werner).
gpg: Don't take the a TOFU trust model from the trustdb,
Oct 10 2018, 11:49 AM
werner changed the status of T4134: GnuPG: Changing the trust model once changes the default trust model from Open to Testing.
Oct 10 2018, 11:48 AM · gpg4win, gpgol, Bug Report, gnupg

Oct 9 2018

werner committed rD05b61018582e: web: Release info for gnupg 2.2.10 and gpgme 1.12.0 (authored by werner).
web: Release info for gnupg 2.2.10 and gpgme 1.12.0
Oct 9 2018, 10:04 AM
werner accepted D466: core: Add trust-model flag.
Oct 9 2018, 9:41 AM

Oct 8 2018

werner added a comment to T4014: when verifying signatures, gpg and gpgv should ensure signing capabilities.

Editor fault. The browser's editor is not like Emacs and here o my laptop the backspace key does not work as intended. I guess I was about to write ".. a back signature's usage flag".

Oct 8 2018, 11:49 PM · gpgv, gnupg, Bug Report
werner reopened T4014: when verifying signatures, gpg and gpgv should ensure signing capabilities as "Testing".

The fix was not fully correct because it considered a back signature's usage tool.

Oct 8 2018, 4:26 PM · gpgv, gnupg, Bug Report