Page MenuHome GnuPG
Feed Advanced Search

Sep 17 2024

gniibe changed the status of T7277: libgcrypt: Adding Known Answer Tests for KEM from Open to Testing.

Pushed the change in: rC38742196c04c: cipher:kyber: Add gcry_kem_genkey to support deterministic op.
rC4876a1a45c25: tests:kyber: Add genkey and encap KAT tests.

Sep 17 2024, 9:39 AM · PQC, libgcrypt
gniibe added a comment to T7293: spawn API glitch.

Fixed GnuPG 2.4 in: rG730593affa91: common:w32: Don't expose unused functions.

Sep 17 2024, 9:11 AM · gnupg22 (gnupg-2.2.45), gnupg24, gpgrt, Bug Report
gniibe added a comment to T7138: Windows (Semi-hosted environment): filename and network access.

For now, I'm using this to avoid failure of make check (invoking gpg-agent by gpg-connect-agent).

diff --git a/common/stringhelp.c b/common/stringhelp.c
index 9a2265258..6596c65cd 100644
--- a/common/stringhelp.c
+++ b/common/stringhelp.c
@@ -70,6 +70,22 @@ change_slashes (char *name)
 {
 #ifdef HAVE_DOSISH_SYSTEM
   char *p;
+  /* 0: don't know yet, 1: it's under wine, -1: no */
+  static int semihosted_by_wine;
+
+  /* Under wine, no change.  */
+  if (!semihosted_by_wine)
+    {
+      HMODULE hntdll = GetModuleHandle ("ntdll.dll");
+      if (hntdll
+          && GetProcAddress (hntdll, "wine_get_version"))
+        semihosted_by_wine = 1;
+      else
+        semihosted_by_wine = -1;
+    }
+
+  if (semihosted_by_wine > 0)
+    return name;
Sep 17 2024, 4:40 AM · gnupg, Bug Report
gniibe updated the task description for T7293: spawn API glitch.
Sep 17 2024, 3:15 AM · gnupg22 (gnupg-2.2.45), gnupg24, gpgrt, Bug Report
gniibe committed rG730593affa91: common:w32: Don't expose unused functions. (authored by gniibe).
common:w32: Don't expose unused functions.
Sep 17 2024, 2:33 AM
gniibe set External Link to https://bugs.debian.org/1081807 on T7293: spawn API glitch.
Sep 17 2024, 2:26 AM · gnupg22 (gnupg-2.2.45), gnupg24, gpgrt, Bug Report
gniibe updated the task description for T7293: spawn API glitch.
Sep 17 2024, 2:23 AM · gnupg22 (gnupg-2.2.45), gnupg24, gpgrt, Bug Report
gniibe claimed T7293: spawn API glitch.

libgpg-error fix is done in: rEc2a713fe11e3: w32:spawn: Remove unused function get_max_fds.

Sep 17 2024, 2:22 AM · gnupg22 (gnupg-2.2.45), gnupg24, gpgrt, Bug Report
gniibe created T7293: spawn API glitch.
Sep 17 2024, 2:20 AM · gnupg22 (gnupg-2.2.45), gnupg24, gpgrt, Bug Report

Sep 16 2024

gniibe committed rEc2a713fe11e3: w32:spawn: Remove unused function get_max_fds. (authored by gniibe).
w32:spawn: Remove unused function get_max_fds.
Sep 16 2024, 9:00 AM
gniibe claimed T7291: scdaemon randomly hangs when trying to access a token.
Sep 16 2024, 8:30 AM · scd
gniibe closed T7139: Windows: gnupg_exec_tool_stream with INEXTRA as Resolved.
Sep 16 2024, 8:14 AM · gnupg26, Bug Report

Sep 13 2024

gniibe committed rGb08d990607b6: tests:gpgscm: Raise an error correctly for process spawning. (authored by gniibe).
tests:gpgscm: Raise an error correctly for process spawning.
Sep 13 2024, 4:04 AM

Sep 12 2024

gniibe changed the status of T7220: The CF protection not enabled in libgcrypt from Open to Testing.
Sep 12 2024, 7:17 AM · libgcrypt, Bug Report
gniibe changed the status of T7226: libgcrypt 1.11.0 buid error on armhf with gcc-14 from Open to Testing.
Sep 12 2024, 7:17 AM · FTBFS, arm, libgcrypt, Bug Report
gniibe changed the status of T7246: libassuan 3.0.1: putc_unlocked() is re-defined unconditionally from Open to Testing.
Sep 12 2024, 7:12 AM · libassuan, MacOS, Bug Report

Sep 11 2024

gniibe committed rG7e321c2c2a15: gpg: Fix getting key by IPGP. (authored by gniibe).
gpg: Fix getting key by IPGP.
Sep 11 2024, 6:56 AM
gniibe claimed T7288: gpg is not properly handling IPGP entries.
Sep 11 2024, 6:45 AM · dns, dirmngr, gnupg, Bug Report

Sep 9 2024

gniibe committed rP7f9f6bab93cc: curses: Factor out dialog release to separate function. (authored by Jakuje).
curses: Factor out dialog release to separate function.
Sep 9 2024, 10:37 AM
gniibe added a comment to T7287: libgpg-error:w32: Support setting an environment block encoded as UTF-8.

Since CreateProcessW allows two ways for lpEnvironment (one is ANSI environment block, another is Unicode environment block), if we want to support these two ways for users' of gpgrt spawn API, we would offer either:

Sep 9 2024, 8:31 AM · Bug Report, gpgrt
gniibe added a comment to T7287: libgpg-error:w32: Support setting an environment block encoded as UTF-8.

I'm talking about CreateProcessW and how a user of gpgrt spawn API can specify lpEnvironment (when needed).

Sep 9 2024, 8:03 AM · Bug Report, gpgrt
gniibe changed the status of T7218: pinentry memory leak from Open to Testing.

Thank you. Applied.

Sep 9 2024, 7:58 AM · pinentry, Bug Report
gniibe added a comment to T7288: gpg is not properly handling IPGP entries.

Thank you for the bug report and your patch.

Sep 9 2024, 7:19 AM · dns, dirmngr, gnupg, Bug Report
gniibe added a comment to T7287: libgpg-error:w32: Support setting an environment block encoded as UTF-8.

Please note that gpgrt_spawn_actions_set_envvars is W32 specific API in libgpg-error. Currently, the behavior with ASCII string is defined.
The patch is an answer in future if we want to extend the semantics supporting UTF-8.

Sep 9 2024, 2:53 AM · Bug Report, gpgrt

Sep 6 2024

gniibe added a project to T7277: libgcrypt: Adding Known Answer Tests for KEM: PQC.
Sep 6 2024, 8:50 AM · PQC, libgcrypt
gniibe added a comment to T7287: libgpg-error:w32: Support setting an environment block encoded as UTF-8.

Here is my attempt:

Sep 6 2024, 8:11 AM · Bug Report, gpgrt
gniibe committed rE0f7b327ccf6d: w32: Clarify the environment block encoding. (authored by gniibe).
w32: Clarify the environment block encoding.
Sep 6 2024, 4:33 AM
gniibe triaged T7287: libgpg-error:w32: Support setting an environment block encoded as UTF-8 as Normal priority.
Sep 6 2024, 4:06 AM · Bug Report, gpgrt
gniibe committed rG412e183e55c5: scd:w32: Fix for setting an environment block with GNUPGHOME. (authored by gniibe).
scd:w32: Fix for setting an environment block with GNUPGHOME.
Sep 6 2024, 3:55 AM

Sep 5 2024

gniibe committed rGc9677e950170: scd:w32: Export GNUPGHOME for scd-event. (authored by gniibe).
scd:w32: Export GNUPGHOME for scd-event.
Sep 5 2024, 6:40 AM
gniibe added a comment to T7169: libgpg-error 1.50 build issue (spawn-posix.c:345:5: error: use of undeclared identifier 'environ').

Use of execve is better (avoiding use of environ).

Sep 5 2024, 4:22 AM · gpgrt, MacOS, Bug Report
gniibe merged task T7168: environ not declared in macOS; gpgrt 1.50 failed to build. into T7169: libgpg-error 1.50 build issue (spawn-posix.c:345:5: error: use of undeclared identifier 'environ').
Sep 5 2024, 4:20 AM · gpgrt, Bug Report, MacOS
gniibe merged T7168: environ not declared in macOS; gpgrt 1.50 failed to build. into T7169: libgpg-error 1.50 build issue (spawn-posix.c:345:5: error: use of undeclared identifier 'environ').
Sep 5 2024, 4:20 AM · gpgrt, MacOS, Bug Report

Sep 4 2024

gniibe added a comment to T7246: libassuan 3.0.1: putc_unlocked() is re-defined unconditionally.

Fixed in: rA69069bc63e6b: Remove an declaration for an unused function

Sep 4 2024, 7:23 AM · libassuan, MacOS, Bug Report
gniibe added a project to T7277: libgcrypt: Adding Known Answer Tests for KEM: libgcrypt.
Sep 4 2024, 7:13 AM · PQC, libgcrypt
gniibe added a comment to T7277: libgcrypt: Adding Known Answer Tests for KEM.

I re-consider. Adding arguments to existing gcry_kem_keypair is not good since it introduces API break.
Instead, I add gcry_kem_genkey with additional arguments (which can be used for deterministic key generation).

Sep 4 2024, 7:07 AM · PQC, libgcrypt
gniibe changed the status of T7283: Odd "gpg: KEYTOCARD failed: Invalid time" error when using `--pinentry-mode=loopback` from Open to Testing.
Sep 4 2024, 1:34 AM · gpgagent, Bug Report

Sep 3 2024

werner awarded T7283: Odd "gpg: KEYTOCARD failed: Invalid time" error when using `--pinentry-mode=loopback` a Pterodactyl token.
Sep 3 2024, 11:02 AM · gpgagent, Bug Report
gniibe committed rG4a4c1efac59f: agent: Fix KEYTOCARD for the use case with loopback pinentry. (authored by gniibe).
agent: Fix KEYTOCARD for the use case with loopback pinentry.
Sep 3 2024, 7:20 AM
gniibe claimed T7283: Odd "gpg: KEYTOCARD failed: Invalid time" error when using `--pinentry-mode=loopback`.

I can replicate the problem.

Sep 3 2024, 7:06 AM · gpgagent, Bug Report
gniibe closed T7121: gnupg 2.2.43: scdaemon fails with KDF as Resolved.
Sep 3 2024, 3:35 AM · gnupg22 (gnupg-2.2.44), yubikey, scd, Bug Report

Aug 30 2024

gniibe added a comment to T7277: libgcrypt: Adding Known Answer Tests for KEM.

I was confused. We already have KAT for decap in t-mlkem.c.

Aug 30 2024, 7:57 AM · PQC, libgcrypt

Aug 29 2024

gniibe added a comment to T7277: libgcrypt: Adding Known Answer Tests for KEM.
Aug 29 2024, 8:23 AM · PQC, libgcrypt
gniibe triaged T7277: libgcrypt: Adding Known Answer Tests for KEM as Normal priority.
Aug 29 2024, 8:18 AM · PQC, libgcrypt

Aug 27 2024

gniibe committed rCcc95c36e7f79: cipher:kyber: Apply changes from upstream for final FIPS 203. (authored by gniibe).
cipher:kyber: Apply changes from upstream for final FIPS 203.
Aug 27 2024, 7:54 AM
gniibe committed rEb79d4206f482: w32: Add GPGRT_PROCESS_ALLOW_SET_FG for gpgrt_process_spawn. (authored by gniibe).
w32: Add GPGRT_PROCESS_ALLOW_SET_FG for gpgrt_process_spawn.
Aug 27 2024, 6:34 AM

Aug 26 2024

gniibe claimed T7264: libgcrypt `tests/pkcs1v2` test fails in FIPS mode.

That's my badness.
I noticed by the CI at https://gitlab.com/redhat-crypto/libgcrypt/libgcrypt-mirror

Aug 26 2024, 10:17 AM · libgcrypt, Bug Report
gniibe committed rS8331f3723990: Update *.m4. (authored by gniibe).
Update *.m4.
Aug 26 2024, 10:00 AM
gniibe committed rCbfbddd64002d: Fix previous commit. (authored by gniibe).
Fix previous commit.
Aug 26 2024, 4:27 AM

Aug 22 2024

gniibe committed rCced3a39b29af: tests: More fixes for tests/pkcs1v2.c. (authored by gniibe).
tests: More fixes for tests/pkcs1v2.c.
Aug 22 2024, 2:25 AM
gniibe committed rC081e18a98f62: tests: Remove needless PKCS#1.5 encryption and decryption parameters. (authored by Jakuje).
tests: Remove needless PKCS#1.5 encryption and decryption parameters.
Aug 22 2024, 2:25 AM

Aug 21 2024

gniibe committed rC0e186b31d7bc: Fix memory leaks. (authored by gniibe).
Fix memory leaks.
Aug 21 2024, 8:42 AM

Jul 23 2024

gniibe committed rGdd23441938d1: agent: Avoid memory leak when handling ssh keys. (authored by Jakuje).
agent: Avoid memory leak when handling ssh keys.
Jul 23 2024, 2:32 AM
gniibe committed rGbe40a33419c8: agent: Avoid memory leak when handling tpm2. (authored by Jakuje).
agent: Avoid memory leak when handling tpm2.
Jul 23 2024, 2:32 AM
gniibe committed rG4bdd43fdca20: dotlock: Avoid leaking directory handle. (authored by Jakuje).
dotlock: Avoid leaking directory handle.
Jul 23 2024, 2:32 AM
gniibe committed rGb1029031d473: scd: Avoid memory leak. (authored by Jakuje).
scd: Avoid memory leak.
Jul 23 2024, 2:32 AM
gniibe committed rGf66e9356f892: export_secret_ssh_key: Avoid memory leak. (authored by Jakuje).
export_secret_ssh_key: Avoid memory leak.
Jul 23 2024, 2:32 AM
gniibe committed rGe8c8068decb3: tools: Avoid memory leaks. (authored by Jakuje).
tools: Avoid memory leaks.
Jul 23 2024, 2:32 AM

Jul 16 2024

gniibe claimed T7201: More memory leaks in gnupg.
Jul 16 2024, 8:58 AM · gnupg, Bug Report

Jul 12 2024

gniibe committed rGcc78b26a4729: common: Fix tlv-parser for constructed OCTET-STRING. (authored by gniibe).
common: Fix tlv-parser for constructed OCTET-STRING.
Jul 12 2024, 9:00 AM

Jul 11 2024

gniibe claimed T5924: libassuan: uses of socklen_t in assuan.h are inconsistent.
Jul 11 2024, 4:46 AM · libassuan
gniibe changed the status of T5924: libassuan: uses of socklen_t in assuan.h are inconsistent from Open to Testing.

The socklen_t use are now being fixed in newer POSIX Issue 8, 2024.
https://www.man7.org/linux/man-pages/man3/socklen_t.3type.html

Jul 11 2024, 4:45 AM · libassuan
gniibe committed rA69a703446b61: Use socklen_t for the length of socket address. (authored by gniibe).
Use socklen_t for the length of socket address.
Jul 11 2024, 4:43 AM
gniibe added a project to T5924: libassuan: uses of socklen_t in assuan.h are inconsistent: libassuan.
Jul 11 2024, 4:10 AM · libassuan
gniibe added a project to T5920: libassuan: Don't inherit handles for Windows: libassuan.
Jul 11 2024, 4:08 AM · libassuan
gniibe added a comment to T4945: Windows builds use "winepath" when it is available.

My summary here:

  • Use of winepath by libtool is correct way for semi-hosted environment to run tests built by cross-build.
  • (cross-)Build itself is possible with no winepath (or winepath -> /bin/false), if you don't need make check with semi-hosted environment.
  • I don't see that it's too slow, these days. My environment is bookworm Debian (having Wine 8.0 something).
Jul 11 2024, 3:59 AM · gpgrt
gniibe committed rAf89352ddc834: Update date of libassuan.m4. (authored by gniibe).
Update date of libassuan.m4.
Jul 11 2024, 3:14 AM
gniibe committed rAb8148b4f5735: Fix typo in assuan.h. (authored by gniibe).
Fix typo in assuan.h.
Jul 11 2024, 3:14 AM

Jul 10 2024

gniibe changed the status of T7195: gpgme regression (t-json) with GnuPG 2.5.0 from Open to Testing.

Fixed in: rG1e6b96577f68: gpg: Fix agent_probe_any_secret_key.

Jul 10 2024, 8:17 AM · gnupg, Bug Report
gniibe committed rG1e6b96577f68: gpg: Fix agent_probe_any_secret_key. (authored by gniibe).
gpg: Fix agent_probe_any_secret_key.
Jul 10 2024, 8:14 AM
gniibe claimed T7195: gpgme regression (t-json) with GnuPG 2.5.0.
Jul 10 2024, 8:12 AM · gnupg, Bug Report
gniibe created T7195: gpgme regression (t-json) with GnuPG 2.5.0.
Jul 10 2024, 8:12 AM · gnupg, Bug Report
gniibe committed rGd6017e4b1ed9: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Jul 10 2024, 3:24 AM

Jul 9 2024

gniibe committed rG2b19474aab8f: common: On Windows, we care about how PIPE handles are inherited. (authored by gniibe).
common: On Windows, we care about how PIPE handles are inherited.
Jul 9 2024, 8:49 AM
gniibe changed the status of T7193: gnupg-2.5.0: Does not build due to missing declaration of read and write from Open to Testing.

Thank you for your report.

Jul 9 2024, 3:52 AM · MacOS, gnupg, Bug Report
gniibe committed rG1d5cfa9b7fd2: scd: Add <unistd.h> for read(2) / write(2) . (authored by gniibe).
scd: Add <unistd.h> for read(2) / write(2) .
Jul 9 2024, 3:50 AM
gniibe changed the status of T7194: gnupg_ -> gpgrt_ : Pipe API from Open to Testing.

Pushed the change: rGaf6c47b2910f: common,kbx,tests: Clean up the PIPE function API.

Jul 9 2024, 3:44 AM · gpgrt, gnupg
gniibe committed rGaf6c47b2910f: common,kbx,tests: Clean up the PIPE function API. (authored by gniibe).
common,kbx,tests: Clean up the PIPE function API.
Jul 9 2024, 3:43 AM
gniibe triaged T7194: gnupg_ -> gpgrt_ : Pipe API as Normal priority.
Jul 9 2024, 3:25 AM · gpgrt, gnupg
gniibe changed the status of T7192: gnupg-2.5.0: Use gpgrt_process_spawn API (was: Does not build due to undeclared identifier 'environ') from Open to Testing.

Push the change: rG953dd67368ce: Use gpgrt_process_spawn API from libgpg-error.
Please test.

Jul 9 2024, 3:15 AM · gnupg, Bug Report
gniibe committed rG953dd67368ce: Use gpgrt_process_spawn API from libgpg-error. (authored by gniibe).
Use gpgrt_process_spawn API from libgpg-error.
Jul 9 2024, 3:15 AM
gniibe renamed T7192: gnupg-2.5.0: Use gpgrt_process_spawn API (was: Does not build due to undeclared identifier 'environ') from gnupg-2.5.0: Does not build due to undeclared identifier 'environ' to gnupg-2.5.0: Use gpgrt_process_spawn API (was: Does not build due to undeclared identifier 'environ').
Jul 9 2024, 3:14 AM · gnupg, Bug Report
gniibe claimed T7192: gnupg-2.5.0: Use gpgrt_process_spawn API (was: Does not build due to undeclared identifier 'environ').

Thank you for your report. We are about to migrate to use the gpgrt_spawn_process API.
(In our development history, it was originally implemented and tested as gnupg_spawn_process API and moved to libgpg-error.)

Jul 9 2024, 3:13 AM · gnupg, Bug Report

Jul 5 2024

gniibe committed rGcf3cec982d28: tpm2d: Fix key import. (authored by Jakuje).
tpm2d: Fix key import.
Jul 5 2024, 7:22 AM
gniibe changed the status of T7186: Fix tpm2d key import after recent changes from Open to Testing.
Jul 5 2024, 7:22 AM · gnupg, Bug Report
gniibe claimed T7186: Fix tpm2d key import after recent changes.

Thank you for the patch.

Jul 5 2024, 7:22 AM · gnupg, Bug Report
gniibe committed rMde6068450094: Fix printing size_t and off_t value for LLP64 Windows. (authored by gniibe).
Fix printing size_t and off_t value for LLP64 Windows.
Jul 5 2024, 6:54 AM
gniibe committed rM95bd4fa81302: Fix calling CancelSynchronousIo. (authored by gniibe).
Fix calling CancelSynchronousIo.
Jul 5 2024, 6:54 AM
gniibe triaged T7187: gpgme: Debug output for size_t and off_t as Normal priority.
Jul 5 2024, 6:49 AM · Windows 64, gpgme
gniibe committed rM8b4171680c32: Remove ath.h and ath.c. (authored by gniibe).
Remove ath.h and ath.c.
Jul 5 2024, 4:51 AM
gniibe committed rM9c276e762a25: Don't use ath_self, but get thread ID directly. (authored by gniibe).
Don't use ath_self, but get thread ID directly.
Jul 5 2024, 4:51 AM
gniibe claimed T7058: KDF-DO is not properly implemented.
Jul 5 2024, 2:40 AM · scd, gnupg, Bug Report

Jul 4 2024

gniibe committed rP7dc2d243fc50: m4: Update gpg-error.m4 and libassuan.m4. (authored by gniibe).
m4: Update gpg-error.m4 and libassuan.m4.
Jul 4 2024, 7:21 AM
gniibe committed rCb42116d6067a: cipher:blake2: Fix for use_avx512. (authored by gniibe).
cipher:blake2: Fix for use_avx512.
Jul 4 2024, 4:22 AM
gniibe changed the status of T7184: Libgcrypt v1.11.0 make fails at cipher/blake2.c:834:6 (has no member named 'use_avx512') from Open to Testing.
Jul 4 2024, 4:19 AM · libgcrypt, Bug Report
gniibe claimed T7184: Libgcrypt v1.11.0 make fails at cipher/blake2.c:834:6 (has no member named 'use_avx512').

Thank you for your report, good catch.
It's introduced by the commit: rC909daa700e4b: blake2: add AVX512 accelerated implementations
And the bug is there since then.

Jul 4 2024, 4:16 AM · libgcrypt, Bug Report
gniibe added a parent task for T7138: Windows (Semi-hosted environment): filename and network access: T6508: Port GnuPG to 64-bit Windows.
Jul 4 2024, 4:09 AM · gnupg, Bug Report
gniibe added a subtask for T6508: Port GnuPG to 64-bit Windows: T7138: Windows (Semi-hosted environment): filename and network access.
Jul 4 2024, 4:09 AM · Windows 64, Feature Request, gnupg26

Jul 2 2024

gniibe committed rC8b898670e915: cipher:kyber: Use ct_int16_select of libgcrypt . (authored by gniibe).
cipher:kyber: Use ct_int16_select of libgcrypt .
Jul 2 2024, 3:59 AM
gniibe committed rCf765778e82b3: cipher:kyber: Apply a change from upstream. (authored by gniibe).
cipher:kyber: Apply a change from upstream.
Jul 2 2024, 3:59 AM