I guess it's now ready for testing
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Nov 13 2024
Nov 13 2024
• ikloecker changed the status of T7331: Kleopatra: Improvements for debug dialog from Open to Testing.
All changes have been backported for VSD 3.3
• ikloecker committed rKLEOPATRA7cb2e48844fa: Make sure debug dialog commands are run only once when pressing Enter (authored by • TobiasFella).
Make sure debug dialog commands are run only once when pressing Enter
• ikloecker moved T7388: Kleopatra: missing German translations in kf5 from Backlog to WiP on the vsd33 board.
I added this to gpg4win master. I assume that this branch will be used for VSD 3.3 and Gpg4win 4.4.
• ikloecker changed the status of T7388: Kleopatra: missing German translations in kf5 from Open to Testing.
All missing translations mentioned in the original description should now be there (once a new kleopatra snapshot is created).
• ikloecker committed rW599dd32a4850: Add messages that were moved from kleopatra to libkleo (authored by • ikloecker).
Add messages that were moved from kleopatra to libkleo
• ikloecker added a comment to T7391: dev.gnupg.org: Font 'Segoe UI Emoji' causes huge word-spacing.
That's a bug in Firefox. Chromium doesn't exhibit the problem. I have problems with fonts in Firefox on many different websites.
Forget the explanation. msgcat --use-first works correctly. We didn't use it correctly for our purposes. msgcat --use-first took the first translation of the context-less messages. This happened to be marked-as-obsolete messages in the main po file (because KDE keeps obsolete messages for easier recovery). And since they were marked as obsolete they were dropped when the po file were compiled. The script now removes obsolete messages before merging in additional po files. This way non-obsolete messages in the additional po files don't get shadowed anymore by obsolete messages in the main po files.
• ikloecker committed rWf2f33ee93777: Don't clone the whole history if we need just the tip of a single branch (authored by • ikloecker).
Don't clone the whole history if we need just the tip of a single branch
Improve merging of translations
Fix two translations
Nov 12 2024
Nov 12 2024
Andre's comment was "Use use first to avoid double translations that confuse it.".
I have removed the --use-first from the msgcat command that merges the combined messages from KDE's svn and the po file in our repo with the local l10n files for libkleo and kleopatra in gpg4win/packages.
• ikloecker committed rW5660de6ab657: Merge local translations instead of keeping only the first one (authored by • ikloecker).
Merge local translations instead of keeping only the first one
• ikloecker committed rW10782262e242: Remove names and emails of translators to avoid fuzzy messages (authored by • ikloecker).
Remove names and emails of translators to avoid fuzzy messages
The problem seems to be that the msgcat commands in gen-tarball.sh (gpg4win repo) are used with --use-first and that seems to ignore msgctxt when looking for duplicate msgids.
- "GnuPG VS-Desktop Audit Log Viewer" (nur Fenstertitel unübersetzt)
- "Valid until (between %1 and %2):" (Schlüsselgenerierung, Erweiterte Einstellungen)
- Unter Extras -> Zwischenablage: 4 von 5 Unterpunkten nicht übersetzt
- Lookup on server (nur im Fenstertitel unübersetzt)
- "Publish on keyserver afterwards" (im Fenster Beglaubigung)
- "Enter a message to encrypt or decrypt…" Notepad-Placeholdertext
• ikloecker changed the status of T7365: Kleopatra: Error on key generation after using the "Retry" button from Open to Testing.
Should be ready for testing
• ikloecker moved T7365: Kleopatra: Error on key generation after using the "Retry" button from Backlog to WiP on the vsd33 board.
Backported for VSD 3.3
• ikloecker committed rKLEOPATRAc4efaab89610: Fix setting curve in certificate creation dialog (authored by • ikloecker).
Fix setting curve in certificate creation dialog
Fix wrong function calls
• ikloecker added a project to T7365: Kleopatra: Error on key generation after using the "Retry" button: vsd33.
This bugfix shall be backported for VSD 3.3 as discussed with ebo
• ikloecker committed rKLEOPATRAf04880ea5923: Add Qt 6 compatibility include to make the backport compile (authored by • ikloecker).
Add Qt 6 compatibility include to make the backport compile
• ikloecker moved T7296: Kleopatra: Change filters "All certificates" etc. so that they do not include disabled ones from Backlog to WiP on the vsd33 board.
Latest changes backported for VSD 3.3
• ikloecker committed rKLEOPATRA0ff7b2f6d7bf: Update tooltip for "Disable Certificate" action to reflect current behavior (authored by • TobiasFella).
Update tooltip for "Disable Certificate" action to reflect current behavior
• ikloecker committed rKLEOPATRAdd308e814d1d: Fix crash in debug dialog (authored by • TobiasFella).
Fix crash in debug dialog
• ikloecker committed rKLEOPATRA0ae32b1f49db: Close standard input for debug commands (authored by • TobiasFella).
Close standard input for debug commands
• ikloecker moved T7234: Kleopatra: add disable/enable certificate in context menu from Backlog to WiP on the vsd33 board.
Backported for VSD 3.3
• ikloecker committed rLIBKLEOb7b0df3f414a: Split "My Certificates" filter into separate filtering and appearance filters (authored by • TobiasFella).
Split "My Certificates" filter into separate filtering and appearance filters
• ikloecker moved T6567: Kleopatra: gpg-agent does not restart when trying to access smart card from Backlog to WiP on the vsd33 board.
And backported for VSD 3.3.
• ikloecker changed the status of T6567: Kleopatra: gpg-agent does not restart when trying to access smart card from Open to Testing.
Fixed.
• ikloecker committed rLIBKLEO541725ca3f5a: Use synchronous QProcess API to start gpg-agent without event loop (authored by • ikloecker).
Use synchronous QProcess API to start gpg-agent without event loop
• ikloecker committed rLIBKLEO2520ae86cddc: Use synchronous QProcess API to start gpg-agent without event loop (authored by • ikloecker).
Use synchronous QProcess API to start gpg-agent without event loop
Add context to some connects
• ikloecker committed rLIBKLEO3e4a6da08909: Use synchronous QProcess API to start gpg-agent without event loop (authored by • ikloecker).
Use synchronous QProcess API to start gpg-agent without event loop
Nov 11 2024
Nov 11 2024
Fix gpgme++ includes
The QProcesses we start should be configured with closed stdin so that the started process don't hang waiting for input, e.g. by calling closeWriteChannel() immediately after start(). Or by calling start() with QIODeviceBase::ReadOnly, but, sadly, the documentation of QProcess doesn't document what effect that has.
Nov 8 2024
Nov 8 2024
• ikloecker added a comment to T7296: Kleopatra: Change filters "All certificates" etc. so that they do not include disabled ones.
We shouldn't have to add explicit line breaks. Explicit line breaks will lead to bad formatting (German: Flattersatz) for people who use huge font sizes (a11y!) and Qt will wrap long tool tips so that they won't become wider than the screen. Alternatively, we wrap the tool tips (in the code that sets the tool tips) into <html> tags. Then (for whatever reason) Qt will make the tool tips much narrower. (Some people think too narrow, but we have to die one death.)
Nov 7 2024
Nov 7 2024
You mean that a disabled certificate with secret key isn't listed with bold font? That's probably because we have an appearance filter for disabled certificates which takes precedence.
• ikloecker added a comment to T7217: Kleopatra: Create an appearance filter for the "disabled" status.
I agree that it doesn't make sense anymore because we never show disabled and not-disabled certificates next to each other.
• ikloecker moved T7302: Kleopatra: Add tooltips for certificate filters from Restricted Project Column to Restricted Project Column on the Restricted Project board.
I have updated the translations of the filters defined in the libkleopatrarc*.desktop files.
• ikloecker committed rLIBKLEOcf2adbc6f314: Update translations in libkleopatrarc*.desktop files (authored by • ikloecker).
Update translations in libkleopatrarc*.desktop files
• ikloecker added a comment to T7379: Kleopatra: Learning certificates of Signature v2.0 card fails if a Yubikey is plugged in as well.
I assume by "do such things in the background" you mean that GnuPG should do this automatically in the background.
Nov 6 2024
Nov 6 2024
• ikloecker committed rLIBKLEO814cbe274209: Avoid test failure because of different date/time text representation (authored by • ikloecker).
Avoid test failure because of different date/time text representation
• ikloecker committed rLIBKLEO5b3ec222acf1: Avoid test failure because of different date/time text representation (authored by • ikloecker).
Avoid test failure because of different date/time text representation
Skip test on Windows
• ikloecker committed rLIBKLEO72a78f82174c: Avoid test failure because of different date/time text representation (authored by • ikloecker).
Avoid test failure because of different date/time text representation
Skip test on Windows
Add missing include
• ikloecker committed rLIBKLEO4773e3df0ce0: Add destructor to fix compiler complaints about incomplete type Private (authored by • ikloecker).
Add destructor to fix compiler complaints about incomplete type Private
Enable Windows CI
I cannot reproduce the crash anymore. I guess this was fixed with the fix of T7372: Kleopatra: Crash when unplugging smartcard while operation is in progress. I'll close this ticket as duplicate of T7372.
@ebo I suspect that we want to fix this crash also for VSD 3.3 (if it is still reproducible). I found this ticket by accident while searching for READKEY.
• ikloecker added a comment to T7379: Kleopatra: Learning certificates of Signature v2.0 card fails if a Yubikey is plugged in as well.
I haven't added any project tags because I'm not sure for which projects this is relevant. Since GnuPG 2.2 doesn't support multiple smartcards it's likely not relevant for VSD 3.3.
• ikloecker updated subscribers of T7378: Kleopatra: loading X.509 certificate from Signature card hangs.
@gniibe It seems that a keylisting (with gpg and gpgsm) interferes with a READKEY --card --no-data -- NKS-NKS3.4571 gpg-agent command and makes it hang until scdaemon is killed.
• ikloecker added a comment to T7378: Kleopatra: loading X.509 certificate from Signature card hangs.
It looks as if a keylisting interfered with a gpg-agent/scdaemon command.
48458.670390 2024/11/06 12:43:04.238 5772 kleopatra.exe org.kde.pim.kleopatra: ReaderStatusThread[GUI]::ping()
^ update of the smart cards is requested
48458.670695 2024/11/06 12:43:04.238 5772 kleopatra.exe org.kde.pim.kleopatra: ReaderStatusThread[2nd]: new iteration command= "__update__" ; nullSlot= true
^ background thread starts update of the smart cards
48459.147743 2024/11/06 12:43:04.728 5772 kleopatra.exe org.kde.pim.kleopatra: ReaderStatusThread[GUI]::ping()
^ another update of the smart cards is requested (the request is queued)
48464.804883 2024/11/06 12:43:10.393 5772 kleopatra.exe org.kde.pim.kleopatra: ReaderStatusThread: Card "89490171500022806460" with app "nks" was added 48464.805095 2024/11/06 12:43:10.393 5772 kleopatra.exe org.kde.pim.kleopatra: ReaderStatusThread: Card "D2760001240100000006154932910000" with app "openpgp" was added 48464.807483 2024/11/06 12:43:10.393 5772 kleopatra.exe org.kde.pim.kleopatra: ReaderStatusThread: Card "D2760001240100000006154932910000" with app "piv" was added
^ the background thread completed the update of the smart cards and found three card apps
48464.811286 2024/11/06 12:43:10.393 5772 kleopatra.exe org.kde.pim.kleopatra: ReaderStatusThread[2nd]: new iteration command= "__update__" ; nullSlot= true
^ background thread starts another update of the smart cards
48464.924701 2024/11/06 12:43:10.492 5772 kleopatra.exe org.kde.pim.kleopatra: ReaderStatusThread[GUI]::learnCardsCMS()
^ learn cards is requested (and queued) -> Kleopatra shows the progress overlay
48465.796319 2024/11/06 12:43:11.291 5772 kleopatra.exe org.kde.pim.libkleo: KeyCache::RefreshKeysJob start
^ a keylisting is started (OpenPGP and S/MIME)
48467.549251 2024/11/06 12:43:12.874 5772 kleopatra.exe org.kde.pim.libkleo: sendStatusLinesCommand "SCD LEARN --force" : got ( status( "READER" ) = "SCM Microsystems Inc. SPRx32 USB Smart Card Reader 0" [...] 48467.550423 2024/11/06 12:43:12.875 5772 kleopatra.exe org.kde.pim.libkleo: sendCommand "READKEY --card --no-data -- NKS-NKS3.4531" 48467.895485 2024/11/06 12:43:13.187 5772 kleopatra.exe org.kde.pim.libkleo: sendStatusLinesCommand "READKEY --card --no-data -- NKS-NKS3.4531" : got ( ) 48467.896400 2024/11/06 12:43:13.188 5772 kleopatra.exe org.kde.pim.libkleo: sendCommand "READKEY --card --no-data -- NKS-NKS3.45B1" 48468.209551 2024/11/06 12:43:13.471 5772 kleopatra.exe org.kde.pim.libkleo: sendStatusLinesCommand "READKEY --card --no-data -- NKS-NKS3.45B1" : got ( ) 48468.209660 2024/11/06 12:43:13.471 5772 kleopatra.exe org.kde.pim.libkleo: sendCommand "READKEY --card --no-data -- NKS-NKS3.4571"
^ the background thread sends multiple commands to gpg-agent to gather information about the smart cards
^ the last READKEY command seems to hang
48468.598283 2024/11/06 12:43:13.822 5772 kleopatra.exe org.kde.pim.libkleo: Kleo::KeyCache::RefreshKeysJob(0x63ccba8) RefreshKeysJob::done
^ the keylisting is done
• ikloecker moved T6091: Kleopatra: "Cancel" in the password dialog of "Print secret key" has no effect from Backlog to WiP on the vsd33 board.
Backported for VSD 3.3
• ikloecker moved T6091: Kleopatra: "Cancel" in the password dialog of "Print secret key" has no effect from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Canceling the password prompt is now handled correctly, i.e. the operation is aborted without further feedback.
• ikloecker committed rKLEOPATRAef22a58c8ca8: Treat empty result without error as canceled secret key export job (authored by • ikloecker).
Treat empty result without error as canceled secret key export job
• ikloecker committed rKLEOPATRA8583338db342: Properly terminate the command if an error occurred (authored by • ikloecker).
Properly terminate the command if an error occurred
• ikloecker committed rKLEOPATRAf3866184e841: Treat empty result without error as canceled secret key export job (authored by • ikloecker).
Treat empty result without error as canceled secret key export job
Retry window ci support
• ikloecker changed the status of T7375: Kleopatra: Print secret key operation is not terminated correctly if an empty or wrong password is entered from Open to Testing.
• ikloecker committed rKLEOPATRA1f93efce717a: Make the finished and canceled signals private (authored by • ikloecker).
Make the finished and canceled signals private
• ikloecker committed rKLEOPATRA7834f866078e: Don't emit finished signal twice (authored by • ikloecker).
Don't emit finished signal twice
Fix wrong function calls
• ikloecker committed rKLEOPATRA9174be03b797: Call private canceled function instead of duplicating its code (authored by • ikloecker).
Call private canceled function instead of duplicating its code
• ikloecker committed rKLEOPATRA73e58e3d3487: Properly terminate the command if an error occurred (authored by • ikloecker).
Properly terminate the command if an error occurred
• ikloecker committed rKLEOPATRA0eb4152941e2: Rename variable that shadows the canceled method (authored by • ikloecker).
Rename variable that shadows the canceled method
• ikloecker raised the priority of T7373: gpg --export-secret-keys exits with General error if the password prompt was canceled from Low to Needs Triage.
Nov 5 2024
Nov 5 2024
• ikloecker moved T6091: Kleopatra: "Cancel" in the password dialog of "Print secret key" has no effect from WiP to Backlog on the vsd33 board.
• ikloecker moved T6091: Kleopatra: "Cancel" in the password dialog of "Print secret key" has no effect from Restricted Project Column to Restricted Project Column on the Restricted Project board.
This has also been reported at https://bugs.kde.org/show_bug.cgi?id=477798 (although there a crash occurs). Porting the command to gpgme didn't help, but the remaining problems are in gpg and/or gpgme.
• ikloecker triaged T7374: gpgme: The export operation seems to ignore failures reported by gpg as Low priority.
• ikloecker triaged T7373: gpg --export-secret-keys exits with General error if the password prompt was canceled as Low priority.
• ikloecker added a reverting change for rGTO30b5736a97d8: Remove codec changes: rGTO1f60c6800946: Revert "Remove codec changes" for Qt 5 builds.
• ikloecker committed rGTO1f60c6800946: Revert "Remove codec changes" for Qt 5 builds (authored by • ikloecker).
Revert "Remove codec changes" for Qt 5 builds
• ikloecker committed rGTO9936fcec4cd2: Revert "Don't set codec for QSettings" for Qt 5 builds (authored by • ikloecker).
Revert "Don't set codec for QSettings" for Qt 5 builds
• ikloecker added a reverting change for rGTO7dfcb5f55692: Don't set codec for QSettings: rGTO9936fcec4cd2: Revert "Don't set codec for QSettings" for Qt 5 builds.
This problem was also reported at https://bugs.kde.org/show_bug.cgi?id=479567#c1
• ikloecker changed the status of T7372: Kleopatra: Crash when unplugging smartcard while operation is in progress from Open to Testing.
Fixed and backported for VSD 3.3
• ikloecker committed rKLEOPATRA9ae1931f3f32: Don't crash if there is no current smartcard widget (anymore) (authored by • ikloecker).
Don't crash if there is no current smartcard widget (anymore)
• ikloecker committed rKLEOPATRA3f1f8770b78a: Don't crash if there is no current smartcard widget (anymore) (authored by • ikloecker).
Don't crash if there is no current smartcard widget (anymore)
I'm now using the name "Compliance Check" for the test if no compliance is active/has been configured. I have also checked all other usages of DeVSCompliance::name() in libkleo and kleopatra to make sure it's only used if compliance is active.
• ikloecker committed rKLEOPATRA432f6bf61839: Use generic name for compliance check if no compliance is active (authored by • ikloecker).
Use generic name for compliance check if no compliance is active
• ikloecker changed the status of T7310: GpgOL: Broken Umlauts in progress message (unicode, encoding) from Open to Testing.
I have reverted the commit mentioned by Carl and another text codec related commit for the Qt 5 builds. This will hopefully fix the broken umlauts in the progress messages.
Fixed and backported for VSD 3.3
• ikloecker committed rLIBKLEO1545c48024fe: Avoid crash on program exit on Windows (authored by • ikloecker).
Avoid crash on program exit on Windows
• ikloecker moved T7364: Kleopatra: Crash on Quit from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ikloecker committed rLIBKLEOd19a1f372ed1: Avoid crash on program exit on Windows (authored by • ikloecker).
Avoid crash on program exit on Windows
Nov 4 2024
Nov 4 2024
Looking at the Windows "Problem reports" I saw that it lists many crashes of Kleopatra since 2024-06-19. An older Kleopatra (gpg4win-4.3.2-beta15, built on 2024-04-16) does not crash on exit. The next Kleopatra (gpg4win-4.3.2-beta23, built on 2024-07-05) does crash on exit. The reports point to the libkleo DLL.