Page MenuHome GnuPG
Feed All Stories

May 13 2019

werner added a comment to T4504: Asan findings in iconv configure test causing config failure.

We update condig.{guess,sub} only when needed. In the past we had cases with regressions on some rare platforms.

May 13 2019, 8:49 AM · gpgrt, gnupg
gniibe claimed T4397: GPG Error - version >= 1.25... no.

It is because you don't have ${prefix}/bin in your PATH.
Please build having /var/tmp/bin in your PATH.

May 13 2019, 8:35 AM · gpgrt, Bug Report
gniibe added a project to T4504: Asan findings in iconv configure test causing config failure: gpgrt.
May 13 2019, 8:17 AM · gpgrt, gnupg
gniibe committed rG1cd2aca03b88: build: Update m4/iconv.m4. (authored by gniibe).
build: Update m4/iconv.m4.
May 13 2019, 8:17 AM
JW added a comment to T4504: Asan findings in iconv configure test causing config failure.

I'm going to bring newest m4/iconv.m4 from original (gettext), which apparently fixed file descriptor leaks.

May 13 2019, 8:08 AM · gpgrt, gnupg
gniibe claimed T4504: Asan findings in iconv configure test causing config failure.

Thanks for your report.

May 13 2019, 8:05 AM · gpgrt, gnupg
JW added a comment to T4504: Asan findings in iconv configure test causing config failure.

An FYI... Once we cleared the earlier findings GnuPG tested OK under Asan. GnuPG itself had no findings, and it did not cause any dependent libraries to generate findings.

May 13 2019, 7:20 AM · gpgrt, gnupg

May 12 2019

werner committed rG8d0d61aca3d2: sm: Fix a warning in an es_fopencooie function. (authored by werner).
sm: Fix a warning in an es_fopencooie function.
May 12 2019, 8:43 PM
werner triaged T4495: UBsan finding "certdump.c:695:3: runtime error: null pointer passed as argument 2" as Normal priority.

Thanks for the tests. I just fixed this one and will do replace some code in master, soon.

May 12 2019, 8:43 PM · gnupg
werner triaged T4502: keys added via gpg-agent's ssh-agent interface are stored in private-keys-v1.d/ with a trailing null byte as Normal priority.

I often put an extra nul byte at the end of binary data so that accidental printing the data (e.g. in gdb) assures that there is a string terminator. But right, it should not go out to a file.

May 12 2019, 8:16 PM · gpgagent, ssh
jukivili added a comment to T4499: Asan finding in libgcrypt.

That type of variadic macro is GCC extension, see https://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html

May 12 2019, 6:45 PM · libgcrypt
JW added a comment to T4504: Asan findings in iconv configure test causing config failure.

This patch tested OK.

May 12 2019, 11:44 AM · gpgrt, gnupg
JW created T4504: Asan findings in iconv configure test causing config failure in the S1 Public space.
May 12 2019, 10:26 AM · gpgrt, gnupg
kaspro added a comment to T4301: Handling multiple subkeys on two SmartCards.

Hello again - can I ask about the status? Or should I consider this as a no-fix? Anything I can assist with?

May 12 2019, 7:56 AM · Restricted Project, gnupg, scd, Bug Report
JW added a comment to T4499: Asan finding in libgcrypt.

The second and third arguments passed to xgcry_control seem to be lost when calling gcry_control.

May 12 2019, 7:16 AM · libgcrypt
dkg created T4503: include extension for OpenPGP creation timestamp in X.509 output.
May 12 2019, 1:01 AM · Feature Request, S/MIME
JW added a comment to T4499: Asan finding in libgcrypt.

Here are the next two failures I am seeing while testing libgrcypt. It appears to be related to GCRYCTL_INIT_SECMEM.

May 12 2019, 12:44 AM · libgcrypt
dkg created T4502: keys added via gpg-agent's ssh-agent interface are stored in private-keys-v1.d/ with a trailing null byte.
May 12 2019, 12:37 AM · gpgagent, ssh

May 11 2019

JW added a comment to T4499: Asan finding in libgcrypt.

I'm still seeing a few odd outputs from make check, but I have not investigated them yet.

May 11 2019, 10:50 PM · libgcrypt
JW added a comment to T4499: Asan finding in libgcrypt.

Maybe cleaner option for mpi/mpiutil.c would be to statically allocate the constants

May 11 2019, 9:14 PM · libgcrypt
jukivili added a comment to T4499: Asan finding in libgcrypt.

Maybe cleaner option for mpi/mpiutil.c would be to statically allocate the constants

May 11 2019, 1:27 PM · libgcrypt
JW added a comment to T4499: Asan finding in libgcrypt.

Here's a couple of awful hacks that get me through make check. Feel free to restate how awful they are; I know it is a bad thing to do.

May 11 2019, 7:24 AM · libgcrypt
dkg added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.


here is a copy of another example generated key (not b64-encoded), if you want to just download it.

May 11 2019, 4:24 AM · gnupg (gpg22), Bug Report
dkg added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.

I also did a base64 < "$GNUPGHOME/private-keys-v1.d/".key at the end of a different run of that script, and it produced this output, if you'd like to inspect the actual S-expression stored:

May 11 2019, 4:21 AM · gnupg (gpg22), Bug Report
dkg added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.

I ran the example script from T4490 on an s390x machine, and got the following output:

May 11 2019, 4:16 AM · gnupg (gpg22), Bug Report
dkg updated the task description for T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.
May 11 2019, 12:37 AM · gnupg (gpg22), Bug Report
dkg set Version to 2.2.13 on T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.
May 11 2019, 12:36 AM · gnupg (gpg22), Bug Report
dkg added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.

This might be related to T4490, since it's the same sort of key generation process.

May 11 2019, 12:36 AM · gnupg (gpg22), Bug Report
dkg created T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.
May 11 2019, 12:33 AM · gnupg (gpg22), Bug Report

May 10 2019

pa_am created T4500: Option --use-embedded-filename does not work as expect.
May 10 2019, 11:51 PM · gnupg (gpg22), Bug Report
JW updated the task description for T4499: Asan finding in libgcrypt.
May 10 2019, 11:44 PM · libgcrypt
JW created T4499: Asan finding in libgcrypt in the S1 Public space.
May 10 2019, 11:43 PM · libgcrypt
JW created T4498: Asan findings in tests/t-logging.c in the S1 Public space.
May 10 2019, 11:34 PM · gpgrt
dkg created T4497: gpgconf should report clearer errors when it knows that a given daemon's config file is bad.
May 10 2019, 11:24 PM · gnupg (gpg22)
dkg added a comment to T4490: --export-secret-keys fails with unusually-created secret key.

I was trying to use the above technique to be able to generate an OpenPGP transferable secret key in an ephemeral homedir. Ephemeral directories are recommended in the GnuPG info page's "unattended usage" section, but they do not work here.

May 10 2019, 10:45 PM · ssh, gnupg (gpg22)
jukivili committed rC34e9306a66b4: tests/basic: mark CFB and CFB8 as stream block cipher modes (authored by jukivili).
tests/basic: mark CFB and CFB8 as stream block cipher modes
May 10 2019, 10:44 PM
jukivili committed rC15592cd52f54: Fix message digest final function for MD4, MD5 and RMD160 (authored by jukivili).
Fix message digest final function for MD4, MD5 and RMD160
May 10 2019, 10:44 PM
JW added a comment to T4495: UBsan finding "certdump.c:695:3: runtime error: null pointer passed as argument 2".

It looks like this patch clears this finding:

May 10 2019, 9:26 PM · gnupg
dkg created T4496: gpgconf --launch ignores --homedir arguments.
May 10 2019, 9:25 PM · Bug Report, gnupg (gpg22)
JW created T4495: UBsan finding "certdump.c:695:3: runtime error: null pointer passed as argument 2" in the S1 Public space.
May 10 2019, 9:24 PM · gnupg
JW added a comment to T4494: UBsan finding "armor.c:1159:11: runtime error: member access within null pointer...".

It looks like this patch clears this finding:

May 10 2019, 9:07 PM · gnupg
JW created T4494: UBsan finding "armor.c:1159:11: runtime error: member access within null pointer..." in the S1 Public space.
May 10 2019, 8:31 PM · gnupg
werner triaged T4493: Default to HKPS, not HKP as Normal priority.
May 10 2019, 7:23 PM · dirmngr, Feature Request
dkg committed rGbe116f871dbf: doc: correct documentation for gpgconf --kill (authored by dkg).
doc: correct documentation for gpgconf --kill
May 10 2019, 6:43 PM
dkg committed rG9662538be6af: doc: correct documentation for gpgconf --kill (authored by dkg).
doc: correct documentation for gpgconf --kill
May 10 2019, 6:42 PM
Laurent Montel <montel@kde.org> committed rKLEOPATRA05c0757d8038: Remove deprecated method qVariantFromValue->QVariant::fromValue (authored by Laurent Montel <montel@kde.org>).
Remove deprecated method qVariantFromValue->QVariant::fromValue
May 10 2019, 2:17 PM
Valodim created T4493: Default to HKPS, not HKP.
May 10 2019, 2:13 PM · dirmngr, Feature Request
werner triaged T4490: --export-secret-keys fails with unusually-created secret key as Normal priority.
May 10 2019, 10:20 AM · ssh, gnupg (gpg22)
werner triaged T4491: Compile error in nPth's t-fork.c on Solaris 11.3 i86pc as Normal priority.
May 10 2019, 10:17 AM · npth, Bug Report
werner renamed T4491: Compile error in nPth's t-fork.c on Solaris 11.3 i86pc from Compile error in Nth t-fork.c on Solaris 11.3 i86pc to Compile error in nPth's t-fork.c on Solaris 11.3 i86pc.
May 10 2019, 10:16 AM · npth, Bug Report
werner closed T4492: Gawk 5.0 and warning: regexp escape sequence `\#' is not a known regexp operator as Resolved.

We fixed this bug already in the repo. See T4459.

May 10 2019, 10:13 AM · Duplicate, gnupg
JW added a comment to T4491: Compile error in nPth's t-fork.c on Solaris 11.3 i86pc.

It looks like Solaris only needs CFLAGS+=-std=c99. It was added for all programs and libraries listed at https://www.gnupg.org/download/index.html.

May 10 2019, 9:06 AM · npth, Bug Report
JW updated the task description for T4492: Gawk 5.0 and warning: regexp escape sequence `\#' is not a known regexp operator.
May 10 2019, 8:48 AM · Duplicate, gnupg
JW created T4492: Gawk 5.0 and warning: regexp escape sequence `\#' is not a known regexp operator in the S1 Public space.
May 10 2019, 8:46 AM · Duplicate, gnupg
JW created T4491: Compile error in nPth's t-fork.c on Solaris 11.3 i86pc.
May 10 2019, 8:01 AM · npth, Bug Report
dkg created T4490: --export-secret-keys fails with unusually-created secret key.
May 10 2019, 6:28 AM · ssh, gnupg (gpg22)

May 9 2019

matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

It appears this issue was first identified and triaged in 2016: T2879
The subkey deletion feature also showed up in other issues since then:

May 9 2019, 9:14 PM · patch, Bug Report, gnupg
werner committed rG7c4029110ab4: dirmngr: Add a CSRF expection for pm.me (authored by werner).
dirmngr: Add a CSRF expection for pm.me
May 9 2019, 2:52 PM
werner committed rG7098e4ce198d: dirmngr: Add a CSRF expection for pm.me (authored by werner).
dirmngr: Add a CSRF expection for pm.me
May 9 2019, 2:51 PM
werner committed rGe6901c2bc802: build: Sign all Windows binaries. (authored by werner).
build: Sign all Windows binaries.
May 9 2019, 2:40 PM
Laurent Montel <montel@kde.org> committed rLIBKLEOae82de5a0fe7: GIT_SILENT: Prepare 5.11.2 (authored by Laurent Montel <montel@kde.org>).
GIT_SILENT: Prepare 5.11.2
May 9 2019, 2:08 PM
werner triaged T4488: dirmngr: allow changing `use-tor` in a reload as Normal priority.
May 9 2019, 8:10 AM · gnupg (gpg23), dirmngr
werner triaged T4489: gpg --quick-add-key should be able to add an existing key as a subkey, not just generating a new one as Normal priority.
May 9 2019, 8:09 AM · gnupg, OpenPGP, Feature Request
dkg added a comment to T4489: gpg --quick-add-key should be able to add an existing key as a subkey, not just generating a new one.

i'm thinking that if the algo parameter to --quick-add-key is a keygrip, then it would find the key directly in the existing keyring(s) and attach it as a new subkey.

May 9 2019, 12:15 AM · gnupg, OpenPGP, Feature Request
dkg created T4489: gpg --quick-add-key should be able to add an existing key as a subkey, not just generating a new one.
May 9 2019, 12:14 AM · gnupg, OpenPGP, Feature Request

May 8 2019

matheusmoreira added revisions to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested): D487: gpg: don't delete any keys if --dry-run is passed, D488: gpg: add the --delete-secret-key-stubs command, D489: po: add portuguese translation for the new command.
May 8 2019, 11:59 PM · patch, Bug Report, gnupg
matheusmoreira added a task to D489: po: add portuguese translation for the new command: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
May 8 2019, 11:59 PM
matheusmoreira added a task to D488: gpg: add the --delete-secret-key-stubs command: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
May 8 2019, 11:59 PM
matheusmoreira added a task to D487: gpg: don't delete any keys if --dry-run is passed: T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
May 8 2019, 11:59 PM
matheusmoreira retitled D489: po: add portuguese translation for the new command from po: add portuguese translation for the new to po: add portuguese translation for the new command.
May 8 2019, 11:58 PM
matheusmoreira created D489: po: add portuguese translation for the new command.
May 8 2019, 11:56 PM
matheusmoreira created D488: gpg: add the --delete-secret-key-stubs command.
May 8 2019, 11:53 PM
matheusmoreira created D487: gpg: don't delete any keys if --dry-run is passed.
May 8 2019, 11:48 PM
aheinecke added a comment to T4487: libksba: please refresh ASN.1 components from more recent RFCs with BSD licensing.

Thanks for the explanation.

May 8 2019, 3:14 PM · libksba, Feature Request
dkg created T4488: dirmngr: allow changing `use-tor` in a reload.
May 8 2019, 1:57 PM · gnupg (gpg23), dirmngr
dkg reopened T4487: libksba: please refresh ASN.1 components from more recent RFCs with BSD licensing as "Open".

If the ASN.1 is not from an RFC, then the AUTHORS file should not claim that it is from an RFC.

May 8 2019, 1:42 PM · libksba, Feature Request
aheinecke added a comment to T4427: Windows 10 update KB4489899 stops gpg-agent launching.

As this update lists multiple issues and following fixes for them, maybe it was resolved by Microsoft?

May 8 2019, 10:46 AM · Info Needed, Windows, gpgagent, Bug Report
werner committed rD35887801da27: web: Minor change to the g10 Code entry in service listing. (authored by werner).
web: Minor change to the g10 Code entry in service listing.
May 8 2019, 9:37 AM
aheinecke committed rW5170b9d1b961: Add korean translation (authored by aheinecke).
Add korean translation
May 8 2019, 9:11 AM
aheinecke committed rW1702a47f4b32: Merge branch 'master' into nsis-3 (authored by aheinecke).
Merge branch 'master' into nsis-3
May 8 2019, 9:11 AM
aheinecke committed rW29d323fd9628: Update kleo, gpgol, gpg4win-tools, libkleo (authored by aheinecke).
Update kleo, gpgol, gpg4win-tools, libkleo
May 8 2019, 9:11 AM
werner triaged T4427: Windows 10 update KB4489899 stops gpg-agent launching as High priority.
May 8 2019, 8:54 AM · Info Needed, Windows, gpgagent, Bug Report
aheinecke committed rO49e6658e0946: Update german translation (authored by aheinecke).
Update german translation
May 8 2019, 8:25 AM
aheinecke committed rOd22e616de39b: Auto update po files (authored by aheinecke).
Auto update po files
May 8 2019, 8:25 AM
matheusmoreira added a project to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested): patch.
May 8 2019, 1:08 AM · patch, Bug Report, gnupg
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

Diffs downloaded from the revisions don't include commit messages for some reason. Here are all the commits I submitted for review as patch files with messages:

May 8 2019, 12:51 AM · patch, Bug Report, gnupg

May 7 2019

dkg added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).

@werner could you review the patches posted here by @matheusmoreira ? This looks concretely useful, and i would like to have this fixed.

May 7 2019, 11:16 PM · patch, Bug Report, gnupg
jukivili updated the task description for T4460: libgcrypt performance TODOs.
May 7 2019, 8:15 PM · libgcrypt
jukivili added a comment to T4460: libgcrypt performance TODOs.

SPARC T4 has crypto instruction set for AES, GCM, SHA1, SHA256, SHA512, Camellia and DES, that can be used from user-space too.

May 7 2019, 8:14 PM · libgcrypt
werner added a comment to T4460: libgcrypt performance TODOs.

Isn't the Sparc crypto instruction set only available in kernel mode?

May 7 2019, 11:57 AM · libgcrypt
werner committed rG69e0b080f06b: agent: If a Label is make sure that label is part of the prompt. (authored by werner).
agent: If a Label is make sure that label is part of the prompt.
May 7 2019, 11:52 AM
werner committed rG538853780641: agent: Allow the use of "Label:" in a key file. (authored by werner).
agent: Allow the use of "Label:" in a key file.
May 7 2019, 11:52 AM
werner committed rGb5985d0ca21c: common: New functions nvc_delete_named and nvc_get_string. (authored by werner).
common: New functions nvc_delete_named and nvc_get_string.
May 7 2019, 11:52 AM
aheinecke closed T4487: libksba: please refresh ASN.1 components from more recent RFCs with BSD licensing as Wontfix.

As I want to keep this tracker clean I would say this is a Wontfix at least until someone (DKG?) provides an argument what would be gained and why we should do this.

May 7 2019, 9:30 AM · libksba, Feature Request
werner triaged T4485: Add AEAD mode AES-GCM-SIV to libgcrypt (RFC 8452) as Normal priority.
May 7 2019, 8:55 AM · Feature Request, libgcrypt
werner triaged T4486: Add AEAD mode AES-SIV to libgcrypt (RFC 5297) as Normal priority.
May 7 2019, 8:55 AM · Feature Request, libgcrypt
werner triaged T4487: libksba: please refresh ASN.1 components from more recent RFCs with BSD licensing as Wishlist priority.

That is not a functional feature request and I see no value in chnaging data structures just for being up to the latest RFC. Actually the ASN.1 is not from an RFC but from a specific X.509 profile. For CMS most parsing is anyway done with handcrafted code.

May 7 2019, 8:54 AM · libksba, Feature Request
gniibe committed rGc856ee7312c9: scd: Support direct use of app with PKSIGN/PKAUTH/PKDECRYPT. (authored by gniibe).
scd: Support direct use of app with PKSIGN/PKAUTH/PKDECRYPT.
May 7 2019, 2:54 AM

May 6 2019

dkg created T4487: libksba: please refresh ASN.1 components from more recent RFCs with BSD licensing.
May 6 2019, 11:53 PM · libksba, Feature Request
jukivili updated the task description for T4460: libgcrypt performance TODOs.
May 6 2019, 9:14 PM · libgcrypt