Page MenuHome GnuPG
Feed All Stories

May 14 2019

gniibe changed the status of T4494: UBsan finding "armor.c:1159:11: runtime error: member access within null pointer..." from Open to Testing.

Thanks for your report.

May 14 2019, 4:27 AM · gnupg
gniibe committed rG802a2aa300ba: g10: Fix possible null dereference. (authored by gniibe).
g10: Fix possible null dereference.
May 14 2019, 4:26 AM
gniibe committed rG5b22d2c40089: g10: Fix possible null dereference. (authored by gniibe).
g10: Fix possible null dereference.
May 14 2019, 4:25 AM
dkg added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.

It looks to me like gcry_sexp_canon_len is returning 0 on these platforms from within a backtrace like this:

May 14 2019, 4:21 AM · gnupg (gpg22), Bug Report
dkg added a comment to T4490: --export-secret-keys fails with unusually-created secret key.

I've just pushed 29adca88f5f6425f5311c27bb839718a4956ec3a to the dkg/fix-T4490 branch, which i believe fixes this issue.

May 14 2019, 3:43 AM · ssh, gnupg (gpg22)
dkg committed rG29adca88f5f6: gpg: enable OpenPGP export of cleartext keys with comments (authored by dkg).
gpg: enable OpenPGP export of cleartext keys with comments
May 14 2019, 3:43 AM
wltjr claimed T4147: pinentry-efl does not grab input when requesting pin for authentication.

This is known and by design, basically it is a legacy X feature. For Wayland, the window manager determines if a window should be blocking, no grab or grab, not anything applications themselves have control over. This came up many times when I was first making the interfaces. You can reference these two comments, but there are many more in between them.

May 14 2019, 3:20 AM · Bug Report, pinentry
dkg added a comment to T4507: show-only-fpr-mbox shows user-ids that are not valid.

Validity values are also displayed for all user IDs.
[…]

show-uid-validity
       Display  the  calculated  validity of user IDs during key
       listings.  Defaults to yes.

[…]

Trust values are used to indicate ownertrust and validity of  keys  and
user IDs.  They are displayed with letters or strings:

[…]

revoked
       For validity only: the key or the user ID has been revoked.
May 14 2019, 2:30 AM · Bug Report
dkg committed rGf4dfeb9c80e1: doc: clarify intent for show-only-fpr-mbox (authored by dkg).
doc: clarify intent for show-only-fpr-mbox
May 14 2019, 2:29 AM
dkg added a comment to T4448: Add "Autocrypt" key-origin.

@werner, why is it the case that if i'm willing to look up a key via WKD on Monday, i should by definition also be willing to send a followup request to that WKD server on Thursday just because the certificate is marked with an expiration?

May 14 2019, 2:17 AM · Feature Request
gniibe committed rGcf73c82e95f9: build: Update m4/iconv.m4. (authored by gniibe).
build: Update m4/iconv.m4.
May 14 2019, 1:58 AM
dkg added a comment to T4490: --export-secret-keys fails with unusually-created secret key.

And, i just discovered that when i manually edit the key to remove the (comment) list from the *.key S-expression file, the final --export-secret-key works fine. so the failure appears to be due to the presence of the (comment) clause. (same as in T4501)

May 14 2019, 1:48 AM · ssh, gnupg (gpg22)
JW added a comment to T4499: Asan finding in libgcrypt.

I was talking to Thomas Dickey, who maintains Ncurses. Ncurses had a leak and he offered a config option to remove it. Ncurses config responds to --disable-leaks.

May 14 2019, 1:45 AM · libgcrypt
gniibe added a comment to T4506: OpenPGP Key Certification Forgeries.

In my opinion, it's good if we can offer:

May 14 2019, 1:44 AM · gnupg (gpg22)
dkg added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.

And, i just discovered that when i manually edit the key to remove the (comment) list from the *.key S-expression file, everything works fine on s390x. so the failure appears to be due to the (comment), just like in T4490.

May 14 2019, 1:37 AM · gnupg (gpg22), Bug Report
dkg added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.

fwiw, i've just tried loading the same keyfile that the s390x (64-bit big-endian) implementation choked on into a running gpg-agent on an amd64 machine (64-bit little-endian) and gpg --full-generate-key succeeded with that same key on amd64.

May 14 2019, 1:35 AM · gnupg (gpg22), Bug Report
dkg added a comment to T4513: dirmngr should try the configured keyservers anyway even if they are all dead.

This is particularly bad for users who have manually specified a given keyserver in dirmngr.conf, because even a transient failure in that keyserver will prevent them from any future keyserver requests until dirmngr decides that the "death" has worn off.

May 14 2019, 1:00 AM · Feature Request, Keyserver, dirmngr
dkg created T4513: dirmngr should try the configured keyservers anyway even if they are all dead.
May 14 2019, 12:54 AM · Feature Request, Keyserver, dirmngr
dkg created T4512: gpg's --keyserver option should be more robustly deprecated.
May 14 2019, 12:49 AM · gnupg24, gnupg (gpg23), Documentation, Keyserver, Bug Report
dkg created T4511: dirmngr error logs claim that HTTP GET requests are percent-escaped, but they are not.
May 14 2019, 12:19 AM · Bug Report, dirmngr

May 13 2019

dkg added a comment to T4467: dirmngr keyserver option (and legacy gpg --keyserver) should assume `hkps://` or `hkp://` if no scheme is present.

further testing suggests that the invalid URI issue is only present for dirmngr's --keyserver option, and gpg's deprecated --keyserver option actually accepts schema-less hostnames.

May 13 2019, 11:33 PM · dirmngr
dkg updated the task description for T4467: dirmngr keyserver option (and legacy gpg --keyserver) should assume `hkps://` or `hkp://` if no scheme is present.
May 13 2019, 11:32 PM · dirmngr
dkg added a comment to T4493: Default to HKPS, not HKP.

see also T4467

May 13 2019, 11:12 PM · dirmngr, Feature Request
JW added a comment to T4499: Asan finding in libgcrypt.

Dynamic loading of Libgcrypt is anyway not supported; those who do that are on their own.

May 13 2019, 10:17 PM · libgcrypt
werner added a comment to T4507: show-only-fpr-mbox shows user-ids that are not valid.

"valid user-id" means a user id which is properly bound to the key; that is the self-signature checks out.

May 13 2019, 10:01 PM · Bug Report
werner created T4510: Update our copy of SQLite to 3.28.
May 13 2019, 7:40 PM · CVE
werner committed rGc1dc7a832921: gpg: Change update_keysig_packet to replace SHA-1 by SHA-256. (authored by werner).
gpg: Change update_keysig_packet to replace SHA-1 by SHA-256.
May 13 2019, 7:30 PM
werner added a parent task for T4508: gnupg1: digest-preference not honoured: T4509: Release GnuPG 2.2.16.
May 13 2019, 7:27 PM · gnupg (gpg22), Bug Report
werner added a subtask for T4509: Release GnuPG 2.2.16: T4508: gnupg1: digest-preference not honoured.
May 13 2019, 7:27 PM · Release Info, gnupg (gpg22)
werner created T4509: Release GnuPG 2.2.16.
May 13 2019, 7:26 PM · Release Info, gnupg (gpg22)
werner committed rG484d6ba5896a: gpg: Change update_keysig_packet to replace SHA-1 by SHA-256. (authored by werner).
gpg: Change update_keysig_packet to replace SHA-1 by SHA-256.
May 13 2019, 7:20 PM
werner triaged T4508: gnupg1: digest-preference not honoured as High priority.

I keep this open to track the mentioned change for gnupg 2.2

May 13 2019, 6:53 PM · gnupg (gpg22), Bug Report
werner added a comment to T4508: gnupg1: digest-preference not honoured.

How a digest algorithim is selected for a key signature

May 13 2019, 6:52 PM · gnupg (gpg22), Bug Report
werner added a comment to T4508: gnupg1: digest-preference not honoured.

No, personal-digest-preferences are not used to select a digest algorithm for key signatures. The only way to use a different digest-algorithm than select by gpg is by using --cert-digest-algo. But take care, you can easily cut into your fingers when using such override options.

May 13 2019, 6:49 PM · gnupg (gpg22), Bug Report
sdaoden created T4508: gnupg1: digest-preference not honoured.
May 13 2019, 6:30 PM · gnupg (gpg22), Bug Report
aa7356 added a comment to T4475: Gemalto IDBridge CT710 && Pinentry.

WK you command me to put the file scd.log somewhere.
I am trying to do it on the wires set "F103RB" from ARM (GeeNuke)

May 13 2019, 4:05 PM · Feature Request
werner triaged T4499: Asan finding in libgcrypt as Low priority.

I have not yet looked at the details but I do not consider one-time allocation a problem. If you want to silence ASAN it is possible to use gpgrt_annotate_leaked_object( foo). Dynamic loading of Libgcrypt is anyway not supported; those who do that are on their own.

May 13 2019, 4:01 PM · libgcrypt
dkg created T4507: show-only-fpr-mbox shows user-ids that are not valid.
May 13 2019, 3:47 PM · Bug Report
werner added a comment to T4506: OpenPGP Key Certification Forgeries.
  • For 2.3 we should ignore all SHA-1 key certifications and warn about SHA-1 binding signatures and offer to migrate them.
May 13 2019, 2:43 PM · gnupg (gpg22)
werner added a comment to T4506: OpenPGP Key Certification Forgeries.

How a digest algorithim is selected for a key signature

May 13 2019, 1:38 PM · gnupg (gpg22)
werner committed rGd07666412d43: gpg: Cleanup use of make_keysig_packet. (authored by werner).
gpg: Cleanup use of make_keysig_packet.
May 13 2019, 1:24 PM
werner changed the visibility for T4506: OpenPGP Key Certification Forgeries.
May 13 2019, 11:05 AM · gnupg (gpg22)
gniibe committed rP42c32e08d5a4: build: Update m4/iconv.m4. (authored by gniibe).
build: Update m4/iconv.m4.
May 13 2019, 10:51 AM
gniibe committed rGPA1cb82dcfcea4: build: Update m4/iconv.m4. (authored by gniibe).
build: Update m4/iconv.m4.
May 13 2019, 10:13 AM
aheinecke created T4505: SM, W32: GPGSM hangs up the GnuPG System.
May 13 2019, 9:39 AM · Restricted Project, gpgol, S/MIME, gpg4win, Windows
gniibe committed rE07b1b3be1798: build: Update m4/iconv.m4. (authored by gniibe).
build: Update m4/iconv.m4.
May 13 2019, 9:32 AM
werner added a comment to T4504: Asan findings in iconv configure test causing config failure.

We update condig.{guess,sub} only when needed. In the past we had cases with regressions on some rare platforms.

May 13 2019, 8:49 AM · gpgrt, gnupg
gniibe claimed T4397: GPG Error - version >= 1.25... no.

It is because you don't have ${prefix}/bin in your PATH.
Please build having /var/tmp/bin in your PATH.

May 13 2019, 8:35 AM · gpgrt, Bug Report
gniibe added a project to T4504: Asan findings in iconv configure test causing config failure: gpgrt.
May 13 2019, 8:17 AM · gpgrt, gnupg
gniibe committed rG1cd2aca03b88: build: Update m4/iconv.m4. (authored by gniibe).
build: Update m4/iconv.m4.
May 13 2019, 8:17 AM
JW added a comment to T4504: Asan findings in iconv configure test causing config failure.

I'm going to bring newest m4/iconv.m4 from original (gettext), which apparently fixed file descriptor leaks.

May 13 2019, 8:08 AM · gpgrt, gnupg
gniibe claimed T4504: Asan findings in iconv configure test causing config failure.

Thanks for your report.

May 13 2019, 8:05 AM · gpgrt, gnupg
JW added a comment to T4504: Asan findings in iconv configure test causing config failure.

An FYI... Once we cleared the earlier findings GnuPG tested OK under Asan. GnuPG itself had no findings, and it did not cause any dependent libraries to generate findings.

May 13 2019, 7:20 AM · gpgrt, gnupg

May 12 2019

werner committed rG8d0d61aca3d2: sm: Fix a warning in an es_fopencooie function. (authored by werner).
sm: Fix a warning in an es_fopencooie function.
May 12 2019, 8:43 PM
werner triaged T4495: UBsan finding "certdump.c:695:3: runtime error: null pointer passed as argument 2" as Normal priority.

Thanks for the tests. I just fixed this one and will do replace some code in master, soon.

May 12 2019, 8:43 PM · gnupg
werner triaged T4502: keys added via gpg-agent's ssh-agent interface are stored in private-keys-v1.d/ with a trailing null byte as Normal priority.

I often put an extra nul byte at the end of binary data so that accidental printing the data (e.g. in gdb) assures that there is a string terminator. But right, it should not go out to a file.

May 12 2019, 8:16 PM · gpgagent, ssh
jukivili added a comment to T4499: Asan finding in libgcrypt.

That type of variadic macro is GCC extension, see https://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html

May 12 2019, 6:45 PM · libgcrypt
JW added a comment to T4504: Asan findings in iconv configure test causing config failure.

This patch tested OK.

May 12 2019, 11:44 AM · gpgrt, gnupg
JW created T4504: Asan findings in iconv configure test causing config failure in the S1 Public space.
May 12 2019, 10:26 AM · gpgrt, gnupg
kaspro added a comment to T4301: Handling multiple subkeys on two SmartCards.

Hello again - can I ask about the status? Or should I consider this as a no-fix? Anything I can assist with?

May 12 2019, 7:56 AM · Restricted Project, gnupg, scd, Bug Report
JW added a comment to T4499: Asan finding in libgcrypt.

The second and third arguments passed to xgcry_control seem to be lost when calling gcry_control.

May 12 2019, 7:16 AM · libgcrypt
dkg created T4503: include extension for OpenPGP creation timestamp in X.509 output.
May 12 2019, 1:01 AM · Feature Request, S/MIME
JW added a comment to T4499: Asan finding in libgcrypt.

Here are the next two failures I am seeing while testing libgrcypt. It appears to be related to GCRYCTL_INIT_SECMEM.

May 12 2019, 12:44 AM · libgcrypt
dkg created T4502: keys added via gpg-agent's ssh-agent interface are stored in private-keys-v1.d/ with a trailing null byte.
May 12 2019, 12:37 AM · gpgagent, ssh

May 11 2019

JW added a comment to T4499: Asan finding in libgcrypt.

I'm still seeing a few odd outputs from make check, but I have not investigated them yet.

May 11 2019, 10:50 PM · libgcrypt
JW added a comment to T4499: Asan finding in libgcrypt.

Maybe cleaner option for mpi/mpiutil.c would be to statically allocate the constants

May 11 2019, 9:14 PM · libgcrypt
jukivili added a comment to T4499: Asan finding in libgcrypt.

Maybe cleaner option for mpi/mpiutil.c would be to statically allocate the constants

May 11 2019, 1:27 PM · libgcrypt
JW added a comment to T4499: Asan finding in libgcrypt.

Here's a couple of awful hacks that get me through make check. Feel free to restate how awful they are; I know it is a bad thing to do.

May 11 2019, 7:24 AM · libgcrypt
dkg added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.


here is a copy of another example generated key (not b64-encoded), if you want to just download it.

May 11 2019, 4:24 AM · gnupg (gpg22), Bug Report
dkg added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.

I also did a base64 < "$GNUPGHOME/private-keys-v1.d/".key at the end of a different run of that script, and it produced this output, if you'd like to inspect the actual S-expression stored:

May 11 2019, 4:21 AM · gnupg (gpg22), Bug Report
dkg added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.

I ran the example script from T4490 on an s390x machine, and got the following output:

May 11 2019, 4:16 AM · gnupg (gpg22), Bug Report
dkg updated the task description for T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.
May 11 2019, 12:37 AM · gnupg (gpg22), Bug Report
dkg set Version to 2.2.13 on T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.
May 11 2019, 12:36 AM · gnupg (gpg22), Bug Report
dkg added a comment to T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.

This might be related to T4490, since it's the same sort of key generation process.

May 11 2019, 12:36 AM · gnupg (gpg22), Bug Report
dkg created T4501: gpg --generate-key --batch from existing key (with Key-Grip:) fails on 64-bit big-endian architectures.
May 11 2019, 12:33 AM · gnupg (gpg22), Bug Report

May 10 2019

pa_am created T4500: Option --use-embedded-filename does not work as expect.
May 10 2019, 11:51 PM · gnupg (gpg22), Bug Report
JW updated the task description for T4499: Asan finding in libgcrypt.
May 10 2019, 11:44 PM · libgcrypt
JW created T4499: Asan finding in libgcrypt in the S1 Public space.
May 10 2019, 11:43 PM · libgcrypt
JW created T4498: Asan findings in tests/t-logging.c in the S1 Public space.
May 10 2019, 11:34 PM · gpgrt
dkg created T4497: gpgconf should report clearer errors when it knows that a given daemon's config file is bad.
May 10 2019, 11:24 PM · gnupg (gpg22)
dkg added a comment to T4490: --export-secret-keys fails with unusually-created secret key.

I was trying to use the above technique to be able to generate an OpenPGP transferable secret key in an ephemeral homedir. Ephemeral directories are recommended in the GnuPG info page's "unattended usage" section, but they do not work here.

May 10 2019, 10:45 PM · ssh, gnupg (gpg22)
jukivili committed rC34e9306a66b4: tests/basic: mark CFB and CFB8 as stream block cipher modes (authored by jukivili).
tests/basic: mark CFB and CFB8 as stream block cipher modes
May 10 2019, 10:44 PM
jukivili committed rC15592cd52f54: Fix message digest final function for MD4, MD5 and RMD160 (authored by jukivili).
Fix message digest final function for MD4, MD5 and RMD160
May 10 2019, 10:44 PM
JW added a comment to T4495: UBsan finding "certdump.c:695:3: runtime error: null pointer passed as argument 2".

It looks like this patch clears this finding:

May 10 2019, 9:26 PM · gnupg
dkg created T4496: gpgconf --launch ignores --homedir arguments.
May 10 2019, 9:25 PM · Bug Report, gnupg (gpg22)
JW created T4495: UBsan finding "certdump.c:695:3: runtime error: null pointer passed as argument 2" in the S1 Public space.
May 10 2019, 9:24 PM · gnupg
JW added a comment to T4494: UBsan finding "armor.c:1159:11: runtime error: member access within null pointer...".

It looks like this patch clears this finding:

May 10 2019, 9:07 PM · gnupg
JW created T4494: UBsan finding "armor.c:1159:11: runtime error: member access within null pointer..." in the S1 Public space.
May 10 2019, 8:31 PM · gnupg
werner triaged T4493: Default to HKPS, not HKP as Normal priority.
May 10 2019, 7:23 PM · dirmngr, Feature Request
dkg committed rGbe116f871dbf: doc: correct documentation for gpgconf --kill (authored by dkg).
doc: correct documentation for gpgconf --kill
May 10 2019, 6:43 PM
dkg committed rG9662538be6af: doc: correct documentation for gpgconf --kill (authored by dkg).
doc: correct documentation for gpgconf --kill
May 10 2019, 6:42 PM
Laurent Montel <montel@kde.org> committed rKLEOPATRA05c0757d8038: Remove deprecated method qVariantFromValue->QVariant::fromValue (authored by Laurent Montel <montel@kde.org>).
Remove deprecated method qVariantFromValue->QVariant::fromValue
May 10 2019, 2:17 PM
Valodim created T4493: Default to HKPS, not HKP.
May 10 2019, 2:13 PM · dirmngr, Feature Request
werner triaged T4490: --export-secret-keys fails with unusually-created secret key as Normal priority.
May 10 2019, 10:20 AM · ssh, gnupg (gpg22)
werner triaged T4491: Compile error in nPth's t-fork.c on Solaris 11.3 i86pc as Normal priority.
May 10 2019, 10:17 AM · npth, Bug Report
werner renamed T4491: Compile error in nPth's t-fork.c on Solaris 11.3 i86pc from Compile error in Nth t-fork.c on Solaris 11.3 i86pc to Compile error in nPth's t-fork.c on Solaris 11.3 i86pc.
May 10 2019, 10:16 AM · npth, Bug Report
werner closed T4492: Gawk 5.0 and warning: regexp escape sequence `\#' is not a known regexp operator as Resolved.

We fixed this bug already in the repo. See T4459.

May 10 2019, 10:13 AM · Duplicate, gnupg
JW added a comment to T4491: Compile error in nPth's t-fork.c on Solaris 11.3 i86pc.

It looks like Solaris only needs CFLAGS+=-std=c99. It was added for all programs and libraries listed at https://www.gnupg.org/download/index.html.

May 10 2019, 9:06 AM · npth, Bug Report
JW updated the task description for T4492: Gawk 5.0 and warning: regexp escape sequence `\#' is not a known regexp operator.
May 10 2019, 8:48 AM · Duplicate, gnupg
JW created T4492: Gawk 5.0 and warning: regexp escape sequence `\#' is not a known regexp operator in the S1 Public space.
May 10 2019, 8:46 AM · Duplicate, gnupg