Page MenuHome GnuPG
Feed All Stories

Jun 15 2023

ebo moved T6373: Kleopatra: Show progress dialog when moving decrypted archive to final destination from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 15 2023, 12:25 PM · Restricted Project, kleopatra
ebo closed T6473: Kleopatra: "Change Validity" does ignore the option "Also update the validity period of the subkeys" as Resolved.
Jun 15 2023, 12:23 PM · kleopatra, Restricted Project
werner committed rGa88aeee12990: gpgsm: Fix last commit (authored by werner).
gpgsm: Fix last commit
Jun 15 2023, 12:20 PM
ikloecker changed the status of T6373: Kleopatra: Show progress dialog when moving decrypted archive to final destination from Testing to Open.

Move back to the backlog and trigger re-evalutation of priority (which was high).

Jun 15 2023, 12:08 PM · Restricted Project, kleopatra
ikloecker changed the status of T6373: Kleopatra: Show progress dialog when moving decrypted archive to final destination, a subtask of T5478: Kleopatra: Performance problems decrypting and encrypting large Archives, from Testing to Open.
Jun 15 2023, 12:08 PM · Restricted Project, gpgme, kleopatra
ikloecker created T6537: Make KIO::move work on Windows when moving between different partitions.
Jun 15 2023, 12:05 PM · Restricted Project, kleopatra
werner moved T6534: gpg's progress_filter needs to use uint64_t from WiP to QA on the gnupg24 board.
Jun 15 2023, 11:21 AM · gpgme (gpgme 1.23.x), gnupg22 (gnupg-2.2.42), gnupg24 (gnupg-2.4.3), Feature Request, Restricted Project, Windows
werner committed rG6944aefa3c2e: kbx,w32: Disable the fd-passing. (authored by werner).
kbx,w32: Disable the fd-passing.
Jun 15 2023, 11:17 AM
werner committed rGcd7f286486f2: gpgtar: Emit FAILURE status line. (authored by werner).
gpgtar: Emit FAILURE status line.
Jun 15 2023, 11:17 AM
werner committed rG5f46bcaaa082: sm: Emit STATUS_FAILURE for non-implemented commands. (authored by werner).
sm: Emit STATUS_FAILURE for non-implemented commands.
Jun 15 2023, 11:17 AM
werner committed rG48b56485548e: common,w32: Set a proper error code when creating an output file. (authored by werner).
common,w32: Set a proper error code when creating an output file.
Jun 15 2023, 11:17 AM
werner committed rG6657230f9ee4: w32: Add missing supportedOS Ids for Windows-10 (authored by werner).
w32: Add missing supportedOS Ids for Windows-10
Jun 15 2023, 11:17 AM
werner committed rG3fbe10172f0a: w32: Add missing manifests and set a requestedExecutionLevel. (authored by werner).
w32: Add missing manifests and set a requestedExecutionLevel.
Jun 15 2023, 11:17 AM
werner committed rG80097bc78bf7: gpg: Return ERROR status for --quick-sign-key. (authored by werner).
gpg: Return ERROR status for --quick-sign-key.
Jun 15 2023, 11:17 AM
gniibe committed rG0f8e5f1c1db0: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Jun 15 2023, 11:17 AM
gniibe committed rG6a2cb8cfd714: agent,w32: Fix resource leak for a process. (authored by gniibe).
agent,w32: Fix resource leak for a process.
Jun 15 2023, 11:17 AM
werner committed rG9f2f7a51b243: gpg: Skip keys found via ADSKs. (authored by werner).
gpg: Skip keys found via ADSKs.
Jun 15 2023, 11:17 AM
werner committed rGa048a93ed2c3: common: New function nve_set (authored by werner).
common: New function nve_set
Jun 15 2023, 11:17 AM
werner committed rG14828c75be10: gpg: Fix searching for the ADSK key when adding an ADSK. (authored by werner).
gpg: Fix searching for the ADSK key when adding an ADSK.
Jun 15 2023, 11:17 AM
werner committed rG13013ec1c0d3: agent: Create and use Token entries to track the display s/n. (authored by werner).
agent: Create and use Token entries to track the display s/n.
Jun 15 2023, 11:17 AM
werner committed rG05f29b5c7caa: agent: Update key files by first writing to a temp file. (authored by werner).
agent: Update key files by first writing to a temp file.
Jun 15 2023, 11:17 AM
werner committed rGa1015bf2fc07: agent: Do not overwrite a key file by a shadow key file. (authored by werner).
agent: Do not overwrite a key file by a shadow key file.
Jun 15 2023, 11:17 AM
werner committed rGf953d67446fa: Prepare the NEWS for the next release (authored by werner).
Prepare the NEWS for the next release
Jun 15 2023, 11:17 AM
werner committed rG4cfa2efdc6f8: po: Translated one new string to German. (authored by werner).
po: Translated one new string to German.
Jun 15 2023, 11:17 AM
werner committed rG550bc15b006d: po: msgmerge done (authored by werner).
po: msgmerge done
Jun 15 2023, 11:17 AM
werner committed rG3c97dc2714b6: Post release updates (authored by werner).
Post release updates
Jun 15 2023, 11:17 AM
werner committed rG9e86dac84f37: Release 2.4.2 (authored by werner).
Release 2.4.2
Jun 15 2023, 11:17 AM
werner committed rG2c1d5d5cd35c: po: Update Czech translation (authored by petr_p).
po: Update Czech translation
Jun 15 2023, 11:17 AM
werner committed rGc8f6fdcd359a: build: Always build the wixlib with a release (authored by werner).
build: Always build the wixlib with a release
Jun 15 2023, 11:17 AM
werner committed rG89da4a32ab77: doc: Replace remaining "gpg2" by "gpg". (authored by werner).
doc: Replace remaining "gpg2" by "gpg".
Jun 15 2023, 11:17 AM
werner committed rGbaa88832153d: gpg: Set default expiration date to 3 years. (authored by werner).
gpg: Set default expiration date to 3 years.
Jun 15 2023, 11:17 AM
werner committed rGc68dd2287237: gpg: Add --list-filter properties key_expires and key_expires_d. (authored by werner).
gpg: Add --list-filter properties key_expires and key_expires_d.
Jun 15 2023, 11:17 AM
werner committed rG7b7fdf45e5d8: common: New function substitute_vars. (authored by werner).
common: New function substitute_vars.
Jun 15 2023, 11:17 AM
werner committed rG207c99567ced: dirmngr: Extend the AD_QUERY command. (authored by werner).
dirmngr: Extend the AD_QUERY command.
Jun 15 2023, 11:17 AM
werner committed rG695cb04af521: gpg: Print status line and proper diagnostics for write errors. (authored by werner).
gpg: Print status line and proper diagnostics for write errors.
Jun 15 2023, 11:17 AM
werner committed rGca3f0e66bcf6: w32: Map ERROR_FILE_INVALID to EIO. (authored by werner).
w32: Map ERROR_FILE_INVALID to EIO.
Jun 15 2023, 11:17 AM
werner committed rG64509134d47a: speedo,w32: Call gpgconf --kill all (authored by aheinecke).
speedo,w32: Call gpgconf --kill all
Jun 15 2023, 11:17 AM
werner committed rG808494b48577: gpg: Make progress work for large files on Windows. (authored by werner).
gpg: Make progress work for large files on Windows.
Jun 15 2023, 11:17 AM
werner committed rGc58067415fe9: gpgsm: Print PROGRESS status lines. (authored by werner).
gpgsm: Print PROGRESS status lines.
Jun 15 2023, 11:17 AM
werner committed rM8796456d235d: tests: Add option --cancel to run-encrypt. (authored by werner).
tests: Add option --cancel to run-encrypt.
Jun 15 2023, 11:03 AM
werner committed rMeb68948c4388: core: Use 64 bit instead of gpgme_off_t for some internal functions. (authored by werner).
core: Use 64 bit instead of gpgme_off_t for some internal functions.
Jun 15 2023, 11:03 AM
werner added a project to T6534: gpg's progress_filter needs to use uint64_t: gpgme.

And of course we also need to adjust GPGME

Jun 15 2023, 10:58 AM · gpgme (gpgme 1.23.x), gnupg22 (gnupg-2.2.42), gnupg24 (gnupg-2.4.3), Feature Request, Restricted Project, Windows
werner added a comment to T6534: gpg's progress_filter needs to use uint64_t.

We also need PROGRESS lines in gpgsm.

Jun 15 2023, 10:36 AM · gpgme (gpgme 1.23.x), gnupg22 (gnupg-2.2.42), gnupg24 (gnupg-2.4.3), Feature Request, Restricted Project, Windows
gniibe committed rCed879d832659: cipher:ecc: Fix EdDSA secret key check. (authored by gniibe).
cipher:ecc: Fix EdDSA secret key check.
Jun 15 2023, 6:42 AM
gniibe committed rCf4019ed225bf: context: Make the context chain-able. (authored by gniibe).
context: Make the context chain-able.
Jun 15 2023, 4:27 AM
l10n daemon script <scripty@kde.org> committed rKLEOPATRA131d4ddcfa01: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
Jun 15 2023, 3:59 AM
gniibe added a comment to rCc160e1a85f82: cipher:pubkey: Fix non-use of flexible array member..

I agree that the "future" won't come, ever. (for libgcrypt)

Jun 15 2023, 2:02 AM

Jun 14 2023

ebo closed T6452: Kleopatra: Configurable default for certification expiry as Resolved.

works

Jun 14 2023, 2:15 PM · Restricted Project, kleopatra
werner added a project to T6536: Extend P12 parser for ShroudedKeyBag inside a CertBag: Bug Report.
Jun 14 2023, 12:39 PM · gnupg24 (gnupg-2.4.4), gnupg22 (gnupg-2.2.42), Bug Report, S/MIME, Restricted Project
werner triaged T6536: Extend P12 parser for ShroudedKeyBag inside a CertBag as Normal priority.
Jun 14 2023, 12:36 PM · gnupg24 (gnupg-2.4.4), gnupg22 (gnupg-2.2.42), Bug Report, S/MIME, Restricted Project
ebo closed T6330: Kleopatra: Additional Expiry handling as Resolved.

works

Jun 14 2023, 11:55 AM · kleopatra, Restricted Project
ebo added a comment to T6473: Kleopatra: "Change Validity" does ignore the option "Also update the validity period of the subkeys".

It does not work as described for subkeys with later expiry dates if the primary key has already expired:


Change validity on the 12th for that key results in:

Jun 14 2023, 11:24 AM · kleopatra, Restricted Project
werner added a comment to rCc160e1a85f82: cipher:pubkey: Fix non-use of flexible array member..

I doubt that we will ever be able to use the flexible array thingy. The old pattern has been used for nearly 50 years and replacing it will just introduce bugs.
Do you use offsetof for that reason?

Jun 14 2023, 11:19 AM
gniibe committed rCc160e1a85f82: cipher:pubkey: Fix non-use of flexible array member. (authored by gniibe).
cipher:pubkey: Fix non-use of flexible array member.
Jun 14 2023, 10:13 AM
gniibe committed rC86fcf8292208: cipher:ecc: Support gcry_pk_hash_sign/verify for EdDSA. (authored by gniibe).
cipher:ecc: Support gcry_pk_hash_sign/verify for EdDSA.
Jun 14 2023, 7:59 AM
gniibe added a comment to T6511: EdDSA support in FIPS mode.

I found that for EdDSA other than pure Ed25519, it can supply context.
I changed the semantics and API for adding context and input data, as we need to support both simultaneously.

Jun 14 2023, 7:49 AM · FIPS, libgcrypt, Bug Report
l10n daemon script <scripty@kde.org> committed rKLEOPATRA844aafd12c09: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
Jun 14 2023, 5:22 AM
gniibe added a comment to T6511: EdDSA support in FIPS mode.

I changed the lg-input-data.diff patch not to break the ABI, reusing the published symbol of gcry_pk_random_override_new.
With this approach, if/when needed, backporting may be easier.
Drawback is debugging internal of libgcrypt will be a bit confusing.

Jun 14 2023, 4:50 AM · FIPS, libgcrypt, Bug Report
l10n daemon script <scripty@kde.org> committed rKLEOPATRA220f1071b6ec: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
Jun 14 2023, 3:56 AM

Jun 13 2023

werner triaged T6535: Failure to export plaintext v5 secret key. as Normal priority.
Jun 13 2023, 7:41 PM · gnupg24, Bug Report
werner added a project to T6535: Failure to export plaintext v5 secret key.: gnupg24.

Thanks, we will take care of this.

Jun 13 2023, 7:41 PM · gnupg24, Bug Report
aheinecke committed rWfce655326255: Add manifest for okular and fix open with for PDF (authored by aheinecke).
Add manifest for okular and fix open with for PDF
Jun 13 2023, 5:00 PM
aheinecke committed rW4d57b4608223: Remove KTextWidgets patch parts from Okular patch (authored by aheinecke).
Remove KTextWidgets patch parts from Okular patch
Jun 13 2023, 4:59 PM
onickolay updated the task description for T6535: Failure to export plaintext v5 secret key..
Jun 13 2023, 2:43 PM · gnupg24, Bug Report
onickolay created T6535: Failure to export plaintext v5 secret key..
Jun 13 2023, 2:42 PM · gnupg24, Bug Report
aheinecke committed rM7e6d51aa6fc9: Fix definition of GPG_ERR_ENABLE_GETTEXT_MACROS (authored by aheinecke).
Fix definition of GPG_ERR_ENABLE_GETTEXT_MACROS
Jun 13 2023, 1:31 PM
werner added a comment to T6515: GPG in FIPS mode spits out useless "out of core handler ignored in FIPS mode" message on every execution.

Let's fix this in Libgcrypt (ignore setting of the handler)

Jun 13 2023, 11:19 AM · FIPS, Bug Report
werner added a comment to rC469919751d6e: cipher:ecc: Fix public key computation for EdDSA..

This is related to T6511

Jun 13 2023, 10:57 AM
werner claimed T6534: gpg's progress_filter needs to use uint64_t.
Jun 13 2023, 10:07 AM · gpgme (gpgme 1.23.x), gnupg22 (gnupg-2.2.42), gnupg24 (gnupg-2.4.3), Feature Request, Restricted Project, Windows
Jakuje added a comment to T6511: EdDSA support in FIPS mode.

Another approach would be having "non-hash" algo for gcry_md_open.

Jun 13 2023, 9:53 AM · FIPS, libgcrypt, Bug Report
gniibe committed rC469919751d6e: cipher:ecc: Fix public key computation for EdDSA. (authored by gniibe).
cipher:ecc: Fix public key computation for EdDSA.
Jun 13 2023, 7:49 AM
gniibe added a comment to T6511: EdDSA support in FIPS mode.

Before adding FIPS support flag and tests, we need to modify implementation:

  • Adding PCT check for EdDSA
  • Adding support of gcry_pk_hash_sign/verify API for EdDSA
Jun 13 2023, 6:33 AM · FIPS, libgcrypt, Bug Report
l10n daemon script <scripty@kde.org> committed rKLEOPATRAcca6cbfe9413: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
Jun 13 2023, 5:29 AM
l10n daemon script <scripty@kde.org> committed rKLEOPATRA7a8f04f4b395: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
Jun 13 2023, 4:00 AM
gniibe added a comment to T6271: The old FSF address in libgcrypt source code.

Thanks. I think that it was the oldest one: FSF used to be there in Cambridge, then moved to Tremont St. in Boston, and now it's in Franklin St.

Jun 13 2023, 3:10 AM · Documentation, libgcrypt, Bug Report

Jun 12 2023

ikloecker changed the status of T5478: Kleopatra: Performance problems decrypting and encrypting large Archives from Testing to Open.
Jun 12 2023, 6:38 PM · Restricted Project, gpgme, kleopatra
ikloecker added a parent task for T6530: GPGME / QGpgME Extend Archivejobs to accept input / output from a filename: T5478: Kleopatra: Performance problems decrypting and encrypting large Archives.
Jun 12 2023, 6:25 PM · gpgme, Restricted Project, kleopatra
ikloecker added a subtask for T5478: Kleopatra: Performance problems decrypting and encrypting large Archives: T6530: GPGME / QGpgME Extend Archivejobs to accept input / output from a filename.
Jun 12 2023, 6:25 PM · Restricted Project, gpgme, kleopatra
werner triaged T6534: gpg's progress_filter needs to use uint64_t as High priority.
Jun 12 2023, 4:23 PM · gpgme (gpgme 1.23.x), gnupg22 (gnupg-2.2.42), gnupg24 (gnupg-2.4.3), Feature Request, Restricted Project, Windows
werner created T6534: gpg's progress_filter needs to use uint64_t.
Jun 12 2023, 4:23 PM · gpgme (gpgme 1.23.x), gnupg22 (gnupg-2.2.42), gnupg24 (gnupg-2.4.3), Feature Request, Restricted Project, Windows
Jakuje added a comment to T6271: The old FSF address in libgcrypt source code.

FYI, while going through the licenses again I noticed one of the pinentry files have even older address that so if you would do sed, this would not be matched:

Jun 12 2023, 4:11 PM · Documentation, libgcrypt, Bug Report
werner committed rE3faf11925549: yat2m: Fix Windows build (authored by werner).
yat2m: Fix Windows build
Jun 12 2023, 3:51 PM
aheinecke added a comment to T6531: Gpgtar behavioral change when extracting archives.

In the past this was done by --set-filename in libkleopatrarc-win32.desktop. But I am happy if we close this and focus on T6530.

Jun 12 2023, 3:46 PM · Restricted Project, kleopatra, gpgtar
aheinecke reopened T6363: Add progress status output to gpgtar as "Open".

I'm reopening this. Its probably not a regression but I was sure that we had progress for large files fixed in the past.

Jun 12 2023, 3:44 PM · gpgme (gpgme 1.23.x), gnupg22 (gnupg-2.2.42), gnupg24 (gnupg-2.4.1), Feature Request
ikloecker added a comment to T6531: Gpgtar behavioral change when extracting archives.

Which only works if gpgtar actually knows the input file name (which it will once T6530: GPGME / QGpgME Extend Archivejobs to accept input / output from a filename is done and used).

Jun 12 2023, 3:23 PM · Restricted Project, kleopatra, gpgtar
werner added projects to T6531: Gpgtar behavioral change when extracting archives: gpgtar, kleopatra.
Jun 12 2023, 3:21 PM · Restricted Project, kleopatra, gpgtar
aheinecke added a comment to T6363: Add progress status output to gpgtar.

Yeah no progress for files larger then 32 bit o.O... But this used to work 😭

Jun 12 2023, 3:18 PM · gpgme (gpgme 1.23.x), gnupg22 (gnupg-2.2.42), gnupg24 (gnupg-2.4.1), Feature Request
aheinecke added a comment to T6363: Add progress status output to gpgtar.

On 64 bit linux this works btw. so I think it comes down to the difference between 32 bit off_t and 64 bit off_t

Jun 12 2023, 3:13 PM · gpgme (gpgme 1.23.x), gnupg22 (gnupg-2.2.42), gnupg24 (gnupg-2.4.1), Feature Request
aheinecke added a comment to T6363: Add progress status output to gpgtar.

Yeah, its the ugly off_t again. I am just testing how this works with single files above that threshold we worked quite a bit on this back in the days https://dev.gnupg.org/T2368

Jun 12 2023, 3:12 PM · gpgme (gpgme 1.23.x), gnupg22 (gnupg-2.2.42), gnupg24 (gnupg-2.4.1), Feature Request
ikloecker added a comment to T6363: Add progress status output to gpgtar.

Yeah, probably a Windows/MinGW 32-bit problem. GpgME::Data does

off_t size = seek(0, SEEK_END);
seek(0, SEEK_SET);
std::string sizestr = std::to_string(size);
// Ignore errors as this is optional
gpgme_data_set_flag(d->data, "size-hint", sizestr.c_str());
Jun 12 2023, 3:00 PM · gpgme (gpgme 1.23.x), gnupg22 (gnupg-2.2.42), gnupg24 (gnupg-2.4.1), Feature Request
aheinecke added a comment to T6533: Kleopatra: Import progress weird when importing large files.

Well staying at 0 is imo worse then knight rider because that looks "stuck" and knight rider looks "working".

Jun 12 2023, 2:55 PM · kleopatra, Restricted Project
ikloecker added a comment to T6533: Kleopatra: Import progress weird when importing large files.

Well the progress is by file and type of import (OpenPGP, S/MIME, groups). Is importing a 38 MB keyring really a use case that is worth changing perfectly working behavior? People, rightfully, hate knight rider progress because it gives no indication at all when it's finished.

Jun 12 2023, 2:42 PM · kleopatra, Restricted Project
aheinecke added a comment to T6531: Gpgtar behavioral change when extracting archives.

So we basically let gpgtar pick the folder name again.

Jun 12 2023, 2:42 PM · Restricted Project, kleopatra, gpgtar
aheinecke added a comment to T6531: Gpgtar behavioral change when extracting archives.

Yes. I think for now we should ifdef the directory change to Linux, must be done in GPGME I think. I know its ugly to have it differently on both plattforms but while extracting in a subfolder might be more uncomfortable our users are used to this and this resolves the issue until we have better options with KIO.

Jun 12 2023, 2:41 PM · Restricted Project, kleopatra, gpgtar
ikloecker added a comment to T6531: Gpgtar behavioral change when extracting archives.

I wasn't aware of this behavior (on Windows), i.e. the behavior change wasn't intended.

Jun 12 2023, 2:35 PM · Restricted Project, kleopatra, gpgtar
aheinecke added a comment to T6532: Kleopatra: X509 import needs to be offline.

Ok

Jun 12 2023, 2:29 PM · kleopatra, Restricted Project
ikloecker added a comment to T6532: Kleopatra: X509 import needs to be offline.

There is already an additional handleExternalCMSImports which does

// For external CMS Imports we have to manually do a keylist
// with validation to get the intermediate and root ca imported
// automatically if trusted-certs and extra-certs are used.
Jun 12 2023, 2:26 PM · kleopatra, Restricted Project
aheinecke triaged T6533: Kleopatra: Import progress weird when importing large files as Normal priority.
Jun 12 2023, 2:04 PM · kleopatra, Restricted Project
aheinecke triaged T6532: Kleopatra: X509 import needs to be offline as High priority.
Jun 12 2023, 1:34 PM · kleopatra, Restricted Project
aheinecke added a comment to T6363: Add progress status output to gpgtar.

Probably some issue with large files / integer overflow. I am testing on Windows with 32 bit.

Jun 12 2023, 1:27 PM · gpgme (gpgme 1.23.x), gnupg22 (gnupg-2.2.42), gnupg24 (gnupg-2.4.1), Feature Request