Page MenuHome GnuPG
Feed Advanced Search

May 29 2024

werner committed rGa1f85fdc40e4: agent: Avoid uninitialized access in GENKEY command on parameter error. (authored by Jakuje).
agent: Avoid uninitialized access in GENKEY command on parameter error.
May 29 2024, 12:00 PM
werner committed rGebf9e3b824f8: wks: Make sure that ERR is always initialized. (authored by werner).
wks: Make sure that ERR is always initialized.
May 29 2024, 12:00 PM
werner changed the status of T7129: Fix static reports by static analyser in gnugp from Open to Testing.

Backported to 2.4 and relevant parts also to 2.2

May 29 2024, 12:00 PM · gnupg22 (gnupg-2.2.44), gnupg24 (2.4.6), Bug Report
werner committed rGf54944693376: gpg-auth: Fix use after free. (authored by Jakuje).
gpg-auth: Fix use after free.
May 29 2024, 11:49 AM
werner committed rG521455df0702: agent: Avoid uninitialized access in GENKEY command on parameter error. (authored by Jakuje).
agent: Avoid uninitialized access in GENKEY command on parameter error.
May 29 2024, 11:49 AM
werner committed rGece154562f00: gpgsm: Avoid double free when checking rsaPSS signatures. (authored by Jakuje).
gpgsm: Avoid double free when checking rsaPSS signatures.
May 29 2024, 11:49 AM
werner committed rG524e3a934568: scd: Avoid buffer overrun with more than 16 PC/SC readers. (authored by Jakuje).
scd: Avoid buffer overrun with more than 16 PC/SC readers.
May 29 2024, 11:49 AM
werner committed rG5e7ea643052b: agent: Avoid double free of empty string in the PIN caching. (authored by werner).
agent: Avoid double free of empty string in the PIN caching.
May 29 2024, 11:49 AM
werner committed rG234e9db3c324: gpg: Avoid a double free on error in the key generation. (authored by werner).
gpg: Avoid a double free on error in the key generation.
May 29 2024, 11:49 AM
werner committed rG19d93a239dc5: agent: Make sure to return success in ephemeral store mode. (authored by werner).
agent: Make sure to return success in ephemeral store mode.
May 29 2024, 11:49 AM
werner committed rG0b52f837801c: wks: Make sure that ERR is always initialized. (authored by werner).
wks: Make sure that ERR is always initialized.
May 29 2024, 11:49 AM
werner committed rGf46d75f0b223: scd:openpgp: Add new vendor. (authored by werner).
scd:openpgp: Add new vendor.
May 29 2024, 11:49 AM
werner closed T7137: unreliable RSA decryption as Resolved.

I can replicate that and it works if you disable the use of the CRT. Looking at the key:

pkey[0]: BC9E1CD66676208956B35357210C220508F9F883FE32F4D682CD36BFB4E8055938D4BA21C341D9F48527E420F951B80335B24DF6710F01C4364D554AF659FC35D322061B67CC2F303DC878076059E4F266CFAEF6AB7A29124E969B9C15B1FC2FBA0F0F90E6B059E36B5E3C9BEC4174162689108A1E0EF6D5DDEE61B6B48327A259746288A517B1D78A0E24F5EFF6E880FF39C0BEDDC464B66F787B559EC5487F248196C2CFB15730BD9695C48355DFB2839FA23D8A37FBD48C741F6BE19F9D48BF844C5147591E1E06803DA40BEA1186B3B39CDCBC0E7DAC9DACDBB60A20E56B7E6631E47A45989A256743FDD83C591CFD4110DEA1B04ADE91CCB575FB858C13
 pkey[1]: 010001
 skey[2]: 512FB977EB9872FECA8BDB96884A01A6AB2B7575D307B9ED4F55E777F2F55FBFFCBF4BF2D669D4D7F42CAC7C28F4ACC0ECEEF7B1D90E3D936850372352107F87E77E20A4D133C927F99FFD52277DEA17107BDA72A072AF950AB0B70023327E3B48D9CCB871237D3D6F6C9BA7FDB45AB46217E33FA01A8ED295795323E26505BC9471CAE4DDA94DBF4F35ED915B0CD025805DCA796EB6B208D8D3F63DBE52BC0045CF4CF9B128356359C7E55B661D7B9DCA57F8984095C5AD3FE4DBD19228B281D66609A154DD7E3EE940CFC66CC180DDC4DD00C45A52D5789286D89D49CA34E5F3C4E798D90955074DAE3D99F7F004CDFFBC9B8428E8EB603E240AE07BEE8D71
 skey[3]: F57D9F597750967DF272D9AC661DDC212D7C5CA4C6E91573A80756281351CDC3A2532B155D9251029F89A0A0807DF2BD177DC30FC6A847E07738B55606DF032ADAD8361E0AFEE9C0CF7D566793834977FAAE9C4B87132B94F665EFF463777CDE7EB89113FA3AAC194B6F2D30C40BE7C0DDE36A5855277C1E4D0204FC4C737BCB
 skey[4]: C4B135296B8F4390B953DDA84249FC8467CFF81FC715D1B5F3E01FCC8DC770813630AEA93982F2004705C4D272E07A10B1882AC5C09A45E88B14A1446B4C639B549420CE3BF90947E6E86503E426A8FDAC4C5CFC2809F5F0A1647ED5EE2457C054A40AA1F0666B28B2C970BE2093AE7B095A688B2D713CA8885826F23AFB37D9
 skey[5]: 0790A8E260C6CADC353FB3961D798EFD4F15F96752DA20B86841334C38861743DD7A1FEB2B750D0864F5901BE541B6C8FB63649B18FDC4A32A1233EF90872DCD35704A4B4063DB62752CF6A7FD00F086C6B1042A2B0CB6FB36B7D5269671DACF55242A838E60D514BA868354910CEB1C41FB9A43BF932B5036A6EFE35236FFC7
May 29 2024, 9:40 AM · OpenPGP, Not A Bug, gnupg
werner triaged T7136: libgcrypt: Implement constant-time RSA decryption (Marvin attack fix) as Low priority.

We discussed this forth and back with the RedHat people at our jour-fix to explain that the Kairo fix is done at the wrong layer - this needs to be done at the protocol layer and not in the building blocks. This is not covered by our security policy and @gniibe already came up with some extra support to help at the protocol layer. There are only a few use cases where this side-channel or the Minerva one (for ECDSA) should be considered (e.g. time stamping services). Generally required protection against DoS are also pat of the mitigation.

May 29 2024, 8:22 AM · libgcrypt, Bug Report

May 28 2024

werner moved T7129: Fix static reports by static analyser in gnugp from Backlog to WiP on the gnupg24 board.
May 28 2024, 5:20 PM · gnupg22 (gnupg-2.2.44), gnupg24 (2.4.6), Bug Report
werner added a comment to T7129: Fix static reports by static analyser in gnugp.

All except the above mentioned applied to master - will be backported to 2.4

May 28 2024, 5:20 PM · gnupg22 (gnupg-2.2.44), gnupg24 (2.4.6), Bug Report
werner added a comment to T7129: Fix static reports by static analyser in gnugp.

In PATCH GnuPG 12/15] sm: Avoid use of uninitialized variable I can't see where ERR was not initialized.

May 28 2024, 5:19 PM · gnupg22 (gnupg-2.2.44), gnupg24 (2.4.6), Bug Report
werner committed rG9adaa79ab43e: gpg-auth: Fix use after free. (authored by Jakuje).
gpg-auth: Fix use after free.
May 28 2024, 5:18 PM
werner committed rGdcb0b6fd4822: gpgsm: Avoid double free when checking rsaPSS signatures. (authored by Jakuje).
gpgsm: Avoid double free when checking rsaPSS signatures.
May 28 2024, 5:18 PM
werner committed rG28c705a3be5c: gpgsm: Silence a lint warning (authored by werner).
gpgsm: Silence a lint warning
May 28 2024, 5:18 PM
werner committed rG379fc5569d60: agent: Avoid uninitialized access in GENKEY command on parameter error. (authored by Jakuje).
agent: Avoid uninitialized access in GENKEY command on parameter error.
May 28 2024, 5:18 PM
werner committed rG4c1b0070354d: scd: Avoid buffer overrun with more than 16 PC/SC readers. (authored by Jakuje).
scd: Avoid buffer overrun with more than 16 PC/SC readers.
May 28 2024, 5:18 PM
werner committed rGbdbf5cee2ff5: agent: Avoid double free of empty string in the PIN caching. (authored by werner).
agent: Avoid double free of empty string in the PIN caching.
May 28 2024, 5:18 PM
werner committed rGfdc500395640: agent: Make sure to return success in ephemeral store mode. (authored by werner).
agent: Make sure to return success in ephemeral store mode.
May 28 2024, 5:18 PM
werner committed rG021c27510b52: wks: Make sure that ERR is always initialized. (authored by werner).
wks: Make sure that ERR is always initialized.
May 28 2024, 5:18 PM
werner committed rGbcc002cd45d1: gpg: Avoid a double free on error in the key generation. (authored by werner).
gpg: Avoid a double free on error in the key generation.
May 28 2024, 5:18 PM
werner added a comment to T7129: Fix static reports by static analyser in gnugp.

I do not understand why there should be an integer overflow:

May 28 2024, 4:10 PM · gnupg22 (gnupg-2.2.44), gnupg24 (2.4.6), Bug Report
werner committed rGd631c8198c25: tpm: Improve error handling and check returned lengths. (authored by werner).
tpm: Improve error handling and check returned lengths.
May 28 2024, 1:32 PM
werner committed rG2e4b1f785055: tpm: Do not use fprintf for logging. (authored by werner).
tpm: Do not use fprintf for logging.
May 28 2024, 1:32 PM
werner assigned T7130: Fix static reports by static analyser in libgcrypt to gniibe.
May 28 2024, 11:08 AM · libgcrypt, Bug Report
werner raised the priority of T7129: Fix static reports by static analyser in gnugp from Normal to High.
May 28 2024, 11:08 AM · gnupg22 (gnupg-2.2.44), gnupg24 (2.4.6), Bug Report
werner raised a concern with rE8dc6e3281e17: Import spawn functions from GnuPG master..
May 28 2024, 9:00 AM

May 27 2024

werner added a comment to T7134: Kleopatra: Allow PIN reset with Admin-PIN.

For OpenPGP cards >= v2.0 there is no PUK due to updated ISO standards but we use the term in Kleopatra for the Reset-Code.

May 27 2024, 1:42 PM · gpd5x (gpd-5.0.0), Feature Request, kleopatra
werner added a comment to T6481: BEGIN_ENCRYPTION status output happens later in 2.4.1 (breaks Emacs's EasyPG).

This is not a bug. We changed it as a convenience for some Emacs users.

May 27 2024, 8:26 AM · Emacs, gnupg, Bug Report

May 23 2024

werner triaged T7103: Confusing error message when changing passphrase/password of subkey as Normal priority.
May 23 2024, 4:51 PM · gnupg26, Feature Request
werner triaged T7131: Kleopatra: Make copying subkey fingerprints w/o spaces possible as Normal priority.
May 23 2024, 4:50 PM · kleopatra, Restricted Project
werner triaged T7133: Add feature to load designated revoker from LDAP as Normal priority.
May 23 2024, 12:01 PM · backport, vsd34, Feature Request, gnupg22
werner added a comment to T6481: BEGIN_ENCRYPTION status output happens later in 2.4.1 (breaks Emacs's EasyPG).

Sorry, no. The change is too large to back port it w/o risking a regression. As mentioned in T6481#170366 I don't consider this a bug. We are anyway working towards version 2.6 which will be the next LTS version.

May 23 2024, 9:04 AM · Emacs, gnupg, Bug Report

May 22 2024

werner changed the status of T6881: Kleopatra: Make designated revoker configurable for new keys from Testing to Open.

Although it is implemented in gnupg-2.2 we should add another feature: Iff this option is configured, gpg shall try to load the requested key from LDAP in the same manner as it does for a trusted-key.

May 22 2024, 6:23 PM · kleopatra
werner added a comment to T6882: Make ADSK configurable for new keys.

This should not be configured in Kleopatra but an option to gpg because this is a core crypto functionality. Thus is now a gpg task.

May 22 2024, 6:20 PM · gnupg24 (2.4.6), gnupg22 (gnupg-2.2.45)
werner renamed T6882: Make ADSK configurable for new keys from Kleopatra: Make ADSK configurgurable for new keys to Make ADSK configurgurable for new keys.
May 22 2024, 6:18 PM · gnupg24 (2.4.6), gnupg22 (gnupg-2.2.45)
werner committed rCeca1ed096038: build: Minor updates (authored by werner).
build: Minor updates
May 22 2024, 4:16 PM
werner committed rC9bea69896397: Prepare NEWS for 1.11 (authored by werner).
Prepare NEWS for 1.11
May 22 2024, 3:18 PM
werner committed rG610a452bb5c3: scd:openpgp: Add new vendor. (authored by werner).
scd:openpgp: Add new vendor.
May 22 2024, 11:22 AM
werner committed rGcdc798db5c6b: tools: Fix help output for gpg-authcode-sign.sh (authored by werner).
tools: Fix help output for gpg-authcode-sign.sh
May 22 2024, 11:22 AM

May 21 2024

werner committed rO7624bd4aa1d7: build: Update autogen.sh and autogen.rc to a modern version. (authored by werner).
build: Update autogen.sh and autogen.rc to a modern version.
May 21 2024, 5:45 PM
werner committed rOa1228fdfd043: build: Update libassuan.m4 to 2023-07-26 and gpgrt to 2023-04-01 (authored by werner).
build: Update libassuan.m4 to 2023-07-26 and gpgrt to 2023-04-01
May 21 2024, 5:45 PM
werner committed rWdc4c9cdea3c9: build: Improve option handling of gen-tarball.sh (authored by werner).
build: Improve option handling of gen-tarball.sh
May 21 2024, 5:01 PM
werner committed rWb7c11272e6ea: Remove not anymore required patches. (authored by werner).
Remove not anymore required patches.
May 21 2024, 3:23 PM
werner committed rW79820895191d: Update gpgme to a 1.24.0-beta566 (authored by werner).
Update gpgme to a 1.24.0-beta566
May 21 2024, 3:23 PM
werner committed rMac4bf86bb65a: tests: Fix segv in t-json.c (authored by werner).
tests: Fix segv in t-json.c
May 21 2024, 2:35 PM
werner committed rM55a1ae4163ec: tests: Avoid some compiler warnings. (authored by werner).
tests: Avoid some compiler warnings.
May 21 2024, 1:44 PM
werner committed rC187575844015: mpi: Fix loop condition in bad point check. (authored by Jakuje).
mpi: Fix loop condition in bad point check.
May 21 2024, 11:52 AM
werner added a comment to T7130: Fix static reports by static analyser in libgcrypt.

Well, but if the padding is indeed limited to 7 bytes the fix should be applied anyway.

May 21 2024, 11:46 AM · libgcrypt, Bug Report
werner triaged T7130: Fix static reports by static analyser in libgcrypt as Normal priority.
May 21 2024, 11:45 AM · libgcrypt, Bug Report
werner added a comment to T7130: Fix static reports by static analyser in libgcrypt.

Can you give a hint where there is a buffer overrun in the first patch? Padding limit might be correct but I can't see an overrun.

May 21 2024, 11:31 AM · libgcrypt, Bug Report
werner edited projects for T7129: Fix static reports by static analyser in gnugp, added: gnupg24; removed gnupg24 (gnupg-2.4.4).
May 21 2024, 11:20 AM · gnupg22 (gnupg-2.2.44), gnupg24 (2.4.6), Bug Report
werner triaged T7129: Fix static reports by static analyser in gnugp as Normal priority.

Thanks for running the analyzer. We need to have a closer look at the suggested fixes. For example initializing a variable needs a reason and should not be done as a general precaution because that may hide other errors.

May 21 2024, 11:19 AM · gnupg22 (gnupg-2.2.44), gnupg24 (2.4.6), Bug Report
werner moved T6369: gpgme: add a faster variant of gpgme_get_key() from Backlog to QA for next release on the gpgme board.
May 21 2024, 11:08 AM · gpgme, Feature Request
werner committed rM73403a8ba003: core: speedup gpgme_get_key (authored by werner).
core: speedup gpgme_get_key
May 21 2024, 11:05 AM

May 18 2024

werner triaged T7123: please document --unwrap as Low priority.
May 18 2024, 11:31 PM · gnupg, Documentation, Bug Report
werner added a comment to T7124: unclear descriptions of `--disable-cipher-algo` and `--disable-pubkey-algo` .

Back in the ancient days we allowed to dlopen algorithms so to avoid patent problems in certain countries.

May 18 2024, 11:30 PM · gnupg, Documentation, Bug Report
werner triaged T7124: unclear descriptions of `--disable-cipher-algo` and `--disable-pubkey-algo` as Low priority.
May 18 2024, 11:29 PM · gnupg, Documentation, Bug Report
werner added a comment to T6634: Port GPGME to Windows 64-bit.

Actually we are using gpgme already for 64 bit Windows; but statically linked.

May 18 2024, 11:28 PM · Windows 64, gpgme

May 17 2024

werner committed rC903a2c2ea068: doc: Update copyright notices (authored by werner).
doc: Update copyright notices
May 17 2024, 12:19 PM
werner committed rC0526d65afd34: build: Remove cruft from configure.ac (authored by werner).
build: Remove cruft from configure.ac
May 17 2024, 12:19 PM
werner created vsd33 (vsd-3.3.0).
May 17 2024, 10:18 AM

May 16 2024

werner committed rG287e717b55d2: Merge branch 'STABLE-BRANCH-2-4' into master (authored by werner).
Merge branch 'STABLE-BRANCH-2-4' into master
May 16 2024, 9:49 AM
werner closed T7120: Ship dutch translation (po/po.nl) in released tarball as Resolved.

Pretty outdated, but I add it nevertheless to 2.4
s/gnupg-2.4/po/nl.po: 1320 translated messages, 625 fuzzy translations, 268 untranslated messages.

May 16 2024, 9:35 AM · i18n, gnupg, Bug Report
werner committed rG758cd4ccfc11: po: Enable Dutch translation (authored by werner).
po: Enable Dutch translation
May 16 2024, 9:34 AM
werner committed rG7f661aa129fd: kbx: Use standard function to setup gcrypt logging in kbxutil. (authored by werner).
kbx: Use standard function to setup gcrypt logging in kbxutil.
May 16 2024, 9:34 AM
werner committed rG5355d0885512: card: Fix compiler warning. (authored by werner).
card: Fix compiler warning.
May 16 2024, 9:34 AM

May 15 2024

werner committed rG3bbfcab606bf: Update NEWS (authored by werner).
Update NEWS
May 15 2024, 12:30 PM
werner added a comment to T6185: `gpg2 --list-keys --with-colons > /dev/full` exits with status 0.

Done for gpg. Needs to be done for gpgsm.

May 15 2024, 9:57 AM · Bug Report, gnupg
werner committed rGb36e557c5b05: gpg: Terminate key listing on output write error. (authored by werner).
gpg: Terminate key listing on output write error.
May 15 2024, 9:57 AM

May 13 2024

werner accepted D570: core: Implement adding ADSKs.

Looks good to me. Thanks.

May 13 2024, 12:18 PM
werner committed rW9ecd1cdceed4: build-aux: Fix recently introduced syntax error in a script. (authored by werner).
build-aux: Fix recently introduced syntax error in a script.
May 13 2024, 11:38 AM
werner added a project to T6354: All VSD and GPD binaries need a proper product name on Windows.: vsd33.

Please, we need a fix here for 3.3.

May 13 2024, 9:12 AM · gpd5x, vsd, kleopatra, gpd
werner committed rW09f34796b2e4: packages: Use 24.05 branch of kleopatra (authored by werner).
packages: Use 24.05 branch of kleopatra
May 13 2024, 9:01 AM
werner triaged T7115: gpgsm: support for importing x25519 and ed25519 private keys from .p12 files as Normal priority.
May 13 2024, 8:32 AM · S/MIME, gnupg26, Feature Request
werner added a comment to T7116: minor spelling fixes.

I still spotted a grammar glitch in corrections. Thus if we apply this we need to proofread it.

May 13 2024, 8:29 AM · gnupg, Bug Report

May 12 2024

werner edited projects for T7115: gpgsm: support for importing x25519 and ed25519 private keys from .p12 files, added: Feature Request, gnupg26, S/MIME; removed Bug Report.

Yes, I think we should support this. Also X448. Thanks for the report and the samples.

May 12 2024, 10:42 PM · S/MIME, gnupg26, Feature Request
werner closed T2190: No custom Icon shown for signed only messages as Resolved.
May 12 2024, 2:36 PM · Too Old, Bug Report, gpgol
werner added a project to T7114: AM_PATH_LIBGCRYPT does not use gpgrt-config without AM_PATH_GPG_ERROR: gpgrt.

I noticed this recently too on some boxes. Thanks for the good decription. This support for pkg-config style .pc files for our config scripts seems to be a never ending story. The alternative name for libgpg-error-config does not make it easier.

May 12 2024, 2:29 PM · gpgrt, libgcrypt, Bug Report

May 8 2024

werner closed T6511: EdDSA support in FIPS mode as Resolved.
May 8 2024, 8:32 AM · FIPS, libgcrypt, Bug Report
werner added projects to T7112: gpg fails on Windows when specifying absolute homedir with drive letter: Windows, gnupg.

pwd is not a standard Windows command. It is availabe in powershell but there I get

May 8 2024, 8:28 AM · gnupg, Windows, Bug Report

May 7 2024

werner added a comment to T6511: EdDSA support in FIPS mode.

Can we close this?

May 7 2024, 2:44 PM · FIPS, libgcrypt, Bug Report
werner committed rCb99952adc6ee: Fix building error with '-O2' in sysroot path (authored by simit.ghane).
Fix building error with '-O2' in sysroot path
May 7 2024, 12:15 PM
werner committed rC1689d143b413: doc: Add some comments to gcrypt.h (authored by werner).
doc: Add some comments to gcrypt.h
May 7 2024, 12:14 PM

May 6 2024

werner added a comment to D600: posix: don't use LFS64 types in struct linux_dirent64.

Breaks them how?

May 6 2024, 3:17 PM · gpgme
werner committed rG97b37db144da: gpg,gpgsm: Remove compatibility_flags allow-ecc-encr and vsd-allow-encr. (authored by werner).
gpg,gpgsm: Remove compatibility_flags allow-ecc-encr and vsd-allow-encr.
May 6 2024, 2:34 PM
werner committed rG351fc6e6fa65: gpg: Algo "kyber" is now a shortcut for ky768_bp256. (authored by werner).
gpg: Algo "kyber" is now a shortcut for ky768_bp256.
May 6 2024, 10:46 AM
werner committed rG473f37a53ef4: scd:piv: Support listing of retired keys with KEYINFO. (authored by werner).
scd:piv: Support listing of retired keys with KEYINFO.
May 6 2024, 9:55 AM
werner requested changes to D600: posix: don't use LFS64 types in struct linux_dirent64.

This breaks existing 32 bit systems with the 64 bit types. Thus a test for off64_t is required which redefines it to int64_t if it does not exist.

May 6 2024, 9:52 AM · gpgme

May 5 2024

werner added a member for Contributor: ffontaine.
May 5 2024, 6:04 PM

May 3 2024

werner added a comment to T6799: Kleopatra configuration files in wrong places.

Let me remark, that we don't need a general migrator. We only need to make sure that the kleogroups are somehow migrated. Maybe we should do this along with the change of these group files (signing, v5 fingerprints). In any case it is important to get this into vsd33

May 3 2024, 4:03 PM · gpd5x (gpd-5.0.0), kleopatra

May 2 2024

werner committed rG467239dccbf9: speedo: Update the instructions to use the gnupg26 tag. (authored by werner).
speedo: Update the instructions to use the gnupg26 tag.
May 2 2024, 9:42 PM
werner committed rGf415d96facd3: gpg: Add a notation to Kyber encryption subkeys (authored by werner).
gpg: Add a notation to Kyber encryption subkeys
May 2 2024, 9:42 PM

May 1 2024

werner closed T7066: Communication with Yubikey hangs in scdaemon as Resolved.

Seems it was a kernel / USB bug

May 1 2024, 7:55 PM · Arch, yubikey, Bug Report

Apr 30 2024

werner added a comment to T6808: Libkleo Keyresolver: misleading display/wording in confirmation dialog.

RL discussion result:

Apr 30 2024, 3:56 PM · vsd33 (vsd-3.3.0), kleopatra, Restricted Project