Looks good to me on gpg4win-5.0.2-beta2 @ win11:

@ikloecker said (paraphrased by me):

Looks good to me on gpg4win-5.0.2-beta2 @ win11.

Looks good to me on gpg4win-5.0.2-beta2 @ win11:

The case above shows the case where the public key for the imported secret key was in the keyring beforehand.
We'll assume that this is something which would probably not occur in real life and don't explicitly handle this.

Looks good to me on gpg4win-5.0.2-beta2 @ win11:

Fixed.

Looks good to me on gpg4win-5.0.2-beta2 @ win11:

All tables should now have a context menu which offers at least the Copy action (with "Copy cell contents to clipboard" as tool tip).

Looks good to me on gpg4win-5.0.2-beta2 @ win11.

Regarding the order of items on the page: It is basically the same order, but the frame for the encryption settings improves the overview.

Debugview:

As far as I remember this is the intended behavior.

Looks good to me on gpg4win-5.0.2-beta2 @ win11:

The missing signature was a problem on my end. The customer mail (to ted / exchange server) works fine if the cert is in the keyring. The testmails (via outlook imap) are fine, too. I still need a better test setup for mails to our exchange accounts, but this is enough to rule out a problem in gpgol. I adjust my former message accordingly.

Tested with gpg4win-5.0.2-beta-2 @ win11.

Hmm ich sehe weiterhin die Signatur.

Tested with Gpg4win-5.0.2-beta2

Looks good to me on gpg4win-5.0.2-beta2 @ win11 (although there might unrelated issues, see notes in the end).
Tests of all messages generated by create-test-data.sh:

Looks good to me on gpg4win-5.0.2-beta2 @ win11:

Looks good to me on gpg4win-5.0.2-beta2 @ win11 (tested via config file and registry)

Looks good to me on gpg4win-5.0.2-beta2 @ win11:

This ticket has been superseded by T7971: Kleopatra: Always use gpgme to find the GnuPG binaries. All changes have been reverted.

This is the dialog window which comes up when importing a team key with the group flag:

Looks good to me on gpg4win-5.0.2-beta2 @ win11:

Looks good to me on gpg4win-5.0.2-beta2 @ win11.

I looked at sm/keydb.c:keydb_set_ephemeral function. It says:

tested with Gpg4win-5.0.2-beta2

I don't really know what you are testing, but as far as I understood the (overly verbose [sigh]) comments the only thing that was implemented is that temporary files are removed when our mail viewer is closed properly. Removing temporary files/folders left over on a crash or reboot or any other forceful termination of the mail viewer or kleopatra would be covered by the already mentioned T6842: Kleopatra: Clean up temporary files on windows.

In this comment above T6793: Cleanup temporary files / dirs with decrypted content another issue was created for this: T6842: Kleopatra: Clean up temporary files on windows
I'm not sure what to expect, before this is implemented, so I just documented it here.

I found out, that successful notepad pgp encryption/signature never had an audit log button (it's also like this in gpg4win-4.4.1 and vsd-3.3.4).
So, everything fine here for gpg4win-5.0.2-beta2 @ win11, vsd still needs to be tested.

Suggestion: When Kleopatra starts up, it should just delete its Temp folder.

Looks good to me on gpg4win-5.0.2-beta2 @ win11:

In T7784#214660, @timegrid wrote:

Just to be sure: The "Show Email" button is still never shown on the notepad, right?

In T7784#214657, @timegrid wrote:

Issues found:

• pgp encrypt/sign does not offer an audit log, the first screenshot in the description ("verschlüsselt und signiert") suggests that this was different before

it was zsh

Not sure, which shell had problems, but it works on both zsh and bash with my last build gpg4win-5.0.1-beta24-x86_64.AppImage. So i guess, i can close this.

A different order is pretty much impossible to implement in upstream kconfig without big changes/refactoring.

Also done: The tab order for the close button is now correct.

Note: On gpg4win-5.0.1, there's also no audit log for notepad pgp sign/encrypt. So this is expected?

Looks good to me on gpg4win-5.0.2-beta2 @ win11.

Just to be sure: The "Show Email" button is still never shown on the notepad, right?

In general looks good to me on gpg4win-5.0.2-beta2 @ win11:

Looks good to me on gpg4win-5.0.2-beta2 @ win11:

• first manual gpg -K and gpgsm -K displays the correct output now
• the loop ran without a hang for 50 times

Looks good to me on gpg4win-5.0.2-beta2 @ win11:

Looks good to me on parallel install of

1. gpg4win-5.0.2-beta2 @ win11
2. vsd-4.0.0-beta1203 @ win11

Looks good to me on gpg4win-5.0.2-beta2 @ win11:

The registry keys "GnuPG Desktop" and "GnuPG VS-Desktop" now work correctly, i.e. existing registry keys should be considered in the next VSD 4 build.

There shouldn't be any RegCreateKey anymore for HKLM\SOFTWARE\<product name>\... or HKCU\SOFTWARE\<product name>\.... And, of course, no registry keys should be created.

In any case, the order still needs to be adjusted.
The current implementation is still (neither the order in the description nor on the settings page):

Seems to work in principle with gpg4win-5.0.2-beta2 and vsd-4.0.0-beta1203.
I'll wait for a new vsd beta release (with some fixes) for further testing.

with Gpg4win-5.0.2-beta2:

The missing signature indication can also be seen now in the customer mails sent via kmail (ted:INBOX, e.g. 18.02. 12:52). This was fine before.

Looks good to me on gpg4win-5.0.2-beta2 @ win11.
Tested import on 5 normal starts and 5 gdb starts.

The basic fix for the msg box looks good to me on gpg4win-5.0.2 (beta) @ win11.
There's only no signature shown anymore, not even for the formerly working case 1.
Note: I also tested those mails sent to an exchange server with the same result as via IMAP.

Looks like the "read config from registry" patch that was upstreamed wasn't tested properly.

Works with Gpg4win-5.0.2-beta2

Fixed.

Here's a full log of a gdb run, which segfaults on start:

full debugview log:

Please always attach the full Debugview log. Sometimes (like here) I really want to know everything that was logged since the start.

Fixed. This regression was caused by changes made for T8056: Support config options RSAKeySizes and PGPKeyType for Kf6.

In T8029#212310, @werner wrote:

My actual plan is to rework the imp[ort/export of secret keys to gpg-agent. Right now gpg-agent has knowledge of OpenPGP for import/export. This is not good and the required conversion should be moved to a helper tools for easier testing and to have this out of the gpg-agent process. For Kyber we right now don't use any conversion mut store the secret keys in gpg-agent's native format. Thus the passphrase is not necessary. We need to figure out why we have this problem here.

@werner said the reading order should be like on the page https://gnupg.com/vsd/kleopatra-settings.html:

Tested with Gpg4win 5.0.2 (Beta):
Registry settings SOFTWARE\Gpg4win\Kleopatra\<config group>\<config entry>
works (I used [CertificateCreationWizard] EMAIL_placeholder for testing)

This is not "Unbreak now" because we have not released the software yet. Unbreak now should be used for bugs in deployed software but not during development.

Note: This was fine on gpg4win-5.0.1

Regarding some broken "reg create" on some filepath: split into T8141: Kleopatra: Many wrong registry keys created in HKCU\Software\Gpg4Win

I rechecked the keyboxd locking of pubring.db. On crash via gdb the file was unlocked before, so this doesn't seem to be the problem: