Emanuel can you check if this is still the case with the current version? I
think it should still be the case as I have tried to leave this all intact.

But the problem is likely the same as for
http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgol.git;a=commit;h=1bab2eba47249b258759ad7d897ef96e76bb9557

And easy to fix.

Duplicate of T1826

Please try the latest 1.3.0 beta version which is available from:

https://wiki.gnupg.org/GpgOL/Development/Testversions

This version has experimental read support for PGP/MIME mails.

I'm closing this issue as a duplicate of T1826 which already tracks PGP-MIME
support in gpgol.

I have to check if this is possible (Depending on the parameters in the forward
reply events this could even be trivial)

You may want to try out the latest 1.3.0 Beta version which supports reading
PGP/MIME mails. See:

https://wiki.gnupg.org/GpgOL/Development/Testversions

I've just uploaded a Test Version of a new GpgOL and documented it under:
https://wiki.gnupg.org/GpgOL/Development/Testversions

While the main focus for that Testversion is MIME support I've also added a lot
of debug output in the functions you see crashing:

http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgol.git;a=commitdiff;h=7016fec9aef7be53f164829f7c76e28c6a83e228

If you are willing it would be a great help if you would install that version
and provide me with the gpgol debug log after you encounter the next crash.

They just might also be gone because of the changes mentioned in T1837 (aheinecke on Oct 13 2015, 12:06 PM / Roundup) but I
doubt it.

Thanks for your quick reponse.

Thanks for the info (and again apologies for your trouble)

btnDecryptLarge and btnDecrypt are also functions that only fetch resource data
like GetCustomUI. I don't understand why they would crash only some time and not
always.

From looking at the code the only possible problem I see is that an invalid
result pointer is passed to that function. There is not check for that. I'm
adding one.

With regards to getcustomui:

In the current mime-addin development branch I'm currently working on I have
modified the ribbon ui function to use a dynamically allocated string. But this
should not the problem because the locale strings should not change.

Another theory that I need to check is that the pointers to the localized string
I use there are not guaranteed to be valid when they are used in the sprintf
call. They should be, but maybe there is a problem with our gettext
implementation. So I'll reduce the lifetime of the pointers to the function call.

Just to give an update:

since June I had 24 messages of type without any encryption/decryption

Fehler bei der Ausführung des Add-Ins. Outlook ist während des Rückrufs
'GetCustomUI' der Schnittstelle 'IRibbonExtensibility' beim Aufrufen des Add-Ins
'GpgOL - The GnuPG Outlook Plugin' abgestürzt.

and one of the folling two

Fehler bei der Ausführung des Add-Ins. Outlook ist während des Rückrufs
'btnDecryptLarge' der Schnittstelle 'IRibbonControl' beim Aufrufen des Add-Ins
'GpgOL - The GnuPG Outlook Plugin' abgestürzt.

Fehler bei der Ausführung des Add-Ins. Outlook ist während des Rückrufs
'btnDecrypt' der Schnittstelle 'IRibbonControl' beim Aufrufen des Add-Ins 'GpgOL

• The GnuPG Outlook Plugin' abgestürzt.

No reply thus we assume everything is alright.

Hi, any plans for the next release?
Best regards
KJ

I can't reproduce this problem.

GpgOL tries to talk to Kleopatra through a file in %APPDATA%\gnupg

please make sure the permissions on this folder are correct. If you started
things with Administrator privileges before there might be files in there that
are only accessible for administrators and not with normal user rights.

So I'm going to wait for a new release with more tracing capabilites.
Thanks so far.
KJ

The Mail you show is a so called PGP/MIME mail.

We are well aware that GpgOL for Outlook 2010 and later versions only provides a
very basic OpenPGP support and no PGP/MIME Support. It is mentioned on the
website and in the documentation.

We are hoping to develop this but this is a huge Feature and very problematic to
implement given Outlook's extension API.

Wildly clicking around and changing components in GpgOL for quite some time I
was able to trigger this crash once (right before I was about to give up)

So there definitely is something here. Probably a threading / timing thing as it
is so hard to reproduce. Should not be though as all the extension code runs in
Outlooks main thread.

I've tried to reproduce it a second time but failed. Even with a script changing
components and opening encrypted mails in Outlook I was unable to reproduce it a
second time.

If I don't find more I'll add some more trace code in the debug output for a new
release. That should help us to at least tell us where it crashes in that function.

Hi,

since April there are 14 crashes recorded in windows event log, one occurred in
function btnDecryptLarge all others in function GetCustomUI.

It happens occasionally when changing between views. So it's not easy to
reproduce the behaviour. Even the log is not very useful because there are no
timestamps in the log entries to check it against windows event log.

There are other 6 active plugins installed.

If you need more info’s, please let me know.

KJ

This should work. GpgOL 2010 just queries the Plain Text from outlook and
encrypts that.

KMail (Which is my primary mail client and testing client) works fine with such
mails.

Robert, could you send an example mail created by GpgOL that kmail does not decrypt?

To: aheinecke@intevation.de

My keyid is: C97822F5

You can find it attached.

Appears to be working. I had no reports of more problems with Exchange domain
addresses since 1.2.1

Hi,
sorry for the late reply. Missed this report.

In your debug output I can see that GpgOL appears to cause the crash in the
GetCustomUI function.

This is a very simple and static function that is called very often.

Is this issue reproducable for you? What were you doing exactly when it crashed?

(From the debug output it looks like you've opened the Tasks view but this works
ok for me)

Do you have any other Addins installed in Outlook?

The support for OL2010 is pretty limited compared to what gpgol can do
with earlier versions. The Compendium also notes that you should not
use HTML mails. For example in 13.3 (German version):

  Es ist empfehlenswert, Ihr E-Mail-Programm so einzustellen, dass Sie
  E-Mails nur im "Text"-Format und *nicht* im "HTML"-Format
  versenden. Sollten Sie dennoch HTML für signierte oder
  verschlüsselte E-Mails verwenden, können dabei beim Empfänger die
  Formatierungsinformationen verloren gehen, was zum Bruch der
  Signatur führen kann.

Andre: Do you have time to look into this?

Hi Werner,

now I am confused as to what I just found on Wikipedia about "Gpg4win": http://de.wikipedia.org/wiki/PGP/MIME
Quotes from that page [translated to English]:
"PGP/MIME is – just as the old PGP/INLINE – an encoding to mark an email for mail clients [as encrypted]."

"Mail clients supporting that encoding can detect if an email and its attachments are encrypted and/or signed with PGP/GnuPG."

"With PGP/MIME it's possible to encrypt all attachments along with the message which is the default behavior." And which is
also a major usability improvement.

Because other mail clients (except for e.g. Kmail and probably some others, too) do not support that encoding yet comes the
quote that puzzled me:
"Government-funded by the German agency "Bundesamt für Sicherheit in der Informationstechnik" (BSI) the software Gpg4win was
published."

I'd like you to explain why you rated that bug low and talk it down when on the other hand GPG OL - which is shipped as part
of Gpg4win - is supposed to support that encoding type?

IMO that's a very strong hint for an incomplete feature or bug.

Has it something to do with closed-source Outlook itself and that GPG OL is not able to change the "Content-Type"? In that
case rating the bug down is no right as it would never get fixed anyways.

Regards
Robert

I'm sorry but that's just a poor excuse for several reasons:

• The security issues arising from HTML mails are a totally different attack vectors.
• Your claim that HTML messages would render encryption useless is wrong unless

there's a severe bug in the encryption/decryption algorithm, that triggers a buffer
overflow when reading the message's text.

• The purpose of encryption is to hide the message content while the mail is traveling

through the web.

• Encryption has got to be independent of the encrypted contents. Otherwise, following

your logic, you should drop encryption of attached ZIP, PDF, EXE, and whatever else
files.

As I said at the end of my first comment: I'd like to fund its fixing as that bug is a
real pain when it comes to interoperability across different OS-boxes/mail clients.

HTML mails are a severe security problem and may render the whole encryption
useless. Thus I downgrade this bug.

Yes, that's a confirmed workaround. However, sending HTML-Messages is important
to my business. So the bug remains.

Please disable "HTML and Text" and use "text only" For formatting thge mails.

Please find attached two encrypted mails sent via Kmail. Kmail can detect both as
PGP-encrypted even the "Inline-OpenPGP" formatted one. There must be some
critical difference to encrypted mails received from Outlook with GPG OL that
cause outlook mails not to be detected as encrypted.

This should have been resolved a long time ago. There was a KDE bug about this
but I can't find it anymore.

Thanks for the feedback!

Not sure but everything seems to be working in the 2.2.2-beta relase.

Should be fixed in 1.2.1 (part of gpg4win-2.2.2-beta)

Are you sure that the case sensitivity was the problem here and not the general
Problem that Exchange Addresses were not looked up correctly?

It would be helpful if you could test this with gpgol 1.2.1 (part of
gpg4win-2.2.2-beta) if this is still an issue I'll look into it.

Hi Jon,
can you check this please with the current gpg4win-2.2.2 beta? I've fixed some
object resolution bugs there when Sender / Recipient addresses were not SMTP only.

Thanks

This should be working with gpgOl 1.2.1

As I don't have a test set up I'm setting this to resolved until someone complains.

your debug output points to the same issue that was fixed recently in gpgol
1.2.1 relating to address lookup in Outlook (part of gpg4win-2.2.2-beta)

Please try this version.

Nope; won't be done. We had this in the past and people enabled it and later
complained about disk full stati. And yes, it exposes confidential info.