In T5189#140669, @gniibe wrote:

Reviewed D517 and pushed it as rE621446d3c859: po: Update Traditional Chinese Translation..

gniibe received another patch from Debian.

For D515, I think that there is similar issue, and I received another patch from Debian.

Reviewed D517 and pushed it as rE621446d3c859: po: Update Traditional Chinese Translation..

I did editorial change for meta data.
Also, I fixed the translation of "out of core", even if it's unused (it's comment).

GnuPG requires some C99 features - thus a language level of C89 might not work. We use variadic macros and the func macro. For details see doc/HACKING.

OS:AIX , Compiler: XLC

In D517#4833, @bobwxc wrote:

In D517#4831, @chyen wrote:

Thanks a lot for the translations! However, some terms appear to be translated from Simplified Chinese. Here are some suggestions:
...

Got that, thank you :-)
Any other suggestion?

In D517#4831, @chyen wrote:

Thanks a lot for the translations! However, some terms appear to be translated from Simplified Chinese. Here are some suggestions:
...

Got that, thank you :-)
Any other suggestion?

Thanks a lot for the translations! However, some terms appear to be translated from Simplified Chinese. Here are some suggestions:

Pushed the change for libgpg-error zh_CN.po.

For PO file editing, what I use (for Japanese Translation) is:

• Emacs PO mode: https://www.emacswiki.org/emacs/PoMode

There are actually tools for PO file editing:
http://docs.translatehouse.org/projects/localization-guide/en/latest/guide/tools/trans_editors.html

use poedit to rebuild it

I think that you don't use PO editor. I'm going to remove mark like ", fuzzy", which should be removed when entering good entry.

Thank you for your effort. I'll review.

The patch will be in 2.2.27. Thanks.

Simply add -v or --verbose to the gpg invocation too see infos about the pinentry. --debug-level is not helpful here.
And well, we don't have a way to test stuff on Vista anymore. You should also update to at least Windows 7.

patch of libgpg-error/po/zh_CN.po
D516: po: Update simplified Chinese translation po/zh_CN.po

Good catch. This is due to back porting a change from master. However the extra introduced conditional of

if (sig->version >=4)

will always evaluate to true. It is set a bit above and GnuPG does not handle public key packets with version 3 anymore. So this if can actually be removed. Thus no harm.

Please provide detailed information about the build peoblem. An arbitrary paste from a build does not make up a bug report. If you need support building GnuPG you may want to look for a commercial offer or to ask on a mailing list. From what I see I assume you have an incomplete installation of the supporting libraries.

In T5189#140595, @gniibe wrote:

Please note that many error messages are defined in: https://dev.gnupg.org/source/libgpg-error/browse/master/po/zh_CN.po
and https://dev.gnupg.org/source/gnupg/browse/master/po/zh_CN.po

Sorry, in case you already know that.

May I ask that how to get a new complete clean po file.
I'm not familiar with gettext.
The old one is confusing, and I think maybe I should completely clean the messy.
Really a big project.

Frankly, I more or less forgot about these help files. The German version for sure needs an update as weel.

In T5189#140595, @gniibe wrote:

Please note that many error messages are defined in: https://dev.gnupg.org/source/libgpg-error/browse/master/po/zh_CN.po
and https://dev.gnupg.org/source/gnupg/browse/master/po/zh_CN.po

Sorry, in case you already know that.

In T5189#140594, @gniibe wrote:

For D515, I will also apply it to master.

Before that, I'd like to confirm an editorial change of mine:

• Remove an extra space before new line (two places)

Please and thanks, I imitated the English edition format :-)

• Remove a comment for use case of the file
  • If needed, we could have support of another locale(s) with Chinese language: zh_HK, zh_SG, etc.
  • It is not us, but it's users who decide which locale is better for them
    • E.g., my friend in Düsseldorf uses ja_JP locale
  • So, it's technically better not to address restriction in a translation

for that, I think you best keep that.
Use a locale to distinguish Chinese users always cause problems.
There isn't a big difference between the written language. And small region always lack translations.
Singapore's users who use simplified Chinese always use zh_CN if there is no a specific zh_SG.
And the traditional Chinese users from HK SAR and MC SAR sometimes use the translation for Taiwan Province.
So when translate it, the tip remiand you must consider all the users from anywhere.

Please note that many error messages are defined in: https://dev.gnupg.org/source/libgpg-error/browse/master/po/zh_CN.po
and https://dev.gnupg.org/source/gnupg/browse/master/po/zh_CN.po

For D515, I will also apply it to master.

Thank you for your review!
:-)
And how to mark this revision passed?

Applied D514 to master, with an editorial change (removing extra space before newline).

Already have set another, thanks gnibe! See ya!

Please change your passphrase for your card, BTW.

Good. The error recovery worked well.

Applied to s390x optimizations feature branch:
https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgcrypt.git;a=commit;h=7532e27cacb74c92fd561524a0897163b0fcd7f4

Applied to s390x optimizations feature branch:
SHA256: https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgcrypt.git;a=commit;h=0b555c3cc7c2b80ec2628685946a6139a1996911
SHA512: https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgcrypt.git;a=commit;h=45f0ec0c4e3b08627cbf7e65f5f110c321710d01

Applied to s390x optimizations feature branch:
https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgcrypt.git;a=commit;h=88570515b4ca92a44c4e40c31f877c11cc00ab68

Applied to s390x optimizations feature branch:
https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgcrypt.git;a=commit;h=5aeb091f911398217b2e9facb9bdeb05c63d7844

Applied to s390x optimizations feature branch:
https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgcrypt.git;a=commit;h=9219d9d1b60c01a4c7dbde05ee6b5b52e0d7d072

In Chinese, “密钥” make a general reference to secret keys, public keys and key-pairs, it has a broad meaning.

Implemented stitched ChaCha20-Poly1305 (vector ChaCha20 & ALU Poly1305). Unfortunately performance is less than OpenSSL (vector ChaCha20 & vector Poly1305). Instruction latencies make Poly1305 slower than combined OpenSSL ChaCha20+Poly1305, thus it is not possible to reach same performance with stitching. Vector Poly1305 implementation is therefore needed.

Currently have 8 block parallel implementation done. Need to check if 6 block parallel approach is better (as used in OpenSSL - benefit being less register pressure and less moving of data between registers and stack).

Thanks for reporting this. You are correct, those HWCAP2_SHA1 and HWCAP2_SHA2 defines are wrong.

Translation of "key" is difficult in our context of public key cryptography.
In many case "key" just refers public key, but for key generation, it means key pair.

Granted I'm not familiar with the functions and it may not be applicable, but the DNS resolver functions in the GNU C Library have semi-recently gained parameters (RES_USE_DNSSEC) to check for DNSSEC validation IIRC. Recent versions of glibc also don't trust the 'ad' bit unless an indication of its trustworthiness is set in /etc/resolv.conf, say if using a local validating resolver, so one can be sure that it's trustworthy. It also appears musl libc may support this.

Thanks, appreciated.

You are lucky. The report came just in time for the 2.2.26 released. Not mentioned over thre but anyway fixed. See T5153