- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jun 28 2021
Fixed as discussed.
Thanks for reporting. There is two commits in that commit range, including https://dev.gnupg.org/rC9d909cb67e70fd792926ac1e2ab305b2cc96bc27 which adds fast reduction for NIST curves. So obviously something is wrong there. Is secp192r1 only curve that is giving wrong results?
I have received a convincing report that Kleopatra crashes when encrypting or decrypting Folder structures > 30GB. So I need to at least test this, too.
test-stubs.c:374:1: note: 'show_photos' was previously declared here keyserver-internal.h:35:24: warning: type of 'parse_keyserver_uri' does not match original declaration [-Wlto-type-mismatch] 35 | struct keyserver_spec *parse_keyserver_uri (const char *string, | ^ test-stubs.c:356:1: note: type mismatch in parameter 3 356 | parse_keyserver_uri (const char *uri, int require_scheme, | ^ test-stubs.c:356:1: note: 'parse_keyserver_uri' was previously declared here keyserver-internal.h:60:5: warning: type of 'keyserver_import_ldap' does not match original declaration [-Wlto-type-mismatch] 60 | int keyserver_import_ldap (ctrl_t ctrl, const char *name, | ^ test-stubs.c:243:1: note: type mismatch in parameter 2 243 | keyserver_import_ldap (const char *name) | ^ test-stubs.c:243:1: note: 'keyserver_import_ldap' was previously declared here keyserver-internal.h:57:5: warning: type of 'keyserver_import_name' does not match original declaration [-Wlto-type-mismatch] 57 | int keyserver_import_name (ctrl_t ctrl, | ^ test-stubs.c:224:1: note: type mismatch in parameter 3 224 | keyserver_import_name (const char *name,struct keyserver_spec *spec) | ^ test-stubs.c:224:1: note: 'keyserver_import_name' was previously declared here keyserver-internal.h:50:5: warning: type of 'keyserver_import_cert' does not match original declaration [-Wlto-type-mismatch] 50 | int keyserver_import_cert (ctrl_t ctrl, const char *name, int dane_mode, | ^ test-stubs.c:205:1: note: type mismatch in parameter 2 205 | keyserver_import_cert (const char *name) | ^ test-stubs.c:205:1: note: 'keyserver_import_cert' was previously declared here keyserver-internal.h:44:5: warning: type of 'keyserver_import_keyid' does not match original declaration [-Wlto-type-mismatch] 44 | int keyserver_import_keyid (ctrl_t ctrl, u32 *keyid, | ^ test-stubs.c:184:1: note: type mismatch in parameter 3 184 | keyserver_import_keyid (u32 *keyid, void *dummy, unsigned int flags) | ^ test-stubs.c:184:1: note: 'keyserver_import_keyid' was previously declared here photoid.h:31:6: warning: type of 'show_photos' does not match original declaration [-Wlto-type-mismatch] 31 | void show_photos (ctrl_t ctrl, const struct user_attribute *attrs, int count, | ^ test-stubs.c:374:1: note: type mismatch in parameter 2 374 | show_photos (const struct user_attribute *attrs, int count, PKT_public_key *pk) | ^ test-stubs.c:374:1: note: 'show_photos' was previously declared here keyserver-internal.h:35:24: warning: type of 'parse_keyserver_uri' does not match original declaration [-Wlto-type-mismatch] 35 | struct keyserver_spec *parse_keyserver_uri (const char *string, | ^ test-stubs.c:356:1: note: type mismatch in parameter 3 356 | parse_keyserver_uri (const char *uri, int require_scheme, | ^ test-stubs.c:356:1: note: 'parse_keyserver_uri' was previously declared here keyserver-internal.h:60:5: warning: type of 'keyserver_import_ldap' does not match original declaration [-Wlto-type-mismatch] 60 | int keyserver_import_ldap (ctrl_t ctrl, const char *name, | ^ test-stubs.c:243:1: note: type mismatch in parameter 2 243 | keyserver_import_ldap (const char *name) | ^ test-stubs.c:243:1: note: 'keyserver_import_ldap' was previously declared here keyserver-internal.h:57:5: warning: type of 'keyserver_import_name' does not match original declaration [-Wlto-type-mismatch] 57 | int keyserver_import_name (ctrl_t ctrl, | ^ test-stubs.c:224:1: note: type mismatch in parameter 3 224 | keyserver_import_name (const char *name,struct keyserver_spec *spec) | ^ test-stubs.c:224:1: note: 'keyserver_import_name' was previously declared here keyserver-internal.h:50:5: warning: type of 'keyserver_import_cert' does not match original declaration [-Wlto-type-mismatch] 50 | int keyserver_import_cert (ctrl_t ctrl, const char *name, int dane_mode, | ^ test-stubs.c:205:1: note: type mismatch in parameter 2 205 | keyserver_import_cert (const char *name) | ^ test-stubs.c:205:1: note: 'keyserver_import_cert' was previously declared here keyserver-internal.h:44:5: warning: type of 'keyserver_import_keyid' does not match original declaration [-Wlto-type-mismatch] 44 | int keyserver_import_keyid (ctrl_t ctrl, u32 *keyid, | ^ test-stubs.c:184:1: note: type mismatch in parameter 3 184 | keyserver_import_keyid (u32 *keyid, void *dummy, unsigned int flags) | ^ test-stubs.c:184:1: note: 'keyserver_import_keyid' was previously declared here photoid.h:31:6: warning: type of 'show_photos' does not match original declaration [-Wlto-type-mismatch] 31 | void show_photos (ctrl_t ctrl, const struct user_attribute *attrs, int count, | ^ test-stubs.c:374:1: note: type mismatch in parameter 2 374 | show_photos (const struct user_attribute *attrs, int count, PKT_public_key *pk) | ^ test-stubs.c:374:1: note: 'show_photos' was previously declared here keyserver-internal.h:35:24: warning: type of 'parse_keyserver_uri' does not match original declaration [-Wlto-type-mismatch] 35 | struct keyserver_spec *parse_keyserver_uri (const char *string, | ^ test-stubs.c:356:1: note: type mismatch in parameter 3 356 | parse_keyserver_uri (const char *uri, int require_scheme, | ^ test-stubs.c:356:1: note: 'parse_keyserver_uri' was previously declared here keyserver-internal.h:60:5: warning: type of 'keyserver_import_ldap' does not match original declaration [-Wlto-type-mismatch] 60 | int keyserver_import_ldap (ctrl_t ctrl, const char *name, | ^ test-stubs.c:243:1: note: type mismatch in parameter 2 243 | keyserver_import_ldap (const char *name) | ^ test-stubs.c:243:1: note: 'keyserver_import_ldap' was previously declared here keyserver-internal.h:57:5: warning: type of 'keyserver_import_name' does not match original declaration [-Wlto-type-mismatch] 57 | int keyserver_import_name (ctrl_t ctrl, | ^ test-stubs.c:224:1: note: type mismatch in parameter 3 224 | keyserver_import_name (const char *name,struct keyserver_spec *spec) | ^ test-stubs.c:224:1: note: 'keyserver_import_name' was previously declared here keyserver-internal.h:50:5: warning: type of 'keyserver_import_cert' does not match original declaration [-Wlto-type-mismatch] 50 | int keyserver_import_cert (ctrl_t ctrl, const char *name, int dane_mode, | ^ test-stubs.c:205:1: note: type mismatch in parameter 2 205 | keyserver_import_cert (const char *name) | ^ test-stubs.c:205:1: note: 'keyserver_import_cert' was previously declared here keyserver-internal.h:44:5: warning: type of 'keyserver_import_keyid' does not match original declaration [-Wlto-type-mismatch] 44 | int keyserver_import_keyid (ctrl_t ctrl, u32 *keyid, | ^ test-stubs.c:184:1: note: type mismatch in parameter 3 184 | keyserver_import_keyid (u32 *keyid, void *dummy, unsigned int flags) | ^ test-stubs.c:184:1: note: 'keyserver_import_keyid' was previously declared here photoid.h:31:6: warning: type of 'show_photos' does not match original declaration [-Wlto-type-mismatch] 31 | void show_photos (ctrl_t ctrl, const struct user_attribute *attrs, int count, | ^ gpgv.c:617:1: note: type mismatch in parameter 2 617 | show_photos (const struct user_attribute *attrs, int count, PKT_public_key *pk) | ^ gpgv.c:617:1: note: 'show_photos' was previously declared here keyserver-internal.h:35:24: warning: type of 'parse_keyserver_uri' does not match original declaration [-Wlto-type-mismatch] 35 | struct keyserver_spec *parse_keyserver_uri (const char *string, | ^ gpgv.c:599:1: note: type mismatch in parameter 3 599 | parse_keyserver_uri (const char *uri, int require_scheme, | ^ gpgv.c:599:1: note: 'parse_keyserver_uri' was previously declared here keyserver-internal.h:60:5: warning: type of 'keyserver_import_ldap' does not match original declaration [-Wlto-type-mismatch] 60 | int keyserver_import_ldap (ctrl_t ctrl, const char *name, | ^ gpgv.c:485:1: note: type mismatch in parameter 2 485 | keyserver_import_ldap (const char *name) | ^ gpgv.c:485:1: note: 'keyserver_import_ldap' was previously declared here keyserver-internal.h:57:5: warning: type of 'keyserver_import_name' does not match original declaration [-Wlto-type-mismatch] 57 | int keyserver_import_name (ctrl_t ctrl, | ^ gpgv.c:466:1: note: type mismatch in parameter 3 466 | keyserver_import_name (const char *name,struct keyserver_spec *spec) | ^ gpgv.c:466:1: note: 'keyserver_import_name' was previously declared here keyserver-internal.h:50:5: warning: type of 'keyserver_import_cert' does not match original declaration [-Wlto-type-mismatch] 50 | int keyserver_import_cert (ctrl_t ctrl, const char *name, int dane_mode, | ^ gpgv.c:447:1: note: type mismatch in parameter 2 447 | keyserver_import_cert (const char *name) | ^ gpgv.c:447:1: note: 'keyserver_import_cert' was previously declared here keyserver-internal.h:44:5: warning: type of 'keyserver_import_keyid' does not match original declaration [-Wlto-type-mismatch] 44 | int keyserver_import_keyid (ctrl_t ctrl, u32 *keyid, | ^ gpgv.c:426:1: note: type mismatch in parameter 3 426 | keyserver_import_keyid (u32 *keyid, void *dummy, unsigned int flags) | ^ gpgv.c:426:1: note: 'keyserver_import_keyid' was previously declared here certchain.c:2123:1: note: in a call to function 'gpgsm_validate_chain' 2123 | gpgsm_validate_chain (ctrl_t ctrl, ksba_cert_t cert, ksba_isotime_t checktime, | ^ cvt-openpgp.h:27:13: warning: type of 'convert_from_openpgp_native' does not match original declaration [-Wlto-type-mismatch] 27 | gpg_error_t convert_from_openpgp_native (ctrl_t ctrl, | ^ t-protect.c:344:1: note: type mismatch in parameter 4 344 | convert_from_openpgp_native (gcry_sexp_t s_pgp, const char *passphrase, | ^ t-protect.c:344:1: note: 'convert_from_openpgp_native' was previously declared here
In this case it is not about don't consult the return code or casting sometning byt messy declaration in header files and .c files.
Please have look closer one more time on [-Wlto-type-mismatch] warnings.
Jun 27 2021
g10/getkey.c
Jun 26 2021
Thanks for the report. Fixed.
wk at gnupg dot org but better avoid any HTML parts etc.
Jun 25 2021
Thanks for the report.
Thank you, this is my great honor!
If it is convenient, can you provide an email address? So that I can elaborate to you.
Needs to be tested with the current 2.2 version and a gcry_log_debugsxp should be added to the error output.
This will not be fixed. Brainpool is a standard feature of Libgcrypt and thus this is a bug in the used Libgcrypt installation. Note that although I recently fixed a new regression test for this case, I do not think that it is a good idea to add extra code for a broken Libgcrypt.
This has been solved in 2.2.26 commit rGc75fd75532
That might depend on your pinentry version. With a pre-1.1.1 pinentry and 2.2.28 I get this:
Will be in 2.2.29.
Thanks. I added it to the list. If you have not yet done this I would suggest to write a note to gnupg-users.
We need to see how to best fix this regression test for all Python versions.
We should not support a different OID or representation of 22519 which will only lead to incompatibilities and trouble existing users. 25519 is in too widespread use than to allow for any changes.
FWIW: We have always refused to support shared mode because we anticipated such problems. However, we have a customer using their own cards along with card maintenance software of them. For their purposes PCSC_SHARED works just fine makes and this is why I decided to add --pcsc-shared along with a warning that it is in general not a good idea.
You need to protect only 2 critical set of ADPU sequence Sign and Decrypt. All other can be done not safely and have a minor impact. Get generation and cards unlock can be profitable with the transaction mode... but is very rare user makes another use of the card in same time he start that’s command. The check external interference can protect from a bad start. I have started this ticket because my card suffer in exclusive mode render the use of openpgp not really usable. When my card is an pcsc-shared mode, all it's OK but the daemon not able to restore after external interference. The correction proposed is OK but I have made recommendations because this can cause a bad applet switch... if the state does not restore before trying to switch applet all it's OK. I am not actually able to set directly differential code but I have described in the patch the change I have made and this make my card very happy. Not problems and the pin was queried if another application makes interference.
There are multiple issues here.