In T6966#189067, @ebo wrote:This is how the upper part of the "New Group" window looks with Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41):
It seems that, deviating from the task description, something else was implemented. And it's not even what Andre suggested in the comments but seemingly something inspired by it.
I do not like it.
I think that the color coding of suitable certificates is a no go for a11y. And it clashes with our color marking in VSD. Which in that case is a convenience only, that info is also available in a column. Instead of a tooltip in this case.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jul 29 2024
Jul 29 2024
• TobiasFella added a comment to T6966: Kleopatra: Show which certificates in a group are not usable for encryption.
• ikloecker added a comment to T6966: Kleopatra: Show which certificates in a group are not usable for encryption.
This task only dealt with the lower pane. It added the warning icon and the tool tip "This certificate cannot be used for encryption." For the upper pane see T6722.
• TobiasFella committed rKLEOPATRAd3f2b094b869: Improve wording of expiry dialog (authored by • TobiasFella).
Improve wording of expiry dialog
Adapt to feedback
Checked in Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41):
Looks ok to me.
Yes, we can phase it out in master which is what Nico is talking about and which uses Qt 6/KF6. Nobody is going to remove KIconLoader from KF5.
Daniel wrote a migration tool which was merged in January (https://invent.kde.org/pim/akonadi/-/merge_requests/154), i.e. a few weeks after he wrote the documentation. He foresaw that the documentation "will go out-of-date quickly". ;-)
• ebo changed the status of T6966: Kleopatra: Show which certificates in a group are not usable for encryption, a subtask of T6916: Kleopatra group related improvements, from Testing to Open.
• ebo changed the status of T6966: Kleopatra: Show which certificates in a group are not usable for encryption from Testing to Open.
• ebo updated subscribers of T6966: Kleopatra: Show which certificates in a group are not usable for encryption.
This is how the upper part of the "New Group" window looks with Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41):
Add i18n context
Add i18n context
• ikloecker triaged T7227: Kleopatra: Ensure columns are wide enough when they are made visible as Normal priority.
• ebo closed T7019: Kleopatra: change "certificate detailed view" to tabbed interface instead of sub-windows as Resolved.
The basic task is definitively done and looks good.
It is not clear if the improvement wishes commented later have consensus and they should be addressed in an new ticket, anyway.
• TobiasFella committed rLIBKLEO562baeb340b1: Fix context string for subkey validity (authored by • TobiasFella).
Fix context string for subkey validity
• ebo moved T6403: Kleopatra: Warn if a certificate in a group is deleted from QA to vsd-3.3.0 on the vsd33 board.
• ebo closed T6403: Kleopatra: Warn if a certificate in a group is deleted, a subtask of T6916: Kleopatra group related improvements, as Resolved.
• ebo updated the task description for T6403: Kleopatra: Warn if a certificate in a group is deleted.
Tested with Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41)
Btw. Here is a nice backtrace, which I think is similar to the crash part of this Task:
I think the crash in the end is the same we have in T6688: Kleopatra GPGME: Reported assert on exit where quitting kleopatra with running jobs tries to cancel all open contexts and then crashes where the assert would be triggered in debug builds. In T6688 we just hid this issue again by not keeping the deviceinfowatcher running.
Use @option:check
Use @option:check
l10n daemon script <scripty@kde.org> committed rLIBKLEOb1cb1d8a58f3: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rKLEOPATRA864dbd3d72e8: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
Jul 28 2024
Jul 28 2024
Volker Krause <vkrause@kde.org> committed rMTP929f47ad8c88: Port away from deprecated KMime API (authored by Volker Krause <vkrause@kde.org>).
Port away from deprecated KMime API
l10n daemon script <scripty@kde.org> committed rMTPac4cc3012728: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rMTP5b6efbe440fe: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rLIBKLEOd1bd20176a68: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rKLEOPATRA29bcf2b88b36: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
• aheinecke reassigned T6354: All VSD and GPD binaries need a proper product name on Windows. from • aheinecke to • werner.
Phew. Got it. a new script: "gccwrap.sh.in"
Jul 27 2024
Jul 27 2024
Well, so the documentation is that there is no way to migrate and you have to delete everything and then set it up manually again? In that case it is still missing the deletion of the KMail settings etc.
That fixed it.
• aheinecke closed T3516: Gpg4win: Version info for Kleopatra, a subtask of T3742: Gpg4win 3.1.0, as Resolved.
Fixing this is important for getting the next release out.
Is the QIcon API available in QT5 ? If not we can't phase that out.
GIT_SILENT: increase version
GIT_SILENT: increase version
GIT_SILENT: increase version
GIT_SILENT: use last version
Fix version
GIT_SILENT: prepare rc
GIT_SILENT: prepare rc
Thank you. With this patch the IBT flags are present on the shared object and CF protection test passes.
"rijndael-vaes-avx2-i386.S" should not be build for x86-64 but until now that has not had any affect as #ifdefs in that source file result empty object file on x86-64.
l10n daemon script <scripty@kde.org> committed rLIBKLEOa687102f6d6e: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rKLEOPATRA0140df6368ae: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rKLEOPATRA73dd8d76b58b: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rLIBKLEOa4228e17bcd3: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
Jul 26 2024
Jul 26 2024
GIT_SILENT: prepare rc
Thank you for having a look into this!
• TobiasFella committed rKLEOPATRAa0d904d31432: Improve wording of expiry dialog (authored by • TobiasFella).
Improve wording of expiry dialog
• TobiasFella committed rLIBKLEOdcf03c97cb37: Fix context string for subkey validity (authored by • TobiasFella).
Fix context string for subkey validity
• TobiasFella committed rKLEOPATRA32dea3b556d6: Fix removing icon from a key filter (authored by • TobiasFella).
Fix removing icon from a key filter
• TobiasFella committed rKLEOPATRA6f0601692a57: Show filters in the order that they're evaluated in (authored by • TobiasFella).
Show filters in the order that they're evaluated in
• TobiasFella committed rKLEOPATRA5d1d1bbe7b71: Reset to default style instead of "empty" style (authored by • TobiasFella).
Reset to default style instead of "empty" style
• werner triaged T7221: Disable -O flag munging when the libgcrypt is not compiled with rndjent as Low priority.
Not for a broken compiler but for several CC versions which consumed lots of memory for unrulling stuff. iirc, this was not only gcc.
• aheinecke updated the task description for T7214: Kleopatra: Dark mode detection problems on Windows 10 2016.
As shown in the above screenshots the fix was tested by me.
Here's patches for adding CET support to x86-64 and i386 assembly.
OpenBSD carries libgcrypt patch for CET which adds endbr64 instruction to CFI_STARTPROC() macro in "asm-common-amd64.h". We could do the same and also add endbr32 to i386 too. That would be easiest way to add required endbr instructions. OpenBSD also has patch for arm64 to add similar BTI instructions to aarch64 variant of CFI_STARTPROC.
• ebo moved T7082: Kleopatra: Improve initial column layout in smart card views from QA to vsd-3.3.0 on the vsd33 board.
With Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41) I see the expected result. The width for the additional columns is as expected too. So I'll mark this task as done.
• aheinecke triaged T7223: GpgOL: Handle Outlook settings which allow users to disable automatically marking mails as read as Normal priority.
jukivili added a comment to T7221: Disable -O flag munging when the libgcrypt is not compiled with rndjent.
There is -O flag munging for "tiger.o" in "cipher/Makefile.am", an old workaround for broken compiler I think. IMHO tiger.o case can and should be removed.
• aheinecke triaged T7222: pinentry-qt: On PKCS#12 import pinentry shows spaces with pinentry-formatted-passphrase as Normal priority.
OpenBSD carries libgcrypt patch for CET which adds endbr64 instruction to CFI_STARTPROC() macro in "asm-common-amd64.h". We could do the same and also add endbr32 to i386 too. That would be easiest way to add required endbr instructions. OpenBSD also has patch for arm64 to add similar BTI instructions to aarch64 variant of CFI_STARTPROC.
l10n daemon script <scripty@kde.org> committed rLIBKLEOcc78037c2b50: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rKLEOPATRA88c57ae9b11d: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rLIBKLEOb0f32f4ed20d: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
l10n daemon script <scripty@kde.org> committed rKLEOPATRA667f0e41c9ba: GIT_SILENT Sync po/docbooks with svn (authored by l10n daemon script <scripty@kde.org>).
GIT_SILENT Sync po/docbooks with svn
Jul 25 2024
Jul 25 2024
Interesting. i'm also not sure this is a good feature. I also still don't think the gpgv man page explains this clearly, but if you don't want to clarify it, i won't bother re-opening this issue.
CarlSchwan committed rKLEOPATRA07bf7952f679: Use QString::arg with multiple argument (authored by CarlSchwan).
Use QString::arg with multiple argument
CarlSchwan committed rKLEOPATRAbc0c7b165ac3: CertificateRequester: Expose NOTIFY signal in properties (authored by CarlSchwan).
CertificateRequester: Expose NOTIFY signal in properties
CarlSchwan committed rKLEOPATRAc5202b8d5d63: SignEncryptTask: Use new connect syntax (authored by CarlSchwan).
SignEncryptTask: Use new connect syntax
CarlSchwan committed rKLEOPATRAdd8036ca0c32: Avoid detaching by iterating over temporary or non const variables (authored by CarlSchwan).
Avoid detaching by iterating over temporary or non const variables
CarlSchwan committed rKLEOPATRA111057c90cbb: Use Q_EMIT when trigerring signal (authored by CarlSchwan).
Use Q_EMIT when trigerring signal
CarlSchwan committed rKLEOPATRAe76da0ac17d2: KWatchGnuPGMainWin: Use modern connect syntax (authored by CarlSchwan).
KWatchGnuPGMainWin: Use modern connect syntax
• ebo moved T7020: Kleopatra: add "Smart Card" tab to certificate detail view from WiP to QA on the vsd33 board.
• ebo moved T6403: Kleopatra: Warn if a certificate in a group is deleted from WiP to QA on the vsd33 board.
• ebo moved T6966: Kleopatra: Show which certificates in a group are not usable for encryption from WiP to QA on the vsd33 board.
• ebo moved T7082: Kleopatra: Improve initial column layout in smart card views from WiP to QA on the vsd33 board.
• ebo moved T7128: Kleopatra: make details clear for keys with multiple locations from WiP to QA on the vsd33 board.
• ebo moved T7080: Kleopatra: Restoring column layout in smart card views doesn't work from WiP to vsd-3.3.0 on the vsd33 board.
• ebo closed T7080: Kleopatra: Restoring column layout in smart card views doesn't work as Resolved.
Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41):
works as described with pkcs#15 and netkey cards.
(The column width is then the same for those cards)
• TobiasFella committed rKLEOPATRAd4a5207d4a2a: Reset to default style instead of "empty" style (authored by • TobiasFella).
Reset to default style instead of "empty" style
• TobiasFella committed rKLEOPATRA2d22d7f609b3: Show filters in the order that they're evaluated in (authored by • TobiasFella).
Show filters in the order that they're evaluated in
• TobiasFella committed rKLEOPATRA64e92fa7b6a2: Fix removing icon from a key filter (authored by • TobiasFella).
Fix removing icon from a key filter